]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agorgw/tracing: unify SO version numbers within librgw2 package 43600/head
Nathan Cutler [Wed, 20 Oct 2021 10:51:02 +0000 (12:51 +0200)]
rgw/tracing: unify SO version numbers within librgw2 package

The librgw2 package contains several SO files. Two of those - librgw_op_tp.so
and librgw_rados_tp.so - had a different version number than the main librgw.

This was a violation of the openSUSE Shared Library Packaging Policy [1] but it
also seems like a "violation" of common sense.

[1] https://en.opensuse.org/openSUSE:Shared_library_packaging_policy#Package_naming

Fixes: https://tracker.ceph.com/issues/52979
Signed-off-by: Nathan Cutler <ncutler@suse.com>
3 years agoMerge pull request #42772 from Daniel-Pivonka/cephadm-add-existing-host
Sebastian Wagner [Wed, 20 Oct 2021 09:49:33 +0000 (11:49 +0200)]
Merge pull request #42772 from Daniel-Pivonka/cephadm-add-existing-host

mgr/cephadm: update host when adding host that already exists

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43354 from adk3798/daemon-failed-agent
Sebastian Wagner [Wed, 20 Oct 2021 09:48:42 +0000 (11:48 +0200)]
Merge pull request #43354 from adk3798/daemon-failed-agent

mgr/cephadm: update CEPHADM_FAILED_DAEMON after receiving agent metadata

Reviewed-by: Daniel Pivonka <dpivonka@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43366 from adk3798/log-list-servers
Sebastian Wagner [Wed, 20 Oct 2021 09:48:09 +0000 (11:48 +0200)]
Merge pull request #43366 from adk3798/log-list-servers

mgr/cephadm: put list_servers output in debug logs

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43367 from adk3798/handle-use-agent
Sebastian Wagner [Wed, 20 Oct 2021 09:47:41 +0000 (11:47 +0200)]
Merge pull request #43367 from adk3798/handle-use-agent

mgr/cephadm: move handling of use_agent setting into agent.py

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43489 from adk3798/clear-agent-down
Sebastian Wagner [Wed, 20 Oct 2021 09:46:17 +0000 (11:46 +0200)]
Merge pull request #43489 from adk3798/clear-agent-down

mgr/cephadm: update CEPHADM_AGENT_DOWN when agent reports in

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43552 from adk3798/dont-log-credentials
Sebastian Wagner [Wed, 20 Oct 2021 09:45:29 +0000 (11:45 +0200)]
Merge pull request #43552 from adk3798/dont-log-credentials

cephadm: do not log commands sent to "call" function

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43592 from rzarzynski/wip-crimson-mount_ertr
Samuel Just [Wed, 20 Oct 2021 04:55:23 +0000 (21:55 -0700)]
Merge pull request #43592 from rzarzynski/wip-crimson-mount_ertr

crimson: errorate the FuturizedStore::mount() paths.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #42839 from giladmaya/wip-on-wire-compression-documentation
Neha Ojha [Tue, 19 Oct 2021 21:55:16 +0000 (14:55 -0700)]
Merge pull request #42839 from giladmaya/wip-on-wire-compression-documentation

doc: Added msgr on-wire-compression

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43577 from ThomasLamprecht/docs-glossary-typo
Neha Ojha [Tue, 19 Oct 2021 21:54:10 +0000 (14:54 -0700)]
Merge pull request #43577 from ThomasLamprecht/docs-glossary-typo

docs: fix case and spelling of Proxmox VE

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agocrimson: errorate the FuturizedStore::mount() paths. 43592/head
Radoslaw Zarzynski [Tue, 19 Oct 2021 20:02:57 +0000 (20:02 +0000)]
crimson: errorate the FuturizedStore::mount() paths.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge PR #43556 into master
Sage Weil [Tue, 19 Oct 2021 20:04:36 +0000 (16:04 -0400)]
Merge PR #43556 into master

* refs/pull/43556/head:
qa/suites/orch/cephadm/osds: add osd rm/zap/add test

Reviewed-by: Cory Snyder <csnyder@iland.com>
3 years agocrimson/os: move singleton_ec up to let mount() reuse it.
Radoslaw Zarzynski [Tue, 19 Oct 2021 19:24:47 +0000 (19:24 +0000)]
crimson/os: move singleton_ec up to let mount() reuse it.

No other changes in this commit.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge PR #43569 into master
Sage Weil [Tue, 19 Oct 2021 14:58:31 +0000 (10:58 -0400)]
Merge PR #43569 into master

* refs/pull/43569/head:
mgr/orchestrator: clean up 'orch device ls' output

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43486 from cbodley/wip-rgw-maintainers
Casey Bodley [Tue, 19 Oct 2021 12:53:01 +0000 (08:53 -0400)]
Merge pull request #43486 from cbodley/wip-rgw-maintainers

rgw: start on MAINTAINERS.md

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #43514 from mgfritch/cephadm-agent-binary
Sebastian Wagner [Tue, 19 Oct 2021 11:33:43 +0000 (13:33 +0200)]
Merge pull request #43514 from mgfritch/cephadm-agent-binary

cephadm: use the current cephadm binary for the agent

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #43465 from rhcs-dashboard/radosgw-grafana-dashboards
Ernesto Puerta [Tue, 19 Oct 2021 11:30:06 +0000 (13:30 +0200)]
Merge pull request #43465 from rhcs-dashboard/radosgw-grafana-dashboards

mgr/dashboard: monitoring: grafonnet refactoring for radosgw dashboards

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43370 from liewegas/fix-rook-rgw-multisite
Sebastian Wagner [Tue, 19 Oct 2021 09:34:46 +0000 (11:34 +0200)]
Merge pull request #43370 from liewegas/fix-rook-rgw-multisite

mgr/rook: describe_services: name rgw svc appropriately

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43550 from liewegas/rook-nvme
Sebastian Wagner [Tue, 19 Oct 2021 09:30:40 +0000 (11:30 +0200)]
Merge pull request #43550 from liewegas/rook-nvme

qa/suites/orch/rook/smoke: use nvme-loop

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #42526 from liewegas/dashboard-nfs
Ernesto Puerta [Tue, 19 Oct 2021 09:17:17 +0000 (11:17 +0200)]
Merge pull request #42526 from liewegas/dashboard-nfs

mgr/dashboard: consume mgr/nfs

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agomgr/dashboard: monitoring: grafonnet refactoring for cephfs dashboards 43465/head
Aashish Sharma [Fri, 8 Oct 2021 10:07:17 +0000 (15:37 +0530)]
mgr/dashboard: monitoring: grafonnet refactoring for cephfs dashboards

This PR intends to refactor cephfs dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agomgr/dashboard: monitoring: grafonnet refactoring for osds dashboards
Aashish Sharma [Fri, 8 Oct 2021 09:58:13 +0000 (15:28 +0530)]
mgr/dashboard: monitoring: grafonnet refactoring for osds dashboards

This PR intends to refactor osds dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agomgr/dashboard: monitoring: grafonnet refactoring for pools dashboards
Aashish Sharma [Fri, 8 Oct 2021 09:52:46 +0000 (15:22 +0530)]
mgr/dashboard: monitoring: grafonnet refactoring for pools dashboards

This PR intends to refactor pools dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agomgr/dashboard: monitoring: grafonnet refactoring for rbd dashboards
Aashish Sharma [Fri, 8 Oct 2021 09:42:41 +0000 (15:12 +0530)]
mgr/dashboard: monitoring: grafonnet refactoring for rbd dashboards

This PR intends to refactor rbd dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agomgr/dashboard: monitoring: grafonnet refactoring for radosgw dashboards
Aashish Sharma [Fri, 8 Oct 2021 09:30:09 +0000 (15:00 +0530)]
mgr/dashboard: monitoring: grafonnet refactoring for radosgw dashboards

This PR intends to refactor radosgw dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agoqa/suites/orch/cephadm/osds: add osd rm/zap/add test 43556/head
Sage Weil [Thu, 14 Oct 2021 20:00:09 +0000 (15:00 -0500)]
qa/suites/orch/cephadm/osds: add osd rm/zap/add test

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge PR #43504 into master
Sage Weil [Mon, 18 Oct 2021 19:03:33 +0000 (15:03 -0400)]
Merge PR #43504 into master

* refs/pull/43504/head:
mgr/nfs: add some test coverage for cluster info, cluster config
mgr/nfs: add 'nfs cluster config get'

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43510 into master
Sage Weil [Mon, 18 Oct 2021 19:03:24 +0000 (15:03 -0400)]
Merge PR #43510 into master

* refs/pull/43510/head:
qa/suites/orch/cephadm/upgrade: smoke test for 'orch upgrade ls'
mgr/cephadm: make upgrade ls output structured
mgr/cephadm: add 'orch upgrade ls' to list available versions

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge PR #43549 into master
Sage Weil [Mon, 18 Oct 2021 17:56:39 +0000 (13:56 -0400)]
Merge PR #43549 into master

* refs/pull/43549/head:
mgr/rook: fix mds service list

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agorgw: add src/rgw/MAINTAINERS.md 43486/head
Casey Bodley [Mon, 11 Oct 2021 14:42:34 +0000 (10:42 -0400)]
rgw: add src/rgw/MAINTAINERS.md

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #43469 from rhcs-dashboard/hosts-grafana-dashboards
Ernesto Puerta [Mon, 18 Oct 2021 15:14:03 +0000 (17:14 +0200)]
Merge pull request #43469 from rhcs-dashboard/hosts-grafana-dashboards

mgr/dashboard: monitoring: grafonnet refactoring for hosts dashboards

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoqa/suites/orch/cephadm/upgrade: smoke test for 'orch upgrade ls' 43510/head
Sage Weil [Fri, 15 Oct 2021 15:58:41 +0000 (11:58 -0400)]
qa/suites/orch/cephadm/upgrade: smoke test for 'orch upgrade ls'

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #42760 from ideepika/wip-iscsi-testing
Ilya Dryomov [Mon, 18 Oct 2021 12:25:36 +0000 (14:25 +0200)]
Merge pull request #42760 from ideepika/wip-iscsi-testing

qa/suites/rbd: switch iscsi tests to cephadm

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #43564 from sebastian-philipp/doc-cephadm-host-location
Sebastian Wagner [Mon, 18 Oct 2021 11:58:55 +0000 (13:58 +0200)]
Merge pull request #43564 from sebastian-philipp/doc-cephadm-host-location

doc/cephadm: Hosts: Add "initial CRUSH location"

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agomgr/dashboard: NFS exports: API + UI: integration with mgr/nfs; cleanups 42526/head
Alfonso Martínez [Thu, 26 Aug 2021 10:05:54 +0000 (12:05 +0200)]
mgr/dashboard: NFS exports: API + UI: integration with mgr/nfs; cleanups

mgr/dashboard: move NFS_GANESHA_SUPPORTED_FSALS to mgr_module.py

Importing from nfs module throws AttributeError because as a side effect the dashboard module is impersonating the nfs module.
https://gist.github.com/varshar16/61ac26426bbe5f5f562ebb14bcd0f548

mgr/dashboard: 'Create NFS export' form: list clusters from nfs module

mgr/dashboard: frontend+backend cleanups for NFS export

Removed all code and references related to daemons. UI cleanup and adopted unit-testing for
nfs-epxort create form for CEPHFS backend. Cleanup for export list/get/create/set/delete endpoints.

mgr/dashboard: rm set-ganesha ref + update docs

Remove existing set-ganesha-clusters-rados-pool-namespace references as
they are no longer required. Moreover, nfs doc in dashboard doc is
updated accordingly to the current nfs status.

mgr/dashboard: add nfs-export e2e test coverage

mgr/dashboard: 'Create NFS export' form: remove RGW user id field.

- Improve bucket typeahead behavior.
- Increase version for bucket list endpoint.
- Some refactoring.

mgr/dashboard: 'Create NFS export' form: allow RGW backend only when default realm is selected.

When RGW multisite is configured, the NFS module can only handle buckets in the default realm.

mgr/dashboard: 'Create service' form: fix NFS service creation.

After https://github.com/ceph/ceph/pull/42073, NFS pool and namespace are not customizable.

mgr/dashboard: 'Create NFS export' form: add bucket validation.

- Allow only existing buckets.
- Refactoring:
  - Moved bucket validator from bucket form to cd-validators.ts
  - Split bucket validator into 2: bucket name validator and bucket existence (that checks either existence or non-existence).

mgr/dashboard: 'Create NFS export' form: path validation refactor: allow only existing paths.

Fixes: https://tracker.ceph.com/issues/46493
Fixes: https://tracker.ceph.com/issues/51479
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agodocs: fix case and spelling of Proxmox VE 43577/head
Thomas Lamprecht [Mon, 18 Oct 2021 10:10:24 +0000 (12:10 +0200)]
docs: fix case and spelling of Proxmox VE

There's no such thing as ProxMox, the hypervisor product with build
in ceph server management and RBD client access is named `Proxmox VE`
and the company behind it is named Proxmox Server Solutions GmbH

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agomgr/dashboard: directly use ExportMgr and NFSCluster objects
Varsha Rao [Mon, 9 Aug 2021 19:00:16 +0000 (00:30 +0530)]
mgr/dashboard: directly use ExportMgr and NFSCluster objects

Using the objects directly provides access to other methods and helps in
avoiding repeatition.

mgr/dashboard/nfsganesha: remove tag

Since NFS v3 is no longer supported. We can remove tag.

mgr/nfs: define global constant to list supported FSALs

mgr/dashboard: directly list nfs clusters by directly importing available_cluster() method

The current dashboard api returns a list of following dictionary

{
   'pool': 'nfs-ganesha',
   'namespace': cluster_id,
   'type': 'orchestrator',
   'daemon_conf': None
}

None of these values are required for listing nfs cluster by mgr/nfs module.
Instead directly list available cluster names

mgr/dashboard: add comment to remove listing of daemons

As the configs are per cluster. There is no need to list daemons per cluster.

mgr/dashboard/controllers/nfsganesha: Add comments to update/remove status endpoint

This endpoint can be updated in suggested way or even removed. As it was
initially[1] introduced to check if dashboard pool and namespace configuration was
set.

[1] https://github.com/ceph/ceph/commit/824726393b185b8e5a8f17e66487dfde9f3c8b5c

mgr/nfs: remove fetch_cluster_obj()

There is no need to fetch NFSCluster class object. Directly
available_clusters() can be imported to list nfs clusters.

mgr/dashboard/controllers/nfsganesha: list exports based on cluster id

As mgr/nfs module lists based on cluster id.

mgr/dashboard/nfs: get and delete export by export id

Fixes: https://tracker.ceph.com/issues/46493
Signed-off-by: Varsha Rao <varao@redhat.com>
3 years agomgr/dashboard: consume mgr/nfs via mgr.remote()
Sage Weil [Wed, 28 Jul 2021 14:29:47 +0000 (10:29 -0400)]
mgr/dashboard: consume mgr/nfs via mgr.remote()

Stop using the dashboard version of the Ganesha config classes; consume
mgr/nfs instead via remote().

mgr/nfs/export: return Export from _apply_export

Future callers will want this.

mgr/nfs: new module methods for dashboard consumption

Add some new methods that are easy for the dashboard API to consume.  These
are very similar to the CLI methods but do now have the @CLICommand and
related decorators, and have slightly different interfaces (e.g., returning
the created/modified Export dict).

mgr/dashboard: remove old ganesha code (and tests)

Fixes: https://tracker.ceph.com/issues/46493
Signed-off-by: Sage Weil <sage@newdream.net>
3 years agosrc/test/cli-integration: correct hostname for iscsi gateway 42760/head
Deepika Upadhyay [Thu, 14 Oct 2021 07:10:14 +0000 (12:40 +0530)]
src/test/cli-integration: correct hostname for iscsi gateway

iscsi accepts first word of hostname as local hostname[0] instead of
smithi061.front.sepia.ceph.com we use: smithi061 otherwise gateway
creation will error out with:
```The first gateway defined must be the local machine```

[0] https://github.com/ceph/ceph-iscsi-cli/blob/ff3e430b70a62257a560b8988bd54bf845c01fb7/gwcli/utils.py#L36

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agosrc/test/cli-integration/rbd: update gwcli_* to use podman exec
Deepika Upadhyay [Wed, 13 Oct 2021 06:30:38 +0000 (12:00 +0530)]
src/test/cli-integration/rbd: update gwcli_* to use podman exec

* since iscsi now resides inside the container, for testing we use the
  hack:
  - find the iscsi container/
  - use found container and podman exec command to test gateway creation
    deletion from host itself

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoqa/tasks: adapt ceph_iscsi.py task to ceph_iscsi_client
Deepika Upadhyay [Wed, 13 Oct 2021 06:19:02 +0000 (11:49 +0530)]
qa/tasks: adapt ceph_iscsi.py task to ceph_iscsi_client

* we use setup_iscsi_client.py to deploy iscsi client services,
  configuring intiator and mulitpath this is done by qa task
  ceph_iscsi_client
* qa/cephadm: adds remotes ip addresses to iscsi gateway,
* rename poolname: iscsi >> datapool, which we usually use for tests and
  expresses type of pool more clearly.

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoqa/suites/rbd: remove baremetal based setup needed for iscsi testing
Deepika Upadhyay [Wed, 13 Oct 2021 06:17:11 +0000 (11:47 +0530)]
qa/suites/rbd: remove baremetal based setup needed for iscsi testing

* replace ceph baremetal deployment with cephadm based deployment

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agodoc: add iSCSI initiator client configuration section for cephadm
Deepika Upadhyay [Wed, 13 Oct 2021 06:03:39 +0000 (11:33 +0530)]
doc: add iSCSI initiator client configuration section for cephadm

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agodoc added msgr on-wire-compression 42839/head
Maya Gilad [Mon, 13 Sep 2021 17:11:39 +0000 (20:11 +0300)]
doc added msgr on-wire-compression

Signed-off-by: Maya Gilad <ms.maya.gilad@gmail.com>
3 years agoMerge pull request #43571 from tchaikov/wip-bl-prepare-iovs
Kefu Chai [Sat, 16 Oct 2021 02:57:05 +0000 (10:57 +0800)]
Merge pull request #43571 from tchaikov/wip-bl-prepare-iovs

common/bl: bl::prepare_iovs() related cleanups

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocommon/bl: mark bl::prepare_iovs() const 43571/head
Kefu Chai [Sat, 16 Oct 2021 00:31:08 +0000 (08:31 +0800)]
common/bl: mark bl::prepare_iovs() const

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocommon/bl: simplify bl::prepare_iovs()
Kefu Chai [Fri, 15 Oct 2021 23:58:50 +0000 (07:58 +0800)]
common/bl: simplify bl::prepare_iovs()

* consolidate the code to initialize a vector<iov>
* use an iterator to track the current vector<iovec>. less
  repeating this way.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocommon/bl: define iov_vec_t using a dedicated struct
Kefu Chai [Fri, 15 Oct 2021 23:48:55 +0000 (07:48 +0800)]
common/bl: define iov_vec_t using a dedicated struct

more readable this way

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocommon/bl: move bl::prepare_iovs() to .cc file
Kefu Chai [Fri, 15 Oct 2021 23:35:21 +0000 (07:35 +0800)]
common/bl: move bl::prepare_iovs() to .cc file

to reduce the compilation time by having a smaller header file.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43478 from anthonyeleven/anthonyeleven/fix-52830
Anthony D'Atri [Fri, 15 Oct 2021 22:34:30 +0000 (15:34 -0700)]
Merge pull request #43478 from anthonyeleven/anthonyeleven/fix-52830

common/options: document rgw_lc_debug_interval configuration option

3 years agoMerge pull request #43537 from xxhdx1985126/wip-seastore-iov-max
Samuel Just [Fri, 15 Oct 2021 22:04:22 +0000 (15:04 -0700)]
Merge pull request #43537 from xxhdx1985126/wip-seastore-iov-max

crimson/os/seastore: deal with scenarios in which bufferlist of do_writev has more than IOV_MAX buffers

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agomgr/orchestrator: clean up 'orch device ls' output 43569/head
Sage Weil [Tue, 3 Aug 2021 17:25:26 +0000 (13:25 -0400)]
mgr/orchestrator: clean up 'orch device ls' output

- headings in CAPS
- DEVICE ID, not just serial or model/vendor
- drop the health, LED fields from non-wide view
- sort devices
- 'Yes' or '', for easier visual parsing

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43507 from cbodley/wip-rgw-log-spam
Casey Bodley [Fri, 15 Oct 2021 18:05:05 +0000 (14:05 -0400)]
Merge pull request #43507 from cbodley/wip-rgw-log-spam

rgw: hide some unnecessary log spam

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #43488 from cbodley/wip-52873
Casey Bodley [Fri, 15 Oct 2021 18:04:13 +0000 (14:04 -0400)]
Merge pull request #43488 from cbodley/wip-52873

radosgw-admin: 'reshard list' doesn't log ENOENT errors

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #43428 from cfsnyder/wip-52818-random-rgw-req-id
Casey Bodley [Fri, 15 Oct 2021 18:03:37 +0000 (14:03 -0400)]
Merge pull request #43428 from cfsnyder/wip-52818-random-rgw-req-id

rgw/rgw_rados: make RGW request IDs non-deterministic

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #42981 from mkogan1/rgw-d3n-fix-lru-exp
Casey Bodley [Fri, 15 Oct 2021 18:02:26 +0000 (14:02 -0400)]
Merge pull request #42981 from mkogan1/rgw-d3n-fix-lru-exp

rgw: d3n: fix d3n cached objects on disk lru eviction entering infini…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #42208 from BryceCao/wip-add-return-when-access-key-exist-in-subus...
Casey Bodley [Fri, 15 Oct 2021 18:01:58 +0000 (14:01 -0400)]
Merge pull request #42208 from BryceCao/wip-add-return-when-access-key-exist-in-subuser-create

rgw : add return when access key exist in subuser create

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #40144 from hualongfeng/osd_compression_bypass
Casey Bodley [Fri, 15 Oct 2021 17:59:58 +0000 (13:59 -0400)]
Merge pull request #40144 from hualongfeng/osd_compression_bypass

rgw: osd compression bypass after rgw compression

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agocommon/options: document rgw_lc_debug_interval configuration option 43478/head
Anthony D'Atri [Sun, 10 Oct 2021 20:25:00 +0000 (13:25 -0700)]
common/options: document rgw_lc_debug_interval configuration option

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #43533 from tchaikov/wip-cmake-less-chatty
Kefu Chai [Fri, 15 Oct 2021 16:10:32 +0000 (00:10 +0800)]
Merge pull request #43533 from tchaikov/wip-cmake-less-chatty

cmake: only pass --verbose when VERBOSE env variable is set

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agorgw: silence error message for nonexistent realm 43507/head
Casey Bodley [Fri, 15 Oct 2021 15:57:13 +0000 (11:57 -0400)]
rgw: silence error message for nonexistent realm

in a normal vstart cluster without a realm or period, every command
prints this error message:

0 RGWPeriod::init failed to init realm  id  : (2) No such file or directory

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge PR #43558 into master
Sage Weil [Fri, 15 Oct 2021 15:48:29 +0000 (11:48 -0400)]
Merge PR #43558 into master

* refs/pull/43558/head:
doc/governance.rst: update clt membership

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
3 years agoMerge PR #43430 into master
Patrick Donnelly [Fri, 15 Oct 2021 15:16:25 +0000 (11:16 -0400)]
Merge PR #43430 into master

* refs/pull/43430/head:
qa: skip c-v install on pacific start

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge PR #43426 into master
Patrick Donnelly [Fri, 15 Oct 2021 15:15:41 +0000 (11:15 -0400)]
Merge PR #43426 into master

* refs/pull/43426/head:
qa/cephfs: update xfstests_dev for centos stream

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43425 into master
Patrick Donnelly [Fri, 15 Oct 2021 15:13:55 +0000 (11:13 -0400)]
Merge PR #43425 into master

* refs/pull/43425/head:
qa: import CommandFailedError from exceptions not run

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
3 years agoMerge PR #43420 into master
Patrick Donnelly [Fri, 15 Oct 2021 15:13:05 +0000 (11:13 -0400)]
Merge PR #43420 into master

* refs/pull/43420/head:
qa: skip internal metadata directory when scanning ceph debugfs directory

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43382 into master
Patrick Donnelly [Fri, 15 Oct 2021 15:11:48 +0000 (11:11 -0400)]
Merge PR #43382 into master

* refs/pull/43382/head:
mds: skip journaling blocklisted clients when in `replay` state

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agomgr/cephadm: make upgrade ls output structured
Sage Weil [Fri, 15 Oct 2021 15:09:07 +0000 (11:09 -0400)]
mgr/cephadm: make upgrade ls output structured

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43120 from dang/wip-dang-user-load-attrs
Daniel Gryniewicz [Fri, 15 Oct 2021 15:02:18 +0000 (11:02 -0400)]
Merge pull request #43120 from dang/wip-dang-user-load-attrs

RGW Zipper - load user attributes with user

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agodoc/cephadm: Hosts: Add "initial CRUSH location" 43564/head
Sebastian Wagner [Fri, 15 Oct 2021 11:13:02 +0000 (13:13 +0200)]
doc/cephadm: Hosts: Add "initial CRUSH location"

Followup on d2a9a35993

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #31909 from rosinL/wip-fix-dpdk-cond-wait
Kefu Chai [Fri, 15 Oct 2021 11:25:55 +0000 (19:25 +0800)]
Merge pull request #31909 from rosinL/wip-fix-dpdk-cond-wait

msg/async/dpdk: exit condition waiting when DPDKStack is destructed

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agocrimson/os/seastore: deal with scenarios in which bufferlist of do_writev has more... 43537/head
Xuehan Xu [Thu, 14 Oct 2021 09:43:23 +0000 (17:43 +0800)]
crimson/os/seastore: deal with scenarios in which bufferlist of do_writev has more than IOV_MAX buffers

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agomsg/async/dpdk: exit condition waiting when DPDKStack is destructed 31909/head
Chunsong Feng [Wed, 20 Nov 2019 01:42:11 +0000 (09:42 +0800)]
msg/async/dpdk: exit condition waiting when DPDKStack is destructed

exit() will call pthread_cond_destroy attempting to destroy dpdk::eal::cond
upon which other threads are currently blocked results in undefine
behavior. Link different libc version test, libc-2.17 can exit,
libc-2.27 will deadlock, the call stack is as follows:

Thread 3 (Thread 0xffff7e5749f0 (LWP 62213)):
 #0  0x0000ffff7f3c422c in futex_wait_cancelable (private=<optimized out>, expected=0,
    futex_word=0xaaaadc0e30f4 <dpdk::eal::cond+44>) at ../sysdeps/unix/sysv/linux/futex-internal.h:88
 #1  __pthread_cond_wait_common (abstime=0x0, mutex=0xaaaadc0e30f8 <dpdk::eal::lock>, cond=0xaaaadc0e30c8 <dpdk::eal::cond>)
    at pthread_cond_wait.c:502
 #2  __pthread_cond_wait (cond=0xaaaadc0e30c8 <dpdk::eal::cond>, mutex=0xaaaadc0e30f8 <dpdk::eal::lock>)
    at pthread_cond_wait.c:655
 #3  0x0000ffff7f1f1f80 in std::condition_variable::wait(std::unique_lock<std::mutex>&) ()
   from /usr/lib/aarch64-linux-gnu/libstdc++.so.6
 #4  0x0000aaaad37f5078 in dpdk::eal::<lambda()>::operator()(void) const (__closure=<optimized out>, __closure=<optimized out>)
    at ./src/msg/async/dpdk/dpdk_rte.cc:136
 #5  0x0000ffff7f1f7ed4 in ?? () from /usr/lib/aarch64-linux-gnu/libstdc++.so.6
 #6  0x0000ffff7f3be088 in start_thread (arg=0xffffe73e197f) at pthread_create.c:463
 #7  0x0000ffff7efc74ec in thread_start () at ../sysdeps/unix/sysv/linux/aarch64/clone.S:78

Thread 1 (Thread 0xffff7ee3b010 (LWP 62200)):
 #0  0x0000ffff7f3c3c38 in futex_wait (private=<optimized out>, expected=12, futex_word=0xaaaadc0e30ec <dpdk::eal::cond+36>)
    at ../sysdeps/unix/sysv/linux/futex-internal.h:61
 #1  futex_wait_simple (private=<optimized out>, expected=12, futex_word=0xaaaadc0e30ec <dpdk::eal::cond+36>)
    at ../sysdeps/nptl/futex-internal.h:135
 #2  __pthread_cond_destroy (cond=0xaaaadc0e30c8 <dpdk::eal::cond>) at pthread_cond_destroy.c:54
 #3  0x0000ffff7ef2be34 in __run_exit_handlers (status=-6, listp=0xffff7f04a5a0 <__exit_funcs>, run_list_atexit=255,
    run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
 #4  0x0000ffff7ef2bf6c in __GI_exit (status=<optimized out>) at exit.c:139
 #5  0x0000ffff7ef176e4 in __libc_start_main (main=0x0, argc=0, argv=0x0, init=<optimized out>, fini=<optimized out>,
    rtld_fini=<optimized out>, stack_end=<optimized out>) at ../csu/libc-start.c:344
 #6  0x0000aaaad2939db0 in _start () at ./src/include/buffer.h:642

Fixes: https://tracker.ceph.com/issues/42890
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Signed-off-by: luo rixin <luorixin@huawei.com>
3 years agoMerge pull request #43555 from tchaikov/wip-dashboard-tsconfig
Kefu Chai [Fri, 15 Oct 2021 08:07:36 +0000 (16:07 +0800)]
Merge pull request #43555 from tchaikov/wip-dashboard-tsconfig

mgr/dashboard: s/hosts.clickHostTab/hosts.clickTab/

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: s/hosts.clickHostTab/hosts.clickTab/ 43555/head
Kefu Chai [Thu, 14 Oct 2021 22:44:55 +0000 (06:44 +0800)]
mgr/dashboard: s/hosts.clickHostTab/hosts.clickTab/

this change is a follow-up fix of
3276147049511a9a8d45d84c95154a4ec014cd83

otherwise we have following test failure:

[lint:tsc     ] cypress/integration/orchestrator/01-hosts.e2e-spec.ts(29,13): error TS2339: Property 'clickHostTab' does not exist on type 'HostsPageHelper'.

also change "host" to "hostname" to be more consistent

Fixes: https://tracker.ceph.com/issues/52645
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocommon: add prepare_iovs to bufferlist
Xuehan Xu [Fri, 15 Oct 2021 05:42:41 +0000 (13:42 +0800)]
common: add prepare_iovs to bufferlist

Enable bufferlist that have more than IOV_MAX buffers to build a vector of iov.

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/common: extract parallel_for_each into errorator-loop.h
Xuehan Xu [Thu, 14 Oct 2021 09:41:18 +0000 (17:41 +0800)]
crimson/common: extract parallel_for_each into errorator-loop.h

otherwise, crimson::errorator<AllowedErrors...>::parallel_for_each would be
referencing incomplete crimson::parallel_for_each_state type

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agorgw: osd compression bypass after rgw compression 40144/head
Feng Hualong [Tue, 10 Aug 2021 08:22:33 +0000 (16:22 +0800)]
rgw: osd compression bypass after rgw compression

In particular, when rgw is itself doing compression,
rgw should send a incompressible hint to OSD.
Because the OSD has little effect on the data
compressed in the condition. So there bypassing the
osd compression is to avoid repeated compression
calculation.

Signed-off-by: Feng Hualong <hualong.feng@intel.com>
3 years agoMerge pull request #43554 from athanatos/sjust/wip-block-segment-manager-sync
Kefu Chai [Fri, 15 Oct 2021 02:09:52 +0000 (10:09 +0800)]
Merge pull request #43554 from athanatos/sjust/wip-block-segment-manager-sync

crimson/os/seastore/segment_manager/block: open with dsync

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agodoc/governance.rst: update clt membership 43558/head
Josh Durgin [Fri, 15 Oct 2021 00:52:50 +0000 (20:52 -0400)]
doc/governance.rst: update clt membership

This now matches the mailing list which Sage audited.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge PR #43333 into master
Sage Weil [Fri, 15 Oct 2021 01:00:13 +0000 (21:00 -0400)]
Merge PR #43333 into master

* refs/pull/43333/head:
.github/CODEOWNERS: tag rook devs on rook related PRs

Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/nfs: add some test coverage for cluster info, cluster config 43504/head
Sage Weil [Thu, 14 Oct 2021 17:21:40 +0000 (13:21 -0400)]
mgr/nfs: add some test coverage for cluster info, cluster config

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/nfs: add 'nfs cluster config get'
Sage Weil [Tue, 12 Oct 2021 16:13:04 +0000 (11:13 -0500)]
mgr/nfs: add 'nfs cluster config get'

Fixes: https://tracker.ceph.com/issues/52942
Signed-off-by: Sage Weil <sage@newdream.net>
3 years agocrimson/os/seastore/segment_manager/block: open with dsync 43554/head
Samuel Just [Thu, 14 Oct 2021 21:51:38 +0000 (14:51 -0700)]
crimson/os/seastore/segment_manager/block: open with dsync

67efc4 appears to be simply incorrect, I don't see any calls
to flush(), so we do need to open with dsync until we
implement a smarter flushing scheme.

Also, refactor open_device to remove mode param -- we always
pass the same value.

Reverts: 67efc48332cebb69497c5676be6ed2a6e5365e03
Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43477 from anthonyeleven/anthonyeleven/fix-23027
Casey Bodley [Thu, 14 Oct 2021 20:13:28 +0000 (16:13 -0400)]
Merge pull request #43477 from anthonyeleven/anthonyeleven/fix-23027

ceph: document rgw_multipart_min_part_size

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agocephadm: do not log commands sent to "call" function 43552/head
Adam King [Thu, 14 Oct 2021 18:56:51 +0000 (14:56 -0400)]
cephadm: do not log commands sent to "call" function

They could potentially log sensitive info such as registry
login passwords

Signed-off-by: Adam King <adking@redhat.com>
3 years agoqa/suites/orch/rook/smoke: use nvme-loop 43550/head
Sage Weil [Wed, 13 Oct 2021 21:16:03 +0000 (16:16 -0500)]
qa/suites/orch/rook/smoke: use nvme-loop

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/rook: fix mds service list 43549/head
Sage Weil [Tue, 12 Oct 2021 14:43:05 +0000 (09:43 -0500)]
mgr/rook: fix mds service list

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #42997 from josephsawaya/wip-mgr-rook-orch-ls
Sebastian Wagner [Thu, 14 Oct 2021 15:33:26 +0000 (17:33 +0200)]
Merge pull request #42997 from josephsawaya/wip-mgr-rook-orch-ls

mgr/rook: orch ls displays info about OSDs

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
3 years agoMerge pull request #43332 from sebastian-philipp/sphinx-rgw-spec
Sebastian Wagner [Thu, 14 Oct 2021 14:54:18 +0000 (16:54 +0200)]
Merge pull request #43332 from sebastian-philipp/sphinx-rgw-spec

doc/cephadm: use sphinx autoclass to document RGWSpec

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #43239 from trociny/wip-48959
Kefu Chai [Thu, 14 Oct 2021 14:43:16 +0000 (22:43 +0800)]
Merge pull request #43239 from trociny/wip-48959

osd: handle inconsistent hash info during backfill and deep scrub gracefully

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43498 from dheart-joe/bluestore_fix
Kefu Chai [Thu, 14 Oct 2021 14:41:52 +0000 (22:41 +0800)]
Merge pull request #43498 from dheart-joe/bluestore_fix

os/bluestore: _do_write_small fix head_pad

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agoMerge pull request #42099 from aclamk/wip-bluefs-fine-grain-locking-2
Kefu Chai [Thu, 14 Oct 2021 14:40:20 +0000 (22:40 +0800)]
Merge pull request #42099 from aclamk/wip-bluefs-fine-grain-locking-2

os/bluestore: BlueFS fine grain locking

Reviewed-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43374 from ljflores/wip-remove-pool-name
Kefu Chai [Thu, 14 Oct 2021 14:39:14 +0000 (22:39 +0800)]
Merge pull request #43374 from ljflores/wip-remove-pool-name

mgr/telemetry: remove pool name from telemetry perf report

Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
3 years agoMerge pull request #43463 from Zhiwei-Dai/wip-enhance-qa-python3-compatibility
Kefu Chai [Thu, 14 Oct 2021 14:38:39 +0000 (22:38 +0800)]
Merge pull request #43463 from Zhiwei-Dai/wip-enhance-qa-python3-compatibility

qa/tasks: replace iterkeys() with keys() for Python 3

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43405 from ljflores/wip-perfcounter-priorities
Kefu Chai [Thu, 14 Oct 2021 14:37:36 +0000 (22:37 +0800)]
Merge pull request #43405 from ljflores/wip-perfcounter-priorities

os/bluestore: update perf counter priorities

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43422 from ronen-fr/wip-rf-exact-time-sec
Kefu Chai [Thu, 14 Oct 2021 14:36:30 +0000 (22:36 +0800)]
Merge pull request #43422 from ronen-fr/wip-rf-exact-time-sec

common/ceph_time: fix wrong seconds output in exact_timespan_str()

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43515 from fengchunsong/dpdk-dev
Kefu Chai [Thu, 14 Oct 2021 14:34:56 +0000 (22:34 +0800)]
Merge pull request #43515 from fengchunsong/dpdk-dev

msgs/async/dpdk: fix dpdk build error

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43531 from tchaikov/wip-pick-addr
Kefu Chai [Thu, 14 Oct 2021 14:33:39 +0000 (22:33 +0800)]
Merge pull request #43531 from tchaikov/wip-pick-addr

common/pick_address: refactor pick_addresses()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43073 from strenuous-life/wip-cephadm-osd-rm-status
Sebastian Wagner [Thu, 14 Oct 2021 14:29:05 +0000 (16:29 +0200)]
Merge pull request #43073 from strenuous-life/wip-cephadm-osd-rm-status

mgr/cephadm: the display of 'orch osd rm status' is incorrect

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>