crimson/os/seastore/.../lba_btree: fix min_capacity condition

Reducing the size of split_merge_multi has an interesting side effect of
causing removes to happen on some leaf nodes immediately after split.
After split, child nodes would have size 72 or 73.  At size 72, the node
would be at_min_size() and a remove would put it below causing the
at_min_size() condition to fail and hande_merge to misbehave.

Replace at_min_capacity() with below_min_capacity().
below_min_capacity() will not be true for any child of a split, and
asserts that the child is below capacity by no more than 1.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../lba_btree: fix lower_bound at_boundary()

Clarify that lookup_depth_range may return an iterator at_boundary() and
audity users.

Fix LBABtree::lookup to correctly handle at_boundary() after the call to
lookup_depth_range.

Fixes: https://tracker.ceph.com/issues/52805
Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager/lba_btree: factor out iterator::handle_boundary

Factor out helper to adjust iterators at_boundary().

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager/lba_btree: add at_boundary helper distinct from is_end

From an external caller, the condition is identical.  However, internally
iterators may be at a leaf boundary without being at end().  For those
checks, use at_boundary() instead.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/test/seastore/test_btree_lba_manager: shorten tests a bit

Signed-off-by: Samuel Just <sjust@redhat.com>

test/crimson/seastore/test_btree_lba_manager: add LBABtree level unit tests

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../lba_btree_node.h: add operator== for lba_map_val_t

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager/btree: tolerate op_context_t without pins

Simpler to construct unit tests for the LBABTree itself without pins.

Signed-off-by: Samuel Just <sjust@redhat.com>

test/crimson/seastore/test_btree_lba_manager: factor out btree_test_base

We're going to use this to create tests for LBABtree in isolation.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/object_data_handler.cc: misc logging improvements

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: debug outputs

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>

crimson/os/seastore/.../lba_btree: fix logging for LBABtree::handle_split

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #43633 from ideepika/wip-rbd-full-try-test-fixups

test/librbd: harden RemoveFullTry tests

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

qa/suites/rbd: whitelist POOL_FULL due to quota for test_librbd.sh

RemoveFullTry tests fill up the pool and expect EDQUOT.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

test/librbd: don't run RemoveFullTry tests with persistent writeback cache

Persistent writeback cache messes with pool quota enforcement on the
OSD side and we don't always break out of the write zeroes loop:

  src/test/librbd/test_librbd.cc:2165: Failure
  Value of: off >= quota && off < size
    Actual: false
  Expected: true

Unfortunately persistent writeback cache doesn't honor FUA [1] so the
workaround for volatile caches from the previous patch doesn't apply.

[1] https://tracker.ceph.com/issues/49715

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

test/librbd: set FUA on writes in remove_full_try()

Work around write-back or write-around cache getting enabled (e.g. if
one runs the tests with rbd_cache_writethrough_until_flush disabled).

Fixes: https://tracker.ceph.com/issues/52883
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #43629 from athanatos/sjust/wip-fix-fsdriver

crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #43573 from idryomov/wip-create-ioctx-preserve-full-try

librbd: preserve CEPH_OSD_FLAG_FULL_TRY in create_ioctx()

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

Merge pull request #43568 from idryomov/wip-writesame-fua

librbd: honor FUA op flag for write_same() in write-around cache

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature

Introduced: e5f7ff
Fixes: https://tracker.ceph.com/issues/53012
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #42151 from chapche/wip-tracker-51466

rgw: cls_bucket_list_unordered() might return one redundent entry every time is_truncated is true

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #43503 from mkogan1/wip-fips-md5

rgw: under fips, set flag to allow md5 in select rgw ops

Merge PR #43566 into master

* refs/pull/43566/head:
qa: reduce frag split confs for dir_split counter test

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #43600 from smithfarm/wip-52979

rgw/tracing: unify SO version numbers within librgw2 package

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #43586 from sebastian-philipp/docs-email-contact

doc/start: documenting-ceph: Remove email to ceph-docs@redhat.com

Reviewed-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #43604 from zdover23/wip-doc-2021-10-21-cephadm-install-typo

doc/cephadm: update typo in install.rst

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #43616 from krafZLorG/fix-cephadm-chooseleaf

cephadm: Fix option name osd_crush_chooseleaf_type

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Fix option name osd_crush_chooseleaf_type

Signed-off-by: Dmitry Kvashnin <dm.kvashnin@gmail.com>

Merge PR #43508 into master

* refs/pull/43508/head:
mds/FSMap: do not assert allow_standby_replay on old FSMaps

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge PR #43506 into master

* refs/pull/43506/head:
mon/MDSMonitor: avoid crash when decoding old FSMap epochs

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge PR #40183 into master

* refs/pull/40183/head:
client: remove useless mds member in Fh class
client: adjust the Fh class members order
client: switch to use shared_ptr for mds_sessions
client: minor cleanup to Fh related code
client: minor cleanup to MetaRequest class
client: minor cleanup to Client related code

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #38752 into master

* refs/pull/38752/head:
qa: enable dynamic debug support to kclient

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #43138 into master

* refs/pull/43138/head:
mgr/rook: implement `orch device zap` in rook orchestrator

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>

Merge pull request #43594 from ivancich/wip-bucket-fix-pool-actual

rgw: have "bucket check --fix" fix pool ids correctly

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #43429 from ivancich/wip-document-rgw_lc_debug_interval

rgw: document rgw_lc_debug_interval configuration option

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

rgw: clean up a little LC logging

Some of the LC logging does not put whitespace between some values and
the thread identifier. This commit adds the whitespace.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

rgw: during "bucket check --fix" set index entry pool id correctly

The current code sets the pool id of bucket index entries to the
bucket index pool rather than the data pool. This fixes that.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #43553 from ivancich/wip-bucket-fix-pool

rgw: pass "force check filter" through SAL in bucket listing

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #43535 from Rethan/fix-image-spec

rbd: correct image_spec() output when rbd-nbd Detach/Unmap error

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #43596 from ronen-fr/wip-rf-test_info

tests: modify osd-scrub-repair to match PR #43239 changes

Reviewed-by: Mykola Golub <mgolub@suse.com>

doc/cephadm: update typo in install.rst

This PR changes the string

   use "--log-to-file" option during bootstrap

to

   use the "--log-to-file" option during bootstrap

The way that it was written makes it sound like it was
written by a native Russian speaker. But it was written
by me, a native English speaker, so this is on me.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #43572 from trociny/wip-qa-backfill-toofull-compress

qa/tasks/backfill_toofull: make test work when compression on

Reviewed-by: Neha Ojha <nojha@redhat.com>

rgw: document rgw_lc_debug_interval configuration option

Updates the yaml describing this config option with a "desc" and a
"long_desc".

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

doc/start: documenting-ceph: Remove email to ceph-docs@redhat.com

Instead get in touch with the component lead.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

doc/start: documenting-ceph: Improve template of commits

by properly linking the corresponding tracker issue.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

doc/governanace: Fix my email address

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

rgw/tracing: unify SO version numbers within librgw2 package

The librgw2 package contains several SO files. Two of those - librgw_op_tp.so
and librgw_rados_tp.so - had a different version number than the main librgw.

This was a violation of the openSUSE Shared Library Packaging Policy [1] but it
also seems like a "violation" of common sense.

[1] https://en.opensuse.org/openSUSE:Shared_library_packaging_policy#Package_naming

Fixes: https://tracker.ceph.com/issues/52979
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #42772 from Daniel-Pivonka/cephadm-add-existing-host

mgr/cephadm: update host when adding host that already exists

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43354 from adk3798/daemon-failed-agent

mgr/cephadm: update CEPHADM_FAILED_DAEMON after receiving agent metadata

Reviewed-by: Daniel Pivonka <dpivonka@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #43366 from adk3798/log-list-servers

mgr/cephadm: put list_servers output in debug logs

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43367 from adk3798/handle-use-agent

mgr/cephadm: move handling of use_agent setting into agent.py

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43489 from adk3798/clear-agent-down

mgr/cephadm: update CEPHADM_AGENT_DOWN when agent reports in

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43552 from adk3798/dont-log-credentials

cephadm: do not log commands sent to "call" function

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

tests: modify osd-scrub-repair to match PR #43239 changes

PR #43239 has modified ECBackend::get_hash_info() behavior.
Modified the standalone scrub test to match.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #43592 from rzarzynski/wip-crimson-mount_ertr

crimson: errorate the FuturizedStore::mount() paths.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #42839 from giladmaya/wip-on-wire-compression-documentation

doc: Added msgr on-wire-compression

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #43577 from ThomasLamprecht/docs-glossary-typo

docs: fix case and spelling of Proxmox VE

Reviewed-by: Laura Flores <lflores@redhat.com>

crimson: errorate the FuturizedStore::mount() paths.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #43556 into master

* refs/pull/43556/head:
qa/suites/orch/cephadm/osds: add osd rm/zap/add test

Reviewed-by: Cory Snyder <csnyder@iland.com>

crimson/os: move singleton_ec up to let mount() reuse it.

No other changes in this commit.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #43569 into master

* refs/pull/43569/head:
mgr/orchestrator: clean up 'orch device ls' output

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43486 from cbodley/wip-rgw-maintainers

rgw: start on MAINTAINERS.md

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #43514 from mgfritch/cephadm-agent-binary

cephadm: use the current cephadm binary for the agent

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #43465 from rhcs-dashboard/radosgw-grafana-dashboards

mgr/dashboard: monitoring: grafonnet refactoring for radosgw dashboards

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #43370 from liewegas/fix-rook-rgw-multisite

mgr/rook: describe_services: name rgw svc appropriately

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43550 from liewegas/rook-nvme

qa/suites/orch/rook/smoke: use nvme-loop

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #42526 from liewegas/dashboard-nfs

mgr/dashboard: consume mgr/nfs

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>

mgr/dashboard: monitoring: grafonnet refactoring for cephfs dashboards

This PR intends to refactor cephfs dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: monitoring: grafonnet refactoring for osds dashboards

This PR intends to refactor osds dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: monitoring: grafonnet refactoring for pools dashboards

This PR intends to refactor pools dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: monitoring: grafonnet refactoring for rbd dashboards

This PR intends to refactor rbd dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: monitoring: grafonnet refactoring for radosgw dashboards

This PR intends to refactor radosgw dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/rook: implement `orch device zap` in rook orchestrator

This commit implements orch device zap by creating a pod on the target
host that mounts the /dev directory and runs either overwrites the first
few blocks of the device with zeros if it's a raw device or if it's not
a raw device it will use `ceph-volume lvm zap`.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>

qa/suites/orch/cephadm/osds: add osd rm/zap/add test

Signed-off-by: Sage Weil <sage@newdream.net>

Merge PR #43504 into master

* refs/pull/43504/head:
mgr/nfs: add some test coverage for cluster info, cluster config
mgr/nfs: add 'nfs cluster config get'

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>

Merge PR #43510 into master

* refs/pull/43510/head:
qa/suites/orch/cephadm/upgrade: smoke test for 'orch upgrade ls'
mgr/cephadm: make upgrade ls output structured
mgr/cephadm: add 'orch upgrade ls' to list available versions

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge PR #43549 into master

* refs/pull/43549/head:
mgr/rook: fix mds service list

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

rgw: add src/rgw/MAINTAINERS.md

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #43469 from rhcs-dashboard/hosts-grafana-dashboards

mgr/dashboard: monitoring: grafonnet refactoring for hosts dashboards

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

qa/suites/orch/cephadm/upgrade: smoke test for 'orch upgrade ls'

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #42760 from ideepika/wip-iscsi-testing

qa/suites/rbd: switch iscsi tests to cephadm

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #43564 from sebastian-philipp/doc-cephadm-host-location

doc/cephadm: Hosts: Add "initial CRUSH location"

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

mgr/dashboard: NFS exports: API + UI: integration with mgr/nfs; cleanups

mgr/dashboard: move NFS_GANESHA_SUPPORTED_FSALS to mgr_module.py

Importing from nfs module throws AttributeError because as a side effect the dashboard module is impersonating the nfs module.
https://gist.github.com/varshar16/61ac26426bbe5f5f562ebb14bcd0f548

mgr/dashboard: 'Create NFS export' form: list clusters from nfs module

mgr/dashboard: frontend+backend cleanups for NFS export

Removed all code and references related to daemons. UI cleanup and adopted unit-testing for
nfs-epxort create form for CEPHFS backend. Cleanup for export list/get/create/set/delete endpoints.

mgr/dashboard: rm set-ganesha ref + update docs

Remove existing set-ganesha-clusters-rados-pool-namespace references as
they are no longer required. Moreover, nfs doc in dashboard doc is
updated accordingly to the current nfs status.

mgr/dashboard: add nfs-export e2e test coverage

mgr/dashboard: 'Create NFS export' form: remove RGW user id field.

- Improve bucket typeahead behavior.
- Increase version for bucket list endpoint.
- Some refactoring.

mgr/dashboard: 'Create NFS export' form: allow RGW backend only when default realm is selected.

When RGW multisite is configured, the NFS module can only handle buckets in the default realm.

mgr/dashboard: 'Create service' form: fix NFS service creation.

After https://github.com/ceph/ceph/pull/42073, NFS pool and namespace are not customizable.

mgr/dashboard: 'Create NFS export' form: add bucket validation.

- Allow only existing buckets.
- Refactoring:
  - Moved bucket validator from bucket form to cd-validators.ts
  - Split bucket validator into 2: bucket name validator and bucket existence (that checks either existence or non-existence).

mgr/dashboard: 'Create NFS export' form: path validation refactor: allow only existing paths.

Fixes: https://tracker.ceph.com/issues/46493
Fixes: https://tracker.ceph.com/issues/51479
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

docs: fix case and spelling of Proxmox VE

There's no such thing as ProxMox, the hypervisor product with build
in ceph server management and RBD client access is named `Proxmox VE`
and the company behind it is named Proxmox Server Solutions GmbH

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

mgr/dashboard: directly use ExportMgr and NFSCluster objects

Using the objects directly provides access to other methods and helps in
avoiding repeatition.

mgr/dashboard/nfsganesha: remove tag

Since NFS v3 is no longer supported. We can remove tag.

mgr/nfs: define global constant to list supported FSALs

mgr/dashboard: directly list nfs clusters by directly importing available_cluster() method

The current dashboard api returns a list of following dictionary

{
   'pool': 'nfs-ganesha',
   'namespace': cluster_id,
   'type': 'orchestrator',
   'daemon_conf': None
}

None of these values are required for listing nfs cluster by mgr/nfs module.
Instead directly list available cluster names

mgr/dashboard: add comment to remove listing of daemons

As the configs are per cluster. There is no need to list daemons per cluster.

mgr/dashboard/controllers/nfsganesha: Add comments to update/remove status endpoint

This endpoint can be updated in suggested way or even removed. As it was
initially[1] introduced to check if dashboard pool and namespace configuration was
set.

[1] https://github.com/ceph/ceph/commit/824726393b185b8e5a8f17e66487dfde9f3c8b5c

mgr/nfs: remove fetch_cluster_obj()

There is no need to fetch NFSCluster class object. Directly
available_clusters() can be imported to list nfs clusters.

mgr/dashboard/controllers/nfsganesha: list exports based on cluster id

As mgr/nfs module lists based on cluster id.

mgr/dashboard/nfs: get and delete export by export id

Fixes: https://tracker.ceph.com/issues/46493
Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/dashboard: consume mgr/nfs via mgr.remote()

Stop using the dashboard version of the Ganesha config classes; consume
mgr/nfs instead via remote().

mgr/nfs/export: return Export from _apply_export

Future callers will want this.

mgr/nfs: new module methods for dashboard consumption

Add some new methods that are easy for the dashboard API to consume.  These
are very similar to the CLI methods but do now have the @CLICommand and
related decorators, and have slightly different interfaces (e.g., returning
the created/modified Export dict).

mgr/dashboard: remove old ganesha code (and tests)

Fixes: https://tracker.ceph.com/issues/46493
Signed-off-by: Sage Weil <sage@newdream.net>

src/test/cli-integration: correct hostname for iscsi gateway

iscsi accepts first word of hostname as local hostname[0] instead of
smithi061.front.sepia.ceph.com we use: smithi061 otherwise gateway
creation will error out with:
```The first gateway defined must be the local machine```

[0] https://github.com/ceph/ceph-iscsi-cli/blob/ff3e430b70a62257a560b8988bd54bf845c01fb7/gwcli/utils.py#L36

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>

src/test/cli-integration/rbd: update gwcli_* to use podman exec

* since iscsi now resides inside the container, for testing we use the
  hack:
  - find the iscsi container/
  - use found container and podman exec command to test gateway creation
    deletion from host itself

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>

qa/tasks: adapt ceph_iscsi.py task to ceph_iscsi_client

* we use setup_iscsi_client.py to deploy iscsi client services,
  configuring intiator and mulitpath this is done by qa task
  ceph_iscsi_client
* qa/cephadm: adds remotes ip addresses to iscsi gateway,
* rename poolname: iscsi >> datapool, which we usually use for tests and
  expresses type of pool more clearly.

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>

qa/suites/rbd: remove baremetal based setup needed for iscsi testing

* replace ceph baremetal deployment with cephadm based deployment

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>

doc: add iSCSI initiator client configuration section for cephadm

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>

doc added msgr on-wire-compression

Signed-off-by: Maya Gilad <ms.maya.gilad@gmail.com>

qa: reduce frag split confs for dir_split counter test

Fixes: https://tracker.ceph.com/issues/52949
Fixes: a5675535ba532cfe782238d995751f9bc91f5078
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

test: fix valgrind.supp path in run-rbd-valgrind-unit-tests.sh

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

test/librados_test_stub: add IoCtx::{set,get}_pool_full_try() stubs

Because unittest_librbd links not just with librados_test_stub.a but
also with librados.so (why?), these were sneakily picked up from the
latter.  This resulted in get_pool_full_try() reading from invalid
memory and every once in a while returning true, prompting librbd to
write to invalid memory through set_pool_full_try() in create_ioctx()
and cause random crashes.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: preserve CEPH_OSD_FLAG_FULL_TRY in create_ioctx()

The obvious use case is an image with a separate data pool but it could
be useful in other places too.

While at it, set_namespace() call in handle_v2_get_data_pool() is
redundant since create_ioctx() already takes care of it.

Fixes: https://tracker.ceph.com/issues/52961
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa/tasks/backfill_toofull: make test work when compression on

The osd backfill reservation does not take compression into account so
we need to operate with "uncompressed" bytes when calculating nearfull
ratio.

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #43571 from tchaikov/wip-bl-prepare-iovs

common/bl: bl::prepare_iovs() related cleanups

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>

common/bl: mark bl::prepare_iovs() const

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

common/bl: simplify bl::prepare_iovs()

* consolidate the code to initialize a vector<iov>
* use an iterator to track the current vector<iovec>. less
  repeating this way.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>