]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agomgr/k8sevents: pin the kubernetes version to 11.0.0 43668/head
Nizamudeen A [Tue, 26 Oct 2021 11:33:33 +0000 (17:03 +0530)]
mgr/k8sevents: pin the kubernetes version to 11.0.0

Fixes: https://tracker.ceph.com/issues/53044
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43640 from rhcs-dashboard/module-status-guard-error-handling
Ernesto Puerta [Tue, 26 Oct 2021 08:52:13 +0000 (10:52 +0200)]
Merge pull request #43640 from rhcs-dashboard/module-status-guard-error-handling

mgr/dashboard: Proper error handling in module status guard

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43639 from rhcs-dashboard/angular-11-form-fix
Ernesto Puerta [Tue, 26 Oct 2021 08:51:22 +0000 (10:51 +0200)]
Merge pull request #43639 from rhcs-dashboard/angular-11-form-fix

mgr/dashboard: Fix for form inside form closing issue

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43560 from pcuzner/fix-orch-device-zap
Sebastian Wagner [Tue, 26 Oct 2021 08:42:05 +0000 (10:42 +0200)]
Merge pull request #43560 from pcuzner/fix-orch-device-zap

mgr/cephadm: improve validation of orch device zap

Reviewed-by: Sage Weil <sage@newdream.net>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43499 from jecluis/wip-cephadm-insecure
Sebastian Wagner [Tue, 26 Oct 2021 08:27:24 +0000 (10:27 +0200)]
Merge pull request #43499 from jecluis/wip-cephadm-insecure

cephadm: allow pulling from insecure registries

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43502 from adk3798/rm-testing2
Sebastian Wagner [Tue, 26 Oct 2021 08:26:44 +0000 (10:26 +0200)]
Merge pull request #43502 from adk3798/rm-testing2

mgr/cephadm: remove host addr from agent deps

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43579 from sebastian-philipp/cephadm-monitoring-ipv6
Sebastian Wagner [Tue, 26 Oct 2021 08:24:32 +0000 (10:24 +0200)]
Merge pull request #43579 from sebastian-philipp/cephadm-monitoring-ipv6

mgr/cephadm: Fix IPv6 in monitoring services

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #43632 from myoungwon/wip-alloc-free-rbm-paddr
Samuel Just [Tue, 26 Oct 2021 08:12:07 +0000 (01:12 -0700)]
Merge pull request #43632 from myoungwon/wip-alloc-free-rbm-paddr

seastore: add alloc/free extent for RBM based on paddr_t

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43641 from athanatos/sjust/wip-52805
Samuel Just [Tue, 26 Oct 2021 07:40:54 +0000 (00:40 -0700)]
Merge pull request #43641 from athanatos/sjust/wip-52805

crimson/os/seastore: fix LBABtree::lower_bound behavior

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #43651 from rzarzynski/wip-crimson-net-fix-nonceportcheck
Samuel Just [Mon, 25 Oct 2021 22:52:19 +0000 (15:52 -0700)]
Merge pull request #43651 from rzarzynski/wip-crimson-net-fix-nonceportcheck

crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43650 from rzarzynski/wip-crimson-improve-dbgs
Samuel Just [Mon, 25 Oct 2021 21:18:03 +0000 (14:18 -0700)]
Merge pull request #43650 from rzarzynski/wip-crimson-improve-dbgs

crimson, monmap: fix / improve miscellaneous debugs

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43652 from rzarzynski/wip-crimson-osd-seqmeta
Samuel Just [Mon, 25 Oct 2021 21:17:11 +0000 (14:17 -0700)]
Merge pull request #43652 from rzarzynski/wip-crimson-osd-seqmeta

crimson/osd: write object store's meta sequentially.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/.../lba_btree: fix min_capacity condition 43641/head
Samuel Just [Mon, 25 Oct 2021 07:47:16 +0000 (07:47 +0000)]
crimson/os/seastore/.../lba_btree: fix min_capacity condition

Reducing the size of split_merge_multi has an interesting side effect of
causing removes to happen on some leaf nodes immediately after split.
After split, child nodes would have size 72 or 73.  At size 72, the node
would be at_min_size() and a remove would put it below causing the
at_min_size() condition to fail and hande_merge to misbehave.

Replace at_min_capacity() with below_min_capacity().
below_min_capacity() will not be true for any child of a split, and
asserts that the child is below capacity by no more than 1.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/.../lba_btree: fix lower_bound at_boundary()
Samuel Just [Mon, 25 Oct 2021 06:26:05 +0000 (06:26 +0000)]
crimson/os/seastore/.../lba_btree: fix lower_bound at_boundary()

Clarify that lookup_depth_range may return an iterator at_boundary() and
audity users.

Fix LBABtree::lookup to correctly handle at_boundary() after the call to
lookup_depth_range.

Fixes: https://tracker.ceph.com/issues/52805
Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/lba_manager/lba_btree: factor out iterator::handle_boundary
Samuel Just [Mon, 25 Oct 2021 06:14:08 +0000 (06:14 +0000)]
crimson/os/seastore/lba_manager/lba_btree: factor out iterator::handle_boundary

Factor out helper to adjust iterators at_boundary().

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/lba_manager/lba_btree: add at_boundary helper distinct from is_end
Samuel Just [Mon, 25 Oct 2021 06:03:33 +0000 (23:03 -0700)]
crimson/os/seastore/lba_manager/lba_btree: add at_boundary helper distinct from is_end

From an external caller, the condition is identical.  However, internally
iterators may be at a leaf boundary without being at end().  For those
checks, use at_boundary() instead.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/test/seastore/test_btree_lba_manager: shorten tests a bit
Samuel Just [Mon, 25 Oct 2021 05:39:49 +0000 (22:39 -0700)]
crimson/test/seastore/test_btree_lba_manager: shorten tests a bit

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agotest/crimson/seastore/test_btree_lba_manager: add LBABtree level unit tests
Samuel Just [Fri, 22 Oct 2021 06:15:33 +0000 (23:15 -0700)]
test/crimson/seastore/test_btree_lba_manager: add LBABtree level unit tests

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #41696 from MrFreezeex/fix-rbd-mirror-remove
Mykola Golub [Mon, 25 Oct 2021 15:12:38 +0000 (18:12 +0300)]
Merge pull request #41696 from MrFreezeex/fix-rbd-mirror-remove

rbd-mirror: fix mirror image removal

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #43528 from TRYTOBE8TME/wip-rgw-malformed-url-fix
Yuval Lifshitz [Mon, 25 Oct 2021 14:07:14 +0000 (17:07 +0300)]
Merge pull request #43528 from TRYTOBE8TME/wip-rgw-malformed-url-fix

src/rgw: Fix for malformed url

3 years agoMerge pull request #41657 from sunnyku/wip-rbd-50787
Mykola Golub [Mon, 25 Oct 2021 13:19:48 +0000 (16:19 +0300)]
Merge pull request #41657 from sunnyku/wip-rbd-50787

librbd/object_map: rbd diff between two snapshots lists entire image content

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agocrimson/osd: write object store's meta sequentially. 43652/head
Radoslaw Zarzynski [Mon, 25 Oct 2021 12:30:39 +0000 (12:30 +0000)]
crimson/osd: write object store's meta sequentially.

We're violating the contract on `ObjectStore::write_meta()' that
requires the method must be called in one-by-one manner.
For instance, the implementation in `BlueStore` does read-modify-
write without any locking. Having multiple in-flight requests
the same time (can happen b/c of the thread pool in `AlienStore`)
may lead to a corruption like the following one:

```
[2021-10-25 13:38:38,725][ceph_volume.process][INFO  ] Running command: /home/rzarz/dev/ceph1/build/bin/ceph-bluestore-tool show-label --dev /dev/nvme0n1p3
[2021-10-25 13:38:38,737][ceph_volume.process][INFO  ] stdout {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "/dev/nvme0n1p3": {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "osd_uuid": "a11030f3-f41f-482c-916c-98476feaf25f",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "size": 1022903713792,
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "btime": "2021-10-25T12:41:11.938439+0200",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "description": "main",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_blocks": "249732352",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_blocks_per_key": "128",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_bytes_per_block": "4096",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_size": "1022903713792",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bluefs": "1",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "ceph_fsid": "f884fe47-b307-46f9-b021-320d7c5a427b",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "kv_backend": "rocksdb",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "mkfs_done": "yes"
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][ERROR ] device /dev/nvme0n1p3 does not have all BlueStore data needed to be a valid OSD: ['{', '    "/dev/nvme0n1p3": {', '        "osd_uuid": "a11030f3-f41f-482c-916c-98476feaf25f",', '        "size": 1022903713792,', '        "btime": "2021-10-25T12:41:11.938439+0200",', '        "description": "main",', '        "bfm_blocks": "249732352",', '        "bfm_blocks_per_key": "128",', '        "bfm_bytes_per_block": "4096",', '        "bfm_size": "1022903713792",', '        "bluefs": "1",', '        "ceph_fsid": "f884fe47-b307-46f9-b021-320d7c5a427b",', '        "kv_backend": "rocksdb",', '        "mkfs_done": "yes"', '    }', '}']
'whoami'
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][INFO  ] device /dev/nvme0n1p3 does not have BlueStore information
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 92b2fe955f9cafdf6a9c6adb8eadc5f6a9fb9b8b)

3 years agocrimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned... 43651/head
Radoslaw Zarzynski [Thu, 21 Oct 2021 12:51:25 +0000 (12:51 +0000)]
crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson/osd: fix broken debug in OSD::_write_superblock(). 43650/head
Radoslaw Zarzynski [Mon, 25 Oct 2021 12:41:02 +0000 (12:41 +0000)]
crimson/osd: fix broken debug in OSD::_write_superblock().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 48d5fc45e3e95485e89419bec716fddfb7029a18)

3 years agocrimson/osd: improve debugs around heatbeat's binding procedure.
Radoslaw Zarzynski [Wed, 20 Oct 2021 12:04:36 +0000 (12:04 +0000)]
crimson/osd: improve debugs around heatbeat's binding procedure.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson/osd: inform about replacing cluster messenger's unknown addresses.
Radoslaw Zarzynski [Wed, 20 Oct 2021 11:53:41 +0000 (11:53 +0000)]
crimson/osd: inform about replacing cluster messenger's unknown addresses.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson, monmap: add more debugs around building initial monmap.
Radoslaw Zarzynski [Mon, 11 Oct 2021 19:54:05 +0000 (19:54 +0000)]
crimson, monmap: add more debugs around building initial monmap.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agomgr/dashboard: Fix for form inside form closing issue 43639/head
Nizamudeen A [Sat, 23 Oct 2021 19:06:51 +0000 (00:36 +0530)]
mgr/dashboard: Fix for form inside form closing issue

After the angular 11 upgrade the form in form behaviour got broken when
one tries to close that "embedded" form. This commit is to fix that
behaviour.

Fixes: https://tracker.ceph.com/issues/53020
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43642 from rhcs-dashboard/pin-version-req-lint
Ernesto Puerta [Mon, 25 Oct 2021 11:12:12 +0000 (13:12 +0200)]
Merge pull request #43642 from rhcs-dashboard/pin-version-req-lint

mgr/dashboard: pin a version for autopep8 and pyfakefs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: pin a version for autopep8 and pyfakefs 43642/head
Nizamudeen A [Mon, 25 Oct 2021 08:42:57 +0000 (14:12 +0530)]
mgr/dashboard: pin a version for autopep8 and pyfakefs

Fixes: https://tracker.ceph.com/issues/53024
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agocrimson/os/seastore/.../lba_btree_node.h: add operator== for lba_map_val_t
Samuel Just [Fri, 22 Oct 2021 06:14:20 +0000 (23:14 -0700)]
crimson/os/seastore/.../lba_btree_node.h: add operator== for lba_map_val_t

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/lba_manager/btree: tolerate op_context_t without pins
Samuel Just [Wed, 20 Oct 2021 06:48:41 +0000 (23:48 -0700)]
crimson/os/seastore/lba_manager/btree: tolerate op_context_t without pins

Simpler to construct unit tests for the LBABTree itself without pins.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agotest/crimson/seastore/test_btree_lba_manager: factor out btree_test_base
Samuel Just [Wed, 20 Oct 2021 05:47:44 +0000 (05:47 +0000)]
test/crimson/seastore/test_btree_lba_manager: factor out btree_test_base

We're going to use this to create tests for LBABtree in isolation.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/object_data_handler.cc: misc logging improvements
Samuel Just [Mon, 25 Oct 2021 04:45:18 +0000 (21:45 -0700)]
crimson/os/seastore/object_data_handler.cc: misc logging improvements

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore: debug outputs
Xuehan Xu [Tue, 19 Oct 2021 05:27:59 +0000 (13:27 +0800)]
crimson/os/seastore: debug outputs

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore/.../lba_btree: fix logging for LBABtree::handle_split
Samuel Just [Mon, 25 Oct 2021 06:51:32 +0000 (23:51 -0700)]
crimson/os/seastore/.../lba_btree: fix logging for LBABtree::handle_split

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agomgr/dashboard: Proper error handling in module status guard 43640/head
Nizamudeen A [Mon, 25 Oct 2021 07:25:35 +0000 (12:55 +0530)]
mgr/dashboard: Proper error handling in module status guard

I've recently introduced a check that verifies if the orch_backend we need for a feature matches the orch_backend of the cluster. But to verify this I need to call configOpt API and some user's don't have the permission to access it. So it'll show this Access Denied page.

Fixes: https://tracker.ceph.com/issues/53021
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43633 from ideepika/wip-rbd-full-try-test-fixups
Mykola Golub [Sun, 24 Oct 2021 07:44:00 +0000 (10:44 +0300)]
Merge pull request #43633 from ideepika/wip-rbd-full-try-test-fixups

test/librbd: harden RemoveFullTry tests

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agoqa/suites/rbd: whitelist POOL_FULL due to quota for test_librbd.sh 43633/head
Ilya Dryomov [Thu, 14 Oct 2021 19:40:49 +0000 (21:40 +0200)]
qa/suites/rbd: whitelist POOL_FULL due to quota for test_librbd.sh

RemoveFullTry tests fill up the pool and expect EDQUOT.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agotest/librbd: don't run RemoveFullTry tests with persistent writeback cache
Ilya Dryomov [Thu, 14 Oct 2021 18:35:16 +0000 (20:35 +0200)]
test/librbd: don't run RemoveFullTry tests with persistent writeback cache

Persistent writeback cache messes with pool quota enforcement on the
OSD side and we don't always break out of the write zeroes loop:

  src/test/librbd/test_librbd.cc:2165: Failure
  Value of: off >= quota && off < size
    Actual: false
  Expected: true

Unfortunately persistent writeback cache doesn't honor FUA [1] so the
workaround for volatile caches from the previous patch doesn't apply.

[1] https://tracker.ceph.com/issues/49715

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agotest/librbd: set FUA on writes in remove_full_try()
Ilya Dryomov [Sat, 16 Oct 2021 21:12:34 +0000 (23:12 +0200)]
test/librbd: set FUA on writes in remove_full_try()

Work around write-back or write-around cache getting enabled (e.g. if
one runs the tests with rbd_cache_writethrough_until_flush disabled).

Fixes: https://tracker.ceph.com/issues/52883
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoseastore: add device_id_t in RBM 43632/head
myoungwon oh [Tue, 12 Oct 2021 13:48:17 +0000 (22:48 +0900)]
seastore: add device_id_t in RBM

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoseastore: add rbm alloc infos when alloc_extent() is called
myoungwon oh [Fri, 13 Aug 2021 04:42:52 +0000 (13:42 +0900)]
seastore: add rbm alloc infos when alloc_extent() is called

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoseastore: free allocated extent if extent is retiered
myoungwon oh [Fri, 13 Aug 2021 03:55:17 +0000 (12:55 +0900)]
seastore: free allocated extent if extent is retiered

This commit frees allocated extent  when the extent is retired

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoseastore: make rbm_alloc_delta_t to use pair<paddr_t, size>
myoungwon oh [Sat, 23 Oct 2021 13:45:16 +0000 (22:45 +0900)]
seastore: make rbm_alloc_delta_t to use pair<paddr_t, size>

This commit makes rbm_alloc_delta_t to use std::pair based on
paddr_t in order that other modules such as cache, which does not
know about RBM, can add free information.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoMerge pull request #43629 from athanatos/sjust/wip-fix-fsdriver
Samuel Just [Sat, 23 Oct 2021 04:42:44 +0000 (21:42 -0700)]
Merge pull request #43629 from athanatos/sjust/wip-fix-fsdriver

crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #43573 from idryomov/wip-create-ioctx-preserve-full-try
Mykola Golub [Fri, 22 Oct 2021 06:49:12 +0000 (09:49 +0300)]
Merge pull request #43573 from idryomov/wip-create-ioctx-preserve-full-try

librbd: preserve CEPH_OSD_FLAG_FULL_TRY in create_ioctx()

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agoMerge pull request #43568 from idryomov/wip-writesame-fua
Mykola Golub [Fri, 22 Oct 2021 06:48:47 +0000 (09:48 +0300)]
Merge pull request #43568 from idryomov/wip-writesame-fua

librbd: honor FUA op flag for write_same() in write-around cache

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agocrimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature 43629/head
Samuel Just [Fri, 22 Oct 2021 06:15:07 +0000 (23:15 -0700)]
crimson/tools/store_nbd/fs_driver: fix mount and mkfs to handle new mkfs signature

Introduced: e5f7ff
Fixes: https://tracker.ceph.com/issues/53012
Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoseastore: make public interfaces in RBM to use paddr_t
myoungwon oh [Fri, 22 Oct 2021 06:26:52 +0000 (15:26 +0900)]
seastore: make public interfaces in RBM to use paddr_t

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoseastore: add blocks_per_segment to use paddr_t in RBM
myoungwon oh [Tue, 5 Oct 2021 01:37:59 +0000 (10:37 +0900)]
seastore: add blocks_per_segment to use paddr_t in RBM

Seastore exploits paddr_t to represent its address.
However. the term of "segment" in paddr_t generally be used in LFS,
not random block design---"block" is more general term of RBM.

The problem is that seasore already has been tighly coupled with padd_t,
also it does not make sense that there are two differnt address
such as paddr_t and block_paddr_t.

Therefore, to solve this problem, this commit adds blocks_per_segment, which
describes how many blocks a single segment contains to make RBM be compotible
with paddr_t

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoMerge pull request #42151 from chapche/wip-tracker-51466
J. Eric Ivancich [Fri, 22 Oct 2021 02:43:24 +0000 (22:43 -0400)]
Merge pull request #42151 from chapche/wip-tracker-51466

rgw: cls_bucket_list_unordered() might return one redundent entry every time is_truncated is true

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoMerge pull request #43503 from mkogan1/wip-fips-md5
Mark Kogan [Thu, 21 Oct 2021 14:35:53 +0000 (17:35 +0300)]
Merge pull request #43503 from mkogan1/wip-fips-md5

rgw: under fips, set flag to allow md5 in select rgw ops

3 years agoMerge PR #43566 into master
Patrick Donnelly [Thu, 21 Oct 2021 14:26:43 +0000 (10:26 -0400)]
Merge PR #43566 into master

* refs/pull/43566/head:
qa: reduce frag split confs for dir_split counter test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #43600 from smithfarm/wip-52979
Daniel Gryniewicz [Thu, 21 Oct 2021 14:21:12 +0000 (10:21 -0400)]
Merge pull request #43600 from smithfarm/wip-52979

rgw/tracing: unify SO version numbers within librgw2 package

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #43586 from sebastian-philipp/docs-email-contact
zdover23 [Thu, 21 Oct 2021 11:14:01 +0000 (21:14 +1000)]
Merge pull request #43586 from sebastian-philipp/docs-email-contact

doc/start: documenting-ceph: Remove email to ceph-docs@redhat.com

Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #43604 from zdover23/wip-doc-2021-10-21-cephadm-install-typo
Sebastian Wagner [Thu, 21 Oct 2021 11:08:38 +0000 (13:08 +0200)]
Merge pull request #43604 from zdover23/wip-doc-2021-10-21-cephadm-install-typo

doc/cephadm: update typo in install.rst

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #43616 from krafZLorG/fix-cephadm-chooseleaf
Sebastian Wagner [Thu, 21 Oct 2021 10:53:39 +0000 (12:53 +0200)]
Merge pull request #43616 from krafZLorG/fix-cephadm-chooseleaf

cephadm: Fix option name osd_crush_chooseleaf_type

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoFix option name osd_crush_chooseleaf_type 43616/head
krafZLorG [Thu, 21 Oct 2021 07:27:14 +0000 (10:27 +0300)]
Fix option name osd_crush_chooseleaf_type

Signed-off-by: Dmitry Kvashnin <dm.kvashnin@gmail.com>
3 years agoMerge PR #43508 into master
Patrick Donnelly [Thu, 21 Oct 2021 02:27:40 +0000 (22:27 -0400)]
Merge PR #43508 into master

* refs/pull/43508/head:
mds/FSMap: do not assert allow_standby_replay on old FSMaps

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 years agoMerge PR #43506 into master
Patrick Donnelly [Thu, 21 Oct 2021 02:26:41 +0000 (22:26 -0400)]
Merge PR #43506 into master

* refs/pull/43506/head:
mon/MDSMonitor: avoid crash when decoding old FSMap epochs

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
3 years agoMerge PR #40183 into master
Patrick Donnelly [Thu, 21 Oct 2021 02:25:58 +0000 (22:25 -0400)]
Merge PR #40183 into master

* refs/pull/40183/head:
client: remove useless mds member in Fh class
client: adjust the Fh class members order
client: switch to use shared_ptr for mds_sessions
client: minor cleanup to Fh related code
client: minor cleanup to MetaRequest class
client: minor cleanup to Client related code

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
3 years agoMerge PR #38752 into master
Patrick Donnelly [Thu, 21 Oct 2021 02:24:32 +0000 (22:24 -0400)]
Merge PR #38752 into master

* refs/pull/38752/head:
qa: enable dynamic debug support to kclient

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43138 into master
Sage Weil [Wed, 20 Oct 2021 21:50:21 +0000 (17:50 -0400)]
Merge PR #43138 into master

* refs/pull/43138/head:
mgr/rook: implement `orch device zap` in rook orchestrator

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
3 years agoMerge pull request #43594 from ivancich/wip-bucket-fix-pool-actual
J. Eric Ivancich [Wed, 20 Oct 2021 18:38:26 +0000 (14:38 -0400)]
Merge pull request #43594 from ivancich/wip-bucket-fix-pool-actual

rgw: have "bucket check --fix" fix pool ids correctly

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #43429 from ivancich/wip-document-rgw_lc_debug_interval
J. Eric Ivancich [Wed, 20 Oct 2021 17:49:20 +0000 (13:49 -0400)]
Merge pull request #43429 from ivancich/wip-document-rgw_lc_debug_interval

rgw: document rgw_lc_debug_interval configuration option

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agorgw: clean up a little LC logging 43594/head
J. Eric Ivancich [Wed, 13 Oct 2021 13:43:59 +0000 (09:43 -0400)]
rgw: clean up a little LC logging

Some of the LC logging does not put whitespace between some values and
the thread identifier. This commit adds the whitespace.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agorgw: during "bucket check --fix" set index entry pool id correctly
J. Eric Ivancich [Mon, 11 Oct 2021 20:17:46 +0000 (16:17 -0400)]
rgw: during "bucket check --fix" set index entry pool id correctly

The current code sets the pool id of bucket index entries to the
bucket index pool rather than the data pool. This fixes that.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoMerge pull request #43553 from ivancich/wip-bucket-fix-pool
J. Eric Ivancich [Wed, 20 Oct 2021 16:58:39 +0000 (12:58 -0400)]
Merge pull request #43553 from ivancich/wip-bucket-fix-pool

rgw: pass "force check filter" through SAL in bucket listing

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #43535 from Rethan/fix-image-spec
Mykola Golub [Wed, 20 Oct 2021 16:05:46 +0000 (19:05 +0300)]
Merge pull request #43535 from Rethan/fix-image-spec

rbd: correct image_spec() output when rbd-nbd Detach/Unmap error

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #43596 from ronen-fr/wip-rf-test_info
Ronen Friedman [Wed, 20 Oct 2021 15:03:22 +0000 (18:03 +0300)]
Merge pull request #43596 from ronen-fr/wip-rf-test_info

tests: modify osd-scrub-repair to match PR #43239 changes

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agodoc/cephadm: update typo in install.rst 43604/head
Zac Dover [Wed, 20 Oct 2021 14:42:02 +0000 (00:42 +1000)]
doc/cephadm: update typo in install.rst

This PR changes the string

   use "--log-to-file" option during bootstrap

to

   use the "--log-to-file" option during bootstrap

The way that it was written makes it sound like it was
written by a native Russian speaker. But it was written
by me, a native English speaker, so this is on me.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #43572 from trociny/wip-qa-backfill-toofull-compress
Neha Ojha [Wed, 20 Oct 2021 13:57:06 +0000 (06:57 -0700)]
Merge pull request #43572 from trociny/wip-qa-backfill-toofull-compress

qa/tasks/backfill_toofull: make test work when compression on

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agorgw: document rgw_lc_debug_interval configuration option 43429/head
J. Eric Ivancich [Tue, 5 Oct 2021 23:27:27 +0000 (19:27 -0400)]
rgw: document rgw_lc_debug_interval configuration option

Updates the yaml describing this config option with a "desc" and a
"long_desc".

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agodoc/start: documenting-ceph: Remove email to ceph-docs@redhat.com 43586/head
Sebastian Wagner [Tue, 19 Oct 2021 09:08:35 +0000 (11:08 +0200)]
doc/start: documenting-ceph: Remove email to ceph-docs@redhat.com

Instead get in touch with the component lead.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agodoc/start: documenting-ceph: Improve template of commits
Sebastian Wagner [Tue, 19 Oct 2021 09:07:13 +0000 (11:07 +0200)]
doc/start: documenting-ceph: Improve template of commits

by properly linking the corresponding tracker issue.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agodoc/governanace: Fix my email address
Sebastian Wagner [Tue, 19 Oct 2021 09:00:26 +0000 (11:00 +0200)]
doc/governanace: Fix my email address

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agorgw/tracing: unify SO version numbers within librgw2 package 43600/head
Nathan Cutler [Wed, 20 Oct 2021 10:51:02 +0000 (12:51 +0200)]
rgw/tracing: unify SO version numbers within librgw2 package

The librgw2 package contains several SO files. Two of those - librgw_op_tp.so
and librgw_rados_tp.so - had a different version number than the main librgw.

This was a violation of the openSUSE Shared Library Packaging Policy [1] but it
also seems like a "violation" of common sense.

[1] https://en.opensuse.org/openSUSE:Shared_library_packaging_policy#Package_naming

Fixes: https://tracker.ceph.com/issues/52979
Signed-off-by: Nathan Cutler <ncutler@suse.com>
3 years agoMerge pull request #42772 from Daniel-Pivonka/cephadm-add-existing-host
Sebastian Wagner [Wed, 20 Oct 2021 09:49:33 +0000 (11:49 +0200)]
Merge pull request #42772 from Daniel-Pivonka/cephadm-add-existing-host

mgr/cephadm: update host when adding host that already exists

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43354 from adk3798/daemon-failed-agent
Sebastian Wagner [Wed, 20 Oct 2021 09:48:42 +0000 (11:48 +0200)]
Merge pull request #43354 from adk3798/daemon-failed-agent

mgr/cephadm: update CEPHADM_FAILED_DAEMON after receiving agent metadata

Reviewed-by: Daniel Pivonka <dpivonka@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43366 from adk3798/log-list-servers
Sebastian Wagner [Wed, 20 Oct 2021 09:48:09 +0000 (11:48 +0200)]
Merge pull request #43366 from adk3798/log-list-servers

mgr/cephadm: put list_servers output in debug logs

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43367 from adk3798/handle-use-agent
Sebastian Wagner [Wed, 20 Oct 2021 09:47:41 +0000 (11:47 +0200)]
Merge pull request #43367 from adk3798/handle-use-agent

mgr/cephadm: move handling of use_agent setting into agent.py

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43489 from adk3798/clear-agent-down
Sebastian Wagner [Wed, 20 Oct 2021 09:46:17 +0000 (11:46 +0200)]
Merge pull request #43489 from adk3798/clear-agent-down

mgr/cephadm: update CEPHADM_AGENT_DOWN when agent reports in

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43552 from adk3798/dont-log-credentials
Sebastian Wagner [Wed, 20 Oct 2021 09:45:29 +0000 (11:45 +0200)]
Merge pull request #43552 from adk3798/dont-log-credentials

cephadm: do not log commands sent to "call" function

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agotests: modify osd-scrub-repair to match PR #43239 changes 43596/head
Ronen Friedman [Wed, 20 Oct 2021 06:42:51 +0000 (06:42 +0000)]
tests: modify osd-scrub-repair to match PR #43239 changes

PR #43239 has modified ECBackend::get_hash_info() behavior.
Modified the standalone scrub test to match.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #43592 from rzarzynski/wip-crimson-mount_ertr
Samuel Just [Wed, 20 Oct 2021 04:55:23 +0000 (21:55 -0700)]
Merge pull request #43592 from rzarzynski/wip-crimson-mount_ertr

crimson: errorate the FuturizedStore::mount() paths.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #42839 from giladmaya/wip-on-wire-compression-documentation
Neha Ojha [Tue, 19 Oct 2021 21:55:16 +0000 (14:55 -0700)]
Merge pull request #42839 from giladmaya/wip-on-wire-compression-documentation

doc: Added msgr on-wire-compression

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43577 from ThomasLamprecht/docs-glossary-typo
Neha Ojha [Tue, 19 Oct 2021 21:54:10 +0000 (14:54 -0700)]
Merge pull request #43577 from ThomasLamprecht/docs-glossary-typo

docs: fix case and spelling of Proxmox VE

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agocrimson: errorate the FuturizedStore::mount() paths. 43592/head
Radoslaw Zarzynski [Tue, 19 Oct 2021 20:02:57 +0000 (20:02 +0000)]
crimson: errorate the FuturizedStore::mount() paths.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge PR #43556 into master
Sage Weil [Tue, 19 Oct 2021 20:04:36 +0000 (16:04 -0400)]
Merge PR #43556 into master

* refs/pull/43556/head:
qa/suites/orch/cephadm/osds: add osd rm/zap/add test

Reviewed-by: Cory Snyder <csnyder@iland.com>
3 years agocrimson/os: move singleton_ec up to let mount() reuse it.
Radoslaw Zarzynski [Tue, 19 Oct 2021 19:24:47 +0000 (19:24 +0000)]
crimson/os: move singleton_ec up to let mount() reuse it.

No other changes in this commit.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge PR #43569 into master
Sage Weil [Tue, 19 Oct 2021 14:58:31 +0000 (10:58 -0400)]
Merge PR #43569 into master

* refs/pull/43569/head:
mgr/orchestrator: clean up 'orch device ls' output

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43486 from cbodley/wip-rgw-maintainers
Casey Bodley [Tue, 19 Oct 2021 12:53:01 +0000 (08:53 -0400)]
Merge pull request #43486 from cbodley/wip-rgw-maintainers

rgw: start on MAINTAINERS.md

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #43514 from mgfritch/cephadm-agent-binary
Sebastian Wagner [Tue, 19 Oct 2021 11:33:43 +0000 (13:33 +0200)]
Merge pull request #43514 from mgfritch/cephadm-agent-binary

cephadm: use the current cephadm binary for the agent

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #43465 from rhcs-dashboard/radosgw-grafana-dashboards
Ernesto Puerta [Tue, 19 Oct 2021 11:30:06 +0000 (13:30 +0200)]
Merge pull request #43465 from rhcs-dashboard/radosgw-grafana-dashboards

mgr/dashboard: monitoring: grafonnet refactoring for radosgw dashboards

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43370 from liewegas/fix-rook-rgw-multisite
Sebastian Wagner [Tue, 19 Oct 2021 09:34:46 +0000 (11:34 +0200)]
Merge pull request #43370 from liewegas/fix-rook-rgw-multisite

mgr/rook: describe_services: name rgw svc appropriately

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43550 from liewegas/rook-nvme
Sebastian Wagner [Tue, 19 Oct 2021 09:30:40 +0000 (11:30 +0200)]
Merge pull request #43550 from liewegas/rook-nvme

qa/suites/orch/rook/smoke: use nvme-loop

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #42526 from liewegas/dashboard-nfs
Ernesto Puerta [Tue, 19 Oct 2021 09:17:17 +0000 (11:17 +0200)]
Merge pull request #42526 from liewegas/dashboard-nfs

mgr/dashboard: consume mgr/nfs

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agomgr/dashboard: monitoring: grafonnet refactoring for cephfs dashboards 43465/head
Aashish Sharma [Fri, 8 Oct 2021 10:07:17 +0000 (15:37 +0530)]
mgr/dashboard: monitoring: grafonnet refactoring for cephfs dashboards

This PR intends to refactor cephfs dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agomgr/dashboard: monitoring: grafonnet refactoring for osds dashboards
Aashish Sharma [Fri, 8 Oct 2021 09:58:13 +0000 (15:28 +0530)]
mgr/dashboard: monitoring: grafonnet refactoring for osds dashboards

This PR intends to refactor osds dashboards using grafonnet

Fixes:https://tracker.ceph.com/issues/52777
Signed-off-by: Aashish Sharma <aasharma@redhat.com>