]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoauth: drop unused get_supported_con_modes() from AuthServer. 43689/head
Radoslaw Zarzynski [Wed, 27 Oct 2021 16:04:11 +0000 (16:04 +0000)]
auth: drop unused get_supported_con_modes() from AuthServer.

In 2d530938753313a776258ff9fa8208db637c9d96 its last user has
been removed.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #42052 from TRYTOBE8TME/wip-rgw-dpp-3
Ali Maredia [Tue, 12 Oct 2021 05:31:00 +0000 (01:31 -0400)]
Merge pull request #42052 from TRYTOBE8TME/wip-rgw-dpp-3

rgw: DPP addition 4

Reviewed-by: Ali Maredia <amaredia@redhat.com>
3 years agoMerge pull request #43181 from xxhdx1985126/wip-extent-placement-manager-multi-device-3
Samuel Just [Tue, 12 Oct 2021 05:17:52 +0000 (22:17 -0700)]
Merge pull request #43181 from xxhdx1985126/wip-extent-placement-manager-multi-device-3

crimson/os/seastore: add multi-device support

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43449 from rzarzynski/wip-crimson-interruptible-peeringevent
Samuel Just [Tue, 12 Oct 2021 01:28:42 +0000 (18:28 -0700)]
Merge pull request #43449 from rzarzynski/wip-crimson-interruptible-peeringevent

crimson/osd: implement interruptions in PeeringEvent.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43483 from cyx1231st/wip-seastore-record-header-fullness
Samuel Just [Tue, 12 Oct 2021 01:25:35 +0000 (18:25 -0700)]
Merge pull request #43483 from cyx1231st/wip-seastore-record-header-fullness

crimson/os/seastore: measure inline/ool record header fullness

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43471 from liewegas/fix-rook-1-node 43400/head
Sebastian Wagner [Mon, 11 Oct 2021 16:47:35 +0000 (18:47 +0200)]
Merge pull request #43471 from liewegas/fix-rook-1-node

qa/suites/orch/rook: replicate across osds for 1-node clusters

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43376 from Daniel-Pivonka/cephadm-apply-health
Sebastian Wagner [Mon, 11 Oct 2021 14:45:58 +0000 (16:45 +0200)]
Merge pull request #43376 from Daniel-Pivonka/cephadm-apply-health

mgr/cephadm: set HEALTH warnings during apply phase in serve

Reviewed-by: Melissa Li <mingkli@redhat.com>
3 years agoMerge pull request #43455 from liewegas/qa-nvme-loop
Sebastian Wagner [Mon, 11 Oct 2021 14:43:10 +0000 (16:43 +0200)]
Merge pull request #43455 from liewegas/qa-nvme-loop

qa: use nvme_loop devices for (some) cephadm tests

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43450 from guits/fix_selinux_apply_spec
Sebastian Wagner [Mon, 11 Oct 2021 14:40:39 +0000 (16:40 +0200)]
Merge pull request #43450 from guits/fix_selinux_apply_spec

cephadm: shell --mount shouldnt enforce ':z' option

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43458 from mgfritch/cephadm-scp
Sebastian Wagner [Mon, 11 Oct 2021 14:38:35 +0000 (16:38 +0200)]
Merge pull request #43458 from mgfritch/cephadm-scp

mgr/cephadm: use `asyncssh.scp` to write remote files

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/rook: specify failureDomain on CephObjectStore CR 43471/head
Sage Weil [Fri, 8 Oct 2021 17:28:31 +0000 (12:28 -0500)]
mgr/rook: specify failureDomain on CephObjectStore CR

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43473 from rhcs-dashboard/wip-pr_deps-master
Ernesto Puerta [Mon, 11 Oct 2021 12:52:02 +0000 (14:52 +0200)]
Merge pull request #43473 from rhcs-dashboard/wip-pr_deps-master

.github: check if PR deps are merged/closed

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43485 from rhcs-dashboard/fix-pr_triage-master
Ernesto Puerta [Mon, 11 Oct 2021 12:45:45 +0000 (14:45 +0200)]
Merge pull request #43485 from rhcs-dashboard/fix-pr_triage-master

.github/pr-triage: rename GH token

Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years ago.github/pr-triage: rename GH token 43485/head
Ernesto Puerta [Mon, 11 Oct 2021 11:05:34 +0000 (13:05 +0200)]
.github/pr-triage: rename GH token

Repo projects use GITHUB_TOKEN instead of MY_GITHUB_TOKEN:
https://github.com/srggrs/assign-one-project-github-action/blob/master/entrypoint.sh#L19

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agosrc/rgw: New commit to fix make check 42052/head
Kalpesh Pandya [Thu, 9 Sep 2021 02:41:34 +0000 (08:11 +0530)]
src/rgw: New commit to fix make check

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
3 years agosrc/rgw: DPP addition to rgw_kms.cc
Kalpesh Pandya [Mon, 21 Jun 2021 10:17:09 +0000 (15:47 +0530)]
src/rgw: DPP addition to rgw_kms.cc

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
3 years agosrc/rgw: DPP addition to rgw_keystone.cc
Kalpesh Pandya [Mon, 21 Jun 2021 08:20:25 +0000 (13:50 +0530)]
src/rgw: DPP addition to rgw_keystone.cc

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
3 years agosrc/rgw: DPP addition to rgw_sts.cc
Kalpesh Pandya [Sun, 20 Jun 2021 20:41:25 +0000 (02:11 +0530)]
src/rgw: DPP addition to rgw_sts.cc

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
3 years agoMerge pull request #43472 from rhcs-dashboard/wip-gh_action_project_dashboard-master
Ernesto Puerta [Mon, 11 Oct 2021 09:06:39 +0000 (11:06 +0200)]
Merge pull request #43472 from rhcs-dashboard/wip-gh_action_project_dashboard-master

.github: add dashboard PRs to Dashboard project

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agocrimson/os/seastore: measure inline/ool record header fullness 43483/head
Yingxin Cheng [Mon, 11 Oct 2021 08:11:22 +0000 (16:11 +0800)]
crimson/os/seastore: measure inline/ool record header fullness

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup record_size_t
Yingxin Cheng [Mon, 11 Oct 2021 08:10:22 +0000 (16:10 +0800)]
crimson/os/seastore: cleanup record_size_t

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: rename ool_write_stats_t::overhead_bytes
Yingxin Cheng [Mon, 11 Oct 2021 07:57:29 +0000 (15:57 +0800)]
crimson/os/seastore: rename ool_write_stats_t::overhead_bytes

To header_bytes to be more explicit.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #43182 from CongMinYin/fix-writesame-assert
Ilya Dryomov [Sun, 10 Oct 2021 15:33:51 +0000 (17:33 +0200)]
Merge pull request #43182 from CongMinYin/fix-writesame-assert

librbd/cache/pwl: initialize number_log_entries

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agocrimson/os/seastore/segment_cleaner: update segment_info_set_t to use segment_map_t 43181/head
Samuel Just [Wed, 6 Oct 2021 04:57:54 +0000 (21:57 -0700)]
crimson/os/seastore/segment_cleaner: update segment_info_set_t to use segment_map_t

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner: rework SpaceTracker* to use a simpler segment...
Samuel Just [Fri, 8 Oct 2021 06:17:23 +0000 (23:17 -0700)]
crimson/os/seastore/segment_cleaner: rework SpaceTracker* to use a simpler segment map type

segment_info_set_t does extra things not relevant to these structures.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore: max_device -> DEVICE_ID_MAX, clarify users
Samuel Just [Wed, 6 Oct 2021 01:14:54 +0000 (18:14 -0700)]
crimson/os/seastore: max_device -> DEVICE_ID_MAX, clarify users

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/seastore_types.h: clarify segment_id_t visibility, constants
Samuel Just [Wed, 6 Oct 2021 00:39:27 +0000 (17:39 -0700)]
crimson/os/seastore/seastore_types.h: clarify segment_id_t visibility, constants

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner: check for null in SpaceTrackerSimple constructor
Samuel Just [Fri, 8 Oct 2021 05:01:12 +0000 (22:01 -0700)]
crimson/os/seastore/segment_cleaner: check for null in SpaceTrackerSimple constructor

Since we're passing a sparse pointer vector, we need to check for null
in every user.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner.cc: adjust whitespace in init_segments()
Samuel Just [Thu, 7 Oct 2021 23:41:07 +0000 (16:41 -0700)]
crimson/os/seastore/segment_cleaner.cc: adjust whitespace in init_segments()

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner: remove unnecessary template declarations
Samuel Just [Fri, 8 Oct 2021 06:23:44 +0000 (23:23 -0700)]
crimson/os/seastore/segment_cleaner: remove unnecessary template declarations

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore: adjust segment cleaner's space counter calculation
Xuehan Xu [Mon, 13 Sep 2021 06:40:17 +0000 (14:40 +0800)]
crimson/os/seastore: adjust segment cleaner's space counter calculation

Until now, segment cleaner calculate available/used spaces assuming that only the journal
does all the writes, which is not true any more. This commit make segment cleaner track
all segment managers' empty/open segments and further calculate the various space usage
based on that information

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore: multi-device support
Xuehan Xu [Wed, 25 Aug 2021 02:35:27 +0000 (10:35 +0800)]
crimson/os/seastore: multi-device support

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore: enable SegmentCleaner to hold multiple segmented devices
Xuehan Xu [Thu, 23 Sep 2021 06:27:02 +0000 (14:27 +0800)]
crimson/os/seastore: enable SegmentCleaner to hold multiple segmented devices

For now, all segmented devices are treated the same as SEGMENTED. In the future,
there may be different kinds of segmeted devices, like SEGMENTED_NVME, SEGMENTED_SSD,
and even SEGMENTED_SATA. We plan to use a dedicated segment cleaner for each kind of
those devices, and if there are multiple devices of the same kind, they share the same
segment cleaner.

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore: change Scanner to ExtentReader
Xuehan Xu [Thu, 23 Sep 2021 06:53:39 +0000 (14:53 +0800)]
crimson/os/seastore: change Scanner to ExtentReader

This commit makes Scanner an extent reader that route read requests to the corresponding
backing devices according to the device ids encapsulated in the segment ids.

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore: make segment managers device-id aware
Xuehan Xu [Thu, 23 Sep 2021 06:30:06 +0000 (14:30 +0800)]
crimson/os/seastore: make segment managers device-id aware

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore: introduce device id into segment_id_t
Xuehan Xu [Thu, 23 Sep 2021 06:23:13 +0000 (14:23 +0800)]
crimson/os/seastore: introduce device id into segment_id_t

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoMerge pull request #43166 from rzarzynski/wip-crimson-no-subproc
Kefu Chai [Sun, 10 Oct 2021 01:42:35 +0000 (09:42 +0800)]
Merge pull request #43166 from rzarzynski/wip-crimson-no-subproc

 crush, crimson: don't support crush_location_hook as crimson lacks SubProcess

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43346 from hjwsm1989/fix-52765
Kefu Chai [Sun, 10 Oct 2021 01:42:03 +0000 (09:42 +0800)]
Merge pull request #43346 from hjwsm1989/fix-52765

tools/ceph-kvstore-tool: fix segfaults when repair the rocksdb

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43452 from adk3798/agent-perf1
Kefu Chai [Sun, 10 Oct 2021 01:41:30 +0000 (09:41 +0800)]
Merge pull request #43452 from adk3798/agent-perf1

cephadm: agent: subtract average time of previous iterations off wait time

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43401 from romoh/master
Kefu Chai [Sun, 10 Oct 2021 01:38:22 +0000 (09:38 +0800)]
Merge pull request #43401 from romoh/master

src/cephadm: Add support for mariner

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge pull request #43443 from tchaikov/wip-elapsed-in-double
Kefu Chai [Sun, 10 Oct 2021 01:36:57 +0000 (09:36 +0800)]
Merge pull request #43443 from tchaikov/wip-elapsed-in-double

msg/async/ProtocolV2: cast usec to double when converting from nsec

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: dongdong tao <dongdong.tao@canonical.com>
3 years agoMerge pull request #43343 from trociny/wip-crushdiff-compat
Yuri Weinstein [Fri, 8 Oct 2021 22:22:49 +0000 (15:22 -0700)]
Merge pull request #43343 from trociny/wip-crushdiff-compat

tools/crushdiff: support old format json dump

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43324 from neha-ojha/wip-52640
Yuri Weinstein [Fri, 8 Oct 2021 22:21:47 +0000 (15:21 -0700)]
Merge pull request #43324 from neha-ojha/wip-52640

common/options/global.yaml.in: add runtime flag for mon_max_pg_per_osd

Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
3 years agoMerge pull request #43232 from Rethan/feat-bluestore-fail-eio
Yuri Weinstein [Fri, 8 Oct 2021 22:21:08 +0000 (15:21 -0700)]
Merge pull request #43232 from Rethan/feat-bluestore-fail-eio

os/bluestore: add option for bluestore fail eio

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agoqa/tasks/nvme_loop: loop until 'nvme list' shows new devs 43455/head
Sage Weil [Fri, 8 Oct 2021 18:43:56 +0000 (13:43 -0500)]
qa/tasks/nvme_loop: loop until 'nvme list' shows new devs

Sometimes this doesn't happen immediately.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/roch/cephadm/smoke: use nvme_loop
Sage Weil [Thu, 7 Oct 2021 15:12:43 +0000 (10:12 -0500)]
qa/suites/roch/cephadm/smoke: use nvme_loop

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/orch/cephadm/smoke-roleless: no osd roles, use nvme loop
Sage Weil [Thu, 7 Oct 2021 15:11:57 +0000 (10:11 -0500)]
qa/suites/orch/cephadm/smoke-roleless: no osd roles, use nvme loop

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/overrides/nvme_loop: reusable fragment to use nvme_loop devs
Sage Weil [Thu, 7 Oct 2021 15:11:03 +0000 (10:11 -0500)]
qa/overrides/nvme_loop: reusable fragment to use nvme_loop devs

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/cephadm: wait for osds to start explicitly
Sage Weil [Tue, 5 Oct 2021 21:36:05 +0000 (16:36 -0500)]
qa/tasks/cephadm: wait for osds to start explicitly

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/cephadm: if no osd roles, --all-available-devices
Sage Weil [Tue, 5 Oct 2021 16:37:58 +0000 (11:37 -0500)]
qa/tasks/cephadm: if no osd roles, --all-available-devices

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/nvme_loop: set up nvme_loop on scratch_devs
Sage Weil [Tue, 5 Oct 2021 16:06:09 +0000 (11:06 -0500)]
qa/tasks/nvme_loop: set up nvme_loop on scratch_devs

Using an nvme loop device makes the LVs look like "real" disks,
which means we can exercise all of the normal code paths for
provisioning, deprovisioning, and zapping.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge PR #43163 into master
Patrick Donnelly [Fri, 8 Oct 2021 18:38:35 +0000 (14:38 -0400)]
Merge PR #43163 into master

* refs/pull/43163/head:
qa: fsync dir for asynchronous creat on stray tests
qa: refactor and generalize create_n_files
qa: only set frag confs for workloads
mds: improve debugging for fragment size check

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
3 years ago.github: check if PR deps are merged/closed 43473/head
Ernesto Puerta [Fri, 8 Oct 2021 17:14:17 +0000 (19:14 +0200)]
.github: check if PR deps are merged/closed

If a PR description includes `blocked by <pr>` or `depends on <pr>`,
this check will fail until the referred PRs are either merged or closed.

If this check is made required, it'll also block the merge button.

The details of the supported syntax can be checked at:
https://github.com/marketplace/actions/pr-dependency-check

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years ago.github: add dashboard PRs to Dashboard project 43472/head
Ernesto Puerta [Fri, 8 Oct 2021 16:43:25 +0000 (18:43 +0200)]
.github: add dashboard PRs to Dashboard project

This action automatically adds PRs with 'dashboard' label to the
'Dashboard' project (https://github.com/ceph/ceph/projects/6).

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoqa/suites/orch/rook: replicate across osds for 1-node clusters
Sage Weil [Fri, 8 Oct 2021 16:00:48 +0000 (11:00 -0500)]
qa/suites/orch/rook: replicate across osds for 1-node clusters

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43462 from Zhiwei-Dai/wip-test-erasure-code-for-aarch64
Kefu Chai [Fri, 8 Oct 2021 15:24:13 +0000 (23:24 +0800)]
Merge pull request #43462 from Zhiwei-Dai/wip-test-erasure-code-for-aarch64

qa: support isal ec test for aarch64

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43444 from idryomov/wip-read-from-replica-comment
Ilya Dryomov [Fri, 8 Oct 2021 11:43:27 +0000 (13:43 +0200)]
Merge pull request #43444 from idryomov/wip-read-from-replica-comment

librados,librbd: make it clear that replica reads are safe for general use

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agolibrbd/cache/pwl: initialize number_log_entries 43182/head
Yin Congmin [Thu, 16 Sep 2021 13:00:32 +0000 (13:00 +0000)]
librbd/cache/pwl: initialize number_log_entries

Using uninitialized number_log_entries cause writesame req space
calculation error. sometimes fail in TestMockCacheSSDWriteLog.writesame.

Fixes: https://tracker.ceph.com/issues/52852
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
3 years agoMerge pull request #43137 from rhcs-dashboard/fix-52480-master
Ernesto Puerta [Fri, 8 Oct 2021 08:56:30 +0000 (10:56 +0200)]
Merge pull request #43137 from rhcs-dashboard/fix-52480-master

mgr/dashboard: clean-up controllers

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43459 from cyx1231st/wip-seastore-optimize-record-overhead
Samuel Just [Fri, 8 Oct 2021 08:32:55 +0000 (01:32 -0700)]
Merge pull request #43459 from cyx1231st/wip-seastore-optimize-record-overhead

crimson/os/seastore: reduce write amplification from record overhead and implement placement hint

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoqa: support isal ec test for aarch64 43462/head
Dai Zhiwei [Fri, 8 Oct 2021 03:54:01 +0000 (11:54 +0800)]
qa: support isal ec test for aarch64

modified:   qa/standalone/erasure-code/test-erasure-code-plugins.sh
new file:   qa/suites/rados/thrash-erasure-code-isa/arch/aarch64.yaml

Signed-off-by: Dai Zhiwei <daizhiwei3@huawei.com>
3 years agocrimson/os/seastore: implement placement_hint HOT/COLD/REWRITE 43459/head
Yingxin Cheng [Fri, 8 Oct 2021 02:47:13 +0000 (10:47 +0800)]
crimson/os/seastore: implement placement_hint HOT/COLD/REWRITE

The current strategy is to inline allocate non-REWRITE extents in order
to reduce the record overhead. The observation shows the transactions
from user is usually very small and doesn't deserve to be written in ool
records, which requires at least a block to store the record metadata.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/epm: misc cleanup
Yingxin Cheng [Fri, 8 Oct 2021 02:33:28 +0000 (10:33 +0800)]
crimson/os/seastore/epm: misc cleanup

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: rename ool_placement_hint_t
Yingxin Cheng [Fri, 8 Oct 2021 02:24:26 +0000 (10:24 +0800)]
crimson/os/seastore: rename ool_placement_hint_t

To placement_hint_t as the hint is not limited to ool extents.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agomgr/cephadm: use str type for `stdin` 43458/head
Michael Fritch [Thu, 7 Oct 2021 16:17:28 +0000 (10:17 -0600)]
mgr/cephadm: use str type for `stdin`

avoid encode/decode confusion by using a str data type to both
send (stdin) and receive (stdout) data

Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agomgr/cephadm: use `asyncssh.scp` to write remote files
Michael Fritch [Thu, 7 Oct 2021 16:18:00 +0000 (10:18 -0600)]
mgr/cephadm: use `asyncssh.scp` to write remote files

`tee` via stdin happens to work when the file is a utf-8 byte encoded
string, but won't work if the file happens to be binary data

Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43248 from inspur-wyq/wip-doc
Kefu Chai [Thu, 7 Oct 2021 22:22:54 +0000 (06:22 +0800)]
Merge pull request #43248 from inspur-wyq/wip-doc

doc/rbd/vault.rst: fix typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43373 from gregsfortytwo/wip-mon-stretch-new-tiebreaker-52126
Gregory Farnum [Thu, 7 Oct 2021 22:16:23 +0000 (15:16 -0700)]
Merge pull request #43373 from gregsfortytwo/wip-mon-stretch-new-tiebreaker-52126

mon: Allow specifying new tiebreaker monitors

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43331 from adk3798/agent-drain
Kefu Chai [Thu, 7 Oct 2021 22:07:49 +0000 (06:07 +0800)]
Merge pull request #43331 from adk3798/agent-drain

mgr/cephadm: fix host drain with agent

Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/cephadm: set health check warning for apply spec failures and daemon place failur... 43376/head
Melissa Li [Thu, 5 Aug 2021 18:14:38 +0000 (14:14 -0400)]
mgr/cephadm: set health check warning for apply spec failures and daemon place failures in serve

Fixes: https://tracker.ceph.com/issues/44414
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
3 years agomgr/cephadm: set health check warning in `_apply_service_config` for invalid config...
Melissa Li [Thu, 5 Aug 2021 18:28:35 +0000 (14:28 -0400)]
mgr/cephadm: set health check warning in `_apply_service_config` for invalid config options and failures to set options

Fixes: https://tracker.ceph.com/issues/44414
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
3 years agomgr/cephadm: refactor `_check_for_strays` to use `remove_health_warning` helper
Melissa Li [Tue, 3 Aug 2021 17:50:26 +0000 (13:50 -0400)]
mgr/cephadm: refactor `_check_for_strays` to use `remove_health_warning` helper

Fixes: https://tracker.ceph.com/issues/44414
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
3 years agomgr/cephadm: refactor `_refresh_hosts_and_daemons` to use `set_health_warning` and...
Melissa Li [Tue, 3 Aug 2021 17:46:21 +0000 (13:46 -0400)]
mgr/cephadm: refactor `_refresh_hosts_and_daemons` to use `set_health_warning` and `remove_health_warning` helpers

Fixes: https://tracker.ceph.com/issues/44414
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
3 years agomgr/cephadm: refactor `_update_paused_health` to use `set_health_warning` and `remove...
Melissa Li [Tue, 3 Aug 2021 17:40:39 +0000 (13:40 -0400)]
mgr/cephadm: refactor `_update_paused_health` to use `set_health_warning` and `remove_health_warning` helpers

Fixes: https://tracker.ceph.com/issues/44414
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
3 years agomgr/cephadm: refactor `_set_maintenance_health_check` to use `set_health_warning...
Melissa Li [Tue, 3 Aug 2021 17:34:06 +0000 (13:34 -0400)]
mgr/cephadm: refactor `_set_maintenance_health_check` to use `set_health_warning` helper

Fixes: https://tracker.ceph.com/issues/44414
Signed-off-by: Melissa Li <li.melissa.kun@gmail.com>
3 years agoqa: fsync dir for asynchronous creat on stray tests 43163/head
Patrick Donnelly [Tue, 14 Sep 2021 14:58:20 +0000 (10:58 -0400)]
qa: fsync dir for asynchronous creat on stray tests

Use the enhanced create_n_files to dedup code. Also split the large test
into three.

Fixes: https://tracker.ceph.com/issues/52606
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoqa: refactor and generalize create_n_files
Patrick Donnelly [Tue, 14 Sep 2021 17:45:33 +0000 (13:45 -0400)]
qa: refactor and generalize create_n_files

Few things:

- Allow calling fsync on directory (to support async create kernel).
- Allow immediately unlinking the created file (for stray testing).
- Close any file descriptors created.
- Write unique content (the i variable) to each file.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoqa: only set frag confs for workloads
Patrick Donnelly [Wed, 6 Oct 2021 20:37:34 +0000 (16:37 -0400)]
qa: only set frag confs for workloads

Otherwise these local conf overrides prevent functional testing.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agomds: improve debugging for fragment size check
Patrick Donnelly [Wed, 6 Oct 2021 15:09:48 +0000 (11:09 -0400)]
mds: improve debugging for fragment size check

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #43442 from linuxbox2/wip-rgwadmin-logfix
Matt Benjamin [Thu, 7 Oct 2021 15:04:16 +0000 (11:04 -0400)]
Merge pull request #43442 from linuxbox2/wip-rgwadmin-logfix

qa/rgw: fix ops log tests to handle non-bucket ops (which are now valid)

3 years agocephadm: bootstrap --apply-spec shouldn't enforce :z 43450/head
Guillaume Abrioux [Thu, 7 Oct 2021 14:23:07 +0000 (16:23 +0200)]
cephadm: bootstrap --apply-spec shouldn't enforce :z

There's no need to mount this file with the `:z` option.
read-only access is enough for this file.

Fixes: https://tracker.ceph.com/issues/52855
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoMerge pull request #43448 from rzarzynski/wip-crimson-monmap-moredbgs
Kefu Chai [Thu, 7 Oct 2021 14:14:03 +0000 (22:14 +0800)]
Merge pull request #43448 from rzarzynski/wip-crimson-monmap-moredbgs

crimson, monmap: inform about errors when interacting with DNS

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agocephadm: agent: subtract average time of previous iterations off wait time 43452/head
Adam King [Thu, 7 Oct 2021 14:09:12 +0000 (10:09 -0400)]
cephadm: agent: subtract average time of previous iterations off wait time

We want the agent to actually report metadata at the rate we set
it for. Before this, that rate was just being used as the wait time
between iterations so the actual time between iterations was the
given interval plus the time to gather metadata. Now the time between
reports should actually be roughly the given interval.

Signed-off-by: Adam King <adking@redhat.com>
3 years agomsg/async/ProtocolV2: cast usec to double when converting from nsec 43443/head
Kefu Chai [Wed, 6 Oct 2021 22:38:13 +0000 (06:38 +0800)]
msg/async/ProtocolV2: cast usec to double when converting from nsec

to be consistent with the same logic in V1, and more importantly, it is
more correct.

the change was suggested by Ilya Dryomov <idryomov@redhat.com>.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge PR #43231 into master
Patrick Donnelly [Thu, 7 Oct 2021 13:16:34 +0000 (09:16 -0400)]
Merge PR #43231 into master

* refs/pull/43231/head:
qa: fix promotion test

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 years agocephadm: shell --mount shouldnt enforce ':z' option
Guillaume Abrioux [Thu, 7 Oct 2021 08:49:25 +0000 (10:49 +0200)]
cephadm: shell --mount shouldnt enforce ':z' option

cephadm shouldn't enforce this option.
For instance, it can be an issue when you try to bindmount a file in /usr

Fixes: https://tracker.ceph.com/issues/52853
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agocrimson/osd: more interruptions in PeeringEvent. 43449/head
Radoslaw Zarzynski [Wed, 6 Oct 2021 10:50:19 +0000 (10:50 +0000)]
crimson/osd: more interruptions in PeeringEvent.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson/osd: implement interruptions in PeeringEvent.
Radoslaw Zarzynski [Mon, 4 Oct 2021 14:49:24 +0000 (14:49 +0000)]
crimson/osd: implement interruptions in PeeringEvent.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson/osd: squeeze one indentation level from PeeringEvent::start().
Radoslaw Zarzynski [Mon, 4 Oct 2021 14:35:30 +0000 (14:35 +0000)]
crimson/osd: squeeze one indentation level from PeeringEvent::start().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson, monmap: inform about errors in MonMap::init_with_dns_srv(). 43448/head
Radoslaw Zarzynski [Thu, 7 Oct 2021 11:12:48 +0000 (11:12 +0000)]
crimson, monmap: inform about errors in MonMap::init_with_dns_srv().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson, monmap: limit the scope of the seastar namespace inclusion.
Radoslaw Zarzynski [Thu, 7 Oct 2021 11:04:12 +0000 (11:04 +0000)]
crimson, monmap: limit the scope of the seastar namespace inclusion.

More consistency that way. This also enables us to define the usual
`logger()` function without having a clash with `seastar::logger`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43384 from bosc0/master
Venky Shankar [Thu, 7 Oct 2021 08:40:12 +0000 (14:10 +0530)]
Merge pull request #43384 from bosc0/master

mgr: Add check to prevent mgr from crashing

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #41445 from guits/cephadm_quick_patch
Kefu Chai [Wed, 6 Oct 2021 22:48:05 +0000 (06:48 +0800)]
Merge pull request #41445 from guits/cephadm_quick_patch

cephadm: add daemon_name in daemon description

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43335 from liewegas/debug-51815
Kefu Chai [Wed, 6 Oct 2021 22:45:45 +0000 (06:45 +0800)]
Merge pull request #43335 from liewegas/debug-51815

mon,auth: fix proposal (and mon db rebuild) of rotating secrets

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43379 from myoungwon/wip-evict-range
Kefu Chai [Wed, 6 Oct 2021 22:44:33 +0000 (06:44 +0800)]
Merge pull request #43379 from myoungwon/wip-evict-range

osd: trim corresponding chunks on tier_evict

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43378 from ivancich/wip-build-without-mgr
Kefu Chai [Wed, 6 Oct 2021 22:43:25 +0000 (06:43 +0800)]
Merge pull request #43378 from ivancich/wip-build-without-mgr

rados: build minimally when "WITH_MGR" is off

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43360 from jianwei1216/fix-shard-threads-cannot-wakeup-bug
Kefu Chai [Wed, 6 Oct 2021 22:41:54 +0000 (06:41 +0800)]
Merge pull request #43360 from jianwei1216/fix-shard-threads-cannot-wakeup-bug

osd: fix shard-threads cannot wakeup bug

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43307 from taodd/recv_stamp_fix
Kefu Chai [Wed, 6 Oct 2021 22:33:21 +0000 (06:33 +0800)]
Merge pull request #43307 from taodd/recv_stamp_fix

msg/async/ProtocolV2: Set the recv_stamp at the beginning of receiving a message

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Dan Hill <daniel.hill@canonical.com>
3 years agoMerge pull request #43380 from myoungwon/wip-dont-promote-dirty
Kefu Chai [Wed, 6 Oct 2021 22:31:32 +0000 (06:31 +0800)]
Merge pull request #43380 from myoungwon/wip-dont-promote-dirty

osd: do not promote objects if op is is_dirty

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43435 from rzarzynski/wip-crimson-pickv2only
Kefu Chai [Wed, 6 Oct 2021 22:19:54 +0000 (06:19 +0800)]
Merge pull request #43435 from rzarzynski/wip-crimson-pickv2only

crimson/osd: pick only v2 addresses.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>