]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agomgr/dashboard: fix missing alert rule details 43797/head
Ernesto Puerta [Wed, 3 Nov 2021 17:57:53 +0000 (18:57 +0100)]
mgr/dashboard: fix missing alert rule details

Fixes: https://tracker.ceph.com/issues/53144
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #43790 from sebastian-philipp/doc-cephadm-purge
Sebastian Wagner [Wed, 3 Nov 2021 15:27:53 +0000 (16:27 +0100)]
Merge pull request #43790 from sebastian-philipp/doc-cephadm-purge

doc/cephadm: purge

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43659 from majianpeng/send-internal-flush-for-rbd-copy
Deepika Upadhyay [Wed, 3 Nov 2021 14:55:21 +0000 (20:25 +0530)]
Merge pull request #43659 from majianpeng/send-internal-flush-for-rbd-copy

librbd: send FLUSH_SOURCE_INTERNAL when do copy/deep_copy.

Reviewed-by: Mykola Golub <mykola.golub@clyso.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agodoc/cephadm: purge 43790/head
Sebastian Wagner [Wed, 3 Nov 2021 13:11:00 +0000 (14:11 +0100)]
doc/cephadm: purge

Fixes: https://tracker.ceph.com/issues/50534
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge PR #43786 into master
Patrick Donnelly [Wed, 3 Nov 2021 13:40:55 +0000 (09:40 -0400)]
Merge PR #43786 into master

* refs/pull/43786/head:
mds: fix typo in MDSRank.cc

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
3 years agoMerge pull request #43690 from rhcs-dashboard/improve-error-handling-get-facts-backend
Ernesto Puerta [Wed, 3 Nov 2021 13:08:32 +0000 (14:08 +0100)]
Merge pull request #43690 from rhcs-dashboard/improve-error-handling-get-facts-backend

mgr/dashboard: improve error handling for gather_facts

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomds: fix typo in MDSRank.cc 43786/head
Yongseok Oh [Wed, 3 Nov 2021 06:55:31 +0000 (06:55 +0000)]
mds: fix typo in MDSRank.cc

Signed-off-by: Yongseok Oh <yongseok.oh@linecorp.com>
3 years agoMerge pull request #43750 from zdover23/wip-doc-2021-10-30-omap-format-conversion...
zdover23 [Wed, 3 Nov 2021 03:04:35 +0000 (13:04 +1000)]
Merge pull request #43750 from zdover23/wip-doc-2021-10-30-omap-format-conversion-data-corruption-bug-admonition

doc: add admonition for tracker 53062

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #43769 from ifed01/wip-ifed-omap-upgrade-fix-notes
Neha Ojha [Tue, 2 Nov 2021 23:39:03 +0000 (16:39 -0700)]
Merge pull request #43769 from ifed01/wip-ifed-omap-upgrade-fix-notes

PendingReleaseNotes: document OMAP upgrade bug.

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoPendingReleaseNotes: document OMAP upgrade bug. 43769/head
Igor Fedotov [Tue, 2 Nov 2021 11:54:55 +0000 (14:54 +0300)]
PendingReleaseNotes: document OMAP upgrade bug.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agoMerge pull request #43762 from sebastian-philipp/doc-cephadm-ceph-monstore-tool
Sebastian Wagner [Tue, 2 Nov 2021 16:07:42 +0000 (17:07 +0100)]
Merge pull request #43762 from sebastian-philipp/doc-cephadm-ceph-monstore-tool

doc/cephadm: Calling miscellaneous ceph tools

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sage Weil <sage@newdream.net>
3 years agoMerge PR #42762 into master
Sage Weil [Tue, 2 Nov 2021 15:41:53 +0000 (11:41 -0400)]
Merge PR #42762 into master

* refs/pull/42762/head:
ceph_test_objectstore: skip BlueStoreUnshareBlobTest with SMR
os/bluestore: debug ExtentMap::update()
os/bluestore: _txc_create inside of alloc_and_submit_lock
os/bluestore: fix cleaner race with collection removal
os/bluestore: add missing ' ' to LruOnodeCacheShare _[un]pin
os/bluestore: use simpler map<> to track (onode, zone) -> offset
os/bluestore: avoid casting zoned implementations again
os/bluestore/ZonedFreelistManager: remove sanity checks
os/bluestore/ZonedAllocator: fix allocate() search
os/bluestore: drain transactions on cleaner zone finish
os/bluestore/ZonedFreelistManager: simplify freelist merge update vs zone reset
os/bluetore: configurable sleep period for cleaner
blk/zoned: make discard a no-op
os/bluestore/ZonedAllocator: count sequential only as 'free'
os/bluestore: expect smr fields IFF device is smr
ceph_test_objectstore: Test for fixing write pointer
ceph_test_objectstore: complain if SMR support not compiled in
test/objectstore/run_smr_bluestore_test.sh
os/bluestore/ZonedAllocator: handle alloc/release spanning zones
os/bluestore: simple cleaner
os/bluestore: be smarter about picking a zone to clean
os/bluestore: avoid writes to cleaning zone
os/bluestore/HybridAllocator: whitespace in debug output
os/bluestore: give conventional region of SMR to bluefs
os/bluestore: separate alloc pointer from shared_alloc.a
test/objectstore/run_smr_bluestore_test.sh
ceph_test_objectstore: skip tests that don't work on SMR
os/bluestore: disable cleaner thread until it is implemented
os/bluestore: fsck verify zone refs
os/bluestore: include object in zone ref keys
os/bluestore: refactor object key helpers a bit
ceph_test_objectstore: skip failing tests on SMR
os/bluestore: report mismatch write pointer during fsck
os/bluestore: simplify zone to clean selection
ceph_test_objectstore: add trivial fsck test
os/bluestore: fsck smr allocations (verify num_dead_bytes, alloc past write pointer)
os/bluestore: duplicate zone refs when cloning
os/bluestore: correct zoned freelist when device write pointers are ahead
os/bluestore/ZonedFreelistManager: whitespace
os/bluestore: fix startup vs device write pointers
blk/zoned: add get_zones() to fetch write pointers
os/bluestore: use 64 bit values for zone_state_t
os/bluestore: reimplement zone backrefs
os/bluestore: fix smr allocator init
os/bluestore: do not use null freelist with SMR
blk/zones: implement HMSMRDevice has KernelDevice child
os/bluestore: fix/simplify zoned_cleaner thread start error handling
os/bluestore: properly reset zoned allocator on startup
os/bluestore: force prefer_deferred_size=0 for smr
os/bluestore: drop SMR 64K min_alloc_size restriction
os/bluestore/ZonedAllocator: less verbose
os/bluestore/ZonedAllocator: simplify debug output prefix
os/bluestore/ZonedAllocator: be consistent with hex debug output
os/bluestore/ZonedAllocator: whitespace
blk/zoned: remove dead VDO code
blk/zoned: add reset_all_zones()
blk/zoned: print error during init
os/bluestore: adjust allocator+freelist interfaces for smr params
os/bluestore: select 'zoned' freelistmanager during mkfs, not mount

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agodoc/cephadm: Calling miscellaneous ceph tools 43762/head
Sebastian Wagner [Mon, 1 Nov 2021 21:37:55 +0000 (22:37 +0100)]
doc/cephadm: Calling miscellaneous ceph tools

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43626 from curtbruns/rgw_example
Yuval Lifshitz [Tue, 2 Nov 2021 12:16:44 +0000 (14:16 +0200)]
Merge pull request #43626 from curtbruns/rgw_example

rgw/lua: Example read/write of StorageClass field

3 years agoMerge pull request #43765 from inspur-wyq/wip-doc-4
Kefu Chai [Tue, 2 Nov 2021 11:32:41 +0000 (19:32 +0800)]
Merge pull request #43765 from inspur-wyq/wip-doc-4

doc/rbd/rbd-mirroring.rst: fix typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43628 from pcuzner/cephadm-remove-zram-devices
Sebastian Wagner [Tue, 2 Nov 2021 08:50:35 +0000 (09:50 +0100)]
Merge pull request #43628 from pcuzner/cephadm-remove-zram-devices

cephadm: exclude zram and cdrom from device list

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43766 from inspur-wyq/wip-doc2
Kefu Chai [Tue, 2 Nov 2021 02:09:07 +0000 (10:09 +0800)]
Merge pull request #43766 from inspur-wyq/wip-doc2

doc/radosgw/s3-notification-compatibility.rst: fix typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agodoc/radosgw/s3-notification-compatibility.rst: fix typos 43766/head
wangyunqing [Wed, 22 Sep 2021 03:05:40 +0000 (11:05 +0800)]
doc/radosgw/s3-notification-compatibility.rst: fix typos

Signed-off-by: wangyunqing <wangyunqing@inspur.com>
3 years agoMerge pull request #43742 from ljflores/wip-teuthology-subset
Neha Ojha [Tue, 2 Nov 2021 01:12:52 +0000 (18:12 -0700)]
Merge pull request #43742 from ljflores/wip-teuthology-subset

doc/dev/developer_guide/testing_integration_tests: update "frequently used options"

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/dev/developer_guide/testing_integration_tests: update "frequently used options" 43742/head
Laura Flores [Tue, 2 Nov 2021 00:31:16 +0000 (00:31 +0000)]
doc/dev/developer_guide/testing_integration_tests: update "frequently used options"

The `subset` option is important in Teuthology runs for reducing the number of tests that are triggered. This option is outlined in another part of the Teuthology documentation, but I think it's important to place here as well.

Also, -n (for how many times the job will run) is incorrect; it should be -N.

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agorgw/lua: Example read/write of StorageClass field 43626/head
Curt Bruns [Thu, 21 Oct 2021 21:53:31 +0000 (17:53 -0400)]
rgw/lua: Example read/write of StorageClass field

Admins may setup different pools for RGW objects and
having the StorageClass field mutable allows the steering
of RGW objects to the proper pools.  This Lua example shows
how a user can modify the StorageClass header when
it is empty on a PUT request and steer objects to different
pools based on size (Request.ContentLength).

Signed-off-by: Curt Bruns <curt.e.bruns@gmail.com>
3 years agoMerge PR #43101 into master
Sage Weil [Mon, 1 Nov 2021 19:27:13 +0000 (15:27 -0400)]
Merge PR #43101 into master

* refs/pull/43101/head:
mgr/rook: implement apply rbd-mirror

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
3 years agoMerge pull request #43687 from ifed01/wip-ifed-fix-omap-upgrade
Neha Ojha [Mon, 1 Nov 2021 19:13:28 +0000 (12:13 -0700)]
Merge pull request #43687 from ifed01/wip-ifed-fix-omap-upgrade

os/bluestore: fix invalid omap name conversion when upgrading to per-pg.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-By: Neha Ojha <nojha@redhat.com>
3 years agoMerge PR #43296 into master
Patrick Donnelly [Mon, 1 Nov 2021 18:48:06 +0000 (14:48 -0400)]
Merge PR #43296 into master

* refs/pull/43296/head:
mds: improve mds_bal_fragment_size_max config option

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
3 years agoMerge PR #40514 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:36:21 +0000 (12:36 -0400)]
Merge PR #40514 into master

* refs/pull/40514/head:
cephfs-top: add read/write average io sizes support
cephfs-top: add read/write io speed support
mds: add read/write io size metric support

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43582 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:35:02 +0000 (12:35 -0400)]
Merge PR #43582 into master

* refs/pull/43582/head:
mgr/volumes/fs/operations/versions: fix various flake8 issues

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43590 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:34:14 +0000 (12:34 -0400)]
Merge PR #43590 into master

* refs/pull/43590/head:
qa: test that new mounts of same fs function after old mount is evicted
qa: remove REQUIRE_KCLIENT_REMOTE

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
3 years agoMerge PR #43595 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:33:06 +0000 (12:33 -0400)]
Merge PR #43595 into master

* refs/pull/43595/head:
client: do not defer releasing caps when revoking

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43717 into master
Patrick Donnelly [Mon, 1 Nov 2021 15:53:20 +0000 (11:53 -0400)]
Merge PR #43717 into master

* refs/pull/43717/head:
script: update ceph-debug-docker for centos:stream

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
3 years agoMerge pull request #43751 from cbodley/wip-rgw-ops-log-cond
Casey Bodley [Mon, 1 Nov 2021 15:13:26 +0000 (11:13 -0400)]
Merge pull request #43751 from cbodley/wip-rgw-ops-log-cond

rgw: fix debug build of OpsLogFile

Reviewed-by: Cory Snyder <csnyder@iland.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agoMerge pull request #43647 from adk3798/agent-on-off-tests
Sebastian Wagner [Mon, 1 Nov 2021 14:43:10 +0000 (15:43 +0100)]
Merge pull request #43647 from adk3798/agent-on-off-tests

qa/suites/orch/cephadm: test with agent on/off

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43454 from Daniel-Pivonka/cephadm-daemon-postactions-bydaemon
Sebastian Wagner [Mon, 1 Nov 2021 14:27:26 +0000 (15:27 +0100)]
Merge pull request #43454 from Daniel-Pivonka/cephadm-daemon-postactions-bydaemon

mgr/cephadm: track daemon deployment post actions by daemon name instead of type

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #42838 from Daniel-Pivonka/cephadm-apply-spec-traceback
Sebastian Wagner [Mon, 1 Nov 2021 13:49:02 +0000 (14:49 +0100)]
Merge pull request #42838 from Daniel-Pivonka/cephadm-apply-spec-traceback

cephadm: fix tracebacks that could occur during apply spec

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43127 from majianpeng/librbd-pwl-flush-reorder
Deepika Upadhyay [Mon, 1 Nov 2021 07:01:04 +0000 (12:31 +0530)]
Merge pull request #43127 from majianpeng/librbd-pwl-flush-reorder

librbd/cache/pwl: fix reorder when flush cache-data to osd.

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #43749 from tchaikov/wip-seastore-cleanup
Kefu Chai [Mon, 1 Nov 2021 04:39:06 +0000 (12:39 +0800)]
Merge pull request #43749 from tchaikov/wip-seastore-cleanup

crimson/os/seastore: minor cleanups

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agolibrbd/cache/pwl: fix reorder when flush cache-data to osd. 43127/head
Jianpeng Ma [Mon, 1 Nov 2021 01:25:52 +0000 (09:25 +0800)]
librbd/cache/pwl: fix reorder when flush cache-data to osd.

Consider the following workload:
writeA(0, 4096)
writeB(0, 512).
pwl can makre sure writeA persist to cache before writeB.
But when flush to osd, it use async-read to read data from cache and in
the callback function they issue write to osd.
So although we by order issue aio-read(4096), aio-read(512). But we
can't make sure the return order.
If aio-read(512) firstly return, the write order to next layer is
writeB(0, 512)
writeA(0, 4096).
This is wrong from the user point.

To avoid this occur, we should firstly read all data from cache. And
then send write by order.

Fiexs: https://tracker.ceph.com/issues/52511

Tested-by: Feng Hualong <hualong.feng@intel.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
3 years agolibrbd: send FLUSH_SOURCE_INTERNAL when do copy/deep_copy. 43659/head
Jianpeng Ma [Mon, 1 Nov 2021 00:33:23 +0000 (08:33 +0800)]
librbd: send FLUSH_SOURCE_INTERNAL when do copy/deep_copy.

copy/deep_copy use object_map to judge whether object exist.
If w/ librbdo pwl cache, flush can't flush data to osd which
change objectmap state. So we should send flush w/ FLUSH_SOURCE_INTERNAL
to make data flush to osd.

Fixes:https://tracker.ceph.com/issues/53057
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
3 years agoMerge pull request #43676 from zdover23/wip-doc-2021-10-26-rados-config-storage_devices
zdover23 [Sun, 31 Oct 2021 05:17:33 +0000 (15:17 +1000)]
Merge pull request #43676 from zdover23/wip-doc-2021-10-26-rados-config-storage_devices

doc/rados: storage-devices.rst rewrite

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agorgw: fix debug build of OpsLogFile 43751/head
Casey Bodley [Sun, 31 Oct 2021 00:26:21 +0000 (20:26 -0400)]
rgw: fix debug build of OpsLogFile

can't use ceph::mutex locks with std::condition_variable::wait() in
debug builds. use the ceph::condition_variable wrapper instead

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge PR #43734 into master
Sage Weil [Sat, 30 Oct 2021 19:51:31 +0000 (15:51 -0400)]
Merge PR #43734 into master

* refs/pull/43734/head:
cephadm: --config-json overrides --config or --keyring args

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge PR #43743 into master
Sage Weil [Sat, 30 Oct 2021 19:51:04 +0000 (15:51 -0400)]
Merge PR #43743 into master

* refs/pull/43743/head:
mgr/nfs/export: use tool_exec() instead of private _exec()
pybind/mgr/mgr_module: add tool_exec() command

Reviewed-by: Sage Weil <sage@redhat.com>
3 years agoMerge pull request #43654 from adk3798/limit-info
Sebastian Wagner [Sat, 30 Oct 2021 18:47:32 +0000 (20:47 +0200)]
Merge pull request #43654 from adk3798/limit-info

mgr/cephadm: inform users if limit set for data devices is not met

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43606 from adk3798/suppress-tls-error
Sebastian Wagner [Sat, 30 Oct 2021 18:46:48 +0000 (20:46 +0200)]
Merge pull request #43606 from adk3798/suppress-tls-error

mgr/cephadm: suppress TLSV1_ALERT_DECRYPT_ERROR from cherrypy

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agodoc/cephadm: add admonition for tracker 53062 43750/head
Zac Dover [Sat, 30 Oct 2021 15:56:44 +0000 (01:56 +1000)]
doc/cephadm: add admonition for tracker 53062

NOTE: This commit also adds an admonition to the pacific.rst
      page, in the /releases directory.

This commit warns users not to upgrade to Ceph v16 (Pacific). Upgrading
to v16 (Pacific) can cause data corruption.

This commit has been made in response to https://tracker.ceph.com/issues/53062
and in response to Stefan Kooman's urgent request that we update the
documentation, adding a warning to the documentation to prevent users
from upgrading to v16.2.6.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agocrimson/os/seastore: minor cleanups 43749/head
Kefu Chai [Sat, 30 Oct 2021 07:40:40 +0000 (15:40 +0800)]
crimson/os/seastore: minor cleanups

* pass string by reference. more consistent this way.
* set a bl using list::append(), simpler this way.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43657 from liu-chunmei/osd_meta_to_file
Samuel Just [Sat, 30 Oct 2021 06:46:24 +0000 (23:46 -0700)]
Merge pull request #43657 from liu-chunmei/osd_meta_to_file

crimson: osd meta read from/write to file.

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agotest/crimson/seastore/test_transaction_manager_test_state: add mock MDStore 43657/head
Samuel Just [Thu, 28 Oct 2021 09:50:16 +0000 (02:50 -0700)]
test/crimson/seastore/test_transaction_manager_test_state: add mock MDStore

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/seastore: factor out MDStore interface
Samuel Just [Thu, 28 Oct 2021 08:37:13 +0000 (01:37 -0700)]
crimson/os/seastore/seastore: factor out MDStore interface

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson: check mkfs_done before seastore do mkfs
chunmei-liu [Wed, 27 Oct 2021 03:23:27 +0000 (20:23 -0700)]
crimson: check mkfs_done before seastore do mkfs

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson: write some other osd metas
chunmei-liu [Sun, 24 Oct 2021 22:06:28 +0000 (15:06 -0700)]
crimson: write some other osd metas

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson: osd meta data read from and write to files
chunmei-liu [Sun, 24 Oct 2021 21:41:32 +0000 (14:41 -0700)]
crimson: osd meta data read from and write to files

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agomgr/nfs/export: use tool_exec() instead of private _exec() 43743/head
Sage Weil [Fri, 29 Oct 2021 15:27:50 +0000 (11:27 -0400)]
mgr/nfs/export: use tool_exec() instead of private _exec()

Fixes: https://tracker.ceph.com/issues/53096
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agopybind/mgr/mgr_module: add tool_exec() command
Sage Weil [Thu, 28 Oct 2021 22:11:38 +0000 (18:11 -0400)]
pybind/mgr/mgr_module: add tool_exec() command

Run a (ceph) tool with the appropriate keyring and entity name.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43625 from alimaredia/wip-marcus-teuthvault-2
Casey Bodley [Fri, 29 Oct 2021 19:14:03 +0000 (15:14 -0400)]
Merge pull request #43625 from alimaredia/wip-marcus-teuthvault-2

qa/rgw: Fix vault token file access.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge PR #43736 into master
Sage Weil [Fri, 29 Oct 2021 18:55:02 +0000 (14:55 -0400)]
Merge PR #43736 into master

* refs/pull/43736/head:
Revert "Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master"

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43738 from rishabh-d-dave/mgr-dash-pyfakefs
Ernesto Puerta [Fri, 29 Oct 2021 16:52:44 +0000 (18:52 +0200)]
Merge pull request #43738 from rishabh-d-dave/mgr-dash-pyfakefs

mgr/dashboard: all pyfakefs must be pinned on same version

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: ljflores <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rishabh-d-dave <NOT@FOUND>
3 years agoMerge pull request #43733 from neha-ojha/wip-fix-octopusx
Yuri Weinstein [Fri, 29 Oct 2021 16:45:37 +0000 (09:45 -0700)]
Merge pull request #43733 from neha-ojha/wip-fix-octopusx

qa/suites/upgrade/octopus-x: exclude ceph-volume

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
3 years agoMerge pull request #43329 from cfsnyder/wip-48752-generalize-ops-log-socket
Matt Benjamin [Fri, 29 Oct 2021 16:19:59 +0000 (12:19 -0400)]
Merge pull request #43329 from cfsnyder/wip-48752-generalize-ops-log-socket

rgw: add abstraction for ops log destination and add file logger

3 years agomgr/dashboard: all pyfakefs must be pinned on same version 43738/head
Rishabh Dave [Fri, 29 Oct 2021 15:04:12 +0000 (20:34 +0530)]
mgr/dashboard: all pyfakefs must be pinned on same version

Without this patch execution of install-deps.sh fails with an error.

Fixes: https://tracker.ceph.com/issues/53088
Signed-off-by: Rishabh Dave <ridave@redhat.com>
3 years agoRevert "Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master" 43736/head
Sage Weil [Fri, 29 Oct 2021 14:53:43 +0000 (09:53 -0500)]
Revert "Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master"

This reverts commit 78d6ac0d35e8db037bb0f42935528cc9fecf2d84, reversing
changes made to 9a8de97f7af473a6a773323a463dc6603d7f4d39.

This broke cephadm (infers config when it should not)

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agocephadm: --config-json overrides --config or --keyring args 43734/head
Sage Weil [Fri, 29 Oct 2021 14:49:17 +0000 (09:49 -0500)]
cephadm: --config-json overrides --config or --keyring args

These args aren't normally combined, but if --fsid and --name are
provided, they may be inferred.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43706 from neha-ojha/wip-doc-corr
Neha Ojha [Fri, 29 Oct 2021 14:34:41 +0000 (07:34 -0700)]
Merge pull request #43706 from neha-ojha/wip-doc-corr

doc/releases/pacific.rst: add note about data corruption bug

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #43714 from ceph/wip-yuriw-crontab-master
Yuri Weinstein [Fri, 29 Oct 2021 14:15:31 +0000 (07:15 -0700)]
Merge pull request #43714 from ceph/wip-yuriw-crontab-master

qa/tests: added back octopus-x run on master

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoceph_test_objectstore: skip BlueStoreUnshareBlobTest with SMR 42762/head
Sage Weil [Wed, 20 Oct 2021 13:51:20 +0000 (08:51 -0500)]
ceph_test_objectstore: skip BlueStoreUnshareBlobTest with SMR

non-deterministic

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: debug ExtentMap::update()
Sage Weil [Tue, 19 Oct 2021 22:04:34 +0000 (17:04 -0500)]
os/bluestore: debug ExtentMap::update()

I hit a case where the shard key size didn't match, and it looked as though
this code somehow didn't get executed.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: _txc_create inside of alloc_and_submit_lock
Sage Weil [Tue, 19 Oct 2021 21:28:55 +0000 (16:28 -0500)]
os/bluestore: _txc_create inside of alloc_and_submit_lock

Create the transaction inside of the SMR lock.  Otherwise, we may get a
deadlock between the cleaner C and a normal write op W:

W                         C
_txc_create seq 1
                          lock alloc_and_submit
                          _txc_create seq 2
                          ...
                          unlock alloc_and_submit
lock alloc_and_submit
...
block on flush
                          _txc_finish_io, but blocked by seq 1
<deadlock>

The root issue here is the txc's are misordered with respect to the
alloc_and_submit lock.

Fix by moving the _txc_create inside the lock!

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: fix cleaner race with collection removal
Sage Weil [Tue, 19 Oct 2021 20:09:37 +0000 (15:09 -0500)]
os/bluestore: fix cleaner race with collection removal

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: add missing ' ' to LruOnodeCacheShare _[un]pin
Sage Weil [Tue, 19 Oct 2021 15:39:45 +0000 (10:39 -0500)]
os/bluestore: add missing ' ' to LruOnodeCacheShare _[un]pin

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: use simpler map<> to track (onode, zone) -> offset
Sage Weil [Mon, 18 Oct 2021 19:28:42 +0000 (14:28 -0500)]
os/bluestore: use simpler map<> to track (onode, zone) -> offset

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: avoid casting zoned implementations again
Sage Weil [Mon, 18 Oct 2021 19:23:20 +0000 (14:23 -0500)]
os/bluestore: avoid casting zoned implementations again

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore/ZonedFreelistManager: remove sanity checks
Sage Weil [Mon, 18 Oct 2021 19:10:15 +0000 (14:10 -0500)]
os/bluestore/ZonedFreelistManager: remove sanity checks

These were there when I was using the merge operator; not really needed
since it's just setting zeroed values now.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore/ZonedAllocator: fix allocate() search
Sage Weil [Mon, 18 Oct 2021 17:30:29 +0000 (12:30 -0500)]
os/bluestore/ZonedAllocator: fix allocate() search

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: drain transactions on cleaner zone finish
Sage Weil [Fri, 1 Oct 2021 20:54:04 +0000 (15:54 -0500)]
os/bluestore: drain transactions on cleaner zone finish

Make sure all open transactions (the ones from the cleaner especially)
get drained before we clear the device zone.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore/ZonedFreelistManager: simplify freelist merge update vs zone reset
Sage Weil [Fri, 1 Oct 2021 18:14:26 +0000 (13:14 -0500)]
os/bluestore/ZonedFreelistManager: simplify freelist merge update vs zone reset

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluetore: configurable sleep period for cleaner
Sage Weil [Fri, 1 Oct 2021 18:02:24 +0000 (13:02 -0500)]
os/bluetore: configurable sleep period for cleaner

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoblk/zoned: make discard a no-op
Sage Weil [Fri, 1 Oct 2021 17:50:21 +0000 (12:50 -0500)]
blk/zoned: make discard a no-op

Discard is meaningless on SMR or ZNS since we are always explicitly
managing the reset of entire zones.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore/ZonedAllocator: count sequential only as 'free'
Sage Weil [Fri, 1 Oct 2021 17:43:23 +0000 (12:43 -0500)]
os/bluestore/ZonedAllocator: count sequential only as 'free'

Completely ignore the conventional region of the device.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: expect smr fields IFF device is smr
Sage Weil [Fri, 1 Oct 2021 14:44:34 +0000 (09:44 -0500)]
os/bluestore: expect smr fields IFF device is smr

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoceph_test_objectstore: Test for fixing write pointer
Adam Kupczyk [Wed, 22 Sep 2021 13:18:49 +0000 (15:18 +0200)]
ceph_test_objectstore: Test for fixing write pointer

Test for checking if bluestore mount() can nicely handle unexpected
change of SMR sequential zone write pointer.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoceph_test_objectstore: complain if SMR support not compiled in
Adam Kupczyk [Fri, 17 Sep 2021 10:22:58 +0000 (12:22 +0200)]
ceph_test_objectstore: complain if SMR support not compiled in

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agotest/objectstore/run_smr_bluestore_test.sh
Adam Kupczyk [Fri, 17 Sep 2021 10:22:02 +0000 (12:22 +0200)]
test/objectstore/run_smr_bluestore_test.sh

Added execution permissions.
Modified script to account for different lsscsi outputs (7th column was not device path on Ubuntu 20.04).
Added comments.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoos/bluestore/ZonedAllocator: handle alloc/release spanning zones
Sage Weil [Thu, 23 Sep 2021 15:23:11 +0000 (10:23 -0500)]
os/bluestore/ZonedAllocator: handle alloc/release spanning zones

The same txn may allocate the end of one zone and the start of the next.
These get combined in an interval_set in bluestore and submitted as one
extent to the freelist.  Ensure that we spread the allocate (or release)
over the appropriate zones.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: simple cleaner
Sage Weil [Fri, 17 Sep 2021 19:14:51 +0000 (14:14 -0500)]
os/bluestore: simple cleaner

Rewrite object ranges to move by reusing _do_read and _do_write.  Note that
this will rewrite shared/cloned extents multiple times, so it is
suitable only for workloads/datasets that do not use clone (snapshots).

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: be smarter about picking a zone to clean
Sage Weil [Fri, 17 Sep 2021 18:54:42 +0000 (13:54 -0500)]
os/bluestore: be smarter about picking a zone to clean

Base our selection on best "value" (benefit / cost).

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: avoid writes to cleaning zone
Sage Weil [Fri, 17 Sep 2021 17:38:34 +0000 (12:38 -0500)]
os/bluestore: avoid writes to cleaning zone

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore/HybridAllocator: whitespace in debug output
Sage Weil [Thu, 16 Sep 2021 17:10:07 +0000 (12:10 -0500)]
os/bluestore/HybridAllocator: whitespace in debug output

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: give conventional region of SMR to bluefs
Sage Weil [Thu, 16 Sep 2021 17:09:54 +0000 (12:09 -0500)]
os/bluestore: give conventional region of SMR to bluefs

Let bluefs use the conventional region of an SMR HDD.  It won't be able to
use the sequential region if it runs out of space, but it does mean that
bluefs can function on an SMR drive without a dedicated db/wal device.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: separate alloc pointer from shared_alloc.a
Sage Weil [Thu, 16 Sep 2021 16:26:48 +0000 (11:26 -0500)]
os/bluestore: separate alloc pointer from shared_alloc.a

For the moment, these are always the same, so no change in functionality
form this patch.  In a future patch these may be different.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agotest/objectstore/run_smr_bluestore_test.sh
Sage Weil [Fri, 10 Sep 2021 20:25:36 +0000 (15:25 -0500)]
test/objectstore/run_smr_bluestore_test.sh

Needs sudo/root to set up.

Requires tcmu-runner and targetcli be installed (and a sufficiently
new kernel, not sure what the exact version is!).

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoceph_test_objectstore: skip tests that don't work on SMR
Sage Weil [Fri, 10 Sep 2021 18:50:19 +0000 (13:50 -0500)]
ceph_test_objectstore: skip tests that don't work on SMR

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: disable cleaner thread until it is implemented
Sage Weil [Thu, 9 Sep 2021 17:08:55 +0000 (12:08 -0500)]
os/bluestore: disable cleaner thread until it is implemented

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: fsck verify zone refs
Sage Weil [Thu, 9 Sep 2021 16:59:48 +0000 (11:59 -0500)]
os/bluestore: fsck verify zone refs

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: include object in zone ref keys
Sage Weil [Thu, 9 Sep 2021 16:16:29 +0000 (11:16 -0500)]
os/bluestore: include object in zone ref keys

We may have multiple objects referencing the same offset in the same
zone if the object gets cloned.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: refactor object key helpers a bit
Sage Weil [Thu, 9 Sep 2021 16:15:22 +0000 (11:15 -0500)]
os/bluestore: refactor object key helpers a bit

We want methods that work on partial keys.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoceph_test_objectstore: skip failing tests on SMR
Sage Weil [Thu, 9 Sep 2021 14:59:25 +0000 (09:59 -0500)]
ceph_test_objectstore: skip failing tests on SMR

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: report mismatch write pointer during fsck
Sage Weil [Thu, 9 Sep 2021 13:06:19 +0000 (08:06 -0500)]
os/bluestore: report mismatch write pointer during fsck

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: simplify zone to clean selection
Sage Weil [Wed, 8 Sep 2021 16:37:26 +0000 (11:37 -0500)]
os/bluestore: simplify zone to clean selection

Only pick one zone to clean based on the current.  Since the best victim
may change (maybe another zone gets a bunch of releases and new dead
bytes!) there is no reason (yet) to explicitly avoid the victim zone
during allocation.  There is also no need to track which zones we are
cleaning on disk because we can choose to clean from any zone at any time,
and in general want to clean from the best candidate at the time, not the
one that looked the best some time in the past.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoceph_test_objectstore: add trivial fsck test
Sage Weil [Wed, 8 Sep 2021 15:45:50 +0000 (10:45 -0500)]
ceph_test_objectstore: add trivial fsck test

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: fsck smr allocations (verify num_dead_bytes, alloc past write pointer)
Sage Weil [Wed, 8 Sep 2021 15:30:24 +0000 (10:30 -0500)]
os/bluestore: fsck smr allocations (verify num_dead_bytes, alloc past write pointer)

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoos/bluestore: duplicate zone refs when cloning
Sage Weil [Tue, 7 Sep 2021 21:56:14 +0000 (16:56 -0500)]
os/bluestore: duplicate zone refs when cloning

When we clone an object, add zone refs pointing to the new object for
any relevant extents.

This is only half of the solution; we will want to make sure the cleaner
is clever enough to keep shared blobs shared when they are relocated.

Signed-off-by: Sage Weil <sage@newdream.net>