]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agocrimson: eliminate warning for unused variable 44718/head
chunmei-liu [Tue, 25 Jan 2022 01:36:23 +0000 (17:36 -0800)]
crimson: eliminate warning for unused variable

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson: fix split_pin_left assert_aligned
chunmei-liu [Fri, 21 Jan 2022 16:22:59 +0000 (08:22 -0800)]
crimson: fix split_pin_left assert_aligned

hint passed to lba alloc_extent may not be block size aligned
in a certain case, this hint insert lba tree as key, so make
laddr in lba tree is not aligned.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agoMerge pull request #44737 from adamemerson/wip-wrong-modelines
Adam C. Emerson [Mon, 24 Jan 2022 17:26:03 +0000 (12:26 -0500)]
Merge pull request #44737 from adamemerson/wip-wrong-modelines

cleanup: Change incorrect modelines

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge PR #44574 into master
Patrick Donnelly [Mon, 24 Jan 2022 14:32:48 +0000 (09:32 -0500)]
Merge PR #44574 into master

* refs/pull/44574/head:
qa: Add syslog ignore list

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #44714 from idryomov/wip-rbd-mirror-delprop-races
Ilya Dryomov [Mon, 24 Jan 2022 10:43:56 +0000 (11:43 +0100)]
Merge pull request #44714 from idryomov/wip-rbd-mirror-delprop-races

rbd-mirror: fix races in snapshot-based mirroring deletion propagation

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #42993 from ronen-fr/wip-ronenf-scrub-be2
Ronen Friedman [Mon, 24 Jan 2022 09:07:31 +0000 (11:07 +0200)]
Merge pull request #42993 from ronen-fr/wip-ronenf-scrub-be2

osd/scrub: extracting scrub "backend" functionality

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #44744 from ronen-fr/wip-rf-lost-update
Ronen Friedman [Mon, 24 Jan 2022 08:57:04 +0000 (10:57 +0200)]
Merge pull request #44744 from ronen-fr/wip-rf-lost-update

scrub/osd: add a missing 'publish stats to osd'

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
3 years agoMerge pull request #44649 from cyx1231st/wip-crimson-improve-log-cache
Yingxin [Mon, 24 Jan 2022 01:37:01 +0000 (09:37 +0800)]
Merge pull request #44649 from cyx1231st/wip-crimson-improve-log-cache

crimson/os/seastore: consolidate seastore_t and seastore_cache logs

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoscrub/osd: add a missing 'publish stats to osd' 44744/head
Ronen Friedman [Sun, 23 Jan 2022 06:54:58 +0000 (08:54 +0200)]
scrub/osd: add a missing 'publish stats to osd'

to publish the last scrub status report.
The change is needed following the merge of
PR #42735.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44572 from 5cs/fix-spdk-cmake
Kefu Chai [Sat, 22 Jan 2022 11:51:58 +0000 (19:51 +0800)]
Merge pull request #44572 from 5cs/fix-spdk-cmake

cmake/modules/BuildSPDK.cmake: link whole-archive

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoosd/scrub: change missing_digest fix-list type 42993/head
Ronen Friedman [Thu, 13 Jan 2022 09:22:11 +0000 (09:22 +0000)]
osd/scrub: change missing_digest fix-list type

...allowing for efficient creation and, more important,
direct consumption by the function performing the
actual I/O.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd/scrub: scrub components embedded documentation
Ronen Friedman [Thu, 30 Dec 2021 13:04:58 +0000 (13:04 +0000)]
osd/scrub: scrub components embedded documentation

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd/scrub: add to PgScrubber a local ref to next-scrub's details
Ronen Friedman [Thu, 30 Dec 2021 13:01:24 +0000 (13:01 +0000)]
osd/scrub: add to PgScrubber a local ref to next-scrub's details

The owner is still the PG.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
osd/scrub: removing PgScrubber's ref to the primary scrub map

as caching this reference (to an object that is owned by the
scrubber backend) creates a dangling-pointer risk.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44669 from idryomov/wip-rbd-switch-arguments-fix
Ilya Dryomov [Sat, 22 Jan 2022 09:37:20 +0000 (10:37 +0100)]
Merge pull request #44669 from idryomov/wip-rbd-switch-arguments-fix

rbd: add missing switch arguments for recognition by get_command_spec()

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoosd/scrub: minor fixes split from main "scrub backend" commit
Ronen Friedman [Wed, 1 Dec 2021 11:37:04 +0000 (11:37 +0000)]
osd/scrub: minor fixes split from main "scrub backend" commit

Reformatting, minor compiler warnings, etc.
Split from "osd/scrub: extract scrub backend code into separate classes"

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd/scrub: extract scrub backend code into separate classes
Ronen Friedman [Sun, 11 Apr 2021 18:17:41 +0000 (21:17 +0300)]
osd/scrub: extract scrub backend code into separate classes

A refactoring of the scrub backend code (all Scrub related code
that checks/manipulates objects' (meta)data).

Part of the refactoring was breaking long chunks of code into
separate functions. In order to avoid passing endless lists
of state parameters from/to these new methods, the scrub backend
state is now maintained within its own objects.

a change to note:
Instead of two scrub-map collections - one that holds all
incoming maps, and one that holds pointers to all of those incoming
plus the one we (the Primary) manage - just use one collection
for both incoming and our own.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Split from "osd/scrub: minor fixes split from main "scrub backend" commit"

Split from "osd/scrub: scrub components embedded documentation"

fix

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
osd/scrub: fix the scrubber backend to include all PR #42735

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44736 from adamemerson/wip-no-using-namespace-std
Kefu Chai [Sat, 22 Jan 2022 06:30:38 +0000 (14:30 +0800)]
Merge pull request #44736 from adamemerson/wip-no-using-namespace-std

src: Remove some 'using namespace std' lines that crept back into headers

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoneorados: Remove using namespace std::literals from header 44736/head
Adam C. Emerson [Sat, 22 Jan 2022 00:58:08 +0000 (19:58 -0500)]
neorados: Remove using namespace std::literals from header

We don't actually need it.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agomgr: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:57:34 +0000 (19:57 -0500)]
mgr: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agotest: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:57:00 +0000 (19:57 -0500)]
test: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years ago{osd,crimson}: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:56:07 +0000 (19:56 -0500)]
{osd,crimson}: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agorgw: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:54:47 +0000 (19:54 -0500)]
rgw: Remove straggling `using namespace std` from headers

A few crept back in.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agocleanup: Change incorrect modelines 44737/head
Adam C. Emerson [Sat, 22 Jan 2022 02:13:12 +0000 (21:13 -0500)]
cleanup: Change incorrect modelines

Change C modelines to C++ for C++ files.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #44734 from anthonyeleven/anthonyeleven/cephfs-pool-recs
zdover23 [Sat, 22 Jan 2022 02:35:04 +0000 (12:35 +1000)]
Merge pull request #44734 from anthonyeleven/anthonyeleven/cephfs-pool-recs

doc/cephfs: Clarify CephFS pool guidance

Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #44509 from rzarzynski/wip-crimson-alienstore-drop-constant
Kefu Chai [Sat, 22 Jan 2022 00:41:01 +0000 (08:41 +0800)]
Merge pull request #44509 from rzarzynski/wip-crimson-alienstore-drop-constant

crimson/alienstore: drop unused constant from AlienStore.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44646 from neha-ojha/wip-backport-q
Neha Ojha [Fri, 21 Jan 2022 23:04:41 +0000 (15:04 -0800)]
Merge pull request #44646 from neha-ojha/wip-backport-q

script: backport updates for quincy

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #44265 from KellenRenshaw/WIP-replay_alloc
Igor Fedotov [Fri, 21 Jan 2022 20:52:32 +0000 (23:52 +0300)]
Merge pull request #44265 from KellenRenshaw/WIP-replay_alloc

test/allocator_replay_test: Add replay_alloc option

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agoMerge pull request #44705 from ceph/wip-yuriw-build-script
Ilya Dryomov [Fri, 21 Jan 2022 20:43:27 +0000 (21:43 +0100)]
Merge pull request #44705 from ceph/wip-yuriw-build-script

script/build-integration-branch: add quincy to the list of releases

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agodoc/cephfs: Clarify CephFS pool guidance 44734/head
Anthony D'Atri [Fri, 21 Jan 2022 20:26:52 +0000 (12:26 -0800)]
doc/cephfs: Clarify CephFS pool guidance

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #44674 from adamemerson/wip-53941
Adam C. Emerson [Fri, 21 Jan 2022 20:14:42 +0000 (15:14 -0500)]
Merge pull request #44674 from adamemerson/wip-53941

rgw: Report empty endpoints as error instead of crashing

Reviewed-By: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #44706 from rzarzynski/wip-tests-bl-fix-rebuild
Neha Ojha [Fri, 21 Jan 2022 19:22:07 +0000 (11:22 -0800)]
Merge pull request #44706 from rzarzynski/wip-tests-bl-fix-rebuild

test/bufferlist: ensure rebuild_aligned_size_and_memory() always rebuilds.

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44717 from zdover23/wip-doc-2021-01-22-man-page-radosgw-admin...
Casey Bodley [Fri, 21 Jan 2022 18:22:44 +0000 (13:22 -0500)]
Merge pull request #44717 from zdover23/wip-doc-2021-01-22-man-page-radosgw-admin-missing-apostrophe

doc/man: radosgw-admin.rst: missing apostrophe

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agodoc/man: radosgw-admin.rst: missing apostrophe 44717/head
Zac Dover [Fri, 21 Jan 2022 16:57:28 +0000 (02:57 +1000)]
doc/man: radosgw-admin.rst: missing apostrophe

This commit adds two missing apostrophes to two
different strings.

Hat tip to IcePic.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #44694 from alimaredia/wip-rgw-kmip-teuthology-test
Ali Maredia [Fri, 21 Jan 2022 16:56:45 +0000 (11:56 -0500)]
Merge pull request #44694 from alimaredia/wip-rgw-kmip-teuthology-test

qa: move certificates for kmip task into /etc/ceph

Reviewed-by: Al Maredia <amaredia@redhat.com>
3 years agotest/rbd_mirror: drop redundant MockJournaler instances 44714/head
Ilya Dryomov [Fri, 21 Jan 2022 13:26:31 +0000 (14:26 +0100)]
test/rbd_mirror: drop redundant MockJournaler instances

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agorbd-mirror: fix races in snapshot-based mirroring deletion propagation
Ilya Dryomov [Fri, 21 Jan 2022 12:41:46 +0000 (13:41 +0100)]
rbd-mirror: fix races in snapshot-based mirroring deletion propagation

When remote image is deleted, rbd-mirror can encounter three cases:

  1) no remote image id
  2) no remote mirror metadata
  3) MIRROR_IMAGE_STATE_DISABLING in remote mirror metadata

Commit d4c66ac5c615 ("rbd-mirror: fix issue with snapshot-based
mirroring deletion propagation") fixed case 1.  Cases 2 and 3 remained
broken because for both of them finalize_snapshot_state_builder() would
populate not only remote_mirror_peer_uuid but also remote_image_id,
thus disabling ENOLINK logic in handle_prepare_remote_image() and
handle_bootstrap().  Commit ff60aec2d9ef ("rbd-mirror: fix bootstrap
sequence while the image is removed") touched on case 3, but it made
a difference only for journal-based mirroring.

Stop calling finalize_snapshot_state_builder() on errors.  Instead,
align with journal-based mirroring by filling remote_mirror_peer_uuid
together with remote_mirror_uuid.

Fixes: https://tracker.ceph.com/issues/53963
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #44112 from zaitcev/wip-py_ssize_t_clean
Pete Zaitcev [Fri, 21 Jan 2022 15:05:16 +0000 (09:05 -0600)]
Merge pull request #44112 from zaitcev/wip-py_ssize_t_clean

mgr: Define PY_SSIZE_T_CLEAN ahead of every Python.h

3 years agorbd-mirror: don't default replay_requires_remote_image() implementation
Ilya Dryomov [Fri, 21 Jan 2022 12:41:46 +0000 (13:41 +0100)]
rbd-mirror: don't default replay_requires_remote_image() implementation

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agorbd-mirror: untangle StateBuilder::is_linked() overloads
Ilya Dryomov [Fri, 21 Jan 2022 12:41:46 +0000 (13:41 +0100)]
rbd-mirror: untangle StateBuilder::is_linked() overloads

Make it clear that the local image non-primariness is asserted
independent of the mode; avoid the default implementation being
overridden but still relied on by both modes.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agorbd-mirror: drop redundant initialization of StateBuilder members
Ilya Dryomov [Thu, 20 Jan 2022 15:25:46 +0000 (16:25 +0100)]
rbd-mirror: drop redundant initialization of StateBuilder members

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #44604 from mgfritch/c-v-skip-rbd-devs
Guillaume Abrioux [Fri, 21 Jan 2022 12:37:25 +0000 (13:37 +0100)]
Merge pull request #44604 from mgfritch/c-v-skip-rbd-devs

ceph-volume: show RBD devices as not available

3 years agoMerge pull request #44687 from sebastian-philipp/gov
Sebastian Wagner [Fri, 21 Jan 2022 08:56:00 +0000 (09:56 +0100)]
Merge pull request #44687 from sebastian-philipp/gov

doc/governance: Adam King

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agocrimson/os/seastore/journal: add logs to flush operation 44649/head
Yingxin Cheng [Wed, 19 Jan 2022 06:26:48 +0000 (14:26 +0800)]
crimson/os/seastore/journal: add logs to flush operation

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/cache: consolidate logs in levels
Yingxin Cheng [Wed, 19 Jan 2022 02:57:20 +0000 (10:57 +0800)]
crimson/os/seastore/cache: consolidate logs in levels

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: introduce seastore_t logs
Yingxin Cheng [Wed, 19 Jan 2022 02:54:22 +0000 (10:54 +0800)]
crimson/os/seastore: introduce seastore_t logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: move transaction-id forward in log
Yingxin Cheng [Wed, 19 Jan 2022 02:30:40 +0000 (10:30 +0800)]
crimson/os/seastore: move transaction-id forward in log

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/cache: misc cleanup
Yingxin Cheng [Wed, 19 Jan 2022 02:29:25 +0000 (10:29 +0800)]
crimson/os/seastore/cache: misc cleanup

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup effort_t and reuse Transaction::io_stat_t
Yingxin Cheng [Fri, 14 Jan 2022 07:33:28 +0000 (15:33 +0800)]
crimson/os/seastore: cleanup effort_t and reuse Transaction::io_stat_t

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: consolidate Cache::init_cached_extent with drop_from_cache
Yingxin Cheng [Thu, 13 Jan 2022 06:44:58 +0000 (14:44 +0800)]
crimson/os/seastore: consolidate Cache::init_cached_extent with drop_from_cache

So Cache::drop_from_cache() can be removed, and make it possible to add
related logs within the Cache component.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agotest/bufferlist: ensure rebuild_aligned_size_and_memory() always rebuilds. 44706/head
Radoslaw Zarzynski [Fri, 21 Jan 2022 01:50:22 +0000 (01:50 +0000)]
test/bufferlist: ensure rebuild_aligned_size_and_memory() always rebuilds.

Before the patch the test case was showing an unreliable behaviour
dependent on the underlying memory allocator. It was because
the bufferlist rebuild can be skipped, resulting in unchanged number
of buffers, if all of them begin at aligned addresses.

The commit fixes that by allocating a 4 KiB-aligned buffer and
offsetting it by a small constant (42) to ensure the memory added
to the bufferlist begins at non-4 KiB address.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoqa/tests: add quincy name to teh wip name 44705/head
Yuri Weinstein [Fri, 21 Jan 2022 00:17:19 +0000 (16:17 -0800)]
qa/tests: add quincy name to teh wip name

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
3 years agoqa: move certificates for kmip task into /etc/ceph 44694/head
Ali Maredia [Mon, 17 Jan 2022 19:01:34 +0000 (14:01 -0500)]
qa: move certificates for kmip task into /etc/ceph

On rhel/centos the ceph user does not have permission
to access these certs which leads to s3-test failures
in teuthology.

Signed-off-by: Ali Maredia <amaredia@redhat.com>
3 years agoMerge pull request #44042 from myoungwon/wip-add-blk-paddr
Samuel Just [Thu, 20 Jan 2022 21:27:25 +0000 (13:27 -0800)]
Merge pull request #44042 from myoungwon/wip-add-blk-paddr

seastore: add blk_paddr_t

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44685 from rhcs-dashboard/fix-53950-master
Ernesto Puerta [Thu, 20 Jan 2022 20:21:17 +0000 (21:21 +0100)]
Merge pull request #44685 from rhcs-dashboard/fix-53950-master

mgr/dashboard: remove feedback module as always-on

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44665 from guits/cv-sw-logger
Guillaume Abrioux [Thu, 20 Jan 2022 19:21:30 +0000 (20:21 +0100)]
Merge pull request #44665 from guits/cv-sw-logger

ceph-volume: don't use MultiLogger in find_executable_on_host()

3 years agoMerge pull request #43345 from trociny/wip-osdmaptool-down
Laura Flores [Thu, 20 Jan 2022 18:56:29 +0000 (12:56 -0600)]
Merge pull request #43345 from trociny/wip-osdmaptool-down

tools/osdmaptool: fix possible segfaults when there are down osds

3 years agomgr/dashboard: fix openapi-check 44685/head
Avan Thakkar [Thu, 20 Jan 2022 16:39:22 +0000 (22:09 +0530)]
mgr/dashboard: fix openapi-check

Fixes: https://tracker.ceph.com/issues/53950
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
3 years agorgw: Report empty endpoints as error instead of crashing 44674/head
Adam C. Emerson [Wed, 19 Jan 2022 21:49:05 +0000 (16:49 -0500)]
rgw: Report empty endpoints as error instead of crashing

Fixes: https://tracker.ceph.com/issues/53941
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoceph-volume: filter RBD devices from the device inventory 44604/head
Michael Fritch [Tue, 18 Jan 2022 22:15:45 +0000 (15:15 -0700)]
ceph-volume: filter RBD devices from the device inventory

Avoid running `blkid` or deploying OSDs on RBD devices by ensuring they
do not appear in the `ceph-volume inventory`

Fixes: https://tracker.ceph.com/issues/53846
Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #44675 from rzarzynski/wip-tests-bl-explicit-rebuild
Radoslaw Zarzynski [Thu, 20 Jan 2022 17:12:20 +0000 (18:12 +0100)]
Merge pull request #44675 from rzarzynski/wip-tests-bl-explicit-rebuild

test/bufferlist: assert the rebuild in rebuild_aligned_size_and_memory() actually happens.

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44677 from zdover23/wip-doc_2022-01-20_weil-crush-sc06pdf-repair
zdover23 [Thu, 20 Jan 2022 15:11:59 +0000 (01:11 +1000)]
Merge pull request #44677 from zdover23/wip-doc_2022-01-20_weil-crush-sc06pdf-repair

doc/rados: update broken pdf link

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/governance: Adam King 44687/head
Sebastian Wagner [Thu, 20 Jan 2022 13:02:37 +0000 (14:02 +0100)]
doc/governance: Adam King

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/dashboard: remove feedback as always-on
Ernesto Puerta [Thu, 20 Jan 2022 12:11:58 +0000 (13:11 +0100)]
mgr/dashboard: remove feedback as always-on

It was mistakenly left as always-on

Fixes: https://tracker.ceph.com/issues/53950
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agocmake/modules/BuildSPDK.cmake: link whole-archive 44572/head
Tongliang Deng [Thu, 13 Jan 2022 09:01:52 +0000 (17:01 +0800)]
cmake/modules/BuildSPDK.cmake: link whole-archive

We build spdk as static library, linking against them requires the
use of `-Wl,--whole-archive` as argument, otherwise we will have error
`nvme.c: nvme_probe_internal: *ERROR*: NVMe trtype 256 not available`.
This is due to the use of constructor functions in spdk to register
NVMe transports. So we need to do so to ensure we call all the
constructors.

Signed-off-by: Tongliang Deng <dengtongliang@sensetime.com>
3 years agoMerge pull request #44557 from kotreshhr/clone-quota-failure
Venky Shankar [Thu, 20 Jan 2022 11:12:35 +0000 (16:42 +0530)]
Merge pull request #44557 from kotreshhr/clone-quota-failure

mgr/volumes: Fix subvoume snapshot clone failure

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoceph-volume: install config_template from collection 44665/head
Guillaume Abrioux [Wed, 19 Jan 2022 14:39:52 +0000 (15:39 +0100)]
ceph-volume: install config_template from collection

ceph-ansible@master uses config_template from upstream collection.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoceph-volume: don't use MultiLogger in find_executable_on_host()
Guillaume Abrioux [Wed, 19 Jan 2022 14:04:20 +0000 (15:04 +0100)]
ceph-volume: don't use MultiLogger in find_executable_on_host()

This generates a lot of unnecessary messages on the terminal.

Fixes: https://tracker.ceph.com/issues/53934
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agodoc/rados: update broken pdf link 44677/head
Zac Dover [Thu, 20 Jan 2022 01:01:42 +0000 (11:01 +1000)]
doc/rados: update broken pdf link

This PR repairs a link to a PDF. The link was broken
when the PDF assets were moved during the restructure
of the ceph.io website in 2021.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agotest/bufferlist: assert the rebuild in rebuild_aligned_size_and_memory() actually... 44675/head
Radoslaw Zarzynski [Wed, 19 Jan 2022 21:56:05 +0000 (21:56 +0000)]
test/bufferlist: assert the rebuild in rebuild_aligned_size_and_memory() actually happens.

For the investigation of failures like the following one:

```
[ RUN      ] BufferList.rebuild_aligned_size_and_memory
../src/test/bufferlist.cc:1865: Failure
Expected equality of these values:
  bl.get_num_buffers()
    Which is: 2
  1
[  FAILED  ] BufferList.rebuild_aligned_size_and_memory (0 ms)
```

The test case assumes the rebuild before the failed clause **always**
happens while `bufferlist::rebuild_aligned_size_and_memory()` skips it
if buffers are already aligned.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #44615 from ceph/wip-yuriw-crontab-master
Yuri Weinstein [Wed, 19 Jan 2022 16:15:20 +0000 (08:15 -0800)]
Merge pull request #44615 from ceph/wip-yuriw-crontab-master

qa/tests: run upgrades on quincy

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44617 from cbodley/wip-rgw-swift-bulk-upload-no-such-bucket
Casey Bodley [Wed, 19 Jan 2022 15:43:44 +0000 (10:43 -0500)]
Merge pull request #44617 from cbodley/wip-rgw-swift-bulk-upload-no-such-bucket

rgw/swift: don't crash on nonexistent bucket in BulkUpload

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #44601 from trociny/wip-53888
Ilya Dryomov [Wed, 19 Jan 2022 15:36:22 +0000 (16:36 +0100)]
Merge pull request #44601 from trociny/wip-53888

cls/journal: skip disconnected clients when calculating min_commit_position

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #44381 from ly798/add-ns-to-snap-dump
Ilya Dryomov [Wed, 19 Jan 2022 15:31:45 +0000 (16:31 +0100)]
Merge pull request #44381 from ly798/add-ns-to-snap-dump

cls/rbd: add namespace to snapshot dump results

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #44553 from kamoltat/wip-ksirivad-progress-mgr-enforce-key-error...
Kamoltat Sirivadhna [Wed, 19 Jan 2022 15:24:07 +0000 (10:24 -0500)]
Merge pull request #44553 from kamoltat/wip-ksirivad-progress-mgr-enforce-key-error-exception

pybind/mgr/progress: enforced try and except on event dictionary
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agorbd: add missing switch arguments for recognition by get_command_spec() 44669/head
Ilya Dryomov [Wed, 19 Jan 2022 11:54:23 +0000 (12:54 +0100)]
rbd: add missing switch arguments for recognition by get_command_spec()

Currently this

  $ rbd --all children img

doesn't work, while this

  $ rbd children --all img

or this

  $ rbd children img --all

does.  The issue is that -a/--all isn't on the list of known switch
arguments.  The "rbd children" example may seem contrived but for more
complicated commands such as "rbd device map" mixing switches and
positional arguments occurs naturally:

  $ rbd device --device-type nbd --options try-netlink --show-cookie map img

Fixes: https://tracker.ceph.com/issues/53935
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #44024 from rhcs-dashboard/fix-53334-master
Ernesto Puerta [Wed, 19 Jan 2022 13:03:42 +0000 (14:03 +0100)]
Merge pull request #44024 from rhcs-dashboard/fix-53334-master

mgr/dashboard: Improve notifications for osd nearfull, full

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44238 from rhcs-dashboard/fix-51575-fix
Ernesto Puerta [Wed, 19 Jan 2022 12:35:03 +0000 (13:35 +0100)]
Merge pull request #44238 from rhcs-dashboard/fix-51575-fix

mgr/dashboard: Notification banners at the top of the UI have fixed height

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
3 years agoMerge pull request #44332 from rhcs-dashboard/grafana-warnings
Ernesto Puerta [Wed, 19 Jan 2022 12:18:31 +0000 (13:18 +0100)]
Merge pull request #44332 from rhcs-dashboard/grafana-warnings

monitoring/grafana: Replace missing legendFormat warning with error.

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #44600 from phlogistonjohn/jjm-mirror-service-module
Sebastian Wagner [Wed, 19 Jan 2022 11:16:29 +0000 (12:16 +0100)]
Merge pull request #44600 from phlogistonjohn/jjm-mirror-service-module

mgr/cephadm: auto-enable mirroring module when deploying service

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #44647 from melissa-kun-li/remove-duplicate-deployment-doc
Sebastian Wagner [Wed, 19 Jan 2022 11:14:10 +0000 (12:14 +0100)]
Merge pull request #44647 from melissa-kun-li/remove-duplicate-deployment-doc

doc/cephadm: remove duplicate deployment scenario section

Reviewed-by: Adam King <adking@redhat.com>
3 years agomgr/dashboard: Improve notifications for osd nearfull, full 44024/head
Aashish Sharma [Fri, 19 Nov 2021 09:02:49 +0000 (14:32 +0530)]
mgr/dashboard: Improve notifications for osd nearfull, full

This PR adds some visual hints for osds that are near full or full

Fixes: https://tracker.ceph.com/issues/53334
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agoMerge pull request #44430 from 5cs/fix-check-pg-num-underflow
Yuri Weinstein [Tue, 18 Jan 2022 22:39:11 +0000 (14:39 -0800)]
Merge pull request #44430 from 5cs/fix-check-pg-num-underflow

mon/OSDMonitor: fix integer underflow of check_pg_num

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agodoc/cephadm: remove duplicate deployment scenario section 44647/head
Melissa Li [Tue, 18 Jan 2022 21:53:04 +0000 (16:53 -0500)]
doc/cephadm: remove duplicate deployment scenario section

Signed-off-by: Melissa Li <melissali@redhat.com>
3 years agoMerge pull request #43732 from pdvian/wip-limit-slowop
Yuri Weinstein [Tue, 18 Jan 2022 20:33:07 +0000 (12:33 -0800)]
Merge pull request #43732 from pdvian/wip-limit-slowop

osd/OSD: Log aggregated slow ops detail to cluster logs

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoscript: backport updates for quincy 44646/head
Neha Ojha [Tue, 18 Jan 2022 20:21:04 +0000 (20:21 +0000)]
script: backport updates for quincy

Signed-off-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44578 from rhcs-dashboard/fix-53843-master
Ernesto Puerta [Tue, 18 Jan 2022 19:23:07 +0000 (20:23 +0100)]
Merge pull request #44578 from rhcs-dashboard/fix-53843-master

qa/dashboard: ensure node 16 is installed

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
Reviewed-by: Yuri Weinstein <yweins@redhat.com>
3 years agoMerge pull request #44607 from rhcs-dashboard/fix-autopep8-qa-tasks
Ernesto Puerta [Tue, 18 Jan 2022 19:11:07 +0000 (20:11 +0100)]
Merge pull request #44607 from rhcs-dashboard/fix-autopep8-qa-tasks

mgr/dashboard: include autopep8 for dashboard qa tasks

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44575 from rhcs-dashboard/dashboard-cephadm-more-stability
Ernesto Puerta [Tue, 18 Jan 2022 19:02:25 +0000 (20:02 +0100)]
Merge pull request #44575 from rhcs-dashboard/dashboard-cephadm-more-stability

mgr/dashboard: Refactoring dashboard cephadm checks

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #42603 from cypherean/feedback_frontend
Ernesto Puerta [Tue, 18 Jan 2022 18:47:13 +0000 (19:47 +0100)]
Merge pull request #42603 from cypherean/feedback_frontend

mgr/dashboard: report ceph tracker bug/feature through GUI

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
3 years agomgr/cephadm: add a test for enabling cephfs mirroring module 44600/head
John Mulligan [Tue, 18 Jan 2022 18:31:03 +0000 (13:31 -0500)]
mgr/cephadm: add a test for enabling cephfs mirroring module

Add a test that checks that when cephfs mirror service is enabled
the mirroring mgr module gets enabled.

Actually-written-by: Sebastian Wagner <sewagner@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
3 years agomgr/cephadm: auto-enable mirroring module when deploying service
John Mulligan [Thu, 13 Jan 2022 19:01:51 +0000 (14:01 -0500)]
mgr/cephadm: auto-enable mirroring module when deploying service

Automatically enable the mgr's mirroring module when creating
cephfs-mirror services. This will trigger a mgr respawn.

Fixes: https://tracker.ceph.com/issues/50593
Based roughly on 50dc1d0decb2fbf7b9129bddba940969410be5cd

Signed-off-by: John Mulligan <jmulligan@redhat.com>
3 years agoMerge pull request #33934 from cbodley/wip-40177
Casey Bodley [Tue, 18 Jan 2022 18:22:18 +0000 (13:22 -0500)]
Merge pull request #33934 from cbodley/wip-40177

rgw: delete full sync index before switching to incremental sync

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
3 years agoMerge pull request #40011 from cbodley/wip-49723
Casey Bodley [Tue, 18 Jan 2022 18:21:06 +0000 (13:21 -0500)]
Merge pull request #40011 from cbodley/wip-49723

rgw: allow rgw_data_notify_interval_msec=0 to disable notifications

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #44581 from cbodley/wip-53177
Casey Bodley [Tue, 18 Jan 2022 18:20:15 +0000 (13:20 -0500)]
Merge pull request #44581 from cbodley/wip-53177

rgw/dbstore: hide dbstore_log.h from rgw_main.cc

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
3 years agoMerge pull request #44413 from cybozu/rgw-fix-error-code-of-remove-bucket-api
Casey Bodley [Tue, 18 Jan 2022 18:19:53 +0000 (13:19 -0500)]
Merge pull request #44413 from cybozu/rgw-fix-error-code-of-remove-bucket-api

rgw: remove bucket API returns NoSuchKey than NoSuchBucket

Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #44078 from cbodley/wip-rgw-multisite-metadata-retry-error
Casey Bodley [Tue, 18 Jan 2022 18:18:46 +0000 (13:18 -0500)]
Merge pull request #44078 from cbodley/wip-rgw-multisite-metadata-retry-error

rgw/multisite: metadata sync only retries on errors

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #44602 from neha-ojha/wip-qct-remove
Neha Ojha [Tue, 18 Jan 2022 17:17:59 +0000 (09:17 -0800)]
Merge pull request #44602 from neha-ojha/wip-qct-remove

doc/foundation.rst: qct is no longer a member

Reviewed-by: Dan van der Ster <daniel.vanderster@cern.ch>
3 years agoseastore/seastore_types: fix wrong masking 44042/head
myoungwon oh [Fri, 3 Dec 2021 08:31:30 +0000 (17:31 +0900)]
seastore/seastore_types: fix wrong masking

Fix bit operation due to device_id_t is 8 bit for now

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoseastore/random_block_manager: use paddr_t instead of uint64
myoungwon oh [Wed, 24 Nov 2021 10:19:45 +0000 (19:19 +0900)]
seastore/random_block_manager: use paddr_t instead of uint64

Reagarding read() and write(), use paddr_t as input parameter
instead of uint64

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoseatore/random_block_manager: remove blocks_per_segment
myoungwon oh [Mon, 22 Nov 2021 03:30:58 +0000 (12:30 +0900)]
seatore/random_block_manager: remove blocks_per_segment

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>