]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agomgr/dashboard: fix columns in host table with NaN Undefined 44843/head
Avan Thakkar [Mon, 31 Jan 2022 13:53:10 +0000 (19:23 +0530)]
mgr/dashboard: fix columns in host table  with NaN Undefined

Fixes: https://tracker.ceph.com/issues/54068
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
3 years agoMerge pull request #44833 from fstachura/wip-doc-more-pdf-links
Ilya Dryomov [Sun, 30 Jan 2022 16:58:07 +0000 (17:58 +0100)]
Merge pull request #44833 from fstachura/wip-doc-more-pdf-links

doc: Fix links to CRUSH, RADOS and DSP research papers

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agodoc: Fix links to CRUSH, RADOS and DSP research papers. 44833/head
Franciszek Stachura [Sat, 29 Jan 2022 09:43:02 +0000 (10:43 +0100)]
doc: Fix links to CRUSH, RADOS and DSP research papers.

Signed-off-by: Franciszek Stachura <fbstachura@gmail.com>
3 years agoMerge pull request #44707 from liumiaomiaoIntel/qatdoc
Kefu Chai [Sat, 29 Jan 2022 06:13:41 +0000 (14:13 +0800)]
Merge pull request #44707 from liumiaomiaoIntel/qatdoc

doc/radosgw: update QAT acceleration to specify the configuration

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agodoc/radosgw: update QAT acceleration to specify the configuration 44707/head
Miaomiao Liu [Fri, 21 Jan 2022 07:45:44 +0000 (15:45 +0800)]
doc/radosgw: update QAT acceleration to specify the configuration

add and change the configuration steps to enable latest version of QAT
driver on QAT based encryption and compression

Signed-off-by: Miaomiao Liu <miaomiao.liu@intel.com>
3 years agoMerge pull request #44816 from cbodley/wip-rgw-cmake-system
Casey Bodley [Fri, 28 Jan 2022 19:09:59 +0000 (14:09 -0500)]
Merge pull request #44816 from cbodley/wip-rgw-cmake-system

cmake/rgw: src/rgw and src/rgw/services are not system headers

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #44801 from sebastian-philipp/doc-cephadm-count-per-host
Sebastian Wagner [Fri, 28 Jan 2022 15:19:35 +0000 (16:19 +0100)]
Merge pull request #44801 from sebastian-philipp/doc-cephadm-count-per-host

doc/cephadm: Co-location of daemons

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by:Anthony D'Atri <anthony.datri@gmail.com>

3 years agoMerge pull request #44823 from andriytk/fix-install-deps2
Daniel Gryniewicz [Fri, 28 Jan 2022 14:39:41 +0000 (09:39 -0500)]
Merge pull request #44823 from andriytk/fix-install-deps2

install-deps.sh: fix cortx-motr installation condition

3 years agoinstall-deps.sh: fix cortx-motr installation condition 44823/head
Andriy Tkachuk [Fri, 28 Jan 2022 11:33:12 +0000 (11:33 +0000)]
install-deps.sh: fix cortx-motr installation condition

Don't try to install cortx-motr if it is already installed
or not needed. (Currently, it installs on any run from an
interactive terminal session).

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
3 years agoMerge pull request #44711 from zdover23/wip-doc-2022-01-21-rados-bluestore-cache...
zdover23 [Thu, 27 Jan 2022 23:29:14 +0000 (09:29 +1000)]
Merge pull request #44711 from zdover23/wip-doc-2022-01-21-rados-bluestore-cache-autotune-interval-rewrite-2

src/rados: rewrite bs cache autotune instructions

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #44703 from phlogistonjohn/jjm-issue46773
Adam King [Thu, 27 Jan 2022 22:35:21 +0000 (17:35 -0500)]
Merge pull request #44703 from phlogistonjohn/jjm-issue46773

cephadm: validate that the constructed YumDnf baseurl is usable

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #44517 from adk3798/agent-cache
Adam King [Thu, 27 Jan 2022 22:34:01 +0000 (17:34 -0500)]
Merge pull request #44517 from adk3798/agent-cache

mgr/cephadm: store agent metadata in its own cache

Reviewed-By: Sebastian Wagner <sewagner@redhat.com>
3 years agocmake/rgw: src/rgw and src/rgw/services are not system headers 44816/head
Casey Bodley [Thu, 27 Jan 2022 21:31:00 +0000 (16:31 -0500)]
cmake/rgw: src/rgw and src/rgw/services are not system headers

include these with -I instead of -isystem so we don't hide their
compiler warnings

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #44719 from zdover23/wip-doc-2021-01-22-man-page-radosgw-multitena...
zdover23 [Thu, 27 Jan 2022 18:16:16 +0000 (04:16 +1000)]
Merge pull request #44719 from zdover23/wip-doc-2021-01-22-man-page-radosgw-multitenancy-remove-double-quotes

doc/radosgw: replace double quotes with single

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #44379 from andriytk/add-motr-rgw-sal
Daniel Gryniewicz [Thu, 27 Jan 2022 16:33:25 +0000 (11:33 -0500)]
Merge pull request #44379 from andriytk/add-motr-rgw-sal

rgw: add CORTX Motr SAL implementation

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
3 years agoMerge pull request #44654 from rhcs-dashboard/page-title-feature
Ernesto Puerta [Thu, 27 Jan 2022 15:10:40 +0000 (16:10 +0100)]
Merge pull request #44654 from rhcs-dashboard/page-title-feature

mgr/dashboard: Page title should indicate current location

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44793 from anthonyeleven/anthonyeleven/cephfs-mirroring
Venky Shankar [Thu, 27 Jan 2022 12:57:44 +0000 (18:27 +0530)]
Merge pull request #44793 from anthonyeleven/anthonyeleven/cephfs-mirroring

doc/cephfs: Clean up mirroring

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agorgw: add CORTX Motr SAL implementation 44379/head
Andriy Tkachuk [Mon, 1 Nov 2021 21:39:39 +0000 (21:39 +0000)]
rgw: add CORTX Motr SAL implementation

To build with Motr backend, use -DWITH_RADOSGW_MOTR=YES cmake
option. cortx-motr-devel rpm should be installed beforehand.

To connect to Motr cluster, add the following configuration
parameters to ceph.conf:

    [client]
            ...
            rgw backend store = motr
            motr profile fid  = 0x7000000000000001:0x4f
            motr ha endpoint  = inet:tcp:10.0.0.1@2001
    ...
    [client.rgw.8000]
            ...
            motr my endpoint  = inet:tcp:10.0.0.1@5001
            motr my fid       = 0x7200000000000001:0x29

The correct values for the Motr connection parameters can be
taken from `hctl status` cmd output after Motr cluster is
bootstrapped. In the example above, the values were taken from
the following output:

    Profile:
        0x7000000000000001:0x4f
    Services:
        centos8n1
        [started] hax       0x7200000000000001:0x6  inet:tcp:10.0.0.1@5001
        ...
        [unknown] m0_client 0x7200000000000001:0x29 inet:tcp:10.0.0.1@5001

Motr pkgs for the build/run can be taken from
https://github.com/Seagate/cortx-motr/releases/tag/2.0.0-rgw.

Co-authored-by: Sining Wu <sining.wu@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
3 years agomgr/dashboard: Page title should indicate current location 44654/head
Sarthak0702 [Tue, 18 Jan 2022 20:39:27 +0000 (02:09 +0530)]
mgr/dashboard: Page title should indicate current location

Added titleService to BreadcrumbsComponent.

Fixes: https://tracker.ceph.com/issues/36587
Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>
3 years agodoc/cephadm: Co-location of daemons 44801/head
Sebastian Wagner [Thu, 27 Jan 2022 09:09:58 +0000 (10:09 +0100)]
doc/cephadm: Co-location of daemons

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44693 from rhcs-dashboard/configuration-test
Ernesto Puerta [Thu, 27 Jan 2022 09:37:07 +0000 (10:37 +0100)]
Merge pull request #44693 from rhcs-dashboard/configuration-test

mgr/dashboard: navigation page e2e fix

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44748 from cyx1231st/wip-crimson-improve-log-tm
Yingxin [Thu, 27 Jan 2022 05:25:21 +0000 (13:25 +0800)]
Merge pull request #44748 from cyx1231st/wip-crimson-improve-log-tm

crimson/os/seastore/transaction_manager: cleanups and logs

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44760 from mgfritch/fixup-asyncssh-mypy
Adam King [Thu, 27 Jan 2022 02:42:39 +0000 (21:42 -0500)]
Merge pull request #44760 from mgfritch/fixup-asyncssh-mypy

mgr/cephadm: improve asyncssh type checking

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Melissa Li <melissali@redhat.com>
3 years agoMerge pull request #44792 from Matan-B/wip-matanb-email-contact
Neha Ojha [Wed, 26 Jan 2022 20:48:51 +0000 (12:48 -0800)]
Merge pull request #44792 from Matan-B/wip-matanb-email-contact

mailmap: Add Matan Breizman

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/cephfs: Clean up mirroring 44793/head
Anthony D'Atri [Wed, 26 Jan 2022 20:01:26 +0000 (12:01 -0800)]
doc/cephfs: Clean up mirroring

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agomailmap: Add Matan Breizman 44792/head
Matan Breizman [Wed, 26 Jan 2022 17:57:13 +0000 (17:57 +0000)]
mailmap: Add Matan Breizman

Add Matan Breizman to mailmap.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
3 years agoMerge pull request #44304 from guits/guits-fix-cv-batch-mpath
Guillaume Abrioux [Wed, 26 Jan 2022 17:49:45 +0000 (18:49 +0100)]
Merge pull request #44304 from guits/guits-fix-cv-batch-mpath

ceph-volume: improve mpath devices support

3 years agoMerge pull request #44782 from liu-chunmei/crimson-fix-content-corrupt
Liu-Chunmei [Wed, 26 Jan 2022 08:26:25 +0000 (00:26 -0800)]
Merge pull request #44782 from liu-chunmei/crimson-fix-content-corrupt

crimson: fix qa/RadosModel content corrupt

reviewed by: Samuel Just <sjust@redhat.com>

3 years agoMerge pull request #44718 from liu-chunmei/crimson-fix-split_pin_right-assert
Samuel Just [Wed, 26 Jan 2022 06:27:08 +0000 (22:27 -0800)]
Merge pull request #44718 from liu-chunmei/crimson-fix-split_pin_right-assert

crimson: fix split_pin_left assert_aligned

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agocrimson: fix qa/RadosModel content corrupt 44782/head
chunmei-liu [Tue, 25 Jan 2022 06:39:31 +0000 (22:39 -0800)]
crimson: fix qa/RadosModel content corrupt

RadosModel test read more length than object size, if truncate
not append zero to bufferlist, RadosMode will read more data and
it will check if there is content after the object size. So append
zero after truncate size to end of extent.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson: eliminate warning for unused variable 44718/head
chunmei-liu [Tue, 25 Jan 2022 01:36:23 +0000 (17:36 -0800)]
crimson: eliminate warning for unused variable

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson: fix split_pin_left assert_aligned
chunmei-liu [Fri, 21 Jan 2022 16:22:59 +0000 (08:22 -0800)]
crimson: fix split_pin_left assert_aligned

hint passed to lba alloc_extent may not be block size aligned
in a certain case, this hint insert lba tree as key, so make
laddr in lba tree is not aligned.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agoceph-volume: fix typo in tests 44304/head
Guillaume Abrioux [Tue, 14 Dec 2021 10:08:48 +0000 (11:08 +0100)]
ceph-volume: fix typo in tests

This fixes 2 typo in ceph-volume tests.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agodoc/ceph-volume: fix a typo
Guillaume Abrioux [Tue, 14 Dec 2021 09:42:09 +0000 (10:42 +0100)]
doc/ceph-volume: fix a typo

This fixes a typo in ceph-volume documentation.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoceph-volume: add a test `test_mpath_device_is_device`
Guillaume Abrioux [Tue, 14 Dec 2021 09:40:35 +0000 (10:40 +0100)]
ceph-volume: add a test `test_mpath_device_is_device`

This test checks that Device.is_device() returns True for a mpath device.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoceph-volume: improve mpath devices support
Guillaume Abrioux [Tue, 14 Dec 2021 08:57:10 +0000 (09:57 +0100)]
ceph-volume: improve mpath devices support

ee8887f4c0ff4f91117f31b621b95c8d08019130 was intended for adding
mpath devices support in ceph-volume but it has missed the lvm batch scenario.
This also fixes the zapping of mpath devices prepared with `ceph-volume raw`

Fixes: https://tracker.ceph.com/issues/52908
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoMerge pull request #44549 from melissa-kun-li/remove-iscsi
Adam King [Tue, 25 Jan 2022 19:25:34 +0000 (14:25 -0500)]
Merge pull request #44549 from melissa-kun-li/remove-iscsi

mgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command`

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #44682 from sebastian-philipp/cephadm-ipv6-parse-ipv6-addr-wo...
Adam King [Tue, 25 Jan 2022 19:21:06 +0000 (14:21 -0500)]
Merge pull request #44682 from sebastian-philipp/cephadm-ipv6-parse-ipv6-addr-wo-route

cephadm: _parse_ipv6_route: Fix parsing ifs w/o route

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agomgr/cephadm: improve asyncssh type checking 44760/head
Michael Fritch [Mon, 24 Jan 2022 19:39:15 +0000 (12:39 -0700)]
mgr/cephadm: improve asyncssh type checking

asyncssh 2.9.0 introduces additional type hints

Fixes: https://tracker.ceph.com/issues/54003
Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #44735 from neha-ojha/wip-reduce-cephadm
Yuri Weinstein [Tue, 25 Jan 2022 17:22:57 +0000 (09:22 -0800)]
Merge pull request #44735 from neha-ojha/wip-reduce-cephadm

qa/suites/rados: reduce the number of cephadm tests

Reviewed-by: Adam King adking@redhat.com
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
3 years agoMerge pull request #44662 from guits/cv-shared_ceph_folder
Adam King [Tue, 25 Jan 2022 17:06:05 +0000 (12:06 -0500)]
Merge pull request #44662 from guits/cv-shared_ceph_folder

cephadm: add shared_ceph_folder opt to ceph-volume subcommand

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44695 from liewegas/fix-cephadm-pretty-timedelta
Sebastian Wagner [Tue, 25 Jan 2022 15:56:13 +0000 (16:56 +0100)]
Merge pull request #44695 from liewegas/fix-cephadm-pretty-timedelta

pybind/mgr/mgr_util: fix to_pretty_timedelta()

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44459 from adk3798/misc-args
Sebastian Wagner [Tue, 25 Jan 2022 15:54:16 +0000 (16:54 +0100)]
Merge pull request #44459 from adk3798/misc-args

mgr/cephadm: allow miscellaneous container args at service level

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44192 from liuqinfei/docfix
Guillaume Abrioux [Tue, 25 Jan 2022 15:05:40 +0000 (16:05 +0100)]
Merge pull request #44192 from liuqinfei/docfix

doc: typo fixes in ceph-volume and install

3 years agocephadm: add shared_ceph_folder opt to ceph-volume subcommand 44662/head
Guillaume Abrioux [Wed, 19 Jan 2022 13:17:04 +0000 (14:17 +0100)]
cephadm: add shared_ceph_folder opt to ceph-volume subcommand

This commit adds the `--shared_ceph_folder` option to `ceph-volume`
subcommand, just like `shell` and `bootstrap` subcommands.

Fixes: https://tracker.ceph.com/issues/53931
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoMerge pull request #44282 from orozery/qa-qemu-nbd-ide-interface
Ilya Dryomov [Tue, 25 Jan 2022 14:06:14 +0000 (15:06 +0100)]
Merge pull request #44282 from orozery/qa-qemu-nbd-ide-interface

qa/tasks/qemu: switch nbd devices from virtio to ide

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #44066 from guits/guits-fix-rollback-osd
Guillaume Abrioux [Tue, 25 Jan 2022 10:03:35 +0000 (11:03 +0100)]
Merge pull request #44066 from guits/guits-fix-rollback-osd

ceph-volume: zap osds in rollback_osd()

3 years agoMerge pull request #44755 from ronen-fr/wip-rf-be2-clang1
Ronen Friedman [Tue, 25 Jan 2022 08:19:33 +0000 (10:19 +0200)]
Merge pull request #44755 from ronen-fr/wip-rf-be2-clang1

osd/scrub: fix ceph::mutex usage

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
3 years agoMerge pull request #44740 from liu-chunmei/crimson-fix-remove_from_lru-assert
Yingxin [Tue, 25 Jan 2022 06:52:24 +0000 (14:52 +0800)]
Merge pull request #44740 from liu-chunmei/crimson-fix-remove_from_lru-assert

crimson: fix remove_from_lru assert

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoMerge pull request #44653 from cyx1231st/wip-crimson-osd-empty-transaction
Yingxin [Tue, 25 Jan 2022 05:02:37 +0000 (13:02 +0800)]
Merge pull request #44653 from cyx1231st/wip-crimson-osd-empty-transaction

crimson/osd: ShardServices::dispatch_context_transaction to flush

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/transaction_manager: consolidate logs in levels 44748/head
Yingxin Cheng [Mon, 24 Jan 2022 05:16:20 +0000 (13:16 +0800)]
crimson/os/seastore/transaction_manager: consolidate logs in levels

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/transaction_manager: abort when error
Yingxin Cheng [Mon, 24 Jan 2022 05:05:47 +0000 (13:05 +0800)]
crimson/os/seastore/transaction_manager: abort when error

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/transaction_manager: drop the extent metrics
Yingxin Cheng [Mon, 24 Jan 2022 03:52:44 +0000 (11:52 +0800)]
crimson/os/seastore/transaction_manager: drop the extent metrics

These metrics won't distinguish extent operations from invalidated and
successful transactions.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocephadm: fully replace agent files when writing them 44517/head
Adam King [Wed, 19 Jan 2022 02:44:54 +0000 (21:44 -0500)]
cephadm: fully replace agent files when writing them

otherwise, if the new file is shorter than the old one
we will end up with a malformed file retaining the end bit
of the old version

Signed-off-by: Adam King <adking@redhat.com>
3 years agomgr/cephadm: store agent metadata in its own cache
Adam King [Mon, 10 Jan 2022 20:12:11 +0000 (15:12 -0500)]
mgr/cephadm: store agent metadata in its own cache

To avoid having the host cache getting too big
due to having to store this additional info

Fixes: https://tracker.ceph.com/issues/53624
Signed-off-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44761 from mgfritch/cephadm-asyncssh-2_8
Adam King [Mon, 24 Jan 2022 22:40:06 +0000 (17:40 -0500)]
Merge pull request #44761 from mgfritch/cephadm-asyncssh-2_8

mgr/cephadm: require asyncssh 2.8

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Melissa Li <melissali@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
3 years agomgr/cephadm: require asyncssh 2.8 44761/head
Michael Fritch [Mon, 24 Jan 2022 19:58:17 +0000 (12:58 -0700)]
mgr/cephadm: require asyncssh 2.8

Fixes: https://tracker.ceph.com/issues/54003
Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agoosd/scrub: fix clang compilation issues 44755/head
Ronen Friedman [Mon, 24 Jan 2022 13:01:49 +0000 (13:01 +0000)]
osd/scrub: fix clang compilation issues

Issues created by the scrub-backend refactoring PR.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44737 from adamemerson/wip-wrong-modelines
Adam C. Emerson [Mon, 24 Jan 2022 17:26:03 +0000 (12:26 -0500)]
Merge pull request #44737 from adamemerson/wip-wrong-modelines

cleanup: Change incorrect modelines

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson: fix remove_from_lru assert 44740/head
chunmei-liu [Mon, 24 Jan 2022 17:12:00 +0000 (09:12 -0800)]
crimson: fix remove_from_lru assert

RETIRED_PLACEHOLDER extent also put into retired set, when do
commit_retire_extent need check if it is RETIRED_PLACEHOLDER,
otherwise will cause remove_from_lru assert.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agoMerge PR #44574 into master
Patrick Donnelly [Mon, 24 Jan 2022 14:32:48 +0000 (09:32 -0500)]
Merge PR #44574 into master

* refs/pull/44574/head:
qa: Add syslog ignore list

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #44714 from idryomov/wip-rbd-mirror-delprop-races
Ilya Dryomov [Mon, 24 Jan 2022 10:43:56 +0000 (11:43 +0100)]
Merge pull request #44714 from idryomov/wip-rbd-mirror-delprop-races

rbd-mirror: fix races in snapshot-based mirroring deletion propagation

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agomgr/dashboard: navigation page e2e fix 44693/head
Nizamudeen A [Thu, 20 Jan 2022 16:52:50 +0000 (22:22 +0530)]
mgr/dashboard: navigation page e2e fix

Looks like the newly added relative position for the sidebar is
causing cypress to verify that the sidebar is hidden from the user view.

Fixes: https://tracker.ceph.com/issues/53960
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #42993 from ronen-fr/wip-ronenf-scrub-be2
Ronen Friedman [Mon, 24 Jan 2022 09:07:31 +0000 (11:07 +0200)]
Merge pull request #42993 from ronen-fr/wip-ronenf-scrub-be2

osd/scrub: extracting scrub "backend" functionality

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #44744 from ronen-fr/wip-rf-lost-update
Ronen Friedman [Mon, 24 Jan 2022 08:57:04 +0000 (10:57 +0200)]
Merge pull request #44744 from ronen-fr/wip-rf-lost-update

scrub/osd: add a missing 'publish stats to osd'

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
3 years agocrimson/os/seastore: suppress verbose onode info logs
Yingxin Cheng [Mon, 24 Jan 2022 03:47:31 +0000 (11:47 +0800)]
crimson/os/seastore: suppress verbose onode info logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #44649 from cyx1231st/wip-crimson-improve-log-cache
Yingxin [Mon, 24 Jan 2022 01:37:01 +0000 (09:37 +0800)]
Merge pull request #44649 from cyx1231st/wip-crimson-improve-log-cache

crimson/os/seastore: consolidate seastore_t and seastore_cache logs

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoqa/run_xfstests_qemu.sh: disable 251, 260 and 288 44282/head
Ilya Dryomov [Sun, 23 Jan 2022 15:32:57 +0000 (16:32 +0100)]
qa/run_xfstests_qemu.sh: disable 251, 260 and 288

All three are skipped with virtio disks:

251  [not run] FITRIM not supported on /dev/vdc
260  [not run] FITRIM not supported on /dev/vdc
288  [not run] FITRIM not supported on /dev/vdc

But 260 and 288 fail with ide disks, where discard defaults to on.  The
ancient kernel in our ubuntu-12.04.qcow2 doesn't support virtio discard
anyway so let's just disable them for consistency.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoscrub/osd: add a missing 'publish stats to osd' 44744/head
Ronen Friedman [Sun, 23 Jan 2022 06:54:58 +0000 (08:54 +0200)]
scrub/osd: add a missing 'publish stats to osd'

to publish the last scrub status report.
The change is needed following the merge of
PR #42735.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44572 from 5cs/fix-spdk-cmake
Kefu Chai [Sat, 22 Jan 2022 11:51:58 +0000 (19:51 +0800)]
Merge pull request #44572 from 5cs/fix-spdk-cmake

cmake/modules/BuildSPDK.cmake: link whole-archive

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoqa/run_xfstests_qemu.sh: fall back to ide disks if needed
Ilya Dryomov [Sat, 22 Jan 2022 10:49:46 +0000 (11:49 +0100)]
qa/run_xfstests_qemu.sh: fall back to ide disks if needed

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoosd/scrub: change missing_digest fix-list type 42993/head
Ronen Friedman [Thu, 13 Jan 2022 09:22:11 +0000 (09:22 +0000)]
osd/scrub: change missing_digest fix-list type

...allowing for efficient creation and, more important,
direct consumption by the function performing the
actual I/O.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd/scrub: scrub components embedded documentation
Ronen Friedman [Thu, 30 Dec 2021 13:04:58 +0000 (13:04 +0000)]
osd/scrub: scrub components embedded documentation

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd/scrub: add to PgScrubber a local ref to next-scrub's details
Ronen Friedman [Thu, 30 Dec 2021 13:01:24 +0000 (13:01 +0000)]
osd/scrub: add to PgScrubber a local ref to next-scrub's details

The owner is still the PG.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
osd/scrub: removing PgScrubber's ref to the primary scrub map

as caching this reference (to an object that is owned by the
scrubber backend) creates a dangling-pointer risk.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44669 from idryomov/wip-rbd-switch-arguments-fix
Ilya Dryomov [Sat, 22 Jan 2022 09:37:20 +0000 (10:37 +0100)]
Merge pull request #44669 from idryomov/wip-rbd-switch-arguments-fix

rbd: add missing switch arguments for recognition by get_command_spec()

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoosd/scrub: minor fixes split from main "scrub backend" commit
Ronen Friedman [Wed, 1 Dec 2021 11:37:04 +0000 (11:37 +0000)]
osd/scrub: minor fixes split from main "scrub backend" commit

Reformatting, minor compiler warnings, etc.
Split from "osd/scrub: extract scrub backend code into separate classes"

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd/scrub: extract scrub backend code into separate classes
Ronen Friedman [Sun, 11 Apr 2021 18:17:41 +0000 (21:17 +0300)]
osd/scrub: extract scrub backend code into separate classes

A refactoring of the scrub backend code (all Scrub related code
that checks/manipulates objects' (meta)data).

Part of the refactoring was breaking long chunks of code into
separate functions. In order to avoid passing endless lists
of state parameters from/to these new methods, the scrub backend
state is now maintained within its own objects.

a change to note:
Instead of two scrub-map collections - one that holds all
incoming maps, and one that holds pointers to all of those incoming
plus the one we (the Primary) manage - just use one collection
for both incoming and our own.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Split from "osd/scrub: minor fixes split from main "scrub backend" commit"

Split from "osd/scrub: scrub components embedded documentation"

fix

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
osd/scrub: fix the scrubber backend to include all PR #42735

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44736 from adamemerson/wip-no-using-namespace-std
Kefu Chai [Sat, 22 Jan 2022 06:30:38 +0000 (14:30 +0800)]
Merge pull request #44736 from adamemerson/wip-no-using-namespace-std

src: Remove some 'using namespace std' lines that crept back into headers

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoneorados: Remove using namespace std::literals from header 44736/head
Adam C. Emerson [Sat, 22 Jan 2022 00:58:08 +0000 (19:58 -0500)]
neorados: Remove using namespace std::literals from header

We don't actually need it.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agomgr: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:57:34 +0000 (19:57 -0500)]
mgr: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agotest: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:57:00 +0000 (19:57 -0500)]
test: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years ago{osd,crimson}: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:56:07 +0000 (19:56 -0500)]
{osd,crimson}: Remove straggling `using namespace std` from headers

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agorgw: Remove straggling `using namespace std` from headers
Adam C. Emerson [Sat, 22 Jan 2022 00:54:47 +0000 (19:54 -0500)]
rgw: Remove straggling `using namespace std` from headers

A few crept back in.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agocleanup: Change incorrect modelines 44737/head
Adam C. Emerson [Sat, 22 Jan 2022 02:13:12 +0000 (21:13 -0500)]
cleanup: Change incorrect modelines

Change C modelines to C++ for C++ files.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #44734 from anthonyeleven/anthonyeleven/cephfs-pool-recs
zdover23 [Sat, 22 Jan 2022 02:35:04 +0000 (12:35 +1000)]
Merge pull request #44734 from anthonyeleven/anthonyeleven/cephfs-pool-recs

doc/cephfs: Clarify CephFS pool guidance

Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #44509 from rzarzynski/wip-crimson-alienstore-drop-constant
Kefu Chai [Sat, 22 Jan 2022 00:41:01 +0000 (08:41 +0800)]
Merge pull request #44509 from rzarzynski/wip-crimson-alienstore-drop-constant

crimson/alienstore: drop unused constant from AlienStore.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoqa/suites/rados: reduce the number of cephadm tests 44735/head
Neha Ojha [Fri, 21 Jan 2022 23:31:01 +0000 (23:31 +0000)]
qa/suites/rados: reduce the number of cephadm tests

Currently, every rados run of ~400 jobs is running ~150 cephadm tests,
which is unnecessary and redundant. With this change, we will run some
basic cephadm tests within the rados suite. The following seems to be
a good start.

qa/suites/rados/cephadm/osds
qa/suites/rados/cephadm/smoke
qa/suites/rados/cephadm/smoke-singlehost
qa/suites/rados/cephadm/workunits

Signed-off-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44646 from neha-ojha/wip-backport-q
Neha Ojha [Fri, 21 Jan 2022 23:04:41 +0000 (15:04 -0800)]
Merge pull request #44646 from neha-ojha/wip-backport-q

script: backport updates for quincy

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #44265 from KellenRenshaw/WIP-replay_alloc
Igor Fedotov [Fri, 21 Jan 2022 20:52:32 +0000 (23:52 +0300)]
Merge pull request #44265 from KellenRenshaw/WIP-replay_alloc

test/allocator_replay_test: Add replay_alloc option

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agoMerge pull request #44705 from ceph/wip-yuriw-build-script
Ilya Dryomov [Fri, 21 Jan 2022 20:43:27 +0000 (21:43 +0100)]
Merge pull request #44705 from ceph/wip-yuriw-build-script

script/build-integration-branch: add quincy to the list of releases

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agodoc/cephfs: Clarify CephFS pool guidance 44734/head
Anthony D'Atri [Fri, 21 Jan 2022 20:26:52 +0000 (12:26 -0800)]
doc/cephfs: Clarify CephFS pool guidance

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #44674 from adamemerson/wip-53941
Adam C. Emerson [Fri, 21 Jan 2022 20:14:42 +0000 (15:14 -0500)]
Merge pull request #44674 from adamemerson/wip-53941

rgw: Report empty endpoints as error instead of crashing

Reviewed-By: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #44706 from rzarzynski/wip-tests-bl-fix-rebuild
Neha Ojha [Fri, 21 Jan 2022 19:22:07 +0000 (11:22 -0800)]
Merge pull request #44706 from rzarzynski/wip-tests-bl-fix-rebuild

test/bufferlist: ensure rebuild_aligned_size_and_memory() always rebuilds.

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44717 from zdover23/wip-doc-2021-01-22-man-page-radosgw-admin...
Casey Bodley [Fri, 21 Jan 2022 18:22:44 +0000 (13:22 -0500)]
Merge pull request #44717 from zdover23/wip-doc-2021-01-22-man-page-radosgw-admin-missing-apostrophe

doc/man: radosgw-admin.rst: missing apostrophe

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agodoc/radosgw: replace double quotes with single 44719/head
Zac Dover [Fri, 21 Jan 2022 17:05:01 +0000 (03:05 +1000)]
doc/radosgw: replace double quotes with single

This changes the string
  "tenant$<user>"
to
  'tenant$<user>'
in order to avoid users running into confusing
shell expansion behavior.

Hat tip to IcePic.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agodoc/man: radosgw-admin.rst: missing apostrophe 44717/head
Zac Dover [Fri, 21 Jan 2022 16:57:28 +0000 (02:57 +1000)]
doc/man: radosgw-admin.rst: missing apostrophe

This commit adds two missing apostrophes to two
different strings.

Hat tip to IcePic.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #44694 from alimaredia/wip-rgw-kmip-teuthology-test
Ali Maredia [Fri, 21 Jan 2022 16:56:45 +0000 (11:56 -0500)]
Merge pull request #44694 from alimaredia/wip-rgw-kmip-teuthology-test

qa: move certificates for kmip task into /etc/ceph

Reviewed-by: Al Maredia <amaredia@redhat.com>
3 years agotest/rbd_mirror: drop redundant MockJournaler instances 44714/head
Ilya Dryomov [Fri, 21 Jan 2022 13:26:31 +0000 (14:26 +0100)]
test/rbd_mirror: drop redundant MockJournaler instances

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agorbd-mirror: fix races in snapshot-based mirroring deletion propagation
Ilya Dryomov [Fri, 21 Jan 2022 12:41:46 +0000 (13:41 +0100)]
rbd-mirror: fix races in snapshot-based mirroring deletion propagation

When remote image is deleted, rbd-mirror can encounter three cases:

  1) no remote image id
  2) no remote mirror metadata
  3) MIRROR_IMAGE_STATE_DISABLING in remote mirror metadata

Commit d4c66ac5c615 ("rbd-mirror: fix issue with snapshot-based
mirroring deletion propagation") fixed case 1.  Cases 2 and 3 remained
broken because for both of them finalize_snapshot_state_builder() would
populate not only remote_mirror_peer_uuid but also remote_image_id,
thus disabling ENOLINK logic in handle_prepare_remote_image() and
handle_bootstrap().  Commit ff60aec2d9ef ("rbd-mirror: fix bootstrap
sequence while the image is removed") touched on case 3, but it made
a difference only for journal-based mirroring.

Stop calling finalize_snapshot_state_builder() on errors.  Instead,
align with journal-based mirroring by filling remote_mirror_peer_uuid
together with remote_mirror_uuid.

Fixes: https://tracker.ceph.com/issues/53963
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #44112 from zaitcev/wip-py_ssize_t_clean
Pete Zaitcev [Fri, 21 Jan 2022 15:05:16 +0000 (09:05 -0600)]
Merge pull request #44112 from zaitcev/wip-py_ssize_t_clean

mgr: Define PY_SSIZE_T_CLEAN ahead of every Python.h