]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoqa/suites/rbd: make sure block-rbd.so is installed 45072/head
Ilya Dryomov [Wed, 16 Feb 2022 09:32:26 +0000 (10:32 +0100)]
qa/suites/rbd: make sure block-rbd.so is installed

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 8f0fd0af3da8581c47dc916303615264714a0489)

3 years agoqa/tasks/qemu: make sure block-rbd.so is installed
Ilya Dryomov [Tue, 15 Feb 2022 13:57:51 +0000 (14:57 +0100)]
qa/tasks/qemu: make sure block-rbd.so is installed

Fixes: https://tracker.ceph.com/issues/54286
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 525ff61cfc8516b4d7bed6f819b00a0b6cb7be0a)

3 years agoMerge pull request #44725 from cfsnyder/wip-53703-pacific
Yuri Weinstein [Wed, 16 Feb 2022 23:15:19 +0000 (15:15 -0800)]
Merge pull request #44725 from cfsnyder/wip-53703-pacific

pacific: osdc: add set_error in BufferHead, when split set_error to right

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #44865 from cbodley/wip-54090
Yuri Weinstein [Wed, 16 Feb 2022 21:21:53 +0000 (13:21 -0800)]
Merge pull request #44865 from cbodley/wip-54090

pacific: qa: remove centos8 from supported distros

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44545 from cfsnyder/wip-53718-pacific
Yuri Weinstein [Wed, 16 Feb 2022 21:20:44 +0000 (13:20 -0800)]
Merge pull request #44545 from cfsnyder/wip-53718-pacific

pacific: osd/OSDMapMapping: fix spurious threadpool timeout errors

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44879 from adk3798/pacific-co-locate-doc
Adam King [Wed, 16 Feb 2022 20:12:09 +0000 (15:12 -0500)]
Merge pull request #44879 from adk3798/pacific-co-locate-doc

pacific: doc/cephadm: Co-location of daemons

Reviewed-by: Michael Fritch mfritch@suse.com
3 years agoMerge pull request #44146 from k0ste/wip-53435-pacific
Adam King [Wed, 16 Feb 2022 20:07:18 +0000 (15:07 -0500)]
Merge pull request #44146 from k0ste/wip-53435-pacific

pacific: mgr/prometheus: Fix the per method stats exported

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44830 from adk3798/pacific-rm-iscsi
Adam King [Wed, 16 Feb 2022 20:04:57 +0000 (15:04 -0500)]
Merge pull request #44830 from adk3798/pacific-rm-iscsi

pacific: mgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command`

Reviewed-by: Michael Fritch mfritch@suse.com
3 years agoMerge pull request #44829 from adk3798/pacific-cpu-limit
Adam King [Wed, 16 Feb 2022 20:03:26 +0000 (15:03 -0500)]
Merge pull request #44829 from adk3798/pacific-cpu-limit

pacific: mgr/cephadm: allow miscellaneous container args at service level

Reviewed-by: Michael Fritch mfritch@suse.com
3 years agoMerge pull request #44637 from sebastian-philipp/pacific-backport-44566
Adam King [Wed, 16 Feb 2022 20:00:47 +0000 (15:00 -0500)]
Merge pull request #44637 from sebastian-philipp/pacific-backport-44566

pacific: mgr/cephadm: fix minor grammar nit in Dry-Runs message

Reviewed-by: Michael Fritch mfritch@suse.com
3 years agoMerge pull request #44634 from sebastian-philipp/pacific-backport-44498
Adam King [Wed, 16 Feb 2022 19:59:31 +0000 (14:59 -0500)]
Merge pull request #44634 from sebastian-philipp/pacific-backport-44498

pacific: cephadm: check if cephadm is root after cli is parsed

Reviewed-by: John Mulligan <jmulligan@redhat.com>
3 years agoMerge pull request #44633 from sebastian-philipp/pacific-backport-44394
Adam King [Wed, 16 Feb 2022 19:57:27 +0000 (14:57 -0500)]
Merge pull request #44633 from sebastian-philipp/pacific-backport-44394

pacific: Enable autotune for osd_memory_target on bootstrap

Reviewed-by: Melissa Li melissali@redhat.com
3 years agoMerge pull request #44631 from sebastian-philipp/pacific-backport-44482
Adam King [Wed, 16 Feb 2022 19:56:22 +0000 (14:56 -0500)]
Merge pull request #44631 from sebastian-philipp/pacific-backport-44482

pacific: mgr/cephadm: nfs migration: avoid port conflicts

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44630 from sebastian-philipp/pacific-backport-43833
Adam King [Wed, 16 Feb 2022 19:55:06 +0000 (14:55 -0500)]
Merge pull request #44630 from sebastian-philipp/pacific-backport-43833

pacific: mgr/cephadm: fix tcmu-runner cephadm_stray_daemon

Reviewed-by: Melissa Li melissali@redhat.com
3 years agoMerge pull request #44628 from sebastian-philipp/pacific-backport-44374
Adam King [Wed, 16 Feb 2022 19:53:05 +0000 (14:53 -0500)]
Merge pull request #44628 from sebastian-philipp/pacific-backport-44374

pacific: mgr/cephadm: fix 'mgr/cephadm: spec.virtual_ip  param should be used by the ingress daemon

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44723 from cfsnyder/wip-53608-pacific
Yuri Weinstein [Wed, 16 Feb 2022 19:07:41 +0000 (11:07 -0800)]
Merge pull request #44723 from cfsnyder/wip-53608-pacific

pacific: os/bluestore: avoid premature onode release.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agoMerge pull request #44721 from cfsnyder/wip-53535-pacific
Yuri Weinstein [Wed, 16 Feb 2022 19:07:07 +0000 (11:07 -0800)]
Merge pull request #44721 from cfsnyder/wip-53535-pacific

pacific: mon/MgrStatMonitor: do not spam subscribers (mgr) with service_map

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44698 from cfsnyder/wip-53942-pacific
Yuri Weinstein [Wed, 16 Feb 2022 19:05:56 +0000 (11:05 -0800)]
Merge pull request #44698 from cfsnyder/wip-53942-pacific

pacific: mon/OSDMonitor: avoid null dereference if stats are not available

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #45028 from rhcs-dashboard/wip-54269-pacific
Ernesto Puerta [Wed, 16 Feb 2022 16:16:47 +0000 (17:16 +0100)]
Merge pull request #45028 from rhcs-dashboard/wip-54269-pacific

pacific: mgr/dashboard: Directories Menu Can't Use on Ceph File System Dashboard

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #45052 from rhcs-dashboard/wip-54295-pacific
Ernesto Puerta [Wed, 16 Feb 2022 16:06:19 +0000 (17:06 +0100)]
Merge pull request #45052 from rhcs-dashboard/wip-54295-pacific

pacific: mgr/dashboard: change privacy protocol field from required to optional

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44747 from cybozu/wip-53070-pacific
Daniel Gryniewicz [Wed, 16 Feb 2022 15:12:36 +0000 (10:12 -0500)]
Merge pull request #44747 from cybozu/wip-53070-pacific

pacific: rgw: fix lock scope in ObjectCache::get()

3 years agoMerge pull request #44750 from rhcs-dashboard/wip-53987-pacific
Ernesto Puerta [Wed, 16 Feb 2022 13:06:34 +0000 (14:06 +0100)]
Merge pull request #44750 from rhcs-dashboard/wip-53987-pacific

pacific: mgr: TTL Cache in mgr module

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: neha-ojha <NOT@FOUND>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: add validation for snmp v3 engine id 45052/head
Avan Thakkar [Tue, 15 Feb 2022 13:13:36 +0000 (18:43 +0530)]
mgr/dashboard: add validation for snmp v3 engine id

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 2866db1eac7d726201f5bb34abdb32981c783f0e)

3 years agomgr/dashboard: change privacy protocol field from required to optional
Avan Thakkar [Mon, 14 Feb 2022 12:18:39 +0000 (17:48 +0530)]
mgr/dashboard: change privacy protocol field from required to optional

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Privacy protocol field shouldn't be a required field.

(cherry picked from commit 2d8f2b8195a0f0c7a21d4ec5061b1b51a3aade2c)

3 years agoMerge pull request #44543 from cfsnyder/wip-53659-pacific
Brad Hubbard [Wed, 16 Feb 2022 00:56:12 +0000 (10:56 +1000)]
Merge pull request #44543 from cfsnyder/wip-53659-pacific

pacific: mon: prevent new sessions during shutdown

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agocephadm/ingress: make frontend stat bind on localhost 44628/head
Guillaume Abrioux [Fri, 11 Feb 2022 16:39:18 +0000 (17:39 +0100)]
cephadm/ingress: make frontend stat bind on localhost

The current configuration of keepalived makes it do
a curl on localhost:9999 in order to check the endpoint is alive.
Given the endpoint only binds on the vip addr, that doesn't work.

Fixes: https://tracker.ceph.com/issues/53807
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoMerge pull request #44756 from votdev/wip-53929-pacific
Ernesto Puerta [Tue, 15 Feb 2022 10:56:50 +0000 (11:56 +0100)]
Merge pull request #44756 from votdev/wip-53929-pacific

pacific: mgr/dashboard: Notification banners at the top of the UI have fixed height

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
3 years agoMerge pull request #44938 from rhcs-dashboard/wip-54091-pacific
Ernesto Puerta [Tue, 15 Feb 2022 10:54:55 +0000 (11:54 +0100)]
Merge pull request #44938 from rhcs-dashboard/wip-54091-pacific

pacific: mgr/dashboard: cephadm e2e job improvements

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44935 from rhcs-dashboard/pacific-test-applitools
Ernesto Puerta [Tue, 15 Feb 2022 10:53:55 +0000 (11:53 +0100)]
Merge pull request #44935 from rhcs-dashboard/pacific-test-applitools

pacific: mgr/dashboard: set appropriate baseline branch for applitools

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44876 from aaSharma14/wip-53930-pacific
Ernesto Puerta [Tue, 15 Feb 2022 10:53:19 +0000 (11:53 +0100)]
Merge pull request #44876 from aaSharma14/wip-53930-pacific

pacific: mgr/dashboard: Improve notifications for osd nearfull, full

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44789 from guits/wip-54021-pacific
Guillaume Abrioux [Mon, 14 Feb 2022 20:17:59 +0000 (21:17 +0100)]
Merge pull request #44789 from guits/wip-54021-pacific

pacific: ceph-volume: improve mpath devices support

3 years agoMerge pull request #44884 from guits/wip-54127-pacific
Guillaume Abrioux [Mon, 14 Feb 2022 19:09:22 +0000 (20:09 +0100)]
Merge pull request #44884 from guits/wip-54127-pacific

pacific: ceph-volume: fix error 'KeyError' with inventory

3 years agomgr/dashboard:Directories Menu Can't Use on Ceph File System Dashboard 45028/head
Sarthak0702 [Thu, 3 Feb 2022 17:59:17 +0000 (23:29 +0530)]
mgr/dashboard:Directories Menu Can't Use on Ceph File System Dashboard

Added exception handling to opendir() in cephfs.py for directories with no execute permission.

Fixes: https://tracker.ceph.com/issues/51611
Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>
(cherry picked from commit ea1af5438d380eb2160de635ffc7b08a69baf04c)

3 years agoMerge pull request #44767 from guits/wip-54007-pacific
Guillaume Abrioux [Mon, 14 Feb 2022 14:59:46 +0000 (15:59 +0100)]
Merge pull request #44767 from guits/wip-54007-pacific

pacific: ceph-volume: fix tags dict output in `lvm list`

3 years agoceph-volume: fix error 'KeyError' with inventory 44884/head
Guillaume Abrioux [Mon, 6 Dec 2021 09:24:46 +0000 (10:24 +0100)]
ceph-volume: fix error 'KeyError' with inventory

The tag ceph.cluster_name is always set at the end.
The only way it could be absent was if the osd prepare
has been interrupted between [1] and [2].

[1] https://github.com/ceph/ceph/blob/v14.2.11/src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py#L355-L387
[2] https://github.com/ceph/ceph/blob/v14.2.11/src/ceph-volume/ceph_volume/devices/lvm/prepare.py

Although the code received tremendous changes meantime
and this error shouldn't show up again, we need to handle
the case where this tag wouldn't have been set.

Fixes: https://tracker.ceph.com/issues/44356
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 691660c42eaa568a754670e093c512aa041d1479)

3 years agoceph-volume: fix typo in tests 44789/head
Guillaume Abrioux [Tue, 14 Dec 2021 10:08:48 +0000 (11:08 +0100)]
ceph-volume: fix typo in tests

This fixes 2 typo in ceph-volume tests.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit b07bd3e0e17021e0cf9773f916fad954f12254ed)

3 years agodoc/ceph-volume: fix a typo
Guillaume Abrioux [Tue, 14 Dec 2021 09:42:09 +0000 (10:42 +0100)]
doc/ceph-volume: fix a typo

This fixes a typo in ceph-volume documentation.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 5d0a3cee5d7021dafd1e166e17946689b4bb90b7)

3 years agoceph-volume: add a test `test_mpath_device_is_device`
Guillaume Abrioux [Tue, 14 Dec 2021 09:40:35 +0000 (10:40 +0100)]
ceph-volume: add a test `test_mpath_device_is_device`

This test checks that Device.is_device() returns True for a mpath device.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 0280ff6df09bc26107bc97446e9d5c18fbc582e9)

3 years agoceph-volume: improve mpath devices support
Guillaume Abrioux [Tue, 14 Dec 2021 08:57:10 +0000 (09:57 +0100)]
ceph-volume: improve mpath devices support

ee8887f4c0ff4f91117f31b621b95c8d08019130 was intended for adding
mpath devices support in ceph-volume but it has missed the lvm batch scenario.
This also fixes the zapping of mpath devices prepared with `ceph-volume raw`

Fixes: https://tracker.ceph.com/issues/52908
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 601ff7ed0a3ba5172b6bd886ca8ba2bd4d9e655a)

3 years agoMerge pull request #44973 from guits/wip-54244-pacific
Guillaume Abrioux [Mon, 14 Feb 2022 13:50:37 +0000 (14:50 +0100)]
Merge pull request #44973 from guits/wip-54244-pacific

pacific: ceph-volume: honour osd_dmcrypt_key_size option

3 years agoMerge pull request #44977 from rhcs-dashboard/wip-54240-pacific
Avan [Fri, 11 Feb 2022 09:58:25 +0000 (15:28 +0530)]
Merge pull request #44977 from rhcs-dashboard/wip-54240-pacific

pacific: mgr/dashboard: support snmp-gateway service creation from UI

3 years agomgr/dashboard: add snmp-gateway service e2e tests 44977/head
Avan Thakkar [Tue, 1 Feb 2022 13:02:42 +0000 (18:32 +0530)]
mgr/dashboard: add snmp-gateway service e2e tests

Fixes: https://tracker.ceph.com/issues/54034
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 76dcf6a881f343bb3d93259701e57ccb572f94e8)

3 years agomgr/dashboard: add snmp destination validation
Avan Thakkar [Fri, 28 Jan 2022 16:38:56 +0000 (22:08 +0530)]
mgr/dashboard: add snmp destination validation

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 81c93a21ff64e6aeeeba2c88db4f61b13352f565)

3 years agomgr/dashboard: support snmp-gateway service creation from UI
Avan Thakkar [Thu, 27 Jan 2022 14:13:22 +0000 (19:43 +0530)]
mgr/dashboard: support snmp-gateway service creation from UI

Fixes: https://tracker.ceph.com/issues/54034
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit ad6fcfc05625b3fd8a088b8a2b5c3d5fbbf2c53a)

3 years agoceph-volume/activate: load the config from lv tag 44973/head
Guillaume Abrioux [Thu, 10 Feb 2022 01:23:51 +0000 (02:23 +0100)]
ceph-volume/activate: load the config from lv tag

When `ceph-volume lvm trigger` is called with an OSD where the tag
`ceph.cluster_name` is not 'ceph', it fails.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 5ac1ec65cb2a582b2ae550202cc9911f993943f2)

3 years agoceph-volume/tests: use centos/stream8 images
Guillaume Abrioux [Wed, 9 Feb 2022 17:33:27 +0000 (18:33 +0100)]
ceph-volume/tests: use centos/stream8 images

Since recent move from CentOS 8 to CentOS Stream 8, let's do the same here.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 2b793952bbac7973b97d245c282165daadeabb51)

3 years agoceph-volume/tests: add tests in util/encryption.py
Guillaume Abrioux [Wed, 9 Feb 2022 16:04:19 +0000 (17:04 +0100)]
ceph-volume/tests: add tests in util/encryption.py

this adds some unit tests in order to cover `luks_format()` and `luks_open()`
in `util/encryption.py`.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit db48850745f218e08cf53ae2d8edf3428f2b4010)

3 years agoceph-volume: honour osd_dmcrypt_key_size option
Guillaume Abrioux [Tue, 25 Jan 2022 09:25:53 +0000 (10:25 +0100)]
ceph-volume: honour osd_dmcrypt_key_size option

ceph-volume doesn't honour osd_dmcrypt_key_size.
It means the default size is always applied.

It also changes the default value in `get_key_size_from_conf()`

From cryptsetup manpage:

> For XTS mode you can optionally set a key size of 512 bits with the -s option.

Using more than 512bits will end up with the following error message:

```
Key size in XTS mode must be 256 or 512 bits.
```

Fixes: https://tracker.ceph.com/issues/54006
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 47c33179f9a15ae95cc1579a421be89378602656)

3 years agomgr/dashboard: change the readFile to readFileSync 44935/head
Nizamudeen A [Wed, 9 Feb 2022 15:36:16 +0000 (21:06 +0530)]
mgr/dashboard: change the readFile to readFileSync

Apparently the readFile i added in #44934 is async and that's not what
we want. so changing it to the synchronous call that is readFileSync

Fixes: https://tracker.ceph.com/issues/54190
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit cbfdd551d9c1e67c2757056ac1119c058f4aa704)

3 years agoMerge pull request #44889 from ceph/pacific-stream8
Yuri Weinstein [Thu, 10 Feb 2022 01:13:07 +0000 (17:13 -0800)]
Merge pull request #44889 from ceph/pacific-stream8

qa: Default to CentOS 8 Stream

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
3 years agoMerge pull request #44903 from neha-ojha/wip-44868-pacific
Yuri Weinstein [Wed, 9 Feb 2022 21:09:38 +0000 (13:09 -0800)]
Merge pull request #44903 from neha-ojha/wip-44868-pacific

pacific: qa/distros/podman: remove centos_8.2 and centos_8.3

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Adam King adking@redhat.com
3 years agoMerge pull request #44944 from ljflores/wip-54204-pacific
Laura Flores [Wed, 9 Feb 2022 15:26:39 +0000 (09:26 -0600)]
Merge pull request #44944 from ljflores/wip-54204-pacific

pacific: monitoring: mention PyYAML only once in requirements

3 years agomgr/dashboard: set appropriate baseline branch for applitools
Nizamudeen A [Tue, 8 Feb 2022 06:20:29 +0000 (11:50 +0530)]
mgr/dashboard: set appropriate baseline branch for applitools

All the dashboard PRs are checked against a baseline branch called
'default' in the visual regresstion testing. This will cause issues when
testing PRs in different branches. For eg: currently our master and
pacific has to save two different screenshots since the two of them
differ slightly.

Disabling the applitools logs as well because its too 'noisy'

Fixes: https://tracker.ceph.com/issues/54190
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 40c902ac59b758a314f6a123d71cb59342523dac)

3 years agomonitoring: mention PyYAML only once in requirements 44944/head
Rishabh Dave [Mon, 7 Feb 2022 18:44:42 +0000 (00:14 +0530)]
monitoring: mention PyYAML only once in requirements

Following error occurs while running "sudo install-deps.sh" -
ERROR: Double requirement given: PyYAML==6.0 (from -r requirements-lint.txt (line 5)) (already in pyyaml (from -r requirements-alerts.txt (line 1)), name='PyYAML')

PyYAML is mentioned twice as a requirement. It is mentioned once in both
the following files -
monitoring/ceph-mixin/requirements-lint.txt
monitoring/ceph-mixin/requirements-alerts.txt

These requirements were added in commits
44d3e4c264506154373ffaeb13d6c924c580e6b5 and
4750ac0d7766a8a089adf073415af0ac0d3f81d9.

Fixes: https://tracker.ceph.com/issues/54185
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit a6f5efb620c429f81ea13992c2f77b4ca55458bc)

3 years agodoc: update dashboard kcli test env documentation 44938/head
Nizamudeen A [Tue, 1 Feb 2022 15:42:14 +0000 (21:12 +0530)]
doc: update dashboard kcli test env documentation

Fixes: https://tracker.ceph.com/issues/54105
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8feb2b8fe03f0c06a0ab09328ca8df0dfe8c0de9)

3 years agomgr/dashboard: fix for cephadm e2e failing because of rgw commands getting stuck
Nizamudeen A [Fri, 28 Jan 2022 13:53:31 +0000 (19:23 +0530)]
mgr/dashboard: fix for cephadm e2e failing because of rgw commands getting stuck

Delaying the rgw service creation in the tests until the cluster is
healthy

also changing the node_ip_offset to 110 because in the jenkins I saw

Fixes: https://tracker.ceph.com/issues/54030
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 347fb2e8fe26020a4693d3bbd94ca007c7e3535a)

3 years agomgr/dashboard: cephadm e2e job: display info on error & other improvements
Alfonso Martínez [Fri, 21 Jan 2022 14:57:39 +0000 (15:57 +0100)]
mgr/dashboard: cephadm e2e job: display info on error & other improvements

- Fix: ensure that on_error trap is called (display more info on error).
- Set static IPs to VMs.
- Remove domain in cluster definition to avoid side effects of potential dns misconfiguration.
- Minor improvements.

Fixes: https://tracker.ceph.com/issues/53991
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
(cherry picked from commit 39af61efb24dac6f41ba0752944882d35ad287db)

3 years agomgr/dashboard: navigation page e2e fix 44756/head
Volker Theile [Tue, 8 Feb 2022 08:32:17 +0000 (09:32 +0100)]
mgr/dashboard: navigation page e2e fix

Looks like the newly added relative position for the sidebar is
causing cypress to verify that the sidebar is hidden from the user view.

Fixes: https://tracker.ceph.com/issues/53960
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 6b2be10dbba639cea4d40c39fb63900b7bc0ccd0)

3 years agoqa: remove broken symlinks, add centos_8.stream wherever needed 44903/head
Neha Ojha [Fri, 4 Feb 2022 23:50:35 +0000 (23:50 +0000)]
qa: remove broken symlinks, add centos_8.stream wherever needed

This commit is not required in master/quincy

Signed-off-by: Neha Ojha <nojha@redhat.com>
3 years agoqa/distros/podman: remove centos_8.2 and centos_8.3
Neha Ojha [Wed, 2 Feb 2022 19:16:16 +0000 (19:16 +0000)]
qa/distros/podman: remove centos_8.2 and centos_8.3

Related to https://tracker.ceph.com/issues/54087

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 8f1d1b7c55a6a5715e12e9586be0951fad15cf49)

3 years agoMerge pull request #43897 from k0ste/wip-53234-pacific
Ernesto Puerta [Fri, 4 Feb 2022 16:39:05 +0000 (17:39 +0100)]
Merge pull request #43897 from k0ste/wip-53234-pacific

pacific: mgr/prometheus: Make prometheus standby behaviour configurable

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: k0ste <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rsommer <NOT@FOUND>
3 years agoMerge pull request #44775 from p-se/wip-53882-pacific
Ernesto Puerta [Fri, 4 Feb 2022 16:36:43 +0000 (17:36 +0100)]
Merge pull request #44775 from p-se/wip-53882-pacific

pacific: mgr/dashboard: fix Grafana OSD/host panels

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: p-se <NOT@FOUND>
3 years agoqa: Default to CentOS 8 Stream 44889/head
David Galloway [Thu, 3 Feb 2022 18:03:58 +0000 (13:03 -0500)]
qa: Default to CentOS 8 Stream

Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years agodoc/cephadm: Co-location of daemons 44879/head
Sebastian Wagner [Thu, 27 Jan 2022 09:09:58 +0000 (10:09 +0100)]
doc/cephadm: Co-location of daemons

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/dashboard: Improve notifications for osd nearfull, full 44876/head
Aashish Sharma [Fri, 19 Nov 2021 09:02:49 +0000 (14:32 +0530)]
mgr/dashboard: Improve notifications for osd nearfull, full

This PR adds some visual hints for osds that are near full or full

Fixes: https://tracker.ceph.com/issues/53334
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit f771cd492cd06da13f26e5f7ffe41b2d3c43f950)

3 years agoMerge pull request #44672 from kamoltat/wip-ksirivad-pacific-backport-44553
Kamoltat Sirivadhna [Wed, 2 Feb 2022 22:10:42 +0000 (17:10 -0500)]
Merge pull request #44672 from kamoltat/wip-ksirivad-pacific-backport-44553

pacific: pybind/mgr/progress: enforced try and except on accessing event dictionary
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44840 from mchangir/pacific-avoid-mon-sanity-assertion-on-startup
Yuri Weinstein [Wed, 2 Feb 2022 17:26:51 +0000 (09:26 -0800)]
Merge pull request #44840 from mchangir/pacific-avoid-mon-sanity-assertion-on-startup

qa: skip sanity check during upgrade

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Venky Shankar vshankar@redhat.com
3 years agoMerge pull request #44259 from sseshasa/wip-53551-pacific
Yuri Weinstein [Wed, 2 Feb 2022 17:25:24 +0000 (09:25 -0800)]
Merge pull request #44259 from sseshasa/wip-53551-pacific

pacific: osd/OSDMap: Add health warning if 'require-osd-release' != current release

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoqa/rgw: rgw/verify no longer pins centos 8.0 44865/head
Casey Bodley [Mon, 31 Jan 2022 22:23:25 +0000 (17:23 -0500)]
qa/rgw: rgw/verify no longer pins centos 8.0

the symlink rgw/verify/centos_latest.yaml already selects centos

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 0fad609d4dca01335abda6c48ae2663a8fd15494)

3 years agoqa/distros: remove duplicate centos_8.stream.yaml from supported
Casey Bodley [Mon, 31 Jan 2022 19:52:04 +0000 (14:52 -0500)]
qa/distros: remove duplicate centos_8.stream.yaml from supported

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 3b71b41190bbb0af5026babc82266541b6398e92)

3 years agoqa/distros: centos_8.yaml is now a symlink to centos_8.stream.yaml
Casey Bodley [Mon, 31 Jan 2022 19:51:00 +0000 (14:51 -0500)]
qa/distros: centos_8.yaml is now a symlink to centos_8.stream.yaml

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 0f4e51f05f9b340fe6128b46ea4601ecf01625d2)

Conflicts:
qa/distros/all/centos_8.yaml was pointing at 8.2 instead of 8.3

3 years agoqa/distro/supported: add centos 8.stream
Sage Weil [Fri, 18 Jun 2021 23:07:30 +0000 (18:07 -0500)]
qa/distro/supported: add centos 8.stream

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 577cbd162ed63bcee9f027776d72d569d9adf93b)

3 years agoPendingReleaseNotes: Release note 'require-osd-release' health warning 44259/head
Sridhar Seshasayee [Fri, 3 Dec 2021 09:55:32 +0000 (15:25 +0530)]
PendingReleaseNotes: Release note 'require-osd-release' health warning

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit 34f18fa45f3e98de4f35959bdeb1d11730f3f291)

Conflicts:
    PendingReleaseNotes
- Add the release note under the correct release heading.

3 years agoqa: set pacific require-osd-release to avoid health warning
Patrick Donnelly [Wed, 15 Dec 2021 17:57:00 +0000 (12:57 -0500)]
qa: set pacific require-osd-release to avoid health warning

Fixes: https://tracker.ceph.com/issues/53615
Fixes: bd815bd9d6ecdecaab3d2dd9e0f5a18aa795d749
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit bc2eaba8c6616c3469ac85d36ee21f3e9765cf42)

Conflicts:
- Changed release name in commit message from 'quincy' to 'pacific'.

  ../fs/upgrade/featureful_client/old_client/tasks/2-upgrade.yaml
  ../fs/upgrade/featureful_client/upgraded_client/tasks/2-upgrade.yaml
  ../fs/upgrade/nofs/tasks/1-upgrade.yaml
- Changed release name from 'quincy' to 'pacific' when setting the
  'require-osd-release' flag in the above files.

  ../fs/upgrade/volumes/import-legacy/tasks/2-upgrade.yaml
- Changed release name from 'octopus' to 'pacific' when setting the
  'require-osd-release' flag in the above file.

3 years agoqa/suites/upgrade/octopus-x/stress-split-no-cephadm: remove msgr2
Neha Ojha [Wed, 1 Dec 2021 01:22:46 +0000 (01:22 +0000)]
qa/suites/upgrade/octopus-x/stress-split-no-cephadm: remove msgr2

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 6ad7a8a597e6314cf9310f9f7c2f01ef82bc8fa3)

3 years agoqa: test upgrades with hybrid allocator
Neha Ojha [Wed, 1 Dec 2021 01:15:14 +0000 (01:15 +0000)]
qa: test upgrades with hybrid allocator

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit df67040a4c34593adb4585086671543233d90f5a)

3 years agoqa: rename octopus install correctly
Neha Ojha [Wed, 1 Dec 2021 01:12:15 +0000 (01:12 +0000)]
qa: rename octopus install correctly

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 3b15a044550903d4074fc421a2ef1f24fc7e4023)

3 years agoqa: remove leftovers from nautilus
Neha Ojha [Wed, 1 Dec 2021 00:39:57 +0000 (00:39 +0000)]
qa: remove leftovers from nautilus

pglog_hardlimit and msgr2

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit ed4bb05bd945c5d30cb70b88b1f8db0eb64a6ab1)

3 years agoqa/suites/upgrade: Fix/Modify upgrade tests to work with 'pacific' release.
Sridhar Seshasayee [Thu, 13 Jan 2022 13:27:09 +0000 (18:57 +0530)]
qa/suites/upgrade: Fix/Modify upgrade tests to work with 'pacific' release.

This commit is not a cherry-pick and fixes the following issues unique to
the pacific release:
1. Fixes the nautilus-x and octopus-x upgrade tests to work with the
   pacific release by updating the post upgrade step to set the
   'require-osd-release' flag to 'pacific'. This is done by using
   '.qa/releases/pacific.yaml' for all the tests.
2. Fixed an issue in 'upgrade-mon-osd-mds.yaml' under both the
   nautilus-x/parallel, octopus-x/parallel-no-cephadm tests. The
   'wait-for-healthy' check should not be performed after all the osds
   are upgraded since the 'require-osd-release' warning comes into
   effect. This check is delayed until after the 'require-osd-release'
   flag is set to 'pacific'.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
3 years agoosd/OSDMap: Add health warning if 'require-osd-release' != current release
Sridhar Seshasayee [Mon, 22 Nov 2021 15:16:02 +0000 (20:46 +0530)]
osd/OSDMap: Add health warning if 'require-osd-release' != current release

After all OSDs are upgraded to a new release, generate a health warning if
the 'require-osd-release' flag doesn't match the the new release version.
This will result in the cluster showing a warning in the health state until
the flag is set properly.

Fixes: https://tracker.ceph.com/issues/51984
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit bd815bd9d6ecdecaab3d2dd9e0f5a18aa795d749)

Conflicts:
    src/osd/OSDMap.cc
- Removed checks for non-existent ceph_release_t 'quincy' flag from
  OSDMap::pending_require_osd_release().

3 years agoMerge pull request #44387 from trociny/wip-53702-pacific
Yuri Weinstein [Wed, 2 Feb 2022 00:04:42 +0000 (16:04 -0800)]
Merge pull request #44387 from trociny/wip-53702-pacific

pacific: qa/tasks: improve backfill_toofull test

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44325 from k0ste/wip-53621-pacific
Yuri Weinstein [Wed, 2 Feb 2022 00:04:08 +0000 (16:04 -0800)]
Merge pull request #44325 from k0ste/wip-53621-pacific

pacific: mgr/devicehealth: fix missing timezone from time delta calculation

Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>
3 years agoMerge pull request #44205 from k0ste/wip-53488-pacific
Yuri Weinstein [Wed, 2 Feb 2022 00:03:32 +0000 (16:03 -0800)]
Merge pull request #44205 from k0ste/wip-53488-pacific

pacific: mgr/prometheus: define module options for standby

Reviewed-by: Adam King adking@redhat.com
3 years agoMerge pull request #44175 from cfsnyder/wip-51172-pacific
Yuri Weinstein [Wed, 2 Feb 2022 00:02:34 +0000 (16:02 -0800)]
Merge pull request #44175 from cfsnyder/wip-51172-pacific

pacific: common/PriorityCache: low perf counters priorities for submodules.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agoMerge pull request #44181 from myoungwon/pacific-50192
Yuri Weinstein [Tue, 1 Feb 2022 22:12:17 +0000 (14:12 -0800)]
Merge pull request #44181 from myoungwon/pacific-50192

pacific: osd: recover unreadable snapshot before reading ref. count info

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43955 from cfsnyder/wip-53201-pacific
Yuri Weinstein [Tue, 1 Feb 2022 22:10:21 +0000 (14:10 -0800)]
Merge pull request #43955 from cfsnyder/wip-53201-pacific

pacific: osd: fix 'ceph osd stop <osd.nnn>' doesn't take effect

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #44212 from k0ste/wip-53494-pacific
Yuri Weinstein [Tue, 1 Feb 2022 20:42:40 +0000 (12:42 -0800)]
Merge pull request #44212 from k0ste/wip-53494-pacific

pacific: mgr: fix locking for MetadataUpdate::finish

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44202 from myoungwon/pacific-53486
Yuri Weinstein [Tue, 1 Feb 2022 20:41:52 +0000 (12:41 -0800)]
Merge pull request #44202 from myoungwon/pacific-53486

pacific: test: increase retry duration when calculating manifest ref. count

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44173 from cfsnyder/wip-51150-pacific
Yuri Weinstein [Tue, 1 Feb 2022 20:40:49 +0000 (12:40 -0800)]
Merge pull request #44173 from cfsnyder/wip-51150-pacific

pacific: osd: set r only if succeed in FillInVerifyExtent

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #44096 from cfsnyder/wip-53388-pacific
Yuri Weinstein [Tue, 1 Feb 2022 20:40:09 +0000 (12:40 -0800)]
Merge pull request #44096 from cfsnyder/wip-53388-pacific

pacific: osd/OSDMap.cc: clean up pg_temp for nonexistent pgs

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
3 years agoMerge pull request #43882 from ifed01/wip-ifed-fix-53011-pac
Yuri Weinstein [Tue, 1 Feb 2022 20:39:04 +0000 (12:39 -0800)]
Merge pull request #43882 from ifed01/wip-ifed-fix-53011-pac

pacific: os/bluestore: use proper prefix when removing undecodable Share Blob.

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/mgr: Add cli api documentation 44750/head
Waad AlKhoury [Fri, 29 Oct 2021 14:38:11 +0000 (16:38 +0200)]
doc/mgr: Add cli api documentation

Signed-off-by: Waad AlKhoury <walkhour@redhat.com>
3 years agomgr/cli Redo cli api mgr module.
Waad AlKhoury [Wed, 24 Nov 2021 09:12:41 +0000 (10:12 +0100)]
mgr/cli Redo  cli api mgr module.

Signed-off-by: Waad AlKhoury <walkhour@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoqa: skip sanity check during upgrade 44840/head
Milind Changire [Mon, 31 Jan 2022 11:22:45 +0000 (16:52 +0530)]
qa: skip sanity check during upgrade

Fixes: https://tracker.ceph.com/issues/54064
Signed-off-by: Milind Changire <mchangir@redhat.com>
3 years agomgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command` 44830/head
Melissa Li [Tue, 11 Jan 2022 23:03:23 +0000 (18:03 -0500)]
mgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command`

Use `mon_command` instead of `check_mon_command` in `post_remove` to avoid errors such as if iscsi service is removed before the iscsi gateway list is updated, cluster will enter error state and iscsi removal gets stuck.

Fixes: https://tracker.ceph.com/issues/53706
Signed-off-by: Melissa Li <melissali@redhat.com>
3 years agomgr/cephadm: allow miscellaneous container args at service level 44829/head
Adam King [Mon, 20 Dec 2021 06:39:08 +0000 (01:39 -0500)]
mgr/cephadm: allow miscellaneous container args at service level

Fixes: https://tracker.ceph.com/issues/51566
Signed-off-by: Adam King <adking@redhat.com>
Conflicts:
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/tests/test_services.py

3 years agoMerge pull request #44727 from cfsnyder/wip-51825-pacific
Ernesto Puerta [Thu, 27 Jan 2022 10:27:06 +0000 (11:27 +0100)]
Merge pull request #44727 from cfsnyder/wip-51825-pacific

pacific: qa/run-tox-mgr-dashboard: Do not write to /tmp/test_sanitize_password…

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>
Reviewed-by: kevinzs2048 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44540 from kamoltat/wip-ksirivad-backport-pacific-43716
Yuri Weinstein [Wed, 26 Jan 2022 23:39:24 +0000 (15:39 -0800)]
Merge pull request #44540 from kamoltat/wip-ksirivad-backport-pacific-43716

pacific: mgr/autoscaler: Introduce noautoscale flag

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
3 years agoMerge pull request #44660 from sebastian-philipp/pacific-backport-44647
Adam King [Wed, 26 Jan 2022 14:50:37 +0000 (09:50 -0500)]
Merge pull request #44660 from sebastian-philipp/pacific-backport-44647

pacific: doc/cephadm: remove duplicate deployment scenario section

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44636 from sebastian-philipp/pacific-backport-44510
Adam King [Wed, 26 Jan 2022 14:46:08 +0000 (09:46 -0500)]
Merge pull request #44636 from sebastian-philipp/pacific-backport-44510

pacific: doc/cephadm: improve the development doc a bit

Reviewed-by: Adam King <adking@redhat.com>