mgr/devicehealth: skip null pages when extracting wear level

Some devices have null pages in their ata_device_statistics struct; skip
those pages in order to avoid an AttributeError when extracting device's
wear level.

Fixes: https://tracker.ceph.com/issues/51554
Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
(cherry picked from commit 2864ac30d4170ba7b5f60ae01ecfdeee707e026a)

Merge pull request #45123 from zdover23/wip-hardware-recs-backport-2022-02-23-pacific

doc/start: remove journal info from hardware recs

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #45075 from chrisphoffman/wip-54298-pacific

pacific: cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #45072 from idryomov/wip-qemu-task-rbd-package-pacific

pacific: qa/tasks/qemu: make sure block-rbd.so is installed

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #44629 from sebastian-philipp/pacific-backport-44367

pacific: mgr/cephadm: Fix count for OSDs with OSD specs

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44632 from sebastian-philipp/pacific-backport-44306

pacific: cephadm: deal with ambiguity within normalize_image_digest

Reviewed-by: Adam King <adking@redhat.com>

doc/start: remove journal info from hardware recs

This PR removes mentions of journaling from the hardware
recommendations.

Journaling was a FileStore-related practice. BlueStore is
the default backend for Ceph OSDs and has been since
Luminous. The documentation should reflect that.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 276bbd8f2b516993813fedfdfd1371e87bb0d44a)

mgr/cephadm: Fix count for OSDs with OSD specs

osd counting is special

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Conflicts:
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/tests/test_cephadm.py

Merge pull request #44996 from pcfe/patch-1

pacific: doc/cephadm: Add CentOS Stream install instructions

Reviewed-by: Adam King <adking@redhat.com>

cephadm: count number of docker.io occurrences.

We have to be super careful adding any new hardcoded
regstistry names to the code base. Let's make this an informed
decision next time.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit 0fe2e54db774271e4fc18b45aba36b66cbc71779)

mgr/cephadm: improve doc strings for ambigous config values

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit 391ddf15530d4063d68b03dce1da9999490930d6)

cephadm: sync normalize_image_digest with mgr/cephadm

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit 84bef14999e0422cf3a2c456c8972211303f91f1)

mgr/cephadm: normalize_image_digest: reworked

Reworked to only care about known short names. I coudn't
find any algorithm, as this problem is ambiguous.

Fixes: https://tracker.ceph.com/issues/53594
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit a48b8344bd9ebb47c23e589f2c7ecdd18a6f3085)

mgr/cephadm: normalize_image_digest: comment to tests

`pytest --doctest` ftw. Be aware those tests actually fail, as the
implementation contradicts the function documentation.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit dc19e3a867b015d8f4c6f5128603d71be3ce5b0d)

Merge pull request #44882 from adk3798/pacific-validate-yumdnf-baseurl

pacific: cephadm: validate that the constructed YumDnf baseurl is usable

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44880 from adk3798/pacific-shared-ceph-ceph-volume

pacific: cephadm: add shared_ceph_folder opt to ceph-volume subcommand

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44877 from adk3798/pacific-parse-ipv6-route

pacific: cephadm: _parse_ipv6_route: Fix parsing ifs w/o route

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44661 from sebastian-philipp/pacific-backport-44600

pacific: mgr/cephadm: auto-enable mirroring module when deploying service

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44658 from sebastian-philipp/pacific-backport-43889

pacific: mgr/cephadm: store contianer registry credentials in config-key

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #45046 from mgfritch/backport-44905-pacific

pacific: cephadm: chown the prometheus data dir during redeploy

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>

Merge pull request #44742 from idryomov/wip-rbd-switch-arguments-fix-pacific

pacific: rbd: add missing switch arguments for recognition by get_command_spec()

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #44690 from MrFreezeex/wip-53938-pacific

pacific: cls/journal: skip disconnected clients when calculating min_commit_position

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #44094 from MrFreezeex/wip-53386-pacific

pacific: rbd-mirror: make RemoveImmediateUpdate test synchronous

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #44754 from idryomov/wip-rbd-mirror-delprop-races-pacific

pacific: rbd-mirror: fix races in snapshot-based mirroring deletion propagation

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>

Merge pull request #44998 from idryomov/wip-53419-pacific

pacific: librbd: fix various memory leaks

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #44999 from idryomov/wip-52522-pacific

pacific: librbd: fix use-after-free on ictx in list_descendants()

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #45005 from sunnyku/wip-54168-pacific

pacific: mgr/rbd_support: fix schedule remove

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #45008 from idryomov/wip-rbd-help-positional-optional-pacific

pacific: rbd: mark optional positional arguments as such in help output

Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

Merge pull request #45044 from votdev/wip-54284-pacific

cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

For

  GroupSnapshotNamespace a(1, "group-1", "snap-2");
  GroupSnapshotNamespace b(1, "group-2", "snap-1");

both a < b and b < a evaluate to true.  This violates STL strict weak
ordering requirements which is a problem because GroupSnapshotNamespace
is used as a key in std::map (ictx->snap_ids at least), etc.

Fixes: https://tracker.ceph.com/issues/49792
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 830e72ab9d66c8f5703ea27da5249b02dd16ccd0)

qa/suites/rbd: make sure block-rbd.so is installed

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 8f0fd0af3da8581c47dc916303615264714a0489)

qa/tasks/qemu: make sure block-rbd.so is installed

Fixes: https://tracker.ceph.com/issues/54286
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 525ff61cfc8516b4d7bed6f819b00a0b6cb7be0a)

mgr/dashboard: "Please expand your cluster first" shouldn't be shown if cluster is already meaningfully running

This PR will assume that a cluster is already up and fully running. If this should not be the expected behaviour, deployment tools have to set 'INSTALLED' explicitly. Without this assumption it might happen that upgraded and fully running clusters, e.g. Octopus -> Pacific, will show the 'Expand Cluster' on first log in.

cephadm will take care that the bootstrap phase will write the necessary key to show the 'Expand cluster' page.

Fixes: https://tracker.ceph.com/issues/54215
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 48fff60b63785ec07f71d3e59394b0c08357247c)

Conflicts:
src/cephadm/cephadm

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/cephadm: add a test for enabling cephfs mirroring module

Add a test that checks that when cephfs mirror service is enabled
the mirroring mgr module gets enabled.

Actually-written-by: Sebastian Wagner <sewagner@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit bcb4fa70f9f739dce3e1c111db0a322804350f9d)

Conflicts:
src/pybind/mgr/cephadm/tests/test_services.py

mgr/cephadm: auto-enable mirroring module when deploying service

Automatically enable the mgr's mirroring module when creating
cephfs-mirror services. This will trigger a mgr respawn.

Fixes: https://tracker.ceph.com/issues/50593
Based roughly on 50dc1d0decb2fbf7b9129bddba940969410be5cd

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit e030130fd1d680ebf9d2c6c9f95f44109fbf3036)

mgr/cephadm: store contianer registry credentials in config-key

Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
(cherry picked from commit 2c29286b370b1079a35e0e0d47c33a7dabab3468)

Conflicts:
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/serve.py

Merge pull request #44725 from cfsnyder/wip-53703-pacific

pacific: osdc: add set_error in BufferHead, when split set_error to right

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #44865 from cbodley/wip-54090

pacific: qa: remove centos8 from supported distros

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44545 from cfsnyder/wip-53718-pacific

pacific: osd/OSDMapMapping: fix spurious threadpool timeout errors

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44879 from adk3798/pacific-co-locate-doc

pacific: doc/cephadm: Co-location of daemons

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44146 from k0ste/wip-53435-pacific

pacific: mgr/prometheus: Fix the per method stats exported

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44830 from adk3798/pacific-rm-iscsi

pacific: mgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command`

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44829 from adk3798/pacific-cpu-limit

pacific: mgr/cephadm: allow miscellaneous container args at service level

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44637 from sebastian-philipp/pacific-backport-44566

pacific: mgr/cephadm: fix minor grammar nit in Dry-Runs message

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44634 from sebastian-philipp/pacific-backport-44498

pacific: cephadm: check if cephadm is root after cli is parsed

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #44633 from sebastian-philipp/pacific-backport-44394

pacific: Enable autotune for osd_memory_target on bootstrap

Reviewed-by: Melissa Li melissali@redhat.com

Merge pull request #44631 from sebastian-philipp/pacific-backport-44482

pacific: mgr/cephadm: nfs migration: avoid port conflicts

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44630 from sebastian-philipp/pacific-backport-43833

pacific: mgr/cephadm: fix tcmu-runner cephadm_stray_daemon

Reviewed-by: Melissa Li melissali@redhat.com

Merge pull request #44628 from sebastian-philipp/pacific-backport-44374

pacific: mgr/cephadm: fix 'mgr/cephadm: spec.virtual_ip  param should be used by the ingress daemon

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44723 from cfsnyder/wip-53608-pacific

pacific: os/bluestore: avoid premature onode release.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #44721 from cfsnyder/wip-53535-pacific

pacific: mon/MgrStatMonitor: do not spam subscribers (mgr) with service_map

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44698 from cfsnyder/wip-53942-pacific

pacific: mon/OSDMonitor: avoid null dereference if stats are not available

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #45028 from rhcs-dashboard/wip-54269-pacific

pacific: mgr/dashboard: Directories Menu Can't Use on Ceph File System Dashboard

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #45052 from rhcs-dashboard/wip-54295-pacific

pacific: mgr/dashboard: change privacy protocol field from required to optional

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44747 from cybozu/wip-53070-pacific

pacific: rgw: fix lock scope in ObjectCache::get()

Merge pull request #44750 from rhcs-dashboard/wip-53987-pacific

pacific: mgr: TTL Cache in mgr module

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: neha-ojha <NOT@FOUND>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: add validation for snmp v3 engine id

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 2866db1eac7d726201f5bb34abdb32981c783f0e)

mgr/dashboard: change privacy protocol field from required to optional

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Privacy protocol field shouldn't be a required field.

(cherry picked from commit 2d8f2b8195a0f0c7a21d4ec5061b1b51a3aade2c)

Merge pull request #44543 from cfsnyder/wip-53659-pacific

pacific: mon: prevent new sessions during shutdown

Reviewed-by: Neha Ojha <nojha@redhat.com>

cephadm: chown the prometheus data dir during redeploy

some builds of prometheus run with a uid 65534 (nobody) where other
builds of prometheus run with a uid of 0 (root)

Fixes: https://tracker.ceph.com/issues/54159
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 21fb80aaab0b333d997d8241e17cf9749a37e065)

doc/cephadm: Add CentOS Stream install instructions

Tested on CentOS Stream 9

Signed-off-by: Patrick C. F. Ernzer <pcfe@pcfe.net>.

cephadm/ingress: make frontend stat bind on localhost

The current configuration of keepalived makes it do
a curl on localhost:9999 in order to check the endpoint is alive.
Given the endpoint only binds on the vip addr, that doesn't work.

Fixes: https://tracker.ceph.com/issues/53807
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44756 from votdev/wip-53929-pacific

pacific: mgr/dashboard: Notification banners at the top of the UI have fixed height

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #44938 from rhcs-dashboard/wip-54091-pacific

pacific: mgr/dashboard: cephadm e2e job improvements

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44935 from rhcs-dashboard/pacific-test-applitools

pacific: mgr/dashboard: set appropriate baseline branch for applitools

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44876 from aaSharma14/wip-53930-pacific

pacific: mgr/dashboard: Improve notifications for osd nearfull, full

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44789 from guits/wip-54021-pacific

pacific: ceph-volume: improve mpath devices support

Merge pull request #44884 from guits/wip-54127-pacific

pacific: ceph-volume: fix error 'KeyError' with inventory

mgr/dashboard:Directories Menu Can't Use on Ceph File System Dashboard

Added exception handling to opendir() in cephfs.py for directories with no execute permission.

Fixes: https://tracker.ceph.com/issues/51611
Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>
(cherry picked from commit ea1af5438d380eb2160de635ffc7b08a69baf04c)

Merge pull request #44767 from guits/wip-54007-pacific

pacific: ceph-volume: fix tags dict output in `lvm list`

ceph-volume: fix error 'KeyError' with inventory

The tag ceph.cluster_name is always set at the end.
The only way it could be absent was if the osd prepare
has been interrupted between [1] and [2].

[1] https://github.com/ceph/ceph/blob/v14.2.11/src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py#L355-L387
[2] https://github.com/ceph/ceph/blob/v14.2.11/src/ceph-volume/ceph_volume/devices/lvm/prepare.py

Although the code received tremendous changes meantime
and this error shouldn't show up again, we need to handle
the case where this tag wouldn't have been set.

Fixes: https://tracker.ceph.com/issues/44356
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 691660c42eaa568a754670e093c512aa041d1479)

ceph-volume: fix typo in tests

This fixes 2 typo in ceph-volume tests.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit b07bd3e0e17021e0cf9773f916fad954f12254ed)

doc/ceph-volume: fix a typo

This fixes a typo in ceph-volume documentation.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 5d0a3cee5d7021dafd1e166e17946689b4bb90b7)

ceph-volume: add a test `test_mpath_device_is_device`

This test checks that Device.is_device() returns True for a mpath device.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 0280ff6df09bc26107bc97446e9d5c18fbc582e9)

ceph-volume: improve mpath devices support

ee8887f4c0ff4f91117f31b621b95c8d08019130 was intended for adding
mpath devices support in ceph-volume but it has missed the lvm batch scenario.
This also fixes the zapping of mpath devices prepared with `ceph-volume raw`

Fixes: https://tracker.ceph.com/issues/52908
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 601ff7ed0a3ba5172b6bd886ca8ba2bd4d9e655a)

Merge pull request #44973 from guits/wip-54244-pacific

pacific: ceph-volume: honour osd_dmcrypt_key_size option

rbd: mark optional positional arguments as such in help output

Currently at least five commands have optional positional arguments.

Overloading po::value<std::string>()->default_value("") for this
is a bit sneaky but nothing better fits into the existing Shell.cc
framework.

Note that strictly speaking "[<interval>] [<start-time>]" should be
"[<interval> [<start-time>]]" but we aren't doing that here because
"ceph" command doesn't do it either.

Fixes: https://tracker.ceph.com/issues/54191
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit cb0df397aae552adc80713ca0d59ed1ebfd3b1be)

qa/workunits/rbd: improve schedule add/remove cli test

This patch adds few tests to cover schedule add/remove with invalid
inputs.

Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
(cherry picked from commit a9312d4777a82d8f2d8766a011f10952f84d3f27)

mgr/rbd_support: fix schedule remove

Issue:

If we provide a random string in the schedule remove
command the entire schedule at specified level gets
removed.

Fixes: https://tracker.ceph.com/issues/53250
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
(cherry picked from commit 1b62447071a900b9fa7d856617cb7db9e030f91e)

librbd: report correct error for ictx->state->close()

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 22903c3965b15245b464540ccfb3404bf45f0627)

librbd: fix use-after-free on ictx in list_descendants()

Ictx is deleted when "ictx->state->open()" and "ictx->state->close()"
fail, and then "lderr(ictx->cct)" crashes.

Fixes: https://tracker.ceph.com/issues/52522
Signed-off-by: Wang ShuaiChao <wangshuaich@chinatelecom.cn>
(cherry picked from commit fa5d61ee5144f67cba53d54d36013614183e53a3)

librbd/crypto: remove unused member from ShutDownCryptoRequest

m_crypto is not used - remove it.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 5de8791da71c244bdf40a7b7e7aa9dd60728fba0)

test/librbd: fix memory leak in TestMockShutDownCryptoRequest

fix memory leak in TestMockShutDownCryptoRequest.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 23831579b47b20c7590784ebdeee0bf7871e7543)

test/librbd: fix memory leak in TestMockCryptoLoadRequest

fix memory leak in TestMockCryptoLoadRequest.CryptoAlreadyLoaded

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 23bb3e458cbcad684bdd62c5ccbea6ce4c3e9cf5)

test/librbd: fix memory leak in TestMockCryptoCryptoObjectDispatch

fix memory leak in TestMockCryptoCryptoObjectDispatch.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit bb0ccb3cc4876bead0b0309e378f5fa78aa5ca2c)

librbd/crypto: fix memory leak in openssl/DataCryptor

Re-initializing the same datacryptor, causes a memory leak of the old encryption key.
This commit fixes this issue.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 9992bbaa5303521fafe28a7d5d0581afa7b32da7)

librbd/crypto: fix memory leak in ShutDownCryptoRequest

If crypto object dispatch does not exist, a context pointer is leaked.
This commit fixes this issue.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 044280dcbe808d76cb2c97e1457685d76e8c869a)

test/librbd: fix memory leak in TestMockParentCacheObjectDispatch

fix memory leak in TestMockParentCacheObjectDispatch.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 0f61c82d2e2d4b9f3f53f2ad06b599def6f408e9)

test/librbd: fix memory leak in TestMockCryptoLuksFormatRequest

fix memory leak in TestMockCryptoLuksFormatRequest.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit bcca300d26fa58132e6aa7894f1849405d222f55)

test/librbd: fix memory leak in TestMockCryptoLuksLoadRequest

fix memory leak in TestMockCryptoLuksLoadRequest.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 79501173b7f9ac0d6d112f6951cd9d619ec93bc5)

test/librbd: fix bad TearDown in TestCryptoOpensslDataCryptor

Fix the TearDown function in TestCryptoOpensslDataCryptor
to call the right class parent function.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 91c3b0314c4545fa47275d69c0738561846c1e83)

test/librbd: fix memory leak in TestCryptoOpensslDataCryptor

One of the tests leaks an encryption context.
This commit fixes this issue.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 09ae3bd03d465af46bfefc03909b91b238d1586f)

librbd/crypto: fix memory leak in when DataCryptor fails

If DataCryptor fails, either in init_context or update_context,
the encryption context is not returned, which causes a memory leak.
This commit fixes this issue.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 3af5bb7c61f37cdad56b13d1abccf5e9fd078563)

test/librbd: fix memory leak in TestMockCryptoBlockCrypto

fix memory leak in TestMockCryptoBlockCrypto.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
(cherry picked from commit 78abde0d25652e76c92cf39998e6f3dacabaa20c)

Merge pull request #44977 from rhcs-dashboard/wip-54240-pacific

pacific: mgr/dashboard: support snmp-gateway service creation from UI

mgr/dashboard: add snmp-gateway service e2e tests

Fixes: https://tracker.ceph.com/issues/54034
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 76dcf6a881f343bb3d93259701e57ccb572f94e8)

mgr/dashboard: add snmp destination validation

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 81c93a21ff64e6aeeeba2c88db4f61b13352f565)

mgr/dashboard: support snmp-gateway service creation from UI

Fixes: https://tracker.ceph.com/issues/54034
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit ad6fcfc05625b3fd8a088b8a2b5c3d5fbbf2c53a)

ceph-volume/activate: load the config from lv tag

When `ceph-volume lvm trigger` is called with an OSD where the tag
`ceph.cluster_name` is not 'ceph', it fails.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 5ac1ec65cb2a582b2ae550202cc9911f993943f2)

ceph-volume/tests: use centos/stream8 images

Since recent move from CentOS 8 to CentOS Stream 8, let's do the same here.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 2b793952bbac7973b97d245c282165daadeabb51)