mgr/cephadm: block draining last _admin host

Fixes: https://tracker.ceph.com/issues/54413
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit a0d21c7108e8f95b541bdb7653d2595f68e42520)

Merge pull request #45002 from idryomov/wip-krbd-rxbounce-option-pacific

pacific: rbd: recognize rxbounce map option

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #45003 from idryomov/wip-54128-pacific

pacific: krbd: return error when no initial monitor address found

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #44897 from aclamk/wip-53480-pacific

pacific: crush: Fix segfault in update_from_hook

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44847 from kamoltat/wip-ksirivad-pacific-backport-44241

pacific: mon: osd pool create <pool-name> with --bulk flag

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44613 from ifed01/wip-ifed-fix-ram-gridy-fsck-pac

pacific: os/bluestore: make shared blob fsck much less RAM-greedy.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #43313 from idryomov/wip-keyring-resolve-error-pacific

pacific: auth,mon: don't log "unable to find a keyring" error when key is given

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #44975 from vshankar/wip-54241

pacific: mds: ignore unknown client op when tracking op latency

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #45100 from vshankar/wip-54217

pacific: mds: kill session when mds do ms_handle_remote_reset

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #45099 from vshankar/wip-54220

pacific: mds: fix seg fault in expire_recursive

Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>

Merge pull request #45016 from Vicente-Cheng/wip-54194-pacific

pacific: mds: mds_oft_prefetch_dirfrags default to false

Reviewed-by: Venky Shankar vshankar@redhat.com

Merge pull request #44910 from batrick/i54161

pacific: mon/MDSMonitor: sanity assert when inline data turned on in MDSMap from v16.2.4 -> v16.2.[567]

Reviewed-by: Venky Shankar vshankar@redhat.com

Merge pull request #44504 from MrFreezeex/wip-53761-pacific

pacific: qa/suites/fs: add prefetch_dirfrags false to thrasher suite

Reviewed-by: Venky Shankar vshankar@redhat.com

Merge pull request #42932 from kotreshhr/wip-52384-pacific

pacific: mgr/volumes: Subvolume removal and clone failure fixes

Reviewed-by: Venky Shankar vshankar@redhat.com

Merge pull request #44869 from neha-ojha/wip-mgr-fixes-pacific

pacific: mgr: various fixes for mgr scalability

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Adam King adking@redhat.com
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #45123 from zdover23/wip-hardware-recs-backport-2022-02-23-pacific

doc/start: remove journal info from hardware recs

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #45075 from chrisphoffman/wip-54298-pacific

pacific: cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #45072 from idryomov/wip-qemu-task-rbd-package-pacific

pacific: qa/tasks/qemu: make sure block-rbd.so is installed

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #44629 from sebastian-philipp/pacific-backport-44367

pacific: mgr/cephadm: Fix count for OSDs with OSD specs

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44632 from sebastian-philipp/pacific-backport-44306

pacific: cephadm: deal with ambiguity within normalize_image_digest

Reviewed-by: Adam King <adking@redhat.com>

doc/start: remove journal info from hardware recs

This PR removes mentions of journaling from the hardware
recommendations.

Journaling was a FileStore-related practice. BlueStore is
the default backend for Ceph OSDs and has been since
Luminous. The documentation should reflect that.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 276bbd8f2b516993813fedfdfd1371e87bb0d44a)

mgr/cephadm: Fix count for OSDs with OSD specs

osd counting is special

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Conflicts:
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/tests/test_cephadm.py

Merge pull request #44996 from pcfe/patch-1

pacific: doc/cephadm: Add CentOS Stream install instructions

Reviewed-by: Adam King <adking@redhat.com>

cephadm: count number of docker.io occurrences.

We have to be super careful adding any new hardcoded
regstistry names to the code base. Let's make this an informed
decision next time.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit 0fe2e54db774271e4fc18b45aba36b66cbc71779)

mgr/cephadm: improve doc strings for ambigous config values

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit 391ddf15530d4063d68b03dce1da9999490930d6)

cephadm: sync normalize_image_digest with mgr/cephadm

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit 84bef14999e0422cf3a2c456c8972211303f91f1)

mgr/cephadm: normalize_image_digest: reworked

Reworked to only care about known short names. I coudn't
find any algorithm, as this problem is ambiguous.

Fixes: https://tracker.ceph.com/issues/53594
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit a48b8344bd9ebb47c23e589f2c7ecdd18a6f3085)

mgr/cephadm: normalize_image_digest: comment to tests

`pytest --doctest` ftw. Be aware those tests actually fail, as the
implementation contradicts the function documentation.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
(cherry picked from commit dc19e3a867b015d8f4c6f5128603d71be3ce5b0d)

Merge pull request #44882 from adk3798/pacific-validate-yumdnf-baseurl

pacific: cephadm: validate that the constructed YumDnf baseurl is usable

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44880 from adk3798/pacific-shared-ceph-ceph-volume

pacific: cephadm: add shared_ceph_folder opt to ceph-volume subcommand

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44877 from adk3798/pacific-parse-ipv6-route

pacific: cephadm: _parse_ipv6_route: Fix parsing ifs w/o route

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44661 from sebastian-philipp/pacific-backport-44600

pacific: mgr/cephadm: auto-enable mirroring module when deploying service

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44658 from sebastian-philipp/pacific-backport-43889

pacific: mgr/cephadm: store contianer registry credentials in config-key

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #45046 from mgfritch/backport-44905-pacific

pacific: cephadm: chown the prometheus data dir during redeploy

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>

Merge pull request #44742 from idryomov/wip-rbd-switch-arguments-fix-pacific

pacific: rbd: add missing switch arguments for recognition by get_command_spec()

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #44690 from MrFreezeex/wip-53938-pacific

pacific: cls/journal: skip disconnected clients when calculating min_commit_position

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #44094 from MrFreezeex/wip-53386-pacific

pacific: rbd-mirror: make RemoveImmediateUpdate test synchronous

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #44754 from idryomov/wip-rbd-mirror-delprop-races-pacific

pacific: rbd-mirror: fix races in snapshot-based mirroring deletion propagation

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>

Merge pull request #44998 from idryomov/wip-53419-pacific

pacific: librbd: fix various memory leaks

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #44999 from idryomov/wip-52522-pacific

pacific: librbd: fix use-after-free on ictx in list_descendants()

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #45005 from sunnyku/wip-54168-pacific

pacific: mgr/rbd_support: fix schedule remove

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

mds: kill session when mds do ms_handle_remote_reset

if the mds decide to reuse the old connection it will
do reset_session and should  also kill the session
which are open state in MDSDaemon::ms_handle_remote_reset
to prevent the situation client session is stuck in
opening state and never has chance to becaome open.

the root cause is client missed the request_open
reply but the mds session has become open already.
so we should kill the session in mds side and let
mds recreate the session when received the connect
request from client.

Fixes: http://tracker.ceph.com/issues/53911
Signed-off-by: YunfeiGuan <yunfeiguan@xtaotech.com>
(cherry picked from commit 3651deb4e0b0c102adcaddce79ee4e053f033418)

Merge pull request #45008 from idryomov/wip-rbd-help-positional-optional-pacific

pacific: rbd: mark optional positional arguments as such in help output

Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

mds: fix seg fault in expire_recursive

Range-based for should not be used when we are altering the container.
Use iterator explicitly instead.

Fixes: https://tracker.ceph.com/issues/53805
Signed-off-by: 胡玮文 <huww98@outlook.com>
(cherry picked from commit d48a2cf7e2481cf9758f2934464ec6d9c35d898b)

Merge pull request #45044 from votdev/wip-54284-pacific

cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

For

  GroupSnapshotNamespace a(1, "group-1", "snap-2");
  GroupSnapshotNamespace b(1, "group-2", "snap-1");

both a < b and b < a evaluate to true.  This violates STL strict weak
ordering requirements which is a problem because GroupSnapshotNamespace
is used as a key in std::map (ictx->snap_ids at least), etc.

Fixes: https://tracker.ceph.com/issues/49792
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 830e72ab9d66c8f5703ea27da5249b02dd16ccd0)

qa/suites/rbd: make sure block-rbd.so is installed

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 8f0fd0af3da8581c47dc916303615264714a0489)

qa/tasks/qemu: make sure block-rbd.so is installed

Fixes: https://tracker.ceph.com/issues/54286
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 525ff61cfc8516b4d7bed6f819b00a0b6cb7be0a)

mgr/dashboard: "Please expand your cluster first" shouldn't be shown if cluster is already meaningfully running

This PR will assume that a cluster is already up and fully running. If this should not be the expected behaviour, deployment tools have to set 'INSTALLED' explicitly. Without this assumption it might happen that upgraded and fully running clusters, e.g. Octopus -> Pacific, will show the 'Expand Cluster' on first log in.

cephadm will take care that the bootstrap phase will write the necessary key to show the 'Expand cluster' page.

Fixes: https://tracker.ceph.com/issues/54215
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 48fff60b63785ec07f71d3e59394b0c08357247c)

Conflicts:
src/cephadm/cephadm

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/cephadm: add a test for enabling cephfs mirroring module

Add a test that checks that when cephfs mirror service is enabled
the mirroring mgr module gets enabled.

Actually-written-by: Sebastian Wagner <sewagner@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit bcb4fa70f9f739dce3e1c111db0a322804350f9d)

Conflicts:
src/pybind/mgr/cephadm/tests/test_services.py

mgr/cephadm: auto-enable mirroring module when deploying service

Automatically enable the mgr's mirroring module when creating
cephfs-mirror services. This will trigger a mgr respawn.

Fixes: https://tracker.ceph.com/issues/50593
Based roughly on 50dc1d0decb2fbf7b9129bddba940969410be5cd

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit e030130fd1d680ebf9d2c6c9f95f44109fbf3036)

mgr/cephadm: store contianer registry credentials in config-key

Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
(cherry picked from commit 2c29286b370b1079a35e0e0d47c33a7dabab3468)

Conflicts:
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/serve.py

Merge pull request #44725 from cfsnyder/wip-53703-pacific

pacific: osdc: add set_error in BufferHead, when split set_error to right

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #44865 from cbodley/wip-54090

pacific: qa: remove centos8 from supported distros

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44545 from cfsnyder/wip-53718-pacific

pacific: osd/OSDMapMapping: fix spurious threadpool timeout errors

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44879 from adk3798/pacific-co-locate-doc

pacific: doc/cephadm: Co-location of daemons

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44146 from k0ste/wip-53435-pacific

pacific: mgr/prometheus: Fix the per method stats exported

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44830 from adk3798/pacific-rm-iscsi

pacific: mgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command`

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44829 from adk3798/pacific-cpu-limit

pacific: mgr/cephadm: allow miscellaneous container args at service level

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44637 from sebastian-philipp/pacific-backport-44566

pacific: mgr/cephadm: fix minor grammar nit in Dry-Runs message

Reviewed-by: Michael Fritch mfritch@suse.com

Merge pull request #44634 from sebastian-philipp/pacific-backport-44498

pacific: cephadm: check if cephadm is root after cli is parsed

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #44633 from sebastian-philipp/pacific-backport-44394

pacific: Enable autotune for osd_memory_target on bootstrap

Reviewed-by: Melissa Li melissali@redhat.com

Merge pull request #44631 from sebastian-philipp/pacific-backport-44482

pacific: mgr/cephadm: nfs migration: avoid port conflicts

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44630 from sebastian-philipp/pacific-backport-43833

pacific: mgr/cephadm: fix tcmu-runner cephadm_stray_daemon

Reviewed-by: Melissa Li melissali@redhat.com

Merge pull request #44628 from sebastian-philipp/pacific-backport-44374

pacific: mgr/cephadm: fix 'mgr/cephadm: spec.virtual_ip  param should be used by the ingress daemon

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #44723 from cfsnyder/wip-53608-pacific

pacific: os/bluestore: avoid premature onode release.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #44721 from cfsnyder/wip-53535-pacific

pacific: mon/MgrStatMonitor: do not spam subscribers (mgr) with service_map

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44698 from cfsnyder/wip-53942-pacific

pacific: mon/OSDMonitor: avoid null dereference if stats are not available

Reviewed-by: Neha Ojha <nojha@redhat.com>

pybind/mgr/devicehealth/module.py: use NotifyType enum

master/quincy use a precreated .mgr pool and does not
need this commit

Signed-off-by: Neha Ojha <nojha@redhat.com>

mgr: only queue notify events that modules ask for

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit ee4e3ecd6e0754854c00f3dfa0eaaa17bbf3603d)

pybind/mgr: annotate which events modules consume

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 95ca3a444505b5bd38f4961ed63760ac45abcf64)

 Conflicts:
src/pybind/mgr/mds_autoscaler/module.py - trivial resolution

pybind/mgr: introduce NotifyType enum

Note that we don't annotate the dashboard NotificationQueue because it is
used internally by the dashboard with other events.

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 1ac480df45058e103a2f4954950b8a4edb23610a)

 Conflicts:
src/pybind/mgr/cephadm/module.py - trivial resolution
src/pybind/mgr/dashboard/module.py - trivial resolution
src/pybind/mgr/localpool/module.py - trivial resolution
src/pybind/mgr/mds_autoscaler/module.py - trivial resolution

mgr: stop issuing events that no modules consume

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit d3c8f171e9aaa9cbf970b6dadda5837ca9b030c7)

mgr: limit changes to pg_num

We need to avoid making drastic changes to pg_num that outpace pgp_num or
else we will may hit the per-osd pg limits.

Fixes: https://tracker.ceph.com/issues/53442
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 3b2a11249aff6ee608efc95212d6723df180cd07)

 Conflicts:
src/common/options/mgr.yaml.in - old way of specifying config settings

mgr/progress: avoid inefficient dump of all pg stats

We only use a handful of fields, and the pg dump includes a gazillion
fields that we waste CPU copying to python-land.  This tends to lead to
long ClusterState::lock hold times, leading to long ms_dispatch delays
and generally gumming up the works.

Instead, create a new "pg_progress" item that dumps only the fields that
mgr/progress needs.

Fixes: https://tracker.ceph.com/issues/53475
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit f5973ccef415571c72560a04968592e8a6daf93a)

pybind/mgr/mgr_module: cache mgr_ip

This does not change for the lifetime of an active mgr module.  No need to
keep calling back into Mgr to re-fetch it.

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 994832e8e50c3566e21928f6be61e45a4411e556)

 Conflicts:
src/pybind/mgr/mgr_module.py - self._db_lock = threading.Lock() DNE in pacific

Merge pull request #45028 from rhcs-dashboard/wip-54269-pacific

pacific: mgr/dashboard: Directories Menu Can't Use on Ceph File System Dashboard

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #45052 from rhcs-dashboard/wip-54295-pacific

pacific: mgr/dashboard: change privacy protocol field from required to optional

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44747 from cybozu/wip-53070-pacific

pacific: rgw: fix lock scope in ObjectCache::get()

Merge pull request #44750 from rhcs-dashboard/wip-53987-pacific

pacific: mgr: TTL Cache in mgr module

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: neha-ojha <NOT@FOUND>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: add validation for snmp v3 engine id

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 2866db1eac7d726201f5bb34abdb32981c783f0e)

mgr/dashboard: change privacy protocol field from required to optional

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Privacy protocol field shouldn't be a required field.

(cherry picked from commit 2d8f2b8195a0f0c7a21d4ec5061b1b51a3aade2c)

Merge pull request #44543 from cfsnyder/wip-53659-pacific

pacific: mon: prevent new sessions during shutdown

Reviewed-by: Neha Ojha <nojha@redhat.com>

cephadm: chown the prometheus data dir during redeploy

some builds of prometheus run with a uid 65534 (nobody) where other
builds of prometheus run with a uid of 0 (root)

Fixes: https://tracker.ceph.com/issues/54159
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 21fb80aaab0b333d997d8241e17cf9749a37e065)

doc/cephadm: Add CentOS Stream install instructions

Tested on CentOS Stream 9

Signed-off-by: Patrick C. F. Ernzer <pcfe@pcfe.net>.

cephadm/ingress: make frontend stat bind on localhost

The current configuration of keepalived makes it do
a curl on localhost:9999 in order to check the endpoint is alive.
Given the endpoint only binds on the vip addr, that doesn't work.

Fixes: https://tracker.ceph.com/issues/53807
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44756 from votdev/wip-53929-pacific

pacific: mgr/dashboard: Notification banners at the top of the UI have fixed height

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #44938 from rhcs-dashboard/wip-54091-pacific

pacific: mgr/dashboard: cephadm e2e job improvements

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44935 from rhcs-dashboard/pacific-test-applitools

pacific: mgr/dashboard: set appropriate baseline branch for applitools

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44876 from aaSharma14/wip-53930-pacific

pacific: mgr/dashboard: Improve notifications for osd nearfull, full

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44789 from guits/wip-54021-pacific

pacific: ceph-volume: improve mpath devices support

Merge pull request #44884 from guits/wip-54127-pacific

pacific: ceph-volume: fix error 'KeyError' with inventory

mgr/dashboard:Directories Menu Can't Use on Ceph File System Dashboard

Added exception handling to opendir() in cephfs.py for directories with no execute permission.

Fixes: https://tracker.ceph.com/issues/51611
Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>
(cherry picked from commit ea1af5438d380eb2160de635ffc7b08a69baf04c)

Merge pull request #44767 from guits/wip-54007-pacific

pacific: ceph-volume: fix tags dict output in `lvm list`

ceph-volume: fix error 'KeyError' with inventory

The tag ceph.cluster_name is always set at the end.
The only way it could be absent was if the osd prepare
has been interrupted between [1] and [2].

[1] https://github.com/ceph/ceph/blob/v14.2.11/src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py#L355-L387
[2] https://github.com/ceph/ceph/blob/v14.2.11/src/ceph-volume/ceph_volume/devices/lvm/prepare.py

Although the code received tremendous changes meantime
and this error shouldn't show up again, we need to handle
the case where this tag wouldn't have been set.

Fixes: https://tracker.ceph.com/issues/44356
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 691660c42eaa568a754670e093c512aa041d1479)

ceph-volume: fix typo in tests

This fixes 2 typo in ceph-volume tests.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit b07bd3e0e17021e0cf9773f916fad954f12254ed)

doc/ceph-volume: fix a typo

This fixes a typo in ceph-volume documentation.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 5d0a3cee5d7021dafd1e166e17946689b4bb90b7)

ceph-volume: add a test `test_mpath_device_is_device`

This test checks that Device.is_device() returns True for a mpath device.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 0280ff6df09bc26107bc97446e9d5c18fbc582e9)

ceph-volume: improve mpath devices support

ee8887f4c0ff4f91117f31b621b95c8d08019130 was intended for adding
mpath devices support in ceph-volume but it has missed the lvm batch scenario.
This also fixes the zapping of mpath devices prepared with `ceph-volume raw`

Fixes: https://tracker.ceph.com/issues/52908
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 601ff7ed0a3ba5172b6bd886ca8ba2bd4d9e655a)

Merge pull request #44973 from guits/wip-54244-pacific

pacific: ceph-volume: honour osd_dmcrypt_key_size option