ceph_dedup_tool: fix threshold comparison

If threadhold count is 2, existing code always returns true
even though reference count is 1 actually  because it additionally
adds one via ++.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

ceph_dedup_tool: make SampleDedupWorkerThread::chunk_size const

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: remove unused SampleDedupWorkerThread::duplicable_chunks

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: minor code simplifications

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: remove unimplemented mark_non_dedup method signature

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: fix log lines to use std::endl, update object skip message

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: remove unused SampleDedupWorkerThread::do_object_dedup

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: make SampleDedupGlobal::sampling_rate const

Clarifies why it doesn't need to be protected by a lock.

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: remove unused SampleDedupGlobal::object_dedup_threshold

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: fix unnecessarily complicated bool returns

Signed-off-by: Samuel Just <sjust@redhat.com>

ceph_dedup_tool: SampleDedupWorkerThread can simply inherit from Thread

SampleDedupWorkerThread didn't actually use any of the facilities on
CrawlerThread and indeed left several of them uninitialized.

Also allows us to remove the CrawlerThread constructor which left
several members uninitialized.

Signed-off-by: Samuel Just <sjust@redhat.com>

qa: remove unused values in deduplication.py

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

qa: add validation stage for deduplication.py

To validate sample-dedup actually works, validate() runs
separated thread from sample-dedup and verifies
two following things.
1. check sample-dedup starts properly.
2. check references of all the chunk objects' in chunk tier
   exists in designated base pool.
This routune repeats for max_valication_cnt times while
sample-dedup is running. If it doesn't raise any fail while the loop,
we can pretend sample-dedup works accurately.
If not, assert() will stop this test.

In case that a reference of chunk object doesn't exist in base pool,
validate() gives a second chance after repairing it (chunk-repair op)
to deal with false-positive reference inconsistency.

Signed-off-by: Sungmin Lee <sung_min.lee@samsung.com>

src/tools/ceph_dedup_tool: fixes to daemonize the process correctly

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

qa: add deduplication test under RGW workload (s3)

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

qa: add test case for sample_dedup operation of dedup_tool

Signed-off-by: JinyongHa <jy200.ha@samsung.com>

dedup-tool: add options for operating usability

Daemonization is used for background execution of crawler.
Iterative execution makes crawler threads wake up at each period.

[usage]
  ceph_dedup_tool --op sample-dedup --pool POOL --chunk-pool POOL \
    --iterative --daemonize

Signed-off-by: JinyongHa <jy200.ha@samsung.com>

dedup-tool: add sampling ratio to crawling

By using lower sampling ratio, runtime deduplication with lower overhead.
It tries deduplication with sampled few objects in base-pool, and
only deduplicates objects or chunks which are highly duplicated among
samples.
The option "sampling-ratio" is used for controling the ratio of the objects
to be picked.

Signed-off-by: JinyongHa <jy200.ha@samsung.com>

dedup-tool: add basic crawling

Create crawling threads which crawl objects in base pool and deduplicate
based on their deduplication efficiency. Crawler samples objects and finds
duplicated chunks within the samples. It regards an object which has
duplicated chunks higher than object_dedup_threshold value as an efficient
object to be deduplicated. Besides the chunk which is duplicated more than
chunk_dedup_threshold times is also deduplicated.
The commit contains basic crawling which crawls all objects in base pool
instead of sampling among the objects.

[usage]
  ceph_dedup_tool --op sample-dedup --pool POOL --chunk-pool POOL \
    --chunk-altorithm ALGO --fingerprint-algorithm FP \
    --object-dedup-threshold <percentile> --chunk-dedup-threshold <number>

Signed-off-by: JinyongHa <jy200.ha@samsung.com>

Merge pull request #46523 from alvistack/pg_autoscaler-module.py

pybind/mgr: maximum recursion depth exceeded in comparison

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47366 from adk3798/quoted-networks

cephadm: support quotes around public/cluster network in config passed to bootstrap

Reviewed-by: Francesco Pantano <fpantano@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #47346 from rhcs-dashboard/remove-grafana-loki-dependency

mgr/dashboard: add flag to automatically deploy loki/promtail service at bootstrap

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47489 from cyx1231st/wip-seastore-trimmer

crimson/os/seastore: introduce JournalTrimmer with refactors

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Zhang Song <zhangsong325@gmail.com>

crimson/os/seastore: introduce JournalTrimmer

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/cache: decouple prepare_record() from segment_provider

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: be explicit about detecting out-dated delta using segment info

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: decouple segment release from transaction manager

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: construct TransactionManager classes after device mount

To construct TransactionManager after all the devices are discoverred.

Also, it makes the following cleanups possible:
* Cleanup SeaStore and TransactionManager factory methods.
* Decouple TransactionManager from SegmentManagerGroup.
* Drop the unnecessary tm_make_config_t.
* Drop the unnecessary add_device() methods.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/epm: configure prefer_ool through the primary_device

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #47548 from cbodley/wip-57073

install-deps: fix centos 8's use of gcc-toolset-11

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47544 from ceph/pmem-c9

ceph.spec.in: disable system_pmdk on aarch64

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #47543 from cbodley/wip-cmake-cxx20-compiler-versions

cmake: enforce minimum compiler versions for c++20

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47534 from tchaikov/wip-cmake-motr

cmake: find motr libraries and header before using them

Reviewed-by: Casey Bodley <cbodley@redhat.com>

cephadm: unit test for parsing networks from config

Signed-off-by: Adam King <adking@redhat.com>

cephadm: support quotes around public/cluster network in config passed to bootstrap

Fixes: https://tracker.ceph.com/issues/56973
Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #47421 from adk3798/conf-osd-reconfig

mgr/cephadm: recreate osd config when redeploy/reconfiguring

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #47464 from michaelalang/master

mgr/cephadm: provide an additional hint when running into I/O closed exception

Reviewed-by: Adam King <adking@redhat.com>

ceph.spec.in: install gcc-toolset-11-libatomic-devel in x86_64 also

otherwise after enabling gcc-toolset-11, cmake fails with:

- Performing Test HAVE_LIBATOMIC - Failed
CMake Error at cmake/modules/CheckCxxAtomic.cmake:66 (message):
  Host compiler /opt/rh/gcc-toolset-11/root/usr/bin/g++ requires libatomic,
  but it is not found

Signed-off-by: Casey Bodley <cbodley@redhat.com>

install-deps: bump gcc-toolset version to 11

match the toolset versions installed from ceph.spec.in

Signed-off-by: Casey Bodley <cbodley@redhat.com>

install-deps: update ensure_decent_gcc_on_rh for gcc-toolset

Signed-off-by: Casey Bodley <cbodley@redhat.com>

install-deps: centos8 doesn't have or need centos-release-scl

Fixes: https://tracker.ceph.com/issues/57073
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #46378 from pritha-srivastava/wip-rgw-sts-modify-session-duration

rgw/sts: modify max_session_duration using update role REST API/ radosgw-admin command.

ceph.spec.in: disable system_pmdk on aarch64

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #47538 from tchaikov/wip-enable-gts

ceph.spec.in: %enable_devtoolset11 only if the macro is defined

cmake: enforce minimum compiler versions for c++20

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #47541 from ceph/1723

doc: Add missing index links for 17.2.3

doc: Add missing index links for 17.2.3

Signed-off-by: David Galloway <dgallowa@redhat.com>

ceph.spec.in: always use stock compiler on el9

as RHEL/CentOS 9, we have the access to GCC-11, which is good enough for
compiling main HEAD even with WITH_SEASTAR=ON.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #46400 from rkachach/fix_issue_55733

mgr/cephadm: adding dynamic prometheus configuration based on http_sd_config

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

ceph.spec.in: define %gts_prefix

less repeatings this way, also  allow maintainer to use other version of GTS.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

ceph.spec.in: %enable_devtoolset11 only if the macro is defined

there is chance that we are using `yum-builddep` to prepare the
build dependencies. in that case, gcc-toolset-11-build is not
installed. it's like a chicken-egg dilemma, but the point is
`yum-builddep` is able to pull in the gcc-toolset-11-build. once
gcc-toolset-11-build is installed, we will have the %enable_devtoolset11
rpm macro.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #43155 from ljflores/wip-install-deps-fix

install-deps.sh: ensure that pip ugrades to most recent version within virtualenv

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47278 from rzarzynski/wip-cephx-verify_auth_cleanups

monc, cephx: improve debugs and slightly clean invalidate_ticket() up

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #47092 from dparmar18/wip-dparmar-cephadm-simple-1

pybind/mgr/cephadm/upgrade: allow upgrades without reducing max_mds

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

mgr/cephadm: setting version field to a 17.2.3

Signed-off-by: Redouane Kachach <rkachach@redhat.com>

mgr/cephadm: adding dynamic prometheus config based on http_sd

Signed-off-by: Redouane Kachach <rkachach@redhat.com>

cmake: find motr libraries and header before using them

cmake should fail when generating the building system, if the necessary
development libraries or the header files are missing.

in this change, Findmotr.cmake is added to detect the motr library
and header so that we can use it to find the motr package before using
it.

See-also: https://tracker.ceph.com/issues/57079
Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47479 from ceph/wip-backportbot_script-main

.github/workflows: add create-backport action

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

.github/workflows: add create-backport action

Currently there's a cron job in a teuthology VM running a script to find all trackers in needs-backports and to create their corresponding backport trackers. This is done through the [Backport Bot](https://tracker.ceph.com/users/12172) Redmine account.

This PR intends to run this cron job task as a periodic Github Action.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #47514 from guits/c-v-thread-inventory-2

ceph-volume: system.get_mounts() refactor

Merge pull request #47198 from ceph/wip-yuriw-release-15.2.17-main

doc: 15.2.17 Release Notes

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/releases/octopus.rst: add note for CVE-2022-0670

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/releases/octopus.rst: add note for rbd perf image iostat/iotop

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/releases/octopus.rst: add release note for rados

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc: 15.2.17 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #47179 from rhcs-dashboard/service-id-info

mgr/dashboard: validate mds service_id and helper text for service_id

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #47517 from tchaikov/wip-cortx-motr-jammy

install-deps: install cortx-motr from chacra on jammy

Reviewed-by: Casey Bodley <cbodley@redhat.com>

pybind/mgr: maximum recursion depth exceeded in comparison

Original issue from https://github.com/python/typing_extensions/issues/10

In case typing-extensions is upgrade to 4.1.1
(https://pypi.org/project/typing-extensions/4.1.1/, the final Python 3.6
supported version), Ceph MGR will failed with pg_autoscaler as below:

    [root@cp-nightsky ~]# pip list | grep typing-extensions
    typing-extensions      4.1.1

    [root@cp-nightsky ~]# systemctl restart ceph-mgr@cp-nightsky.service

    [root@cp-nightsky ~]# journalctl -xef -u ceph-mgr@cp-nightsky.service
    May 12 06:16:39 cp-nightsky.novalocal systemd[1]: Started Ceph cluster manager daemon.
    -- Subject: Unit ceph-mgr@cp-nightsky.service has finished start-up
    -- Defined-By: systemd
    -- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
    --
    -- Unit ceph-mgr@cp-nightsky.service has finished starting up.
    --
    -- The start-up result is done.
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.181+0000 7fe3eb521700 -1 log_channel(cluster) log [ERR] : Unhandled exception from module 'pg_autoscaler' while running on mgr.cp-nightsky: maximum recursion depth exceeded in comparison
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.182+0000 7fe3eb521700 -1 pg_autoscaler.serve:
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.182+0000 7fe3eb521700 -1 Traceback (most recent call last):
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/usr/share/ceph/mgr/pg_autoscaler/module.py", line 206, in serve
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: self._maybe_adjust()
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/usr/share/ceph/mgr/pg_autoscaler/module.py", line 423, in _maybe_adjust
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: ps, root_map, pool_root = self._get_pool_status(osdmap, pools)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/usr/share/ceph/mgr/pg_autoscaler/module.py", line 325, in _get_pool_status
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: self.log.debug('skipping empty subtree %s', cr_name)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/logging/__init__.py", line 1296, in debug
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: self._log(DEBUG, msg, args, **kwargs)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/logging/__init__.py", line 1443, in _log
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: exc_info, func, extra, sinfo)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/logging/__init__.py", line 1413, in makeRecord
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: sinfo)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/logging/__init__.py", line 277, in __init__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if (args and len(args) == 1 and isinstance(args[0], collections.Mapping)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/abc.py", line 193, in __instancecheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: return cls.__subclasscheck__(subclass)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/abc.py", line 228, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if issubclass(subclass, scls):
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/abc.py", line 228, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if issubclass(subclass, scls):
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/typing.py", line 1154, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: return super().__subclasscheck__(cls)
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib64/python3.6/abc.py", line 228, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if issubclass(subclass, scls):
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib/python3.6/site-packages/typing_extensions.py", line 426, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if issubclass(subclass, scls):
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib/python3.6/site-packages/typing_extensions.py", line 426, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if issubclass(subclass, scls):
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib/python3.6/site-packages/typing_extensions.py", line 426, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if issubclass(subclass, scls):
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: [Previous line repeated 239 more times]
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: File "/lib/python3.6/site-packages/typing_extensions.py", line 421, in __subclasscheck__
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: if self.__extra__ in subclass.__mro__:
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: RecursionError: maximum recursion depth exceeded in comparison
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.291+0000 7fe3de3c7700 -1 client.0 error registering admin socket command: (17) File exists
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.291+0000 7fe3de3c7700 -1 client.0 error registering admin socket command: (17) File exists
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.291+0000 7fe3de3c7700 -1 client.0 error registering admin socket command: (17) File exists
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.291+0000 7fe3de3c7700 -1 client.0 error registering admin socket command: (17) File exists
    May 12 06:16:51 cp-nightsky.novalocal ceph-mgr[1719]: 2022-05-12T06:16:51.291+0000 7fe3de3c7700 -1 client.0 error registering admin socket command: (17) File exists

Solution provided by
https://github.com/python/typing_extensions/issues/10#issuecomment-1131767191
not working:

    self.log.debug('skipping empty subtree %s', str(cr_name))

But implement with `.format` could help:

    self.log.debug("skipping empty subtree {0}".format(cr_name))

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

Merge pull request #47488 from cbodley/wip-rgw-lc-shuffle

rgw/lc: random_sequence() uses default_random_engine

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #47504 from cbodley/wip-57050

rgw/cmake: stop building all of radosgw a shared lib

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #47503 from ceph/infosec

.gitleaks.toml: Allowlist cephadm test

qa/suites/fs/upgrade: added upgrade_without_reducing_max_mds for testing the fail_fs option

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

qa/tasks/fs: add cases in post_upgrade_checks() for fail_fs

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

doc/cephadm/upgrade: Add doc for mds upgrade without reducing mds_mds to 1.

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

PendingReleaseNotes: added note related to new mds upgrade option using cephadm

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

pybind/mgr/cephadm/upgrade: allow upgrades without reducing max_mds

Fixes: https://tracker.ceph.com/issues/55715
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #46101 from myoungwon/wip-dedup-tool-update

tool: modify object-dedup command to run on manifest object

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #46242 from kamoltat/wip-ksirivad-fix-overlapping-message

pybind/mgr/pg_autoscaler: change overlapping roots to warning

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #47408 from ronen-fr/wip-rf-snprefix

osd: a faster version of SnapMapper::get_prefix()

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #46573 from aclamk/wip-one-cmdparse

common/cmdparse: Unsplit crimson/classic

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #47379 from NitzanMordhai/wip-nitzan-valgrind-handle-recovery-delete

osd: remove invalid put on message

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #47500 from tchaikov/wip-no-more-distutils

pybind/mgr/dashboard: do not use distutils.version.StrictVersion

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

install-deps: install cortx-motr from chacra

this is an intermediate solution before cotx-motr upstream builds the
packages for jammy and upload them to github.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

install-deps: extract install_cortx_motr_on_ubuntu out

for better readability and maintainability

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47496 from tchaikov/wip-atomic-fc36

ceph.spec.in: add libatomic to BuildRequires on fedora

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

pybind/mgr/dashboard: do not use distutils.version.StrictVersion

replace `distutils.version.StrictVersion` with
`pkg_resources.parse_version()`

as the former is deprecated, see https://peps.python.org/pep-0632/.
let's use `pkg_resources` instead. this change also addresses
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010894.
we have this issue when testing with an ubuntu jammy test node.
see https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1967139

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47505 from ceph/dot

doc: Install graphviz

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

ceph-volume: system.get_mounts() refactor

When a network mount is present in `/proc/mounts` but for any reason
the corresponding server is down, this function hangs forever.
In a cluster deployed with cephadm, the consequence is that
it triggers `ceph-volume inventory` commands that hang and stay in D
state.

The idea here is to use a thread with a timeout to abort the call if the
timeout is reached.
`get_mounts()` is now a method of a class so we can exclude a path
altogether during the whole `inventory` execution (otherwise,
ceph-volume would try to access it as many devices there is on the
host which could slow down the inventory execution)

Fixes: https://tracker.ceph.com/issues/57070
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #47476 from rosinL/fix-enoent

crimson/os/seastore: return future when no element error tolerated

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #47425 from cyx1231st/wip-seastore-backref-cleanup

crimson/os/seastore: backref related cleanups

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>

doc: Install graphviz

Fixes `WARNING: dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting`

Signed-off-by: David Galloway <dgallowa@redhat.com>

- mgr/cephadm: provide an additional hint when running into I/O closed exception from execnet seen as
               Error EINVAL: Can't communicate with remote host `127.0.0.1`, possibly because python3 is not installed there: cannot send (already closed?)

Signed-off-by: Michaela Lang <milang@redhat.com>

rgw/cmake: stop building all of radosgw a shared lib

Fixes: https://tracker.ceph.com/issues/57050
Signed-off-by: Casey Bodley <cbodley@redhat.com>

.gitleaks.toml: Allowlist cephadm test

I signed up for Red Hat's gitleaks scanning service.  The self-signed key is just for testing purposes.

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #47475 from Huber-ming/stale_delete

rgw: correct help message of 'reshard stale-instances delete'

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

ceph.spec.in: add libatomic to BuildRequires on fedora

otherwise we'd have failures like

/opt/compiler-explorer/gcc-trunk-20220808/bin/../lib/gcc/x86_64-linux-gnu/13.0.0/../../../../x86_64-linux-gnu/bin/ld:
/tmp/ccVlMbVh.o: in function `std::atomic<tagged_ptr>::store(tagged_ptr,
std::memory_order)':
/opt/compiler-explorer/gcc-trunk-20220808/include/c++/13.0.0/atomic:273:
undefined reference to `__atomic_store_16'

when generating the building system using CMake on fedora 36.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47486 from tchaikov/wip-dashboard-newer-teuth

mgr/dashboard: bump up teuthology

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #46972 from nSedrickm/button-name-accessibility-update

mgr/dashboard: Improve level A accessibility for buttons

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #46927 from nmshelke/fix-55762

mgr/volumes: filter internal directories in 'subvolumegroup ls' command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

Merge pull request #47436 from SUSE/wip-mib-snmp-dir

ceph.spec.in: ceph-mib: require snmp-mibs on SUSE distros

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Justin Caratzas <jcaratza@redhat.com>