]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoceph.spec.in: remove build directory in %clean, not %install 45705/head
Tim Serong [Wed, 30 Mar 2022 05:25:30 +0000 (16:25 +1100)]
ceph.spec.in: remove build directory in %clean, not %install

Removing the build directory at the end of %install is too soon,
and means we get rid of a bunch of stuff needed to correctly
create debuginfo/debugsource packages, which happens automatically
right after %install.  So, let's put it where it really belongs, in
the %clean section.

Fixes: aa18cb12003e3526c8e8f23dc2335a483fbfa68e
Fixes: https://tracker.ceph.com/issues/55079
Signed-off-by: Tim Serong <tserong@suse.com>
3 years agoMerge pull request #45563 from rhcs-dashboard/fix-54991-master
Ernesto Puerta [Tue, 29 Mar 2022 17:03:49 +0000 (19:03 +0200)]
Merge pull request #45563 from rhcs-dashboard/fix-54991-master

mgr/dashboard:  don't log 3xx as errors

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #45295 from lbausch/tweak_mgr_alerts_mail
Boris Ranto [Tue, 29 Mar 2022 11:55:14 +0000 (13:55 +0200)]
Merge pull request #45295 from lbausch/tweak_mgr_alerts_mail

mgr/alerts: Add Message-Id and Date header to sent emails

Reviewed-by: Boris Ranto <branto@redhat.com>
3 years agomgr/dashboard: don't log 3xx as errors 45563/head
Ernesto Puerta [Tue, 22 Mar 2022 13:40:30 +0000 (14:40 +0100)]
mgr/dashboard:  don't log 3xx as errors

Let's avoid printing these ugly/misleading/redundant messages:

```
0 [dashboard DEBUG controllers.home] frontend language from headers: ['en-us']
0 [dashboard DEBUG controllers.home] found directory for language 'en-us'
0 [dashboard DEBUG controllers.home] serving static content: /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/build/src/pybind/mgr/dashboard/frontend/dist/en-US/styles.css
0 [dashboard ERROR exception] Internal Server Error
Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/pybind/mgr/dashboard/services/exception.py", line 47, in dashboard_exception_handler
    return handler(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/cherrypy/_cpdispatch.py", line 60, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/pybind/mgr/dashboard/controllers/home.py", line 134, in __call__
    return serve_file(full_path)
  File "/usr/lib/python3/dist-packages/cherrypy/lib/static.py", line 70, in serve_file
    cptools.validate_since()
  File "/usr/lib/python3/dist-packages/cherrypy/lib/cptools.py", line 117, in validate_since
    raise cherrypy.HTTPRedirect([], 304)
cherrypy._cperror.HTTPRedirect: ([], 304)
```

Fixes: https://tracker.ceph.com/issues/54991
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #45676 from rzarzynski/wip-crimson-toolset-10
Kefu Chai [Tue, 29 Mar 2022 09:03:14 +0000 (17:03 +0800)]
Merge pull request #45676 from rzarzynski/wip-crimson-toolset-10

ceph.spec.in: use gcc-toolset-10 for building crimson

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44014 from rhcs-dashboard/host-detail-service-column
Ernesto Puerta [Tue, 29 Mar 2022 08:49:31 +0000 (10:49 +0200)]
Merge pull request #44014 from rhcs-dashboard/host-detail-service-column

mgr/dashboard: extend daemon actions to host details

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
3 years agoMerge pull request #45537 from yuvalif/wip-yuval-multisite-test-devices
Yuval Lifshitz [Tue, 29 Mar 2022 07:35:57 +0000 (10:35 +0300)]
Merge pull request #45537 from yuvalif/wip-yuval-multisite-test-devices

multisite/test: running the multisite test script with custom devices

3 years agoMerge pull request #45666 from SUSE/wip-fix-55087
Tim Serong [Tue, 29 Mar 2022 07:01:46 +0000 (18:01 +1100)]
Merge pull request #45666 from SUSE/wip-fix-55087

ceph.spec.in: Use libthrift-devel on SUSE distros

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #45664 from SUSE/wip-fix-55079
Tim Serong [Tue, 29 Mar 2022 06:08:09 +0000 (17:08 +1100)]
Merge pull request #45664 from SUSE/wip-fix-55079

ceph.spec.in: remove build directory at end of %install

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoceph.spec.in: use gcc-toolset-10 for building crimson 45676/head
Radosław Zarzyński [Mon, 28 Mar 2022 14:38:44 +0000 (16:38 +0200)]
ceph.spec.in: use gcc-toolset-10 for building crimson

This commit bumps up the toolset version but only to build crimson.
That is, the classical OSD stays unaffected.

The reason behind the upgrade is the following FTBFS:

```
[ 32%] Building CXX object src/seastar/CMakeFiles/seastar.dir/src/core/reactor.cc.o
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc: In constructor ‘seastar::reactor::reactor(std::shared_ptr<seastar::smp>, seastar::alien::instance&, unsigned int, seastar::reactor_backend_selector, seastar::reactor_config)’:
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc:926:90: error: use of deleted function ‘seastar::condition_variable::condition_variable()’
  926 |     , _thread_pool(std::make_unique<thread_pool>(this, seastar::format("syscall-{}", id))) {
      |                                                                                          ^
In file included from /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/include/seastar/core/reactor.hh:74,
                 from /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/src/core/reactor.cc:32:
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11345-ga3bb1485/rpm/el8/BUILD/ceph-17.0.0-11345-ga3bb1485/src/seastar/include/seastar/core/condition-variable.hh:157:5: note: ‘seastar::condition_variable::condition_variable() noexcept’ is implicitly deleted because its exception-specification does not match the implicit exception-specification ‘’
  157 |     condition_variable() noexcept = default;
```

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
3 years agoMerge pull request #45647 from rhcs-dashboard/fix-55060-master 45682/head
Ernesto Puerta [Mon, 28 Mar 2022 15:29:11 +0000 (17:29 +0200)]
Merge pull request #45647 from rhcs-dashboard/fix-55060-master

mgr/dashboard: fix api test issue with pip

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: zmc <NOT@FOUND>
3 years agoceph.spec.in: Use libthrift-devel on SUSE distros 45666/head
Tim Serong [Mon, 28 Mar 2022 09:45:01 +0000 (20:45 +1100)]
ceph.spec.in: Use libthrift-devel on SUSE distros

Fixes: 80e82686ebafe36fca6dfd21cb32e63ced94d5cd
Fixes: https://tracker.ceph.com/issues/55087
Signed-off-by: Tim Serong <tserong@suse.com>
3 years agomgr/dashboard: fix api test issue with pip 45647/head
Ernesto Puerta [Fri, 25 Mar 2022 15:26:48 +0000 (16:26 +0100)]
mgr/dashboard: fix api test issue with pip

Fix
```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-libcloud 3.5.0 requires requests>=2.26.0, but you have requests 2.25.1 which is incompatible.
Successfully installed CherryPy-13.1.0 PyJWT-2.0.1 Routes-2.4.1 bcrypt-3.1.4 ceph-1.0.0 chardet-4.0.0 cheroot-8.6.0 idna-2.10 jaraco.functools-3.5.0 more-itertools-4.1.0 natsort-8.1.0 portend-3.1.0 pyopenssl-22.0.0 pytz-2022.1 repoze.lru-0.7 requests-2.25.1 tempora-5.0.1
```

Fixes: https://tracker.ceph.com/issues/55060
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoceph.spec.in: remove build directory at end of %install 45664/head
Tim Serong [Mon, 28 Mar 2022 04:12:10 +0000 (15:12 +1100)]
ceph.spec.in: remove build directory at end of %install

By the time we get to the end of the %install section, all the
built binaries have been installed in the build root, so we can
delete the build directory from the source tree.  This frees up
about 17GB of disk space on build hosts, which is helpful in
case other processes later in the RPM build need more disk space.

Fixes: https://tracker.ceph.com/issues/55079
Signed-off-by: Tim Serong <tserong@suse.com>
3 years agoMerge pull request #45661 from tchaikov/doc-dpdk
Kefu Chai [Sun, 27 Mar 2022 01:58:43 +0000 (09:58 +0800)]
Merge pull request #45661 from tchaikov/doc-dpdk

doc/dpdk: reformat and reword

Reviewed-by: Chunsong Feng <fengchunsong@huawei.com>
3 years agodoc/dpdk: reword the root access part 45661/head
Kefu Chai [Sat, 26 Mar 2022 17:00:19 +0000 (01:00 +0800)]
doc/dpdk: reword the root access part

the root access to system is not a must have for running a DPDK
application. so reword the "Configuring OSD DPDKStack" section.

also, manually editing /etc/passwd is not encouraged, so use
"usermod" instead. to add a directory after user's command
interpreter in /etc/passwd does not make sense. see PASSWD(5).
so drop the paragraph on editing /etc/passwd.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #45640 from ronen-fr/wip-rf-snaptrim
Ronen Friedman [Sat, 26 Mar 2022 17:00:20 +0000 (20:00 +0300)]
Merge pull request #45640 from ronen-fr/wip-rf-snaptrim

osd/scrub: restart snap trimming only after scrubbing is done

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/dpdk: improve the formatting
Kefu Chai [Sat, 26 Mar 2022 16:45:29 +0000 (00:45 +0800)]
doc/dpdk: improve the formatting

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44292 from fengchunsong/dpdk-doc
Kefu Chai [Sat, 26 Mar 2022 15:48:00 +0000 (23:48 +0800)]
Merge pull request #44292 from fengchunsong/dpdk-doc

doc/dev: add dpdkstack doc

Reviewed-by: Haomai Wang <haomai@xsky.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44343 from adk3798/nfs-offline
Adam King [Fri, 25 Mar 2022 23:45:39 +0000 (19:45 -0400)]
Merge pull request #44343 from adk3798/nfs-offline

mgr/cephadm: Reschedule nfs daemons from offline hosts

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #45649 from tchaikov/wip-crimson-cleanup
David Galloway [Fri, 25 Mar 2022 19:07:39 +0000 (15:07 -0400)]
Merge pull request #45649 from tchaikov/wip-crimson-cleanup

crimson/os: use fmt::format() instead of sstream

3 years agoMerge pull request #45539 from rhcs-dashboard/css-fix-highlight-search
David Galloway [Fri, 25 Mar 2022 18:44:46 +0000 (14:44 -0400)]
Merge pull request #45539 from rhcs-dashboard/css-fix-highlight-search

mgr/dashboard: Remove padding in search highlighted text

3 years agoMerge pull request #45651 from sseshasa/wip-qa-fix-activate-osd-test
Neha Ojha [Fri, 25 Mar 2022 18:24:52 +0000 (11:24 -0700)]
Merge pull request #45651 from sseshasa/wip-qa-fix-activate-osd-test

qa/standalone: Fix test_activate_osd() test in ceph-helpers.sh

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #45553 from wxypro/doc-update
Neha Ojha [Fri, 25 Mar 2022 18:06:14 +0000 (11:06 -0700)]
Merge pull request #45553 from wxypro/doc-update

doc/mgr/prometheus.rst: fix spelling error

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #45575 from wxypro/options-fix
Neha Ojha [Fri, 25 Mar 2022 18:00:19 +0000 (11:00 -0700)]
Merge pull request #45575 from wxypro/options-fix

common/options: fix typos: smarctl -> smartctl

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44699 from ivancich/wip-bucket-index-timeout-config
J. Eric Ivancich [Fri, 25 Mar 2022 17:16:39 +0000 (13:16 -0400)]
Merge pull request #44699 from ivancich/wip-bucket-index-timeout-config

core,rgw: allow configuration of bi tx timeout; add instrumentation

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #45522 from sseshasa/wip-improve-mclock-docs
Neha Ojha [Fri, 25 Mar 2022 16:46:41 +0000 (09:46 -0700)]
Merge pull request #45522 from sseshasa/wip-improve-mclock-docs

Doc: Improve mclock config reference documentation & update PendingReleaseNotes.

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoqa/standalone: Fix test_activate_osd() test in ceph-helpers.sh 45651/head
Sridhar Seshasayee [Fri, 25 Mar 2022 16:40:31 +0000 (22:10 +0530)]
qa/standalone: Fix test_activate_osd() test in ceph-helpers.sh

Modify test_activate_osd() to get the type of scheduler in use and then
verify the value of osd_max_backfills. This is because mclock scheduler
overrides this option to 1000 upon OSD initialization.

The test earlier used to pass because the OSD daemon was killed but not
marked down and upon being brought up, the wait for OSD up check was
passing quickly. But the OSD still didn't have the latest config values.

But now upon killing the OSD, the osd_fast_shutdown sequence notifies the
mon (see PR: https://github.com/ceph/ceph/pull/44807) and is marked down
and dead. Upon bringing it up, the wait for OSD up check takes a longer
time and this is sufficient for the config values to be updated. This
results in the correct values being read from the config 'Values' map.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
3 years agoMerge pull request #44807 from NitzanMordhai/wip-nitzan-fast-shutdown-notify-mon
Yuri Weinstein [Fri, 25 Mar 2022 15:59:05 +0000 (08:59 -0700)]
Merge pull request #44807 from NitzanMordhai/wip-nitzan-fast-shutdown-notify-mon

osd/OSD: osd_fast_shutdown_notify_mon not quite right

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agocrimson/os: use fmt::format() instead of sstream 45649/head
Kefu Chai [Fri, 25 Mar 2022 15:02:59 +0000 (23:02 +0800)]
crimson/os: use fmt::format() instead of sstream

for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #45309 from caisan/modify_without_source_segfault
J. Eric Ivancich [Fri, 25 Mar 2022 15:46:09 +0000 (11:46 -0400)]
Merge pull request #45309 from caisan/modify_without_source_segfault

radosgw-admin: fix segfault on pipe modify without source/dest zone specified

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #45573 from wxypro/cephfs-shell-typos
Venky Shankar [Fri, 25 Mar 2022 12:44:33 +0000 (18:14 +0530)]
Merge pull request #45573 from wxypro/cephfs-shell-typos

tools/cephfs-shell: fix typos in comments

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44895 from rkachach/fix_issue_54026
Adam King [Fri, 25 Mar 2022 12:35:47 +0000 (08:35 -0400)]
Merge pull request #44895 from rkachach/fix_issue_54026

mgr/cephadm: Adding support for natural sorting

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #45241 from rkachach/fix_issue_51072
Adam King [Fri, 25 Mar 2022 12:33:54 +0000 (08:33 -0400)]
Merge pull request #45241 from rkachach/fix_issue_51072

mgr/cephadm: fixing prometheus port handling

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #45314 from rkachach/fix_issue_54503
Adam King [Fri, 25 Mar 2022 12:32:01 +0000 (08:32 -0400)]
Merge pull request #45314 from rkachach/fix_issue_54503

mgr/cephadm: checking service name before removal

Reviewed-by: Adam King <adking@redhat.com>
3 years agoosd/scrub: restart snap trimming only after scrubbing is done 45640/head
Ronen Friedman [Fri, 25 Mar 2022 10:45:47 +0000 (10:45 +0000)]
osd/scrub: restart snap trimming only after scrubbing is done

Snap trimming that was postponed as the target PG was scrubbing
must be restarted at scrub completion.
PR #38111 moved trimming restart to just before the scrub fully
terminated. The current PR fixes that.

Trimming is also restarted in those cases where scrub was
queued but aborted immediately.

Fixes: https://tracker.ceph.com/issues/52026
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #45601 from idryomov/wip-diff-iterate-striping-fix
Ilya Dryomov [Fri, 25 Mar 2022 08:45:26 +0000 (09:45 +0100)]
Merge pull request #45601 from idryomov/wip-diff-iterate-striping-fix

librbd: make diff-iterate in fast-diff mode sort and merge reported extents

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
3 years agoMerge pull request #45513 from tchaikov/wip-cxx20-fixes-mon
Kefu Chai [Fri, 25 Mar 2022 04:24:24 +0000 (12:24 +0800)]
Merge pull request #45513 from tchaikov/wip-cxx20-fixes-mon

mgr,mon,test: C++20 fixes

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #45386 from cyx1231st/wip-crimson-epm-split-hot-cold
Samuel Just [Fri, 25 Mar 2022 03:46:02 +0000 (20:46 -0700)]
Merge pull request #45386 from cyx1231st/wip-crimson-epm-split-hot-cold

crimson/os/seastore: reuse RecordSubmitter for SegmentedJournal and EPM::Writer

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agorgw: bucket index transaction instrumentation clean-ups 44699/head
J. Eric Ivancich [Thu, 17 Mar 2022 21:05:10 +0000 (17:05 -0400)]
rgw: bucket index transaction instrumentation clean-ups

Add a series of clean-ups to the instrumentation code. Keep this as a
separate commit so it will be easier to reconcile other code streams.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agorgw: additional configurable CLS instrumentation on bucket index TXs
J. Eric Ivancich [Wed, 9 Feb 2022 19:37:56 +0000 (14:37 -0500)]
rgw: additional configurable CLS instrumentation on bucket index TXs

This supplements an earlier commit to add additional instrumentation
on bucket index transactions on the CLS side.

The instrumentation is triggered by setting the configuration option
rgw_bucket_index_transaction_instrumentation in the [global] section.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoMerge pull request #45115 from mchangir/mgr-snap_schedule-restart-old-schedules-on...
Venky Shankar [Fri, 25 Mar 2022 01:54:05 +0000 (07:24 +0530)]
Merge pull request #45115 from mchangir/mgr-snap_schedule-restart-old-schedules-on-startup

mgr/snap_schedule: restart old schedules

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #45399 from adk3798/no-firewall
Adam King [Thu, 24 Mar 2022 19:21:32 +0000 (15:21 -0400)]
Merge pull request #45399 from adk3798/no-firewall

cephadm: respect --skip-firewalld flag

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #45401 from adk3798/legacy-config
Adam King [Thu, 24 Mar 2022 19:20:32 +0000 (15:20 -0400)]
Merge pull request #45401 from adk3798/legacy-config

cephadm: verify config file exists when inferring it

Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #45527 from adk3798/eca-osd-allowed
Adam King [Thu, 24 Mar 2022 19:19:14 +0000 (15:19 -0400)]
Merge pull request #45527 from adk3798/eca-osd-allowed

python-common/drive_group: add extra_container_args to supported features

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #45250 from ifed01/wip-ifed-get-bluest-extents-cleanup
Yuri Weinstein [Thu, 24 Mar 2022 16:49:46 +0000 (09:49 -0700)]
Merge pull request #45250 from ifed01/wip-ifed-get-bluest-extents-cleanup

os/bluestore: refactor bluefs get_block_extents interface

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agorgw: configurable instrumentation on bucket index transactions
J. Eric Ivancich [Fri, 21 Jan 2022 20:30:45 +0000 (15:30 -0500)]
rgw: configurable instrumentation on bucket index transactions

In order to better understand corner cases with bucket index
operations, extra instrumentation is now added and controlled by a
boolean configuration variable
("rgw_bucket_index_transaction_instrumentation").

When set to true, there is extra logging during all CLS operations
involving bucket index transactions. Additionally, all these log
entries are tagged with "BITX" to make them easier to find in the
logs. This is preferable to setting all OSD logging at a high level
due to the log size issues.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agorgw: make bucket index pending op expiration configureable
J. Eric Ivancich [Thu, 20 Jan 2022 15:57:32 +0000 (10:57 -0500)]
rgw: make bucket index pending op expiration configureable

Bucket index operations are transactional with data object
manipulation. The operation is prepared by adding a pending operation
record. And when the data object side is complete, the bucket index
operation is committed.

If it fails to be committed, later bucket listings will compare the
pending ops with the current data object state and see whether it
completed or not and then either commit or expire the op. The time
span for expiration is currently hard-coded as 120 seconds (unless
overridden in the bucket header, which can happen during "bucket
check").

This commit allows that expiration time to be configured.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoosd: add new CLS call to retrieve global configuration
J. Eric Ivancich [Thu, 20 Jan 2022 15:56:49 +0000 (10:56 -0500)]
osd: add new CLS call to retrieve global configuration

Currently there is no easy way to gain access to global configuration
from CLS (objclass) code. This adds a new call to the CLS interface
that returns a "const ConfigProxy&" from which configuration can be
accessed.

NOTE: Working code to do provide this functionality in crimson is not
provided.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoMerge pull request #45393 from rzarzynski/wip-crimson-fix-throw-in-plugins
Kefu Chai [Thu, 24 Mar 2022 13:47:24 +0000 (21:47 +0800)]
Merge pull request #45393 from rzarzynski/wip-crimson-fix-throw-in-plugins

build, crimson/osd: do not let Seastar to interfere with ELF's program headers

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoqa: test snap_schedule with mgr restart 45115/head
Milind Changire [Thu, 24 Feb 2022 06:20:18 +0000 (11:50 +0530)]
qa: test snap_schedule with mgr restart

Scheduled snaps should follow the created schedule even across mgr
restart.

Signed-off-by: Milind Changire <mchangir@redhat.com>
3 years agomgr/snap_schedule: restart old schedules
Milind Changire [Mon, 28 Feb 2022 06:26:09 +0000 (11:56 +0530)]
mgr/snap_schedule: restart old schedules

Old schedules were not picked up from database when mgr was restarted.
Restart old schedules on mgr restart.

Fixes: https://tracker.ceph.com/issues/54052
Signed-off-by: Milind Changire <mchangir@redhat.com>
3 years agomgr/util: add function to list all fs names
Milind Changire [Mon, 28 Feb 2022 06:22:26 +0000 (11:52 +0530)]
mgr/util: add function to list all fs names

Signed-off-by: Milind Changire <mchangir@redhat.com>
3 years agoPendingReleaseNotes: Add mclock config reference link to an existing note 45522/head
Sridhar Seshasayee [Fri, 18 Mar 2022 14:55:25 +0000 (20:25 +0530)]
PendingReleaseNotes: Add mclock config reference link to an existing note

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
3 years agodoc: Improvements to mClock configuration reference documentation
Sridhar Seshasayee [Fri, 18 Mar 2022 07:43:52 +0000 (13:13 +0530)]
doc: Improvements to mClock configuration reference documentation

Improve the documentation around.
 - mclock client types.
 - Describe in greater detail about mclock config profiles.
 - Add notes about manually benchmarking OSDs and tuning bluestore throttle
   parameters.
 - Include a couple of missing mclock configuration options.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
3 years agomgr/cephadm: fixing natsort dependencies on debian 44895/head
Redouane Kachach [Thu, 17 Mar 2022 08:49:26 +0000 (09:49 +0100)]
mgr/cephadm: fixing natsort dependencies on debian

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
3 years agomgr/cephadm: Adding support for natural sorting
Redouane Kachach [Fri, 4 Feb 2022 11:22:50 +0000 (12:22 +0100)]
mgr/cephadm: Adding support for natural sorting
Fixes: https://tracker.ceph.com/issues/54026
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #45472 from vshankar/revert-45307
Venky Shankar [Thu, 24 Mar 2022 06:39:50 +0000 (12:09 +0530)]
Merge pull request #45472 from vshankar/revert-45307

Revert "mds: kill session when mds do ms_handle_remote_reset"

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoRevert "mds: kill session when mds do ms_handle_remote_reset" 45472/head
Venky Shankar [Thu, 17 Mar 2022 04:36:38 +0000 (10:06 +0530)]
Revert "mds: kill session when mds do ms_handle_remote_reset"

This reverts commit 3651deb4e0b0c102adcaddce79ee4e053f033418.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #45340 from benhanokh/disable_ncb_rotational
Neha Ojha [Wed, 23 Mar 2022 21:49:23 +0000 (14:49 -0700)]
Merge pull request #45340 from benhanokh/disable_ncb_rotational

os/bluestore: Disable NCB functionality on rotational drives

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agobuild, crimson/osd: do not let Seastar to interfere with ELF's program headers. 45393/head
Radosław Zarzyński [Tue, 15 Mar 2022 14:33:41 +0000 (15:33 +0100)]
build, crimson/osd: do not let Seastar to interfere with ELF's program headers.

For the sake of avoiding locking on the `__cxa_throw` paths, Seastar
hijacks `dl_iterate_phdr` of the dynamic linker. Unfortunately, this
has a nasty side effect: it makes impossible to catch an exception in
in a plugin (a DSO loaded via the `dlopen()` machinery).

For mote details please consult:
  * https://gist.github.com/rzarzynski/3abe9ed6b50cfa1893d34988e1628bfc,
  * `seastar/src/core/exception_hacks.cc`.

This patch deals with the problem by simply disabling the problematic
workaround which could be iatrogenic too. If that would be the case,
we can consider:

  * preloading all our Ceph Classes before reaching `smp::configure()`,
  * statically linking them.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
3 years agoMerge pull request #45551 from liu-chunmei/crimson-string-view
Samuel Just [Wed, 23 Mar 2022 20:49:01 +0000 (13:49 -0700)]
Merge pull request #45551 from liu-chunmei/crimson-string-view

crimson: keep string alive during string_view lifetime

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44696 from cbodley/wip-arrow-submodule-ext
Casey Bodley [Wed, 23 Mar 2022 19:43:38 +0000 (15:43 -0400)]
Merge pull request #44696 from cbodley/wip-arrow-submodule-ext

cmake: add submodule for Apache Arrow at v6.0.1

Reviewed-by: Gal Salomon <gsalomon@redhat.com>
3 years agoMerge pull request #45550 from liu-chunmei/crimson-fix-read-error-return
Samuel Just [Wed, 23 Mar 2022 19:02:27 +0000 (12:02 -0700)]
Merge pull request #45550 from liu-chunmei/crimson-fix-read-error-return

crimson: return read error code in MOSDOpReply

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #45246 from aclamk/wip-bluefs-sync-compaction-fix
Yuri Weinstein [Wed, 23 Mar 2022 17:18:31 +0000 (10:18 -0700)]
Merge pull request #45246 from aclamk/wip-bluefs-sync-compaction-fix

Fix BlueFS sync compaction

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agoMerge pull request #45230 from ljflores/wip-github-actions-stale
Laura Flores [Wed, 23 Mar 2022 16:37:38 +0000 (11:37 -0500)]
Merge pull request #45230 from ljflores/wip-github-actions-stale

.github/workflows: replace probot-stale with equivalent github action

3 years agoMerge pull request #45466 from neha-ojha/wip-54592
Yuri Weinstein [Wed, 23 Mar 2022 15:45:15 +0000 (08:45 -0700)]
Merge pull request #45466 from neha-ojha/wip-54592

osd/PrimaryLogPG.cc: CEPH_OSD_OP_OMAPRMKEYRANGE should mark omap dirty

Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #45366 from NitzanMordhai/wip-nitzan-test-librados-watchnotify...
Yuri Weinstein [Wed, 23 Mar 2022 15:35:28 +0000 (08:35 -0700)]
Merge pull request #45366 from NitzanMordhai/wip-nitzan-test-librados-watchnotify-watch2delete

tests: ceph_test_rados_api_watch_notify: watch2Delete reconnect

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
3 years agolibrbd: make diff-iterate in fast-diff mode sort and merge reported extents 45601/head
Ilya Dryomov [Sun, 20 Mar 2022 11:10:52 +0000 (12:10 +0100)]
librbd: make diff-iterate in fast-diff mode sort and merge reported extents

Various users, the most notable example being the QEMU driver, assume
that extents are reported in image offset order.

Fixes: https://tracker.ceph.com/issues/53885
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #45468 from idryomov/wip-pool-reverse-lookup-osdmap
Yuri Weinstein [Wed, 23 Mar 2022 14:45:42 +0000 (07:45 -0700)]
Merge pull request #45468 from idryomov/wip-pool-reverse-lookup-osdmap

librados: check latest osdmap on ENOENT in pool_reverse_lookup()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoosd/OSD: osd_fast_shutdown_notify_mon not quite right 44807/head
Nitzan Mordechai [Thu, 27 Jan 2022 13:13:28 +0000 (15:13 +0200)]
osd/OSD: osd_fast_shutdown_notify_mon not quite right

When osd_fast_shutdown and osd_fast_shutdown_notify_mon set as true, OSD marked as Down
it should be marked as Dead,

Fixed: https://tracker.ceph.com/issues/53327

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
nd

nd

3 years agomgr/dashboard: Remove padding in search highlighted text 45539/head
Sarthak0702 [Mon, 21 Mar 2022 18:29:08 +0000 (23:59 +0530)]
mgr/dashboard: Remove padding in search highlighted text

Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>
3 years agoMerge pull request #45429 from votdev/issue_54591_language_dropdown
Ernesto Puerta [Wed, 23 Mar 2022 11:50:41 +0000 (12:50 +0100)]
Merge pull request #45429 from votdev/issue_54591_language_dropdown

mgr/dashboard: Language dropdown box is partly hidden on login page

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #45577 from wxypro/mgr-stat-fix
Jos Collin [Wed, 23 Mar 2022 11:06:42 +0000 (16:36 +0530)]
Merge pull request #45577 from wxypro/mgr-stat-fix

mgr/stats: fix a typo in comment

Reviewed-by: Jos Collin <jcollin@redhat.com>
3 years agomgr/cephadm: fixing prometheus port handling 45241/head
Adam King [Wed, 2 Mar 2022 05:23:52 +0000 (00:23 -0500)]
mgr/cephadm: fixing prometheus port handling
Fixes: https://tracker.ceph.com/issues/51072
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #44579 from asm0deuz/fix_pids_limits_bug_52898
Ilya Dryomov [Wed, 23 Mar 2022 07:44:13 +0000 (08:44 +0100)]
Merge pull request #44579 from asm0deuz/fix_pids_limits_bug_52898

cephadm: Remove containers pids-limit

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agomgr/stats: fix an typo in comment 45577/head
wangxinyu [Wed, 23 Mar 2022 07:31:01 +0000 (15:31 +0800)]
mgr/stats: fix an typo in comment

fix an typo in comment

Signed-off-by: wangxinyu <wangxinyu@inspur.com>
3 years agomgr/dashboard: extend daemon actions to host details 44014/head
Nizamudeen A [Mon, 28 Feb 2022 20:23:19 +0000 (01:53 +0530)]
mgr/dashboard: extend daemon actions to host details

The daemon actions are only available in the service details section but
not on the host details. This takes care of that.

Fixes: https://tracker.ceph.com/issues/54559
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agocommon/options: fix typos: smarctl -> smartctl 45575/head
wangxinyu [Wed, 23 Mar 2022 06:34:14 +0000 (14:34 +0800)]
common/options: fix typos: smarctl -> smartctl

fix typos: smarctl -> smartctl

Signed-off-by: wangxinyu <wangxinyu@inspur.com>
3 years agomgr/dashboard: Hide hostname column of daemon table in host details
Nizamudeen A [Thu, 18 Nov 2021 20:31:36 +0000 (02:01 +0530)]
mgr/dashboard: Hide hostname column of daemon table in host details

Fixes: https://tracker.ceph.com/issues/53355
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agocrimson: keep string alive during string_view lifetime 45551/head
Chunmei Liu [Wed, 23 Mar 2022 05:21:24 +0000 (22:21 -0700)]
crimson: keep string alive during string_view lifetime

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agocrimson:return read error code in MOSDOpReply 45550/head
Chunmei Liu [Mon, 21 Mar 2022 06:14:17 +0000 (23:14 -0700)]
crimson:return read error code in MOSDOpReply

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agotools/cephfs-shell: fix typos in comments 45573/head
wangxinyu [Wed, 23 Mar 2022 02:15:15 +0000 (10:15 +0800)]
tools/cephfs-shell: fix typos in comments

fix typos in comments

Signed-off-by: wangxinyu <wangxinyu@inspur.com>
3 years agoMerge pull request #45512 from zdover23/wip-doc-2022-03-18-master-to-main
Josh Durgin [Tue, 22 Mar 2022 23:38:40 +0000 (16:38 -0700)]
Merge pull request #45512 from zdover23/wip-doc-2022-03-18-master-to-main

ceph/admin: s/master/main

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agocephadm: verify config file exists when inferring it 45401/head
Adam King [Tue, 15 Mar 2022 20:41:15 +0000 (16:41 -0400)]
cephadm: verify config file exists when inferring it

Fixes: https://tracker.ceph.com/issues/54571
Signed-off-by: Adam King <adking@redhat.com>
3 years agocephadm: respect --skip-firewalld flag 45399/head
Adam King [Tue, 15 Mar 2022 18:33:52 +0000 (14:33 -0400)]
cephadm: respect --skip-firewalld flag

Fixes: https://tracker.ceph.com/issues/54137
Signed-off-by: Adam King <adking@redhat.com>
3 years agomgr/cephadm: Reschedule nfs daemons from offline hosts 44343/head
Adam King [Tue, 22 Mar 2022 22:57:21 +0000 (18:57 -0400)]
mgr/cephadm: Reschedule nfs daemons from offline hosts

In order to improve nfs availability, if there are other
hosts we can place an nfs daemon on or if there is a host
with a lower rank nfs daemon when a higher rank one is on
an offline host, we should reschedule the nfs daemons

Signed-off-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #45286 from adk3798/ssh-offline
Adam King [Tue, 22 Mar 2022 22:00:22 +0000 (18:00 -0400)]
Merge pull request #45286 from adk3798/ssh-offline

mgr/cephadm: add keep-alive requests to ssh connections

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #45333 from s0nea/config-fqdn
Adam King [Tue, 22 Mar 2022 21:58:28 +0000 (17:58 -0400)]
Merge pull request #45333 from s0nea/config-fqdn

mgr/cephadm: try to get FQDN for configuration files

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
3 years agoqa/suites/orch/cephadm: restrict test_iscsi_pids_limit to CentOS 44579/head
Ilya Dryomov [Tue, 22 Mar 2022 10:36:18 +0000 (11:36 +0100)]
qa/suites/orch/cephadm: restrict test_iscsi_pids_limit to CentOS

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agocephadm: remove containers pids-limit
Teoman ONAY [Thu, 11 Nov 2021 15:05:49 +0000 (15:05 +0000)]
cephadm: remove containers pids-limit

The default pids-limit (docker 4096/podman 2048) prevent some
customization from working (http threads on RGW) or limits the number
of luns per iscsi target.

Fixes: https://tracker.ceph.com/issues/52898
Signed-off-by: Teoman ONAY <tonay@redhat.com>
3 years agoMerge pull request #45269 from kalaspuffar/table_fix
Ernesto Puerta [Tue, 22 Mar 2022 18:35:43 +0000 (19:35 +0100)]
Merge pull request #45269 from kalaspuffar/table_fix

mgr/dashboard: Table columns hiding fix

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: kalaspuffar <NOT@FOUND>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
3 years agoMerge pull request #45510 from ceph/fix-github_workflow-master
Ernesto Puerta [Tue, 22 Mar 2022 17:35:50 +0000 (18:35 +0100)]
Merge pull request #45510 from ceph/fix-github_workflow-master

.github: continue on error

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #44616 from dang/wip-dang-zipper-objctx
Daniel Gryniewicz [Tue, 22 Mar 2022 16:17:24 +0000 (12:17 -0400)]
Merge pull request #44616 from dang/wip-dang-zipper-objctx

RGW - Zipper - remove RGWObjectCtx from SAL API

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
3 years agotest: Remove unused variable 45513/head
Adam C. Emerson [Tue, 8 Mar 2022 03:15:05 +0000 (22:15 -0500)]
test: Remove unused variable

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agotest: Pragma to silence infinite recursion warning for GCC
Adam C. Emerson [Tue, 8 Mar 2022 03:12:20 +0000 (22:12 -0500)]
test: Pragma to silence infinite recursion warning for GCC

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agotest: Initialize possibly uninitialized buffer
Adam C. Emerson [Tue, 8 Mar 2022 03:13:50 +0000 (22:13 -0500)]
test: Initialize possibly uninitialized buffer

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #45533 from rhcs-dashboard/update-grafana-version
Ernesto Puerta [Tue, 22 Mar 2022 15:27:25 +0000 (16:27 +0100)]
Merge pull request #45533 from rhcs-dashboard/update-grafana-version

mgr/dashboard/monitoring: update grafana version

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agomgr: use constexpr string_view as input to format()
Casey Bodley [Mon, 14 Feb 2022 22:58:05 +0000 (17:58 -0500)]
mgr: use constexpr string_view as input to format()

resolves a c++20 compilation error with clang13:

ceph/src/mgr/Mgr.cc:602:42: error: call to consteval function 'fmt::basic_format_string<char, const std::basic_string<char> &>::basic_format_string<const char *, 0>' is not a constant expression
    monc->start_mon_command({fmt::format(cmd, name)}, {},
                                         ^
ceph/src/fmt/include/fmt/core.h:2839:56: note: read of non-constexpr variable 'cmd' is not allowed in a constant expression
  FMT_CONSTEVAL basic_format_string(const S& s) : str_(s) {
                                                       ^
ceph/src/mgr/Mgr.cc:602:42: note: in call to 'basic_format_string(cmd)'
    monc->start_mon_command({fmt::format(cmd, name)}, {},
                                         ^
ceph/src/mgr/Mgr.cc:601:17: note: declared here
    const char* cmd = R"({{"prefix": "mon metadata", "id": "{}"}})";
                ^

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agomon: Replace deprecated use of format_to
Adam C. Emerson [Mon, 7 Mar 2022 23:54:30 +0000 (18:54 -0500)]
mon: Replace deprecated use of format_to

The non-deprecated version takes an explicit OutputIterator.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>