mgr/dashboard: Creating and editing Prometheus AlertManager silences is buggy

When creating a new monitoring silence the form is pre-filled with the wrong alert data. It is always used the alert data from the very first object in the list of the API response but not the specified alert identified by the 'fingerprint' property.

The same problem applies to editing silences. The selected silence is not edited, it's always the first one in the list returned API response but not that with the specified 'id' property.

The main problem of the origin implementation is that the Prometheus Alertmanager API endpoints /api/v1/[alerts/silences] do not support querying. To fix that, filtering is done in the frontend.

Fixes: https://tracker.ceph.com/issues/55578
Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #45732 from mchangir/mgr-snap_schedule-validate-fs-for-all-commands

mgr/snap_schedule: validate fs name argument

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #46064 from liu-chunmei/crimson-pool-quota

Crimson pool quota

Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/osd: check full

need check if pool exceeds its quota

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

crimson/errorator: change errorator template to int

need define EDQUOT which is not included in std::errc.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

Merge pull request #46170 from elacunza/patch-1

doc/rados/operations: Add missing required parameters to stretch-mode CRUSH rule example

Merge pull request #46108 from rhcs-dashboard/fix-ingress-ssl-cert-validation

mgr/dashboard: fix ssl cert validation for ingress service creation

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>

doc/rados/operations: Add missing required parameters to stretch-mode CRUSH rule example

Rule example is missing min_size and max_size, both are required.

Signed-off-by: Eneko Lacunza <elacunza@binovo.es>

Merge pull request #45935 from dparmar18/cephfs-shell-doc-update

doc/man/cephfs-shell.rst: add use of exclamation mark with cmds

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #46097 from tchaikov/wip-crimson-cleanups

crimson/osd/main: s/values/config_values/

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #45788 from rzarzynski/wip-crimson-op-tracking-2

crimson: bring the core of op tracking

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #46006 from phlogistonjohn/jjm-nfs-cleanups-pt4

mgr/nfs: minor organizational cleanups

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #46035 from rkachach/fix_issue_52906

mgr/cephadm: adding logic to close ports when removing a daemon

Reviewed-by: Adam King <adking@redhat.com>

crimson/osd: drop legacy base classes for pipeline stages

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: drop the old blocking infrastructure

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: strip blokcing_future from OperationT

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate OperationThrottler to new tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: crimson/osd: drop blocking_future from PGActivationBlocker

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: crimson/osd: drop blocking_future from PGMap

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: drop blocking_future from OSDMapGate

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson: bring the WaitBarrier tracking

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

Merge pull request #46033 from iqbalredkhan/quota2

rgw: Refactoring Quota Management

crimson: move PipelineStageIT::enter() dispatch to compile-time

The optimization isn't the goal (but rather a side effect). The
reason behind this change is to let pipeline stages define exit
barriers incorporating `OpT`-dependant `Triggers` to track blocking
that happens on the barriers.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/os: add junction between OSD's ops and Seastore's OrderingHandle.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate AggregateBlocker-related ops to new tracking infra

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: bring AggregateBlockingEvent.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate PeeringEvent to new tracking infra, part 2

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: add BlockingEvent-aware variant of OSD::get_or_create_pg

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate InternalClientRequest to new tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate RecoverySubRequest to new tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate RepRequest to new tracking infra

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate PGAdvanceMap to new tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: reduce unnecessary indentation level in PGAdvanceMap::start()

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate PeeringEvent to new tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate BackgroundRecovery to new tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate BackfillRecoveryPipeline to new tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: CompoundPeeringRequest tracks its start and completion too

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: migrate CompoundPeeringRequest into new tracking infra

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: move SubOpBlocker from .cc to header

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: PGActivationBlocker does support new tracking infra

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: dissect PG::WaitForActiveBlocker into PGActivationBlocker

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: PGMap blocker does support new tracking infra

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: make PhaseOperationT able to deal with interruptors

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: pg_map.h doesn't pull pg.h anymore

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: convert entire ClientRequest to the new infra

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: slightly optimize OperationRegistryT::do_register()

There is no need to call the virtual op::get_type() twice.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: fix an assertion failure in Formatter when dumping ops

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: implement dump_ops_in_flight

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: track start and completion of ClientRequest

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: bring boilerplate for LTTng-based external tracking backend

At the moment it's mostly for verification & demonstration purposes.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: drop forward declaration of OSDMap osd.h

Having it doesn't make sense as we already include the header.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: add registry of external handlers of tracking events

This commit intentionally fails the build. It does that to verify
the static assertion on per-op-type lookup of event registry.

The concrete assertion is the one about `ClientRequest` as we
already moved two of its blocker into the new op tracking infra.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: switch one OSDMapGate of ClientRequest to new blocking infra

This time the demo of `BlockerT::BlockingEvent::TriggerI` which
is supposed to handle situations where:

1) `BlockerT` is separated from `TrackableOperationT` by many
intermediaries while
2) we don't want to templatize them all.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: switch a stage of ClientRequest to new blocking infra

This is a debut of the new blocking & tracking infrastructure
using the type-aware `BlockerT::BlockingEvent::Trigger<T>`.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: introduce PhasedOperationT to deduplicate PipelineHandles

This new class in the hierarchy will be handy when it will come to
introduce helpers for deailing with entering a pipeline stage.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: switch all OSD operations to TrackableOperationT

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: get rid of unnecessary private in ClientRequest

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: switch all ClientRequest-related pipeline stages to the new infra

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: pipeline stage classes can be bases for CRTP now

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: pipeline stage classes derive from BlockerT now

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: document OperationThrottler's behavior towards op's blocker list.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: simplify OperationThrottler::with_throttle()

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: move with_blocking_future from Operation to OperationT.

Buildability of this commit proves all users of `with_blocking_future()`
have the concrete operation type which is necessary on the the way
to the compile-time defined op's blocker registry.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/os/seastore: migrate OrderingHandle away from blocking_future

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: OperationThrottler derives from BlockerT instead of Blocker.

One another step closer. See the previous' commit description.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: make OperationThrottler aware about exact type of operation

This is a step towards making op's blocker registry static and
compile-time checked.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: make the OperationThrottler::with_throttle private

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/osd: add types PG and OSD-hosted OSDMapGate instances.

`ClientRequest` is going to hold all tracking events as a `std::tuple`
instance and access them through the type-related variant of `std::get`.
As two instances of `OSDMapGate` are used there, a need to differentiate
at the type level arises.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

crimson/common: add basic infrastructure for op tracking

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

rgw: user_quota and bucket_quota are defined under RGWQuota

struct RGWQuota {
      RGWQuotaInfo user_quota;
      RGWQuotaInfo bucket_quota;
};

Signed-off-by: Iqbal Khan <iqkhan@redhat.com>

Merge pull request #46080 from cbodley/wip-55420

cmake/rgw: add missing dependency on Arrow::Arrow

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Gal Salomon <gsalomon@redhat.com>

Merge pull request #45341 from idryomov/wip-use-system-libpmem-on-c9s

rpm: use system libpmem on Centos 9 Stream

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #46073 from idryomov/wip-rbd-mirror-exit-code

rbd-mirror,immutable-object-cache: exit code is inverted

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #46103 from tchaikov/cmake-alloc-cleanup

cmake: re-enable TCMalloc and allocator related cleanups

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #45845 from SUSE/wip-fix-55237

ceph.spec.in: openSUSE: require gcc11-c++, disable parquet

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

crimson/common: abstract from staticness of BlockerT::type_name.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

Merge pull request #37655 from rishabh-d-dave/vr-run-multiple-cmds

vstart_runner: accepts multiple commands as str too

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #45473 from neesingh-rh/fix_50470

cephfs-top: Multiple filesystem support

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #45776 from neesingh-rh/fix_48863

cephfs-shell: chmod should be allowed for changing all mode bits.

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #45974 from rishabh-d-dave/shell-unrecognized-cmds

cephfs-shell: exit with non-zero on getting unrecognized cmd

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #46135 from athanatos/sjust/wip-vstart-asok

vstart.sh: default CEPH_ASOK_DIR to out/

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #46137 from athanatos/sjust/wip-crimson-typos

crimson: misc typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #46134 from athanatos/sjust/wip-55326

crimson/common/format: remove ceph::coarse_real_clock format speciali…

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

crimson/common/format: remove ceph::coarse_real_clock format specialization

...
..., value=..., loc=...) at /usr/include/fmt/ostream.h:114
...

Introduced: e9784125241064709d25e9c64d16e1c72b4d7bed
Fixes: https://tracker.ceph.com/issues/55326
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #46128 from vumrao/wip-vumrao-quincy-release-note-update

docs/releases: update quincy release notes tracker 55383 known issue

mgr/cephadm: adding logic to close ports when removing a daemon
Fixes: https://tracker.ceph.com/issues/52906
Signed-off-by: Redouane Kachach <rkachach@redhat.com>

docs/releases: update quincy release notes tracker 55383 known issue

Signed-off-by: Vikhyat Umrao <vikhyat@redhat.com>

Merge pull request #46079 from ronen-fr/wip-rf-log-mock

common: make LogChannel mockable

Reviewed-by: Samuel Just <sjust@redhat.com>

cmake: link daemons against ${ALLOC_LIBS}

to enable them to use the specified allocators

Fixes: https://tracker.ceph.com/issues/55519
Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #46115 from dang/wip-dang-split-init

RGW - Split RGWRados initialization

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Soumya Koduri <skaduri@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>

Merge pull request #46066 from bluikko/patch-4

doc/cephadm/services: Add missing ceph command to orch apply commands

Merge pull request #46109 from bluikko/pgcalc_links

doc/rados: fix pgcalc links

Reviewed-by: Zac Dover <zac.dover@gmail.com>

vstart.sh: default CEPH_ASOK_DIR to out/

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/common/interruptible_future: fix typo

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/common/operation: fix comment formatting

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/admin/osd_admin: fix comment spacing

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #44494 from mdw-at-linuxbox/wip-master-mankey

rgw/crypt: sse-s3 changes

Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #45843 from ajarr/wip-mgr-nfs-output-message

mgr/nfs: clarify in the output message

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #46095 from aclamk/wip-aclamk-unbounded-wholespace-iterator

kv/RocksDBStore: Remove ability to bound WholeSpaceIterator

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>

RGW - Split RGWRados initialization

The inter-connectedness of RadosStore and RGWRados resulted in a
segfault during RGWRados::init_complete due to the rados pointer not
being set in RadosStore yet.

Split the calls to RGWRados::initialize and RGWRados::init_complete, so
that we can set up RadosStore between them, allowing the services
created in RGWRados::init_complete to access the RadosStore.

Fixes: https://tracker.ceph.com/issues/55512
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>