]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoosd/SnapMapper: fix pacific legacy key conversion and introduce test 46908/head
Manuel Lausch [Thu, 30 Jun 2022 12:29:53 +0000 (14:29 +0200)]
osd/SnapMapper: fix pacific legacy key conversion and introduce test

Octopus modified the SnapMapper key format from

  <LEGACY_MAPPING_PREFIX><snapid>_<shardid>_<hobject_t::to_str()>

to

  <MAPPING_PREFIX><pool>_<snapid>_<shardid>_<hobject_t::to_str()>

When this change was introduced, 94ebe0ea also introduced a conversion
with a crucial bug which essentially destroyed legacy keys by mapping them
to

  <MAPPING_PREFIX><poolid>_<snapid>_

without the object-unique suffix.  This commit fixes this conversion going
forward, but a fix for existing clusters still needs to be developed.

Fixes: https://tracker.ceph.com/issues/56147
Signed-off-by: Manuel Lausch <manuel.lausch@1und1.de>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
3 years agoMerge pull request #46436 from cyx1231st/wip-seastore-generational-cleanning
Samuel Just [Thu, 30 Jun 2022 00:16:38 +0000 (17:16 -0700)]
Merge pull request #46436 from cyx1231st/wip-seastore-generational-cleanning

crimson/os/seastore: implement generational GC

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #46843 from jsoref/spelling-docs
Josh Durgin [Wed, 29 Jun 2022 19:30:22 +0000 (12:30 -0700)]
Merge pull request #46843 from jsoref/spelling-docs

doc/releases: Fixes spelling

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
3 years agoMerge pull request #46881 from ivancich/wip-complete-op-spamming-log
Casey Bodley [Wed, 29 Jun 2022 18:38:00 +0000 (14:38 -0400)]
Merge pull request #46881 from ivancich/wip-complete-op-spamming-log

rgw: reduce logging level in rgw_bucket_complete_op

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
3 years agoMerge pull request #46880 from thinko/patch-1
Adam King [Wed, 29 Jun 2022 17:56:18 +0000 (13:56 -0400)]
Merge pull request #46880 from thinko/patch-1

doc/cephadm: osd: minor fixes in OSD config examples

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #46894 from zdover23/wip-doc-2022-06-29-doc-index-link-to-basic...
zdover23 [Wed, 29 Jun 2022 15:23:18 +0000 (01:23 +1000)]
Merge pull request #46894 from zdover23/wip-doc-2022-06-29-doc-index-link-to-basic-workflow

doc/index.rst: add link to Dev Guide basic workfl.

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/index.rst: add link to Dev Guide basic workfl. 46894/head
Zac Dover [Wed, 29 Jun 2022 12:57:13 +0000 (22:57 +1000)]
doc/index.rst: add link to Dev Guide basic workfl.

This PR adds a link to the "Basic Workflow" section of the
Developer Guide on the landing page of docs.ceph.com.

This PR is meant to improve the documentation for developers
new to Ceph and to guide them to instructions that will allow
them to become full-fledged contributors to the Ceph project
as quickly as possible.

The "Basic Workflow" page of the Developer Guide contains
information that answers almost all of the questions that I had
about contributing to the Ceph project when I was new to it,
and I am finally acting on my long-held conviction that the
"Basic Workflow" page of the Developer Guide should have a more
prominent position in the documentation suite than it has had.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #46864 from rzarzynski/wip-crimson-gcc11
Kefu Chai [Wed, 29 Jun 2022 11:50:44 +0000 (19:50 +0800)]
Merge pull request #46864 from rzarzynski/wip-crimson-gcc11

crimson: switch to GCC11

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson/os/seastore/segment_cleaner: increase avaliable ratio limit 46436/head
Yingxin Cheng [Fri, 24 Jun 2022 03:04:50 +0000 (11:04 +0800)]
crimson/os/seastore/segment_cleaner: increase avaliable ratio limit

Journal trimming may consume unexpected number of segments when the
available ratio limit is reached with user transactions blocked, causing
ceph_abort(). So increase the limit as a simple workaround.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: improve GC policies with modify-time
Yingxin Cheng [Fri, 24 Jun 2022 05:25:51 +0000 (13:25 +0800)]
crimson/os/seastore: improve GC policies with modify-time

* record_header_t to store the average modify time for dirty extents.
* Drop tracking rewrite-time.
* Drop the last-modify field in extent_info_t.
* Maintain modify-time during rewriting.
* Introduce 3 GC policies: greedy, benefit, and cost-benefit.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/segment_cleaner: improve log information
Yingxin Cheng [Fri, 24 Jun 2022 05:22:07 +0000 (13:22 +0800)]
crimson/os/seastore/segment_cleaner: improve log information

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: misc cleanups
Yingxin Cheng [Fri, 24 Jun 2022 04:02:25 +0000 (12:02 +0800)]
crimson/os/seastore: misc cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: implement generational GC
Yingxin Cheng [Fri, 27 May 2022 09:13:06 +0000 (17:13 +0800)]
crimson/os/seastore: implement generational GC

Place extents into the dedicated RecordSubmitter by their data-category
and reclaimed-count. Segments of different data-category or
reclaimed-count should have different locality in the access patterns,
which is the foundation to form a desired bimodal distribution of
segment utilizations, so that GC can be more efficient.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #46885 from myoungwon/wip-rename-seg-cleaner
Samuel Just [Wed, 29 Jun 2022 04:19:52 +0000 (21:19 -0700)]
Merge pull request #46885 from myoungwon/wip-rename-seg-cleaner

seastore: rename segment cleaner to async cleaner

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoseastore: rename segment cleaner to async cleaner 46885/head
myoungwon oh [Wed, 1 Jun 2022 12:55:27 +0000 (21:55 +0900)]
seastore: rename segment cleaner to async cleaner

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agorgw: reduce logging level in rgw_bucket_complete_op 46881/head
J. Eric Ivancich [Tue, 28 Jun 2022 13:52:49 +0000 (09:52 -0400)]
rgw: reduce logging level in rgw_bucket_complete_op

There are two instances where pedestrian logging happens at level 0
but should be at a much higher level, such as 20. Both are fixed.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agodoc/cephadm: osd: minor fixes in config examples 46880/head
Alex Handy [Tue, 28 Jun 2022 17:27:23 +0000 (10:27 -0700)]
doc/cephadm: osd: minor fixes in config examples

- Corrected drive counts (8 to 10) and rotational flag use (not consistent with HDD) in the "Multiple OSD specs for a single host" example
- Adjusted vendor names in "Multiple hosts with the same disk layout" for consistency of examples

Signed-off-by: Alex Handy <thinko@redhat.com>
3 years agoMerge pull request #46660 from pritha-srivastava/wip-rgw-user-policy-test-changes
Ali Maredia [Tue, 28 Jun 2022 16:04:02 +0000 (12:04 -0400)]
Merge pull request #46660 from pritha-srivastava/wip-rgw-user-policy-test-changes

Changes to integrate user-policy(iam) tests in teuthology.

Reviewed-by: Ali Maredia <amaredia@redhat.com>
3 years agoMerge pull request #46857 from zdover23/wip-doc-2022-06-27-pdonnelly-to-venky
zdover23 [Tue, 28 Jun 2022 13:58:39 +0000 (23:58 +1000)]
Merge pull request #46857 from zdover23/wip-doc-2022-06-27-pdonnelly-to-venky

doc/dev_guide: change CephFS lead to vshankar

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #46581 from linuxbox2/wip-admin-errortrans
Casey Bodley [Tue, 28 Jun 2022 13:32:58 +0000 (09:32 -0400)]
Merge pull request #46581 from linuxbox2/wip-admin-errortrans

rgw: return ENOENT for NO_SUCH_BUCKET in radosgw-admin bucket stats

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46846 from tchaikov/cmake-ccache
Kefu Chai [Tue, 28 Jun 2022 13:17:17 +0000 (21:17 +0800)]
Merge pull request #46846 from tchaikov/cmake-ccache

cmake: use CMAKE_<LANG>_COMPILER_LAUNCHER for configuring ccache

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46835 from CongMinYin/wip-install-pmdk
Kefu Chai [Tue, 28 Jun 2022 13:15:53 +0000 (21:15 +0800)]
Merge pull request #46835 from CongMinYin/wip-install-pmdk

install-deps: install pmdk libraries

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoceph.spec.in: use %enable_devtoolset11 to enable GTS-11 46864/head
Kefu Chai [Mon, 27 Jun 2022 13:18:57 +0000 (21:18 +0800)]
ceph.spec.in: use %enable_devtoolset11 to enable GTS-11

%enable_devtoolset11 redefines %___build_pre by appending
`source scl_source enable gcc-toolset-11` to it. `___build_pre` should
be able to populate this setting to both %build and %install. and hence
address the FTBFS where we need to use the tool chain from GTS-11.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 49459d92fec553246b35719e9defc0ad7582f701)

3 years agoceph.spec.in: enable toolset 11 also in install
Radoslaw Zarzynski [Mon, 27 Jun 2022 19:38:03 +0000 (19:38 +0000)]
ceph.spec.in: enable toolset 11 also in install

This can be surprising but we actually compile things during
the `install` stage of `rpm-build`. The example is the pybind's
`setup.py` which builds `rados_dummy.c`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoceph.spec.in: move and undef _annotated_build only for rhels.
Radoslaw Zarzynski [Tue, 28 Jun 2022 01:15:15 +0000 (01:15 +0000)]
ceph.spec.in: move and undef _annotated_build only for rhels.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoceph.spec.in: use gcc-toolset-11 for building crimson
Radosław Zarzyński [Tue, 31 May 2022 10:21:41 +0000 (12:21 +0200)]
ceph.spec.in: use gcc-toolset-11 for building crimson

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
3 years agodoc/dev_guide: change CephFS lead to vshankar 46857/head
Zac Dover [Mon, 27 Jun 2022 13:02:14 +0000 (23:02 +1000)]
doc/dev_guide: change CephFS lead to vshankar

This makes an overdue change. Venky Shankar is the
CephFS lead, and has been for a while.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #46754 from ideepika/wip-opentelemetry-submodule
Deepika Upadhyay [Tue, 28 Jun 2022 09:36:48 +0000 (15:06 +0530)]
Merge pull request #46754 from ideepika/wip-opentelemetry-submodule

.gitmodules: add opentelemetry-cpp as a submodule

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46829 from soumyakoduri/wip-skoduri-dbstore-fix
Soumya Koduri [Tue, 28 Jun 2022 05:47:58 +0000 (11:17 +0530)]
Merge pull request #46829 from soumyakoduri/wip-skoduri-dbstore-fix

rgw/dbstore: Fix crash in delete_stale_objs

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #46673 from ljflores/wip-mempool-documentation
Laura Flores [Mon, 27 Jun 2022 19:01:58 +0000 (14:01 -0500)]
Merge pull request #46673 from ljflores/wip-mempool-documentation

doc/dev: improve wording and grammar of mempool page

3 years agoMerge pull request #46756 from tobias-urdin/mgr-influx-pool-name-keyerror
Yuri Weinstein [Mon, 27 Jun 2022 18:27:17 +0000 (11:27 -0700)]
Merge pull request #46756 from tobias-urdin/mgr-influx-pool-name-keyerror

mgr: influx: catch KeyError when looking up pool name

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #46732 from rzarzynski/wip-55355
Yuri Weinstein [Mon, 27 Jun 2022 18:26:34 +0000 (11:26 -0700)]
Merge pull request #46732 from rzarzynski/wip-55355

msg: fix deadlock when handling existing but closed v2 connection

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #46628 from tchaikov/wip-msg-cleanup
Yuri Weinstein [Mon, 27 Jun 2022 18:25:42 +0000 (11:25 -0700)]
Merge pull request #46628 from tchaikov/wip-msg-cleanup

msg, mount: cleanups

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
3 years agoMerge pull request #46571 from NitzanMordhai/wip-nitzan-add-pg-log-output
Yuri Weinstein [Mon, 27 Jun 2022 18:24:36 +0000 (11:24 -0700)]
Merge pull request #46571 from NitzanMordhai/wip-nitzan-add-pg-log-output

osd: add option to dump pg log to pg command

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocmake: rename a series of pmem libraries to pmdk 46835/head
Yin Congmin [Sat, 25 Jun 2022 09:43:52 +0000 (17:43 +0800)]
cmake: rename a series of pmem libraries to pmdk

At first, libpmem was the only library. Later, pmem related libraries
such as libpmemobj and libpmem2 were gradually added. These libraries
were also integrated into one named pmdk. So rename to pmdk.

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
3 years agodoc/dev: improve wording and grammar of mempool page 46673/head
Laura Flores [Tue, 14 Jun 2022 17:35:04 +0000 (12:35 -0500)]
doc/dev: improve wording and grammar of mempool page

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agodoc/releases: Fix many spelling errors 46843/head
Josh Soref [Sun, 26 Jun 2022 03:09:51 +0000 (23:09 -0400)]
doc/releases: Fix many spelling errors

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
3 years agoMerge pull request #46727 from cfsnyder/wip-54172-fix-scrub-abort
Ronen Friedman [Mon, 27 Jun 2022 16:25:30 +0000 (19:25 +0300)]
Merge pull request #46727 from cfsnyder/wip-54172-fix-scrub-abort

osd/scrubber/pg_scrubber.cc: fix bug where scrub machine gets stuck
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #46785 from kamoltat/wip-ksirivad-fix-56151
Kamoltat Sirivadhna [Mon, 27 Jun 2022 16:11:51 +0000 (12:11 -0400)]
Merge pull request #46785 from kamoltat/wip-ksirivad-fix-56151

src/mgr/DaemonServer.cc: fix typo in output gap >= max_pg_num_change
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #46761 from pdvian/wip-autoscaler-adjust
Kamoltat Sirivadhna [Mon, 27 Jun 2022 16:07:43 +0000 (12:07 -0400)]
Merge pull request #46761 from pdvian/wip-autoscaler-adjust

pybind/mgr/autoscaler: Donot show NEW PG_NUM value if autoscaler is not on
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
3 years agoMerge pull request #46020 from pritha-srivastava/wip-rgw-gc-break-chain
Casey Bodley [Mon, 27 Jun 2022 13:26:30 +0000 (09:26 -0400)]
Merge pull request #46020 from pritha-srivastava/wip-rgw-gc-break-chain

rgw: splitting gc chains into smaller parts to prevent

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46832 from zdover23/wip-doc-2022-06-24-sage-removal-1
zdover23 [Mon, 27 Jun 2022 13:05:03 +0000 (23:05 +1000)]
Merge pull request #46832 from zdover23/wip-doc-2022-06-24-sage-removal-1

doc: remove mention of Sage as current leader

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agorgw: return ENOENT for NO_SUCH_BUCKET in radosgw-admin bucket stats 46581/head
Matt Benjamin [Wed, 8 Jun 2022 19:01:00 +0000 (15:01 -0400)]
rgw: return ENOENT for NO_SUCH_BUCKET in radosgw-admin bucket stats

This was a recent behavior change.

It might be tempting to normalize these, but I'm trying to avoid further
changes in result codes.

Fixes: https://tracker.ceph.com/issues/55975
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agocmake: use CMAKE_<LANG>_COMPILER_LAUNCHER for configuring ccache 46846/head
Kefu Chai [Sat, 25 Jun 2022 14:27:02 +0000 (22:27 +0800)]
cmake: use CMAKE_<LANG>_COMPILER_LAUNCHER for configuring ccache

ccache only works for c and c++, so instead of using the universal
`RULE_LAUNCH_COMPILE` use `CMAKE_<LANG>_COMPILER_LAUNCHER` instead,
so ccache is only configured for c and c++ compilation. this is a better
solution for integrating ccache into our building system.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoinstall-deps: install pmdk libraries
Yin Congmin [Fri, 13 May 2022 12:44:53 +0000 (20:44 +0800)]
install-deps: install pmdk libraries

Install libpmem and libpmemobj under focal ubuntu. the version of apt
list can meet the current requirements. libpmemobj require >=1.8.
Libpmem has no version requirements.

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
3 years agocmake: lower the required version of libpmem to 1.8
Yin Congmin [Sat, 25 Jun 2022 09:04:44 +0000 (17:04 +0800)]
cmake: lower the required version of libpmem to 1.8

The upgrade of pmemobj in https://github.com/ceph/ceph/pull/40493
is to introduce new API. The minimum version requirement is 1.8.
Therefore, the requirements for find_package can be lowered.

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
3 years agoMerge pull request #46840 from ceph/fix-backport2
David Galloway [Fri, 24 Jun 2022 18:03:58 +0000 (14:03 -0400)]
Merge pull request #46840 from ceph/fix-backport2

.github: Add labels while PR is open

3 years ago.github: Add labels while PR is open 46840/head
David Galloway [Fri, 24 Jun 2022 16:27:43 +0000 (12:27 -0400)]
.github: Add labels while PR is open

I think https://github.com/tibdex/backport will only create backport PRs if our doc/releases PRs are labelled *and then* closed.  This action currently labels after the PR is closed.

Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years agoMerge pull request #46576 from ceph/wip-yuriw-release-17.2.1-main
David Galloway [Fri, 24 Jun 2022 15:30:33 +0000 (11:30 -0400)]
Merge pull request #46576 from ceph/wip-yuriw-release-17.2.1-main

doc: 17.2.1 Release Notes

3 years agoMerge pull request #46830 from ceph/backport-doc-pr
David Galloway [Fri, 24 Jun 2022 15:06:22 +0000 (11:06 -0400)]
Merge pull request #46830 from ceph/backport-doc-pr

.github: Automatically backport doc/releases PRs

3 years agodoc: remove mention of Sage as current leader 46832/head
Zac Dover [Fri, 24 Jun 2022 07:07:09 +0000 (17:07 +1000)]
doc: remove mention of Sage as current leader

This commit removes mention of Sage as the leader of the
Ceph project in the following files:

dev/developer_guide/essentials.rst
dev/developer_guide/merging.rst
foundation.rst
governance.rst

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agodoc: 17.2.1 nit fixes 46576/head
David Galloway [Thu, 23 Jun 2022 21:35:16 +0000 (17:35 -0400)]
doc: 17.2.1 nit fixes

Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years ago.github: Support for automatically creating backport PRs when labeled 46830/head
David Galloway [Thu, 23 Jun 2022 19:33:54 +0000 (15:33 -0400)]
.github: Support for automatically creating backport PRs when labeled

e.g., add a 'backport quincy' label to a PR and this workflow will automatically create a backport PR

Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years ago.github: Label doc/releases PRs so tibdex/backport@v2 can backport
David Galloway [Thu, 23 Jun 2022 19:31:48 +0000 (15:31 -0400)]
.github: Label doc/releases PRs so tibdex/backport@v2 can backport

Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years agorgw/dbstore: Fix crash in delete_stale_objs 46829/head
Soumya Koduri [Thu, 23 Jun 2022 17:33:18 +0000 (23:03 +0530)]
rgw/dbstore: Fix crash in delete_stale_objs

Fix a race between RemoveBucket and delete_stale_objs operations
by using shared_ptr to add reference to DB Ops.

Fixes:https://tracker.ceph.com/issues/55828
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
3 years agoMerge pull request #46643 from ronen-fr/wip-rf-blocked
Ronen Friedman [Thu, 23 Jun 2022 15:29:27 +0000 (18:29 +0300)]
Merge pull request #46643 from ronen-fr/wip-rf-blocked

scrub/osd: add clearer reminders that a scrub is blocked

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
3 years agomgr: influx: catch KeyError when looking up pool name 46756/head
Tobias Urdin [Mon, 20 Jun 2022 15:14:33 +0000 (15:14 +0000)]
mgr: influx: catch KeyError when looking up pool name

It can lookup the pool name when a new pool is created
and the pool_info doesn't contain it causing a KeyError.

Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
3 years agoqa/rgw: 1. adding yaml files to integrate iam tests in teuthology. 46660/head
Pritha Srivastava [Tue, 14 Jun 2022 05:00:22 +0000 (10:30 +0530)]
qa/rgw: 1. adding yaml files to integrate iam tests in teuthology.
2. Modifying s3tests.py for iam tests.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
3 years agoMerge pull request #46435 from liu-chunmei/crimson-error-log
Liu-Chunmei [Wed, 22 Jun 2022 22:28:48 +0000 (15:28 -0700)]
Merge pull request #46435 from liu-chunmei/crimson-error-log

Crimson/osd:  add error log

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #46613 from liu-chunmei/crimson-cmp-ext
Liu-Chunmei [Wed, 22 Jun 2022 22:26:53 +0000 (15:26 -0700)]
Merge pull request #46613 from liu-chunmei/crimson-cmp-ext

crimson/osd: return error code to break next op in cmp_ext

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agodoc: add more 17.2.1 notes
Neha Ojha [Wed, 22 Jun 2022 20:49:59 +0000 (20:49 +0000)]
doc: add more 17.2.1 notes

update release date

Signed-off-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #46795 from xxhdx1985126/wip-seastore-backref-trim-bug-fix
Samuel Just [Wed, 22 Jun 2022 18:32:44 +0000 (11:32 -0700)]
Merge pull request #46795 from xxhdx1985126/wip-seastore-backref-trim-bug-fix

crimson/os/seastore/cache: trim backref cache before preparing record

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #46788 from ivancich/wip-superfluous-struct
J. Eric Ivancich [Wed, 22 Jun 2022 16:56:52 +0000 (12:56 -0400)]
Merge pull request #46788 from ivancich/wip-superfluous-struct

rgw: remove unnecessary "struct" from req_state declarations

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #46707 from adamemerson/wip-timestamp-status
Casey Bodley [Wed, 22 Jun 2022 16:51:28 +0000 (12:51 -0400)]
Merge pull request #46707 from adamemerson/wip-timestamp-status

rgw: radosgw-admin includes current time in most status commands

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46640 from xxhdx1985126/wip-seastore-count-tree-size
Samuel Just [Wed, 22 Jun 2022 16:20:43 +0000 (09:20 -0700)]
Merge pull request #46640 from xxhdx1985126/wip-seastore-count-tree-size

crimson/os/seastore: count tree sizes

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #46816 from cbodley/wip-54405-again
Casey Bodley [Wed, 22 Jun 2022 15:27:38 +0000 (11:27 -0400)]
Merge pull request #46816 from cbodley/wip-54405-again

rgw: fix frontend's use of rgw_access log subsystem

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
3 years agoMerge pull request #46769 from zdover23/wip-doc-2022-06-21-dev-guide-config-local...
zdover23 [Wed, 22 Jun 2022 14:03:14 +0000 (00:03 +1000)]
Merge pull request #46769 from zdover23/wip-doc-2022-06-21-dev-guide-config-local-env-add-context-note

doc/dev: add context note to dev guide config

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #46369 from rkachach/fix_issue_55357
Adam King [Wed, 22 Jun 2022 13:46:25 +0000 (09:46 -0400)]
Merge pull request #46369 from rkachach/fix_issue_55357

doc/cephadm: document the new per-fsid cephadm conf location

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 years agorgw: fix frontend's use of rgw_access log subsystem 46816/head
Casey Bodley [Wed, 22 Jun 2022 13:07:36 +0000 (09:07 -0400)]
rgw: fix frontend's use of rgw_access log subsystem

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46759 from idryomov/wip-rbd-mirror-remote-not-primary
Ilya Dryomov [Wed, 22 Jun 2022 11:51:20 +0000 (13:51 +0200)]
Merge pull request #46759 from idryomov/wip-rbd-mirror-remote-not-primary

rbd-mirror: generally skip replay/resync if remote image is not primary

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #46765 from rhcs-dashboard/login-banner-cli-bug
Ernesto Puerta [Wed, 22 Jun 2022 11:38:03 +0000 (13:38 +0200)]
Merge pull request #46765 from rhcs-dashboard/login-banner-cli-bug

mgr/dashboard: dashboard help command showing wrong syntax for login-banner

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
3 years agoMerge pull request #46733 from rhcs-dashboard/rbd-mirroring-snapshot-ui
Ernesto Puerta [Wed, 22 Jun 2022 11:05:26 +0000 (13:05 +0200)]
Merge pull request #46733 from rhcs-dashboard/rbd-mirroring-snapshot-ui

mgr/dashboard: rbd mirroring promotion/demotion UI

Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agocrimson/osd: create and send error log when has error 46435/head
chunmei-liu [Wed, 25 May 2022 05:55:42 +0000 (22:55 -0700)]
crimson/osd: create and send error log when has error

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agodoc/cephadm: document the new per-fsid cephadm conf location 46369/head
Redouane Kachach [Mon, 23 May 2022 09:14:05 +0000 (11:14 +0200)]
doc/cephadm: document the new per-fsid cephadm conf location
Fixes: https://tracker.ceph.com/issues/55357
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
3 years agoscrub/osd: disable blocked-scrub warnings during some tests 46643/head
Ronen Friedman [Mon, 20 Jun 2022 12:47:57 +0000 (12:47 +0000)]
scrub/osd: disable blocked-scrub warnings during some tests

As some Teuthology tests seem to block objects for long minutes,
we must not issue the "scrub is blocked for too long" warning
(that warning causes the tests to fail).

A new configuration parameter now controls the grace period before
the warning is issued. Some tests were modified to set this
configuration parameter to a large value.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #46587 from liu-chunmei/crimson-check-truncate
Liu-Chunmei [Wed, 22 Jun 2022 05:07:46 +0000 (22:07 -0700)]
Merge pull request #46587 from liu-chunmei/crimson-check-truncate

crimson/osd: check truncate size in sparse_read

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/cache: count tree size during OSD startup 46640/head
Xuehan Xu [Fri, 17 Jun 2022 04:33:28 +0000 (12:33 +0800)]
crimson/os/seastore/cache: count tree size during OSD startup

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/os/seastore/cache: trim backref cache before preparing record 46795/head
Xuehan Xu [Fri, 17 Jun 2022 07:58:33 +0000 (15:58 +0800)]
crimson/os/seastore/cache: trim backref cache before preparing record

Otherwise, the transaction record would contain backrefs that has been
merged into the backref tree

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocmake: remove git fetch and use submodule for building opentelemetry lib 46754/head
Deepika Upadhyay [Sat, 18 Jun 2022 10:40:58 +0000 (16:10 +0530)]
cmake: remove git fetch and use submodule for building opentelemetry lib

We were using git fetch and an unofficial remote to fetch
opentelemetry-cpp, as it needed additional patch to include boost
headers, with the merge of

open-telemetry/opentelemetry-cpp#1100
open-telemetry/opentelemetry-cpp#1020

we do not require to maintain our own patched version. Also, we were
using git fetch as a temporary change, now that tracing is always on, it
should be right time to adapt to using opentelemetry-cpp as a submodule.

This removes compile time fetch for opentelemetry-cpp instead use
official opentelemetry-cpp lib as a submodule.

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years ago.gitmodules: add opentelemetry-cpp submodule
Deepika Upadhyay [Sat, 18 Jun 2022 09:54:37 +0000 (15:24 +0530)]
.gitmodules: add opentelemetry-cpp submodule

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agocrimson/osd: check truncate size in sparse_read 46587/head
chunmei-liu [Thu, 9 Jun 2022 07:44:01 +0000 (00:44 -0700)]
crimson/osd: check truncate size in sparse_read

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson/osd: return error code to break next op in cmp_ext 46613/head
chunmei-liu [Fri, 10 Jun 2022 01:30:20 +0000 (18:30 -0700)]
crimson/osd: return error code to break next op in cmp_ext

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agoMerge pull request #46616 from xxhdx1985126/wip-seastore-lba-wrong-lba-node-size
Samuel Just [Tue, 21 Jun 2022 23:18:27 +0000 (16:18 -0700)]
Merge pull request #46616 from xxhdx1985126/wip-seastore-lba-wrong-lba-node-size

crimson/os/seastore/lba_manager: correct btree node sizes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #46614 from xxhdx1985126/wip-backref-bug-fixes
Samuel Just [Tue, 21 Jun 2022 23:17:21 +0000 (16:17 -0700)]
Merge pull request #46614 from xxhdx1985126/wip-backref-bug-fixes

crimson/os/seastore: bug fixes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agorgw: remove unnecessary "struct" from req_state declarations 46788/head
J. Eric Ivancich [Tue, 21 Jun 2022 22:12:32 +0000 (18:12 -0400)]
rgw: remove unnecessary "struct" from req_state declarations

The "struct" is superfluous and makes it harder for those looking for
the definition.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agoMerge pull request #46786 from ljflores/wip-doc-fix
Laura Flores [Tue, 21 Jun 2022 22:58:41 +0000 (17:58 -0500)]
Merge pull request #46786 from ljflores/wip-doc-fix

doc/dev/developer_guide: fix small typo

3 years agoMerge pull request #46716 from rkachach/fix_issue_54474
Adam King [Tue, 21 Jun 2022 22:07:07 +0000 (18:07 -0400)]
Merge pull request #46716 from rkachach/fix_issue_54474

doc/cephadm: Add post-upgrade section

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 years agodoc/dev/developer_guide: fix small typo 46786/head
Laura Flores [Tue, 21 Jun 2022 20:52:39 +0000 (15:52 -0500)]
doc/dev/developer_guide: fix small typo

Introduced in 682b806efa39784c8ef67b46f4ac628f40aa15d9.

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #46773 from tchaikov/wip-libpmem
David Galloway [Tue, 21 Jun 2022 20:21:54 +0000 (16:21 -0400)]
Merge pull request #46773 from tchaikov/wip-libpmem

install-deps.sh: do not install libpmem from chacra

3 years agosrc/mgr/DaemonServer.cc: fix typo in output gap >= max_pg_num_change 46785/head
Kamoltat [Tue, 21 Jun 2022 20:06:07 +0000 (20:06 +0000)]
src/mgr/DaemonServer.cc: fix typo in output gap >= max_pg_num_change

Fix typo of the output when pgnum is scaling faster
than pgp_num in the function DaemonServer::adjust_pgs().

Fixes: https://tracker.ceph.com/issues/56151
Signed-off-by: Kamoltat <ksirivad@redhat.com>
3 years agomgr/dashboard: dashboard help command showing wrong syntax for login-banner 46765/head
Sarthak0702 [Tue, 21 Jun 2022 09:52:12 +0000 (15:22 +0530)]
mgr/dashboard: dashboard help command showing wrong syntax for login-banner

Signed-off-by: Sarthak0702 <sarthak.dev.0702@gmail.com>
3 years agoinstall-deps.sh: do not install libpmem from chacra 46773/head
Kefu Chai [Tue, 21 Jun 2022 15:28:23 +0000 (23:28 +0800)]
install-deps.sh: do not install libpmem from chacra

this change reverts 17d2bc3707bb0078e2fa1b4eef31b39804e45135, before
we recreate a chacra repo hosting libpmem packages, we are not able
to query the repo from shaman or pull the dependencies from chacra.

in future, we should be able to get the libpmem dependencies from
offical ubuntu package repo and fedora, CentOS Stream and RHEL repos.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agomgr/dashboard: rbd image primary ui 46733/head
Pedro Gonzalez Gomez [Fri, 3 Jun 2022 10:13:44 +0000 (12:13 +0200)]
mgr/dashboard: rbd image primary ui

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #46743 from idryomov/wip-rbd-mirror-schedule-watchless
Ilya Dryomov [Tue, 21 Jun 2022 14:19:35 +0000 (16:19 +0200)]
Merge pull request #46743 from idryomov/wip-rbd-mirror-schedule-watchless

mgr/rbd_support: always rescan image mirror snapshots on refresh

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agodoc/dev: add context note to dev guide config 46769/head
Zac Dover [Tue, 21 Jun 2022 14:09:05 +0000 (00:09 +1000)]
doc/dev: add context note to dev guide config

This PR adds a note directing first-time cloners of
their Ceph git forks to make sure to cd into the ceph/
directory before trying to run the "git config" commands.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agopybind/mgr/autoscaler: Donot show NEW PG_NUM value if autoscaler is not on 46761/head
Prashant D [Tue, 21 Jun 2022 06:53:41 +0000 (02:53 -0400)]
pybind/mgr/autoscaler: Donot show NEW PG_NUM value if autoscaler is not on

When noautscale is set, autoscale-status shows NEW PG_NUM
value if pool pg_num is more than 96. If autoscaler is in
off or warn mode for the pool then donot adjust the final
pg count for the pool.

Fixes: https://tracker.ceph.com/issues/56136
Signed-off-by: Prashant D <pdhange@redhat.com>
3 years agomgr/rbd_support: always rescan image mirror snapshots on refresh 46743/head
Ilya Dryomov [Sun, 19 Jun 2022 10:12:01 +0000 (12:12 +0200)]
mgr/rbd_support: always rescan image mirror snapshots on refresh

Establishing a watch on rbd_mirroring object and skipping rescanning
image mirror snapshots on periodic refresh unless rbd_mirroring object
gets notified in the interim is flawed.  rbd_mirroring object is
notified when mirroring is enabled or disabled on some image (including
when the image is removed), but it is not notified when images are
promoted or demoted.  However, load_pool_images() discards images that
are not primary at the time of the scan.  If the image is promoted
later, no snapshots are created even if the schedule is in place.  This
happens regardless of whether the schedule is added before or after the
promotion.

This effectively reverts commit 69259c8d3722 ("mgr/rbd_support: make
mirror_snapshot_schedule rescan only updated pools").  An alternative
fix could be to stop discarding non-primary images (i.e. drop

    if not info['primary']:
        continue

check added in commit d39eb283c5ce ("mgr/rbd_support: mirror snapshot
schedule should skip non-primary images")), but that would clutter the
queue and therefore "rbd mirror snapshot schedule status" output with
bogus entries.  Performing a rescan roughly every 60 seconds should be
manageable: currently it amounts to a single mirror_image_status_list
request, followed by mirror_image_get, get_snapcontext and snapshot_get
requests for each snapshot-based mirroring enabled image and concluded
by a single dir_list request.  Among these, per-image get_snapcontext
and snapshot_get requests are necessary for determining primaryness.

Fixes: https://tracker.ceph.com/issues/53914
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #46734 from idryomov/wip-rbd-schedule-load-race
Ilya Dryomov [Tue, 21 Jun 2022 10:43:53 +0000 (12:43 +0200)]
Merge pull request #46734 from idryomov/wip-rbd-schedule-load-race

mgr/rbd_support: avoid losing a schedule on load vs add race

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #46527 from rhcs-dashboard/mirroring-workflow
Ernesto Puerta [Tue, 21 Jun 2022 10:05:07 +0000 (12:05 +0200)]
Merge pull request #46527 from rhcs-dashboard/mirroring-workflow

mgr/dashboard: configure rbd mirroring

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: fix linting issues 46527/head
Pere Diaz Bou [Tue, 21 Jun 2022 08:34:56 +0000 (10:34 +0200)]
mgr/dashboard: fix linting issues

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>