]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agomgr/dashboard: fix rbdconfiguration init type 47105/head
Pere Diaz Bou [Wed, 6 Jul 2022 15:47:31 +0000 (17:47 +0200)]
mgr/dashboard: fix rbdconfiguration init type

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 80964fb5204ab18208d1033c927a620448802451)

3 years agomgr/dashboard: fix api tests + lint
Pere Diaz Bou [Tue, 5 Jul 2022 12:57:16 +0000 (14:57 +0200)]
mgr/dashboard: fix api tests + lint

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 08c980ede37f1d2eba08b43ce624994b939a3ca3)

3 years agomgr/dashboard: cleanups
Pere Diaz Bou [Tue, 5 Jul 2022 11:22:42 +0000 (13:22 +0200)]
mgr/dashboard: cleanups

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 23615b3e1b0d479595929d6483856afce67502d2)

3 years agomgr/dashboard: RbdConfiguration.list reuse image context.
Pere Diaz Bou [Tue, 5 Jul 2022 10:39:12 +0000 (12:39 +0200)]
mgr/dashboard: RbdConfiguration.list reuse image context.

Image contexts are reopen even though we pass the context as an
argument. This commit changes that so you can forget about reopening
a rbd image context again.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 5a0ead8cc88fd677d882391bddcff5b474a63a9b)

3 years agomgr/dashboard: change sort char to '+' and page icons
Pere Diaz Bou [Tue, 5 Jul 2022 09:55:51 +0000 (11:55 +0200)]
mgr/dashboard: change sort char to '+' and page icons

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit c01ce41266aeec229d60c302b4da8ed6fac6f2d0)

3 years agomgr/dashboard: fix linting errors
Pere Diaz Bou [Tue, 5 Jul 2022 08:10:23 +0000 (10:10 +0200)]
mgr/dashboard: fix linting errors

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 90869173ee4cbe2d9e24e354608995e04793bc7d)

3 years agomgr/dashboard: add rbd list sorting support
Pere Diaz Bou [Mon, 4 Jul 2022 14:57:43 +0000 (16:57 +0200)]
mgr/dashboard: add rbd list sorting support

Support sorting with name, pool name and namespace

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 3c308804d5a7a5e96842e3234edbf6ad42509e93)

Conflicts:
src/pybind/mgr/dashboard/services/rbd.py

remove _rbd_image_stat_parent function because it isn't used in pacific.

3 years agomgr/dashboard: update rbd list api version to 2
Pere Diaz Bou [Mon, 4 Jul 2022 10:56:03 +0000 (12:56 +0200)]
mgr/dashboard: update rbd list api version to 2

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 5386dd1cb3195e7bc2dd80dafa1f0d29e8e0eb9e)

3 years agomgr/dashboard: debounce reload data with serverSide
Pere Diaz Bou [Mon, 4 Jul 2022 10:33:36 +0000 (12:33 +0200)]
mgr/dashboard: debounce reload data with serverSide

Whenever we use serverSide (paginate through backend) we should
debounce reloadData since it might call api calls too much times.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit c832464998ed3ed34af3bda37056dfdc1729f4a6)

3 years agomgr/dashboard: add rbd list search and disable sorting
Pere Diaz Bou [Fri, 1 Jul 2022 08:16:13 +0000 (10:16 +0200)]
mgr/dashboard: add rbd list search and disable sorting

- Disable sorting in each column because it will not be possible to
sort with this pagination implementation.
- Add search capabilities to the rbd list pagination endpoint.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 68ef0b83e9b0ce3ccf854eff9cbf599a263b3e7e)

3 years agomgr/dashboard: fix rbd list tests
Pere Diaz Bou [Wed, 29 Jun 2022 11:37:17 +0000 (13:37 +0200)]
mgr/dashboard: fix rbd list tests

X-Total-Count header was missing from rbdservice.list spy mock

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 08b6f22807c14967fb49495ca9f18124d495b19b)

3 years agomgr/dashboard: fix frontend unit tests
Nizamudeen A [Tue, 28 Jun 2022 17:33:04 +0000 (23:03 +0530)]
mgr/dashboard: fix frontend unit tests

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit a27eea3e8c834eb6e148aeef72a5e8522d81ef97)

3 years agomgr/dashboard: if null tablecontext then create empty one
Pere Diaz Bou [Tue, 28 Jun 2022 13:58:11 +0000 (15:58 +0200)]
mgr/dashboard: if null tablecontext then create empty one

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 4060061014506ed1edd32936f54ed46d489c0f11)

3 years agomgr/dashboard: more linting
Pere Diaz Bou [Fri, 17 Jun 2022 11:57:53 +0000 (13:57 +0200)]
mgr/dashboard: more linting

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 27f40514ebc87a05144989be9aa1abb700f49566)

3 years agomgr/dashboard: fix tests and iscsi rbd list
Pere Diaz Bou [Fri, 17 Jun 2022 11:02:28 +0000 (13:02 +0200)]
mgr/dashboard: fix tests and iscsi rbd list

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 78523ec030621be548c4e3ecb8802d0b5c7bd8e8)

3 years agomgr/dashboard: bind serverSide to externalPaging
Pere Diaz Bou [Thu, 16 Jun 2022 09:15:35 +0000 (11:15 +0200)]
mgr/dashboard: bind serverSide to externalPaging

Count won't be used unless externalPaging is set to true.
remove paginated import

task list service needed to be updated in order to have extra
params. This commit introduces that param.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit dbf2552ca57d90f6551553d25ca493375eb1e700)

3 years agomgr/dashboard: rbd pagination poc
Pere Diaz Bou [Mon, 13 Jun 2022 15:15:45 +0000 (17:15 +0200)]
mgr/dashboard: rbd pagination poc

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit efd9a8ba5c9194e89b95aae021f62f3e164f3581)

3 years agoMerge pull request #46675 from rhcs-dashboard/wip-56038-pacific
Nizamudeen A [Wed, 13 Jul 2022 07:37:13 +0000 (13:07 +0530)]
Merge pull request #46675 from rhcs-dashboard/wip-56038-pacific

pacific: mgr/dashboard: stop polling when page is not visible

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #46953 from idryomov/wip-56387-pacific
Yuri Weinstein [Tue, 12 Jul 2022 13:31:05 +0000 (06:31 -0700)]
Merge pull request #46953 from idryomov/wip-56387-pacific

pacific: rbd-fuse: librados will filter out -r option from command-line

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
3 years agoMerge pull request #46767 from ronen-fr/wip-rf-42780-pacific
Yuri Weinstein [Tue, 12 Jul 2022 13:30:10 +0000 (06:30 -0700)]
Merge pull request #46767 from ronen-fr/wip-rf-42780-pacific

pacific: osd/scrub: mark PG as being scrubbed, from scrub initiation to Inacti…

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #47049 from zdover23/wip-doc-2022-07-12-backport-47045-to-pacific
zdover23 [Mon, 11 Jul 2022 21:00:27 +0000 (07:00 +1000)]
Merge pull request #47049 from zdover23/wip-doc-2022-07-12-backport-47045-to-pacific

pacific: doc/dev: s/github/GitHub/ in essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #47050 from zdover23/wip-doc-2022-07-12-backport-47031-to-pacific
zdover23 [Mon, 11 Jul 2022 20:55:21 +0000 (06:55 +1000)]
Merge pull request #47050 from zdover23/wip-doc-2022-07-12-backport-47031-to-pacific

pacific: doc/dev: edit delayed-delete.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/dev: s/github/GitHub/ in essentials.rst 47049/head
Zac Dover [Mon, 11 Jul 2022 16:58:18 +0000 (02:58 +1000)]
doc/dev: s/github/GitHub/ in essentials.rst

This addresses a typo that Anthony D'Atri pointed out in
PR#47032. It didn't get addressed there, so it's being
addressed here.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit f7581e05b08d6ab55446088b0fb9f29b1dd6441b)

3 years agodoc/dev: edit delayed-delete.rst 47050/head
Zac Dover [Sat, 9 Jul 2022 16:10:31 +0000 (02:10 +1000)]
doc/dev: edit delayed-delete.rst

This PR improves the English in the "CephFS Delayed
Deletion" chapter of the Ceph Internals Guide (which
is stored in the doc/dev/ directory).

There was no pressing need to rewrite this. I just saw
that it could be tightened up, and I had the fifteen
minutes I needed to do it.

Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c186c5ec6cb2ea1999cb14500aaa64d6aa72dddd)

3 years agoMerge pull request #47043 from zdover23/wip-doc-2022-07-12-backport-47032-to-pacific
zdover23 [Mon, 11 Jul 2022 18:15:19 +0000 (04:15 +1000)]
Merge pull request #47043 from zdover23/wip-doc-2022-07-12-backport-47032-to-pacific

pacific: doc/dev: add Dependabot section to essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agodoc/dev: add Dependabot section to essentials.rst 47043/head
Zac Dover [Sat, 9 Jul 2022 18:05:47 +0000 (04:05 +1000)]
doc/dev: add Dependabot section to essentials.rst

This PR adds a section to the Developer Guide chapter
"Essentials" that explains what Dependabot is. This
section is adapted from an email from Ernesto Puerta
to the CLT that was sent on 08 Jul 2022.

Co-authored-by: Ernesto Puerta <epuertat@redhat.com>>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 2711e8de80edea121503e022cca37683f8abdfa9)

3 years agoMerge pull request #46921 from ceph/revert-46429-wip-55309-pacific
Yuri Weinstein [Mon, 11 Jul 2022 13:36:20 +0000 (06:36 -0700)]
Merge pull request #46921 from ceph/revert-46429-wip-55309-pacific

Revert "pacific: mgr, mgr/prometheus: Fix regression with prometheus metrics"

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #46920 from ceph/revert-46427-wip-55308-pacific
Yuri Weinstein [Mon, 11 Jul 2022 13:35:50 +0000 (06:35 -0700)]
Merge pull request #46920 from ceph/revert-46427-wip-55308-pacific

Revert "pacific: mgr, mon: Keep upto date metadata with mgr for MONs"

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #46845 from ronen-fr/wip-rf-46727-pacific
Yuri Weinstein [Mon, 11 Jul 2022 13:34:46 +0000 (06:34 -0700)]
Merge pull request #46845 from ronen-fr/wip-rf-46727-pacific

Pacific: osd/scrubber/pg_scrubber.cc: fix bug where scrub machine gets stuck

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #46806 from nmshelke/wip-56104-pacific
Yuri Weinstein [Mon, 11 Jul 2022 13:34:03 +0000 (06:34 -0700)]
Merge pull request #46806 from nmshelke/wip-56104-pacific

pacific: mgr/volumes: subvolume ls command crashes if groupname as '_nogroup'

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46803 from nmshelke/wip-56107-pacific
Yuri Weinstein [Mon, 11 Jul 2022 13:33:18 +0000 (06:33 -0700)]
Merge pull request #46803 from nmshelke/wip-56107-pacific

pacific: mgr/volumes: remove incorrect 'size' from output of 'snapshot info'

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #46677 from ljflores/wip-51287-pacific
Yuri Weinstein [Mon, 11 Jul 2022 13:31:11 +0000 (06:31 -0700)]
Merge pull request #46677 from ljflores/wip-51287-pacific

pacific: ceph_test_librados_service: wait longer for servicemap to update

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #46939 from zdover23/wip-doc-2022-07-03-backport-46938-to-pacific
zdover23 [Sat, 9 Jul 2022 16:12:27 +0000 (02:12 +1000)]
Merge pull request #46939 from zdover23/wip-doc-2022-07-03-backport-46938-to-pacific

pacific: doc/dev: add IRC registration instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/dev: add IRC registration instructions 46939/head
Zac Dover [Sat, 2 Jul 2022 15:47:02 +0000 (01:47 +1000)]
doc/dev: add IRC registration instructions

This PR adds to the Developer Guide a link to the OFTC's IRC nick
registration instructions.

(cherry picked from commit 893e68a8f57b22cc025c82586ad0b42da2a6477c)

3 years agoMerge pull request #46340 from zdover23/wip-doc-pr-45209-backport-pacific
zdover23 [Fri, 8 Jul 2022 17:49:58 +0000 (03:49 +1000)]
Merge pull request #46340 from zdover23/wip-doc-pr-45209-backport-pacific

pacific: doc/start: alphabetize hardware-recs links

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #46347 from zdover23/wip-min-hardware-typo-pacific-backport-2022...
zdover23 [Fri, 8 Jul 2022 17:36:45 +0000 (03:36 +1000)]
Merge pull request #46347 from zdover23/wip-min-hardware-typo-pacific-backport-2022-05-19

pacific: Wip min hardware typo pacific backport 2022 05 19

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #46976 from adk3798/wip-56436-pacific
Adam King [Fri, 8 Jul 2022 12:23:31 +0000 (08:23 -0400)]
Merge pull request #46976 from adk3798/wip-56436-pacific

pacific: doc/cephadm: enhancing daemon operations documentation

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 years agoMerge pull request #46977 from adk3798/wip-56158-pacific
Adam King [Fri, 8 Jul 2022 12:22:17 +0000 (08:22 -0400)]
Merge pull request #46977 from adk3798/wip-56158-pacific

pacific: doc/cephadm: Add post-upgrade section

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 years agoMerge pull request #46974 from adk3798/wip-56473-pacific
Adam King [Fri, 8 Jul 2022 12:06:34 +0000 (08:06 -0400)]
Merge pull request #46974 from adk3798/wip-56473-pacific

pacific: pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
3 years agoMerge pull request #46069 from guits/wip-55479-pacific
Guillaume Abrioux [Fri, 8 Jul 2022 05:20:38 +0000 (07:20 +0200)]
Merge pull request #46069 from guits/wip-55479-pacific

pacific: ceph-volume: only warn when config file isn't found

3 years agoMerge pull request #46729 from guits/wip-56084-pacific
Guillaume Abrioux [Fri, 8 Jul 2022 05:15:38 +0000 (07:15 +0200)]
Merge pull request #46729 from guits/wip-56084-pacific

pacific: ceph-volume: do not log sensitive details

3 years agoMerge pull request #46731 from guits/wip-56040-pacific
Guillaume Abrioux [Fri, 8 Jul 2022 05:14:36 +0000 (07:14 +0200)]
Merge pull request #46731 from guits/wip-56040-pacific

pacific: ceph-volume: make is_valid() optional

3 years agoMerge pull request #46967 from guits/wip-56472-pacific
Guillaume Abrioux [Fri, 8 Jul 2022 05:13:03 +0000 (07:13 +0200)]
Merge pull request #46967 from guits/wip-56472-pacific

pacific: ceph-volume: decrease number of `pvs` calls in `lvm list`

3 years agoMerge pull request #47018 from guits/wip-56493-pacific
Guillaume Abrioux [Fri, 8 Jul 2022 04:10:05 +0000 (06:10 +0200)]
Merge pull request #47018 from guits/wip-56493-pacific

pacific: ceph-volume: allow listing devices by OSD ID

3 years agoMerge pull request #46975 from adk3798/wip-56455-pacific
Adam King [Fri, 8 Jul 2022 00:36:30 +0000 (20:36 -0400)]
Merge pull request #46975 from adk3798/wip-56455-pacific

pacific: mgr/cephadm: fixing scheduler consistent hashing

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoceph-volume: move get_lvs_from_path() to api/lvm.py 47018/head
Rishabh Dave [Mon, 30 Nov 2020 09:40:30 +0000 (15:10 +0530)]
ceph-volume: move get_lvs_from_path() to api/lvm.py

This makes this method reusable across ceph-volume codebase.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 0ea399c01143673f0225b1b4a48136af75b0b6c5)

3 years agoceph-volume: allow listing devices by OSD ID
Rishabh Dave [Thu, 19 Nov 2020 13:06:38 +0000 (18:36 +0530)]
ceph-volume: allow listing devices by OSD ID

Adds the ability to list devices by OSD IDs, i.e. "ceph-volume lvm list
3" would list all devices under OSD ID 3 (which can be up to 2 and 3
devices under filestore and bluestore OSDs respectively).

Fixes: https://tracker.ceph.com/issues/41294
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 0792a396ce61b356ad004ac3dbd96fabed739eac)

3 years agoceph-volume: add methods to get LV from OSD ID
Rishabh Dave [Thu, 19 Nov 2020 13:05:39 +0000 (18:35 +0530)]
ceph-volume: add methods to get LV from OSD ID

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 7bf4937a597b37d98d3c4e69e2751c07992e33e4)

3 years agoMerge pull request #46934 from zdover23/wip-doc-2022-06-30-backport-46906-to-pacific
zdover23 [Thu, 7 Jul 2022 11:25:19 +0000 (21:25 +1000)]
Merge pull request #46934 from zdover23/wip-doc-2022-06-30-backport-46906-to-pacific

pacific: doc/dev: s/the the/the/ in basic-workflow.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoRevert "pacific: mgr, mgr/prometheus: Fix regression with prometheus metrics" 46921/head
Prashant D [Fri, 1 Jul 2022 05:19:14 +0000 (15:19 +1000)]
Revert "pacific: mgr, mgr/prometheus: Fix regression with prometheus metrics"

This reverts pacific commit f07e47ae405218dbe4029ed9c82559d0cf1667a5

Reason: The pacific commit 98760e36c7bbbb48657e4d033bcbb080a56bbf7b has
added a new MMgrUpdate message which incorrectly handled service_daemon.
Reverting PR#46429 as a result of revert of PR#46427.

More details in https://tracker.ceph.com/issues/55322

Signed-off-by: Prashant D <pdhange@redhat.com>
3 years agoRevert "pacific: mgr, mon: Keep upto date metadata with mgr for MONs" 46920/head
Prashant D [Fri, 1 Jul 2022 05:18:24 +0000 (15:18 +1000)]
Revert "pacific: mgr, mon: Keep upto date metadata with mgr for MONs"

This reverts pacific commit 98760e36c7bbbb48657e4d033bcbb080a56bbf7b

Reason: The service_daemon is related to client daemons like rgw,
iscsi demons and it should not be handled in MMgrUpdate.

More details in https://tracker.ceph.com/issues/55322

Signed-off-by: Prashant D <pdhange@redhat.com>
3 years agodoc/cephadm: Add post-upgrade section 46977/head
Redouane Kachach [Thu, 16 Jun 2022 14:28:30 +0000 (16:28 +0200)]
doc/cephadm: Add post-upgrade section
Fixes: https://tracker.ceph.com/issues/54474
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 49b234ae744dd3a2afc130d9c215f4f00c1ee4b8)

3 years agodoc/cephadm: enhancing daemon operations documentation 46976/head
Redouane Kachach [Wed, 15 Jun 2022 10:35:30 +0000 (12:35 +0200)]
doc/cephadm: enhancing daemon operations documentation
Fixes: https://tracker.ceph.com/issues/54399
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit df1aaacb7d09322528e42ae90c0d98793e9c254e)

3 years agomgr/cephadm: fixing E128 warning 46975/head
Redouane Kachach [Wed, 29 Jun 2022 15:03:10 +0000 (17:03 +0200)]
mgr/cephadm: fixing E128 warning

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit e37924c623d797b3118ddd9a804818432a5704dd)

3 years agomgr/cephadm: fixing scheduler consistent hashing
Redouane Kachach [Tue, 28 Jun 2022 13:32:19 +0000 (15:32 +0200)]
mgr/cephadm: fixing scheduler consistent hashing

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 5d5829cd370e9278cb8b70d6426094e595badb5d)

3 years agopybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure 46974/head
dparmar18 [Tue, 14 Jun 2022 20:30:48 +0000 (02:00 +0530)]
pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Fixes: https://tracker.ceph.com/issues/56024
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 6436acc4b51b52635f8fa0e56cd79ba66c028d81)

3 years agoMerge pull request #46744 from mkogan1/rgw-backport-pacific-t54363
Yuri Weinstein [Tue, 5 Jul 2022 14:39:27 +0000 (07:39 -0700)]
Merge pull request #46744 from mkogan1/rgw-backport-pacific-t54363

pacific: rgwlc: fix segfault resharding during lc

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46715 from mkogan1/rgw-pacific-fix-fips-segf
Yuri Weinstein [Tue, 5 Jul 2022 14:38:48 +0000 (07:38 -0700)]
Merge pull request #46715 from mkogan1/rgw-pacific-fix-fips-segf

pacific rgw: on FIPS enabled, fix segfault performing s3 multipart PUT

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46235 from vumrao/wip-vumrao-54278
Yuri Weinstein [Tue, 5 Jul 2022 14:37:59 +0000 (07:37 -0700)]
Merge pull request #46235 from vumrao/wip-vumrao-54278

pacific: rgw: remove rgw_rados_pool_pg_num_min and its use on pool creation use the cluster defaults for pg_num_min

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43802 from rjhaverkamp/wip-53145-pacific
Yuri Weinstein [Tue, 5 Jul 2022 14:36:38 +0000 (07:36 -0700)]
Merge pull request #43802 from rjhaverkamp/wip-53145-pacific

pacific: rgw: fix self-comparison for RGWCopyObj optimization

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46909 from idryomov/wip-rbd-deep-copy-progress-pacific
Yuri Weinstein [Tue, 5 Jul 2022 14:15:31 +0000 (07:15 -0700)]
Merge pull request #46909 from idryomov/wip-rbd-deep-copy-progress-pacific

pacific: librbd: update progress for non-existent objects on deep-copy

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
3 years agoMerge pull request #46815 from idryomov/wip-55389-pacific
Yuri Weinstein [Tue, 5 Jul 2022 14:14:32 +0000 (07:14 -0700)]
Merge pull request #46815 from idryomov/wip-55389-pacific

pacific: librbd/cache/pwl: fix endianness issue

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #46813 from idryomov/wip-rbd-mirror-remote-not-primary-pacific
Yuri Weinstein [Tue, 5 Jul 2022 14:13:46 +0000 (07:13 -0700)]
Merge pull request #46813 from idryomov/wip-rbd-mirror-remote-not-primary-pacific

pacific: rbd-mirror: generally skip replay/resync if remote image is not primary

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
3 years agoMerge pull request #46778 from idryomov/wip-rbd-schedule-backports-pacific
Yuri Weinstein [Tue, 5 Jul 2022 14:12:31 +0000 (07:12 -0700)]
Merge pull request #46778 from idryomov/wip-rbd-schedule-backports-pacific

pacific: mirror snapshot schedule and trash purge schedule fixes

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoceph-volume: decrease number of `pvs` calls in `lvm list` 46967/head
Guillaume Abrioux [Mon, 20 Jun 2022 11:43:43 +0000 (13:43 +0200)]
ceph-volume: decrease number of `pvs` calls in `lvm list`

current implementation of `List.create_report()` implies a lot of calls
to `pvs` process. This could be avoided.

current implementation:
```
>>> import timeit
>>> from ceph_volume.devices.lvm.listing import List
>>> timeit.timeit(List([]).main, number=1000)

...

93.03700458299136
```

new implementation:

```
>>> import timeit
>>> from ceph_volume.devices.lvm.listing import List
>>> timeit.timeit(List([]).main, number=1000)

...

62.16391600697534
```

In this example, it improves performance by ~30%

Fixes: https://tracker.ceph.com/issues/56127
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 1a38ea3b96dbe8fd2f2fca8ee9a501ef1423027f)

3 years agoMerge pull request #46531 from rhcs-dashboard/wip-55752-pacific
Ernesto Puerta [Mon, 4 Jul 2022 11:52:54 +0000 (13:52 +0200)]
Merge pull request #46531 from rhcs-dashboard/wip-55752-pacific

pacific: mgr/dashboard: batch rbd-mirror backports

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: melissa-kun-li <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agorbd-fuse: librados will filter out -r option from command-line 46953/head
wanwencong [Fri, 24 Jun 2022 15:54:52 +0000 (23:54 +0800)]
rbd-fuse: librados will filter out -r option from command-line

The -r option will be filtered out by librados
when exec cmd "rbd-fuse /mountpoint -p pool_name -r rbd_name"
other rbds can be seen under the mount point

Fixes: https://tracker.ceph.com/issues/56387
Signed-off-by: wanwencong <wanwc@chinatelecom.cn>
(cherry picked from commit e99d64bc8a5c3bbb8a3632f211d4f56751cf499e)

3 years agodoc/dev: s/the the/the/ in basic-workflow.rst 46934/head
Zac Dover [Thu, 30 Jun 2022 11:08:51 +0000 (21:08 +1000)]
doc/dev: s/the the/the/ in basic-workflow.rst

This PR does exactly what it says: it changes a "the the"
to a "the".

I'd like to thank Josh Soref for bringing this
to my attention.

(cherry picked from commit 326034807d58fe6569851c043f71a222f59cde5e)

3 years agoMerge pull request #46870 from rhcs-dashboard/wip-56118-pacific
Pere Diaz Bou [Fri, 1 Jul 2022 09:35:51 +0000 (11:35 +0200)]
Merge pull request #46870 from rhcs-dashboard/wip-56118-pacific

pacific: mgr/dashboard: iterate through copy of items

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: fix rbd remote calls 46531/head
Pere Diaz Bou [Thu, 30 Jun 2022 11:44:49 +0000 (13:44 +0200)]
mgr/dashboard: fix rbd remote calls

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: rbd image primary ui
Pedro Gonzalez Gomez [Fri, 3 Jun 2022 10:13:44 +0000 (12:13 +0200)]
mgr/dashboard: rbd image primary ui

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: fix linting issues
Pere Diaz Bou [Tue, 21 Jun 2022 08:34:56 +0000 (10:34 +0200)]
mgr/dashboard: fix linting issues

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: Error page cleanup
Nizamudeen A [Wed, 15 Jun 2022 17:22:39 +0000 (22:52 +0530)]
mgr/dashboard: Error page cleanup

Some error page cleanups

Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: add rbd status endpoint
Melissa Li [Thu, 26 May 2022 18:07:30 +0000 (14:07 -0400)]
mgr/dashboard: add rbd status endpoint

Show "No RBD pools available" error page when accessing block/rbd if there are no rbd pools.
Add a "button_name" and "button_route" property to `ModuleStatusGuardService` config to customize the button on the error page.
Modify `ModuleStatusGuardService` to execute API calls to `/ui-api/<uiApiPath>/status` which uses the `UIRouter`.

Fixes: https://tracker.ceph.com/issues/42109
Signed-off-by: Melissa Li <melissali@redhat.com>
(cherry picked from commit 6ac9b3cfe171a8902454ea907b3ba37d83eda3dc)

3 years agomgr/dashboard: configure rbd mirroring
Nizamudeen A [Mon, 6 Jun 2022 05:51:29 +0000 (11:21 +0530)]
mgr/dashboard: configure rbd mirroring

One-click button in the case of an orch cluster for configuring the
rbd-mirroring when its not properly setup. This button will create an
rbd-mirror service and also an rbd labelled pool(replicated: size-3) (if they are not
existing)

Fixes: https://tracker.ceph.com/issues/55646
Signed-off-by: Nizamudeen A <nia@redhat.com>
 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/core/error/error.component.html
src/pybind/mgr/dashboard/frontend/src/app/shared/services/module-status-guard.service.ts
src/pybind/mgr/dashboard/tests/test_rbd_mirroring.py

error component and module-status-guard.service.ts had one minor
conflict which was resolved by getting incoming changes (add missing
logic).
test_rbd_mirroring had an import conflict which was resolved by
accepting incoming changes which had the same imports with new ones.

3 years agomgr/dashboard: improve edit site name action in rbd-mirroring
Nizamudeen A [Mon, 13 Jun 2022 08:24:15 +0000 (13:54 +0530)]
mgr/dashboard: improve edit site name action in rbd-mirroring

Fixes: https://tracker.ceph.com/issues/55896
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: rbd force resync from fornt-end
Sarthak0702 [Thu, 2 Jun 2022 22:58:31 +0000 (04:28 +0530)]
mgr/dashboard: rbd force resync from fornt-end

Signed-off-by: Sarthak0702 <sarthak.dev.0702@gmail.com>
3 years agomgr/dashboard: fix mirroring e2e and lint errors
Avan Thakkar [Wed, 8 Jun 2022 11:03:18 +0000 (16:33 +0530)]
mgr/dashboard: fix mirroring e2e and lint errors

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
3 years agomgr/dashboard: add byte info, move state, add idle state
Pere Diaz Bou [Tue, 7 Jun 2022 17:57:44 +0000 (19:57 +0200)]
mgr/dashboard: add byte info, move state, add idle state

Idle substate added from snapshot mode.
Instead of seconds info we display bytes and entries info.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Conflicts:
src/pybind/mgr/dashboard/controllers/rbd_mirroring.py

Fixed a minor import conflict

3 years agomgr/dashboard: move replaying images to Syncing tab
Pere Diaz Bou [Mon, 30 May 2022 14:10:11 +0000 (16:10 +0200)]
mgr/dashboard: move replaying images to Syncing tab

Images with 'Replaying' state will be displayed in Syncing tab. syncTmpl
removed as it was unnecessary if sate is provided from the backend.

Replaying images in contrast of Syncing images don't have a progress
percentage, nevertheless, we have an approximation of how much time left
there is until the image is fully synced. Therefore, we can use seconds_until_synced to represent the progress.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: snapshot mirroring from dashboard
Pere Diaz Bou [Fri, 13 May 2022 15:15:33 +0000 (17:15 +0200)]
mgr/dashboard: snapshot mirroring from dashboard

Enable snapshot mirroring from the Pools -> Image

Also show the mirror-snapshot in the image where snapshot is enabled

When parsing images if an image has the snapshot mode enabled, it will
try to  run commands that don't work with that mode. The solution was
not running those for now and appending the mode in the get call.

Fixes: https://tracker.ceph.com/issues/55648
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 489a385a95d6ffa5dbd4c5f9c53c1f80ea179142)

3 years agomgr/dashboard: expose image mirroring commands as endpoints
Pere Diaz Bou [Thu, 12 May 2022 18:29:01 +0000 (20:29 +0200)]
mgr/dashboard: expose image mirroring commands as endpoints

Expose:
  - enable/disable mirroring in image
  - promote/demote (primary and non-primary)
  - resync
  - snapshot mode:
    - mirror image snapshot (manual snapshot)
    - schedule

Fixes: https://tracker.ceph.com/issues/55645
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 8bd89415fe340512f457acd58225934e9ed8e4e1)

3 years agolibrbd: make ImageCopyRequest::send_next_object_copy() return void 46909/head
Ilya Dryomov [Tue, 28 Jun 2022 18:47:25 +0000 (20:47 +0200)]
librbd: make ImageCopyRequest::send_next_object_copy() return void

Make send_object_copies() consistent with handle_object_copy() wrt
calling send_next_object_copy().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 155fabd994f8a2052482d216df1ec0dfb40cb5b7)

3 years agolibrbd: update progress for non-existent objects on deep-copy
Ilya Dryomov [Sun, 26 Jun 2022 11:05:09 +0000 (13:05 +0200)]
librbd: update progress for non-existent objects on deep-copy

As a side effect of commit e5a21e904142 ("librbd: deep-copy image copy
state machine skips clean objects"), handle_object_copy() stopped being
called for non-existent objects.  This broke progress_object_no logic,
which expects to "see" all object numbers so that update_progress()
callback invocations can be ordered.  Currently update_progress() based
progress reporting gets stuck after encountering a hole in the image.

To fix, arrange for handle_object_copy() to be called for all object
numbers, even if ObjectCopyRequest isn't created.  Defer the extra call
to the image work queue to avoid locking issues.

Fixes: https://tracker.ceph.com/issues/56181
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 6813a7879146aec40f204a174b40a5a54e00b780)

3 years agoMerge pull request #46903 from zdover23/wip-doc-2022-06-30-backport-46984-to-pacific
zdover23 [Thu, 30 Jun 2022 10:58:24 +0000 (20:58 +1000)]
Merge pull request #46903 from zdover23/wip-doc-2022-06-30-backport-46984-to-pacific

pacific: doc/index.rst: add link to Dev Guide basic workfl.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/index.rst: add link to Dev Guide basic workfl. 46903/head
Zac Dover [Wed, 29 Jun 2022 12:57:13 +0000 (22:57 +1000)]
doc/index.rst: add link to Dev Guide basic workfl.

This PR adds a link to the "Basic Workflow" section of the
Developer Guide on the landing page of docs.ceph.com.

This PR is meant to improve the documentation for developers
new to Ceph and to guide them to instructions that will allow
them to become full-fledged contributors to the Ceph project
as quickly as possible.

The "Basic Workflow" page of the Developer Guide contains
information that answers almost all of the questions that I had
about contributing to the Ceph project when I was new to it,
and I am finally acting on my long-held conviction that the
"Basic Workflow" page of the Developer Guide should have a more
prominent position in the documentation suite than it has had.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c624a2a8ef71035eef34ee866ef7668f83a139e7)

3 years agoMerge pull request #46717 from rhcs-dashboard/wip-56075-pacific
Ernesto Puerta [Wed, 29 Jun 2022 18:20:30 +0000 (20:20 +0200)]
Merge pull request #46717 from rhcs-dashboard/wip-56075-pacific

pacific: mgr/dashboard: bump moment from 2.29.1 to 2.29.3 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #46626 from neesingh-rh/wip-55937-pacific
Laura Flores [Wed, 29 Jun 2022 16:01:01 +0000 (11:01 -0500)]
Merge pull request #46626 from neesingh-rh/wip-55937-pacific

pacific: client: Inode::hold_caps_until is time from monotonic clock now.

3 years agotest/librados: modify LibRadosMiscConnectFailure.ConnectFailure to comply with new... 46626/head
Laura Flores [Thu, 9 Jun 2022 18:55:48 +0000 (18:55 +0000)]
test/librados: modify LibRadosMiscConnectFailure.ConnectFailure to comply with new seconds unit

The unit type for `client_mount_timeout` was changed from "float" to "secs" in
983b10506dc8466a0e47ff0d320d480dd09999ec. To make this test comply with the new
seconds unit change, we need to change the value to an integer, as seconds
does not accept float values.

Fixes: https://tracker.ceph.com/issues/55971
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit f357459e6b159229ad40491709f756b06a6e87f1)
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
3 years agoclient: Inode::hold_caps_until is time from monotonic clock now.
Neeraj Pratap Singh [Wed, 8 Dec 2021 08:42:59 +0000 (14:12 +0530)]
client: Inode::hold_caps_until is time from monotonic clock now.

Inode::hold_caps_until storing time from ceph::coarse_mono_clock now.

This upstream code of this PR i.e. the parent PR contains the file
`src/common/options/mds-client.yaml.in` which intends to fix a part
of this PR whereas this file didn't exist in pacific branch.So, those
changes of `src/common/options/mds-client.yaml.in` are incorporated in
the below mentioned files in Conlicts.
Fixes: https://tracker.ceph.com/issues/52982
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 983b10506dc8466a0e47ff0d320d480dd09999ec)

Conflicts:`/src/common/legacy_config_opts.h`
          `/src/common/options.cc`

3 years agoMerge pull request #46802 from lxbsz/wip-56105
Yuri Weinstein [Tue, 28 Jun 2022 15:17:28 +0000 (08:17 -0700)]
Merge pull request #46802 from lxbsz/wip-56105

pacific: qa: wait rank 0 to become up:active state before mounting fuse client

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
3 years agoMerge pull request #46799 from lxbsz/wip-56110
Yuri Weinstein [Tue, 28 Jun 2022 15:15:42 +0000 (08:15 -0700)]
Merge pull request #46799 from lxbsz/wip-56110

pacific: client: choose auth MDS for getxattr with the Xs caps

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46798 from lxbsz/wip-55449
Yuri Weinstein [Tue, 28 Jun 2022 15:15:08 +0000 (08:15 -0700)]
Merge pull request #46798 from lxbsz/wip-55449

pacific: client: add option to disable collecting and sending metrics

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46682 from lxbsz/wip-56016
Yuri Weinstein [Tue, 28 Jun 2022 15:14:27 +0000 (08:14 -0700)]
Merge pull request #46682 from lxbsz/wip-56016

Pacific: mds: clear MDCache::rejoin_*_q queues before recovering file inodes

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46679 from lxbsz/wip-55993
Yuri Weinstein [Tue, 28 Jun 2022 15:13:53 +0000 (08:13 -0700)]
Merge pull request #46679 from lxbsz/wip-55993

Pacific: client: switch AT_NO_ATTR_SYNC to AT_STATX_DONT_SYNC

Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46646 from rhcs-dashboard/wip-54577-pacific
Yuri Weinstein [Tue, 28 Jun 2022 15:12:17 +0000 (08:12 -0700)]
Merge pull request #46646 from rhcs-dashboard/wip-54577-pacific

pacific: Add mapping for ernno:13 and adding path in error msg in opendir()/cephfs.pyx

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
3 years agoMerge pull request #46557 from lxbsz/wip-55935
Yuri Weinstein [Tue, 28 Jun 2022 15:11:13 +0000 (08:11 -0700)]
Merge pull request #46557 from lxbsz/wip-55935

Pacific: client: always return ESTALE directly in handle_reply

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46425 from lxbsz/wip-55660
Yuri Weinstein [Tue, 28 Jun 2022 15:10:45 +0000 (08:10 -0700)]
Merge pull request #46425 from lxbsz/wip-55660

Pacific: qa: add filesystem/file sync stuck test support

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46424 from lxbsz/wip-55659
Yuri Weinstein [Tue, 28 Jun 2022 15:09:59 +0000 (08:09 -0700)]
Merge pull request #46424 from lxbsz/wip-55659

Pacific: mds: trigger to flush the mdlog in handle_find_ino()

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #46423 from lxbsz/wip-55757
Yuri Weinstein [Tue, 28 Jun 2022 15:08:33 +0000 (08:08 -0700)]
Merge pull request #46423 from lxbsz/wip-55757

Pacific: mds: flush mdlog if locked and still has wanted caps not satisfied

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar vshankar@redhat.com