rgw: Guard against malformed bucket URLs

Misplaced colons can result in radosgw thinking is has a bucket URL
but with no bucket name, leading to a crash later on.

Fixes: https://tracker.ceph.com/issues/55765
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 3ee9a3b41a289a926fed8b8927ca2a93b4f120a6)
Fixes: https://tracker.ceph.com/issues/56585
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Fix `rgw::sal::Bucket::empty` static method signatures

`unique_ptr` overload should take by reference.

Both should be const.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit b1d3e6c00674ebf6bde08968789a426d65db73d9)

Conflicts:
src/rgw/rgw_sal.h
 - `unique_ptr` overload of empty

Fixes: https://tracker.ceph.com/issues/56585
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #47156 from rhcs-dashboard/wip-56616-quincy

quincy: mgr/dashboard: do not recommend throughput for ssd's only cluster

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: do not recommend throughput for ssd's only cluster

This is just a bug fix where we recommend the throughput option even if
there are only ssd's are present in the cluster.

Fixes: https://tracker.ceph.com/issues/56413
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 0f6f79f1d9c716e13f662151459fa107f651f158)

Merge pull request #47094 from rhcs-dashboard/wip-56547-quincy

quincy: mgr/dashboard: don't log tracebacks on 404s

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #47146 from s0nea/wip-56593-quincy

quincy: mgr/dashboard: prevent alert redirect

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: prevent alert redirect

Prevent Alertmanager alerts from being redirected to the active mgr
dashboard instance. There are two reasons for it:

1. It doesn't bring any additional benefit. The Alertmanager config
   includes all available mgr instances - active and passive ones. In
   case of an alert, it will be sent to all of them. It ensures that
   the active mgr dashboard will receive the alert in any case.
2. The redirect URL includes the mgr IP and NOT the FQDN. This leads
   to issues in environments where an SSL certificate is configured and
   matches the FQDNs, only.

Fixes: https://tracker.ceph.com/issues/56401
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 965005e0789e566ccadce7a326b0e197ab8d7f5f)

Merge pull request #47071 from adk3798/wip-56475-quincy

quincy: cephadm: improve message when removing osd

Merge pull request #46966 from guits/wip-56471-quincy

quincy: ceph-volume: decrease number of `pvs` calls in `lvm list`

Merge pull request #46968 from guits/wip-56471-2-quincy

quincy: ceph-volume: avoid unnecessary subprocess calls

Merge pull request #47072 from adk3798/wip-56474-quincy

quincy: pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #47070 from adk3798/wip-56494-quincy

quincy: mgr/cephadm: limiting ingress/keepalived pass to 8 chars

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47123 from zdover23/wip-doc-2022-07-16-backport-47109-to-quincy

quincy: doc/start: update hardware recs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47069 from adk3798/wip-56501-quincy

quincy: ceph.spec: fixing cephadm build deps

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47073 from adk3798/wip-56454-quincy

quincy: mgr/cephadm: fixing scheduler consistent hashing

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47075 from adk3798/wip-56177-quincy

quincy: mgr/cephadm: use host shortname for osd memory autotuning

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47085 from rhcs-dashboard/wip-56545-quincy

quincy: mgr/dashboard: ingress backend service should list all supported services

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/start: update hardware recs

This PR picks up the parts of
https://github.com/ceph/ceph/pull/44466
that were not merged back in January, when that
pull request was raised.

Matters added here:
* improved organzation of matter
* emphasis of IOPs per core over cores per OSD

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 29c44a3bd6919f7fc23083d75d22e84c8b51e1c1)

Merge pull request #46954 from idryomov/wip-56387-quincy

quincy: rbd-fuse: librados will filter out -r option from command-line

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #46910 from idryomov/wip-rbd-deep-copy-progress-quincy

quincy: librbd: update progress for non-existent objects on deep-copy

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #46814 from idryomov/wip-rbd-mirror-remote-not-primary-quincy

quincy: rbd-mirror: generally skip replay/resync if remote image is not primary

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #46742 from mkogan1/backport-quincy-t54363

quincy: rgwlc: fix segfault resharding during lc

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #46625 from cfsnyder/wip-55997-quincy

quincy: rgw: reopen ops log file on sighup

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #46781 from idryomov/wip-rbd-schedule-backports-quincy

quincy: mirror snapshot schedule and trash purge schedule fixes

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

Merge pull request #46624 from cfsnyder/wip-55999-quincy

quincy: rgw: log access key id in ops logs

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #46598 from idryomov/wip-qa-rwl-on-tmpfs-quincy

quincy: qa/suites/rbd: place cache file on tmpfs for xfstests

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #46594 from idryomov/wip-rbd-unlink-newest-snap-at-capacity-quincy

quincy: librbd: unlink newest mirror snapshot when at capacity, bump capacity

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

Merge pull request #46591 from idryomov/wip-rbd-preserve-non-primary-snap-quincy

quincy: rbd-mirror: don't prune non-primary snapshot when restarting delta sync

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>

Merge pull request #46801 from lxbsz/wip-56106

quincy: qa: wait rank 0 to become up:active state before mounting fuse client

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46800 from lxbsz/wip-56109

quincy: client: choose auth MDS for getxattr with the Xs caps

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46697 from NitzanMordhai/wip-54282-quincy

quincy: pybind/mgr: ceph osd status crash with ZeroDivisionError

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #46681 from lxbsz/wip-56015

Quincy: mds: clear MDCache::rejoin_*_q queues before recovering file inodes

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #46680 from lxbsz/wip-55994

Quincy: client: switch AT_NO_ATTR_SYNC to AT_STATX_DONT_SYNC

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>

Merge pull request #46595 from kotreshhr/wip-55926-quincy

quincy: client/fuse: Fix directory DACs overriding for root

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46566 from vshankar/tr-55933

quincy: mds: do not assert early on when issuing client leases

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46558 from lxbsz/wip-55934

Quincy:  client: always return ESTALE directly in handle_reply

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #47102 from adk3798/quincy-osd-removal-docs-update

quincy: doc/cephadm: add note about OSDs being recreated to OSD removal section

Reviewed-by: <Anthony D'Atri anthonyeleven@users.noreply.github.com>

doc/cephadm: add note about OSDs being recreated to OSD removal section

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d4a39cd046b93cb7bb5b7ce0311139d9f6552802)

mgr/dashboard: don't log tracebacks on 404s

Currently we're logging tracebacks on expected request errors as 404,
401, etc. This may cause confusion to users, which might think that
something really wrong was happening there.

This should be extended to many DashboardExceptions that simply return
expected HTTP error codes (403, 415, 3xx, etc).

Fixes: https://tracker.ceph.com/issues/55720
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit 3928fe91a4b8c313a52e38cab9ba31e54ff1ae51)

mgr/dashboard: ingress backend service should list all supported services

Fixes: https://tracker.ceph.com/issues/56478
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 32118522cb71722c3cc20a1e1a9ca9ffdf7897e4)

Merge pull request #47077 from adk3798/wip-56159-quincy

quincy: doc/cephadm: Add post-upgrade section

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47076 from adk3798/wip-56171-quincy

quincy: doc/cephadm: document the new per-fsid cephadm conf location

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47074 from adk3798/wip-56437-quincy

quincy: doc/cephadm: enhancing daemon operations documentation

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47068 from adk3798/wip-56505-quincy

quincy: doc/cephadm/services: the config section of service specs

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

doc/cephadm: Add post-upgrade section
Fixes: https://tracker.ceph.com/issues/54474
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 49b234ae744dd3a2afc130d9c215f4f00c1ee4b8)

doc/cephadm: document the new per-fsid cephadm conf location
Fixes: https://tracker.ceph.com/issues/55357
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 443f93e95d8068a31526730da0febd692b87b7a5)

mgr/cephadm: use hostname from crush map for osd memory autotuning

Fixes: https://tracker.ceph.com/issues/55841
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 50f28aa56edd348c3816335bef3bbfaf5133ae54)

doc/cephadm: enhancing daemon operations documentation
Fixes: https://tracker.ceph.com/issues/54399
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit df1aaacb7d09322528e42ae90c0d98793e9c254e)

mgr/cephadm: fixing E128 warning

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit e37924c623d797b3118ddd9a804818432a5704dd)

mgr/cephadm: fixing scheduler consistent hashing

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 5d5829cd370e9278cb8b70d6426094e595badb5d)

pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Fixes: https://tracker.ceph.com/issues/56024
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 6436acc4b51b52635f8fa0e56cd79ba66c028d81)

cephadm: improve message when removing osd

make it clearer that not passing --zap will leave VG/LV, therefore all
LVM metadata associated with the osd being removed from the Ceph cluster.

Fixes: https://tracker.ceph.com/issues/56092
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 854b62e2a9367e1ebe92c445b0bb419c185aad50)

mgr/cephadm: limitting ingress/keepalived pass to 8 chars
Fixes: https://tracker.ceph.com/issues/55491
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 4fe59545ec8a4d7677bb7949ab283acf4b15b6cf)

ceph.spec: fixing cephadm build deps
Fixes: https://tracker.ceph.com/issues/52514
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 2c4b31601f546c8a6b08824d9fcaa3c33f518b74)

doc/cephadm/services: the config section of service specs
Fixes: https://tracker.ceph.com/issues/53997
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit b67bd50a3bb1233973586c4c2eabfb934db2e818)

Merge pull request #46915 from cbodley/wip-55495

quincy: rgw/dbstore: Fix build errors on centos9

Merge pull request #47048 from zdover23/wip-doc-2022-07-12-backport-47045-to-quincy

quincy: doc/dev: s/github/GitHub/ in essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47051 from zdover23/wip-doc-2022-07-12-backport-47031-to-quincy

quincy: doc/dev: edit delayed-delete.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: s/github/GitHub/ in essentials.rst

This addresses a typo that Anthony D'Atri pointed out in
PR#47032. It didn't get addressed there, so it's being
addressed here.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit f7581e05b08d6ab55446088b0fb9f29b1dd6441b)

doc/dev: edit delayed-delete.rst

This PR improves the English in the "CephFS Delayed
Deletion" chapter of the Ceph Internals Guide (which
is stored in the doc/dev/ directory).

There was no pressing need to rewrite this. I just saw
that it could be tightened up, and I had the fifteen
minutes I needed to do it.

Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c186c5ec6cb2ea1999cb14500aaa64d6aa72dddd)

Merge pull request #47042 from zdover23/wip-doc-2022-07-12-backport-47032-to-quincy

quincy: doc/dev: add Dependabot section to essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

doc/dev: add Dependabot section to essentials.rst

This PR adds a section to the Developer Guide chapter
"Essentials" that explains what Dependabot is. This
section is adapted from an email from Ernesto Puerta
to the CLT that was sent on 08 Jul 2022.

Co-authored-by: Ernesto Puerta <epuertat@redhat.com>>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 2711e8de80edea121503e022cca37683f8abdfa9)

Merge pull request #47007 from rhcs-dashboard/wip-56126-quincy

quincy: mgr/dashboard: display helpfull message when the iframe-embedded Grafana dashboard failed to load

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: nSedrickm <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46990 from aaSharma14/wip-56481-quincy

quincy: mgr/dashboard: Improve monitoring tabs content

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46790 from adk3798/wip-55951-quincy

quincy: cephadm: preserve cephadm user during RPM upgrade

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #46339 from zdover23/wip-doc-pr-45209-backport-quincy

quincy: doc/start: alphabetize hardware-recs links

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #46548 from MrFreezeex/wip-55653-quincy

quincy: ceph-mixin: backport of recent cleanups

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: Dashboard should display some helpful (error) message when the iframe-embedded Grafana dashboard failed to load

This commit adds checks for successful grafana panel loads before displaying dashboards and informs the user if the request is blocked by the browser
Fixes: https://tracker.ceph.com/issues/54206
Signed-off-by: Ngwa Sedrick Meh <nsedrick101@gmail.com>
(cherry picked from commit a4b66efb2a2139bd88a6a088af9bd5e079e46105)

Merge pull request #46935 from zdover23/wip-doc-2022-06-30-backport-46906-to-quincy

quincy: doc/dev: s/the the/the/ in basic-workflow.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

mgr/dashboard: Improve column spacing in alerts tab

This PR intends to fix the column spacing in the alert list in the alerts tab

Fixes:https://tracker.ceph.com/issues/56165
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit d60ca04c965446cfde20a0b7bfdd76393815c1bb)

mds: clear the recover and check queues in front of identify_files_to_recover()

If the monitor sends rejoin mdsmap twice just before the first time
hasn't finished yet, it may run identify_files_to_recover() twice.
Since the rejoin_recover_q and rejoin_check_q were vector so there
could be duplicated inodes.

Fixes: https://tracker.ceph.com/issues/53741
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit d82bdd8e4255585512a963c87c8300be8dc26420)

Merge pull request #46946 from aaSharma14/wip-56451-quincy

quincy: doc: update docs for centralized logging

Reviewed-by: anthonyeleven <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

ceph-volume: avoid unnecessary subprocess calls

These calls are slowing down `ceph-volume inventory`.
Especially because of the class `ceph_volume.util.device.Devices`.
It calls the class `ceph_volume.util.device.Device` for each device found
on the host which calls many times the binaries `lsblk`, `pvs`, `vgs`, `lvs` itself.
We can make only one call in `Devices()` to gather all details and use them during the whole runtime

current implementation:

```
        1    0.000    0.000    0.892    0.892 device.py:35(__init__) (class Devices)
        8    0.001    0.000    0.853    0.107 device.py:151(_parse)
       56    0.002    0.000    0.882    0.016 process.py:154(call)
        8    0.001    0.000    0.245    0.031 lvm.py:1099(get_lvs)
        8    0.000    0.000    0.026    0.003 disk.py:231(lsblk)
        8    0.000    0.000    0.435    0.054 device.py:278(_set_lvm_membership)
        1    0.000    0.000    0.885    0.885 device.py:38(<listcomp>) (multiple calls to Device() class)
      8/5    0.000    0.000    0.885    0.177 device.py:92(__init__) (class Device)

>>> timeit.timeit('Inventory([]).main()', setup='from ceph_volume.inventory import Inventory', number=1)

Device Path               Size         rotates available Model name
/dev/sdb                  200.00 GB    True    True      QEMU HARDDISK
/dev/sda                  200.00 GB    True    False     QEMU HARDDISK
/dev/sdc                  200.00 GB    True    False     QEMU HARDDISK
/dev/sdd                  200.00 GB    True    False     QEMU HARDDISK
/dev/vda                  11.00 GB     True    False
0.9309048530412838
>>>
```

new approach:

```
        1    0.000    0.000    0.253    0.253 device.py:35(__init__) (class Devices)
        5    0.000    0.000    0.144    0.029 device.py:167(_parse)
       21    0.001    0.000    0.246    0.012 process.py:154(call)
        1    0.000    0.000    0.032    0.032 lvm.py:1110(get_lvs)
        1    0.000    0.000    0.005    0.005 disk.py:236(lsblk_all)
        5    0.000    0.000    0.062    0.012 device.py:309(_set_lvm_membership)
        1    0.000    0.000    0.179    0.179 device.py:41(<listcomp>) (multiple calls to Device() class)
        5    0.000    0.000    0.179    0.036 device.py:99(__init__) (class Device)

>>> timeit.timeit('Inventory([]).main()', setup='from ceph_volume.inventory import Inventory', number=1)

Device Path               Size         rotates available Model name
/dev/sdb                  200.00 GB    True    True      QEMU HARDDISK
/dev/sda                  200.00 GB    True    False     QEMU HARDDISK
/dev/sdc                  200.00 GB    True    False     QEMU HARDDISK
/dev/sdd                  200.00 GB    True    False     QEMU HARDDISK
/dev/vda                  11.00 GB     True    False
0.2486933789914474
>>>
```

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit bea9f4b643ce32268ad79c0fc257b25ff2f8333c)

ceph-volume: rename _get_pv_paths() in util/device.py

This name is misleading, let's rename it for something clearer.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 325b6f50e88d8ee046fdba0b2bdb17a11577a2f6)

ceph-volume: decrease number of `pvs` calls in `lvm list`

current implementation of `List.create_report()` implies a lot of calls
to `pvs` process. This could be avoided.

current implementation:
```
>>> import timeit
>>> from ceph_volume.devices.lvm.listing import List
>>> timeit.timeit(List([]).main, number=1000)

...

93.03700458299136
```

new implementation:

```
>>> import timeit
>>> from ceph_volume.devices.lvm.listing import List
>>> timeit.timeit(List([]).main, number=1000)

...

62.16391600697534
```

In this example, it improves performance by ~30%

Fixes: https://tracker.ceph.com/issues/56127
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 1a38ea3b96dbe8fd2f2fca8ee9a501ef1423027f)

Merge pull request #46532 from rhcs-dashboard/wip-55753-quincy

quincy: mgr/dashboard: rbd-mirror batch backport

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: melissa-kun-li <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

rbd-fuse: librados will filter out -r option from command-line

The -r option will be filtered out by librados
when exec cmd "rbd-fuse /mountpoint -p pool_name -r rbd_name"
other rbds can be seen under the mount point

Fixes: https://tracker.ceph.com/issues/56387
Signed-off-by: wanwencong <wanwc@chinatelecom.cn>
(cherry picked from commit e99d64bc8a5c3bbb8a3632f211d4f56751cf499e)

doc: update docs for centralized logging

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 4ac2a3e5f764dae9315358d11d7b00e9a08610b1)

Merge pull request #46940 from zdover23/wip-doc-2022-07-03-backport-46938-to-quincy

quincy: doc/dev: add IRC registration instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: add IRC registration instructions

This PR adds to the Developer Guide a link to the OFTC's IRC nick
registration instructions.

(cherry picked from commit 893e68a8f57b22cc025c82586ad0b42da2a6477c)

doc/dev: s/the the/the/ in basic-workflow.rst

This PR does exactly what it says: it changes a "the the"
to a "the".

I'd like to thank Josh Soref for bringing this
to my attention.

(cherry picked from commit 326034807d58fe6569851c043f71a222f59cde5e)

Merge pull request #46792 from adk3798/wip-55992-quincy

quincy: python-common: allow crush device class to be set from osd service spec

Reviewed-by: Cory Snyder <csnyder@iland.com>

Merge pull request #46871 from rhcs-dashboard/wip-56119-quincy

quincy: mgr/dashboard: iterate through copy of items

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

rgw/dbstore: Fix build errors on centos9

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
(cherry picked from commit fc1008a15bc9f7c37330e613f7c81680bc5605fc)

Merge pull request #46819 from rhcs-dashboard/wip-iops-quincy

quincy: mgr/dashboard: iops optimized option enabled

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #46900 from ceph/46773-quincy

install-deps.sh: do not install libpmem from chacra

librbd: make ImageCopyRequest::send_next_object_copy() return void

Make send_object_copies() consistent with handle_object_copy() wrt
calling send_next_object_copy().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 155fabd994f8a2052482d216df1ec0dfb40cb5b7)

librbd: update progress for non-existent objects on deep-copy

As a side effect of commit e5a21e904142 ("librbd: deep-copy image copy
state machine skips clean objects"), handle_object_copy() stopped being
called for non-existent objects.  This broke progress_object_no logic,
which expects to "see" all object numbers so that update_progress()
callback invocations can be ordered.  Currently update_progress() based
progress reporting gets stuck after encountering a hole in the image.

To fix, arrange for handle_object_copy() to be called for all object
numbers, even if ObjectCopyRequest isn't created.  Defer the extra call
to the image work queue to avoid locking issues.

Fixes: https://tracker.ceph.com/issues/56181
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 6813a7879146aec40f204a174b40a5a54e00b780)

Merge pull request #46904 from zdover23/wip-doc-2022-06-30-backport-46984-to-quincy

quincy: doc/index.rst: add link to Dev Guide basic workfl.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/index.rst: add link to Dev Guide basic workfl.

This PR adds a link to the "Basic Workflow" section of the
Developer Guide on the landing page of docs.ceph.com.

This PR is meant to improve the documentation for developers
new to Ceph and to guide them to instructions that will allow
them to become full-fledged contributors to the Ceph project
as quickly as possible.

The "Basic Workflow" page of the Developer Guide contains
information that answers almost all of the questions that I had
about contributing to the Ceph project when I was new to it,
and I am finally acting on my long-held conviction that the
"Basic Workflow" page of the Developer Guide should have a more
prominent position in the documentation suite than it has had.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c624a2a8ef71035eef34ee866ef7668f83a139e7)

install-deps.sh: do not install libpmem from chacra

this change reverts 17d2bc3707bb0078e2fa1b4eef31b39804e45135, before
we recreate a chacra repo hosting libpmem packages, we are not able
to query the repo from shaman or pull the dependencies from chacra.

in future, we should be able to get the libpmem dependencies from
offical ubuntu package repo and fedora, CentOS Stream and RHEL repos.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit fbfb369722fe9f92ad333f8368095637c36c10ec)

Merge pull request #46807 from aaSharma14/wip-56156-quincy

quincy: mgr/dashboard: Add daemon logs tab to Logs component

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46718 from rhcs-dashboard/wip-56076-quincy

quincy: mgr/dashboard: bump moment from 2.29.1 to 2.29.3 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: iterate through copy of items

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit f6de56a02c4f1db557211621f1a369e3f8cff615)

mgr/dashboard: rbd image primary ui

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: fix linting issues

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: Error page cleanup

Some error page cleanups

Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: configure rbd mirroring

One-click button in the case of an orch cluster for configuring the
rbd-mirroring when its not properly setup. This button will create an
rbd-mirror service and also an rbd labelled pool(replicated: size-3) (if they are not
existing)

Fixes: https://tracker.ceph.com/issues/55646
Signed-off-by: Nizamudeen A <nia@redhat.com>
 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/core/error/error.component.html
src/pybind/mgr/dashboard/frontend/src/app/shared/services/module-status-guard.service.ts

This commits had minor conflicts where the addition of dashboardButton
had to be explicitly added and the state of api/orch/status in
module-status-guard had to be updated.

mgr/dashboard: add rbd status endpoint

Show "No RBD pools available" error page when accessing block/rbd if there are no rbd pools.
Add a "button_name" and "button_route" property to `ModuleStatusGuardService` config to customize the button on the error page.
Modify `ModuleStatusGuardService` to execute API calls to `/ui-api/<uiApiPath>/status` which uses the `UIRouter`.

Fixes: https://tracker.ceph.com/issues/42109
Signed-off-by: Melissa Li <melissali@redhat.com>
(cherry picked from commit 6ac9b3cfe171a8902454ea907b3ba37d83eda3dc)

Merge pull request #46528 from rhcs-dashboard/wip-54624-quincy

quincy: mgr/dashboard: BDD approach for the dashboard cephadm e2e

Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>