]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agomgr/dashboard: Show error on creating service with duplicate service id 47403/head
Aashish Sharma [Mon, 25 Jul 2022 08:18:39 +0000 (13:48 +0530)]
mgr/dashboard: Show error on creating service with duplicate service id

Fixes: https://tracker.ceph.com/issues/56689
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 07cfd44193f6ebd552d13325858e8b5b5c131bfb)

2 years agoMerge pull request #47248 from idryomov/wip-56676-quincy
Yuri Weinstein [Mon, 1 Aug 2022 21:58:48 +0000 (14:58 -0700)]
Merge pull request #47248 from idryomov/wip-56676-quincy

quincy: librbd: tweak misleading "image is still primary" error message

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #47162 from idryomov/wip-56549-quincy
Yuri Weinstein [Mon, 1 Aug 2022 21:57:50 +0000 (14:57 -0700)]
Merge pull request #47162 from idryomov/wip-56549-quincy

quincy: librbd: bail from schedule_request_lock() if already lock owner

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #47159 from idryomov/wip-48038-quincy
Yuri Weinstein [Mon, 1 Aug 2022 21:57:09 +0000 (14:57 -0700)]
Merge pull request #47159 from idryomov/wip-48038-quincy

quincy: qa/suites/rbd: disable workunit timeout for dynamic_features_no_cache

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
2 years agoMerge pull request #47144 from idryomov/wip-56561-quincy
Yuri Weinstein [Mon, 1 Aug 2022 21:56:09 +0000 (14:56 -0700)]
Merge pull request #47144 from idryomov/wip-56561-quincy

quincy: rbd: don't default empty pool name unless namespace is specified

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #47129 from idryomov/wip-50734-quincy
Yuri Weinstein [Mon, 1 Aug 2022 21:55:32 +0000 (14:55 -0700)]
Merge pull request #47129 from idryomov/wip-50734-quincy

quincy: qa/suites/rbd/pwl-cache: ensure recovery is actually tested

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #47126 from idryomov/wip-56516-quincy
Yuri Weinstein [Mon, 1 Aug 2022 21:54:23 +0000 (14:54 -0700)]
Merge pull request #47126 from idryomov/wip-56516-quincy

quincy: rbd-mirror: remove bogus completed_non_primary_snapshots_exist check

Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agoMerge pull request #47297 from aclamk/wip-56668-quincy
Yuri Weinstein [Mon, 1 Aug 2022 17:23:01 +0000 (10:23 -0700)]
Merge pull request #47297 from aclamk/wip-56668-quincy

quincy: os/bluestore: Fix collision between BlueFS and BlueStore deferred writes

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2 years agoMerge pull request #47344 from ceph/quincy-release
Ilya Dryomov [Mon, 1 Aug 2022 16:56:34 +0000 (18:56 +0200)]
Merge pull request #47344 from ceph/quincy-release

v17.2.3

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #47391 from adk3798/quincy-fix-flake8
Ilya Dryomov [Mon, 1 Aug 2022 16:34:03 +0000 (18:34 +0200)]
Merge pull request #47391 from adk3798/quincy-fix-flake8

quincy: pybind/mgr: fix flake8

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agorbd-mirror: remove bogus completed_non_primary_snapshots_exist check 47126/head
Ilya Dryomov [Sat, 9 Jul 2022 11:35:04 +0000 (13:35 +0200)]
rbd-mirror: remove bogus completed_non_primary_snapshots_exist check

This check was added in commit ecd3778a6f9a ("rbd-mirror: ensure that
the last non-primary snapshot cannot be pruned") as an additional
safeguard against pruning an incomplete non-primary snapshot in case
there is no predecessor mirror snapshot.  However it still fires if the
predecessor is there but happens to be a primary demotion snapshot.
A bogus "incomplete local non-primary snapshot" error is reported and
the replayer gets stuck.

Remove completed_non_primary_snapshots_exist tracking as the presence
of the predecessor in the incomplete non-primary snapshot pruning arm
is already ensured by "m_local_snap_id_start > 0" condition.

Fixes: https://tracker.ceph.com/issues/56516
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit a581509381ba84b49c906a1fe440ca3ddcab418c)

2 years agotest/rbd-mirror: add last_copied_object_number == 0 coverage
Ilya Dryomov [Fri, 8 Jul 2022 17:15:48 +0000 (19:15 +0200)]
test/rbd-mirror: add last_copied_object_number == 0 coverage

Incomplete non-primary snapshot handling is bifurcated depending
on whether any data objects have been copied.  If no data objects
have been copied, an incomplete non-primary snapshot is assumed to
be malformed and gets pruned; the sync is restarted from scratch.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 13aa47ae2ee89babca7571165ac88eaa665d2fc0)

2 years agoqa/tasks: rename persistent write log cache trash task 47129/head
Ilya Dryomov [Sat, 16 Jul 2022 06:54:38 +0000 (08:54 +0200)]
qa/tasks: rename persistent write log cache trash task

It doesn't really thrash anything, just repeatedly restarts the
workload on top of a dirty cache file.  rbd_pwl_cache_recovery is
more on point and gets covered by existing CODEOWNERS.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2de0574382e2c1c63f20745d6870ac7f82b27b9f)

2 years agoqa/tasks: add thrash test for persistent write log cache
Yin Congmin [Fri, 7 Jan 2022 07:03:44 +0000 (15:03 +0800)]
qa/tasks: add thrash test for persistent write log cache

add thrash test for persistent write log cache. run rbd bench
on persistent write log cache, thrashes rbd bench, test the
recovery function of persistent write log cache.

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
(cherry picked from commit 0eab8de3c017d8318bd6c846991bb3f7c51fa97d)

2 years agorbd: drop unused default_empty_pool_name argument 47144/head
Ilya Dryomov [Thu, 14 Jul 2022 12:42:45 +0000 (14:42 +0200)]
rbd: drop unused default_empty_pool_name argument

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 365300f253fd8066ae6f8cbd36c94ff4b145ab8d)

2 years agorbd: don't default empty pool name unless namespace is specified
Ilya Dryomov [Thu, 14 Jul 2022 12:19:06 +0000 (14:19 +0200)]
rbd: don't default empty pool name unless namespace is specified

Commit 96f05a7956b3 ("rbd: delay determination of default pool name")
broke "rbd perf image iostat" and "rbd perf image iotop" GLOBAL_POOL_KEY
support (the ability to blend all rbd pools together into a single
view).

Fixes: https://tracker.ceph.com/issues/56561
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b2137e205862e6cfc316c11036266da65a78d26d)

2 years agoqa/suites/rbd: disable workunit timeout for dynamic_features_no_cache 47159/head
Ilya Dryomov [Fri, 20 May 2022 12:05:03 +0000 (14:05 +0200)]
qa/suites/rbd: disable workunit timeout for dynamic_features_no_cache

The I/O workload in this test is xfstests (qa/run_xfstests_qemu.sh)
which isn't subjected to any timeout other than global max_job_time
limit in any other subsuite (e.g. qemu/workloads/qemu_xfstests.yaml).
But here, there is a parallel "op" workload defined as a workunit.
The workunit task has a default timeout of 3 hours which is effectively
imposed on the entire job.  In the "rbd cache = false" configuration,
it's sometimes exceeded.

Fixes: https://tracker.ceph.com/issues/48038
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0a6a70760a6f771b848852e0779a221e22c8775d)

2 years agolibrbd: bail from schedule_request_lock() if already lock owner 47162/head
Christopher Hoffman [Thu, 14 Jul 2022 18:20:29 +0000 (12:20 -0600)]
librbd: bail from schedule_request_lock() if already lock owner

Race condition may be hit if there are multiple pending locks for the
same image and pending callbacks. Abort exclusive lock process if
already exclusive lock owner.

Fixes: https://tracker.ceph.com/issues/56549
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
(cherry picked from commit 3527d2c764626c09c5ede80ae844551fd8845756)

2 years agolibrbd: tweak misleading "image is still primary" error message 47248/head
Ilya Dryomov [Fri, 22 Jul 2022 13:23:57 +0000 (15:23 +0200)]
librbd: tweak misleading "image is still primary" error message

m_promotion_state == PROMOTION_STATE_NON_PRIMARY doesn't say anything
about the remote image.  It could still be primary but it could also be
demoted.

Fixes: https://tracker.ceph.com/issues/56676
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 95dd89b4d771a8e01ce52beecc701548bf8321e8)

2 years agomgr/cephadm: fix flake8 47391/head
Avan Thakkar [Mon, 1 Aug 2022 09:23:14 +0000 (14:53 +0530)]
mgr/cephadm: fix flake8

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit a124f6c47b119a8741f347ea5a809f3fb48d6679)

2 years agoMerge pull request #44641 from rzarzynski/wip-bs-lazy4freebsd-quincy
Kefu Chai [Sat, 30 Jul 2022 02:00:47 +0000 (10:00 +0800)]
Merge pull request #44641 from rzarzynski/wip-bs-lazy4freebsd-quincy

quincy: bdev: fix FTBFS on FreeBSD, keep the huge paged read buffers.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agobdev: fix FTBFS on FreeBSD, keep the huge paged read buffers. 44641/head
Radoslaw Zarzynski [Mon, 17 Jan 2022 14:55:05 +0000 (14:55 +0000)]
bdev: fix FTBFS on FreeBSD, keep the huge paged read buffers.

Special thanks to Willem Jan Withagen!

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit d04ea43cfd0a834f470677d17a15d9c9d5c1c2e7)

2 years agoMerge pull request #47359 from zdover23/wip-doc-2022-07-29-backport-47347-to-quincy
zdover23 [Fri, 29 Jul 2022 13:13:36 +0000 (23:13 +1000)]
Merge pull request #47359 from zdover23/wip-doc-2022-07-29-backport-47347-to-quincy

quincy: doc/radosgw: Uppercase s3

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/radosgw: make s3 uppercase 47359/head
Anthony D'Atri [Fri, 29 Jul 2022 07:11:22 +0000 (00:11 -0700)]
doc/radosgw: make s3 uppercase

s/s3/S3/

(cherry picked from commit 73f0d5707d275529416d5110160b9ff5ead23d22)

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years ago17.2.3 47344/head v17.2.3
Ceph Release Team [Thu, 28 Jul 2022 21:52:12 +0000 (21:52 +0000)]
17.2.3

Signed-off-by: Ceph Release Team <ceph-maintainers@ceph.io>
2 years agoMerge pull request #47270 from vumrao/wip-vumrao-56702
Neha Ojha [Thu, 28 Jul 2022 21:49:26 +0000 (14:49 -0700)]
Merge pull request #47270 from vumrao/wip-vumrao-56702

quincy: libcephsqlite: ceph-mgr crashes when compiled with gcc12

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agolibcephsqlite: ceph-mgr crashes when compiled with gcc12
Ganesh Maharaj Mahalingam [Mon, 11 Apr 2022 17:15:43 +0000 (10:15 -0700)]
libcephsqlite: ceph-mgr crashes when compiled with gcc12

regex in libcephsqlite, when compiled with GCC12 treats '-' as a range
operator resulting in the following error.
"Invalid start of '[x-x]' range in regular expression"

Fixes: https://tracker.ceph.com/issues/55304
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
(cherry picked from commit ac043a09c5ffb4b434b8644920004b3d5b7f9d8c)
(cherry picked from commit 5a10875d4570356afa3af024f63ac229caaa765b)

2 years agoos/bluestore: Fix deferred writes corrupting RocksDB 47297/head
Adam Kupczyk [Wed, 29 Jun 2022 08:31:43 +0000 (10:31 +0200)]
os/bluestore: Fix deferred writes corrupting RocksDB

Deferred writes can sometimes update regions that are no longer mapped to any object.
This cannot happen when BlueStore is running, as blobs are being held,
and allocations are not released until deferred op is executed.
However in case of restart allocations that deferred is targetting are already freed.
Deferred replay is done on BlueStore bootup, before any new object can be allocated,
so no collision with object is possible.
But BlueFS can allocate space from block with deferred ops still pending.

Fixes: https://tracker.ceph.com/issues/54547
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit 2afb951a490aac9ca4d01614867396cbd06b793d)

Conflicts: src/os/bluestore/BlueStore.cc
Modified non-critical BlueFS call foreach_block_extents to get_block_extents.

2 years agocommon/interval_set: Add operator-- to iterator
Adam Kupczyk [Wed, 29 Jun 2022 08:28:37 +0000 (10:28 +0200)]
common/interval_set: Add operator-- to iterator

Only ++ was allowed. Extend iterator manipulation to -- too.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit 58860ce3f60489d258aaa10fd783e68083261937)

2 years agotest/objectstore: Add test for deferred writes
Adam Kupczyk [Mon, 27 Jun 2022 12:50:10 +0000 (12:50 +0000)]
test/objectstore: Add test for deferred writes

Add test that recreates situation when BlueStore deferred writes
can cause RocksDB files corruption.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit 42de47ae8468d000d5bca62bd537d7a1028bae42)

2 years agolibcephsqlite: ceph-mgr crashes when compiled with gcc12 47270/head
Ganesh Maharaj Mahalingam [Mon, 11 Apr 2022 17:15:43 +0000 (10:15 -0700)]
libcephsqlite: ceph-mgr crashes when compiled with gcc12

regex in libcephsqlite, when compiled with GCC12 treats '-' as a range
operator resulting in the following error.
"Invalid start of '[x-x]' range in regular expression"

Fixes: https://tracker.ceph.com/issues/55304
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
(cherry picked from commit ac043a09c5ffb4b434b8644920004b3d5b7f9d8c)

2 years agoMerge pull request #47283 from zdover23/wip-doc-2022-07-27-backport-47082-to-quincy
zdover23 [Tue, 26 Jul 2022 16:34:37 +0000 (02:34 +1000)]
Merge pull request #47283 from zdover23/wip-doc-2022-07-27-backport-47082-to-quincy

quincy: doc, crimson: document installing crimson with cephadm

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc, crimson: document installing crimson with cephadm 47283/head
Radosław Zarzyński [Wed, 13 Jul 2022 12:33:06 +0000 (14:33 +0200)]
doc, crimson: document installing crimson with cephadm

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 60b8348a843ffaaf475453611a8235d6f892093a)

2 years agoMerge pull request #47222 from ceph/1722
David Galloway [Fri, 22 Jul 2022 20:16:32 +0000 (16:16 -0400)]
Merge pull request #47222 from ceph/1722

v17.2.2

2 years agoqa: Remove unused variable 47222/head
Kotresh HR [Fri, 22 Jul 2022 13:50:33 +0000 (19:20 +0530)]
qa: Remove unused variable

Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit c8416c3f0e15e49dde4b9bca6f732231d9b5d16b)

2 years agoMerge pull request #46805 from nmshelke/wip-56103-quincy
Yuri Weinstein [Fri, 22 Jul 2022 12:13:03 +0000 (05:13 -0700)]
Merge pull request #46805 from nmshelke/wip-56103-quincy

quincy: mgr/volumes: subvolume ls command crashes if groupname as '_nogroup'

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge pull request #46804 from nmshelke/wip-56108-quincy
Yuri Weinstein [Fri, 22 Jul 2022 12:11:56 +0000 (05:11 -0700)]
Merge pull request #46804 from nmshelke/wip-56108-quincy

quincy: mgr/volumes: remove incorrect 'size' from output of 'snapshot info'

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #46667 from nmshelke/wip-56013-quincy
Yuri Weinstein [Fri, 22 Jul 2022 12:10:30 +0000 (05:10 -0700)]
Merge pull request #46667 from nmshelke/wip-56013-quincy

quincy: mgr/volumes: subvolumegroup quotas

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #46647 from rhcs-dashboard/wip-54578-quincy
Yuri Weinstein [Fri, 22 Jul 2022 12:09:32 +0000 (05:09 -0700)]
Merge pull request #46647 from rhcs-dashboard/wip-54578-quincy

quincy: Add mapping for ernno:13 and adding path in error msg in opendir()/cephfs.pyx

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #46563 from neesingh-rh/wip-55936-quincy
Yuri Weinstein [Fri, 22 Jul 2022 12:07:39 +0000 (05:07 -0700)]
Merge pull request #46563 from neesingh-rh/wip-55936-quincy

quincy: client: Inode::hold_caps_until is time from monotonic clock now.

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #46827 from ceph/quincy-release
David Galloway [Fri, 22 Jul 2022 01:16:14 +0000 (21:16 -0400)]
Merge pull request #46827 from ceph/quincy-release

v17.2.1

2 years ago17.2.2 v17.2.2
Jenkins Build Slave User [Thu, 21 Jul 2022 17:29:33 +0000 (17:29 +0000)]
17.2.2

2 years agorgw: s3website check for bucket before retargeting
Seena Fallah [Fri, 1 Jul 2022 21:19:40 +0000 (23:19 +0200)]
rgw: s3website check for bucket before retargeting

On requesting s3website API without a bucket name it will crash because s->bucket is null

Fixes: https://tracker.ceph.com/issues/56281
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 933dbabb3a2a43fd016bc61cc0ee5e27f7ad32e7)
(cherry picked from commit e2b923600c28626b921107c13e2c12d691eed3f1)

2 years agoqa: validate subvolume discover on upgrade
Kotresh HR [Fri, 4 Feb 2022 09:58:39 +0000 (15:28 +0530)]
qa: validate subvolume discover on upgrade

Validate subvolume discover on upgrade from
legacy subvolume to v1. The handcrafted
".meta" file on legacy subvolume root should
not be used for any subvolume apis like getpath,
authorize.

Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit fcc118500c545fe6018cd3f2742127b92c657def)
(cherry picked from commit 7e6453d32f78e4a02771396c96dcba472f275135)

2 years agomgr/volumes: V2 Fix for test_subvolume_retain_snapshot_invalid_recreate
Kotresh HR [Thu, 9 Jun 2022 08:00:59 +0000 (13:30 +0530)]
mgr/volumes: V2 Fix for test_subvolume_retain_snapshot_invalid_recreate

Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit ac791879096c8a9e5bda4eef69f1269eee819932)

2 years agomgr/volumes: Fix subvolume discover during upgrade
Kotresh HR [Fri, 4 Feb 2022 09:25:03 +0000 (14:55 +0530)]
mgr/volumes: Fix subvolume discover during upgrade

Fixes the subvolume discover to use the correct
metadata file after an upgrade from legacy subvolume
to v1. The fix makes sure, it doesn't use the
handcrafted metadata file placed in the subvolume
root of legacy subvolume.

Co-authored-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Co-authored-by: Dan van der Ster <daniel.vanderster@cern.ch>
Co-authored-by: Ramana Raja <rraja@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 7eba9cab6cfb9a13a84062177d7a0fa228311e13)
(cherry picked from commit 50f4ac7b75185c89ede210b2c975672e8bdd73aa)

2 years agoMerge pull request #46738 from trociny/wip-56096-quincy
Yuri Weinstein [Wed, 20 Jul 2022 20:57:16 +0000 (13:57 -0700)]
Merge pull request #46738 from trociny/wip-56096-quincy

quincy: mgr: relax "pending_service_map.epoch > service_map.epoch" assert

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #46872 from ronen-fr/wip-rf-46860-quincy
Yuri Weinstein [Wed, 20 Jul 2022 16:42:35 +0000 (09:42 -0700)]
Merge pull request #46872 from ronen-fr/wip-rf-46860-quincy

Quincy: osd/scrub: late-arriving reservation grants are not an error

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #46844 from ronen-fr/wip-rf-46727-quincy
Yuri Weinstein [Wed, 20 Jul 2022 16:41:59 +0000 (09:41 -0700)]
Merge pull request #46844 from ronen-fr/wip-rf-46727-quincy

Quincy: osd/scrubber/pg_scrubber.cc: fix bug where scrub machine gets stuck

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #46689 from sseshasa/wip-56060-quincy
Yuri Weinstein [Wed, 20 Jul 2022 16:40:39 +0000 (09:40 -0700)]
Merge pull request #46689 from sseshasa/wip-56060-quincy

quincy: mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #46498 from ronen-fr/wip-rf-46440-quincy
Yuri Weinstein [Wed, 20 Jul 2022 16:39:53 +0000 (09:39 -0700)]
Merge pull request #46498 from ronen-fr/wip-rf-46440-quincy

quincy: osd/scrub: do not start scrubbing if the PG is snap-trimming

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #47156 from rhcs-dashboard/wip-56616-quincy
Nizamudeen A [Wed, 20 Jul 2022 06:34:08 +0000 (12:04 +0530)]
Merge pull request #47156 from rhcs-dashboard/wip-56616-quincy

quincy: mgr/dashboard: do not recommend throughput for ssd's only cluster

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
3 years agomgr/dashboard: do not recommend throughput for ssd's only cluster 47156/head
Nizamudeen A [Mon, 18 Jul 2022 05:38:28 +0000 (11:08 +0530)]
mgr/dashboard: do not recommend throughput for ssd's only cluster

This is just a bug fix where we recommend the throughput option even if
there are only ssd's are present in the cluster.

Fixes: https://tracker.ceph.com/issues/56413
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 0f6f79f1d9c716e13f662151459fa107f651f158)

3 years agoMerge pull request #47094 from rhcs-dashboard/wip-56547-quincy
Pedro Gonzalez Gomez [Tue, 19 Jul 2022 07:00:26 +0000 (09:00 +0200)]
Merge pull request #47094 from rhcs-dashboard/wip-56547-quincy

quincy: mgr/dashboard: don't log tracebacks on 404s

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
3 years agoMerge pull request #47146 from s0nea/wip-56593-quincy
Pedro Gonzalez Gomez [Mon, 18 Jul 2022 14:15:01 +0000 (16:15 +0200)]
Merge pull request #47146 from s0nea/wip-56593-quincy

quincy: mgr/dashboard: prevent alert redirect

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: prevent alert redirect 47146/head
Tatjana Dehler [Thu, 7 Jul 2022 15:21:14 +0000 (17:21 +0200)]
mgr/dashboard: prevent alert redirect

Prevent Alertmanager alerts from being redirected to the active mgr
dashboard instance. There are two reasons for it:

1. It doesn't bring any additional benefit. The Alertmanager config
   includes all available mgr instances - active and passive ones. In
   case of an alert, it will be sent to all of them. It ensures that
   the active mgr dashboard will receive the alert in any case.
2. The redirect URL includes the mgr IP and NOT the FQDN. This leads
   to issues in environments where an SSL certificate is configured and
   matches the FQDNs, only.

Fixes: https://tracker.ceph.com/issues/56401
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 965005e0789e566ccadce7a326b0e197ab8d7f5f)

3 years agoMerge pull request #47071 from adk3798/wip-56475-quincy
Guillaume Abrioux [Mon, 18 Jul 2022 07:15:39 +0000 (09:15 +0200)]
Merge pull request #47071 from adk3798/wip-56475-quincy

quincy: cephadm: improve message when removing osd

3 years agoMerge pull request #46966 from guits/wip-56471-quincy
Guillaume Abrioux [Mon, 18 Jul 2022 07:14:24 +0000 (09:14 +0200)]
Merge pull request #46966 from guits/wip-56471-quincy

quincy: ceph-volume: decrease number of `pvs` calls in `lvm list`

3 years agoMerge pull request #46968 from guits/wip-56471-2-quincy
Guillaume Abrioux [Mon, 18 Jul 2022 07:14:05 +0000 (09:14 +0200)]
Merge pull request #46968 from guits/wip-56471-2-quincy

quincy: ceph-volume: avoid unnecessary subprocess calls

3 years agoMerge pull request #47072 from adk3798/wip-56474-quincy
Adam King [Sat, 16 Jul 2022 19:41:18 +0000 (15:41 -0400)]
Merge pull request #47072 from adk3798/wip-56474-quincy

quincy: pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
3 years agoMerge pull request #47070 from adk3798/wip-56494-quincy
Adam King [Sat, 16 Jul 2022 18:55:36 +0000 (14:55 -0400)]
Merge pull request #47070 from adk3798/wip-56494-quincy

quincy: mgr/cephadm: limiting ingress/keepalived pass to 8 chars

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #47123 from zdover23/wip-doc-2022-07-16-backport-47109-to-quincy
zdover23 [Sat, 16 Jul 2022 18:46:13 +0000 (04:46 +1000)]
Merge pull request #47123 from zdover23/wip-doc-2022-07-16-backport-47109-to-quincy

quincy: doc/start: update hardware recs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #47069 from adk3798/wip-56501-quincy
Adam King [Sat, 16 Jul 2022 18:36:39 +0000 (14:36 -0400)]
Merge pull request #47069 from adk3798/wip-56501-quincy

quincy: ceph.spec: fixing cephadm build deps

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #47073 from adk3798/wip-56454-quincy
Adam King [Sat, 16 Jul 2022 18:33:20 +0000 (14:33 -0400)]
Merge pull request #47073 from adk3798/wip-56454-quincy

quincy: mgr/cephadm: fixing scheduler consistent hashing

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #47075 from adk3798/wip-56177-quincy
Adam King [Sat, 16 Jul 2022 18:32:32 +0000 (14:32 -0400)]
Merge pull request #47075 from adk3798/wip-56177-quincy

quincy: mgr/cephadm: use host shortname for osd memory autotuning

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #47085 from rhcs-dashboard/wip-56545-quincy
Nizamudeen A [Sat, 16 Jul 2022 13:58:12 +0000 (19:28 +0530)]
Merge pull request #47085 from rhcs-dashboard/wip-56545-quincy

quincy: mgr/dashboard: ingress backend service should list all supported services

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agodoc/start: update hardware recs 47123/head
Zac Dover [Thu, 14 Jul 2022 19:29:11 +0000 (05:29 +1000)]
doc/start: update hardware recs

This PR picks up the parts of
https://github.com/ceph/ceph/pull/44466
that were not merged back in January, when that
pull request was raised.

Matters added here:
* improved organzation of matter
* emphasis of IOPs per core over cores per OSD

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 29c44a3bd6919f7fc23083d75d22e84c8b51e1c1)

3 years agoMerge pull request #46954 from idryomov/wip-56387-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:29:51 +0000 (09:29 -0700)]
Merge pull request #46954 from idryomov/wip-56387-quincy

quincy: rbd-fuse: librados will filter out -r option from command-line

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
3 years agoMerge pull request #46910 from idryomov/wip-rbd-deep-copy-progress-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:29:02 +0000 (09:29 -0700)]
Merge pull request #46910 from idryomov/wip-rbd-deep-copy-progress-quincy

quincy: librbd: update progress for non-existent objects on deep-copy

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #46814 from idryomov/wip-rbd-mirror-remote-not-primary-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:28:31 +0000 (09:28 -0700)]
Merge pull request #46814 from idryomov/wip-rbd-mirror-remote-not-primary-quincy

quincy: rbd-mirror: generally skip replay/resync if remote image is not primary

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #46742 from mkogan1/backport-quincy-t54363
Yuri Weinstein [Fri, 15 Jul 2022 16:27:43 +0000 (09:27 -0700)]
Merge pull request #46742 from mkogan1/backport-quincy-t54363

quincy: rgwlc: fix segfault resharding during lc

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46625 from cfsnyder/wip-55997-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:27:11 +0000 (09:27 -0700)]
Merge pull request #46625 from cfsnyder/wip-55997-quincy

quincy: rgw: reopen ops log file on sighup

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #46781 from idryomov/wip-rbd-schedule-backports-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:26:18 +0000 (09:26 -0700)]
Merge pull request #46781 from idryomov/wip-rbd-schedule-backports-quincy

quincy: mirror snapshot schedule and trash purge schedule fixes

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agoMerge pull request #46624 from cfsnyder/wip-55999-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:24:41 +0000 (09:24 -0700)]
Merge pull request #46624 from cfsnyder/wip-55999-quincy

quincy: rgw: log access key id in ops logs

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #46598 from idryomov/wip-qa-rwl-on-tmpfs-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:23:40 +0000 (09:23 -0700)]
Merge pull request #46598 from idryomov/wip-qa-rwl-on-tmpfs-quincy

quincy: qa/suites/rbd: place cache file on tmpfs for xfstests

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #46594 from idryomov/wip-rbd-unlink-newest-snap-at-capacity-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:22:59 +0000 (09:22 -0700)]
Merge pull request #46594 from idryomov/wip-rbd-unlink-newest-snap-at-capacity-quincy

quincy: librbd: unlink newest mirror snapshot when at capacity, bump capacity

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agoMerge pull request #46591 from idryomov/wip-rbd-preserve-non-primary-snap-quincy
Yuri Weinstein [Fri, 15 Jul 2022 16:20:36 +0000 (09:20 -0700)]
Merge pull request #46591 from idryomov/wip-rbd-preserve-non-primary-snap-quincy

quincy: rbd-mirror: don't prune non-primary snapshot when restarting delta sync

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
3 years agoMerge pull request #46801 from lxbsz/wip-56106
Yuri Weinstein [Fri, 15 Jul 2022 14:43:15 +0000 (07:43 -0700)]
Merge pull request #46801 from lxbsz/wip-56106

quincy: qa: wait rank 0 to become up:active state before mounting fuse client

Reviewed-by: Rishabh Dave <ridave@redhat.com>
3 years agoMerge pull request #46800 from lxbsz/wip-56109
Yuri Weinstein [Fri, 15 Jul 2022 14:42:45 +0000 (07:42 -0700)]
Merge pull request #46800 from lxbsz/wip-56109

quincy: client: choose auth MDS for getxattr with the Xs caps

Reviewed-by: Rishabh Dave <ridave@redhat.com>
3 years agoMerge pull request #46697 from NitzanMordhai/wip-54282-quincy
Yuri Weinstein [Fri, 15 Jul 2022 14:42:09 +0000 (07:42 -0700)]
Merge pull request #46697 from NitzanMordhai/wip-54282-quincy

quincy: pybind/mgr: ceph osd status crash with ZeroDivisionError

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #46681 from lxbsz/wip-56015
Yuri Weinstein [Fri, 15 Jul 2022 14:41:18 +0000 (07:41 -0700)]
Merge pull request #46681 from lxbsz/wip-56015

Quincy: mds: clear MDCache::rejoin_*_q queues before recovering file inodes

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
3 years agoMerge pull request #46680 from lxbsz/wip-55994
Yuri Weinstein [Fri, 15 Jul 2022 14:40:23 +0000 (07:40 -0700)]
Merge pull request #46680 from lxbsz/wip-55994

Quincy: client: switch AT_NO_ATTR_SYNC to AT_STATX_DONT_SYNC

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
3 years agoMerge pull request #46595 from kotreshhr/wip-55926-quincy
Yuri Weinstein [Fri, 15 Jul 2022 14:39:29 +0000 (07:39 -0700)]
Merge pull request #46595 from kotreshhr/wip-55926-quincy

quincy: client/fuse: Fix directory DACs overriding for root

Reviewed-by: Rishabh Dave <ridave@redhat.com>
3 years agoMerge pull request #46566 from vshankar/tr-55933
Yuri Weinstein [Fri, 15 Jul 2022 14:39:03 +0000 (07:39 -0700)]
Merge pull request #46566 from vshankar/tr-55933

quincy: mds: do not assert early on when issuing client leases

Reviewed-by: Rishabh Dave <ridave@redhat.com>
3 years agoMerge pull request #46558 from lxbsz/wip-55934
Yuri Weinstein [Fri, 15 Jul 2022 14:37:50 +0000 (07:37 -0700)]
Merge pull request #46558 from lxbsz/wip-55934

Quincy:  client: always return ESTALE directly in handle_reply

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
3 years agoMerge pull request #47102 from adk3798/quincy-osd-removal-docs-update
Adam King [Thu, 14 Jul 2022 17:27:28 +0000 (13:27 -0400)]
Merge pull request #47102 from adk3798/quincy-osd-removal-docs-update

quincy: doc/cephadm: add note about OSDs being recreated to OSD removal section

Reviewed-by: <Anthony D'Atri anthonyeleven@users.noreply.github.com>
3 years agodoc/cephadm: add note about OSDs being recreated to OSD removal section 47102/head
Adam King [Tue, 12 Jul 2022 20:54:19 +0000 (16:54 -0400)]
doc/cephadm: add note about OSDs being recreated to OSD removal section

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d4a39cd046b93cb7bb5b7ce0311139d9f6552802)

3 years agomgr/dashboard: don't log tracebacks on 404s 47094/head
Ernesto Puerta [Wed, 29 Jun 2022 18:09:21 +0000 (20:09 +0200)]
mgr/dashboard: don't log tracebacks on 404s

Currently we're logging tracebacks on expected request errors as 404,
401, etc. This may cause confusion to users, which might think that
something really wrong was happening there.

This should be extended to many DashboardExceptions that simply return
expected HTTP error codes (403, 415, 3xx, etc).

Fixes: https://tracker.ceph.com/issues/55720
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit 3928fe91a4b8c313a52e38cab9ba31e54ff1ae51)

3 years agomgr/dashboard: ingress backend service should list all supported services 47085/head
Avan Thakkar [Wed, 6 Jul 2022 09:24:26 +0000 (14:54 +0530)]
mgr/dashboard: ingress backend service should list all supported services

Fixes: https://tracker.ceph.com/issues/56478
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 32118522cb71722c3cc20a1e1a9ca9ffdf7897e4)

3 years agoMerge pull request #47077 from adk3798/wip-56159-quincy
Adam King [Wed, 13 Jul 2022 16:00:08 +0000 (12:00 -0400)]
Merge pull request #47077 from adk3798/wip-56159-quincy

quincy: doc/cephadm: Add post-upgrade section

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #47076 from adk3798/wip-56171-quincy
Adam King [Wed, 13 Jul 2022 15:58:57 +0000 (11:58 -0400)]
Merge pull request #47076 from adk3798/wip-56171-quincy

quincy: doc/cephadm: document the new per-fsid cephadm conf location

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #47074 from adk3798/wip-56437-quincy
Adam King [Wed, 13 Jul 2022 15:57:18 +0000 (11:57 -0400)]
Merge pull request #47074 from adk3798/wip-56437-quincy

quincy: doc/cephadm: enhancing daemon operations documentation

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agoMerge pull request #47068 from adk3798/wip-56505-quincy
Adam King [Wed, 13 Jul 2022 15:55:04 +0000 (11:55 -0400)]
Merge pull request #47068 from adk3798/wip-56505-quincy

quincy: doc/cephadm/services: the config section of service specs

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
3 years agodoc/cephadm: Add post-upgrade section 47077/head
Redouane Kachach [Thu, 16 Jun 2022 14:28:30 +0000 (16:28 +0200)]
doc/cephadm: Add post-upgrade section
Fixes: https://tracker.ceph.com/issues/54474
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 49b234ae744dd3a2afc130d9c215f4f00c1ee4b8)

3 years agodoc/cephadm: document the new per-fsid cephadm conf location 47076/head
Redouane Kachach [Mon, 23 May 2022 09:14:05 +0000 (11:14 +0200)]
doc/cephadm: document the new per-fsid cephadm conf location
Fixes: https://tracker.ceph.com/issues/55357
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 443f93e95d8068a31526730da0febd692b87b7a5)

3 years agomgr/cephadm: use hostname from crush map for osd memory autotuning 47075/head
Adam King [Fri, 3 Jun 2022 01:32:53 +0000 (21:32 -0400)]
mgr/cephadm: use hostname from crush map for osd memory autotuning

Fixes: https://tracker.ceph.com/issues/55841
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 50f28aa56edd348c3816335bef3bbfaf5133ae54)

3 years agodoc/cephadm: enhancing daemon operations documentation 47074/head
Redouane Kachach [Wed, 15 Jun 2022 10:35:30 +0000 (12:35 +0200)]
doc/cephadm: enhancing daemon operations documentation
Fixes: https://tracker.ceph.com/issues/54399
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit df1aaacb7d09322528e42ae90c0d98793e9c254e)

3 years agomgr/cephadm: fixing E128 warning 47073/head
Redouane Kachach [Wed, 29 Jun 2022 15:03:10 +0000 (17:03 +0200)]
mgr/cephadm: fixing E128 warning

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit e37924c623d797b3118ddd9a804818432a5704dd)

3 years agomgr/cephadm: fixing scheduler consistent hashing
Redouane Kachach [Tue, 28 Jun 2022 13:32:19 +0000 (15:32 +0200)]
mgr/cephadm: fixing scheduler consistent hashing

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 5d5829cd370e9278cb8b70d6426094e595badb5d)

3 years agopybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure 47072/head
dparmar18 [Tue, 14 Jun 2022 20:30:48 +0000 (02:00 +0530)]
pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Fixes: https://tracker.ceph.com/issues/56024
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 6436acc4b51b52635f8fa0e56cd79ba66c028d81)