librados: rados_ioctx_destroy check for initialized ioctx

If rados_ioctx_destroy called with un-initilized ioctx we will hit segmented fault
checking ioctx before calling put will prevent that.

Fixes: https://tracker.ceph.com/issues/55001
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
(cherry picked from commit e465cfc62ae0f982edb60291c67f4d76a71efd15)

Merge pull request #47443 from ceph/pacific-rtd

pacific: .readthedocs.yml: Always build latest doc/releases pages

.readthedocs.yml: Always build latest doc/releases pages

We don't backport PRs merged into doc/releases.  Therefore, when one browses to an older Ceph release version on docs.ceph.com (e.g., https://docs.ceph.com/en/pacific/), the information is out of date at best.

The doc/releases page is only accurate if browsing https://docs.ceph.com/en/latest/, for example.

So this post_checkout command will make sure we've checked out doc/releases from main before building and publishing.

Signed-off-by: David Galloway <dgallowa@redhat.com>
(cherry picked from commit 055fe1f825b0629b7685d6d3d4d629ffc37a2d7c)

Merge pull request #47375 from adk3798/wip-56985-pacific

pacific: mgr/cephadm: clear error message when resuming upgrade

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #47376 from adk3798/wip-56984-pacific

pacific: cephadm: Fix repo_gpgkey should return 2 vars

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #47271 from vumrao/wip-vumrao-56701

pacific: libcephsqlite: ceph-mgr crashes when compiled with gcc12

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #47416 from zdover23/wip-doc-2022-08-03-backport-47197-to-pacific

pacific: doc/dev: Elaborate on boost .deb creation

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47296 from aclamk/wip-56669-pacific

pacific: os/bluestore: Fix collision between BlueFS and BlueStore deferred writes

doc/dev: Elaborate on boost .deb creation

Signed-off-by: David Galloway <dgallowa@redhat.com>
(cherry picked from commit 3222485d6582ba6ab3ee908c13b6459c2e2b6302)

Merge pull request #47304 from cbodley/wip-56731

pacific: rgw/rgw_string.h: add missing includes for alpine and boost 1.75

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #47393 from adk3798/pacific-fix-flake8

pacific: pybind/mgr: fix flake8

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

mgr/cephadm: fix flake8

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit a124f6c47b119a8741f347ea5a809f3fb48d6679)

cephadm: ceph.manual.gpg cleanup

Cleanup file /etc/apt/trusted.gpg.d/ceph.manual.gpg when repo is removed

Signed-off-by: Laurent Barbe <laurent@ksperis.com>
(cherry picked from commit bf0951353a80dc17edcc85a7914cfaf2b956d544)

cephadm: Fix repo_gpgkey should return 2 vars

when option --gpg-url is specified, the name used for the gpg filename is missing and throws an exception
this adds the string "manual" to the gpg key : /etc/apt/trusted.gpg.d/ceph.manual.gpg

Fixes: https://tracker.ceph.com/issues/56950
Signed-off-by: Laurent Barbe <laurent@ksperis.com>
(cherry picked from commit 79c805546c9bf4747a9019f4ad59f55e03c9fcef)

mgr/cephadm: clear error message when resuming upgrade

the message field in the output of "ceph orch upgrade status"
will first take the value of the error field of the UpgradeState,
and if only if it blank/None, display an info string we periodically
update throughout the upgrade with useful info such as that
we're upgrading a daemon of a particular type or pulling an image
on a certain host. When an upgrade fails, we set the error field
of the UpgradeState, pause the upgrade and raise a health warning.
Sometimes, the user is able to resolve the issue and simply resume
the upgrade. The issue here is, in that case, the error field of
the UpgradeState is still set, so instead of seeing the useful info
messages, it will continue to display an error message that may
no longer be relevant. By emptying the error field of the UpgradeState
when upgrades are resumed, we return to normal behavior of
displaying the info string, and will only show another error message
if another error actually occurs.

Fixes: https://tracker.ceph.com/issues/56714
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 429561ccb7b524f071214ff3aad99ba8830a924c)

Merge pull request #47319 from adk3798/wip-56739-pacific

pacific: cephadm: add "su root root" to cephadm.log logrotate config

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #47320 from adk3798/wip-56737-pacific

pacific: qa/workunits/cephadm: update test_repos master -> main

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #47360 from zdover23/wip-doc-2022-07-29-backport-47347-to-pacific

pacific: doc/radosgw: Uppercase s3

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: make s3 uppercase

s/s3/S3/ (Also, a "the" has been added.)

(cherry picked from commit 73f0d5707d275529416d5110160b9ff5ead23d22)

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47259 from aaSharma14/wip-56686-pacific

pacific: os/bluestore: Better readability of perf output

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>

qa/workunits/cephadm: update test_repos master -> main

Missed this one, it seems the test was still passing until
recently but I guess the "master" builds are now gone

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 9b08edf939752d16b5933e1d7fd5bc33d08c2d4a)

cephadm: add "su root root" to cephadm.log logrotate config

Fixes: https://tracker.ceph.com/issues/56639
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit c0929e7e3ea14b0f8bfc71dc8ff74efddafb3ffc)

rgw/rgw_string.h: add missing includes for alpine and boost 1.75
alpine needs: string, stdexcept

Fixes: https://tracker.ceph.com/issues/50924
Signed-off-by: Duncan Bellamy <dunk@denkimushi.com>
(cherry picked from commit ebf3a0398f18eab67d2ba25e6a10b41ff140f6a4)

os/bluestore: Fix deferred writes corrupting RocksDB

Deferred writes can sometimes update regions that are no longer mapped to any object.
This cannot happen when BlueStore is running, as blobs are being held,
and allocations are not released until deferred op is executed.
However in case of restart allocations that deferred is targetting are already freed.
Deferred replay is done on BlueStore bootup, before any new object can be allocated,
so no collision with object is possible.
But BlueFS can allocate space from block with deferred ops still pending.

Fixes: https://tracker.ceph.com/issues/54547
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit 2afb951a490aac9ca4d01614867396cbd06b793d)

Conflicts: src/os/bluestore/BlueStore.cc
Modified non-critical BlueFS call foreach_block_extents to get_block_extents.

common/interval_set: Add operator-- to iterator

Only ++ was allowed. Extend iterator manipulation to -- too.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit 58860ce3f60489d258aaa10fd783e68083261937)

test/objectstore: Add test for deferred writes

Add test that recreates situation when BlueStore deferred writes
can cause RocksDB files corruption.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit 42de47ae8468d000d5bca62bd537d7a1028bae42)

Conflicts: src/test/objectstore/test_deferred.cc
Non-critical code parts.

libcephsqlite: ceph-mgr crashes when compiled with gcc12

regex in libcephsqlite, when compiled with GCC12 treats '-' as a range
operator resulting in the following error.
"Invalid start of '[x-x]' range in regular expression"

Fixes: https://tracker.ceph.com/issues/55304
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
(cherry picked from commit ac043a09c5ffb4b434b8644920004b3d5b7f9d8c)

Merge pull request #47087 from kamoltat/wip-ksirivad-pacific-backport-46029

pacific:mon/Elector: notify_rank_removed erase rank from both live_pinging and dead_pinging sets for highest ranked MON

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

os/bluestore: Better readability of perf output

Get rid of bluestore_ prefix for some stats.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
(cherry picked from commit b5f2cc7755b221ea0a4e4d11c0e8f1866dbdc052)

Merge pull request #46873 from ronen-fr/wip-rf-46860-pacific

Pacific: osd/scrub: late-arriving reservation grants are not an error

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #47220 from ceph/16210

v16.2.10

qa: Remove unused variable

Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit c8416c3f0e15e49dde4b9bca6f732231d9b5d16b)

16.2.10

rgw: s3website check for bucket before retargeting

On requesting s3website API without a bucket name it will crash because s->bucket is null

Fixes: https://tracker.ceph.com/issues/56281
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 933dbabb3a2a43fd016bc61cc0ee5e27f7ad32e7)

Conflicts:
  src/rgw/rgw_rest_s3.cc rgw::sal::Bucket -> rgw::sal::RGWBucket
(cherry picked from commit 5b3e3874433acdfec415eae2b7a02878afe00734)

qa: validate subvolume discover on upgrade

Validate subvolume discover on upgrade from
legacy subvolume to v1. The handcrafted
`.meta' file on legacy subvolume root should
not be used for any subvolume apis like getpath,
authorize.

Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit fcc118500c545fe6018cd3f2742127b92c657def)
(cherry picked from commit 34d280e306e2287f4fd9b5cac1c70607263ccc23)

mgr/volumes: V2 Fix for test_subvolume_retain_snapshot_invalid_recreate

Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 5bb46ee690591411d4890b613c6380fced9d04b4)

mgr/volumes: Fix subvolume discover during upgrade

Fixes the subvolume discover to use the correct
metadata file after an upgrade from legacy subvolume
to v1. The fix makes sure, it doesn't use the
handcrafted metadata file placed in the subvolume
root of legacy subvolume.

Co-authored-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Co-authored-by: Dan van der Ster <daniel.vanderster@cern.ch>
Co-authored-by: Ramana Raja <rraja@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 7eba9cab6cfb9a13a84062177d7a0fa228311e13)
(cherry picked from commit f8c04135150a7fb3c43607b43a8214e0d57547bc)

Merge pull request #47095 from aaSharma14/wip-56559-pacific

pacific: os/bluestore: update perf counter priorities

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: neha-ojha <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Yuri Weinstein <yweins@redhat.com>

os/bluestore: update priorities and nicks of bluestore perf counters

These perf counters do not show up in telemetry unless they are set to a "useful" priority or higher. Fetching these counters in telemetry may help to diagnose problems with RocksDB / BlueFS prefetching / insufficient cache sizes.

Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 8790f04c5469d86daebb3bbe1eb780a86b7404ce)

Note: This backport (and the original PR) exposed an extra 34 perf counters/OSD to Prometheus. Given Pacific is a stable release and not to add that much extra load we are adapting this backport and only exposing the 2 required perf-coun>

Merge pull request #46553 from adk3798/pacific-preserve-cephadm-user

pacific: cephadm: preserve cephadm user during RPM upgrade

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #47093 from rhcs-dashboard/wip-56546-pacific

pacific: mgr/dashboard: don't log tracebacks on 404s

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #47027 from tchaikov/pacific-56466

pacific: make-dist: patch boost source to support python 3.10  …

Merge pull request #47145 from s0nea/wip-56594-pacific

pacific: mgr/dashboard: prevent alert redirect

Merge pull request #46695 from votdev/dashboard_pull_i18n_transifex

mgr/dashboard: Pull latest languages from Transifex

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: prevent alert redirect

Prevent Alertmanager alerts from being redirected to the active mgr
dashboard instance. There are two reasons for it:

1. It doesn't bring any additional benefit. The Alertmanager config
   includes all available mgr instances - active and passive ones. In
   case of an alert, it will be sent to all of them. It ensures that
   the active mgr dashboard will receive the alert in any case.
2. The redirect URL includes the mgr IP and NOT the FQDN. This leads
   to issues in environments where an SSL certificate is configured and
   matches the FQDNs, only.

Fixes: https://tracker.ceph.com/issues/56401
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 965005e0789e566ccadce7a326b0e197ab8d7f5f)

Merge pull request #47008 from rhcs-dashboard/wip-56125-pacific

pacific: mgr/dashboard: display helpfull message when the iframe-embedded Grafana dashboard failed to load

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: nSedrickm <NOT@FOUND>

Merge pull request #46969 from guits/wip-56471-2-pacific

pacific: ceph-volume: avoid unnecessary subprocess calls

Merge pull request #47122 from zdover23/wip-doc-2022-07-16-backport-47109-to-pacific

pacific: doc/start: update hardware recs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47084 from rhcs-dashboard/wip-56544-pacific

pacific: mgr/dashboard: ingress backend service should list all supported services

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

cmake: patch boost source to support python 3.10

Python 3.10 doesn't include the _Py_fopen() function.  Boost
1.75.0 includes a patch which switches to using fopen() for
python versions >= 3.1, but Pacific is using boost 1.73.0,
which still uses _Py_fopen().  This commit adds the boost
1.75.0 patch to `make-dist`, so it's applied to our copy of
the boost source which is then used when building RPM packages.

the included patch comes from
https://github.com/boostorg/python/commit/d9f06052e28873037db7f98629bce72182a42410

Fixes: https://tracker.ceph.com/issues/56466
please note, this change is not cherry-picked from the
"main" branch. as we use boost 1.75 already in that branch,
but to minimize the risk of switching boost from 1.73 to
1.75 in a LTS branch like pacific, we just add a fix to
address this particular issue in boost 1.73.

Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Kefu Chai <tchaikov@gmail.com>

doc/start: update hardware recs

This PR picks up the parts of
https://github.com/ceph/ceph/pull/44466
that were not merged back in January, when that
pull request was raised.

Matters added here:
* improved organzation of matter
* emphasis of IOPs per core over cores per OSD

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 29c44a3bd6919f7fc23083d75d22e84c8b51e1c1)

Merge pull request #47103 from adk3798/pacific-osd-removal-docs-update

pacific: doc/cephadm: add note about OSDs being recreated to OSD removal section

Reviewed-by: <Anthony D'Atri anthonyeleven@users.noreply.github.com>

doc/cephadm: add note about OSDs being recreated to OSD removal section

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d4a39cd046b93cb7bb5b7ce0311139d9f6552802)

mgr/dashboard: don't log tracebacks on 404s

Currently we're logging tracebacks on expected request errors as 404,
401, etc. This may cause confusion to users, which might think that
something really wrong was happening there.

This should be extended to many DashboardExceptions that simply return
expected HTTP error codes (403, 415, 3xx, etc).

Fixes: https://tracker.ceph.com/issues/55720
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit 3928fe91a4b8c313a52e38cab9ba31e54ff1ae51)

mon/Elector: notify_rank_removed correctly nuke highest ranked MON

Added a case where we are removing the highest rank monitor
in `notify_rank_removed`, the old version did not deal with this
since it would only go into the loop when rank_removed < paxos_size().
Therefore, we added an else case for when rank_removed == paxos_size(),
we erase the rank from both `live_pinging` and `dead_pinging` set.

Fixes: https://tracker.ceph.com/issues/55435
Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit 13f09d0d8a3907ea948343f7d0a092e8ab288439)

mgr/dashboard: ingress backend service should list all supported services

Fixes: https://tracker.ceph.com/issues/56478
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 32118522cb71722c3cc20a1e1a9ca9ffdf7897e4)

Merge pull request #46675 from rhcs-dashboard/wip-56038-pacific

pacific: mgr/dashboard: stop polling when page is not visible

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46953 from idryomov/wip-56387-pacific

pacific: rbd-fuse: librados will filter out -r option from command-line

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #46767 from ronen-fr/wip-rf-42780-pacific

pacific: osd/scrub: mark PG as being scrubbed, from scrub initiation to Inacti…

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #47049 from zdover23/wip-doc-2022-07-12-backport-47045-to-pacific

pacific: doc/dev: s/github/GitHub/ in essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47050 from zdover23/wip-doc-2022-07-12-backport-47031-to-pacific

pacific: doc/dev: edit delayed-delete.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: s/github/GitHub/ in essentials.rst

This addresses a typo that Anthony D'Atri pointed out in
PR#47032. It didn't get addressed there, so it's being
addressed here.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit f7581e05b08d6ab55446088b0fb9f29b1dd6441b)

doc/dev: edit delayed-delete.rst

This PR improves the English in the "CephFS Delayed
Deletion" chapter of the Ceph Internals Guide (which
is stored in the doc/dev/ directory).

There was no pressing need to rewrite this. I just saw
that it could be tightened up, and I had the fifteen
minutes I needed to do it.

Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c186c5ec6cb2ea1999cb14500aaa64d6aa72dddd)

Merge pull request #47043 from zdover23/wip-doc-2022-07-12-backport-47032-to-pacific

pacific: doc/dev: add Dependabot section to essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

doc/dev: add Dependabot section to essentials.rst

This PR adds a section to the Developer Guide chapter
"Essentials" that explains what Dependabot is. This
section is adapted from an email from Ernesto Puerta
to the CLT that was sent on 08 Jul 2022.

Co-authored-by: Ernesto Puerta <epuertat@redhat.com>>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 2711e8de80edea121503e022cca37683f8abdfa9)

Merge pull request #46921 from ceph/revert-46429-wip-55309-pacific

Revert "pacific: mgr, mgr/prometheus: Fix regression with prometheus metrics"

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #46920 from ceph/revert-46427-wip-55308-pacific

Revert "pacific: mgr, mon: Keep upto date metadata with mgr for MONs"

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #46845 from ronen-fr/wip-rf-46727-pacific

Pacific: osd/scrubber/pg_scrubber.cc: fix bug where scrub machine gets stuck

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #46806 from nmshelke/wip-56104-pacific

pacific: mgr/volumes: subvolume ls command crashes if groupname as '_nogroup'

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #46803 from nmshelke/wip-56107-pacific

pacific: mgr/volumes: remove incorrect 'size' from output of 'snapshot info'

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #46677 from ljflores/wip-51287-pacific

pacific: ceph_test_librados_service: wait longer for servicemap to update

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #46939 from zdover23/wip-doc-2022-07-03-backport-46938-to-pacific

pacific: doc/dev: add IRC registration instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: add IRC registration instructions

This PR adds to the Developer Guide a link to the OFTC's IRC nick
registration instructions.

(cherry picked from commit 893e68a8f57b22cc025c82586ad0b42da2a6477c)

Merge pull request #46340 from zdover23/wip-doc-pr-45209-backport-pacific

pacific: doc/start: alphabetize hardware-recs links

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #46347 from zdover23/wip-min-hardware-typo-pacific-backport-2022-05-19

pacific: Wip min hardware typo pacific backport 2022 05 19

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #46976 from adk3798/wip-56436-pacific

pacific: doc/cephadm: enhancing daemon operations documentation

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #46977 from adk3798/wip-56158-pacific

pacific: doc/cephadm: Add post-upgrade section

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #46974 from adk3798/wip-56473-pacific

pacific: pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #46069 from guits/wip-55479-pacific

pacific: ceph-volume: only warn when config file isn't found

Merge pull request #46729 from guits/wip-56084-pacific

pacific: ceph-volume: do not log sensitive details

Merge pull request #46731 from guits/wip-56040-pacific

pacific: ceph-volume: make is_valid() optional

Merge pull request #46967 from guits/wip-56472-pacific

pacific: ceph-volume: decrease number of `pvs` calls in `lvm list`

Merge pull request #47018 from guits/wip-56493-pacific

pacific: ceph-volume: allow listing devices by OSD ID

Merge pull request #46975 from adk3798/wip-56455-pacific

pacific: mgr/cephadm: fixing scheduler consistent hashing

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

ceph-volume: move get_lvs_from_path() to api/lvm.py

This makes this method reusable across ceph-volume codebase.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 0ea399c01143673f0225b1b4a48136af75b0b6c5)

ceph-volume: allow listing devices by OSD ID

Adds the ability to list devices by OSD IDs, i.e. "ceph-volume lvm list
3" would list all devices under OSD ID 3 (which can be up to 2 and 3
devices under filestore and bluestore OSDs respectively).

Fixes: https://tracker.ceph.com/issues/41294
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 0792a396ce61b356ad004ac3dbd96fabed739eac)

ceph-volume: add methods to get LV from OSD ID

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 7bf4937a597b37d98d3c4e69e2751c07992e33e4)

mgr/dashboard: Dashboard should display some helpful (error) message when the iframe-embedded Grafana dashboard failed to load

This commit adds checks for successful grafana panel loads before displaying dashboards and informs the user if the request is blocked by the browser
Fixes: https://tracker.ceph.com/issues/54206
Signed-off-by: Ngwa Sedrick Meh <nsedrick101@gmail.com>
(cherry picked from commit a4b66efb2a2139bd88a6a088af9bd5e079e46105)

Merge pull request #46934 from zdover23/wip-doc-2022-06-30-backport-46906-to-pacific

pacific: doc/dev: s/the the/the/ in basic-workflow.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Revert "pacific: mgr, mgr/prometheus: Fix regression with prometheus metrics"

This reverts pacific commit f07e47ae405218dbe4029ed9c82559d0cf1667a5

Reason: The pacific commit 98760e36c7bbbb48657e4d033bcbb080a56bbf7b has
added a new MMgrUpdate message which incorrectly handled service_daemon.
Reverting PR#46429 as a result of revert of PR#46427.

More details in https://tracker.ceph.com/issues/55322

Signed-off-by: Prashant D <pdhange@redhat.com>

Revert "pacific: mgr, mon: Keep upto date metadata with mgr for MONs"

This reverts pacific commit 98760e36c7bbbb48657e4d033bcbb080a56bbf7b

Reason: The service_daemon is related to client daemons like rgw,
iscsi demons and it should not be handled in MMgrUpdate.

More details in https://tracker.ceph.com/issues/55322

Signed-off-by: Prashant D <pdhange@redhat.com>

doc/cephadm: Add post-upgrade section
Fixes: https://tracker.ceph.com/issues/54474
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 49b234ae744dd3a2afc130d9c215f4f00c1ee4b8)

doc/cephadm: enhancing daemon operations documentation
Fixes: https://tracker.ceph.com/issues/54399
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit df1aaacb7d09322528e42ae90c0d98793e9c254e)

mgr/cephadm: fixing E128 warning

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit e37924c623d797b3118ddd9a804818432a5704dd)

mgr/cephadm: fixing scheduler consistent hashing

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 5d5829cd370e9278cb8b70d6426094e595badb5d)

pybind/mgr/cephadm/serve: don't remove ceph.conf which leads to qa failure

Fixes: https://tracker.ceph.com/issues/56024
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 6436acc4b51b52635f8fa0e56cd79ba66c028d81)

Merge pull request #46744 from mkogan1/rgw-backport-pacific-t54363

pacific: rgwlc: fix segfault resharding during lc

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #46715 from mkogan1/rgw-pacific-fix-fips-segf

pacific rgw: on FIPS enabled, fix segfault performing s3 multipart PUT

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #46235 from vumrao/wip-vumrao-54278

pacific: rgw: remove rgw_rados_pool_pg_num_min and its use on pool creation use the cluster defaults for pg_num_min

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #43802 from rjhaverkamp/wip-53145-pacific

pacific: rgw: fix self-comparison for RGWCopyObj optimization

Reviewed-by: Casey Bodley <cbodley@redhat.com>