]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agomgr/cephadm: reconfig iscsi daemons if trusted_ip_list changes 47521/head
Adam King [Tue, 9 Aug 2022 20:13:38 +0000 (16:13 -0400)]
mgr/cephadm: reconfig iscsi daemons if trusted_ip_list changes

This is necessary as iscsi daemons expect the iscsi-gateway.cfg
which includes this list to match across the iscsi daemons

Fixes: https://tracker.ceph.com/issues/57078
Signed-off-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47898 from adk3798/no-sudo-true
Adam King [Tue, 13 Sep 2022 12:56:18 +0000 (08:56 -0400)]
Merge pull request #47898 from adk3798/no-sudo-true

mgr/cephadm: don't use "sudo" in commands if user is root

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #47469 from lxbsz/cleanup_C_MDC_EmptyImport
Venky Shankar [Tue, 13 Sep 2022 12:47:29 +0000 (18:17 +0530)]
Merge pull request #47469 from lxbsz/cleanup_C_MDC_EmptyImport

mds: remove the stale class C_MDC_EmptyImport code

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2 years agoMerge pull request #48033 from joscollin/wip-kill-cephfs-top
Venky Shankar [Tue, 13 Sep 2022 12:46:20 +0000 (18:16 +0530)]
Merge pull request #48033 from joscollin/wip-kill-cephfs-top

stop.sh: kill cephfs-top

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #48006 from rkachach/fix_issue_57422
Adam King [Tue, 13 Sep 2022 12:22:49 +0000 (08:22 -0400)]
Merge pull request #48006 from rkachach/fix_issue_57422

mgr/cephadm: Adding --storage.tsdb.retention.size prometheus option

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge pull request #47574 from rhcs-dashboard/osd-form-hostname-filter
Nizamudeen A [Tue, 13 Sep 2022 06:08:01 +0000 (11:38 +0530)]
Merge pull request #47574 from rhcs-dashboard/osd-form-hostname-filter

mgr/dashboard: osd form preselect db/wal device filters

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2 years agoMerge pull request #48001 from aisakaki/wip-omap-inclusive-fix
Liu-Chunmei [Tue, 13 Sep 2022 05:54:46 +0000 (22:54 -0700)]
Merge pull request #48001 from aisakaki/wip-omap-inclusive-fix

crimson/seastore: fixs on omap list open/closed range

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2 years agoMerge pull request #47968 from rhcs-dashboard/add-alert-silence-button
Nizamudeen A [Tue, 13 Sep 2022 05:10:34 +0000 (10:40 +0530)]
Merge pull request #47968 from rhcs-dashboard/add-alert-silence-button

mgr/dashboard: Add a Silence button shortcut to alert notifications

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #47305 from zdover23/wip-doc-2022-07-25-pr4600-cleanup
zdover23 [Tue, 13 Sep 2022 03:44:43 +0000 (13:44 +1000)]
Merge pull request #47305 from zdover23/wip-doc-2022-07-25-pr4600-cleanup

doc/monitoring: add min vers of apps in mon stack

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 years agoMerge pull request #47575 from zdover23/wip-doc-2022-08-13-rados-operations-pools...
zdover23 [Tue, 13 Sep 2022 02:45:18 +0000 (12:45 +1000)]
Merge pull request #47575 from zdover23/wip-doc-2022-08-13-rados-operations-pools-prompt-update

doc/rados: add prompts to pools.rst

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #48042 from SUSE/wip-fix-57497
Tim Serong [Mon, 12 Sep 2022 22:55:40 +0000 (08:55 +1000)]
Merge pull request #48042 from SUSE/wip-fix-57497

ceph.spec.in: Use gcc11-c++ on openSUSE Leap 15.x

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47771 from linuxbox2/wip-librgw-frontends
Matt Benjamin [Mon, 12 Sep 2022 22:46:35 +0000 (18:46 -0400)]
Merge pull request #47771 from linuxbox2/wip-librgw-frontends

librgw: add ability to conditionally export HTTP frontends/apis

2 years agorgw/main: if !nfs, register service map as "rgw" 47771/head
Matt Benjamin [Mon, 12 Sep 2022 21:00:49 +0000 (17:00 -0400)]
rgw/main: if !nfs, register service map as "rgw"

This was accidentally changed to "nfs"--which breaks various
ceph orchestration assumptions.

Found by Ernesto Puerta <epuertat@redhat.com>

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #47854 from phlogistonjohn/jjm-fix-57268
Adam King [Mon, 12 Sep 2022 19:56:43 +0000 (15:56 -0400)]
Merge pull request #47854 from phlogistonjohn/jjm-fix-57268

qa/tasks/kubeadm: set up tigera resources via kubectl create

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #48007 from adk3798/fix-staggered-pacific-version
Adam King [Mon, 12 Sep 2022 19:06:33 +0000 (15:06 -0400)]
Merge pull request #48007 from adk3798/fix-staggered-pacific-version

doc/cephadm: correct version staggered upgrade got in pacific

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge pull request #46344 from mjenglish/ceph-volume-multiple-actuator
Guillaume Abrioux [Mon, 12 Sep 2022 18:58:41 +0000 (20:58 +0200)]
Merge pull request #46344 from mjenglish/ceph-volume-multiple-actuator

ceph-volume/ceph_volume/util: ceph-volume multi-actuator drive attribute

2 years agoMerge pull request #47970 from soumyakoduri/wip-skoduri-coverity
Soumya Koduri [Mon, 12 Sep 2022 17:21:54 +0000 (22:51 +0530)]
Merge pull request #47970 from soumyakoduri/wip-skoduri-coverity

rgw/dbstore: Fix coverity issues #1510412, #1511420

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agomgr/dashboard: Add a Silence button shortcut to alert notifications 47968/head
Aashish Sharma [Mon, 5 Sep 2022 05:51:40 +0000 (11:21 +0530)]
mgr/dashboard: Add a Silence button shortcut to alert notifications

Fixes: https://tracker.ceph.com/issues/57457
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #47976 from rhcs-dashboard/fix-duplicate-snapshot
Nizamudeen A [Mon, 12 Sep 2022 05:52:40 +0000 (11:22 +0530)]
Merge pull request #47976 from rhcs-dashboard/fix-duplicate-snapshot

mgr/dashboard: fix snapshot creation with duplicate name

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agorgw/dbstore: Fix coverity issues #1510412, #1511420 47970/head
Soumya Koduri [Mon, 5 Sep 2022 08:31:32 +0000 (14:01 +0530)]
rgw/dbstore: Fix coverity issues #1510412, #1511420

Fixes: https://tracker.ceph.com/issues/57322
Fixes: https://tracker.ceph.com/issues/57325
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 years agoceph.spec.in: Use gcc11-c++ on openSUSE Leap 15.x 48042/head
Tim Serong [Mon, 12 Sep 2022 01:10:14 +0000 (11:10 +1000)]
ceph.spec.in: Use gcc11-c++ on openSUSE Leap 15.x

Fixes: 80949babab4aac86647ce9973f6b44adb92fae95
Fixes: https://tracker.ceph.com/issues/57497
Signed-off-by: Tim Serong <tserong@suse.com>
2 years agoMerge pull request #48032 from rhcs-dashboard/openapi-check-fix
Nizamudeen A [Sat, 10 Sep 2022 07:19:28 +0000 (12:49 +0530)]
Merge pull request #48032 from rhcs-dashboard/openapi-check-fix

mgr/dashboard: fix openapi-check

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: docs gen tags sort 48032/head
Pere Diaz Bou [Fri, 9 Sep 2022 09:18:42 +0000 (11:18 +0200)]
mgr/dashboard: docs gen tags sort

When generating tags the order of endpoints wasn't taken into account.
Two endpoints with the same url prefix, for example `/api/cluster/` and
`/api/cluster/user`, have different docs and the tags is generated from
a doc of one of these two, and since the order of these endpoints might
vary it is imperative to sort them to have a deterministic output.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #47770 from rzarzynski/wip-doc-dups-trimming-relnotes
Neha Ojha [Fri, 9 Sep 2022 17:00:41 +0000 (10:00 -0700)]
Merge pull request #47770 from rzarzynski/wip-doc-dups-trimming-relnotes

PendingReleaseNotes: document online and offline trimming of PG Log's…

Reviewed-By: Neha Ojha <nojha@redhat.com>
2 years agorgwlib: ensure AppMain is destructed before CephContext
Matt Benjamin [Fri, 9 Sep 2022 15:57:44 +0000 (11:57 -0400)]
rgwlib: ensure AppMain is destructed before CephContext

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: cause ratelimiter to destruct in AppMain::shutdown()
Matt Benjamin [Thu, 8 Sep 2022 16:46:55 +0000 (12:46 -0400)]
rgw/main: cause ratelimiter to destruct in AppMain::shutdown()

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agolibrgw: fix mismatched register/unregister sigterm handler
Matt Benjamin [Wed, 7 Sep 2022 17:57:29 +0000 (13:57 -0400)]
librgw: fix mismatched register/unregister sigterm handler

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: fix init order of rgw_main's init_storage()
Matt Benjamin [Wed, 7 Sep 2022 17:30:53 +0000 (13:30 -0400)]
rgw/main:  fix init order of rgw_main's init_storage()

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: move service_map_meta into AppMain
Matt Benjamin [Wed, 7 Sep 2022 14:22:14 +0000 (10:22 -0400)]
rgw/main: move service_map_meta into AppMain

The RGWRealmReloader holds a reference on it.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: move signal handler actions out of shutdown()
Matt Benjamin [Fri, 2 Sep 2022 21:54:45 +0000 (17:54 -0400)]
rgw/main: move signal handler actions out of shutdown()

AppMain::shutdown() had borrowed the unregister_async_signal_handler()
text from librgw, but of course, that's wrong.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgwlib: robustify non-default initialization
Matt Benjamin [Thu, 1 Sep 2022 15:33:31 +0000 (11:33 -0400)]
rgwlib: robustify non-default initialization

Don't rely on the conf-default value of rgw_nfs_frontends to
provide "rgw-nfs," as that's not optional when running under
librgw.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw_main: remove unused tracepoint decls
Matt Benjamin [Thu, 1 Sep 2022 12:57:38 +0000 (08:57 -0400)]
rgw_main: remove unused tracepoint decls

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgwlib: rework linkage
Matt Benjamin [Thu, 1 Sep 2022 12:53:50 +0000 (08:53 -0400)]
rgwlib: rework linkage

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw_a: build reorganization
Matt Benjamin [Tue, 30 Aug 2022 14:19:34 +0000 (10:19 -0400)]
rgw_a: build reorganization

Reorganize some dependencies shared by the librgw.so and radosgw
main units.  The librgw.so build no longer builds a main(...)
unit.

Build time should be slightly reduced, as several shared dependencies
have been moved into rgw_a.

There are some other cleanups, e.g., rgw_signal.{h,cc}.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: remove friends, see_also
Matt Benjamin [Tue, 30 Aug 2022 13:42:31 +0000 (09:42 -0400)]
rgw/main: remove friends, see_also

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: various doc and comment corrections by doc writers
Matt Benjamin [Mon, 29 Aug 2022 15:33:53 +0000 (11:33 -0400)]
rgw/main: various doc and comment corrections by doc writers

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: use AppMain in c++ main function
Matt Benjamin [Sat, 27 Aug 2022 17:11:30 +0000 (13:11 -0400)]
rgw/main: use AppMain in c++ main function

Consolidate standalone and library initialization into one
unit.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: AppMain
Matt Benjamin [Sat, 27 Aug 2022 14:35:45 +0000 (10:35 -0400)]
rgw/main: AppMain

s/rgw::InitHelper/rgw::AppMain/;

Move program state from RGWLib into AppMain, preparing it to
manage program state for all RGW instances (e.g., main()).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agolibrgw: add ability to conditionally export HTTP frontends/apis
Matt Benjamin [Thu, 18 Aug 2022 21:25:09 +0000 (17:25 -0400)]
librgw: add ability to conditionally export HTTP frontends/apis

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #47700 from s0nea/wip-rgw-overview-labels
Nizamudeen A [Fri, 9 Sep 2022 12:06:40 +0000 (17:36 +0530)]
Merge pull request #47700 from s0nea/wip-rgw-overview-labels

monitoring/ceph-mixin: add RGW host to label info

Reviewed-by: MrFreezeex <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agostop.sh: kill cephfs-top 48033/head
Jos Collin [Fri, 9 Sep 2022 11:38:09 +0000 (17:08 +0530)]
stop.sh: kill cephfs-top

Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agomgr/dashboard: osd form preselect db/wal device filters 47574/head
Nizamudeen A [Fri, 12 Aug 2022 15:34:23 +0000 (21:04 +0530)]
mgr/dashboard: osd form preselect db/wal device filters

If the hostname is selected for the primary devices, then we can
preselect the hostname filter for the db/wal devices because osds will
be deployed only on the hostname of the primary device. If preselected
it'll be clear that only this devices will be used to deploy.

Addition to this, usually ssd devices are used for db/wal devices. So I
am preselecting these too in the filters.

Fixes: https://tracker.ceph.com/issues/57118
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #47784 from rhcs-dashboard/ingress-unmanaged
Nizamudeen A [Fri, 9 Sep 2022 05:14:35 +0000 (10:44 +0530)]
Merge pull request #47784 from rhcs-dashboard/ingress-unmanaged

mgr/dashboard: fix unmanaged service creation

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 years agoMerge pull request #47959 from rhcs-dashboard/service-id-filter-undefined
Nizamudeen A [Fri, 9 Sep 2022 03:57:14 +0000 (09:27 +0530)]
Merge pull request #47959 from rhcs-dashboard/service-id-filter-undefined

mgr/dashboard: fix Cannot read properties of undefined (reading 'filter')

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #48014 from idryomov/wip-57116-cont
Ilya Dryomov [Thu, 8 Sep 2022 18:52:28 +0000 (20:52 +0200)]
Merge pull request #48014 from idryomov/wip-57116-cont

test/{librbd, rgw}: increase delay between and number of bind attempts

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #48003 from dang/wip-dang-zipper-admin-api
Daniel Gryniewicz [Thu, 8 Sep 2022 18:36:46 +0000 (14:36 -0400)]
Merge pull request #48003 from dang/wip-dang-zipper-admin-api

RGW - Zipper - Allow per-store admin APIs

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48009 from ljflores/wip-install-deps-focal-bionic
Ilya Dryomov [Thu, 8 Sep 2022 18:05:15 +0000 (20:05 +0200)]
Merge pull request #48009 from ljflores/wip-install-deps-focal-bionic

install-deps.sh: fix install-deps script for focal and bionic

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoRGW - Zipper - Allow per-store admin APIs 48003/head
Daniel Gryniewicz [Thu, 1 Sep 2022 17:52:26 +0000 (13:52 -0400)]
RGW - Zipper - Allow per-store admin APIs

Some of the existing admin APIs are rados-specific, and other stores
will want to add specific APIs.  Allow this by having a function to add
store-specific APIs.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoPendingReleaseNotes: document online and offline trimming of PG Log's dups 47770/head
Radoslaw Zarzynski [Tue, 23 Aug 2022 19:50:48 +0000 (19:50 +0000)]
PendingReleaseNotes: document online and offline trimming of PG Log's dups

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agomgr/cephadm: Adding --storage.tsdb.retention.size prometheus option 48006/head
Redouane Kachach [Wed, 7 Sep 2022 12:51:10 +0000 (14:51 +0200)]
mgr/cephadm: Adding --storage.tsdb.retention.size prometheus option
fixes: https://tracker.ceph.com/issues/57422

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2 years agotest/{librbd, rgw}: increase delay between and number of bind attempts 48014/head
Ilya Dryomov [Thu, 8 Sep 2022 09:36:34 +0000 (11:36 +0200)]
test/{librbd, rgw}: increase delay between and number of bind attempts

Commit aa7885f7cc41 ("test/{librbd, rgw}: retry when bind fail with
port 0") reduced the frequency of sporadic unit test failures caused
by EADDRINUSE a lot, but not entirely.

Currently, it yields a cumulative sleep of ~9 seconds.  Let's increase
that to 1 minute.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #47274 from faithuniterh/Golang-Notification-creation
Yuval Lifshitz [Thu, 8 Sep 2022 09:31:24 +0000 (12:31 +0300)]
Merge pull request #47274 from faithuniterh/Golang-Notification-creation

examples/golang : Add put notification creation golang example code

reviewed-by: yuvalif

2 years agoMerge pull request #46757 from nSedrickm/navigation-component-accessibility-update
Nizamudeen A [Thu, 8 Sep 2022 04:11:29 +0000 (09:41 +0530)]
Merge pull request #46757 from nSedrickm/navigation-component-accessibility-update

mgr/dashboard: Improve accessibility for navigation components

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoinstall-deps.sh: fix install-deps script for focal and bionic 48009/head
Laura Flores [Wed, 7 Sep 2022 19:45:57 +0000 (19:45 +0000)]
install-deps.sh: fix install-deps script for focal and bionic

When run on focal and bionic, install-deps ends early
due to this extra debug message that was added to the
end of `ensure_decent_gcc_on_ubuntu`. The debug message
prints when the script is run in a jenkins environment.

When the script is not run in a jenkins environment, the
value returned there is "false" or "0", which acts as
an early return. This stops the script from completing.

We can remove this line, as `ensure_decent_gcc_on_ubuntu`
is only called for focal and bionic, and most of the jenkins
nodes are running jammy. Also, there is a debug message at the
beginning of the function that should suffice.

Fixes: https://tracker.ceph.com/issues/57466
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agodoc/cephadm: correct version staggered upgrade got in pacific 48007/head
Adam King [Wed, 7 Sep 2022 19:19:02 +0000 (15:19 -0400)]
doc/cephadm: correct version staggered upgrade got in pacific

This didn't end up making 16.2.10 so the first version
it will actually be available is 16.2.11

Signed-off-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47091 from faithuniterh/Golang-Topic-creation
Yuval Lifshitz [Wed, 7 Sep 2022 18:15:52 +0000 (21:15 +0300)]
Merge pull request #47091 from faithuniterh/Golang-Topic-creation

Topic creation example and sorting Golang examples into different folders

reviewed-by: anthonyeleven, yuvalif

2 years agoMerge pull request #47864 from yuvalif/wip-yuval-fix-53186
Yuval Lifshitz [Wed, 7 Sep 2022 18:09:16 +0000 (21:09 +0300)]
Merge pull request #47864 from yuvalif/wip-yuval-fix-53186

rgw/notifications: add region to bucket ARN

reviewed-by: mattbenjamin, nthonyeleven

2 years agoMerge pull request #47924 from tchaikov/wip-57355
Casey Bodley [Wed, 7 Sep 2022 16:53:36 +0000 (12:53 -0400)]
Merge pull request #47924 from tchaikov/wip-57355

denc: support non-c++20 compliant C++ standard library

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47935 from ivancich/wip-simplify-bucket-listing-logging
J. Eric Ivancich [Wed, 7 Sep 2022 15:30:21 +0000 (11:30 -0400)]
Merge pull request #47935 from ivancich/wip-simplify-bucket-listing-logging

rgw: simplify bucket listing logging

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 years agoMerge pull request #47741 from ljflores/wip-python3-fix
Laura Flores [Wed, 7 Sep 2022 15:11:08 +0000 (10:11 -0500)]
Merge pull request #47741 from ljflores/wip-python3-fix

do_cmake.sh: build with python3.10 on ubuntu version >= 22.0

2 years agoMerge pull request #47857 from nSedrickm/duplicate-id-accessibility-update
Pere Diaz Bou [Wed, 7 Sep 2022 14:56:08 +0000 (16:56 +0200)]
Merge pull request #47857 from nSedrickm/duplicate-id-accessibility-update

mgr/dashboard: remove duplicate ids from table column filters

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agomgr/dashboard: fix snapshot creation with duplicate name 47976/head
Aashish Sharma [Mon, 5 Sep 2022 11:59:11 +0000 (17:29 +0530)]
mgr/dashboard: fix snapshot creation with duplicate name

Snapshot creation with same name on UI throwing 500 Internal Error, This PR intends to fix this issue.

Fixes: https://tracker.ceph.com/issues/57456
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #47981 from myoungwon/wip-rbm-cleanup2
Yingxin [Wed, 7 Sep 2022 10:54:27 +0000 (18:54 +0800)]
Merge pull request #47981 from myoungwon/wip-rbm-cleanup2

crimson/os/seastore: RBM cleanups (mkfs, open, unittest)

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson/seastore: lack of config.inclusive==true situation in omap_manager list... 48001/head
Xinyu Huang [Wed, 7 Sep 2022 06:40:52 +0000 (06:40 +0000)]
test/crimson/seastore: lack of config.inclusive==true situation in omap_manager list test

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
2 years agoMerge pull request #47054 from nSedrickm/grafana-component-accessibility-update
Pere Diaz Bou [Wed, 7 Sep 2022 08:30:00 +0000 (10:30 +0200)]
Merge pull request #47054 from nSedrickm/grafana-component-accessibility-update

mgr/dashboard: Improve level A accessibility for grafana component

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agocrimson/os/seastore/rbm: use RBMDevice::size instead of TestMemory::size in TestMemory 47981/head
myoungwon oh [Fri, 2 Sep 2022 05:06:28 +0000 (14:06 +0900)]
crimson/os/seastore/rbm: use RBMDevice::size instead of TestMemory::size in TestMemory

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: force to make rbm superblock when mkfs is called
myoungwon oh [Tue, 6 Sep 2022 02:59:41 +0000 (11:59 +0900)]
crimson/os/seastore/rbm: force to make rbm superblock when mkfs is called

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: call device.open() before rbm.open() or rbm.mkfs()
myoungwon oh [Tue, 6 Sep 2022 02:47:41 +0000 (11:47 +0900)]
crimson/os/seastore/rbm: call device.open() before rbm.open() or rbm.mkfs()

This commit also deletes open_device() in rbn.open()

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agotest/crimson/seastore: fix randomblockmanager test
myoungwon oh [Fri, 2 Sep 2022 04:52:50 +0000 (13:52 +0900)]
test/crimson/seastore: fix randomblockmanager test

1. remove transaction manager initialization in rbm test
2. do not call check_bitmap_blocks directly and use close() and open()
because open() invokes it internally

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/omap: fix assert bug
Xinyu Huang [Wed, 7 Sep 2022 00:01:33 +0000 (00:01 +0000)]
crimson/os/seastore/omap: fix assert bug

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
2 years agoMerge pull request #47987 from idryomov/wip-52810
Ilya Dryomov [Tue, 6 Sep 2022 18:17:15 +0000 (20:17 +0200)]
Merge pull request #47987 from idryomov/wip-52810

librbd: retry ENOENT in V2_REFRESH_PARENT as well

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #47783 from soumyakoduri/wip-skoduri-sync-flow
Casey Bodley [Tue, 6 Sep 2022 16:29:53 +0000 (12:29 -0400)]
Merge pull request #47783 from soumyakoduri/wip-skoduri-sync-flow

radosgw-admin: fix crash with 'sync flow' cmd without 'flow-type'

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2 years agoMerge pull request #45883 from ifed01/wip-ifed-fix-bluefs-truncate
Yuri Weinstein [Tue, 6 Sep 2022 16:12:29 +0000 (09:12 -0700)]
Merge pull request #45883 from ifed01/wip-ifed-fix-bluefs-truncate

os/bluestore: fix no metadata update on truncate+fsync

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #47630 from sseshasa/wip-add-mclk-cpu-util-rel-note
Sridhar Seshasayee [Tue, 6 Sep 2022 15:15:02 +0000 (20:45 +0530)]
Merge pull request #47630 from sseshasa/wip-add-mclk-cpu-util-rel-note

PendingReleaseNotes: Note the fix for high CPU utilization during recovery

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agomonitoring/ceph-mixin: add RGW host to label info 47700/head
Tatjana Dehler [Fri, 19 Aug 2022 10:08:17 +0000 (12:08 +0200)]
monitoring/ceph-mixin: add RGW host to label info

Add the missing information about the RGW instance to the labels of the
"Average GET/PUT Latencies" panel on the "RGW Overview" dashboard.

Fixes: https://tracker.ceph.com/issues/57166
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2 years agoMerge pull request #47908 from dang/wip-dang-zipper-cleanup
Daniel Gryniewicz [Tue, 6 Sep 2022 13:48:49 +0000 (09:48 -0400)]
Merge pull request #47908 from dang/wip-dang-zipper-cleanup

RGW - Sal - remove unused default constructors

Reviewed-by: Casey Bodley <cbodley@redat.com>
2 years agoMerge pull request #47907 from cbodley/wip-57195
Casey Bodley [Tue, 6 Sep 2022 11:52:34 +0000 (07:52 -0400)]
Merge pull request #47907 from cbodley/wip-57195

rgw: fix d3n crash in StoreManager::get_config()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
2 years agomgr/dashboard: add cypress e2e accessibility tests for navigation 46757/head
nsedrickm [Sun, 7 Aug 2022 13:25:11 +0000 (14:25 +0100)]
mgr/dashboard: add cypress e2e accessibility tests for navigation

* Add cypress e2e accessibility tests
* Log accessibility violations to console for quick debugging
* Disable retries to avoid duplicate logs

Signed-off-by: nsedrickm <nsedrick101@gmail.com>
2 years agomgr/dashboard: Improve accessibility for navigation components
nsedrickm [Mon, 20 Jun 2022 17:32:27 +0000 (18:32 +0100)]
mgr/dashboard: Improve accessibility for navigation components

* Fix all dropdown accessibility issues by setting their roles as buttons
* Increase navlink font-size to 16px
* Add new primary color variable $primary-wcag-aa-large-text: #25828e  to meet WCAG level AA color contrast ratio for active navlink backgrounds

Fixes: https://tracker.ceph.com/issues/56021
Signed-off-by: nsedrickm <nsedrick101@gmail.com>
2 years agoMerge pull request #46823 from lightmelodies/librados-c-api-stat2
Kefu Chai [Tue, 6 Sep 2022 00:40:46 +0000 (08:40 +0800)]
Merge pull request #46823 from lightmelodies/librados-c-api-stat2

librados: export stat2 in C API

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47962 from tchaikov/wip-3rd-time-is-a-charm
Kefu Chai [Tue, 6 Sep 2022 00:37:45 +0000 (08:37 +0800)]
Merge pull request #47962 from tchaikov/wip-3rd-time-is-a-charm

test/{librbd, rgw}: retry when bind fail with port 0

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agolibrbd: make RefreshRequest tests compatible with clone v1 47987/head
Ilya Dryomov [Sun, 4 Sep 2022 17:14:04 +0000 (19:14 +0200)]
librbd: make RefreshRequest tests compatible with clone v1

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: retry ENOENT in V2_REFRESH_PARENT as well
Ilya Dryomov [Sun, 4 Sep 2022 15:52:51 +0000 (17:52 +0200)]
librbd: retry ENOENT in V2_REFRESH_PARENT as well

With auto-deletion of trashed snapshots, it is relatively easy to lose
a race to "rbd flatten" as follows:

- when V2_GET_PARENT runs, the image is technically still a clone
- when V2_REFRESH_PARENT runs, the image is fully flattened and the
  snapshot in the parent image is deleted

This results in a spurious ENOENT error, mainly when trying to open the
image (e.g. for "rbd info").  This race condition has always been there
but auto-deletion of trashed snapshots makes it much worse.

Retry ENOENT in V2_REFRESH_PARENT the same way as in V2_GET_SNAPSHOTS.

Fixes: https://tracker.ceph.com/issues/52810
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: limit the number of ENOENT retries in RefreshRequest
Ilya Dryomov [Sun, 4 Sep 2022 10:40:36 +0000 (12:40 +0200)]
librbd: limit the number of ENOENT retries in RefreshRequest

If the image header is corrupt, ENOENT error may be persistent.  Avoid
an infinite loop in that case.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: fix a bunch of issues with restarting RefreshRequest
Ilya Dryomov [Fri, 2 Sep 2022 14:58:36 +0000 (16:58 +0200)]
librbd: fix a bunch of issues with restarting RefreshRequest

Make RefreshRequest properly restartable, at least up until and including
V2_REFRESH_PARENT step:

- clear m_migration_spec when skipping GET_MIGRATION_HEADER
- don't rely on potentially stale m_incomplete_update on retry
- reset m_legacy_parent when retrying more than just V2_GET_PARENT
- don't rely on potentially stale m_parent_md.overlap and
  m_head_parent_overlap on retry
- clear m_metadata before fetching image metadata (but not before
  fetching pool metadata)
- clear m_op_features when skipping V2_GET_OP_FEATURES
- clear m_group_spec on EOPNOTSUPP error in V2_GET_GROUP
- reset m_legacy_snapshot when retrying more than just V2_GET_SNAPSHOTS
- don't rely on potentially stale m_snap_parents on retry

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: check *result consistently in RefreshRequest
Ilya Dryomov [Tue, 30 Aug 2022 19:33:04 +0000 (21:33 +0200)]
librbd: check *result consistently in RefreshRequest

Stick to *result >= 0 checks everywhere and add missing checks for
op_features_get_finish() and image_group_get_finish() errors.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: reflect V2_GET_SNAPSHOTS ENOENT retry in state diagram
Ilya Dryomov [Tue, 30 Aug 2022 18:38:10 +0000 (20:38 +0200)]
librbd: reflect V2_GET_SNAPSHOTS ENOENT retry in state diagram

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #47964 from yuvalif/wip-yuval-fix-57418
Casey Bodley [Mon, 5 Sep 2022 18:17:07 +0000 (14:17 -0400)]
Merge pull request #47964 from yuvalif/wip-yuval-fix-57418

rgw/lua: handle null lua manager in librgw

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47456 from sseshasa/wip-fix-mon-cmd-nack
Yuri Weinstein [Mon, 5 Sep 2022 18:16:00 +0000 (11:16 -0700)]
Merge pull request #47456 from sseshasa/wip-fix-mon-cmd-nack

osd: Implement Context based completion for mon cmd to set a config option

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #37767 from shun-s/add-mons-ms-tos-support
Yuri Weinstein [Mon, 5 Sep 2022 18:14:33 +0000 (11:14 -0700)]
Merge pull request #37767 from shun-s/add-mons-ms-tos-support

msg: add min delay packets support for mons

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agotest/{librbd, rgw}: retry when bind fail with port 0 47962/head 47963/head
Kefu Chai [Sun, 4 Sep 2022 12:37:32 +0000 (20:37 +0800)]
test/{librbd, rgw}: retry when bind fail with port 0

there is chance that the bind() call may fail if we have another test
happen to pick the free port picked by operating system. in this case,
we just retry up to 42 times.

in theory, this change does not fully address the racing, but it should
help to alleviate this issue.

See-also: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47250 from nSedrickm/progress-bar-accessibility-update
Pere Diaz Bou [Mon, 5 Sep 2022 11:02:00 +0000 (13:02 +0200)]
Merge pull request #47250 from nSedrickm/progress-bar-accessibility-update

mgr/dashboard: Improve level A accessibility for usagebar

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #47507 from zenomri/wip-omri-fix-tracer-provider
Yuval Lifshitz [Mon, 5 Sep 2022 09:19:56 +0000 (12:19 +0300)]
Merge pull request #47507 from zenomri/wip-omri-fix-tracer-provider

common/tracer: fix for tracer provider destruction

reviewed-by: yuvalif

2 years agoMerge pull request #47905 from cbodley/wip-57326
Yuval Lifshitz [Mon, 5 Sep 2022 07:33:27 +0000 (10:33 +0300)]
Merge pull request #47905 from cbodley/wip-57326

rgw: avoid string_view to temporary in RGWBulkUploadOp

reviewed-by: dang, yuvalif

2 years agomgr/dashboard: remove duplicate ids from table column filters 47857/head
nsedrickm [Mon, 29 Aug 2022 18:35:29 +0000 (19:35 +0100)]
mgr/dashboard: remove duplicate ids from table column filters

Generate random ids for column filters to avoid id conflics on pages with multiple tables sharing the same column filters

Signed-off-by: nsedrickm <nsedrick101@gmail.com>
Fixes: https://tracker.ceph.com/issues/55869
2 years agoMerge pull request #47518 from aravind-wdc/zns-wip
Yingxin [Mon, 5 Sep 2022 03:34:31 +0000 (11:34 +0800)]
Merge pull request #47518 from aravind-wdc/zns-wip

crimson/os/seastore: improve ZNS support for SeaStore

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agodoc/monitoring: add min vers of apps in mon stack 47305/head
Zac Dover [Wed, 27 Jul 2022 14:27:42 +0000 (00:27 +1000)]
doc/monitoring: add min vers of apps in mon stack

https://tracker.ceph.com/issues/45447

This PR adds recommended versions of grafana and
prometheus and alert manager.

This PR is a second attempt at getting the information
in the following PR into the docs:
https://github.com/ceph/ceph/pull/46000/files

Himadri Maheshwari deserves the credit for the work
in this commit.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
Signed-off-by: Himadri Maheshwari <himadri.maheshwari7915@gmail.com>
2 years agorgw/lua: handle null lua manager in librgw 47964/head
Yuval Lifshitz [Sun, 4 Sep 2022 13:11:36 +0000 (16:11 +0300)]
rgw/lua: handle null lua manager in librgw

Fixes: https://tracker.ceph.com/issues/57418
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #47571 from rhcs-dashboard/nfs-form-squash-norequired
Nizamudeen A [Sun, 4 Sep 2022 07:30:17 +0000 (13:00 +0530)]
Merge pull request #47571 from rhcs-dashboard/nfs-form-squash-norequired

mgr/dashboard: fix nfs exports form issues with squash field

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2 years agomgr/dashboard: fix Cannot read properties of undefined (reading 'filter') 47959/head
Nizamudeen A [Sun, 4 Sep 2022 05:52:45 +0000 (11:22 +0530)]
mgr/dashboard: fix Cannot read properties of undefined (reading 'filter')

Fixes: https://tracker.ceph.com/issues/57434
Signed-off-by: Nizamudeen A <nia@redhat.com>