]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Matan Breizman [Thu, 11 Aug 2022 08:01:27 +0000 (08:01 +0000)]
qa/suites: Reduce rados_python time out
This test runs for few minutes,
reducing timeout from 3h to 1h to avoid hanging jobs.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 10 Aug 2022 13:51:43 +0000 (13:51 +0000)]
qa/crimson-rados: add 'wait' attribute
wait_for_complete tests currently hanging with crimson-osd
and are temporary disabled in Crimson suite.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 10 Aug 2022 10:03:45 +0000 (10:03 +0000)]
test/pybind/test_rados: test_remove_omap_range2 typo
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 10 Aug 2022 09:55:06 +0000 (09:55 +0000)]
crimson/os/cyanstore: omap_rm_keyrange don't remove last key in range
Following our other backends behaviour with ranged key removal.
Caused a failure in test_rados (test_remove_omap_range2)
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Kefu Chai [Sat, 6 Aug 2022 07:52:44 +0000 (15:52 +0800)]
Merge pull request #47485 from tchaikov/crimson-os-cleanups
crimson/os: cleanups
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Anthony D'Atri [Sat, 6 Aug 2022 05:56:36 +0000 (22:56 -0700)]
Merge pull request #47487 from snosratiershad/examples/add-allow-unordered-to-list-objects-v2-extention-support
examples/boto3: add ListObjectsV2Request shape to boto3 sdk extras with AllowUnordered as member
Salar Nosrati-Ershad [Sat, 6 Aug 2022 03:29:19 +0000 (07:59 +0430)]
examples/boto3: add ListObjectsV2Request shape to boto3 sdk extras with AllowUnordered as member
feat: add ListObjectsV2Request shape to boto3 sdk extras with AllowUnordered as member
feat: add list-objects-v2 unordered supports to doc
Signed-off-by: Salar Nosrati-Ershad <snosratiershad@gmail.com>
Kefu Chai [Sat, 6 Aug 2022 03:57:49 +0000 (11:57 +0800)]
Merge pull request #44772 from ybwang0211/Bucket-Operations-doc
doc: Make the SYNTAX code writing of some interfaces of the api document consistent with others
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 6 Aug 2022 03:00:27 +0000 (11:00 +0800)]
Merge pull request #46989 from petrutlucian94/boost_shared_mutex
common: use boost::shared_mutex on Windows
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 6 Aug 2022 02:58:37 +0000 (10:58 +0800)]
Merge pull request #47216 from sseshasa/wip-fix-high-cpu-util-in-process
osd: Handle oncommits and wait for future work items from mClock queue
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Fri, 5 Aug 2022 23:53:11 +0000 (07:53 +0800)]
crimson/osd: trade macro for type alias
for better readablity.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 05:44:54 +0000 (13:44 +0800)]
crimson/os: drop unused function
Btree::compare(const ghobject_t &l, const ghobject_t &r) is never used,
so let's drop it.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 5 Aug 2022 23:06:45 +0000 (07:06 +0800)]
Merge pull request #47309 from Thingee/update-foundation-mems-202207
doc: Updating Ceph Foundation members for July
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Kefu Chai [Fri, 5 Aug 2022 22:51:23 +0000 (06:51 +0800)]
Merge pull request #47478 from tchaikov/wip-cmake-cython
cmake: remove spaces in macro used for compiling cython code
Reviewed-by: Tim Serong <tserong@suse.com>
Laura Flores [Fri, 5 Aug 2022 19:14:17 +0000 (14:14 -0500)]
Merge pull request #47481 from ljflores/wip-github-actions
.github/workflows: increase operations-per-run to 100 in stale bot
Laura Flores [Fri, 5 Aug 2022 16:34:20 +0000 (11:34 -0500)]
.github/workflows: increase operations-per-run to 100 in stale bot
The stale bot's `operations-per-run`
(https://github.com/actions/stale#operations-per-run) corresponds to the max
number of API calls it is allowed to make per hour. Currently,
`operations-per-run` is set to 30, which means that the stale bot
can make up to 30 API calls per hour.
With this limit in place, the stale bot is only able to process 400 PRs at a time.
Since there are 900+ PRs in the Ceph repository, we should increase the number of
operations to cover them all. This needs to be done with care though, since GitHub
has a rate limit
(https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting)
depending on business plan.
According to GitHub's documentation on GitHub action requests
(https://docs.github.com/en/rest/overview/resources-in-the-rest-api#requests-from-github-actions),
the rate limit is 1,000 requests per hour per repository when using `GITHUB_TOKEN` (which we are).
For enterprise accounts, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000
requests per hour per repository.
Based on this information, we should be fine to increase the max `operations-per-run`
to 100. This would cover a little over 1000 PRs, which should be enough
to process the 900-some-odd PRs in the Ceph repository.
Signed-off-by: Laura Flores <lflores@redhat.com>
David Galloway [Fri, 5 Aug 2022 12:51:27 +0000 (08:51 -0400)]
Merge pull request #47459 from tchaikov/wip-cmake-debian-python
cmake: install pure python module to deb_system path
kalebskeithley [Fri, 5 Aug 2022 12:27:13 +0000 (08:27 -0400)]
Merge pull request #47397 from kalebskeithley/luamgr
rgw: lua, add support for lua packages to the lua manager
Kefu Chai [Fri, 5 Aug 2022 08:40:41 +0000 (16:40 +0800)]
cmake: remove spaces in macro used for compiling cython code
we are facing following FTBFS on jammy + GCC-11.2 + Cython 0.29 +
CMake 3.22:
creating /home/jenkins-build/build/workspace/ceph-api/build/lib/cython_modules/temp.linux-x86_64-3.10/home/jenkins-build/build/workspace/ceph-api/build/src/pybind/cephfs
compile options: '-I/usr/include/python3.10 -I/usr/include/python3.10 -c'
extra options: '-Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -iquote/home/jenkins-build/build/workspace/ceph-api/src/include -w -Dvoid0=dead_function(void) -D__Pyx_check_single_interpreter(ARG)=ARG ## 0 -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2'
cc: /home/jenkins-build/build/workspace/ceph-api/build/src/pybind/cephfs/cephfs.c
cc: warning: ##: linker input file unused because linking not done
cc: error: ##: linker input file not found: No such file or directory
cc: warning: 0: linker input file unused because linking not done
cc: error: 0: linker input file not found: No such file or directory
it seems cython is not able to escape the space in the "extra options"
anymore, so the "##" and "0" are considered as object files passed to
compiler in addition to cephfs.c.
in this change the spaces are removed to help cython to make the right
decision.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 5 Aug 2022 07:59:34 +0000 (15:59 +0800)]
Merge pull request #47470 from tchaikov/wip-win32-silence-warning
dokan: cast variable to the expected type before comparison
Reviewed-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Yingxin [Fri, 5 Aug 2022 06:41:10 +0000 (14:41 +0800)]
Merge pull request #47471 from cyx1231st/wip-seastore-cleanup-paddr
crimson/os/seastore: cleanups and extentions to paddr_t related classes
Reviewed-by: Samuel Just <sjust@redhat.com>
Venky Shankar [Fri, 5 Aug 2022 06:31:13 +0000 (12:01 +0530)]
Merge pull request #47214 from nmshelke/minor-fixes
docs: minor doc fixes of showing in progress clones for a snapshot
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com
Kefu Chai [Fri, 5 Aug 2022 06:16:17 +0000 (14:16 +0800)]
Merge pull request #47472 from tchaikov/wip-do-cmake-with-newer-gcc
do_cmake:sh: use newer gcc if available
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 5 Aug 2022 02:20:06 +0000 (10:20 +0800)]
crimson/os/seastore: introduce P_ADDR_ROOT
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 4 Aug 2022 14:09:03 +0000 (22:09 +0800)]
crimson/os/seastore: cleanup, call paddr_t's explicit function where possible
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 4 Aug 2022 13:19:00 +0000 (21:19 +0800)]
crimson/os/seastore: extend reserved device ids to 8 bits
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 4 Aug 2022 12:56:58 +0000 (20:56 +0800)]
crimson/os/seastore: cleanup, introduce res_paddr_t with paddr_types_t::RESERVED
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Fri, 5 Aug 2022 03:48:30 +0000 (11:48 +0800)]
do_cmake:sh: use newer gcc if available
despite that we are using clang in `run-make-check.sh`, `do_cmake.sh`
is still used by some workflows like jenkins' ceph-pr-api job.
now that we've migrated to C++20, we need to use GCC-11 or up for
building the tree. GCC-11 is installed from PPA repo in
`install-deps.sh`, but to avoid interfere with the build of older
branches which do not use GCC-11, as their builds might break if
we use GCC-11 for building them. we don't use the alternative machinary
to point gcc to gcc-11, see
8f342a32ce4a236c45c67497ae34f508e032a9e1 .
so, in this change, we try to use the newest GCC in system when
running `do_cmake.sh`.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Yingxin Cheng [Thu, 4 Aug 2022 04:07:24 +0000 (12:07 +0800)]
crimson/os/seastore: cleanup paddr_t classes
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 4 Aug 2022 02:08:36 +0000 (10:08 +0800)]
crimson/os/seastore: cleanup segment_id_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 4 Aug 2022 01:23:25 +0000 (09:23 +0800)]
crimson/os/seastore: cleanup DEVICE_ID_BITS
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Thu, 4 Aug 2022 13:52:43 +0000 (21:52 +0800)]
cmake,debian: install pure python module to deb_system path
in ubuntu 22.04 and debian unstable, the layout (scheme) for system
python module is named "deb_system", the default one is 'posix_local'.
and 'posix_local' installs python modules into paths like
usr/local/lib/python3.10/dist-packages/. hence dh_install fails
when it tries to find the files to be packaged under directory of
usr/lib/python3*/site-packages/.
in this change, the "deb_system" scheme is used if it is available,
and fall back to "posix_prefix" to be backward compatible with older
debian (derivative) distros.
also, update the source directories of pure python's installation
from `site-packages` to `*-packages`, to be compatible with ubuntu focal
and ubuntu jammy. as we are now using the specified scheme instead of
the default one.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 5 Aug 2022 00:17:45 +0000 (08:17 +0800)]
dokan: cast variable to the expected type before comparison
to fix the FTBFS due to following warning:
```
/home/jenkins-build/build/workspace/ceph-windows-pull-requests/ceph/build.deps/src/dokany/dokan/dokan.h:723:22: error: narrowing conversion of '-1' from 'int' to 'long unsigned int' [-Wnarrowing]
723 | #define DOKAN_ERROR -1
| ^
```
also, clean up the following warning:
```
/home/jenkins-build/build/workspace/ceph-windows-pull-requests/ceph/src/dokan/dbg.cc:142:62: warning: NULL used in arithmetic [-Wpointer-arith]
142 | o << "\n\tIsDirectory: " << (DokanFileInfo->IsDirectory != NULL);
|
```
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 5 Aug 2022 00:29:35 +0000 (08:29 +0800)]
Merge pull request #47427 from tchaikov/wip-strong-ordering
include, common, osd: use std::strong_ordering machinery
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Fri, 5 Aug 2022 00:22:02 +0000 (08:22 +0800)]
Merge pull request #47462 from ronen-fr/wip-rf-list-snapset
tests/osd: fix a test to follow an output formatting change
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Thu, 4 Aug 2022 23:51:35 +0000 (07:51 +0800)]
Merge pull request #47461 from tchaikov/wip-wip32-deps
win32_deps_build.sh: bump curl to curl-7_84_0
Reviewed-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Casey Bodley [Thu, 4 Aug 2022 23:24:18 +0000 (19:24 -0400)]
Merge pull request #47468 from cbodley/wip-cmake-exporter-no-mgr
cmake: ceph-exporter fix for WITH_MGR=OFF
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Casey Bodley [Thu, 4 Aug 2022 18:25:19 +0000 (14:25 -0400)]
cmake: ceph-exporter fix for WITH_MGR=OFF
removing vstart-base's unconditional dependency on ceph-exporter. it's
added conditionally just below:
if (WITH_MGR)
add_dependencies(vstart-base ceph-mgr)
add_dependencies(vstart-base ceph-exporter)
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ronen Friedman [Thu, 4 Aug 2022 15:46:11 +0000 (15:46 +0000)]
tests/osd: fix a test to follow an output formatting change
PR#47255 modified the formatting of std::set-s. That broke
the osd-scrub-snaps.sh standalone test.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Kefu Chai [Thu, 4 Aug 2022 15:06:04 +0000 (23:06 +0800)]
win32_deps_build.sh: bump curl to curl-7_84_0
to silence warnings like:
```
configure.ac:3671: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:3671: You should run autoupdate.
```
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Nikhilkumar Shelke [Thu, 21 Jul 2022 16:58:27 +0000 (22:28 +0530)]
docs: minor doc fixes of showing in progress clones for a snapshot
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
Kefu Chai [Wed, 3 Aug 2022 03:49:32 +0000 (11:49 +0800)]
common,include: drop include/cmp.h
it is not used anymore. so just ditch it.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 03:40:50 +0000 (11:40 +0800)]
common: drop WRITE_{EQ,CMP}_OPERATORS_7()
the default-generated comparison operators can fulfill our needs.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 04:04:16 +0000 (12:04 +0800)]
osd: implement three-way comparison operator for basic types
this is the prerequisite for implementing the three-way comparison
operator for types which aggregates these basic types
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 03:07:17 +0000 (11:07 +0800)]
common: drop WRITE_{EQ,CMP}_OPERATORS_5()
the default-generated comparison operators can fulfill our needs.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 03:02:52 +0000 (11:02 +0800)]
common: drop WRITE_{EQ,CMP}_OPERATORS_4()
the default-generated comparison operators can fulfill our needs.
the order of member variables of `ghobject_t` is adjusted to match
the ordering of `ghobject_t`. the default-generated three-way
comparison operator uses the order in which the member variables
are declared to do the lexical comparison.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 02:53:04 +0000 (10:53 +0800)]
librados, os: drop WRITE_{EQ,CMP}_OPERATORS_3()
the default-generated comparison operators can fulfill our needs.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 02:50:00 +0000 (10:50 +0800)]
include: drop WRITE_{EQ,CMP}_OPERATORS_2()
the default-generated comparison operators can fulfill our needs.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 02:38:58 +0000 (10:38 +0800)]
include: drop WRITE_{EQ,CMP}_OPERATORS_1()
the default-generated comparison operators can fulfill our needs.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 3 Aug 2022 02:37:36 +0000 (10:37 +0800)]
osd/osd: do not init OSDOp::rval explicitly
errorcode32_t's ctor can take care of this. it sets the internal value
to 0.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Thu, 4 Aug 2022 13:30:51 +0000 (21:30 +0800)]
Merge pull request #47449 from tchaikov/rpm-gts-11
ceph.spec.in: build with gcc-toolset-11
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Venky Shankar [Thu, 4 Aug 2022 13:10:10 +0000 (18:40 +0530)]
Merge pull request #46876 from neesingh-rh/feature_55821
mgr/volumes: add interface to check the presence of subvolumegroups/subvolumes
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Kefu Chai [Thu, 4 Aug 2022 05:09:11 +0000 (13:09 +0800)]
cmake: disable LTO when building pmdk
See-also: https://tracker.ceph.com/issues/54473
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Thu, 4 Aug 2022 06:12:34 +0000 (14:12 +0800)]
debian: use dpkg/default.mk to init popular make variables
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Nizamudeen A [Thu, 4 Aug 2022 07:28:03 +0000 (12:58 +0530)]
Merge pull request #47263 from rhcs-dashboard/fix-host-service-instances
mgr/dashboard: host list tables doesn't show all services deployed
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
Avan [Thu, 4 Aug 2022 06:18:54 +0000 (11:48 +0530)]
Merge pull request #46213 from ceph/feature-exporter
exporter: per node metric exporter
Reviewed-by: MrFreezeex <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
Kefu Chai [Thu, 4 Aug 2022 03:57:05 +0000 (11:57 +0800)]
ceph.spec.in: BuildRequires gcc-toolset-11-libatomic-devel for aarch64
to address following failure when generating the building system
using CMake:
```
-- Performing Test HAVE_LIBATOMIC
-- Performing Test HAVE_LIBATOMIC - Failed
CMake Error at cmake/modules/CheckCxxAtomic.cmake:66 (message):
Host compiler /opt/rh/gcc-toolset-11/root/usr/bin/c++ requires libatomic,
but it is not found
```
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Thu, 4 Aug 2022 01:00:29 +0000 (09:00 +0800)]
ceph.spec.in: call %enable_devtoolset11 on centos8
before this change %enable_devtoolset11 is called only when building
with crimson on centos8.
after this change %enable_devtoolset11 is called when building on
centos8. because we've started using gcc-toolset-11 for building
rpm packages on centos8 after the C++20 migration. so, to build
with gcc-11, we need to enable it.
also, because gcc-toolset-11 is used, we have to disable
annotated_build.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Adam King [Wed, 3 Aug 2022 19:52:07 +0000 (15:52 -0400)]
Merge pull request #47299 from hookak/loki-dependency
mgr/cephadm: Add loki dependency to grafana, promtail
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Yuri Weinstein [Wed, 3 Aug 2022 15:04:58 +0000 (08:04 -0700)]
Merge pull request #47165 from NitzanMordhai/wip-nitzan-librados-ioctx-destroy-Segmentation-fault
librados: rados_ioctx_destroy check for initialized ioctx
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Wed, 3 Aug 2022 15:03:52 +0000 (08:03 -0700)]
Merge pull request #47138 from kamoltat/wip-ksirivad-fix-test-pool-min-size
qa/tasks/ceph_manager.py: increase test_pool_min_size timeout
Reviewed-by: Neha Ojha <nojha@redhat.com>
Yuri Weinstein [Wed, 3 Aug 2022 15:03:24 +0000 (08:03 -0700)]
Merge pull request #47065 from ifed01/wip-ifed-fix-blufs-unlink-fsync
os/bluestore: do not signal deleted dirty file to bluefs log
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Yuri Weinstein [Wed, 3 Aug 2022 15:02:33 +0000 (08:02 -0700)]
Merge pull request #46838 from pdvian/wip-version-mgrupdate
mgr: Remove service_daemon handling from MMgrUpdate
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Yuri Weinstein [Wed, 3 Aug 2022 15:01:45 +0000 (08:01 -0700)]
Merge pull request #46507 from aclamk/wip-memstore-leak
os/memstore: Fix memory leak
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Wed, 3 Aug 2022 15:01:00 +0000 (08:01 -0700)]
Merge pull request #44774 from rishabh-d-dave/qa-cleanup
qa/ceph_manager: clean up CephManager.do_rados()
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Wed, 3 Aug 2022 14:27:15 +0000 (22:27 +0800)]
Merge pull request #47327 from rosinL/fix-op-release
crimson/osd/osd_operation: fix abort caused by op be deleted ahead
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Venky Shankar [Wed, 3 Aug 2022 14:18:27 +0000 (19:48 +0530)]
Merge pull request #47026 from lxbsz/wip-56517
fuse_ll: fix compile error when libfuse version is larger than 3.0
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Luis Henriques <lhenriques@suse.de>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Kefu Chai [Wed, 3 Aug 2022 13:32:27 +0000 (21:32 +0800)]
Merge pull request #47412 from rzarzynski/wip-crimson-monc-nothrow-on-renewal
crimson/net: don't throw on failure when renewing tickets and keyrings
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Guillaume Abrioux [Wed, 3 Aug 2022 11:28:51 +0000 (13:28 +0200)]
Merge pull request #47434 from guits/cv-fix-test-get-file-content
ceph-volume/tests: fix test_exception_returns_default
Yuval Lifshitz [Wed, 3 Aug 2022 11:13:52 +0000 (14:13 +0300)]
Merge pull request #47177 from yuvalif/wip-yuval-backport-doc-fix
doc: change "master" to "main" in backport doc
reviewed-by: anthonyeleven, ljflores, zdover23
Avan Thakkar [Mon, 1 Aug 2022 06:50:53 +0000 (12:20 +0530)]
exporter: per node metric exporter
Fixes: https://tracker.ceph.com/issues/55046
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Kefu Chai [Wed, 3 Aug 2022 10:49:10 +0000 (18:49 +0800)]
Merge pull request #47428 from tchaikov/wip-crimson-strong-ordering
crimson: use std::strong_ordering mechinary
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Nizamudeen A [Wed, 3 Aug 2022 10:26:17 +0000 (15:56 +0530)]
Merge pull request #46863 from bryanmontalvan/dashboard-matcher
mgr/dashboard: Simplified silence-form matchers list layout
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Avan Thakkar [Wed, 3 Aug 2022 08:45:02 +0000 (14:15 +0530)]
mgr/dashboard: add cephadm e2e tests for checking count for services instances
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Kefu Chai [Wed, 3 Aug 2022 03:03:19 +0000 (11:03 +0800)]
crimson/os: do not use WRITE_*_OPERATORS_{3,4}()
the default-generated comparison operator is able to fulfill our needs
already.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Guillaume Abrioux [Wed, 3 Aug 2022 09:16:36 +0000 (11:16 +0200)]
ceph-volume/tests: fix test_exception_returns_default
There are cases, like running tests as root user, where this test fails
because root user can always read the file content.
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
yuval Lifshitz [Tue, 19 Jul 2022 18:04:31 +0000 (21:04 +0300)]
doc: change "master" to "main" in backport doc
also fix the alias setting example
Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
Nizamudeen A [Wed, 3 Aug 2022 06:55:49 +0000 (12:25 +0530)]
Merge pull request #47418 from rhcs-dashboard/token-logs-no-good
mgr/dashboard: remove token logging
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Tim Serong [Wed, 3 Aug 2022 06:45:06 +0000 (16:45 +1000)]
Merge pull request #47429 from SUSE/wip-suse-gcc11-or-greater
ceph.spec.in: set BuildRequires: gcc-c++ >= 11 for SUSE distros
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Yingxin [Wed, 3 Aug 2022 05:20:32 +0000 (13:20 +0800)]
Merge pull request #47426 from cyx1231st/wip-seastore-silence-this
crimson: capture this explicitly to silence warnings
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Tim Serong [Wed, 3 Aug 2022 05:20:23 +0000 (15:20 +1000)]
ceph.spec.in: set BuildRequires: gcc-c++ >= 11 for SUSE distros
This is much simpler than explicitly requiring gcc 11, and
anyway, openSUSE Tumbleweed is up to gcc 12 now.
Signed-off-by: Tim Serong <tserong@suse.com>
Kefu Chai [Wed, 3 Aug 2022 02:52:20 +0000 (10:52 +0800)]
crimson: do not use WRITE_{EQ,CMP}_OPERATORS_2()
the default-generated comparison operators can fulfill our needs.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Yingxin Cheng [Wed, 3 Aug 2022 03:34:56 +0000 (11:34 +0800)]
crimson: capture this explicitly
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kaleb S. KEITHLEY [Mon, 1 Aug 2022 21:30:32 +0000 (17:30 -0400)]
rgw: lua, add support for lua packages to the lua manager
Refactor lua manager, adding new {add,remove}_package(), and
list_packages() methods; and changing get(), put(), del() methods
to {get,put,del}_script(). Renaming class from *LuaScriptManager
to *LuaManager to be consistent with dual *script and *package
functionality.
Note: I considered keeping the existing *LuaScriptManager classes
as is and adding *LuaPackageManager classes, but that seemed/seems
like overkill to me.
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Pere Diaz Bou [Tue, 2 Aug 2022 16:56:49 +0000 (18:56 +0200)]
mgr/dashboard: remove token logging
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
bryanmontalvan [Mon, 27 Jun 2022 19:43:58 +0000 (15:43 -0400)]
mgr/dashboard: Simplified silence-form matchers list
This commit removes unmeaning icons on the matchers-list component, and
now only displays the information/content needed when viewing and editing
matchers.
Fixes: https://tracker.ceph.com/issues/42306
Signed-off-by: Bryan Montalvan <bmontalv@redhat.com>
Radoslaw Zarzynski [Tue, 2 Aug 2022 13:42:01 +0000 (13:42 +0000)]
crimson/net: don't throw on failure when renewing tickets and keyrings
In the classical `MonClient` renewal of tickets and rotating
secrets, generally speaking, doesn't verify the `MAuthReply`.
The only difference is breaking the renewal loop:
```cpp
void MonClient::_finish_auth(int auth_err)
{
// ...
if (!auth_err && active_con) {
ceph_assert(auth);
_check_auth_tickets();
}
// ...
}
```
However, `crimson::mon::Client` throws `error::negotiation_failure`
which is finally handled in `Gated::dispatch()`. As the handler
there doesn't expect this particular error, it aborts the entire
process. This was the reason for failing one of the jobs at Sepia:
```
rzarzynski@teuthology:/a/rzarzynski-2022-08-01_11:01:29-crimson-rados-main-distro-default-smithi/
6954468 $ less ./remote/smithi174/log/ceph-osd.1.log.gz
...
DEBUG 2022-08-01 11:26:13,772 [shard 0] monc - renew_rotating_keyring secrets are up-to-date (they expire after
1659353143 .772506)
INFO 2022-08-01 11:26:13,772 [shard 0] monc - renew_tickets: retrieving new tickets
INFO 2022-08-01 11:26:13,772 [shard 0] monc - sending auth(proto 2 132 bytes epoch 0) v1
INFO 2022-08-01 11:26:13,772 [shard 0] monc - waiting
INFO 2022-08-01 11:26:13,773 [shard 0] monc - handle_auth_reply mon v2:172.21.15.174:6802/101543 => v2:172.21.15.174:3300/0 returns auth_reply(proto 2 0 (0) Success) v1: 0
INFO 2022-08-01 11:26:13,773 [shard 0] monc - handle_auth_reply
INFO 2022-08-01 11:26:13,773 [shard 0] monc - renew_tickets: retrieving new tickets
INFO 2022-08-01 11:26:13,773 [shard 0] monc - sending auth(proto 2 132 bytes epoch 0) v1
DEBUG 2022-08-01 11:26:13,773 [shard 0] monc - renew_rotating_keyring secrets are up-to-date (they expire after
1659353143 .
7732666 )
INFO 2022-08-01 11:26:13,773 [shard 0] monc - waiting
INFO 2022-08-01 11:26:13,773 [shard 0] monc - do_auth_single: mon v2:172.21.15.174:6802/101543 => v2:172.21.15.174:3300/0 returns auth_reply(proto 2 0 (0) Success) v1: 0
INFO 2022-08-01 11:26:13,773 [shard 0] monc - handle_auth_reply mon v2:172.21.15.174:6802/101543 => v2:172.21.15.174:3300/0 returns auth_reply(proto 2 0 (0) Success) v1: 0
INFO 2022-08-01 11:26:13,773 [shard 0] monc - handle_auth_reply
INFO 2022-08-01 11:26:13,773 [shard 0] monc - do_auth_single: mon v2:172.21.15.174:6802/101543 => v2:172.21.15.174:3300/0 returns auth_reply(proto 2 0 (0) Success) v1: 0
WARN 2022-08-01 11:26:13,773 [shard 0] auth - cephx client: could not verify service_ticket reply
ERROR 2022-08-01 11:26:13,773 [shard 0] monc - do_auth_single: got error -13 on mon v2:172.21.15.174:3300/0
DEBUG 2022-08-01 11:26:13,773 [shard 0] monc - renew_tickets: don't need new tickets
DEBUG 2022-08-01 11:26:13,774 [shard 0] monc - renew_rotating_keyring secrets are up-to-date (they expire after
1659353143 .773988)
ERROR 2022-08-01 11:26:13,774 [shard 0] osd - mon.osd.1 dispatch() ms_dispatch caught exception: std::system_error (error crimson::net:3, negotiation failure)
```
```
2022-08-01T11:26:13.798 INFO:tasks.ceph.osd.1.smithi174.stderr:ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/giga
ntic/release/
17.0.0-13947-g4f4eedf5 /rpm/el8/BUILD/
ceph-17.0.0-13947-g4f4eedf5 /src/crimson/common/gated.h:36: crimson::common::Gated::dispatch<crimson::mon::Client::ms_dispatch(crimson::net::ConnectionRef, MessageRef)::<lambda()>&, crimson::mon::Client>(const char*, crimson::mon::Client&, crimson::mon::Client::ms_dispatch(crimson::net::ConnectionRef, MessageRef)::<lambda()>&)::<lambda(std::__exception_ptr::exception_ptr)>: Assertion `*eptr.__cxa_exception_type() == typeid(seastar::gate_closed_exception)' failed.
2022-08-01T11:26:13.811 INFO:tasks.ceph.osd.1.smithi174.stderr:Aborting on shard 0.
```
```cpp
class Gated {
// ...
template <typename Func, typename T>
inline seastar::future<> dispatch(const char* what, T& who, Func&& func) {
return seastar::with_gate(pending_dispatch, std::forward<Func>(func)
).handle_exception([what, &who] (std::exception_ptr eptr) {
if (*eptr.__cxa_exception_type() == typeid(system_shutdown_exception)) {
gated_logger().debug(
"{}, {} skipped, system shutdown", who, what);
return;
}
gated_logger().error(
"{} dispatch() {} caught exception: {}", who, what, eptr);
assert(*eptr.__cxa_exception_type()
== typeid(seastar::gate_closed_exception));
});
}
```
See: http://pulpito.front.sepia.ceph.com/rzarzynski-2022-08-01_11:01:29-crimson-rados-main-distro-default-smithi/
6954468 /
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Nizamudeen A [Tue, 2 Aug 2022 08:09:18 +0000 (13:39 +0530)]
Merge pull request #47261 from rhcs-dashboard/fix-duplicate-service-creation
mgr/dashboard: Show error on creating service with duplicate service id
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Aashish Sharma [Mon, 25 Jul 2022 08:18:39 +0000 (13:48 +0530)]
mgr/dashboard: Show error on creating service with duplicate service id
Fixes: https://tracker.ceph.com/issues/56689
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Kefu Chai [Tue, 2 Aug 2022 02:33:55 +0000 (10:33 +0800)]
Merge pull request #47398 from tchaikov/wip-crimson-capture-this
crimson: capture "this" explicitly
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Mon, 1 Aug 2022 23:59:42 +0000 (07:59 +0800)]
crimson: capture "this" explicitly
to silence warnings like:
```
alien_store.cc:577:64: warning: implicit capture of ‘this’ via ‘[=]’ is
deprecated in C++20 [-Wdeprecated]
577 | return tp->submit(ch->get_cid().hash_to_shard(tp->size()),
[=, &bl] {
| ^
```
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Mon, 1 Aug 2022 22:49:03 +0000 (06:49 +0800)]
Merge pull request #45133 from cbodley/wip-cxx20-fixes
enable c++20
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
David Galloway [Mon, 1 Aug 2022 18:55:14 +0000 (14:55 -0400)]
Merge pull request #47197 from ceph/boost-docs
doc/dev: Elaborate on boost .deb creation
Ali Maredia [Mon, 1 Aug 2022 18:06:34 +0000 (14:06 -0400)]
Merge pull request #47262 from shriya-deshmukh/fix-delete-bucket-tagging-issue
rgw: Return correct status code in case of DeleteBucketTagging API.
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Avan Thakkar [Mon, 25 Jul 2022 13:49:22 +0000 (19:19 +0530)]
mgr/dashboard: cluster > hosts: host list tables doesn't show all services deployed
Fixes: https://tracker.ceph.com/issues/53210
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Service instances was displaying only the ceph services, but with these changes it'll display instances
of cephadm services as well.
Adam King [Mon, 1 Aug 2022 15:14:13 +0000 (11:14 -0400)]
Merge pull request #47385 from rhcs-dashboard/fix-flake8
mgr: fix flake8:missing whitespace after keyword for assert() & yield()
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Avan Thakkar [Mon, 1 Aug 2022 09:23:14 +0000 (14:53 +0530)]
mgr/cephadm: fix flake8
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Nizamudeen A [Mon, 1 Aug 2022 08:17:03 +0000 (13:47 +0530)]
Merge pull request #47334 from s0nea/wip-osd-objectstore-types-fix
monitoring/ceph-mixin: OSD overview typo fix
Reviewed-by: MrFreezeex <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
jinhong.kim [Wed, 27 Jul 2022 10:49:04 +0000 (19:49 +0900)]
mgr/cephadm: Add loki dependency to grafana, promtail
- Add loki dependency in order to be consistent with _calc_daemon_deps()
- Add dependency for all loki daemon
Signed-off-by: jinhong.kim <jinhong.kim0@navercorp.com>
Soumya Koduri [Mon, 1 Aug 2022 04:05:43 +0000 (09:35 +0530)]
Merge pull request #45602 from soumyakoduri/wip-skoduri-dbstore-obj-versioning
rgw/dbstore: Object versioning feature support
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>