]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc: virtio discard is supported since kernel 5.0 47716/head
Malte Janduda [Sun, 21 Aug 2022 10:30:08 +0000 (12:30 +0200)]
doc: virtio discard is supported since kernel 5.0

Signed-off-by: Malte Janduda <mail@janduda.net>
2 years agoMerge pull request #47639 from ronen-fr/wip-rf-scrubmap-swap
Ronen Friedman [Sun, 21 Aug 2022 05:57:19 +0000 (08:57 +0300)]
Merge pull request #47639 from ronen-fr/wip-rf-scrubmap-swap

osd: fix ScrubMap::swap() to include all ScrubMap data members
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #44356 from SMIL-Infra/clog
Kefu Chai [Sat, 20 Aug 2022 13:55:22 +0000 (21:55 +0800)]
Merge pull request #44356 from SMIL-Infra/clog

common,mon: use fmt::print(cerr, ...) for stderr logging

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47325 from CongMinYin/fix-owner-lock-ordering
Ilya Dryomov [Sat, 20 Aug 2022 10:41:55 +0000 (12:41 +0200)]
Merge pull request #47325 from CongMinYin/fix-owner-lock-ordering

librbd/cache/pwl: narrow the scope of m_lock in write_image_cache_state()

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #47628 from mkogan1/wip-fix-tcmalloc-link
Casey Bodley [Fri, 19 Aug 2022 17:34:47 +0000 (13:34 -0400)]
Merge pull request #47628 from mkogan1/wip-fix-tcmalloc-link

rgw: fix linking with tcmalloc when specified by -DALLOCATOR

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoosd: modify two ScrubMap data members from fields to full variables 47639/head
Ronen Friedman [Tue, 16 Aug 2022 14:31:23 +0000 (17:31 +0300)]
osd: modify two ScrubMap data members from fields to full variables

as there is no size advantage in this specific case.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoosd: fix ScrubMap::swap() to include all ScrubMap data members
Ronen Friedman [Tue, 16 Aug 2022 14:25:48 +0000 (17:25 +0300)]
osd: fix ScrubMap::swap() to include all ScrubMap data members

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #47632 from linuxbox2/wip-rgw-53455
Casey Bodley [Fri, 19 Aug 2022 15:06:27 +0000 (11:06 -0400)]
Merge pull request #47632 from linuxbox2/wip-rgw-53455

rgw/s3: add conditional json output for s3:ListBucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #46443 from ybwang0211/head_obj
Casey Bodley [Fri, 19 Aug 2022 13:25:12 +0000 (09:25 -0400)]
Merge pull request #46443 from ybwang0211/head_obj

rgw: The error reported in the "rgw_s3_prepare_decrypt" function is unreasonable

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #46547 from Huber-ming/check_appendable
Casey Bodley [Fri, 19 Aug 2022 13:24:35 +0000 (09:24 -0400)]
Merge pull request #46547 from Huber-ming/check_appendable

rgw: check object appendable when check_disk_state

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47228 from Huber-ming/multi_meta
Casey Bodley [Fri, 19 Aug 2022 13:23:58 +0000 (09:23 -0400)]
Merge pull request #47228 from Huber-ming/multi_meta

rgw: 'bucket check' deletes index of multipart meta when its pending_map is nonempty

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47547 from mdw-at-linuxbox/wip-master-xamzdate-1
Casey Bodley [Fri, 19 Aug 2022 13:23:44 +0000 (09:23 -0400)]
Merge pull request #47547 from mdw-at-linuxbox/wip-master-xamzdate-1

rgw: x-amz-date change breaks certain cases of aws sig v4.

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #45036 from rishabh-d-dave/qa-fix-is_mounted
Rishabh Dave [Fri, 19 Aug 2022 13:13:59 +0000 (18:43 +0530)]
Merge pull request #45036 from rishabh-d-dave/qa-fix-is_mounted

qa/cephfs: upgrade is_mounted() in mount.py

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
2 years agoMerge pull request #45869 from neesingh-rh/fix_55234
Rishabh Dave [Fri, 19 Aug 2022 13:08:51 +0000 (18:38 +0530)]
Merge pull request #45869 from neesingh-rh/fix_55234

mgr/snap_schedule: replace .snap with the client configured snap dir name

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2 years agoMerge pull request #46749 from ibm-s390-cloud/fsmap_switch_to_iterator
Rishabh Dave [Fri, 19 Aug 2022 13:02:38 +0000 (18:32 +0530)]
Merge pull request #46749 from ibm-s390-cloud/fsmap_switch_to_iterator

fsmap: switch to using iterator based loop

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoMerge pull request #47691 from myoungwon/wip-cbjournal-integration
Yingxin [Fri, 19 Aug 2022 09:03:34 +0000 (17:03 +0800)]
Merge pull request #47691 from myoungwon/wip-cbjournal-integration

crimson/os/seastore: CBJournal integration works

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #47597 from NitzanMordhai/wip-nitzan-crimson-watch-list-empty...
Radoslaw Zarzynski [Fri, 19 Aug 2022 08:59:01 +0000 (10:59 +0200)]
Merge pull request #47597 from NitzanMordhai/wip-nitzan-crimson-watch-list-empty-return-code

crimson/osd: watch list empty return incorrect

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Sam Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #47670 from rzarzynski/wip-common-ftbfs-systemd
Kefu Chai [Fri, 19 Aug 2022 07:34:47 +0000 (15:34 +0800)]
Merge pull request #47670 from rzarzynski/wip-common-ftbfs-systemd

common: fix a FTBFS in Journald.cc when building without systemd

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47680 from tchaikov/wip-crimson-cleanups
Kefu Chai [Fri, 19 Aug 2022 04:40:06 +0000 (12:40 +0800)]
Merge pull request #47680 from tchaikov/wip-crimson-cleanups

crimson: cleanups to use `IsFullKey` concept

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore: introduce finish_commit to update tails after trim transaction 47691/head
myoungwon oh [Thu, 18 Aug 2022 16:29:00 +0000 (01:29 +0900)]
crimson/os/seastore: introduce finish_commit to update tails after trim transaction

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbjournal: rename journal_tail to dirty_tail
myoungwon oh [Tue, 9 Aug 2022 08:05:39 +0000 (17:05 +0900)]
crimson/os/seastore/cbjournal: rename journal_tail to dirty_tail

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbjournal: make cbjournal to store alloc_tail
myoungwon oh [Fri, 17 Jun 2022 05:25:10 +0000 (14:25 +0900)]
crimson/os/seastore/cbjournal: make cbjournal to store alloc_tail

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbjournal: make journal_tail and written_to to use journal_seq_t...
myoungwon oh [Fri, 3 Jun 2022 01:27:32 +0000 (10:27 +0900)]
crimson/os/seastore/cbjournal: make journal_tail and written_to to use journal_seq_t instead of rbm_abs_addr

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore: divide the role of open_device_read_header into device.mount()
myoungwon oh [Thu, 2 Jun 2022 06:43:14 +0000 (15:43 +0900)]
crimson/os/seastore: divide the role of open_device_read_header into device.mount()
and open_for_mount()

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agoMerge pull request #47615 from adamemerson/wip-objv-doc
Casey Bodley [Thu, 18 Aug 2022 22:22:15 +0000 (18:22 -0400)]
Merge pull request #47615 from adamemerson/wip-objv-doc

rgw: Document `RGWOvjVersionTracker`

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agolibrbd/cache/pwl: generate image cache state json under m_lock 47325/head
Ilya Dryomov [Thu, 18 Aug 2022 16:48:39 +0000 (18:48 +0200)]
librbd/cache/pwl: generate image cache state json under m_lock

The previous commit moved the entirety of write_image_cache_state()
from under m_lock.  This was a step too far because the generated image
cache state json is no longer guaranteed to be consistent.

Arrange for m_lock to still be held during image cache json generation
but released before owner_lock is grabbed.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agocrimson/os: make _node_fields_013_t::insert_at() use IsFullKey 47680/head
Kefu Chai [Thu, 18 Aug 2022 16:37:36 +0000 (00:37 +0800)]
crimson/os: make _node_fields_013_t::insert_at() use IsFullKey

less repeatings this way

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47288 from batrick/i56274
Josh Durgin [Thu, 18 Aug 2022 16:29:28 +0000 (09:29 -0700)]
Merge pull request #47288 from batrick/i56274

debian: add libsqlite3-mod-ceph dependency for ceph-mgr

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/os: define *::from_key() with IsFullKey
Kefu Chai [Thu, 18 Aug 2022 16:07:16 +0000 (00:07 +0800)]
crimson/os: define *::from_key() with IsFullKey

more compact this way.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson: move helper classes down
Kefu Chai [Thu, 18 Aug 2022 15:40:42 +0000 (23:40 +0800)]
crimson: move helper classes down

so we can use the concept of `IsFullKey` for defining accessors in the
incoming commit.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson: define encode_key() with IsFullKey constrait
Kefu Chai [Thu, 18 Aug 2022 15:10:21 +0000 (23:10 +0800)]
crimson: define encode_key() with IsFullKey constrait

also, let the compiler to deduce the type of the template parameter,
less repeating and less error-prone this way.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocommon: fix a FTBFS in Journald.cc when building without systemd 47670/head
Radosław Zarzyński [Thu, 18 Aug 2022 11:45:21 +0000 (13:45 +0200)]
common: fix a FTBFS in Journald.cc when building without systemd

This came from Josh Salomon:

```
/home/jsalomon/src/prim_score/src/common/Journald.h:93:24: error: ‘SubsystemMap’ does not name a type
   93 |   JournaldLogger(const SubsystemMap *) {}
      |                        ^~~~~~~~~~~~
/home/jsalomon/src/prim_score/src/common/Journald.h:94:23: error: ‘Entry’ does not name a type
   94 |   int log_entry(const Entry &) {
      |
```

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2 years agoMerge pull request #47633 from bosc0/alerts_multicluster
Arthur Outhenin-Chalandre [Thu, 18 Aug 2022 11:35:24 +0000 (13:35 +0200)]
Merge pull request #47633 from bosc0/alerts_multicluster

prometheus: add multicluster support to alerts

2 years agoMerge pull request #47554 from Matan-B/wip-matanb-c-rados-python
Matan [Thu, 18 Aug 2022 10:52:45 +0000 (13:52 +0300)]
Merge pull request #47554 from Matan-B/wip-matanb-c-rados-python

qa/suite/crimson-rados: Fix rados_python test

Reviewed by: Samuel Just <sjust@redhat.com>
Reviewed by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed by: Nitzan Mordechai <nmordech@redhat.com>

2 years agoMerge pull request #47653 from Matan-B/wip-matanb-snapmapper-pending-typo
Matan [Thu, 18 Aug 2022 05:56:38 +0000 (08:56 +0300)]
Merge pull request #47653 from Matan-B/wip-matanb-snapmapper-pending-typo

PendingReleaseNotes: fix typo in 15.2.17

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2 years agoMerge pull request #47392 from Matan-B/wip-matanb-memstore-subsys
Matan [Thu, 18 Aug 2022 05:48:59 +0000 (08:48 +0300)]
Merge pull request #47392 from Matan-B/wip-matanb-memstore-subsys

common: MemStore debug subsystem

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #47643 from aisakaki/wip-omap-merge
Yingxin [Thu, 18 Aug 2022 05:20:55 +0000 (13:20 +0800)]
Merge pull request #47643 from aisakaki/wip-omap-merge

crimson/os/seastore/omap: optimize merge policy

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #47558 from rzarzynski/wip-crimson-extradbgs
Yingxin [Thu, 18 Aug 2022 01:23:53 +0000 (09:23 +0800)]
Merge pull request #47558 from rzarzynski/wip-crimson-extradbgs

crimson/{net,osd}: add debugs after bughunt's investigations

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2 years agoMerge PR #47600 into main
Patrick Donnelly [Wed, 17 Aug 2022 17:51:13 +0000 (13:51 -0400)]
Merge PR #47600 into main

* refs/pull/47600/head:
doc: document debugging for libcephsqlite

Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #47523 from adk3798/oracle-linux-support
Adam King [Wed, 17 Aug 2022 16:49:49 +0000 (12:49 -0400)]
Merge pull request #47523 from adk3798/oracle-linux-support

cephadm: support for Oracle Linux 8

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoPendingReleaseNotes: fix typo in 15.2.17 47653/head
Matan Breizman [Wed, 17 Aug 2022 16:33:39 +0000 (16:33 +0000)]
PendingReleaseNotes: fix typo in 15.2.17

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #47422 from adamemerson/wip-coroutine-cleaver
Casey Bodley [Wed, 17 Aug 2022 14:00:04 +0000 (10:00 -0400)]
Merge pull request #47422 from adamemerson/wip-coroutine-cleaver

rgw: Break Full and Incremental sync out into their own classes

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoqa/suites: Reduce rados_python time out 47554/head
Matan Breizman [Thu, 11 Aug 2022 08:01:27 +0000 (08:01 +0000)]
qa/suites: Reduce rados_python time out

This test runs for few minutes,
reducing timeout from 3h to 1h to avoid hanging jobs.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoqa/crimson-rados: add 'wait' attribute
Matan Breizman [Wed, 10 Aug 2022 13:51:43 +0000 (13:51 +0000)]
qa/crimson-rados: add 'wait' attribute

wait_for_complete tests currently hanging with crimson-osd
and are temporary disabled in Crimson suite.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoceph-mixin: Remove jsonnet building 47633/head
Aswin Toni [Tue, 16 Aug 2022 14:17:21 +0000 (16:17 +0200)]
ceph-mixin: Remove jsonnet building

Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
2 years agoprometheus: add multicluster support to alerts
Aswin Toni [Tue, 16 Aug 2022 13:38:18 +0000 (15:38 +0200)]
prometheus: add multicluster support to alerts

Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
2 years agocrimson/os/seastore/omap: optimize merge policy 47643/head
Xinyu Huang [Wed, 17 Aug 2022 04:19:24 +0000 (04:19 +0000)]
crimson/os/seastore/omap: optimize merge policy

in some corner cases on single key erase sence,
for e.g. we have three nodes which are brothers:
1 2 3 4 5 | 6 7 8 | 9 10 11, node min size is 3.
When erasing 11 will trigger balance instead of
merge, the middle nodes will adjust to 6 7, this
will not ensure the all nodes above min size.
This corner case might not be harmful but if we
want to erase 10,11 at one time (range remove wip
need this), this will trigger balance in past
policy which will make both two nodes below min
size and we might need at least one more merge.
This is actually because we cannot ensure a node
to merge in tree is above min size.

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
2 years agocrimson/os/seastore/omap: code cleanup
Xinyu Huang [Tue, 16 Aug 2022 09:06:29 +0000 (09:06 +0000)]
crimson/os/seastore/omap: code cleanup

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
2 years agoMerge pull request #47491 from cyx1231st/wip-seastore-fix-return-future
Yingxin [Wed, 17 Aug 2022 08:39:22 +0000 (16:39 +0800)]
Merge pull request #47491 from cyx1231st/wip-seastore-fix-return-future

crimson/os/seastore/transaction_manager: return future when enoent

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #46855 from ronen-fr/wip-rf-pg-updates
Ronen Friedman [Wed, 17 Aug 2022 08:18:25 +0000 (11:18 +0300)]
Merge pull request #46855 from ronen-fr/wip-rf-pg-updates

osd/scrub: Scrubbing PGs now periodically update their stats

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
2 years agoMerge pull request #47553 from cyx1231st/wip-seastore-cleanup-reclaim
Yingxin [Wed, 17 Aug 2022 08:11:46 +0000 (16:11 +0800)]
Merge pull request #47553 from cyx1231st/wip-seastore-cleanup-reclaim

crimson/os/seastore: cleanups to gc reclaim

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Zhang Song <zhangsong325@gmail.com>
2 years agoMerge pull request #47477 from mchangir/doc-clarify-start-time-in-snap-schedule
Venky Shankar [Wed, 17 Aug 2022 07:06:10 +0000 (12:36 +0530)]
Merge pull request #47477 from mchangir/doc-clarify-start-time-in-snap-schedule

doc/cephfs: note regarding start time time zone

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoMerge pull request #47099 from joscollin/wip-B56537-wrong-rsp-wsp-values
Venky Shankar [Wed, 17 Aug 2022 05:44:21 +0000 (11:14 +0530)]
Merge pull request #47099 from joscollin/wip-B56537-wrong-rsp-wsp-values

cephfs-top: fix the rsp/wsp display

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agorgw/s3: add conditional json output for s3:ListBucket 47632/head
Matt Benjamin [Tue, 16 Aug 2022 12:56:54 +0000 (08:56 -0400)]
rgw/s3: add conditional json output for s3:ListBucket

Adapt the XML ListBucket response to contain well-formed JSON,
matching the implied schema of awscli:

$ aws --endpoint-url http://localhost:8000 s3api list-objects --bucket testbucket

suggested by Casey in review.

Fixes: https://tracker.ceph.com/issues/53455
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #47365 from adk3798/explicit-host-no-schedule
Adam King [Tue, 16 Aug 2022 18:35:16 +0000 (14:35 -0400)]
Merge pull request #47365 from adk3798/explicit-host-no-schedule

mgr/cephadm: fix handling of draining hosts with explicit placement specs

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #47529 from hookak/container-args
Adam King [Tue, 16 Aug 2022 18:32:03 +0000 (14:32 -0400)]
Merge pull request #47529 from hookak/container-args

cephadm: Remove duplicated process args in promtail and loki

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47545 from adk3798/grafana-password
Adam King [Tue, 16 Aug 2022 18:27:37 +0000 (14:27 -0400)]
Merge pull request #47545 from adk3798/grafana-password

mgr/cephadm: set dashboard grafana-api-password when user provides one

Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agorgw/s3: align output format with client request 47577/head
Matt Benjamin [Sat, 13 Aug 2022 18:57:22 +0000 (14:57 -0400)]
rgw/s3: align output format with client request

In general, e.g., in the S3 ListBucket response, the
output Formatter is already of the type requested in the HTTP
Accept header.

Therefore, while there are still many instances where the of
Formatter is assumed to be XML, it appears necessarily safe
and seemingly correct to extend this assumption to end_header(...),
which sends the response content-type.

Fixes: https://tracker.ceph.com/issues/55680
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/rest: replace RGW_FORMAT_ macros with an enum class
Matt Benjamin [Sat, 13 Aug 2022 18:29:10 +0000 (14:29 -0400)]
rgw/rest: replace RGW_FORMAT_ macros with an enum class

This is a pure cleanup.  The method to print an RGWFormat object
as a MIME type is now called to_mime_type().

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/iam: thread DoutPrefixProvider into policy evaluation
Matt Benjamin [Sat, 13 Aug 2022 17:08:03 +0000 (13:08 -0400)]
rgw/iam: thread DoutPrefixProvider into policy evaluation

Also conditionally prints policy and resource in verify_bucket_permission.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw: fix link dependencies when not building dbstore
Matt Benjamin [Sat, 13 Aug 2022 00:19:52 +0000 (20:19 -0400)]
rgw: fix link dependencies when not building dbstore

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoosd/scrub: PGs that are scrubbing now update stats periodically 46855/head
Ronen Friedman [Tue, 14 Jun 2022 14:36:13 +0000 (14:36 +0000)]
osd/scrub: PGs that are scrubbing now update stats periodically

Added periodic calls to all PGs for which the OSD is the primary,
asking for a scrub statistics update.

This allows operator queries (e.g. 'pg dump pgs') to present
up-to-date scrub duration, "scrub is blocked" duration, etc'.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #47565 from adk3798/unit-test-runtime 47147/head
Adam King [Tue, 16 Aug 2022 12:50:10 +0000 (08:50 -0400)]
Merge pull request #47565 from adk3798/unit-test-runtime

mgr/cephadm: mock CephadmHttpServer run in unit tests

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agodoc/cephfs: note regarding start time time zone 47477/head
Milind Changire [Tue, 16 Aug 2022 12:21:37 +0000 (17:51 +0530)]
doc/cephfs: note regarding start time time zone

Fixes: https://tracker.ceph.com/issues/56730
Signed-off-by: Milind Changire <mchangir@redhat.com>
2 years agoMerge pull request #47119 from rhcs-dashboard/image-refs-bug
Nizamudeen A [Tue, 16 Aug 2022 11:59:05 +0000 (17:29 +0530)]
Merge pull request #47119 from rhcs-dashboard/image-refs-bug

mgr/dashboard: fix _rbd_image_refs caching

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #47609 from cbodley/wip-install-deps-rhel
Kefu Chai [Tue, 16 Aug 2022 11:19:07 +0000 (19:19 +0800)]
Merge pull request #47609 from cbodley/wip-install-deps-rhel

install-deps: remove outdated rhel8 devtool packages

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agorgw: fix linking with tcmalloc when specified by -DALLOCATOR 47628/head
Mark Kogan [Tue, 16 Aug 2022 10:46:18 +0000 (10:46 +0000)]
rgw: fix linking with tcmalloc when specified by -DALLOCATOR

Fixes: https://tracker.ceph.com/issues/57140
Signed-off-by: Mark Kogan <mkogan@redhat.com>
2 years agoMerge pull request #45628 from PepperJo/comparev_and_writev_v7
Ilya Dryomov [Tue, 16 Aug 2022 09:53:05 +0000 (11:53 +0200)]
Merge pull request #45628 from PepperJo/comparev_and_writev_v7

librbd: add compare-and-write compare length limit, remove sector size restriction

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #47617 from tchaikov/wip-cmake-jsonnet
Kefu Chai [Tue, 16 Aug 2022 08:59:43 +0000 (16:59 +0800)]
Merge pull request #47617 from tchaikov/wip-cmake-jsonnet

cmake: set $PATH for tests using jsonnet tools

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
2 years agoMerge pull request #47618 from xxhdx1985126/wip-journal-move
Yingxin [Tue, 16 Aug 2022 04:51:23 +0000 (12:51 +0800)]
Merge pull request #47618 from xxhdx1985126/wip-journal-move

crimson/os/seastore/journal: move bufferlists to reduce the amount of memory copies

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore/journal: move bufferlists to reduce the amount of memory copies 47618/head
Xuehan Xu [Tue, 16 Aug 2022 02:56:30 +0000 (10:56 +0800)]
crimson/os/seastore/journal: move bufferlists to reduce the amount of memory copies

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocmake: set $PATH for tests using jsonnet tools 47617/head
Kefu Chai [Tue, 16 Aug 2022 02:52:53 +0000 (10:52 +0800)]
cmake: set $PATH for tests using jsonnet tools

otherwise they would not able to find executables installed into
${CMAKE_CURRENT_BINARY_DIR}.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47594 from tchaikov/wip-cmake-win32
Kefu Chai [Tue, 16 Aug 2022 01:45:54 +0000 (09:45 +0800)]
Merge pull request #47594 from tchaikov/wip-cmake-win32

cmake: enforce gcc-10 for win32 port

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agocephadm: Remove duplicated process args in promtail and loki(config.file) 47529/head
jinhong.kim [Wed, 10 Aug 2022 08:24:22 +0000 (17:24 +0900)]
cephadm: Remove duplicated process args in promtail and loki(config.file)

Signed-off-by: jinhong.kim <jinhong.kim0@navercorp.com>
2 years agorgw: Document `RGWOvjVersionTracker` 47615/head
Adam C. Emerson [Mon, 15 Aug 2022 21:19:06 +0000 (17:19 -0400)]
rgw: Document `RGWOvjVersionTracker`

Give some guidelines as to what it's for and how to use it.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #47612 from cbodley/wip-rgw-revert-lua-filter
Casey Bodley [Mon, 15 Aug 2022 20:22:44 +0000 (16:22 -0400)]
Merge pull request #47612 from cbodley/wip-rgw-revert-lua-filter

Revert "rgw/lua: allow read access to object data"

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoRevert "rgw/lua: allow read access to object data" 47612/head
Casey Bodley [Mon, 15 Aug 2022 18:20:20 +0000 (14:20 -0400)]
Revert "rgw/lua: allow read access to object data"

This reverts commit f4501f69701d74caa5c0da0b7247eed80c1f2a3f.

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47564 from cbodley/wip-build-disable-motr
Casey Bodley [Mon, 15 Aug 2022 18:48:16 +0000 (14:48 -0400)]
Merge pull request #47564 from cbodley/wip-build-disable-motr

build: temporarily disable WITH_RADOSGW_MOTR in make check

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoinstall-deps: remove outdated rhel8 devtool packages 47609/head
Casey Bodley [Mon, 15 Aug 2022 17:25:48 +0000 (13:25 -0400)]
install-deps: remove outdated rhel8 devtool packages

these were accidentally resurrected in 65b1a13139873c1525456e05cd00aeb64da4e881

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47513 from Dazul/cephadm-allow-multiple-vips-keepalived
Adam King [Mon, 15 Aug 2022 17:24:57 +0000 (13:24 -0400)]
Merge pull request #47513 from Dazul/cephadm-allow-multiple-vips-keepalived

Cephadm: Allow multiple virtual IP addresses for keepalived and haproxy

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agodoc: document debugging for libcephsqlite 47600/head
Patrick Donnelly [Mon, 15 Aug 2022 15:05:21 +0000 (11:05 -0400)]
doc: document debugging for libcephsqlite

Fixes: https://tracker.ceph.com/issues/57127
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #47539 from guits/fix-zap-msg-cephadm
Adam King [Mon, 15 Aug 2022 17:14:39 +0000 (13:14 -0400)]
Merge pull request #47539 from guits/fix-zap-msg-cephadm

cephadm: fix incorrect warning

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47562 from guits/c-v-fix_ceph_device
Adam King [Mon, 15 Aug 2022 17:11:33 +0000 (13:11 -0400)]
Merge pull request #47562 from guits/c-v-fix_ceph_device

cephadm/ceph-volume: fix rm-cluster --zap

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #46550 from yuvalif/wip-yuval-lua-filter
Yuval Lifshitz [Mon, 15 Aug 2022 16:57:09 +0000 (19:57 +0300)]
Merge pull request #46550 from yuvalif/wip-yuval-lua-filter

rgw/lua: allow access to object data

reviwed-by: cbodley, anthonyeleven

2 years agoMerge pull request #47420 from yuvalif/wip-yuval-remove-metadata-entry
Yuval Lifshitz [Mon, 15 Aug 2022 16:55:36 +0000 (19:55 +0300)]
Merge pull request #47420 from yuvalif/wip-yuval-remove-metadata-entry

rgw: remove metadata entry when remote fetch reply with ENOENT

reviewed-by: cbodley

2 years agoMerge pull request #47362 from dang/wip-dang-zipper-cleanup
Daniel Gryniewicz [Mon, 15 Aug 2022 16:35:01 +0000 (12:35 -0400)]
Merge pull request #47362 from dang/wip-dang-zipper-cleanup

RGW - Zipper - Init cleanup

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47010 from yuvalif/wip-yuval-fix-lua-post-ctx
Yuval Lifshitz [Mon, 15 Aug 2022 16:31:34 +0000 (19:31 +0300)]
Merge pull request #47010 from yuvalif/wip-yuval-fix-lua-post-ctx

rgw/lua: post request context does not work

reviewed-by: cbodley, zenomri

2 years agoMerge pull request #46304 from yuvalif/wip-yuval-fix-53810
Yuval Lifshitz [Mon, 15 Aug 2022 16:30:11 +0000 (19:30 +0300)]
Merge pull request #46304 from yuvalif/wip-yuval-fix-53810

rgw/lua: don't create the script manager per request

reviewed-by: cbodley, dang, mkogan1

2 years agoMerge pull request #47411 from linuxbox2/wip-56997
Casey Bodley [Mon, 15 Aug 2022 16:25:24 +0000 (12:25 -0400)]
Merge pull request #47411 from linuxbox2/wip-56997

rgwlc/sync: avoid calling merge-and-store-attrs from remove_bucket_co…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agocrimson/osd: watch list empty return incorrect 47597/head
NitzanMordhai [Mon, 15 Aug 2022 13:12:20 +0000 (13:12 +0000)]
crimson/osd: watch list empty return incorrect
fixing retun respon encode when watcher list is empty

Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
2 years agotest/librbd: various fixups for compare-and-write test cases 45628/head
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
test/librbd: various fixups for compare-and-write test cases

- missing EILSEQ asserts in IO and IOWithIOHint
- AioCompletion leak in CompareTooSmall and WriteTooSmall
- skip StripeUnitUnaligned and TooLarge on the PWL cache as it wasn't
  limited by the 512-byte sector limit before and isn't limited by the
  stripe unit limit now

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd/cache/pwl: adjust compare-and-write compare substringing
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
librbd/cache/pwl: adjust compare-and-write compare substringing

cmp_bl can no longer be shorter than read_bl (i.e. image extent).
This is caught very early at the API level, see commit af96e6dae3f4
("librbd: make C++ cmp&write semantics equal to C API").

However, cmp_bl can still be longer than read_bl and in that case
it should be capped by the image extent length.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: discard cache state if compare-and-write writes to disk
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
librbd: discard cache state if compare-and-write writes to disk

Otherwise this is obviously broken with rbd_cache_policy = writeback or
rbd_cache_policy = writethrough as the write is done on the OSD, beneath
ObjectCacher.  This went unnoticed because the original (and so far the
only known) compare-and-write user, tcmu-runner rbd driver, disables the
cache altogether.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agocmake: enforce gcc-10 for win32 port 47594/head
Kefu Chai [Mon, 15 Aug 2022 07:24:14 +0000 (15:24 +0800)]
cmake: enforce gcc-10 for win32 port

we only have GCC-10 targeting MinGW at the time of writing, and it
is good enough for compiling the Winows port.

so let's relax the requirement to enable the windows build.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47402 from NitzanMordhai/wip-nitzan-crimson-rbd-cls-watcher-list
Kefu Chai [Mon, 15 Aug 2022 07:12:54 +0000 (15:12 +0800)]
Merge pull request #47402 from NitzanMordhai/wip-nitzan-crimson-rbd-cls-watcher-list

crimson/osd: Port rgw watcher list

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #47552 from myoungwon/wip-fix-seastore-trm-test
Yingxin [Mon, 15 Aug 2022 03:41:26 +0000 (11:41 +0800)]
Merge pull request #47552 from myoungwon/wip-fix-seastore-trm-test

test/crimson/seastore: unittest-transaction-manager fixes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore/transaction_manager: don't return invalid extent in get_extents_i... 47553/head
Yingxin Cheng [Mon, 15 Aug 2022 03:31:41 +0000 (11:31 +0800)]
crimson/os/seastore/transaction_manager: don't return invalid extent in get_extents_if_live()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore/async_cleaner: cleanup and add logs to gc trim
Yingxin Cheng [Fri, 12 Aug 2022 07:14:54 +0000 (15:14 +0800)]
crimson/os/seastore/async_cleaner: cleanup and add logs to gc trim

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore: document how get_extents_if_live deals with extents split
Yingxin Cheng [Thu, 11 Aug 2022 05:38:05 +0000 (13:38 +0800)]
crimson/os/seastore: document how get_extents_if_live deals with extents split

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore/transaction_manager: cleanups to get_extents_if_live
Yingxin Cheng [Fri, 12 Aug 2022 07:31:57 +0000 (15:31 +0800)]
crimson/os/seastore/transaction_manager: cleanups to get_extents_if_live

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>