]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agorgw/main: if !nfs, register service map as "rgw" 47771/head
Matt Benjamin [Mon, 12 Sep 2022 21:00:49 +0000 (17:00 -0400)]
rgw/main: if !nfs, register service map as "rgw"

This was accidentally changed to "nfs"--which breaks various
ceph orchestration assumptions.

Found by Ernesto Puerta <epuertat@redhat.com>

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgwlib: ensure AppMain is destructed before CephContext
Matt Benjamin [Fri, 9 Sep 2022 15:57:44 +0000 (11:57 -0400)]
rgwlib: ensure AppMain is destructed before CephContext

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: cause ratelimiter to destruct in AppMain::shutdown()
Matt Benjamin [Thu, 8 Sep 2022 16:46:55 +0000 (12:46 -0400)]
rgw/main: cause ratelimiter to destruct in AppMain::shutdown()

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agolibrgw: fix mismatched register/unregister sigterm handler
Matt Benjamin [Wed, 7 Sep 2022 17:57:29 +0000 (13:57 -0400)]
librgw: fix mismatched register/unregister sigterm handler

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: fix init order of rgw_main's init_storage()
Matt Benjamin [Wed, 7 Sep 2022 17:30:53 +0000 (13:30 -0400)]
rgw/main:  fix init order of rgw_main's init_storage()

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: move service_map_meta into AppMain
Matt Benjamin [Wed, 7 Sep 2022 14:22:14 +0000 (10:22 -0400)]
rgw/main: move service_map_meta into AppMain

The RGWRealmReloader holds a reference on it.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: move signal handler actions out of shutdown()
Matt Benjamin [Fri, 2 Sep 2022 21:54:45 +0000 (17:54 -0400)]
rgw/main: move signal handler actions out of shutdown()

AppMain::shutdown() had borrowed the unregister_async_signal_handler()
text from librgw, but of course, that's wrong.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgwlib: robustify non-default initialization
Matt Benjamin [Thu, 1 Sep 2022 15:33:31 +0000 (11:33 -0400)]
rgwlib: robustify non-default initialization

Don't rely on the conf-default value of rgw_nfs_frontends to
provide "rgw-nfs," as that's not optional when running under
librgw.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw_main: remove unused tracepoint decls
Matt Benjamin [Thu, 1 Sep 2022 12:57:38 +0000 (08:57 -0400)]
rgw_main: remove unused tracepoint decls

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgwlib: rework linkage
Matt Benjamin [Thu, 1 Sep 2022 12:53:50 +0000 (08:53 -0400)]
rgwlib: rework linkage

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw_a: build reorganization
Matt Benjamin [Tue, 30 Aug 2022 14:19:34 +0000 (10:19 -0400)]
rgw_a: build reorganization

Reorganize some dependencies shared by the librgw.so and radosgw
main units.  The librgw.so build no longer builds a main(...)
unit.

Build time should be slightly reduced, as several shared dependencies
have been moved into rgw_a.

There are some other cleanups, e.g., rgw_signal.{h,cc}.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: remove friends, see_also
Matt Benjamin [Tue, 30 Aug 2022 13:42:31 +0000 (09:42 -0400)]
rgw/main: remove friends, see_also

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: various doc and comment corrections by doc writers
Matt Benjamin [Mon, 29 Aug 2022 15:33:53 +0000 (11:33 -0400)]
rgw/main: various doc and comment corrections by doc writers

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: use AppMain in c++ main function
Matt Benjamin [Sat, 27 Aug 2022 17:11:30 +0000 (13:11 -0400)]
rgw/main: use AppMain in c++ main function

Consolidate standalone and library initialization into one
unit.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw/main: AppMain
Matt Benjamin [Sat, 27 Aug 2022 14:35:45 +0000 (10:35 -0400)]
rgw/main: AppMain

s/rgw::InitHelper/rgw::AppMain/;

Move program state from RGWLib into AppMain, preparing it to
manage program state for all RGW instances (e.g., main()).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agolibrgw: add ability to conditionally export HTTP frontends/apis
Matt Benjamin [Thu, 18 Aug 2022 21:25:09 +0000 (17:25 -0400)]
librgw: add ability to conditionally export HTTP frontends/apis

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #47700 from s0nea/wip-rgw-overview-labels
Nizamudeen A [Fri, 9 Sep 2022 12:06:40 +0000 (17:36 +0530)]
Merge pull request #47700 from s0nea/wip-rgw-overview-labels

monitoring/ceph-mixin: add RGW host to label info

Reviewed-by: MrFreezeex <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #47784 from rhcs-dashboard/ingress-unmanaged
Nizamudeen A [Fri, 9 Sep 2022 05:14:35 +0000 (10:44 +0530)]
Merge pull request #47784 from rhcs-dashboard/ingress-unmanaged

mgr/dashboard: fix unmanaged service creation

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 years agoMerge pull request #47959 from rhcs-dashboard/service-id-filter-undefined
Nizamudeen A [Fri, 9 Sep 2022 03:57:14 +0000 (09:27 +0530)]
Merge pull request #47959 from rhcs-dashboard/service-id-filter-undefined

mgr/dashboard: fix Cannot read properties of undefined (reading 'filter')

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #48014 from idryomov/wip-57116-cont
Ilya Dryomov [Thu, 8 Sep 2022 18:52:28 +0000 (20:52 +0200)]
Merge pull request #48014 from idryomov/wip-57116-cont

test/{librbd, rgw}: increase delay between and number of bind attempts

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #48003 from dang/wip-dang-zipper-admin-api
Daniel Gryniewicz [Thu, 8 Sep 2022 18:36:46 +0000 (14:36 -0400)]
Merge pull request #48003 from dang/wip-dang-zipper-admin-api

RGW - Zipper - Allow per-store admin APIs

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48009 from ljflores/wip-install-deps-focal-bionic
Ilya Dryomov [Thu, 8 Sep 2022 18:05:15 +0000 (20:05 +0200)]
Merge pull request #48009 from ljflores/wip-install-deps-focal-bionic

install-deps.sh: fix install-deps script for focal and bionic

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoRGW - Zipper - Allow per-store admin APIs 48003/head
Daniel Gryniewicz [Thu, 1 Sep 2022 17:52:26 +0000 (13:52 -0400)]
RGW - Zipper - Allow per-store admin APIs

Some of the existing admin APIs are rados-specific, and other stores
will want to add specific APIs.  Allow this by having a function to add
store-specific APIs.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2 years agotest/{librbd, rgw}: increase delay between and number of bind attempts 48014/head
Ilya Dryomov [Thu, 8 Sep 2022 09:36:34 +0000 (11:36 +0200)]
test/{librbd, rgw}: increase delay between and number of bind attempts

Commit aa7885f7cc41 ("test/{librbd, rgw}: retry when bind fail with
port 0") reduced the frequency of sporadic unit test failures caused
by EADDRINUSE a lot, but not entirely.

Currently, it yields a cumulative sleep of ~9 seconds.  Let's increase
that to 1 minute.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #47274 from faithuniterh/Golang-Notification-creation
Yuval Lifshitz [Thu, 8 Sep 2022 09:31:24 +0000 (12:31 +0300)]
Merge pull request #47274 from faithuniterh/Golang-Notification-creation

examples/golang : Add put notification creation golang example code

reviewed-by: yuvalif

2 years agoMerge pull request #46757 from nSedrickm/navigation-component-accessibility-update
Nizamudeen A [Thu, 8 Sep 2022 04:11:29 +0000 (09:41 +0530)]
Merge pull request #46757 from nSedrickm/navigation-component-accessibility-update

mgr/dashboard: Improve accessibility for navigation components

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoinstall-deps.sh: fix install-deps script for focal and bionic 48009/head
Laura Flores [Wed, 7 Sep 2022 19:45:57 +0000 (19:45 +0000)]
install-deps.sh: fix install-deps script for focal and bionic

When run on focal and bionic, install-deps ends early
due to this extra debug message that was added to the
end of `ensure_decent_gcc_on_ubuntu`. The debug message
prints when the script is run in a jenkins environment.

When the script is not run in a jenkins environment, the
value returned there is "false" or "0", which acts as
an early return. This stops the script from completing.

We can remove this line, as `ensure_decent_gcc_on_ubuntu`
is only called for focal and bionic, and most of the jenkins
nodes are running jammy. Also, there is a debug message at the
beginning of the function that should suffice.

Fixes: https://tracker.ceph.com/issues/57466
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #47091 from faithuniterh/Golang-Topic-creation
Yuval Lifshitz [Wed, 7 Sep 2022 18:15:52 +0000 (21:15 +0300)]
Merge pull request #47091 from faithuniterh/Golang-Topic-creation

Topic creation example and sorting Golang examples into different folders

reviewed-by: anthonyeleven, yuvalif

2 years agoMerge pull request #47864 from yuvalif/wip-yuval-fix-53186
Yuval Lifshitz [Wed, 7 Sep 2022 18:09:16 +0000 (21:09 +0300)]
Merge pull request #47864 from yuvalif/wip-yuval-fix-53186

rgw/notifications: add region to bucket ARN

reviewed-by: mattbenjamin, nthonyeleven

2 years agoMerge pull request #47924 from tchaikov/wip-57355
Casey Bodley [Wed, 7 Sep 2022 16:53:36 +0000 (12:53 -0400)]
Merge pull request #47924 from tchaikov/wip-57355

denc: support non-c++20 compliant C++ standard library

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47935 from ivancich/wip-simplify-bucket-listing-logging
J. Eric Ivancich [Wed, 7 Sep 2022 15:30:21 +0000 (11:30 -0400)]
Merge pull request #47935 from ivancich/wip-simplify-bucket-listing-logging

rgw: simplify bucket listing logging

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 years agoMerge pull request #47741 from ljflores/wip-python3-fix
Laura Flores [Wed, 7 Sep 2022 15:11:08 +0000 (10:11 -0500)]
Merge pull request #47741 from ljflores/wip-python3-fix

do_cmake.sh: build with python3.10 on ubuntu version >= 22.0

2 years agoMerge pull request #47857 from nSedrickm/duplicate-id-accessibility-update
Pere Diaz Bou [Wed, 7 Sep 2022 14:56:08 +0000 (16:56 +0200)]
Merge pull request #47857 from nSedrickm/duplicate-id-accessibility-update

mgr/dashboard: remove duplicate ids from table column filters

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #47981 from myoungwon/wip-rbm-cleanup2
Yingxin [Wed, 7 Sep 2022 10:54:27 +0000 (18:54 +0800)]
Merge pull request #47981 from myoungwon/wip-rbm-cleanup2

crimson/os/seastore: RBM cleanups (mkfs, open, unittest)

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #47054 from nSedrickm/grafana-component-accessibility-update
Pere Diaz Bou [Wed, 7 Sep 2022 08:30:00 +0000 (10:30 +0200)]
Merge pull request #47054 from nSedrickm/grafana-component-accessibility-update

mgr/dashboard: Improve level A accessibility for grafana component

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agocrimson/os/seastore/rbm: use RBMDevice::size instead of TestMemory::size in TestMemory 47981/head
myoungwon oh [Fri, 2 Sep 2022 05:06:28 +0000 (14:06 +0900)]
crimson/os/seastore/rbm: use RBMDevice::size instead of TestMemory::size in TestMemory

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: force to make rbm superblock when mkfs is called
myoungwon oh [Tue, 6 Sep 2022 02:59:41 +0000 (11:59 +0900)]
crimson/os/seastore/rbm: force to make rbm superblock when mkfs is called

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: call device.open() before rbm.open() or rbm.mkfs()
myoungwon oh [Tue, 6 Sep 2022 02:47:41 +0000 (11:47 +0900)]
crimson/os/seastore/rbm: call device.open() before rbm.open() or rbm.mkfs()

This commit also deletes open_device() in rbn.open()

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agotest/crimson/seastore: fix randomblockmanager test
myoungwon oh [Fri, 2 Sep 2022 04:52:50 +0000 (13:52 +0900)]
test/crimson/seastore: fix randomblockmanager test

1. remove transaction manager initialization in rbm test
2. do not call check_bitmap_blocks directly and use close() and open()
because open() invokes it internally

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agoMerge pull request #47987 from idryomov/wip-52810
Ilya Dryomov [Tue, 6 Sep 2022 18:17:15 +0000 (20:17 +0200)]
Merge pull request #47987 from idryomov/wip-52810

librbd: retry ENOENT in V2_REFRESH_PARENT as well

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #47783 from soumyakoduri/wip-skoduri-sync-flow
Casey Bodley [Tue, 6 Sep 2022 16:29:53 +0000 (12:29 -0400)]
Merge pull request #47783 from soumyakoduri/wip-skoduri-sync-flow

radosgw-admin: fix crash with 'sync flow' cmd without 'flow-type'

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2 years agoMerge pull request #45883 from ifed01/wip-ifed-fix-bluefs-truncate
Yuri Weinstein [Tue, 6 Sep 2022 16:12:29 +0000 (09:12 -0700)]
Merge pull request #45883 from ifed01/wip-ifed-fix-bluefs-truncate

os/bluestore: fix no metadata update on truncate+fsync

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #47630 from sseshasa/wip-add-mclk-cpu-util-rel-note
Sridhar Seshasayee [Tue, 6 Sep 2022 15:15:02 +0000 (20:45 +0530)]
Merge pull request #47630 from sseshasa/wip-add-mclk-cpu-util-rel-note

PendingReleaseNotes: Note the fix for high CPU utilization during recovery

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agomonitoring/ceph-mixin: add RGW host to label info 47700/head
Tatjana Dehler [Fri, 19 Aug 2022 10:08:17 +0000 (12:08 +0200)]
monitoring/ceph-mixin: add RGW host to label info

Add the missing information about the RGW instance to the labels of the
"Average GET/PUT Latencies" panel on the "RGW Overview" dashboard.

Fixes: https://tracker.ceph.com/issues/57166
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2 years agoMerge pull request #47908 from dang/wip-dang-zipper-cleanup
Daniel Gryniewicz [Tue, 6 Sep 2022 13:48:49 +0000 (09:48 -0400)]
Merge pull request #47908 from dang/wip-dang-zipper-cleanup

RGW - Sal - remove unused default constructors

Reviewed-by: Casey Bodley <cbodley@redat.com>
2 years agoMerge pull request #47907 from cbodley/wip-57195
Casey Bodley [Tue, 6 Sep 2022 11:52:34 +0000 (07:52 -0400)]
Merge pull request #47907 from cbodley/wip-57195

rgw: fix d3n crash in StoreManager::get_config()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
2 years agomgr/dashboard: add cypress e2e accessibility tests for navigation 46757/head
nsedrickm [Sun, 7 Aug 2022 13:25:11 +0000 (14:25 +0100)]
mgr/dashboard: add cypress e2e accessibility tests for navigation

* Add cypress e2e accessibility tests
* Log accessibility violations to console for quick debugging
* Disable retries to avoid duplicate logs

Signed-off-by: nsedrickm <nsedrick101@gmail.com>
2 years agomgr/dashboard: Improve accessibility for navigation components
nsedrickm [Mon, 20 Jun 2022 17:32:27 +0000 (18:32 +0100)]
mgr/dashboard: Improve accessibility for navigation components

* Fix all dropdown accessibility issues by setting their roles as buttons
* Increase navlink font-size to 16px
* Add new primary color variable $primary-wcag-aa-large-text: #25828e  to meet WCAG level AA color contrast ratio for active navlink backgrounds

Fixes: https://tracker.ceph.com/issues/56021
Signed-off-by: nsedrickm <nsedrick101@gmail.com>
2 years agoMerge pull request #46823 from lightmelodies/librados-c-api-stat2
Kefu Chai [Tue, 6 Sep 2022 00:40:46 +0000 (08:40 +0800)]
Merge pull request #46823 from lightmelodies/librados-c-api-stat2

librados: export stat2 in C API

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47962 from tchaikov/wip-3rd-time-is-a-charm
Kefu Chai [Tue, 6 Sep 2022 00:37:45 +0000 (08:37 +0800)]
Merge pull request #47962 from tchaikov/wip-3rd-time-is-a-charm

test/{librbd, rgw}: retry when bind fail with port 0

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agolibrbd: make RefreshRequest tests compatible with clone v1 47987/head
Ilya Dryomov [Sun, 4 Sep 2022 17:14:04 +0000 (19:14 +0200)]
librbd: make RefreshRequest tests compatible with clone v1

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: retry ENOENT in V2_REFRESH_PARENT as well
Ilya Dryomov [Sun, 4 Sep 2022 15:52:51 +0000 (17:52 +0200)]
librbd: retry ENOENT in V2_REFRESH_PARENT as well

With auto-deletion of trashed snapshots, it is relatively easy to lose
a race to "rbd flatten" as follows:

- when V2_GET_PARENT runs, the image is technically still a clone
- when V2_REFRESH_PARENT runs, the image is fully flattened and the
  snapshot in the parent image is deleted

This results in a spurious ENOENT error, mainly when trying to open the
image (e.g. for "rbd info").  This race condition has always been there
but auto-deletion of trashed snapshots makes it much worse.

Retry ENOENT in V2_REFRESH_PARENT the same way as in V2_GET_SNAPSHOTS.

Fixes: https://tracker.ceph.com/issues/52810
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: limit the number of ENOENT retries in RefreshRequest
Ilya Dryomov [Sun, 4 Sep 2022 10:40:36 +0000 (12:40 +0200)]
librbd: limit the number of ENOENT retries in RefreshRequest

If the image header is corrupt, ENOENT error may be persistent.  Avoid
an infinite loop in that case.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: fix a bunch of issues with restarting RefreshRequest
Ilya Dryomov [Fri, 2 Sep 2022 14:58:36 +0000 (16:58 +0200)]
librbd: fix a bunch of issues with restarting RefreshRequest

Make RefreshRequest properly restartable, at least up until and including
V2_REFRESH_PARENT step:

- clear m_migration_spec when skipping GET_MIGRATION_HEADER
- don't rely on potentially stale m_incomplete_update on retry
- reset m_legacy_parent when retrying more than just V2_GET_PARENT
- don't rely on potentially stale m_parent_md.overlap and
  m_head_parent_overlap on retry
- clear m_metadata before fetching image metadata (but not before
  fetching pool metadata)
- clear m_op_features when skipping V2_GET_OP_FEATURES
- clear m_group_spec on EOPNOTSUPP error in V2_GET_GROUP
- reset m_legacy_snapshot when retrying more than just V2_GET_SNAPSHOTS
- don't rely on potentially stale m_snap_parents on retry

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: check *result consistently in RefreshRequest
Ilya Dryomov [Tue, 30 Aug 2022 19:33:04 +0000 (21:33 +0200)]
librbd: check *result consistently in RefreshRequest

Stick to *result >= 0 checks everywhere and add missing checks for
op_features_get_finish() and image_group_get_finish() errors.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: reflect V2_GET_SNAPSHOTS ENOENT retry in state diagram
Ilya Dryomov [Tue, 30 Aug 2022 18:38:10 +0000 (20:38 +0200)]
librbd: reflect V2_GET_SNAPSHOTS ENOENT retry in state diagram

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #47964 from yuvalif/wip-yuval-fix-57418
Casey Bodley [Mon, 5 Sep 2022 18:17:07 +0000 (14:17 -0400)]
Merge pull request #47964 from yuvalif/wip-yuval-fix-57418

rgw/lua: handle null lua manager in librgw

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47456 from sseshasa/wip-fix-mon-cmd-nack
Yuri Weinstein [Mon, 5 Sep 2022 18:16:00 +0000 (11:16 -0700)]
Merge pull request #47456 from sseshasa/wip-fix-mon-cmd-nack

osd: Implement Context based completion for mon cmd to set a config option

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #37767 from shun-s/add-mons-ms-tos-support
Yuri Weinstein [Mon, 5 Sep 2022 18:14:33 +0000 (11:14 -0700)]
Merge pull request #37767 from shun-s/add-mons-ms-tos-support

msg: add min delay packets support for mons

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agotest/{librbd, rgw}: retry when bind fail with port 0 47962/head 47963/head
Kefu Chai [Sun, 4 Sep 2022 12:37:32 +0000 (20:37 +0800)]
test/{librbd, rgw}: retry when bind fail with port 0

there is chance that the bind() call may fail if we have another test
happen to pick the free port picked by operating system. in this case,
we just retry up to 42 times.

in theory, this change does not fully address the racing, but it should
help to alleviate this issue.

See-also: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47250 from nSedrickm/progress-bar-accessibility-update
Pere Diaz Bou [Mon, 5 Sep 2022 11:02:00 +0000 (13:02 +0200)]
Merge pull request #47250 from nSedrickm/progress-bar-accessibility-update

mgr/dashboard: Improve level A accessibility for usagebar

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #47507 from zenomri/wip-omri-fix-tracer-provider
Yuval Lifshitz [Mon, 5 Sep 2022 09:19:56 +0000 (12:19 +0300)]
Merge pull request #47507 from zenomri/wip-omri-fix-tracer-provider

common/tracer: fix for tracer provider destruction

reviewed-by: yuvalif

2 years agoMerge pull request #47905 from cbodley/wip-57326
Yuval Lifshitz [Mon, 5 Sep 2022 07:33:27 +0000 (10:33 +0300)]
Merge pull request #47905 from cbodley/wip-57326

rgw: avoid string_view to temporary in RGWBulkUploadOp

reviewed-by: dang, yuvalif

2 years agomgr/dashboard: remove duplicate ids from table column filters 47857/head
nsedrickm [Mon, 29 Aug 2022 18:35:29 +0000 (19:35 +0100)]
mgr/dashboard: remove duplicate ids from table column filters

Generate random ids for column filters to avoid id conflics on pages with multiple tables sharing the same column filters

Signed-off-by: nsedrickm <nsedrick101@gmail.com>
Fixes: https://tracker.ceph.com/issues/55869
2 years agoMerge pull request #47518 from aravind-wdc/zns-wip
Yingxin [Mon, 5 Sep 2022 03:34:31 +0000 (11:34 +0800)]
Merge pull request #47518 from aravind-wdc/zns-wip

crimson/os/seastore: improve ZNS support for SeaStore

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agorgw/lua: handle null lua manager in librgw 47964/head
Yuval Lifshitz [Sun, 4 Sep 2022 13:11:36 +0000 (16:11 +0300)]
rgw/lua: handle null lua manager in librgw

Fixes: https://tracker.ceph.com/issues/57418
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #47571 from rhcs-dashboard/nfs-form-squash-norequired
Nizamudeen A [Sun, 4 Sep 2022 07:30:17 +0000 (13:00 +0530)]
Merge pull request #47571 from rhcs-dashboard/nfs-form-squash-norequired

mgr/dashboard: fix nfs exports form issues with squash field

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2 years agomgr/dashboard: fix Cannot read properties of undefined (reading 'filter') 47959/head
Nizamudeen A [Sun, 4 Sep 2022 05:52:45 +0000 (11:22 +0530)]
mgr/dashboard: fix Cannot read properties of undefined (reading 'filter')

Fixes: https://tracker.ceph.com/issues/57434
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #47634 from rhcs-dashboard/kcli-fedora-36
Nizamudeen A [Sun, 4 Sep 2022 04:26:19 +0000 (09:56 +0530)]
Merge pull request #47634 from rhcs-dashboard/kcli-fedora-36

mgr/dashboard: fix "can't read .ssh/known_hosts: No such file or directory

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 years agoMerge pull request #47871 from zdover23/wip-doc-2022-08-30-start-documenting-ceph...
zdover23 [Sun, 4 Sep 2022 02:10:37 +0000 (12:10 +1000)]
Merge pull request #47871 from zdover23/wip-doc-2022-08-30-start-documenting-ceph-branch-name-update

doc/start: update documenting-ceph branch names

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #47906 from ivancich/wip-bad-move-s3-getobj
J. Eric Ivancich [Sat, 3 Sep 2022 22:26:42 +0000 (18:26 -0400)]
Merge pull request #47906 from ivancich/wip-bad-move-s3-getobj

rgw: fix bug where variable referenced after data moved out

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #47941 from adk3798/tp-no-overwrite-doc2
Adam King [Sat, 3 Sep 2022 19:47:21 +0000 (15:47 -0400)]
Merge pull request #47941 from adk3798/tp-no-overwrite-doc2

doc/cephadm: add info about --no-overwrite to note about tuned-profiles

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agodoc/cephadm: add info about --no-overwrite to note about tuned-profiles 47941/head
Adam King [Sat, 3 Sep 2022 16:19:54 +0000 (12:19 -0400)]
doc/cephadm: add info about --no-overwrite to note about tuned-profiles

Follow up to fix to this flag in
https://github.com/ceph/ceph/commit/028cb031ddb72c1f37048c8568ecdf43f5b77b50

Signed-off-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47733 from adk3798/prometheus-retention
Adam King [Sat, 3 Sep 2022 15:59:32 +0000 (11:59 -0400)]
Merge pull request #47733 from adk3798/prometheus-retention

mgr/cephadm: allow setting prometheus retention time

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #47815 from rkachach/fix_issue_57032
Adam King [Sat, 3 Sep 2022 15:58:01 +0000 (11:58 -0400)]
Merge pull request #47815 from rkachach/fix_issue_57032

cephadm/mgr: adding logic to handle --no-overwrite for tuned profiles

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge pull request #47859 from pcuzner/fix-gather-facts-disk-size
Adam King [Sat, 3 Sep 2022 15:55:05 +0000 (11:55 -0400)]
Merge pull request #47859 from pcuzner/fix-gather-facts-disk-size

cephadm: Fix disk size calculation

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47882 from rkachach/fix_issue_57060
Adam King [Sat, 3 Sep 2022 15:53:23 +0000 (11:53 -0400)]
Merge pull request #47882 from rkachach/fix_issue_57060

mgr/cephadm: Fix how we check if a host belongs to public network

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47904 from cbodley/wip-57329
J. Eric Ivancich [Sat, 3 Sep 2022 15:21:11 +0000 (11:21 -0400)]
Merge pull request #47904 from cbodley/wip-57329

rgw: avoid use-after-move in RGWDataSyncSingleEntryCR ctor

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agodenc: support non-c++20 compliant C++ standard library 47924/head
Kefu Chai [Fri, 2 Sep 2022 16:21:57 +0000 (00:21 +0800)]
denc: support non-c++20 compliant C++ standard library

when compiling with the standard library comes with GCC-10, we have
FTBFS like:

```
src/include/denc.h:517:49: error: 'bit_cast' is not a member of 'std';
did you mean 'bad_cast'?
  517 |   unsigned lowznib = v ?
      (std::countr_zero(std::bit_cast<uint64_t>(v)) / 4) : 0u;
      |                                                 ^~~~~~~~
      |                                                 bad_cast
```

to address this issue, an implementation of std::bit_cast<> is defined
if it is not available. in the long run, we should use a better C++
compiler for compiling the tree.

Fixes: https://tracker.ceph.com/issues/57355
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #47921 from rkachach/fix_issue_56953
Adam King [Fri, 2 Sep 2022 18:36:22 +0000 (14:36 -0400)]
Merge pull request #47921 from rkachach/fix_issue_56953

doc/cephadm/services: fix example for specifying rgw placement

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #47388 from ronen-fr/wip-rf-snapper
Ronen Friedman [Fri, 2 Sep 2022 18:31:59 +0000 (21:31 +0300)]
Merge pull request #47388 from ronen-fr/wip-rf-snapper

osd/scrub: verify SnapMapper consistency

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agorgw: simplify bucket listing logging 47935/head
J. Eric Ivancich [Wed, 31 Aug 2022 20:38:06 +0000 (16:38 -0400)]
rgw: simplify bucket listing logging

Switch from __PRETTY_FUNCTION__ to __func__ since the former just adds
noise to the logs.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agoMerge pull request #44589 from xijiacun/lc-transition
J. Eric Ivancich [Fri, 2 Sep 2022 16:38:56 +0000 (12:38 -0400)]
Merge pull request #44589 from xijiacun/lc-transition

rgw: Get canonical storage class when storage class is empty in lifecycle configuration

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #44610 from xijiacun/append-object
J. Eric Ivancich [Fri, 2 Sep 2022 16:37:10 +0000 (12:37 -0400)]
Merge pull request #44610 from xijiacun/append-object

rgw: Use STANDARD storage class in objects appending operation when the

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #46930 from zealot-xzd/wip-rgw-list-optimization2
J. Eric Ivancich [Fri, 2 Sep 2022 16:36:27 +0000 (12:36 -0400)]
Merge pull request #46930 from zealot-xzd/wip-rgw-list-optimization2

rgw: bucket list operation slow down in special scenario

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agoMerge pull request #47831 from a16bitsysop/libaio-musl
Casey Bodley [Fri, 2 Sep 2022 16:29:48 +0000 (12:29 -0400)]
Merge pull request #47831 from a16bitsysop/libaio-musl

rgw: rgw_d3n_datacache.cc add check for musl

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #47819 from yehudasa/wip-cloud-sync-fixes
Casey Bodley [Fri, 2 Sep 2022 16:26:47 +0000 (12:26 -0400)]
Merge pull request #47819 from yehudasa/wip-cloud-sync-fixes

rgw: cloud sync fixes

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #47527 from shraddhaghatol/shr/etag_cosmetic_change
Casey Bodley [Fri, 2 Sep 2022 15:20:10 +0000 (11:20 -0400)]
Merge pull request #47527 from shraddhaghatol/shr/etag_cosmetic_change

rgw: Added Cosmetic change in etag of copyObjectResult

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47667 from AISHU-Technology/fix-rgw-data-corruption
Casey Bodley [Fri, 2 Sep 2022 15:18:37 +0000 (11:18 -0400)]
Merge pull request #47667 from AISHU-Technology/fix-rgw-data-corruption

rgw: fix data corruption due to network jitter

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Or Friedmann <ofriedma@redhat.com>
2 years agoMerge pull request #47818 from petrutlucian94/fix_is_err
David Galloway [Fri, 2 Sep 2022 13:41:40 +0000 (09:41 -0400)]
Merge pull request #47818 from petrutlucian94/fix_is_err

include: fix IS_ERR on Windows

2 years agoMerge pull request #47916 from rhcs-dashboard/applitools-master-main
Ernesto Puerta [Fri, 2 Sep 2022 13:05:14 +0000 (15:05 +0200)]
Merge pull request #47916 from rhcs-dashboard/applitools-master-main

mgr/dashboard: s/master/main in applitools config

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #47796 from adk3798/test_cephadm_fix
Adam King [Fri, 2 Sep 2022 12:57:15 +0000 (08:57 -0400)]
Merge pull request #47796 from adk3798/test_cephadm_fix

qa/cephadm: remove fsid dir before bootstrap in test_cephadm.sh

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #47620 from lxbsz/wip-56249
Rishabh Dave [Fri, 2 Sep 2022 12:24:22 +0000 (17:54 +0530)]
Merge pull request #47620 from lxbsz/wip-56249

client: stop the remount_finisher thread in the Client::unmount()

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2 years agoMerge pull request #47593 from lxbsz/wip-57126
Rishabh Dave [Fri, 2 Sep 2022 12:23:07 +0000 (17:53 +0530)]
Merge pull request #47593 from lxbsz/wip-57126

client: abort the client if we couldn't invalidate dentry caches

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #46988 from rishabh-d-dave/qa-suites-upgraded-client
Rishabh Dave [Fri, 2 Sep 2022 12:21:25 +0000 (17:51 +0530)]
Merge pull request #46988 from rishabh-d-dave/qa-suites-upgraded-client

qa/cephfs: clean up evicted client in 4-compat_client.yaml

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #47919 from SUSE/wip-fix-57390
Tim Serong [Fri, 2 Sep 2022 10:04:31 +0000 (20:04 +1000)]
Merge pull request #47919 from SUSE/wip-fix-57390

ceph-dencoder: Add erasure_code to denc-mod-osd's target_link_libraries

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agodoc/cephadm/services: fix example for specifying rgw placement 47921/head
Redouane Kachach [Fri, 2 Sep 2022 09:57:43 +0000 (11:57 +0200)]
doc/cephadm/services: fix example for specifying rgw placement
fixes: https://tracker.ceph.com/issues/56953

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2 years agoexamples/golang/put-bucket-notification-creation : Add put bucket notification creati... 47274/head
Faith [Tue, 30 Aug 2022 12:06:09 +0000 (12:06 +0000)]
examples/golang/put-bucket-notification-creation : Add put bucket notification creation example code

Signed-off-by: Faith <faithuniterh@tutanota.com>
2 years agoceph-dencoder: Add erasure_code to denc-mod-osd's target_link_libraries 47919/head
Tim Serong [Fri, 2 Sep 2022 08:44:09 +0000 (18:44 +1000)]
ceph-dencoder: Add erasure_code to denc-mod-osd's target_link_libraries

Fixes: https://tracker.ceph.com/issues/57390
Signed-off-by: Tim Serong <tserong@suse.com>
2 years agoMerge pull request #47881 from idryomov/wip-57343
Ilya Dryomov [Fri, 2 Sep 2022 08:00:23 +0000 (10:00 +0200)]
Merge pull request #47881 from idryomov/wip-57343

test/cli-integration/rbd: iSCSI REST API responses aren't pretty-printed anymore

Reviewed-by: Xiubo Li <xiubli@redhat.com>