test: add test for checking snapdir attrs on parent inode updation

Signed-off-by: Venky Shankar <vshankar@redhat.com>

test: add test for checking snapdir acls

Signed-off-by: Venky Shankar <vshankar@redhat.com>

test: cleanup files/dirs for some tests

Otherwise subsequent tests that use the same file/dir name may fail
on ceph_mkdir() expecting success.

Signed-off-by: Venky Shankar <vshankar@redhat.com>

client: refresh snapdir attrs on parent inode updation

Snapdir attrs (ui, gid, etc..) are set its respective parent attributes,
however, those are never updated when the attributes of the parent inode
get updated. There seems to be no reason to no to update snapdir attributes.

This change also updates POSIX ACLs.

Fixes: http://tracker.ceph.com/issues/57084
Signed-off-by: Venky Shankar <vshankar@redhat.com>

client: use parent directory POSIX ACLs for snaphot dir

Fixes: http://tracker.ceph.com/issues/57084
Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #48415 from rhcs-dashboard/repaired-metric-name

mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47495 from rhcs-dashboard/rgw-s3-encryption

mgr/dashboard: add server side encryption to rgw/s3

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46331 from lxbsz/wip-55332

mds: wait unlink to finish to avoid conflict when creating same dentries

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge pull request #48407 from rhcs-dashboard/fix-weird-data-osd

mgr/dashboard: fix weird data in osd details

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #48429 from zdover23/wip-doc-2022-10-11-security-cve-2022-0670-grammar

doc/security: improve grammar in CVE-2022-0670.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #48418 from tchaikov/wip-ceph-dencoder

cmake: do not link ceph-dencoder against global

Reviewed-by: Tim Serong <tserong@suse.com>

mgr/dashboard: add server side encryption to rgw/s3

Fixes:https://tracker.ceph.com/issues/57826
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

doc/security: improve grammar in CVE-2022-0670.rst

This commit accepts the suggestions made by Cole Mitchell in
https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48163 from rhcs-dashboard/refactor-cephadm-e2e

mgr/dashboard: refactor dashboard cephadm e2e tests

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #47812 from rishabh-d-dave/json-decode-error

qa/cephfs: handle non-numeric values for json.loads()

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #47982 from SUSE/wip-fix-57390-2

ceph-dencoder: Add global to denc-mod-osd's target_link_libraries

Reviewed-by: Kefu Chai <tchaikov@gmail.com

Merge pull request #48350 from athanatos/sjust/wip-57739

crimson/.../replicated_request,logmissing_request: retain reference to req

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Radoslaw Zarzynski <rzarzynski@redhat.com>

Merge pull request #48308 from cyx1231st/wip-seastore-offset

crimson/os/seastore: introduce (64-8)-bit signed device_off_t and 32-bit signed segment_off_t

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>

Merge pull request #48349 from rzarzynski/wip-crimson-cltreq-errreply-debug

crimson/osd: introduce debug to ClientRequest::reply_op_error()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>

Merge pull request #47754 from batrick/i57248

qa: cleanup volumes on unwind

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #48064 from lxbsz/asok_fs

qa: the default CEPH_ASOK_DIR is asok/ now

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #48161 from trociny/wip-57589

cephfs-data-scan: make scan_links more verbose

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #48182 from lxbsz/wip-57580

qa: make mount to be compatible with nautilus for blocklist

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48421 from tchaikov/wip-cephadm-pyfakefs

cephadm: run tests as root

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #48423 from zdover23/wip-doc-2022-10-11-releases-pacific-grammar

doc/releases: improve grammar in pacific.rst

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48396 from rhcs-dashboard/fix-57792-main

mgr/dashboard: fix broken login links

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #48337 from batrick/first-python

tools/cephfs: convert first-damage.sh to python

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #46772 from cbodley/wip-rgw-doc-bucket-index

doc/dev/radosgw: start describing the bucket index

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

cephadm: pin pyfakefs to 5.0

so the test is more repeatable.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

cephadm: fix the indent

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

cephadm: run tests as root

as we will be create/access directories which are only accessible by
root with pyfakefs, and pyfake respects the uid of current effective
user, so if we run the test using non-root user, these tests would fail
after the fix for https://github.com/pytest-dev/pyfakefs/issues/489
is addressed in the pyfakefs we are using.

in this change, we will run the test on behalf of root, so we can
create and access the directories as we did before.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

doc/releases: improve grammar in pacific.rst

This commit accepts the grammar suggestions that were made by Cole
Mitchell in https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

cmake: do not link ceph-dencoder against global

it does not use any symbol from global, so no need to link it
against global.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Fixes: https://tracker.ceph.com/issues/57806
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

Revert "mgr/dashboard: unselect rows in datatables"

This reverts commit b79e2a6c6a9368a4fc167b05970db463cd60edab.

Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: refactor dashboard cephadm e2e tests

Fixes: https://tracker.ceph.com/issues/57511
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix weird data in osd details

The devices section in the OSD Details and Host Details shows more than
one daemon and device path in the column when you view the details of a
single osd details/host details. This is because more than one osd
is created on a device with same `deviceid`. I am not sure if this will
happen in the real environment but its mostly reproducible in
environments with QEMU emulated devices.

Fixes: https://tracker.ceph.com/issues/57803
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #48331 from tchaikov/crimson-stop

crimson/osd: shutdown on osdmaps' demand

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48238 from sisco0/fix-rgw-amqp-switch-compiler-warning-2

rgw: fix rabbitmq version checking for AMQP_STATUS_SSL_SET_ENGINE_FAILED

Merge pull request #48401 from zdover23/wip-doc-2022-10-09-crush-pdf-link-update

doc/various: update link to CRUSH pdf

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/various: update link to CRUSH pdf

This commit updates link to the research paper that announces and
explains the CRUSH algorithm. This link was broken in the migration from
the old Ceph website to ceph.io.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48399 from underacloud/wip-doc-spellin-errors

doc/radosgw: Fixes spelling errors in vault.rst

doc: Fixes spelling errors in vault.rst

Signed-off-by: Mary Frances underacloud.tech@gmail.com

Merge pull request #48393 from rzarzynski/wip-crimson-drop-omapiter

crimson: drop OmapIterator, use omap_get_values() instead

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48073 from rzarzynski/wip-crimson-asok-dump_recovery_reservations

crimson/osd: bring the dump_recovery_reservations asok cmd

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>

crimson/os: drop the OmapIterator concept

`get_omap_values()` is powerful enough to be used instead.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

test/crimson: unittest-seastar uses omap_get_values() instead of OmapIterator

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: convert seastarized PGLog from OmapIterator to omap_get_values()

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: read_omap_for_push_op() takes max_len as ref, not ptr

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: ReplicatedRecoveryBackend uses omap_get_values() instead of OmapIterator

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48374 from rkachach/fix_issue_57769

doc/cephadm: fixing grafana cert/key generation documentation

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #48128 from alimaredia/wip-intrusive-lru-destructor-add

common:  intrusive_lru destructor add

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

doc/cephadm: fixing grafana cet/key generation documentation
Fixes: https://tracker.ceph.com/issues/57769
Signed-off-by: Redouane Kachach <rkachach@redhat.com>

mgr/dashboard: fix broken login links

Fixes: https://tracker.ceph.com/issues/57792
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #48378 from ceph/wip-yuriw-crontab-master

qa/testing: added pacific-x and quincy-x for reef release

Reviewed-by: Laura Flores <lflores@redhat.com>

crimson/osd: bring the dump_recovery_reservations asok cmd

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48275 from liu-chunmei/rados-api-test

crimson/qa: add rados_api_tests.yaml for seastore

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48162 from Matan-B/wip-matanb-c-rados-test

qa/suites/crimson-rados/thrash: Adding workloads / Simplifying thrashers

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48277 from cyx1231st/wip-crimson-tools

crimson/net: fix msgr tools and test helpers

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48351 from athanatos/sjust/wip-57738

crimson/osd/replicated_backend: block _submit_transaction on sending the messages

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #47934 from phlogistonjohn/jjm-nfs-sectype

mgr/nfs: add sectype option

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #48301 from PepperJo/cmp_write_C_vec

librbd: add compare-and-write vector C API

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #48285 from adk3798/upgrade-start-version

qa/cephadm: do not start upgrades from Octopus

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #47903 from rkachach/fix_issue_57366

mgr/cephadm: reconfig prometheus when service-discovery port changes

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #48372 from idryomov/wip-57766

qa/tasks/rbd_fio: bump default to fio 3.32

Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

PendingReleaseNotes: add rbd_aio_compare_and_writev note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #47731 from mjenglish/multiple-actuator-osd-specification

python-common/ceph/deployment: filter drives by actuators when creating osds

Merge pull request #48319 from gregsfortytwo/wip-57737-cephfs-doc

doc: discuss the standard multi-tenant CephFS security model

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #48379 from zdover23/wip-doc-2022-10-06-install-clone-source-master-to-main

doc/install: clone-source.rst s/master/main

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/install: clone-source.rst s/master/main

s/master/main in doc/install/clone-source.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

qa/workunits/fs/damage: update first-damage test for python

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

tools/cephfs: convert first-damage.sh to python

To have only one RADOS instance and improve performance/reliability.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #46925 from rkachach/fix_issue_44461

mgr/cephadm: add a simple mechanism to check grafana cert/key

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #48353 from athanatos/sjust/wip-dump-live-ops

crimson: improve dump_ops_in_flight

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48352 from athanatos/sjust/wip-57740

crimson: allow pg creation to be canceled if pool is removed

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #48195 from athanatos/sjust/wip-57617

crimson/osd: populate version/user_version in reply for duplicate ops

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

qa/testing: added pacific-x and quincy-x for reef release

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #48289 from adamemerson/wip-warn-warn-warn

src/: silence Clang and GCC Warnings

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

doc: discuss the standard multi-tenant CephFS security model

Fixes: https://tracker.ceph.com/issues/57737
Signed-off-by: Greg Farnum <gfarnum@redhat.com>

doc/mgr/nfs: document --sectype option for export create commands

Add documentation for the option to specify the sectype (for enabling kerberos)
when creating a new export.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/nfs: add test cases to verify sectype can be set

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/nfs: add --sectype flag to nfs export create functions

Fixes: https://tracker.ceph.com/issues/57404
Add the sectype argument, also for use as a CLI option, to the functions
that create nfs exports. NFS Ganesha can use the sectype configuration
option to decide what kind of security will be applied/required for
connection to an export.

NOTE: This option is only useful when Ganesha is configured along with
LDAP/Kerberos integration. Configuration of that integration is outside
the scope of these patches.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/nfs: reformat long function calls to one line per arg

Using a hand rolled version of the long function call style similar to
that produced by the "Black" tool, put every argument to the
create_export function on a line of its own. This makes the code easier
to read and, importantly for an upcoming change, easier to add new
arguments.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/nfs: add sectype argument to nfs export management funcs

If the caller has supplied a sectype argument, pass it along to the
ganesha configuration functions.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/nfs: add awareness of the SecType option to ganesha_conf.py

This NFS-Ganesha option may be used to select kerberos integration in the
nfs client connection. If the option is not present in the configuration
dict, the option will not be present in the ganesha config blocks, just
as it was before.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

qa/cephadm: do not start upgrades from Octopus

now that we officially have v18 in main the upgrade
will fail if upgrading from Octopus (v15) to main
because they are now considered 3 major releases apart

Additionally adding more debugging to the end
of the upgrade tests as something like `ceph health detail`
can be very useful to see at the end of failed
upgrade tests

Fixes: https://tracker.ceph.com/issues/57695
Signed-off-by: Adam King <adking@redhat.com>

qa/tasks/rbd_fio: bump default to fio 3.32

fio 3.16 doesn't build against recent kernel headers due to removal of
linux/raw.h.

Fixes: https://tracker.ceph.com/issues/57766
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #44564 from zdover23/wip-doc-2022-01-13-44150-cleanup-grafana-data-source-name

doc/mgr: name data source in "Man Install & Config"

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #48362 from zdover23/wip-doc-2022-10-05-rados-ops-crush-map-edits-grammar

doc/rados: refine English in crush-map-edits.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/rados: refine English in crush-map-edits.rst

This commit makes several refinements to the English in
rados/operations/crush-map-edits.rst, which refinements were suggested
by Cole Mitchell and Anthony D'Atri in the discussion of PR#48085.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/osd/osd_operation: drop unused OSDOperationRegistry::dump_client_requests

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/osd: notify waiters if pool for creating pg does not exist

Fixes: https://tracker.ceph.com/issues/57740
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #48085 from zdover23/wip-doc-2022-09-14-rados-ops-crush-map-prompt-update

doc/rados: update prompts in crush-map-edits.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #47458 from rzarzynski/wip-all-kickoff-r

kickoff v18 reef

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

librbd: add compare-and-write vector C API

Add compare and write vector C API.
Require cmp_iov and write_iov to be the same length.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>

Merge pull request #46037 from mohmacht/ebdplugin

blk/kernel: add plugin system for devices with compression and move VDO support into plugin

Merge pull request #48346 from zdover23/wip-doc-2022-10-03-glossary-remove-redundancies

doc/glossary.rst: remove duplicates

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev/release-checklists: mention LIBRBD_VER_MINOR and VERSION

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: bump minor version to match R release

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #48218 from mchangir/qa-test_scrub_pause_and_resume_with_abort-wait-for-scrub-to-finish

qa: wait for scrub to finish

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>