rgw: fix bug where variable referenced after data moved out

Addresses RGWGetObj_ObjStore_S3::override_range_hdr using a variable
for logging after the data had been moved out. This was caught by
coverity.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 6038511c70d0ed4f5eb75194c1bc071f10653136)

Merge pull request #48176 from torchiaf/wip-57584-pacific

pacific: mgr/dashboard: Add details to the modal which displays the `safe-to-d…

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47764 from rzarzynski/wip-get_or_fail-debug-louder-pacific

pacific: msg: Log at higher level when Throttle::get_or_fail() fails

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>

Merge pull request #48189 from rhcs-dashboard/wip-57224-pacific

pacific: mgr/dashboard: fix rgw connect when using ssl

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47701 from rzarzynski/wip-dup-trimming-test2-pacific

pacific: osd, tools, kv: non-aggressive, on-line trimming of accumulated dups

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #47303 from petrutlucian94/wip-56729-pacific

pacific: msg: Fix Windows IPv6 support

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #47939 from idryomov/wip-56703-pacific

pacific: librbd/cache/pwl: narrow the scope of m_lock in write_image_cache_state()

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #47990 from guits/wip-57381-pacific

pacific: ceph-volume: add a retry in util.disk.remove_partition

Merge pull request #48158 from zdover23/wip-doc-2022-09-18-backport-48157-to-pacific

pacific: doc/rados: update prompts in network-config-ref

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48099 from adk3798/wip-57376-pacific

pacific: mgr/dashboard: enable addition of custom Prometheus alerts

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #48101 from adk3798/wip-57398-pacific

pacific: qa/cephadm: remove fsid dir before bootstrap in test_cephadm.sh

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48097 from adk3798/wip-57503-pacific

pacific: qa/tasks/kubeadm: set up tigera resources via kubectl create

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #48096 from adk3798/wip-57528-pacific

pacific: mgr/cephadm: reconfig iscsi daemons if trusted_ip_list changes

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

mgr/dashboard: enable addition custom Prometheus alerts

Fixes: https://tracker.ceph.com/issues/57294
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit 3551d7f8b36d883a72b85f0bd5568a33ac00e62c)

Conflicts:
doc/cephadm/services/monitoring.rst
src/pybind/mgr/cephadm/services/monitoring.py
src/pybind/mgr/cephadm/tests/test_services.py

Merge pull request #48098 from adk3798/wip-57424-pacific

pacific: cephadm: Fix disk size calculation

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48100 from adk3798/wip-57427-pacific

pacific: mgr/cephadm: allow setting prometheus retention time

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #48102 from adk3798/wip-57379-pacific

pacific: cephadm: return nonzero exit code when applying spec fails in bootstrap

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48103 from adk3798/wip-57384-pacific

pacific: mgr/cephadm: Adding logic to store grafana cert/key per node

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

mgr/dashboard: fix rgw connect when using ssl

connecting with the hostname instead of the ip address when using ssl

Fixes: http://tracker.ceph.com/issues/56970
Signed-off-by: Henry Hirsch <henry.hirsch@1und1.de>
(cherry picked from commit ca8f77d6a7fa361328a942e3f37c81dd9577d4de)

Merge pull request #47888 from rhcs-dashboard/wip-57357-pacific

pacific: mgr/dashboard: ensure limit 0 returns 0 images

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47636 from rhcs-dashboard/wip-57143-pacific

pacific: mgr/dashboard: fix _rbd_image_refs caching

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47978 from neesingh-rh/wip-57439-pacific

pacific: cephfs-top: display average read/write/metadata latency

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48045 from rhcs-dashboard/wip-57493-pacific

pacific: mgr/dashboard: fix openapi-check

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47995 from idryomov/wip-52810-pacific

pacific: librbd: retry ENOENT in V2_REFRESH_PARENT as well

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #47866 from neesingh-rh/wip-57274-pacific

pacific: mgr/stats: missing clients in perf stats command output.

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com

Merge pull request #47769 from neesingh-rh/wip-57263-pacific

pacific: mgr/volumes: Add volume info command

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47647 from joscollin/wip-57155-pacific

pacific: cephfs-top: fix the rsp/wsp display

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

mgr/dashboard: Add details to the modal which displays the `safe-to-destroy` result

- Add warnings type information in the case of the OSDs are not safe to destroy
- Add info type information in the case of the OSDs are safe to destroy

Fixes: https://tracker.ceph.com/issues/37327
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit 0d6100bbf99ffa8da0e099343ede050f1cca509c)

Merge pull request #47386 from s0nea/wip-56990-pacific

pacific: monitoring/ceph-mixin: OSD overview typo fix

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/rados: update prompts in network-config-ref

This PR adds unselectable prompts to network-config-
ref.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit e26c1d8574a27e97cbc2ef5e65d6b679b25cd710)

Merge pull request #47528 from lxbsz/wip-57083

pacific: qa/import-legacy: install python3 package for nautilus ceph

Reviewed-by: Kotresh HR khiremat@redhat.com

doc: include read, write, metadata average latencies in doc/man.

Also, the sample cephfs-top image in the doc is outdated. Update that!

Fixes: http://tracker.ceph.com/issues/48619
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit aa04f3faedb6edcb0897e802a8390904deb6f936)

cephfs-top: display latency in milliseconds

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit bf261f2a07111361ec8db36a7a4b13b54ff5d891)

cephfs-top: switch to displaying average latencies and stdev

Do away with cumulative latencies -- those are not much useful.
However, these types need to be maintained since `perf stats`
command (via mgr/stats plugin) includes them. So, maintain a
legacy metrics list which is ignored when choosing metrics to
display.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 60f33a8ca3055ec5ae5c8d67fd03f571bcec8892)

mgr/stats: include average latencies and stdev in `perf stat` dump

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit b2bc45223b02ded7a5cc921980b3961c5e1d5893)

mgr/stats: auto generate metrics names from configured metrics

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit aaeec93efd2ae03d740299a5b22bb9203fbd7b8d)

client: forward read, write, metadata average latency and stdev

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 9b4f210b58571c0d88e5e01b90e6106cd894c3be)

Conflicts:
src/client/Client.cc:Added 'if' condition in read,write and
metadata latencies in 'Client::collect_and_send_global_metrics()'

mds, mgr: plumb in new client metrics

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit f1083c0b3d41e6691945e8b40df8aa707a261217)

Conflicts:
src/include/cephfs/metrics/Types.h:instead of std::ostream
using ostream as is used in other places for latencies.

client: track average read, write and metadata IO latencies

And also standard deviation for each to measure the variance
(volatility) of latencies.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 967e24fe5c0efd9d7eb870494610fd1b4412f1d6)

qa: add test_perf_stats_stale_metrics_with_multiple_filesystem

Fixes: https://tracker.ceph.com/issues/56483
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit e717e216ea956de91cf41986a9f8e1b8b4ddf09f)

Conflicts:
qa/tasks/cephfs/test_mds_metrics.py

mgr/stats: missing clients in perf stats command output.

perf stats doesn't get the client info w.r.t new filesystems
created or filesystems created on failing other filesystem
after running the perf stats command once with existing filesystems.

Fixes: https://tracker.ceph.com/issues/56483
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 584394fb243416ca50c2b5e05de5d20dd46be114)

Merge pull request #47972 from vshankar/tr-55931

pacific: client: allow overwrites to file with size greater than the max_file_size

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #47923 from petrutlucian94/wip-57403-pacific

pacific: include: fix IS_ERR on Windows

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #47862 from lxbsz/wip-57252

pacific: libcephfs: define AT_NO_ATTR_SYNC back for backward compatibility

Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #47851 from joscollin/wip-57279-pacific

pacific: mgr/stats: change in structure of perf_stats o/p

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

mgr/cephadm: Adding logic to store grafana cert/key per node
Fixes: https://tracker.ceph.com/issues/56508
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 3c990f974e3beac0fc03f58c4c47f26f9d5afe56)

Conflicts:
src/pybind/mgr/cephadm/tests/test_services.py

cephadm: return nonzero exit code when applying spec fails in bootstrap

This is mostly useful for testing automation, but right now if applying the
spec provided with --apply-spec fails, the return code remains zero. We don't
want to error out entirely in that case as we still want to print the remaining
output (e.g. the dashboard password). Continuing onward and then returning a
nonzero code could provide a balance where we still give all the output but
still have something to make it easier for those writing automation around bootstrap.

Fixes: https://tracker.ceph.com/issues/57173
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit be17f1d4b30e19aa6039fa5d6a694129cb5f3583)

qa/cephadm: remove fsid dir before bootstrap in test_cephadm.sh

The shell commands we test beforehand can create the
/var/lib/ceph/00000000-0000-0000-0000-0000deadbeef directory
and that directory being present will block bootstrap as
it will think a cluster with this fsid alreayd exists

Fixes: https://tracker.ceph.com/issues/57290
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 7c825da44aee1245e8a17bcdc37512c226463bcf)

doc/cephadm: documentation for setting prometheus retention time

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 11fc0ef194dc347de075cde1274933ec83164404)

mgr/cephadm: allow setting prometheus retention time

When we deploy Prometheus server, we don't provide any
ability to define the tsdb retention time - so it defaults to 15d.

This change adds a field that can be passed in a prometheus service
spec that will be passed as an arg to the --storage.tsdb.retention.time
parameter for the prometheus daemon.

Fixes: https://tracker.ceph.com/issues/54308
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 91dd03fd648d25773a83fdad311b62b781619fc4)

Conflicts:
src/pybind/mgr/cephadm/services/monitoring.py
src/pybind/mgr/cephadm/tests/test_services.py
src/python-common/ceph/deployment/service_spec.py

cephadm: Fix disk size calculation

With native 4k sectors, the logical blocksize is set to
4096, which yields a disk size 8x the size of the actual
device. According to kernel source, device size only
uses 512 byte sectors, so the use of logical blocksize
is unnecessary.

Fixes: https://tracker.ceph.com/issues/57335
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit a6f10ebd572cbf95c94614a94f981ca3550fca25)

qa/tasks/kubeadm: set up tigera resources via kubectl create

Fixes: https://tracker.ceph.com/issues/57268
The tigera operator for the calico CNI has some pretty large resource
definitions. The length of the definitions can cause the "client side
apply", the default mode for `kubectl apply ....`, to fail due to the
length of the needed annotation that would result:

```
2022-08-22T20:24:55.636 INFO:teuthology.orchestra.run.smithi087.stdout:clusterrolebinding.rbac.authorization.k8s.io/tigera-operator created
2022-08-22T20:24:55.670 INFO:teuthology.orchestra.run.smithi087.stdout:deployment.apps/tigera-operator created
2022-08-22T20:24:55.671 INFO:teuthology.orchestra.run.smithi087.stderr:The CustomResourceDefinition "installations.operator.tigera.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
2022-08-22T20:24:55.674 DEBUG:teuthology.orchestra.run:got remote process result: 1
```

There are two simple options for avoiding this error. One is to use
`kubectl create`. The create command will not make this lengthy
annotation. It will fail if any of the resources already exist. The
other option is to use server-side apply, via the `kubectl apply
--server-side ...` command. It is new in k8s 1.18. It will not create
the annotation either.

The block of code setting up the CNI already uses `kubectl create` to
create the custom resources that configure the tigera operator.
Therefore it should be safe to assume the block of code in question
doesn't need to be idempotent and we can also use `kubectl create`
elsewhere in the same block.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit f8b0511d6c45977f2f7925769cf570a82ea447bc)

mgr/cephadm: reconfig iscsi daemons if trusted_ip_list changes

This is necessary as iscsi daemons expect the iscsi-gateway.cfg
which includes this list to match across the iscsi daemons

Fixes: https://tracker.ceph.com/issues/57078
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 8a6e67c6a32f71f38dd3dafe84e6a5e7b2a99f5a)

Conflicts:
src/pybind/mgr/cephadm/module.py

Merge pull request #48060 from zdover23/wip-doc-2022-09-13-backport-47575-to-pacific

pacific: doc/rados: add prompts to pools.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48062 from zdover23/wip-doc-2022-09-13-backport-47305-to-pacific

pacific: doc/monitoring: add min vers of apps in mon stack

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/monitoring: add min vers of apps in mon stack

https://tracker.ceph.com/issues/45447

This PR adds recommended versions of grafana and
prometheus and alert manager.

This PR is a second attempt at getting the information
in the following PR into the docs:
https://github.com/ceph/ceph/pull/46000/files

Himadri Maheshwari deserves the credit for the work
in this commit.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
Signed-off-by: Himadri Maheshwari <himadri.maheshwari7915@gmail.com>
(cherry picked from commit 367695f5b09f75ee723d53116e2f4a6e45dd795d)

doc/rados: add prompts to pools.rst

This commit adds ".. prompt:: bash $"-style prompts to pools.rst.
This brings this file up to the standard established in 2020 when
Kefu added support for the ".. prompt::" directive.

This commit is a part of an initiative to modernize the presentation
of all BASH commands in the RADOS documentation.

The progress of this project can be tracked here:
https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 1bd64192568242b141d8e30fef6758bf162ec350)

Merge pull request #47823 from zdover23/wip-doc-2022-08-27-backport-47810-to-pacific

pacific: doc/mgr: add prompt directives to dashboard.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

mgr/dashboard: docs gen tags sort

When generating tags the order of endpoints wasn't taken into account.
Two endpoints with the same url prefix, for example `/api/cluster/` and
`/api/cluster/user`, have different docs and the tags is generated from
a doc of one of these two, and since the order of these endpoints might
vary it is imperative to sort them to have a deterministic output.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 9673ed18699cdca3f032fd131d4248b010750ef6)

Merge pull request #48024 from idryomov/wip-57116-cont-pacific

pacific: test/{librbd, rgw}: increase delay between and number of bind attempts

Reviewed-by: Laura Flores <lflores@redhat.com>

test/{librbd, rgw}: increase delay between and number of bind attempts

Commit aa7885f7cc41 ("test/{librbd, rgw}: retry when bind fail with
port 0") reduced the frequency of sporadic unit test failures caused
by EADDRINUSE a lot, but not entirely.

Currently, it yields a cumulative sleep of ~9 seconds.  Let's increase
that to 1 minute.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 48016eaa1511ac8a39ed33084e0e230f3b1b5821)

test/{librbd, rgw}: retry when bind fail with port 0

there is chance that the bind() call may fail if we have another test
happen to pick the free port picked by operating system. in this case,
we just retry up to 42 times.

in theory, this change does not fully address the racing, but it should
help to alleviate this issue.

See-also: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit aa7885f7cc41390fcc8eeb82bc7142c3ff6a53f9)

Conflicts:
src/test/rgw/test_http_manager.cc [ commit f5019d2a8388 ("rgw:
  Set CURLOPT_NOBODY for HEAD request") not in pacific ]

Merge pull request #47693 from pdvian/wip-55309-pacific

pacific: mgr, mgr/prometheus: Fix regression with prometheus metrics

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #47433 from lxbsz/wip-56462

pacific:  mds: skip fetching the dirfrags if not a directory

Reviewed-by: Kotresh HR khiremat@redhat.com

Merge pull request #47056 from lxbsz/wip-56449

pacific: mds: notify the xattr_version to replica MDSes

Reviewed-by: Kotresh HR khiremat@redhat.com

librbd: make RefreshRequest tests compatible with clone v1

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 36f1d515ca92784631d29fa1c5d1465e957af2a7)

librbd: retry ENOENT in V2_REFRESH_PARENT as well

With auto-deletion of trashed snapshots, it is relatively easy to lose
a race to "rbd flatten" as follows:

- when V2_GET_PARENT runs, the image is technically still a clone
- when V2_REFRESH_PARENT runs, the image is fully flattened and the
  snapshot in the parent image is deleted

This results in a spurious ENOENT error, mainly when trying to open the
image (e.g. for "rbd info").  This race condition has always been there
but auto-deletion of trashed snapshots makes it much worse.

Retry ENOENT in V2_REFRESH_PARENT the same way as in V2_GET_SNAPSHOTS.

Fixes: https://tracker.ceph.com/issues/52810
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit bd885d75b2e4d728086f744e0d10e7cd12d3f15b)

librbd: limit the number of ENOENT retries in RefreshRequest

If the image header is corrupt, ENOENT error may be persistent.  Avoid
an infinite loop in that case.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 8570194b133462db6b7d4ab108383db0967b1cb9)

librbd: fix a bunch of issues with restarting RefreshRequest

Make RefreshRequest properly restartable, at least up until and including
V2_REFRESH_PARENT step:

- clear m_migration_spec when skipping GET_MIGRATION_HEADER
- don't rely on potentially stale m_incomplete_update on retry
- reset m_legacy_parent when retrying more than just V2_GET_PARENT
- don't rely on potentially stale m_parent_md.overlap and
  m_head_parent_overlap on retry
- clear m_metadata before fetching image metadata (but not before
  fetching pool metadata)
- clear m_op_features when skipping V2_GET_OP_FEATURES
- clear m_group_spec on EOPNOTSUPP error in V2_GET_GROUP
- reset m_legacy_snapshot when retrying more than just V2_GET_SNAPSHOTS
- don't rely on potentially stale m_snap_parents on retry

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 6bd89ea119520cf5a45ac93b0e16edf35ddd4e57)

librbd: check *result consistently in RefreshRequest

Stick to *result >= 0 checks everywhere and add missing checks for
op_features_get_finish() and image_group_get_finish() errors.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit ce6dff89c0f005c1ae1dc71cadfbef9f82df37a4)

librbd: reflect V2_GET_SNAPSHOTS ENOENT retry in state diagram

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit ca36ffa347f0c68115a7d6b54ebb47ac5e82698d)

Merge pull request #47556 from ifed01/wip-ifed-cleanup-onode-pin-pac

pacific: os/bluestore: get rid of fake onode nref increment for pinned entry

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #47611 from adk3798/pacific-multiple-vips

pacific: Cephadm: Allow multiple virtual IP addresses for keepalived and haproxy

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #47512 from nmshelke/wip-57058-pacific

pacific: mgr/volumes: filter internal directories in 'subvolumegroup ls' command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR khiremat@redhat.com

Merge pull request #47535 from guits/wip-57088-pacific

pacific: ceph-volume: system.get_mounts() refactor

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #47661 from adk3798/wip-57169-pacific

pacific: cephadm: support for Oracle Linux 8

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47663 from adk3798/wip-57103-pacific

pacific: mgr/cephadm: recreate osd config when redeploy/reconfiguring

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47662 from adk3798/wip-57148-pacific

pacific: mgr/cephadm: set dashboard grafana-api-password when user provides one

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

mgr/cephadm: loop over all vips when trying to find ingress' interface

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit 1b9a6a0f58a9a7550e8b93573b3191816da5f900)

Split single and multiple vips test into 2 functions

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit f6d4ab9f25e5c9ee1872dbfd18bebbaf9a72a2d0)

mgr/cephadm: update haproxy/keepalive service test for newly generated files

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit a69a6fb4f5275af8a2757003f7fb5ca1f1ab9d2f)

mgr/cephadm: set explicit * bind for haproxy when using multiple vips

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit a11e181b98ffccff40939068d86254e7f8a98c06)

mgr/cephadm: update doc for multiple vips for ingress

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit 7b064e8b0eab0b577470122534e1b2647f5191cc)

mgr/cephadm: set test for multiple vips options for ingress service

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit 5915d2ecd08c1289da38d4fbeb646898f9c5dccf)

mgr/cephadm: allow for multiple vip configuration on ingress service

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit 0193a6f73659f7aa4ac1d000cf11c6544ad6ab6d)

Merge pull request #47627 from guits/wip-57133-pacific

pacific: cephadm/ceph-volume: fix rm-cluster --zap

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #47664 from adk3798/wip-57099-pacific

pacific: cephadm: support quotes around public/cluster network in config passed to bootstrap

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47684 from batrick/i57183

pacific: crash: pthread_mutex_lock()

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #47522 from kamoltat/wip-ksirivad-backport-pacific-46242

pacific: pybind/mgr/pg_autoscaler: change overlapping roots to warning
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #47380 from NitzanMordhai/wip-55156-pacific

pacific: mon/ConfigMonitor: fix config get key with whitespaces

Reviewed-by: Neha Ojha: <nojha@redhat.com>

Merge pull request #47692 from pdvian/wip-55308-pacific

pacific: mgr, mon: Keep upto date metadata with mgr for MONs

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #47401 from tserong/wip-56977-pacific

pacific: cephfs-shell: move source to separate subdirectory

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>

Merge pull request #47282 from batrick/i56712

pacific: mds: standby-replay daemon always removed in MDSMonitor::prepare_beacon

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #47920 from idryomov/wip-57343-pacific

pacific: test/cli-integration/rbd: iSCSI REST API responses aren't pretty-printed anymore

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

ceph-volume: add a retry in util.disk.remove_partition

This fixes a possible race condition when zapping a device.
Due to some udev events, that race condition makes the key
`ID_PART_ENTRY_NUMBER` show up too late.

The idea here is to retry multiple times before actually failing.

Fixes: https://tracker.ceph.com/issues/57144
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 3fedce6c34fb3acfa57b5a028cb750041ee8fbd6)

qa: filter internal directories in 'subvolumegroup ls' command

Internal directories: '_nogroup', '_index', '_legacy', '_deleting'
1. Internal directories should be filtered in 'subvolmegroup ls' command.
2. Internal directories should not be accepted as a group name.

Fixes: https://tracker.ceph.com/issues/55762
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
(cherry picked from commit 7b585d4db921112edeea3c879cb8bca0200c1b71)

mgr/volumes: filter internal directories in 'subvolumegroup ls' command

Internal directories: '_nogroup', '_index', '_legacy', '_deleting'
1. Internal directories should be filtered in 'subvolmegroup ls' command.
2. Internal directories should not be accepted as a group name.

Fixes: https://tracker.ceph.com/issues/55762
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
(cherry picked from commit ce3fa7f1bcd9ca8a9e9e80ca33a15d0746ce7110)

Merge pull request #47911 from idryomov/wip-57317-pacific

pacific: librbd: use actual monitor addresses when creating a peer bootstrap token

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #46949 from lxbsz/wip-56056

pacific: ceph-fuse: add dedicated snap stag map for each directory

Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #47583 from idryomov/wip-57107-pacific

pacific: rbd: find_action() should sort actions first

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>