crimson/osd: ClientRequest sends error to client when loading obc fails

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: move ClientRequest::reply_op_error() up

It's because it's return type is `auto`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: ClientRequest::reply_op_error() takes pgref by const

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: return enoent when PG::resolve_oid() fails

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48196 from neesingh-rh/wip-human-readable-volume-info

mgr/volumes: Add human-readable flag to volume info command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #48367 from stefan-chivu/namespace-optarg-fix

rbd: device map/unmap --namespace handling fixes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #45395 from tobias-urdin/rgw-keystone-service-token

rgw/auth: Add service token support for Keystone auth

PendingReleaseNotes: add "rbd device unmap --namespace" note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa/workunits/rbd-nbd: also test map/unmap with --namespace option

The entire script is using specs, let's cover non-spec syntax as well.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: Removed device_name argument from wnbd unmap

Right now, rbd-wnbd doesn't actually use disk path
identifiers such as "/dev/*" or "\\.\PhysicalDrive*".

So instead of accepting two arguments that are basically
handled more or less the same, we're dropping the device_name
argument and sticking to the image spec.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>

rbd: Moved get_image_or_snap_spec and parse_options to utils

At the moment, there are multiple copies of "get_image_or_snap_spec".

For this reason, we're moving it to Utils.cc so that all backends may
re-use it, also benefiting from the recent pool related fix.

We are also renaming parse_options to append_options_as_args and
changing its type to void

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>

rbd: Added namespace optarg for rbd device unmap

When executing rbd device unmap, an explicit namespace optarg wasn't available

Fixes: https://tracker.ceph.com/issues/57765
Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>

qa: add tests for 'fs volume command --human_readable'

Fixes: https://tracker.ceph.com/issues/57620
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>

doc: documenting the --human_readable flag for volume info cmd

Fixes: https://tracker.ceph.com/issues/57620
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>