]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoPendingReleaseNotes: add "rbd device unmap --namespace" note 48458/head
Ilya Dryomov [Mon, 10 Oct 2022 18:18:12 +0000 (20:18 +0200)]
PendingReleaseNotes: add "rbd device unmap --namespace" note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2df426bd9743309318cc1022853d0033e9c7c4b9)

3 years agoqa/workunits/rbd-nbd: also test map/unmap with --namespace option
Ilya Dryomov [Sat, 8 Oct 2022 14:16:10 +0000 (16:16 +0200)]
qa/workunits/rbd-nbd: also test map/unmap with --namespace option

The entire script is using specs, let's cover non-spec syntax as well.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit edfcf4bd6b2de0de124ec850c75feac3d76a863e)

3 years agorbd: Removed device_name argument from wnbd unmap
Stefan Chivu [Tue, 4 Oct 2022 14:02:14 +0000 (14:02 +0000)]
rbd: Removed device_name argument from wnbd unmap

Right now, rbd-wnbd doesn't actually use disk path
identifiers such as "/dev/*" or "\\.\PhysicalDrive*".

So instead of accepting two arguments that are basically
handled more or less the same, we're dropping the device_name
argument and sticking to the image spec.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit 79127642eb66bd878a1bb6fbf402d695af5bac63)

3 years agorbd: Moved get_image_or_snap_spec and parse_options to utils
Stefan Chivu [Tue, 4 Oct 2022 12:25:45 +0000 (12:25 +0000)]
rbd: Moved get_image_or_snap_spec and parse_options to utils

At the moment, there are multiple copies of "get_image_or_snap_spec".

For this reason, we're moving it to Utils.cc so that all backends may
re-use it, also benefiting from the recent pool related fix.

We are also renaming parse_options to append_options_as_args and
changing its type to void

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit efe8ceb5398e52418ae9ac8c3e227d8bd66a65ff)

3 years agorbd: Added namespace optarg for rbd device unmap
Stefan Chivu [Mon, 3 Oct 2022 08:20:58 +0000 (08:20 +0000)]
rbd: Added namespace optarg for rbd device unmap

When executing rbd device unmap, an explicit namespace optarg wasn't available

Fixes: https://tracker.ceph.com/issues/57765
Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit 51ba25c05c8ec93b26fc0b4fe6f3e5b685093244)

3 years agoMerge pull request #48474 from idryomov/wip-librbd-cmp-write-quincy
Ilya Dryomov [Mon, 17 Oct 2022 08:06:19 +0000 (10:06 +0200)]
Merge pull request #48474 from idryomov/wip-librbd-cmp-write-quincy

quincy: librbd: compare-and-write fixes and vector C API

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
3 years agoMerge pull request #48502 from zdover23/wip-doc-2022-10-17-backport-48501-to-quincy
zdover23 [Sun, 16 Oct 2022 18:38:57 +0000 (04:38 +1000)]
Merge pull request #48502 from zdover23/wip-doc-2022-10-17-backport-48501-to-quincy

quincy: doc/radosgw: refine notifications.rst - top part

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: refine notifications.rst - top part 48502/head
Zac Dover [Sun, 16 Oct 2022 17:54:25 +0000 (03:54 +1000)]
doc/radosgw: refine notifications.rst - top part

This commit refines the English in the first part of the
notifications.rst page (the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 840a2fe3e30d099459ccee0c4c7735853dad0bb9)

3 years agoMerge pull request #48499 from zdover23/wip-doc-2022-10-16-backport-48498-to-quincy
zdover23 [Sun, 16 Oct 2022 03:59:19 +0000 (13:59 +1000)]
Merge pull request #48499 from zdover23/wip-doc-2022-10-16-backport-48498-to-quincy

quincy: doc/radosgw: update notifications.rst - grammar

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: update notifications.rst - grammar 48499/head
Zac Dover [Sun, 16 Oct 2022 03:09:35 +0000 (13:09 +1000)]
doc/radosgw: update notifications.rst - grammar

This commit rewrites a sentence, as requested by
C. Mitchell here:
https://github.com/ceph/ceph/pull/48493/files#r996003812

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 43c37c6721b373af41fe58235b77a917d1961fc1)

3 years agoMerge pull request #48494 from zdover23/wip-doc-2022-10-15-backport-48493-to-quincy
zdover23 [Fri, 14 Oct 2022 21:26:38 +0000 (07:26 +1000)]
Merge pull request #48494 from zdover23/wip-doc-2022-10-15-backport-48493-to-quincy

quincy: doc/radosgw: improve grammar - notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #48228 from ivancich/wip-57430-quincy
Yuri Weinstein [Fri, 14 Oct 2022 18:54:16 +0000 (11:54 -0700)]
Merge pull request #48228 from ivancich/wip-57430-quincy

quincy: rgw: fix bug where variable referenced after data moved out

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 years agodoc/radosgw: improve grammar - notifications.rst 48494/head
Zac Dover [Fri, 14 Oct 2022 17:48:44 +0000 (03:48 +1000)]
doc/radosgw: improve grammar - notifications.rst

This commit makes the changes suggested by C. Mitchell in
https://github.com/ceph/ceph/pull/48486.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 98a4d938e561eb924950535c1a4fe1d6b02849c5)

3 years agoMerge pull request #48487 from zdover23/wip-doc-2022-10-14-backport-48486-to-quincy
zdover23 [Fri, 14 Oct 2022 07:08:43 +0000 (17:08 +1000)]
Merge pull request #48487 from zdover23/wip-doc-2022-10-14-backport-48486-to-quincy

quincy: doc/radosgw: add push_endpoint for rabbitmq

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: add push_endpoint for rabbitmq 48487/head
Zac Dover [Fri, 14 Oct 2022 06:17:12 +0000 (16:17 +1000)]
doc/radosgw: add push_endpoint for rabbitmq

This commit directs users of rabbitmq to use "push_endpoint"
(with an underscore) instead of "push-endpoint" (with a hy-
phen). This commit adds a note that contains such a direct-
ive. It does not alter the examples already present in the
text.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit ddf8295438b14ada04d8bb5dfc23402bedc937b8)

3 years agoMerge pull request #48479 from zdover23/wip-doc-2022-10-13-backport-48463-to-quincy
zdover23 [Thu, 13 Oct 2022 13:31:12 +0000 (23:31 +1000)]
Merge pull request #48479 from zdover23/wip-doc-2022-10-13-backport-48463-to-quincy

quincy: doc/dev: add submodule-update link to dev guide

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/dev: add submodule-update link to dev guide 48479/head
Zac Dover [Wed, 12 Oct 2022 12:39:36 +0000 (22:39 +1000)]
doc/dev: add submodule-update link to dev guide

This commit links to the procedure in install/clone-source.rst that
explains how to update submodules.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit e55c3b114be402eae94550c603cf7c028c9b64bf)

3 years agoPendingReleaseNotes: add rbd_aio_compare_and_writev note 48474/head
Ilya Dryomov [Thu, 6 Oct 2022 10:36:00 +0000 (12:36 +0200)]
PendingReleaseNotes: add rbd_aio_compare_and_writev note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit bd98a66d03a0d9b0a8d1d6d6c0bd698b5baff60f)

Conflicts:
PendingReleaseNotes [ moved to >=17.2.5 section ]

3 years agolibrbd: add compare-and-write vector C API
Jonas Pfefferle [Thu, 29 Sep 2022 19:39:12 +0000 (21:39 +0200)]
librbd: add compare-and-write vector C API

Add compare and write vector C API.
Require cmp_iov and write_iov to be the same length.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit 60fd534731487fa15372558f018099df1bca06a3)

3 years agotest/librbd: various fixups for compare-and-write test cases
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
test/librbd: various fixups for compare-and-write test cases

- missing EILSEQ asserts in IO and IOWithIOHint
- AioCompletion leak in CompareTooSmall and WriteTooSmall
- skip StripeUnitUnaligned and TooLarge on the PWL cache as it wasn't
  limited by the 512-byte sector limit before and isn't limited by the
  stripe unit limit now

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 093e8237450f561a2267b07231426f86735a2faf)

3 years agolibrbd/cache/pwl: adjust compare-and-write compare substringing
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
librbd/cache/pwl: adjust compare-and-write compare substringing

cmp_bl can no longer be shorter than read_bl (i.e. image extent).
This is caught very early at the API level, see commit af96e6dae3f4
("librbd: make C++ cmp&write semantics equal to C API").

However, cmp_bl can still be longer than read_bl and in that case
it should be capped by the image extent length.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 35f3ccb68714f18cc1ff78278fdd5216590cc9bf)

3 years agolibrbd: discard cache state if compare-and-write writes to disk
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
librbd: discard cache state if compare-and-write writes to disk

Otherwise this is obviously broken with rbd_cache_policy = writeback or
rbd_cache_policy = writethrough as the write is done on the OSD, beneath
ObjectCacher.  This went unnoticed because the original (and so far the
only known) compare-and-write user, tcmu-runner rbd driver, disables the
cache altogether.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit ec0fc71cdb579e31ff4e599c43f3918322e70ddf)

3 years agoPendingReleaseNotes: add rbd compare-and-write notes
Ilya Dryomov [Fri, 12 Aug 2022 11:55:01 +0000 (13:55 +0200)]
PendingReleaseNotes: add rbd compare-and-write notes

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 4ddcb7ff92a51a6fa17887e54fd357bd5dea5f4e)

Conflicts:
PendingReleaseNotes [ moved to >=17.2.5 section ]

3 years agolibrbd: make C++ cmp&write semantics equal to C API
Jonas Pfefferle [Fri, 5 Aug 2022 17:37:55 +0000 (19:37 +0200)]
librbd: make C++ cmp&write semantics equal to C API

The compare and write C++ API (both sync and async) does not check
compare bufferlist length and executes compare ops of bufferlist length
size, even if (write) "len" is smaller than bufferlist length.
This patch changes this behavior by always issuing compares and
writes of "len" size to match the C API. The bufferlist length
can be greater than "len" for both compare and write but only
"len" bytes are compared and written. If the bufferlist length
is smaller than "len" the call will fail.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit af96e6dae3f4c3e30f91cb26d6579a6b5a726862)

3 years agolibrbd: remove cmp&write sector size restriction
Jonas Pfefferle [Fri, 5 Aug 2022 17:36:36 +0000 (19:36 +0200)]
librbd: remove cmp&write sector size restriction

This patch removes the compare and write max sector size len
restriction. We can allow up to stripe unit size accesses if
the access is aligned properly.
To allow larger size compare and write requests in the
journal we split the buffers like we do for writes now.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit d80cff0dd665d660cd545c5a66d265b6bf732c73)

3 years agolibrbd: new cmp&write C API tests
Jonas Pfefferle [Tue, 3 May 2022 07:16:00 +0000 (09:16 +0200)]
librbd: new cmp&write C API tests

Test correct mismatch offset is returned.
Test no data is written when compare fails.
Test correct data is written when compare succeeds.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit 3eb7ac6aeb3d11911bcf1c393ddee8913414bef7)

3 years agoMerge pull request #48464 from zdover23/wip-doc-2022-10-15-backport-48460-to-quincy
zdover23 [Wed, 12 Oct 2022 18:04:02 +0000 (04:04 +1000)]
Merge pull request #48464 from zdover23/wip-doc-2022-10-15-backport-48460-to-quincy

quincy: doc/install: improve updating submodules procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/install: improve updating submodules procedure 48464/head
Zac Dover [Wed, 12 Oct 2022 08:27:42 +0000 (18:27 +1000)]
doc/install: improve updating submodules procedure

This commit beefs up the "Updating Submodules" procedure,
which (prior to this commit) was quite brief.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 9382a90342f96cabab4b7caf816d9381f77e7f46)

3 years agoMerge pull request #48219 from s0nea/wip-57661-quincy
Nizamudeen A [Wed, 12 Oct 2022 05:07:46 +0000 (10:37 +0530)]
Merge pull request #48219 from s0nea/wip-57661-quincy

quincy: mgr/dashboard: add option to resolve ip addr

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #48340 from rhcs-dashboard/fix-fedora-url-quincy
Nizamudeen A [Tue, 11 Oct 2022 19:33:34 +0000 (01:03 +0530)]
Merge pull request #48340 from rhcs-dashboard/fix-fedora-url-quincy

quincy: mgr/dashboard: Fix broken Fedora image URL

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: zmc <NOT@FOUND>
3 years agoMerge pull request #48447 from zdover23/wip-doc-2022-10-12-backport-48446-to-quincy
zdover23 [Tue, 11 Oct 2022 18:09:38 +0000 (04:09 +1000)]
Merge pull request #48447 from zdover23/wip-doc-2022-10-12-backport-48446-to-quincy

quincy: doc/glossary: add "ceph monitor" entry

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/glossary: add "ceph monitor" entry 48447/head
Zac Dover [Tue, 11 Oct 2022 16:49:13 +0000 (02:49 +1000)]
doc/glossary: add "ceph monitor" entry

This commit adds information to the "ceph monitor" entry in
glossary.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 8f4ad5dc9d171c805f061b937ad1110b53255fa6)

3 years agoMerge pull request #48433 from rhcs-dashboard/wip-57831-quincy
Nizamudeen A [Tue, 11 Oct 2022 16:18:35 +0000 (21:48 +0530)]
Merge pull request #48433 from rhcs-dashboard/wip-57831-quincy

quincy: mgr/dashboard: fix weird data in osd details

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #48430 from zdover23/wip-doc-2022-10-11-backport-48429-to-quincy
zdover23 [Tue, 11 Oct 2022 16:13:08 +0000 (02:13 +1000)]
Merge pull request #48430 from zdover23/wip-doc-2022-10-11-backport-48429-to-quincy

quincy: doc/security: improve grammar in CVE-2022-0670.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agoMerge pull request #48438 from rhcs-dashboard/wip-57838-quincy
Nizamudeen A [Tue, 11 Oct 2022 11:08:26 +0000 (16:38 +0530)]
Merge pull request #48438 from rhcs-dashboard/wip-57838-quincy

quincy: mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: auto-coloring-badges-component 48433/head
Pedro Gonzalez Gomez [Tue, 5 Jul 2022 09:40:01 +0000 (11:40 +0200)]
mgr/dashboard: auto-coloring-badges-component

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 29f510a522b2694903d095ac0ec45ee23c474121)

3 years agoMerge pull request #48434 from rhcs-dashboard/pyfake-fix-quincy
Nizamudeen A [Tue, 11 Oct 2022 10:30:45 +0000 (16:00 +0530)]
Merge pull request #48434 from rhcs-dashboard/pyfake-fix-quincy

quincy: cephadm: run tests as root

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agomgr/prometheus: change pg_repaired_objects name to pool_repaired_objects 48438/head
Pere Diaz Bou [Mon, 10 Oct 2022 10:08:34 +0000 (12:08 +0200)]
mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Fixes: https://tracker.ceph.com/issues/57806
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 114727fd341ab90328ac3a829807bbc39820f901)

3 years agocephadm: pin pyfakefs to 5.0 48434/head
Kefu Chai [Mon, 10 Oct 2022 15:19:27 +0000 (23:19 +0800)]
cephadm: pin pyfakefs to 5.0

so the test is more repeatable.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 52f5c2fed057efa25e1cbea2a2bb4295f77831e4)

3 years agocephadm: fix the indent
Kefu Chai [Mon, 10 Oct 2022 14:43:23 +0000 (22:43 +0800)]
cephadm: fix the indent

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 38dc57ac9a88dafbe73038ea757dfa778c6191a7)

 Conflicts:
src/cephadm/tests/fixtures.py
  - Replace _cephadm with cd

3 years agocephadm: run tests as root
Kefu Chai [Mon, 10 Oct 2022 13:57:57 +0000 (21:57 +0800)]
cephadm: run tests as root

as we will be create/access directories which are only accessible by
root with pyfakefs, and pyfake respects the uid of current effective
user, so if we run the test using non-root user, these tests would fail
after the fix for https://github.com/pytest-dev/pyfakefs/issues/489
is addressed in the pyfakefs we are using.

in this change, we will run the test on behalf of root, so we can
create and access the directories as we did before.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit ed19416067a7ef3b69310d22bf4e3b573e3011f0)

 Conflicts:
src/cephadm/tests/fixtures.py
  - Replace _cephadm with cd

3 years agomgr/dashboard: fix weird data in osd details
Nizamudeen A [Mon, 10 Oct 2022 05:41:18 +0000 (11:11 +0530)]
mgr/dashboard: fix weird data in osd details

The devices section in the OSD Details and Host Details shows more than
one daemon and device path in the column when you view the details of a
single osd details/host details. This is because more than one osd
is created on a device with same `deviceid`. I am not sure if this will
happen in the real environment but its mostly reproducible in
environments with QEMU emulated devices.

Fixes: https://tracker.ceph.com/issues/57803
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 2e2ecde82f58f26e1f83e329b254ef97fa989506)

3 years agodoc/security: improve grammar in CVE-2022-0670.rst 48430/head
Zac Dover [Tue, 11 Oct 2022 04:36:10 +0000 (14:36 +1000)]
doc/security: improve grammar in CVE-2022-0670.rst

This commit accepts the suggestions made by Cole Mitchell in
https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 52971eb9ac65a25e1bb79e7587de5a51900261d3)

3 years agoMerge pull request #48141 from rhcs-dashboard/wip-57581-quincy
Nizamudeen A [Tue, 11 Oct 2022 04:38:02 +0000 (10:08 +0530)]
Merge pull request #48141 from rhcs-dashboard/wip-57581-quincy

quincy: mgr/dashboard: fix Expected to find element: `cd-modal .badge but never found it

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Yuri Weinstein <yweins@redhat.com>
3 years agoMerge pull request #48424 from zdover23/wip-doc-2022-10-11-backport-48423-to-quincy
zdover23 [Tue, 11 Oct 2022 03:54:05 +0000 (13:54 +1000)]
Merge pull request #48424 from zdover23/wip-doc-2022-10-11-backport-48423-to-quincy

quincy: doc/releases: improve grammar in pacific.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/releases: improve grammar in pacific.rst 48424/head
Zac Dover [Mon, 10 Oct 2022 14:15:11 +0000 (00:15 +1000)]
doc/releases: improve grammar in pacific.rst

This commit accepts the grammar suggestions that were made by Cole
Mitchell in https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 560d7590fdf66ef3827203bc7c5725f167a1a7b2)

3 years agoMerge pull request #48402 from zdover23/wip-doc-2022-10-09-backport-48401-to-quincy
zdover23 [Sun, 9 Oct 2022 07:41:56 +0000 (17:41 +1000)]
Merge pull request #48402 from zdover23/wip-doc-2022-10-09-backport-48401-to-quincy

quincy: doc/various: update link to CRUSH pdf

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/various: update link to CRUSH pdf 48402/head
Zac Dover [Sun, 9 Oct 2022 07:09:30 +0000 (17:09 +1000)]
doc/various: update link to CRUSH pdf

This commit updates link to the research paper that announces and
explains the CRUSH algorithm. This link was broken in the migration from
the old Ceph website to ceph.io.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 6877b592a289cb473f16daa79d5112f5b2d8006c)

3 years agoMerge pull request #48164 from kotreshhr/wip-57554-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:11:49 +0000 (10:11 -0700)]
Merge pull request #48164 from kotreshhr/wip-57554-quincy

quincy: qa: ignore disk quota exceeded failure in test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #48113 from NitzanMordhai/wip-57545-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:08:35 +0000 (10:08 -0700)]
Merge pull request #48113 from NitzanMordhai/wip-57545-quincy

quincy: pybind/rados: notify callback reconnect

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #48039 from NitzanMordhai/wip-57496-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:05:40 +0000 (10:05 -0700)]
Merge pull request #48039 from NitzanMordhai/wip-57496-quincy

quincy: osd: remove invalid put on message

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #47983 from sseshasa/wip-57443-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:03:54 +0000 (10:03 -0700)]
Merge pull request #47983 from sseshasa/wip-57443-quincy

quincy: osd: Implement Context based completion for mon cmd to set a config option

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #47933 from rzarzynski/wip-57346-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:03:07 +0000 (10:03 -0700)]
Merge pull request #47933 from rzarzynski/wip-57346-quincy

quincy: common/ceph_context: leak some memory fail to show in valgrind

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
3 years agoMerge pull request #47928 from rzarzynski/wip-56602-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:01:25 +0000 (10:01 -0700)]
Merge pull request #47928 from rzarzynski/wip-56602-quincy

quincy: Monitor: forward report command to leader

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #47926 from rzarzynski/wip-55282-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:00:38 +0000 (10:00 -0700)]
Merge pull request #47926 from rzarzynski/wip-55282-quincy

quincy: osd: add scrub duration for scrubs after recovery

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
3 years agoMerge pull request #47890 from lxbsz/wip-57240
Yuri Weinstein [Thu, 6 Oct 2022 16:58:22 +0000 (09:58 -0700)]
Merge pull request #47890 from lxbsz/wip-57240

quincy: mds/client: fail the request if the peer MDS doesn't support getvxattr op

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #47820 from neesingh-rh/wip-57278-quincy
Yuri Weinstein [Thu, 6 Oct 2022 16:56:16 +0000 (09:56 -0700)]
Merge pull request #47820 from neesingh-rh/wip-57278-quincy

quincy: cephfs-top, mgr/stats: multiple file system support with UI

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #48380 from zdover23/wip-doc-2022-10-06-backport-48379-to-quincy
zdover23 [Thu, 6 Oct 2022 06:00:18 +0000 (16:00 +1000)]
Merge pull request #48380 from zdover23/wip-doc-2022-10-06-backport-48379-to-quincy

quincy: doc/install: clone-source.rst s/master/main

Reviewed-by: Cole Michell <cole.mitchell@gmail.com>
3 years agodoc/install: clone-source.rst s/master/main 48380/head
Zac Dover [Thu, 6 Oct 2022 04:30:07 +0000 (14:30 +1000)]
doc/install: clone-source.rst s/master/main

s/master/main in doc/install/clone-source.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 5c17509b0a3402ca4a3ee574ed7e73949d51c72a)

3 years agoMerge pull request #48370 from zdover23/wip-doc-2022-10-05-backport-44564-to-quincy
zdover23 [Wed, 5 Oct 2022 11:15:43 +0000 (21:15 +1000)]
Merge pull request #48370 from zdover23/wip-doc-2022-10-05-backport-44564-to-quincy

quincy: doc/mgr: name data source in "Man Install & Config"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/mgr: name data source in "Man Install & Config" 48370/head
Zac Dover [Wed, 12 Jan 2022 22:46:20 +0000 (08:46 +1000)]
doc/mgr: name data source in "Man Install & Config"

This PR specifies that the data source must be set to
be "Dashboard1" when you configure Grafana and Prometheus
manually.

This is a fixup of another PR which was created by Dr
Jake Grimmett. This is that PR:

Credit goes to Dr Jake Grimmett of Cambridge.

https://github.com/ceph/ceph/pull/44150/

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 987713da331e941c05d114f1e167c21d1e7896eb)

3 years agoMerge pull request #48365 from zdover23/wip-doc-2022-10-05-backport-48362-to-quincy
zdover23 [Wed, 5 Oct 2022 07:25:54 +0000 (17:25 +1000)]
Merge pull request #48365 from zdover23/wip-doc-2022-10-05-backport-48362-to-quincy

quincy: doc/rados: refine English in crush-map-edits.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/rados: refine English in crush-map-edits.rst 48365/head
Zac Dover [Wed, 14 Sep 2022 05:19:44 +0000 (15:19 +1000)]
doc/rados: refine English in crush-map-edits.rst

This commit makes several refinements to the English in
rados/operations/crush-map-edits.rst, which refinements were suggested
by Cole Mitchell and Anthony D'Atri in the discussion of PR#48085.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit a70b720032876386d7fbebfb649849fa34e9da5f)

3 years agoMerge pull request #48343 from kotreshhr/wip-57747-quincy
zdover23 [Wed, 5 Oct 2022 01:53:01 +0000 (11:53 +1000)]
Merge pull request #48343 from kotreshhr/wip-57747-quincy

quincy: doc: Fix disaster recovery doc

Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #48363 from zdover23/wip-doc-2022-10-05-backport-48085-to-quincy
zdover23 [Wed, 5 Oct 2022 01:39:18 +0000 (11:39 +1000)]
Merge pull request #48363 from zdover23/wip-doc-2022-10-05-backport-48085-to-quincy

quincy: doc/rados: update prompts in crush-map-edits.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/rados: update prompts in crush-map-edits.rst 48363/head
Zac Dover [Wed, 14 Sep 2022 05:19:44 +0000 (15:19 +1000)]
doc/rados: update prompts in crush-map-edits.rst

This PR updates the prompts in crush-map-edits.rst
to make them unselectable.

There remains no good known way to render parts of
a file if the first line of that file begins with a
hash (#). Sphinx italicizes such a first line, which
is not what I want. Two examples of this are present
in the file crush-maps-rst under the section called
"CRUSH Map Bucket Types". I set this down here for
my own records, in case it is helpful in finding a
way to make these sections render as I would prefer.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 7484b7c10a3f762e6649fb304fd0f7a5da5e418f)

3 years agoMerge pull request #48357 from zdover23/wip-doc-2022-10-04-backport-48346-to-quincy-3
zdover23 [Tue, 4 Oct 2022 14:27:13 +0000 (00:27 +1000)]
Merge pull request #48357 from zdover23/wip-doc-2022-10-04-backport-48346-to-quincy-3

quincy: doc/glossary.rst: remove duplicates

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/glossary.rst: remove duplicates 48357/head
Zac Dover [Mon, 3 Oct 2022 12:51:35 +0000 (22:51 +1000)]
doc/glossary.rst: remove duplicates

This commit removes similar but distinct entries for the following:
   * CephFS
   * Ceph Client

Removal of a glossary term that is referred to in the body of the
documentation suite requires the alteration of the text string
that refers to the glossary term. Alterations of this kind have
been made to doc/architecture.rst and doc/rados/api/index.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 0692b223540143cdb4a60b54595a7069284b5481)

3 years agodoc: Fix disaster recovery doc 48343/head
Kotresh HR [Thu, 29 Sep 2022 05:11:15 +0000 (10:41 +0530)]
doc: Fix disaster recovery doc

Fixes: https://tracker.ceph.com/issues/57734
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit b6898efcb7268ff90a840f2f46532828c7dd5231)

3 years agomgr/dashboard: Fix broken Fedora image URL 48340/head
Zack Cerza [Thu, 29 Sep 2022 19:44:46 +0000 (13:44 -0600)]
mgr/dashboard: Fix broken Fedora image URL

This mirror apparently stopped working, breaking jobs that use this
script.

Signed-off-by: Zack Cerza <zack@redhat.com>
(cherry picked from commit 3f32ab0fb3a54174a8a57681243cd944056c6ffb)
Signed-off-by: Nizamudeen A <nia@redhat.com>
 Conflicts:
src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh
    - Change the url to point to fedora 34 image

3 years agoMerge pull request #48338 from zdover23/wip-doc-2022-10-02-backport-48333-to-quincy
zdover23 [Mon, 3 Oct 2022 03:58:02 +0000 (13:58 +1000)]
Merge pull request #48338 from zdover23/wip-doc-2022-10-02-backport-48333-to-quincy

quincy: doc/glossary.rst: alphabetize glossary terms

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/glossary.rst: alphabetize glossary terms 48338/head
Zac Dover [Sun, 2 Oct 2022 10:48:36 +0000 (20:48 +1000)]
doc/glossary.rst: alphabetize glossary terms

This commit (finally) alphabetizes the terms in the glossary.
This is not a grammar-correcting or usage-correcting commit.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #48334 from zdover23/wip-doc-2022-10-02-backport-48332-to-quincy
zdover23 [Sun, 2 Oct 2022 23:42:06 +0000 (09:42 +1000)]
Merge pull request #48334 from zdover23/wip-doc-2022-10-02-backport-48332-to-quincy

quincy: doc/rados: fix prompts in erasure-code.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/rados: fix prompts in erasure-code.rst 48334/head
Zac Dover [Sun, 2 Oct 2022 04:55:46 +0000 (14:55 +1000)]
doc/rados: fix prompts in erasure-code.rst

This commit adds unselectable prompts to doc/rados/
erasure-code.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #48323 from zdover23/wip-doc-2022-10-01-backport-48322-to-quincy
zdover23 [Sat, 1 Oct 2022 07:02:03 +0000 (17:02 +1000)]
Merge pull request #48323 from zdover23/wip-doc-2022-10-01-backport-48322-to-quincy

quincy: doc/rados: rewrite EC intro

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/rados: rewrite EC intro 48323/head
Zac Dover [Thu, 1 Sep 2022 19:08:00 +0000 (05:08 +1000)]
doc/rados: rewrite EC intro

This PR rewrites the front matter in the "Erasure Code"
section of the RADOS documentation. Previously, the information
in this section was syntactically confused. I have also fleshed
out the distinction between erasure coding and replication.

Co-Author: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #48271 from rhcs-dashboard/wip-57680-quincy
Nizamudeen A [Fri, 30 Sep 2022 14:35:16 +0000 (20:05 +0530)]
Merge pull request #48271 from rhcs-dashboard/wip-57680-quincy

quincy: mgr/dashboard: Add text to empty life expectancy column

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: torchiaf <NOT@FOUND>
3 years agoMerge pull request #48297 from zmc/python36-prettytable-quincy
Zack Cerza [Thu, 29 Sep 2022 19:07:28 +0000 (13:07 -0600)]
Merge pull request #48297 from zmc/python36-prettytable-quincy

3 years agomgr: Fix prettytable pinning to restore python3.6 48297/head
Zack Cerza [Tue, 20 Sep 2022 23:25:28 +0000 (17:25 -0600)]
mgr: Fix prettytable pinning to restore python3.6

prettytable 3.3.0 requires python3.7; we still support 3.6, so change
the pinning to simply keep us under 3.4.0

Signed-off-by: Zack Cerza <zack@redhat.com>
(cherry picked from commit c6a89cc97777bd63123420cd020033534961bfde)

3 years agoMerge pull request #48283 from ljflores/wip-57700-fix-quincy
Yuri Weinstein [Wed, 28 Sep 2022 22:34:25 +0000 (15:34 -0700)]
Merge pull request #48283 from ljflores/wip-57700-fix-quincy

quincy: mgr/telemetry: handle daemons with complex ids

3 years agomgr/telemetry: handle daemons with complex ids 48283/head
Laura Flores [Wed, 28 Sep 2022 17:43:40 +0000 (17:43 +0000)]
mgr/telemetry: handle daemons with complex ids

Treating daemons as `<daemon_type>.x` caused a crash
in the Telemetry module since the current method does not cover a case
where a daemon id is more complex, i.e. `<daemon_type>.x.y`.

When we parse the daemon type and daemon id, we should
split it into a maximum of two pieces rather than splitting
it by every `.` character. Specifying `1` in the Python
.split() function will limit the split to a maximum of two items.

Fixes: https://tracker.ceph.com/issues/57700
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 97833a6a81fed7f868e1d544816cfbdf254fdb43)

3 years agoMerge pull request #48055 from adk3798/quincy-staggered-version-pacific
Adam King [Tue, 27 Sep 2022 17:18:42 +0000 (13:18 -0400)]
Merge pull request #48055 from adk3798/quincy-staggered-version-pacific

quincy: doc/cephadm: correct version staggered upgrade got in pacific

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 years agoMerge pull request #48094 from adk3798/quincy-tp-add-rm-settings-docs
Adam King [Tue, 27 Sep 2022 17:17:44 +0000 (13:17 -0400)]
Merge pull request #48094 from adk3798/quincy-tp-add-rm-settings-docs

quincy: doc/cephadm: fix tuned-profile add/rm-setting syntax example

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 years agoMerge pull request #48068 from adk3798/quincy-docs-eca-mounts
Adam King [Tue, 27 Sep 2022 17:16:56 +0000 (13:16 -0400)]
Merge pull request #48068 from adk3798/quincy-docs-eca-mounts

quincy: doc/cephadm: document recommended syntax for mounting files with ECA

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 years agoMerge pull request #48204 from rhcs-dashboard/wip-57625-quincy
Pere Diaz Bou [Tue, 27 Sep 2022 10:25:05 +0000 (12:25 +0200)]
Merge pull request #48204 from rhcs-dashboard/wip-57625-quincy

quincy: mgr/prometheus: expose repaired pgs metrics

3 years agomgr/dashboard: Add text to empty life expectancy column 48271/head
Francesco Torchia [Tue, 30 Aug 2022 14:46:03 +0000 (16:46 +0200)]
mgr/dashboard: Add text to empty life expectancy column

- Add life_expectancy_enabled field to /api/osd/{svc_id}/devices
- Add new value 'n/a' for 'Life Expectancy' column

Fixes: https://tracker.ceph.com/issues/43116
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit 811bba7e083919cf3b21ed01ac29a107b5bd006d)

3 years agoMerge pull request #48237 from zdover23/wip-doc-2022-09-12-backport-48235-to-quincy
zdover23 [Sun, 25 Sep 2022 20:38:55 +0000 (06:38 +1000)]
Merge pull request #48237 from zdover23/wip-doc-2022-09-12-backport-48235-to-quincy

quincy: doc/dev: improve presentation of note (git remote)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/dev: improve presentation of note (git remote) 48237/head
Zac Dover [Sun, 25 Sep 2022 03:41:35 +0000 (13:41 +1000)]
doc/dev: improve presentation of note (git remote)

This commit corrects the formatting of a note that previously
did not make console output and commands as clear as this commit
makes them.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #48225 from rhcs-dashboard/wip-57669-quincy
Avan [Sat, 24 Sep 2022 13:42:33 +0000 (19:12 +0530)]
Merge pull request #48225 from rhcs-dashboard/wip-57669-quincy

quincy: exporter: don't skip loop if pid path is empty

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agorgw: fix bug where variable referenced after data moved out 48228/head
J. Eric Ivancich [Thu, 1 Sep 2022 15:06:44 +0000 (11:06 -0400)]
rgw: fix bug where variable referenced after data moved out

Addresses RGWGetObj_ObjStore_S3::override_range_hdr using a variable
for logging after the data had been moved out. This was caught by
coverity.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 6038511c70d0ed4f5eb75194c1bc071f10653136)

3 years agoexporter: don't skip loop if pid path is empty 48225/head
Avan Thakkar [Mon, 19 Sep 2022 10:30:20 +0000 (16:00 +0530)]
exporter: don't skip loop if pid path is empty

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Fixes issue when pid file config comes empty from config dump which prevents to add metrics. Also get process metrics only if
pid_path isn't empty.

(cherry picked from commit c817d7d2db4387538f2cb2b1fab3c50276044910)

3 years agomgr/dashboard: add option to resolve ip addr 48219/head
Tatjana Dehler [Mon, 25 Jul 2022 16:04:58 +0000 (18:04 +0200)]
mgr/dashboard: add option to resolve ip addr

Add the option `redirect_resolve_ip_addr` to the dashboard module.
If the option is set to `True`, try to resolve the IP address before
redirecting from the passive to the active mgr instance.
If the option is set to `False`, follow the already known behavior.

Fixes: https://tracker.ceph.com/issues/56699
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 2e15f0f0d2df55bf0c4bc1673a3b7a4b3862d7e2)

3 years agoMerge pull request #48115 from rhcs-dashboard/wip-57514-quincy
Pedro Gonzalez Gomez [Fri, 23 Sep 2022 06:41:01 +0000 (08:41 +0200)]
Merge pull request #48115 from rhcs-dashboard/wip-57514-quincy

quincy: mgr/dashboard: osd form preselect db/wal device filters

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
3 years agoMerge pull request #48065 from aaSharma14/wip-57512-quincy
Nizamudeen A [Fri, 23 Sep 2022 05:31:14 +0000 (11:01 +0530)]
Merge pull request #48065 from aaSharma14/wip-57512-quincy

quincy: mgr/dashboard: Add a Silence button shortcut to alert notifications

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #48177 from torchiaf/wip-57583-quincy
Nizamudeen A [Fri, 23 Sep 2022 05:28:37 +0000 (10:58 +0530)]
Merge pull request #48177 from torchiaf/wip-57583-quincy

quincy: mgr/dashboard: Add details to the modal which displays the `safe-to-d…

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #48206 from rhcs-dashboard/wip-57633-quincy
Avan [Thu, 22 Sep 2022 17:41:36 +0000 (23:11 +0530)]
Merge pull request #48206 from rhcs-dashboard/wip-57633-quincy

quincy: exporter: avoid stoi for empty pid_str

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #48199 from adk3798/wip-57601-quincy
Adam King [Thu, 22 Sep 2022 13:56:20 +0000 (09:56 -0400)]
Merge pull request #48199 from adk3798/wip-57601-quincy

quincy: mgr/rook: fix error when trying to get the list of nfs services

Reviewed-by: Travis Nielsen <tnielsen@redhat.com>
3 years agoMerge pull request #48201 from guits/bkp-48200-quincy
Guillaume Abrioux [Thu, 22 Sep 2022 13:55:04 +0000 (15:55 +0200)]
Merge pull request #48201 from guits/bkp-48200-quincy

quincy: ceph-volume: fix regression in activate

3 years agoexporter: avoid stoi for empty pid_str 48206/head
Avan Thakkar [Tue, 20 Sep 2022 20:30:31 +0000 (02:00 +0530)]
exporter: avoid stoi for empty pid_str

Fixes: https://tracker.ceph.com/issues/57619
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit cff3cf1d31342be759cdd848cd074a247b56b238)

3 years agoMerge pull request #48188 from rhcs-dashboard/wip-57223-quincy
Pedro Gonzalez Gomez [Thu, 22 Sep 2022 12:01:59 +0000 (14:01 +0200)]
Merge pull request #48188 from rhcs-dashboard/wip-57223-quincy

quincy: mgr/dashboard: fix rgw connect when using ssl

Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>