.github/pr-triage: switch from old to new project

The old (classic) Dashboard project (https://github.com/ceph/ceph/projects/6) has been migrated to a new-style one (https://github.com/orgs/ceph/projects/2/views/1).

This also requires updating the GH Action that automatically assigned `dashboard`-labeled PRs to the Dashboard project.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>

Merge pull request #48241 from ajarr/fix-57210

 src/mds: increment directory inode's change attr by one

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #48425 from phlogistonjohn/jjm-shell-fixups

build: minor build script cleanups

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48501 from zdover23/wip-doc-2022-10-17-radosgw-notifications

doc/radosgw: refine notifications.rst - top part

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: refine notifications.rst - top part

This commit refines the English in the first part of the
notifications.rst page (the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>

install-deps: switch to C.UTF-8 locale

The en_US.UTF-8 locale is not always going to present on all systems.
Specifically, setting en_US.UTF-8 causes numerous warnings when running
this script on a CentOS Stream 8 container. Rather than install
additional packages to suppress the warning, use the C.UTF-8 locale.

Additionally, try to update the comment explaining the line to something
based on the commit history rather than the confusing term "vulnerable".

Signed-off-by: John Mulligan <jmulligan@redhat.com>

script/run-make: convert a tab to spaces

There was a single line using a hard tab to indent, convert the tab
and reformat the spacing of the line near it.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

install-deps: for consistency, reformat tabs to spaces

The majority of the install-deps.sh file was already using spaces to
indent, convert the remaining hard tabs to 8 spaces.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

install-deps: remove emacs modeline from script

The majority of the lines in this shell script uses spaces to indent,
but I *think* this modeline tells emacs to indent with tabs. In a very
near future change I'm going to make all indents use spaces. So we first
remove the emacs modeline that tells it to use the opposite.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #48086 from vshankar/wip-57084

client: use parent directory POSIX ACLs for snapshot dir

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #48497 from liu-chunmei/fix-variable-usage-after-move

crimson/osd: not use a moved variable

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48498 from zdover23/wip-doc-2022-10-16-radosgw-notifications-wording

doc/radosgw: update notifications.rst - grammar

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: update notifications.rst - grammar

This commit rewrites a sentence, as requested by
C. Mitchell here:
https://github.com/ceph/ceph/pull/48493/files#r996003812

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/osd: not use a moved variable

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

cephfs: add additional logging to track change_attr of inodes

Signed-off-by: Ramana Raja <rraja@redhat.com>

src/mds: increment directory inode's change attr by one

... whenever the mtime or ctime of the directory inode is modified.

In CephFS subvolume clones exported using NFS-Ganesha, newly created
files using `touch` were not being listed. It was identified that the
create request sent to the Ceph MDS via NFS-Ganesha's libcephfs client
modified the mtime and ctime of the parent directory, but did not modify
the change_attr of the parent directory. Since the NFS client
didn't see a modification of the change attribute in the reply, it
didn't invalidate its readdir cache. The subsequent directory `ls` was
satisfied from the NFS client's stale readdir cache.

Whenever parent directory inode's  mtime was modified in
MDCache::predirty_journal_parents(), the parent inode's change_attr
was set to its dirstat->change_attr. The parent inode's
dirstat->change_attr doesn't track changes to parent's *ctime only*
changes such as setattr, setvxattr, etc. on the parent
directory. See commit 0d441dcd6af553d11d6be6df56d577c5659904a0 for more
details. This caused the directory inode's change_attr to not be updated
when an operation to change only its ctime was followed by an operation
to change its mtime and ctime.

Fix this by making changes to MDCache::predirty_journal_parents() and
CInode::finish_scatter_gather_update() to increment the directory
inode's change_attr by one instead of setting it to its
dirstat->change_attr.

Fixes: https://tracker.ceph.com/issues/57210
Signed-off-by: Ramana Raja <rraja@redhat.com>

test/libcephfs: enhance directory's change_attr testing

Alternate operations that only change directory's ctime
(setattr/setxattr/removexattr on directory) with those that change
directory's mtime and ctime (create/rename/remove a file within
directory). Check that directory's change_attr is updated everytime
ctime changes.

Signed-off-by: Ramana Raja <rraja@redhat.com>

Merge pull request #48227 from phlogistonjohn/jjm-cephadm-test-nfsg

cephadm: add test coverage for NFSGanesha, HAproxy, & Keepalived classes

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #48493 from zdover23/wip-doc-2022-10-15-radosgw-notifications-cleanup

doc/radosgw: improve grammar - notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: improve grammar - notifications.rst

This commit makes the changes suggested by C. Mitchell in
https://github.com/ceph/ceph/pull/48486.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48422 from aravind-wdc/refactor

crimson/zns: refactor zone operations

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48486 from zdover23/wip-doc-2022-10-14-radosgw-push_endpoint

doc/radosgw: add push_endpoint for rabbitmq

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

crimson/zns: refactor zone operation

Moved all zone operations into one routine.

Signed-off-by: Aravind Ramesh <Aravind.Ramesh@wdc.com>

doc/radosgw: add push_endpoint for rabbitmq

This commit directs users of rabbitmq to use "push_endpoint"
(with an underscore) instead of "push-endpoint" (with a hy-
phen). This commit adds a note that contains such a direct-
ive. It does not alter the examples already present in the
text.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48475 from rzarzynski/wip-crimson-resolve_oid-clone_snaps-fix-search

crimson/osd: resolve_oid() looks in clone_snaps by requested snap ID

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48405 from athanatos/sjust/wip-57759

crimson: tmap support, list_snaps support, fixes for zero and cmpext

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

crimson/osd: resolve_oid() looks in clone_snaps by requested snap ID

Before the patch the method was looking for `lower_bound(oid.snap)`
from `SnapSet::clones` which leads to reading from head instead of
returning the `ENOENT` expected in `TestLibRBD.TestIOToSnapshot`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48437 from rosinL/fix-vstart

src/vstart.sh: correct top_cpu's value

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48457 from cyx1231st/wip-fix-msgr-test

test/crimson/test_messenger: add pause before marking down a connection

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #48463 from zdover23/wip-doc-2022-10-14-dev-dev-guide-basic-workflow-submodule-update-2

doc/dev: add submodule-update link to dev guide

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/dev: add submodule-update link to dev guide

This commit links to the procedure in install/clone-source.rst that
explains how to update submodules.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48460 from zdover23/wip-doc-2022-10-14-install-clone-source-submodules

doc/install: improve updating submodules procedure

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

crimson/osd: CEPH_OSD_OP_ZERO should become truncate if past end of object

librbd image diff seems to rely on this behavior to modify oi.size for
LIST_SNAPS.

Fixes: https://tracker.ceph.com/issues/57791
Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/osd: add CEPH_OSD_OP_LIST_SNAPS

Fixes: https://tracker.ceph.com/issues/57789
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #47853 from WOnder93/selinux-io_uring

selinux: prepare for anon inode controls enablement

doc/install: improve updating submodules procedure

This commit beefs up the "Updating Submodules" procedure,
which (prior to this commit) was quite brief.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/net: print connection memory address as the identity

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

test/crimson/test_messenger: add pause before marking down a connection

To make sure the ACK messages are consumed, otherwise there can be
unexpected connect attempts to break the test.

Fixes: https://tracker.ceph.com/issues/57693
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #48377 from ktdreyer/win-deps-clone

win32: speed up and simplify deps cloning

Merge pull request #48406 from athanatos/sjust/wip-57798

qa/suites/crimson-rados: add CRIMSON_COMPAT to workunit env

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #48446 from zdover23/wip-doc-2022-10-12-glossary-ceph-monitor

doc/glossary: add "ceph monitor" entry

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/glossary: add "ceph monitor" entry

This commit adds information to the "ceph monitor" entry in
glossary.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48196 from neesingh-rh/wip-human-readable-volume-info

mgr/volumes: Add human-readable flag to volume info command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #48367 from stefan-chivu/namespace-optarg-fix

rbd: device map/unmap --namespace handling fixes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #45395 from tobias-urdin/rgw-keystone-service-token

rgw/auth: Add service token support for Keystone auth

test: add test for checking snapdir attrs on parent inode updation

Signed-off-by: Venky Shankar <vshankar@redhat.com>

test: add test for checking snapdir acls

Signed-off-by: Venky Shankar <vshankar@redhat.com>

test: cleanup files/dirs for some tests

Otherwise subsequent tests that use the same file/dir name may fail
on ceph_mkdir() expecting success.

Signed-off-by: Venky Shankar <vshankar@redhat.com>

client: refresh snapdir attrs on parent inode updation

Snapdir attrs (ui, gid, etc..) are set its respective parent attributes,
however, those are never updated when the attributes of the parent inode
get updated. There seems to be no reason to no to update snapdir attributes.

This change also updates POSIX ACLs.

Fixes: http://tracker.ceph.com/issues/57084
Signed-off-by: Venky Shankar <vshankar@redhat.com>

client: use parent directory POSIX ACLs for snaphot dir

Fixes: http://tracker.ceph.com/issues/57084
Signed-off-by: Venky Shankar <vshankar@redhat.com>

src/vstart.sh: correct top_cpu's value

Signed-off-by: luo rixin <luorixin@huawei.com>

Merge pull request #48415 from rhcs-dashboard/repaired-metric-name

mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #47495 from rhcs-dashboard/rgw-s3-encryption

mgr/dashboard: add server side encryption to rgw/s3

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46331 from lxbsz/wip-55332

mds: wait unlink to finish to avoid conflict when creating same dentries

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>

mgr/dashboard: add server side encryption to rgw/s3

Fixes:https://tracker.ceph.com/issues/57826
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #48350 from athanatos/sjust/wip-57739

crimson/.../replicated_request,logmissing_request: retain reference to req

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Radoslaw Zarzynski <rzarzynski@redhat.com>

Merge pull request #48308 from cyx1231st/wip-seastore-offset

crimson/os/seastore: introduce (64-8)-bit signed device_off_t and 32-bit signed segment_off_t

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>

qa/suites/crimson-rados: add CRIMSON_COMPAT to workunit env

Fixes: https://tracker.ceph.com/issues/57798
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #48349 from rzarzynski/wip-crimson-cltreq-errreply-debug

crimson/osd: introduce debug to ClientRequest::reply_op_error()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>

Merge pull request #47754 from batrick/i57248

qa: cleanup volumes on unwind

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

PendingReleaseNotes: add "rbd device unmap --namespace" note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa/workunits/rbd-nbd: also test map/unmap with --namespace option

The entire script is using specs, let's cover non-spec syntax as well.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

win32: speed up and simplify deps cloning

Use --depth 1 for all the dependencies we clone to speed up the process.

Use the --branch argument for cloning all dependencies. This simplifies
the process and makes it easier to use other copies in an offline
environment where github.com is inaccessible.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #48423 from zdover23/wip-doc-2022-10-11-releases-pacific-grammar

doc/releases: improve grammar in pacific.rst

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48396 from rhcs-dashboard/fix-57792-main

mgr/dashboard: fix broken login links

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #48337 from batrick/first-python

tools/cephfs: convert first-damage.sh to python

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #46772 from cbodley/wip-rgw-doc-bucket-index

doc/dev/radosgw: start describing the bucket index

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/releases: improve grammar in pacific.rst

This commit accepts the grammar suggestions that were made by Cole
Mitchell in https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Fixes: https://tracker.ceph.com/issues/57806
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #48331 from tchaikov/crimson-stop

crimson/osd: shutdown on osdmaps' demand

Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/osd/pg_backend: remove incorrect length limitation on CMPEXT

We specifically send back errors < -MAX_ERRNO to indicate offset.

Fixes: https://tracker.ceph.com/issues/57773
Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/osd: add tmap support

rbdv1 headers use tmap, it's somewhat easier to add support to crimson
than to modify those tests to avoid rbdv1 on crimson.

Fixes: https://tracker.ceph.com/issues/57759
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #48238 from sisco0/fix-rgw-amqp-switch-compiler-warning-2

rgw: fix rabbitmq version checking for AMQP_STATUS_SSL_SET_ENGINE_FAILED

mgr/dashboard: fix broken login links

Fixes: https://tracker.ceph.com/issues/57792
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

rbd: Removed device_name argument from wnbd unmap

Right now, rbd-wnbd doesn't actually use disk path
identifiers such as "/dev/*" or "\\.\PhysicalDrive*".

So instead of accepting two arguments that are basically
handled more or less the same, we're dropping the device_name
argument and sticking to the image spec.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>

rbd: Moved get_image_or_snap_spec and parse_options to utils

At the moment, there are multiple copies of "get_image_or_snap_spec".

For this reason, we're moving it to Utils.cc so that all backends may
re-use it, also benefiting from the recent pool related fix.

We are also renaming parse_options to append_options_as_args and
changing its type to void

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>

rbd: Added namespace optarg for rbd device unmap

When executing rbd device unmap, an explicit namespace optarg wasn't available

Fixes: https://tracker.ceph.com/issues/57765
Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>

Merge pull request #48275 from liu-chunmei/rados-api-test

crimson/qa: add rados_api_tests.yaml for seastore

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48162 from Matan-B/wip-matanb-c-rados-test

qa/suites/crimson-rados/thrash: Adding workloads / Simplifying thrashers

Reviewed-by: Samuel Just <sjust@redhat.com>

qa/workunits/fs/damage: update first-damage test for python

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

tools/cephfs: convert first-damage.sh to python

To have only one RADOS instance and improve performance/reliability.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #46925 from rkachach/fix_issue_44461

mgr/cephadm: add a simple mechanism to check grafana cert/key

Reviewed-by: Adam King <adking@redhat.com>

cephadm: add test coverage for Keepalived class

Fixes: https://tracker.ceph.com/issues/57621
Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: add test coverage for HAproxy class

Fixes: https://tracker.ceph.com/issues/57621
Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: add unit test coverage for cephadm NFSGanesha class

Fixes: https://tracker.ceph.com/issues/57621
Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #44564 from zdover23/wip-doc-2022-01-13-44150-cleanup-grafana-data-source-name

doc/mgr: name data source in "Man Install & Config"

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #48218 from mchangir/qa-test_scrub_pause_and_resume_with_abort-wait-for-scrub-to-finish

qa: wait for scrub to finish

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

crimson/osd: introduce debug to ClientRequest::reply_op_error()

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48041 from cbodley/wip-rgw-notify-shutdown

rgw: rados service shuts down rados client on shutdown()

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #48152 from Vfrost98/GHC22OSD_Ceph

mgr/telemetry: fixed log exceptions as "exception" instead of "error"

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>

RGWServices_Def::shutdown() shuts down the rest of the services too

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: shut down RGWDataChangesLog before other services

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: rados service shuts down rados client on shutdown()

if we leave the rados client running, it will keep delivering
AioCompletions while we're shutting other things down

this resolves a valgrind use-after-free where rgw::notify::Manager
gets completions after its destruction

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48155 from liangmingyuanneo/wip-rgw-aync-refcount

rgw: async refcount operate in copy_obj

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #47186 from cfsnyder/wip-cfsnyder-56645

rgw: log deletion status of individual objects in multi object delete request

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

rgw: async refcount operate in copy_obj

Signed-off-by: Mingyuan Liang <liangmingyuan@baidu.com>

crimson/osd/stop_signal: s/signaled/on_signal/

to better reflect that it is a callback gets called when receiving a
signal.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

crimson/.../replicated_request,logmissing_request: retain reference to req

Otherwise, operator<< and dump_detail would need to accessing req after
the call to handle_rep_op.

Fixes: https://tracker.ceph.com/issues/57739
Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/osd: signal should_stop in OSD::shutdown()

so osd is able to shut itself down per monitor's request.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

crimson/osd: drop redundant code

this change is a cleanup.

we already update `superblock` with the latest `boost_epoch` and
osdmap's epoch in `OSD::handle_osd_map()`, and `committed_osd_maps()` is
called at end of this function. `shutdown()` is called when we marked
down and stop by the monitor in `committed_osd_maps()`. so these
assignment statements are noops. instead, we should stop the whole osd
service. let's leave it for another commit.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>