]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agodoc/cephadm: clean colons in host-management.rst 48603/head
Zac Dover [Sun, 23 Oct 2022 21:14:32 +0000 (07:14 +1000)]
doc/cephadm: clean colons in host-management.rst

Two lines in host-management.rst ended with both colons and
full stops (periods), causing a kind of punctuational turf
war. This commit removes the full stops.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 495182b84e86babdba38c184d489f118e8881e2c)

3 years agoMerge pull request #48594 from zdover23/wip-doc-2022-10-23-backport-48593-to-quincy
zdover23 [Sun, 23 Oct 2022 02:29:23 +0000 (12:29 +1000)]
Merge pull request #48594 from zdover23/wip-doc-2022-10-23-backport-48593-to-quincy

quincy: doc/cephadm: update install.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/cephadm: update install.rst 48594/head
Zac Dover [Sun, 23 Oct 2022 01:09:18 +0000 (11:09 +1000)]
doc/cephadm: update install.rst

This commit addresses https://github.com/ceph/ceph/pull/43250,
which has remained unmerged for thirteen months. The issues
raised in that PR are addressed here.

This commit contributes to the simplification of the procedure
that explains how to install cephadm. More remains to be done
on this page, but the old PR had to be dealt with first.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c8f01d3a32b889a0f3b68f619bfed36f6579c28b)

3 years agoMerge pull request #48268 from vshankar/tr-57193
Milind Changire [Sat, 22 Oct 2022 02:39:28 +0000 (08:09 +0530)]
Merge pull request #48268 from vshankar/tr-57193

quincy: fsmap: switch to using iterator based loop

Reviewed-by: Milind Changire <mchangir@redhat.com>
3 years agoMerge pull request #48589 from zdover23/wip-doc-2022-10-22-backport-48587-to-quincy
zdover23 [Fri, 21 Oct 2022 18:21:49 +0000 (04:21 +1000)]
Merge pull request #48589 from zdover23/wip-doc-2022-10-22-backport-48587-to-quincy

quincy: doc/cephadm: add prompts to host-management.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/cephadm: add prompts to host-management.rst 48589/head
Zac Dover [Fri, 21 Oct 2022 16:42:33 +0000 (02:42 +1000)]
doc/cephadm: add prompts to host-management.rst

This PR adds unselectable prompts to host-management.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 0ff9e4b9041039160b2d77ce48e29a6fedfaa469)

3 years agoMerge pull request #48327 from kotreshhr/wip-57719-quincy
Yuri Weinstein [Fri, 21 Oct 2022 16:52:04 +0000 (09:52 -0700)]
Merge pull request #48327 from kotreshhr/wip-57719-quincy

quincy: qa: Fix test_subvolume_group_ls_filter_internal_directories

Reviewed-by: Milind Changire <mchangir@redhat.com>
3 years agoMerge pull request #48321 from kamoltat/wip-ksirivad-backport-quincy-44993
Yuri Weinstein [Fri, 21 Oct 2022 16:51:10 +0000 (09:51 -0700)]
Merge pull request #48321 from kamoltat/wip-ksirivad-backport-quincy-44993

quincy: mon/Elector: Added sanity check when pinging a peer monitor

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #48458 from k0ste/wip-57843-quincy
Yuri Weinstein [Fri, 21 Oct 2022 15:29:47 +0000 (08:29 -0700)]
Merge pull request #48458 from k0ste/wip-57843-quincy

quincy: rbd: device map/unmap --namespace handling fixes

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
3 years agoMerge pull request #48058 from tserong/wip-57505-quincy
Yuri Weinstein [Fri, 21 Oct 2022 15:25:45 +0000 (08:25 -0700)]
Merge pull request #48058 from tserong/wip-57505-quincy

quincy: ceph.spec.in: Use gcc11-c++ on openSUSE Leap 15.x

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
3 years agoMerge pull request #48579 from zdover23/wip-doc-2022-10-21-backport-48577-to-quincy
zdover23 [Fri, 21 Oct 2022 04:01:49 +0000 (14:01 +1000)]
Merge pull request #48579 from zdover23/wip-doc-2022-10-21-backport-48577-to-quincy

quincy: doc/radosgw: refine "notifications" and "events"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: refine "notifications" and "events" 48579/head
Zac Dover [Fri, 21 Oct 2022 03:07:16 +0000 (13:07 +1000)]
doc/radosgw: refine "notifications" and "events"

This commit refines the English in the "Notifications"
and "Events" sections of the notifications.rst page
(the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit b1e589343df4a113d773c4091705e74cd489a1e7)

3 years agoMerge pull request #48573 from zdover23/wip-doc-2022-10-21-backport-48572-to-quincy
zdover23 [Thu, 20 Oct 2022 20:06:43 +0000 (06:06 +1000)]
Merge pull request #48573 from zdover23/wip-doc-2022-10-21-backport-48572-to-quincy

quincy: doc/cephadm: refine "os tuning" in h. management

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/cephadm: refine "os tuning" in h. management 48573/head
Zac Dover [Thu, 20 Oct 2022 18:43:24 +0000 (04:43 +1000)]
doc/cephadm: refine "os tuning" in h. management

This commit refines the English in the "OS Tuning Profiles" section of
the "Host Management" page of the cephadm documentation. This commit is
made separately from but in anticipation of a forthcoming commit that
corrects technical (non-grammatical) errors.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 17b50dc1bfeb67132e793f9d8509354a4e29c5b1)

3 years agoMerge pull request #48570 from zdover23/wip-doc-2022-10-21-quincy-remove-deduplication
zdover23 [Thu, 20 Oct 2022 17:36:24 +0000 (03:36 +1000)]
Merge pull request #48570 from zdover23/wip-doc-2022-10-21-quincy-remove-deduplication

quincy: doc/dev: remove deduplication.rst from quincy

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/dev: remove deduplication.rst from quincy 48570/head
Zac Dover [Thu, 20 Oct 2022 16:52:30 +0000 (02:52 +1000)]
doc/dev: remove deduplication.rst from quincy

This PR undoes the backporting of https://github.com/ceph/ceph/pull/46089
to the Quincy branch, which backporting was done in
https://github.com/ceph/ceph/pull/48567. Deduplication does not exist
in the quincy branch, so I shouldn't have backported it.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #48567 from zdover23/wip-doc-2022-10-21-backport-46089-to-quincy
zdover23 [Thu, 20 Oct 2022 16:34:56 +0000 (02:34 +1000)]
Merge pull request #48567 from zdover23/wip-doc-2022-10-21-backport-46089-to-quincy

quincy: doc/dev: add explanation of how to use deduplication

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/dev: add explanation of how to use deduplication 48567/head
myoungwon oh [Fri, 29 Apr 2022 06:32:08 +0000 (15:32 +0900)]
doc/dev: add explanation of how to use deduplication

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
(cherry picked from commit 72c695780c8361f81b8135899d9060811873dcb4)

3 years agoMerge pull request #48560 from zdover23/wip-doc-2022-10-19-backport-48556-to-quincy
zdover23 [Wed, 19 Oct 2022 23:15:00 +0000 (09:15 +1000)]
Merge pull request #48560 from zdover23/wip-doc-2022-10-19-backport-48556-to-quincy

quincy: doc/radosgw: refine "bucket notifications"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: refine "bucket notifications" 48560/head
Zac Dover [Wed, 19 Oct 2022 18:35:14 +0000 (04:35 +1000)]
doc/radosgw: refine "bucket notifications"

This commit refines the English in the "Bucket Notifications REST API"
section of the notifications.rst page (the "Bucket Notifications" page).

Co-author: Cole Mitchell <cole.mitchell@gmail.com>

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit a69dd10ddbbf952cc208f35c0ea04d644b582794)

3 years agoMerge pull request #48519 from ceph/quincy-release
Laura Flores [Wed, 19 Oct 2022 15:11:05 +0000 (10:11 -0500)]
Merge pull request #48519 from ceph/quincy-release

v17.2.5

3 years agoMerge pull request #48440 from aaSharma14/wip-57841-quincy
Nizamudeen A [Wed, 19 Oct 2022 07:42:25 +0000 (13:12 +0530)]
Merge pull request #48440 from aaSharma14/wip-57841-quincy

 quincy: mgr/dashboard: Unable to change rgw subuser permission

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #48441 from aaSharma14/wip-57835-quincy
Nizamudeen A [Wed, 19 Oct 2022 07:32:47 +0000 (13:02 +0530)]
Merge pull request #48441 from aaSharma14/wip-57835-quincy

quincy: mgr/dashboard: add server side encryption to rgw/s3

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #48535 from zdover23/wip-doc-2022-10-19-backport-48512-to-quincy
zdover23 [Tue, 18 Oct 2022 18:12:37 +0000 (04:12 +1000)]
Merge pull request #48535 from zdover23/wip-doc-2022-10-19-backport-48512-to-quincy

quincy: doc/radowsgw: add prompts to notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/radowsgw: add prompts to notifications.rst 48535/head
Zac Dover [Mon, 17 Oct 2022 13:46:39 +0000 (23:46 +1000)]
doc/radowsgw: add prompts to notifications.rst

This PR adds unselectable prompts to doc/radosgw/notifications.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 075ec4cd1435ab5f4c16bbc841aee60419724914)

3 years agoMerge pull request #48529 from zdover23/wip-doc-2022-10-19-backport-48511-to-quincy
zdover23 [Tue, 18 Oct 2022 15:18:40 +0000 (01:18 +1000)]
Merge pull request #48529 from zdover23/wip-doc-2022-10-19-backport-48511-to-quincy

quincy: doc/radosgw: refine "notification reliability"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/radosgw: refine "notification reliability" 48529/head
Zac Dover [Mon, 17 Oct 2022 14:09:34 +0000 (00:09 +1000)]
doc/radosgw: refine "notification reliability"

This commit refines the English in the "Notification Reliability"
section of the notifications.rst page (the "Bucket Notifications"
page). I have also added signposting structure.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Yuval Lifshitz <ylifshit@redhat.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 8f7b57f5cec475f8977e61707b287884903c1bb5)

3 years ago17.2.5 48519/head v17.2.5
Ceph Release Team [Mon, 17 Oct 2022 20:07:30 +0000 (20:07 +0000)]
17.2.5

Signed-off-by: Ceph Release Team <ceph-maintainers@ceph.io>
3 years agomgr/telemetry: handle daemons with complex ids 48290/head
Laura Flores [Wed, 28 Sep 2022 17:43:40 +0000 (17:43 +0000)]
mgr/telemetry: handle daemons with complex ids

Treating daemons as `<daemon_type>.x` caused a crash
in the Telemetry module since the current method does not cover a case
where a daemon id is more complex, i.e. `<daemon_type>.x.y`.

When we parse the daemon type and daemon id, we should
split it into a maximum of two pieces rather than splitting
it by every `.` character. Specifying `1` in the Python
.split() function will limit the split to a maximum of two items.

Fixes: https://tracker.ceph.com/issues/57700
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 97833a6a81fed7f868e1d544816cfbdf254fdb43)

3 years agoceph-volume: fix regression in activate
Guillaume Abrioux [Wed, 21 Sep 2022 20:25:04 +0000 (22:25 +0200)]
ceph-volume: fix regression in activate

bea9f4b643c introduced a regression that makes the activate process
take a very long time to complete.
`_get_bluestore_info()` which calls `ceph-bluestore-tool` binary via
subprocess is called in an exponential way while this is not needed.

Fixes: https://tracker.ceph.com/issues/57627
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 8d7423c3e75afbe111c91e699ef3cb1c0beee61b)

3 years agomgr/rook: fix error when trying to get the list of nfs services
Juan Miguel Olmo Martínez [Wed, 18 May 2022 16:18:16 +0000 (18:18 +0200)]
mgr/rook: fix error when trying to get the list of nfs services

Resolves: https://tracker.ceph.com/issues/55605

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
(cherry picked from commit 1532de124a99ab0e0820850e1c2739689ccb09f0)

3 years agoRevert "osd/PeeringState: fix missed `recheck_readable` from laggy"
Laura Flores [Wed, 14 Sep 2022 20:41:39 +0000 (15:41 -0500)]
Revert "osd/PeeringState: fix missed `recheck_readable` from laggy"

This reverts commit c71ee14cdbcc499d0ccaa84f4714ad5f29821f40.

This commit caused a regression in the rados suite, as evidenced by:

- with the commit:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_15:11:39-rados-quincy-release-distro-default-smithi/

- with the commit reverted:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_17:02:02-rados-wip-lflores-testing-quincy-release-distro-default-smithi/

Fixes: https://tracker.ceph.com/issues/57546
Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoRevert "osd/PeeringState: proc_lease_ack break once found from OSD"
Laura Flores [Wed, 14 Sep 2022 20:38:57 +0000 (15:38 -0500)]
Revert "osd/PeeringState: proc_lease_ack break once found from OSD"

This reverts commit 0d07b406dc2f854363f7ae9b970e980400f4f03e.

This commit caused a regression in the rados suite, as evidenced by:

- with the commit:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_15:11:39-rados-quincy-release-distro-default-smithi/

- with the commit reverted:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_17:02:02-rados-wip-lflores-testing-quincy-release-distro-default-smithi/

Fixes: https://tracker.ceph.com/issues/57546
Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #48386 from idryomov/wip-57766-quincy
Yuri Weinstein [Mon, 17 Oct 2022 14:10:06 +0000 (07:10 -0700)]
Merge pull request #48386 from idryomov/wip-57766-quincy

quincy: qa/tasks/rbd_fio: bump default to fio 3.32

Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agoMerge pull request #48432 from rhcs-dashboard/wip-57828-quincy
Nizamudeen A [Mon, 17 Oct 2022 13:44:54 +0000 (19:14 +0530)]
Merge pull request #48432 from rhcs-dashboard/wip-57828-quincy

quincy: mgr/dashboard: refactor dashboard cephadm e2e tests

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
3 years agoPendingReleaseNotes: add "rbd device unmap --namespace" note 48458/head
Ilya Dryomov [Mon, 10 Oct 2022 18:18:12 +0000 (20:18 +0200)]
PendingReleaseNotes: add "rbd device unmap --namespace" note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2df426bd9743309318cc1022853d0033e9c7c4b9)

3 years agoqa/workunits/rbd-nbd: also test map/unmap with --namespace option
Ilya Dryomov [Sat, 8 Oct 2022 14:16:10 +0000 (16:16 +0200)]
qa/workunits/rbd-nbd: also test map/unmap with --namespace option

The entire script is using specs, let's cover non-spec syntax as well.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit edfcf4bd6b2de0de124ec850c75feac3d76a863e)

3 years agorbd: Removed device_name argument from wnbd unmap
Stefan Chivu [Tue, 4 Oct 2022 14:02:14 +0000 (14:02 +0000)]
rbd: Removed device_name argument from wnbd unmap

Right now, rbd-wnbd doesn't actually use disk path
identifiers such as "/dev/*" or "\\.\PhysicalDrive*".

So instead of accepting two arguments that are basically
handled more or less the same, we're dropping the device_name
argument and sticking to the image spec.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit 79127642eb66bd878a1bb6fbf402d695af5bac63)

3 years agorbd: Moved get_image_or_snap_spec and parse_options to utils
Stefan Chivu [Tue, 4 Oct 2022 12:25:45 +0000 (12:25 +0000)]
rbd: Moved get_image_or_snap_spec and parse_options to utils

At the moment, there are multiple copies of "get_image_or_snap_spec".

For this reason, we're moving it to Utils.cc so that all backends may
re-use it, also benefiting from the recent pool related fix.

We are also renaming parse_options to append_options_as_args and
changing its type to void

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit efe8ceb5398e52418ae9ac8c3e227d8bd66a65ff)

3 years agorbd: Added namespace optarg for rbd device unmap
Stefan Chivu [Mon, 3 Oct 2022 08:20:58 +0000 (08:20 +0000)]
rbd: Added namespace optarg for rbd device unmap

When executing rbd device unmap, an explicit namespace optarg wasn't available

Fixes: https://tracker.ceph.com/issues/57765
Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit 51ba25c05c8ec93b26fc0b4fe6f3e5b685093244)

3 years agoMerge pull request #48474 from idryomov/wip-librbd-cmp-write-quincy
Ilya Dryomov [Mon, 17 Oct 2022 08:06:19 +0000 (10:06 +0200)]
Merge pull request #48474 from idryomov/wip-librbd-cmp-write-quincy

quincy: librbd: compare-and-write fixes and vector C API

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
3 years agoMerge pull request #48502 from zdover23/wip-doc-2022-10-17-backport-48501-to-quincy
zdover23 [Sun, 16 Oct 2022 18:38:57 +0000 (04:38 +1000)]
Merge pull request #48502 from zdover23/wip-doc-2022-10-17-backport-48501-to-quincy

quincy: doc/radosgw: refine notifications.rst - top part

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: refine notifications.rst - top part 48502/head
Zac Dover [Sun, 16 Oct 2022 17:54:25 +0000 (03:54 +1000)]
doc/radosgw: refine notifications.rst - top part

This commit refines the English in the first part of the
notifications.rst page (the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 840a2fe3e30d099459ccee0c4c7735853dad0bb9)

3 years agoMerge pull request #48499 from zdover23/wip-doc-2022-10-16-backport-48498-to-quincy
zdover23 [Sun, 16 Oct 2022 03:59:19 +0000 (13:59 +1000)]
Merge pull request #48499 from zdover23/wip-doc-2022-10-16-backport-48498-to-quincy

quincy: doc/radosgw: update notifications.rst - grammar

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: update notifications.rst - grammar 48499/head
Zac Dover [Sun, 16 Oct 2022 03:09:35 +0000 (13:09 +1000)]
doc/radosgw: update notifications.rst - grammar

This commit rewrites a sentence, as requested by
C. Mitchell here:
https://github.com/ceph/ceph/pull/48493/files#r996003812

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 43c37c6721b373af41fe58235b77a917d1961fc1)

3 years agoMerge pull request #48494 from zdover23/wip-doc-2022-10-15-backport-48493-to-quincy
zdover23 [Fri, 14 Oct 2022 21:26:38 +0000 (07:26 +1000)]
Merge pull request #48494 from zdover23/wip-doc-2022-10-15-backport-48493-to-quincy

quincy: doc/radosgw: improve grammar - notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #48228 from ivancich/wip-57430-quincy
Yuri Weinstein [Fri, 14 Oct 2022 18:54:16 +0000 (11:54 -0700)]
Merge pull request #48228 from ivancich/wip-57430-quincy

quincy: rgw: fix bug where variable referenced after data moved out

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 years agodoc/radosgw: improve grammar - notifications.rst 48494/head
Zac Dover [Fri, 14 Oct 2022 17:48:44 +0000 (03:48 +1000)]
doc/radosgw: improve grammar - notifications.rst

This commit makes the changes suggested by C. Mitchell in
https://github.com/ceph/ceph/pull/48486.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 98a4d938e561eb924950535c1a4fe1d6b02849c5)

3 years agoMerge pull request #48487 from zdover23/wip-doc-2022-10-14-backport-48486-to-quincy
zdover23 [Fri, 14 Oct 2022 07:08:43 +0000 (17:08 +1000)]
Merge pull request #48487 from zdover23/wip-doc-2022-10-14-backport-48486-to-quincy

quincy: doc/radosgw: add push_endpoint for rabbitmq

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/radosgw: add push_endpoint for rabbitmq 48487/head
Zac Dover [Fri, 14 Oct 2022 06:17:12 +0000 (16:17 +1000)]
doc/radosgw: add push_endpoint for rabbitmq

This commit directs users of rabbitmq to use "push_endpoint"
(with an underscore) instead of "push-endpoint" (with a hy-
phen). This commit adds a note that contains such a direct-
ive. It does not alter the examples already present in the
text.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit ddf8295438b14ada04d8bb5dfc23402bedc937b8)

3 years agoMerge pull request #48479 from zdover23/wip-doc-2022-10-13-backport-48463-to-quincy
zdover23 [Thu, 13 Oct 2022 13:31:12 +0000 (23:31 +1000)]
Merge pull request #48479 from zdover23/wip-doc-2022-10-13-backport-48463-to-quincy

quincy: doc/dev: add submodule-update link to dev guide

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/dev: add submodule-update link to dev guide 48479/head
Zac Dover [Wed, 12 Oct 2022 12:39:36 +0000 (22:39 +1000)]
doc/dev: add submodule-update link to dev guide

This commit links to the procedure in install/clone-source.rst that
explains how to update submodules.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit e55c3b114be402eae94550c603cf7c028c9b64bf)

3 years agoPendingReleaseNotes: add rbd_aio_compare_and_writev note 48474/head
Ilya Dryomov [Thu, 6 Oct 2022 10:36:00 +0000 (12:36 +0200)]
PendingReleaseNotes: add rbd_aio_compare_and_writev note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit bd98a66d03a0d9b0a8d1d6d6c0bd698b5baff60f)

Conflicts:
PendingReleaseNotes [ moved to >=17.2.5 section ]

3 years agolibrbd: add compare-and-write vector C API
Jonas Pfefferle [Thu, 29 Sep 2022 19:39:12 +0000 (21:39 +0200)]
librbd: add compare-and-write vector C API

Add compare and write vector C API.
Require cmp_iov and write_iov to be the same length.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit 60fd534731487fa15372558f018099df1bca06a3)

3 years agotest/librbd: various fixups for compare-and-write test cases
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
test/librbd: various fixups for compare-and-write test cases

- missing EILSEQ asserts in IO and IOWithIOHint
- AioCompletion leak in CompareTooSmall and WriteTooSmall
- skip StripeUnitUnaligned and TooLarge on the PWL cache as it wasn't
  limited by the 512-byte sector limit before and isn't limited by the
  stripe unit limit now

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 093e8237450f561a2267b07231426f86735a2faf)

3 years agolibrbd/cache/pwl: adjust compare-and-write compare substringing
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
librbd/cache/pwl: adjust compare-and-write compare substringing

cmp_bl can no longer be shorter than read_bl (i.e. image extent).
This is caught very early at the API level, see commit af96e6dae3f4
("librbd: make C++ cmp&write semantics equal to C API").

However, cmp_bl can still be longer than read_bl and in that case
it should be capped by the image extent length.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 35f3ccb68714f18cc1ff78278fdd5216590cc9bf)

3 years agolibrbd: discard cache state if compare-and-write writes to disk
Ilya Dryomov [Mon, 15 Aug 2022 07:44:09 +0000 (09:44 +0200)]
librbd: discard cache state if compare-and-write writes to disk

Otherwise this is obviously broken with rbd_cache_policy = writeback or
rbd_cache_policy = writethrough as the write is done on the OSD, beneath
ObjectCacher.  This went unnoticed because the original (and so far the
only known) compare-and-write user, tcmu-runner rbd driver, disables the
cache altogether.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit ec0fc71cdb579e31ff4e599c43f3918322e70ddf)

3 years agoPendingReleaseNotes: add rbd compare-and-write notes
Ilya Dryomov [Fri, 12 Aug 2022 11:55:01 +0000 (13:55 +0200)]
PendingReleaseNotes: add rbd compare-and-write notes

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 4ddcb7ff92a51a6fa17887e54fd357bd5dea5f4e)

Conflicts:
PendingReleaseNotes [ moved to >=17.2.5 section ]

3 years agolibrbd: make C++ cmp&write semantics equal to C API
Jonas Pfefferle [Fri, 5 Aug 2022 17:37:55 +0000 (19:37 +0200)]
librbd: make C++ cmp&write semantics equal to C API

The compare and write C++ API (both sync and async) does not check
compare bufferlist length and executes compare ops of bufferlist length
size, even if (write) "len" is smaller than bufferlist length.
This patch changes this behavior by always issuing compares and
writes of "len" size to match the C API. The bufferlist length
can be greater than "len" for both compare and write but only
"len" bytes are compared and written. If the bufferlist length
is smaller than "len" the call will fail.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit af96e6dae3f4c3e30f91cb26d6579a6b5a726862)

3 years agolibrbd: remove cmp&write sector size restriction
Jonas Pfefferle [Fri, 5 Aug 2022 17:36:36 +0000 (19:36 +0200)]
librbd: remove cmp&write sector size restriction

This patch removes the compare and write max sector size len
restriction. We can allow up to stripe unit size accesses if
the access is aligned properly.
To allow larger size compare and write requests in the
journal we split the buffers like we do for writes now.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit d80cff0dd665d660cd545c5a66d265b6bf732c73)

3 years agolibrbd: new cmp&write C API tests
Jonas Pfefferle [Tue, 3 May 2022 07:16:00 +0000 (09:16 +0200)]
librbd: new cmp&write C API tests

Test correct mismatch offset is returned.
Test no data is written when compare fails.
Test correct data is written when compare succeeds.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit 3eb7ac6aeb3d11911bcf1c393ddee8913414bef7)

3 years agoMerge pull request #48464 from zdover23/wip-doc-2022-10-15-backport-48460-to-quincy
zdover23 [Wed, 12 Oct 2022 18:04:02 +0000 (04:04 +1000)]
Merge pull request #48464 from zdover23/wip-doc-2022-10-15-backport-48460-to-quincy

quincy: doc/install: improve updating submodules procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/install: improve updating submodules procedure 48464/head
Zac Dover [Wed, 12 Oct 2022 08:27:42 +0000 (18:27 +1000)]
doc/install: improve updating submodules procedure

This commit beefs up the "Updating Submodules" procedure,
which (prior to this commit) was quite brief.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 9382a90342f96cabab4b7caf816d9381f77e7f46)

3 years agoMerge pull request #48219 from s0nea/wip-57661-quincy
Nizamudeen A [Wed, 12 Oct 2022 05:07:46 +0000 (10:37 +0530)]
Merge pull request #48219 from s0nea/wip-57661-quincy

quincy: mgr/dashboard: add option to resolve ip addr

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #48340 from rhcs-dashboard/fix-fedora-url-quincy
Nizamudeen A [Tue, 11 Oct 2022 19:33:34 +0000 (01:03 +0530)]
Merge pull request #48340 from rhcs-dashboard/fix-fedora-url-quincy

quincy: mgr/dashboard: Fix broken Fedora image URL

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: zmc <NOT@FOUND>
3 years agoMerge pull request #48447 from zdover23/wip-doc-2022-10-12-backport-48446-to-quincy
zdover23 [Tue, 11 Oct 2022 18:09:38 +0000 (04:09 +1000)]
Merge pull request #48447 from zdover23/wip-doc-2022-10-12-backport-48446-to-quincy

quincy: doc/glossary: add "ceph monitor" entry

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agodoc/glossary: add "ceph monitor" entry 48447/head
Zac Dover [Tue, 11 Oct 2022 16:49:13 +0000 (02:49 +1000)]
doc/glossary: add "ceph monitor" entry

This commit adds information to the "ceph monitor" entry in
glossary.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 8f4ad5dc9d171c805f061b937ad1110b53255fa6)

3 years agoMerge pull request #48433 from rhcs-dashboard/wip-57831-quincy
Nizamudeen A [Tue, 11 Oct 2022 16:18:35 +0000 (21:48 +0530)]
Merge pull request #48433 from rhcs-dashboard/wip-57831-quincy

quincy: mgr/dashboard: fix weird data in osd details

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #48430 from zdover23/wip-doc-2022-10-11-backport-48429-to-quincy
zdover23 [Tue, 11 Oct 2022 16:13:08 +0000 (02:13 +1000)]
Merge pull request #48430 from zdover23/wip-doc-2022-10-11-backport-48429-to-quincy

quincy: doc/security: improve grammar in CVE-2022-0670.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agoMerge pull request #48438 from rhcs-dashboard/wip-57838-quincy
Nizamudeen A [Tue, 11 Oct 2022 11:08:26 +0000 (16:38 +0530)]
Merge pull request #48438 from rhcs-dashboard/wip-57838-quincy

quincy: mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: auto-coloring-badges-component 48433/head
Pedro Gonzalez Gomez [Tue, 5 Jul 2022 09:40:01 +0000 (11:40 +0200)]
mgr/dashboard: auto-coloring-badges-component

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 29f510a522b2694903d095ac0ec45ee23c474121)

3 years agomgr/dashboard: add server side encryption to rgw/s3 48441/head
Aashish Sharma [Mon, 8 Aug 2022 12:35:02 +0000 (18:05 +0530)]
mgr/dashboard: add server side encryption to rgw/s3

Fixes:https://tracker.ceph.com/issues/57826
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 42aa2283c2aea6059586cf3bb213a127d8879a45)

3 years agomgr/dashboard: Unable to change rgw subuser permission 48440/head
Aashish Sharma [Mon, 10 Oct 2022 09:08:08 +0000 (14:38 +0530)]
mgr/dashboard: Unable to change rgw subuser permission

Tried to edit the permission of a subuser but once changed the permission, edited permission not seen in user info of UI(ceph dashboard) and from CLI as well

Fixes:https://tracker.ceph.com/issues/57805
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 0b3bdbbc4a4ac78555d08839ee0eca1767465d1c)

3 years agoMerge pull request #48434 from rhcs-dashboard/pyfake-fix-quincy
Nizamudeen A [Tue, 11 Oct 2022 10:30:45 +0000 (16:00 +0530)]
Merge pull request #48434 from rhcs-dashboard/pyfake-fix-quincy

quincy: cephadm: run tests as root

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agomgr/prometheus: change pg_repaired_objects name to pool_repaired_objects 48438/head
Pere Diaz Bou [Mon, 10 Oct 2022 10:08:34 +0000 (12:08 +0200)]
mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Fixes: https://tracker.ceph.com/issues/57806
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 114727fd341ab90328ac3a829807bbc39820f901)

3 years agocephadm: pin pyfakefs to 5.0 48434/head
Kefu Chai [Mon, 10 Oct 2022 15:19:27 +0000 (23:19 +0800)]
cephadm: pin pyfakefs to 5.0

so the test is more repeatable.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 52f5c2fed057efa25e1cbea2a2bb4295f77831e4)

3 years agocephadm: fix the indent
Kefu Chai [Mon, 10 Oct 2022 14:43:23 +0000 (22:43 +0800)]
cephadm: fix the indent

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 38dc57ac9a88dafbe73038ea757dfa778c6191a7)

 Conflicts:
src/cephadm/tests/fixtures.py
  - Replace _cephadm with cd

3 years agocephadm: run tests as root
Kefu Chai [Mon, 10 Oct 2022 13:57:57 +0000 (21:57 +0800)]
cephadm: run tests as root

as we will be create/access directories which are only accessible by
root with pyfakefs, and pyfake respects the uid of current effective
user, so if we run the test using non-root user, these tests would fail
after the fix for https://github.com/pytest-dev/pyfakefs/issues/489
is addressed in the pyfakefs we are using.

in this change, we will run the test on behalf of root, so we can
create and access the directories as we did before.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit ed19416067a7ef3b69310d22bf4e3b573e3011f0)

 Conflicts:
src/cephadm/tests/fixtures.py
  - Replace _cephadm with cd

3 years agomgr/dashboard: fix weird data in osd details
Nizamudeen A [Mon, 10 Oct 2022 05:41:18 +0000 (11:11 +0530)]
mgr/dashboard: fix weird data in osd details

The devices section in the OSD Details and Host Details shows more than
one daemon and device path in the column when you view the details of a
single osd details/host details. This is because more than one osd
is created on a device with same `deviceid`. I am not sure if this will
happen in the real environment but its mostly reproducible in
environments with QEMU emulated devices.

Fixes: https://tracker.ceph.com/issues/57803
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 2e2ecde82f58f26e1f83e329b254ef97fa989506)

3 years agoRevert "mgr/dashboard: unselect rows in datatables" 48432/head
Nizamudeen A [Thu, 6 Oct 2022 09:49:09 +0000 (15:19 +0530)]
Revert "mgr/dashboard: unselect rows in datatables"

This reverts commit b79e2a6c6a9368a4fc167b05970db463cd60edab.

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 82d2ac1abacd19405fdfbf9a8626570231559dba)

3 years agomgr/dashboard: refactor dashboard cephadm e2e tests
Nizamudeen A [Mon, 19 Sep 2022 08:45:52 +0000 (14:15 +0530)]
mgr/dashboard: refactor dashboard cephadm e2e tests

Fixes: https://tracker.ceph.com/issues/57511
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit bc20ab493cd7b70f140e507f99576496fb755aac)

 Conflicts:
src/pybind/mgr/dashboard/frontend/cypress/integration/orchestrator/workflow/06-cluster-check.e2e-spec.ts
   - Accept the incoming changes

3 years agodoc/security: improve grammar in CVE-2022-0670.rst 48430/head
Zac Dover [Tue, 11 Oct 2022 04:36:10 +0000 (14:36 +1000)]
doc/security: improve grammar in CVE-2022-0670.rst

This commit accepts the suggestions made by Cole Mitchell in
https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 52971eb9ac65a25e1bb79e7587de5a51900261d3)

3 years agoMerge pull request #48141 from rhcs-dashboard/wip-57581-quincy
Nizamudeen A [Tue, 11 Oct 2022 04:38:02 +0000 (10:08 +0530)]
Merge pull request #48141 from rhcs-dashboard/wip-57581-quincy

quincy: mgr/dashboard: fix Expected to find element: `cd-modal .badge but never found it

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Yuri Weinstein <yweins@redhat.com>
3 years agoMerge pull request #48424 from zdover23/wip-doc-2022-10-11-backport-48423-to-quincy
zdover23 [Tue, 11 Oct 2022 03:54:05 +0000 (13:54 +1000)]
Merge pull request #48424 from zdover23/wip-doc-2022-10-11-backport-48423-to-quincy

quincy: doc/releases: improve grammar in pacific.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/releases: improve grammar in pacific.rst 48424/head
Zac Dover [Mon, 10 Oct 2022 14:15:11 +0000 (00:15 +1000)]
doc/releases: improve grammar in pacific.rst

This commit accepts the grammar suggestions that were made by Cole
Mitchell in https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 560d7590fdf66ef3827203bc7c5725f167a1a7b2)

3 years agoMerge pull request #48402 from zdover23/wip-doc-2022-10-09-backport-48401-to-quincy
zdover23 [Sun, 9 Oct 2022 07:41:56 +0000 (17:41 +1000)]
Merge pull request #48402 from zdover23/wip-doc-2022-10-09-backport-48401-to-quincy

quincy: doc/various: update link to CRUSH pdf

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
3 years agodoc/various: update link to CRUSH pdf 48402/head
Zac Dover [Sun, 9 Oct 2022 07:09:30 +0000 (17:09 +1000)]
doc/various: update link to CRUSH pdf

This commit updates link to the research paper that announces and
explains the CRUSH algorithm. This link was broken in the migration from
the old Ceph website to ceph.io.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 6877b592a289cb473f16daa79d5112f5b2d8006c)

3 years agoMerge pull request #48164 from kotreshhr/wip-57554-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:11:49 +0000 (10:11 -0700)]
Merge pull request #48164 from kotreshhr/wip-57554-quincy

quincy: qa: ignore disk quota exceeded failure in test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #48113 from NitzanMordhai/wip-57545-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:08:35 +0000 (10:08 -0700)]
Merge pull request #48113 from NitzanMordhai/wip-57545-quincy

quincy: pybind/rados: notify callback reconnect

Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #48039 from NitzanMordhai/wip-57496-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:05:40 +0000 (10:05 -0700)]
Merge pull request #48039 from NitzanMordhai/wip-57496-quincy

quincy: osd: remove invalid put on message

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #47983 from sseshasa/wip-57443-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:03:54 +0000 (10:03 -0700)]
Merge pull request #47983 from sseshasa/wip-57443-quincy

quincy: osd: Implement Context based completion for mon cmd to set a config option

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #47933 from rzarzynski/wip-57346-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:03:07 +0000 (10:03 -0700)]
Merge pull request #47933 from rzarzynski/wip-57346-quincy

quincy: common/ceph_context: leak some memory fail to show in valgrind

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
3 years agoMerge pull request #47928 from rzarzynski/wip-56602-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:01:25 +0000 (10:01 -0700)]
Merge pull request #47928 from rzarzynski/wip-56602-quincy

quincy: Monitor: forward report command to leader

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #47926 from rzarzynski/wip-55282-quincy
Yuri Weinstein [Thu, 6 Oct 2022 17:00:38 +0000 (10:00 -0700)]
Merge pull request #47926 from rzarzynski/wip-55282-quincy

quincy: osd: add scrub duration for scrubs after recovery

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
3 years agoMerge pull request #47890 from lxbsz/wip-57240
Yuri Weinstein [Thu, 6 Oct 2022 16:58:22 +0000 (09:58 -0700)]
Merge pull request #47890 from lxbsz/wip-57240

quincy: mds/client: fail the request if the peer MDS doesn't support getvxattr op

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #47820 from neesingh-rh/wip-57278-quincy
Yuri Weinstein [Thu, 6 Oct 2022 16:56:16 +0000 (09:56 -0700)]
Merge pull request #47820 from neesingh-rh/wip-57278-quincy

quincy: cephfs-top, mgr/stats: multiple file system support with UI

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoqa/tasks/rbd_fio: bump default to fio 3.32 48386/head
Ilya Dryomov [Wed, 5 Oct 2022 08:09:28 +0000 (10:09 +0200)]
qa/tasks/rbd_fio: bump default to fio 3.32

fio 3.16 doesn't build against recent kernel headers due to removal of
linux/raw.h.

Fixes: https://tracker.ceph.com/issues/57766
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 6582c47934afb29c65739e465222a571727658d5)

3 years agoMerge pull request #48380 from zdover23/wip-doc-2022-10-06-backport-48379-to-quincy
zdover23 [Thu, 6 Oct 2022 06:00:18 +0000 (16:00 +1000)]
Merge pull request #48380 from zdover23/wip-doc-2022-10-06-backport-48379-to-quincy

quincy: doc/install: clone-source.rst s/master/main

Reviewed-by: Cole Michell <cole.mitchell@gmail.com>
3 years agodoc/install: clone-source.rst s/master/main 48380/head
Zac Dover [Thu, 6 Oct 2022 04:30:07 +0000 (14:30 +1000)]
doc/install: clone-source.rst s/master/main

s/master/main in doc/install/clone-source.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 5c17509b0a3402ca4a3ee574ed7e73949d51c72a)

3 years agoMerge pull request #48370 from zdover23/wip-doc-2022-10-05-backport-44564-to-quincy
zdover23 [Wed, 5 Oct 2022 11:15:43 +0000 (21:15 +1000)]
Merge pull request #48370 from zdover23/wip-doc-2022-10-05-backport-44564-to-quincy

quincy: doc/mgr: name data source in "Man Install & Config"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>