doc/dev: alphabetize EC glossary

Alphabetize the glossary in
doc/dev/osd_internals/erasure_coding.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48673 from idryomov/wip-49947

doc: note architecture availability for PMEM mode of PWL cache

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #48548 from dparmar18/update_debug_script

script/ceph-debug-docker.sh: change default branch to main

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #48674 from zdover23/doc-2022-10-31-dev-osd-internals-ec-glossary

doc/dev: improve EC glossary

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/dev: improve EC glossary

Improve the clarity and syntax of the text in
doc/dev/osd_internals/erasure_coding.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc: note architecture availability for PMEM mode of PWL cache

Fixes: https://tracker.ceph.com/issues/49947
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #48667 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-colemitchell-notes

doc/ceph-volume: refine Filestore docs

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: refine Filestore docs

Add Cole Mitchell's improvements to the filestore section.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48665 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-datri-notes

doc/ceph-volume: improve prepare.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: improve prepare.rst

Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/48651.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48090 from joscollin/wip-F55197-cephfs-top-scroll

cephfs-top: make cephfs-top display scrollable

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

Merge pull request #48662 from ceph/wip-update-stale-bot

.github/workflows: update `days-before-pr-close`

.github/workflows: update `days-before-pr-close`

Currently, the stale bot closes PRs 90 days after they are marked stale since it counts "marking a PR stale" as activity.

We really want the PRs to close after a total of 90 days, or 30 days after they are marked stale. Changing `days-before-prs-close` to 30 will fix this.

Signed-off-by: Laura Flores <lflores@redhat.com>

Merge pull request #48658 from zdover23/wip-doc-2022-10-28-radosgw-multisite-prompts

doc/radosgw: add prompts to multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: add prompts to multisite.rst

Add unselectable prompts to multisite.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #47582 from snosratiershad/docs/correct-add-system-user-to-the-master-zone-command

docs: correct add system user to the master zone command

Reviewed-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48649 from ybwang0211/REST-spell

doc: Change 'ReST' to 'REST' in doc/radosgw/layout.rst

Reviewed-by: Zac Dover <zac.dover@gmail.com>

doc: Change 'ReST' to 'REST' in doc/radosgw/layout.rst

In doc/radosgw/layout.rst, 'ReST' is not spelled properly, so we change it to 'REST'.

Signed-off-by: wangyingbin <wangyingbin@inspur.com>

Merge pull request #48644 from zdover23/wip-doc-2022-10-28-ceph-volume-lvm-prepare-datri-notes

doc/ceph-volume: add A. D'Atri's suggestions

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: add A. D'Atri's suggestions

Add Anthony D'Atri's notes on doc/ceph-volume/lvm/prepare.rst as
expressed in https://github.com/ceph/ceph/pull/48634.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48629 from SUSE/wip-fix-neorados-fmt9

neorados: compile with fmt v9

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48622 from vumrao/wip-vikhyat-governance

doc/governance: add CLT member Vikhyat Umrao

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #47874 from petrutlucian94/dokany_v2

dokan: switch to Dokany v2

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48624 from zdover23/wip-doc-2022-10-26-ceph-volume-lvm-prepare

doc/ceph-volume: refine "prepare" top matter

neorados: compile with fmt v9

neorados FTBFS on openSUSE Tumbleweed which includes fmt version 9.
On the assumption it's still desirable to support building with older
versions, I've put "#if FMT_VERSION" guards around the additions here.

Signed-off-by: Tim Serong <tserong@suse.com>

doc/ceph-volume: refine "prepare" top matter

This commit refines the top matter in the
doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48633 from adamemerson/wip-scopeguard-nodiscard

include: Add [[nodiscard]] to make_scope_guard

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48586 from ivancich/wip-document-sal-readop-read

rgw: document convention used in ReadOp::read and ReadOp::iterate

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

include: Add [[nodiscard]] to make_scope_guard

To prevent a bug where an unassigned scope guard runs right away.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #48619 from ceph/wip-tracker-57883

qa/standalone/erasure-code: give osdmap 5 seconds to refresh

Merge pull request #48557 from phlogistonjohn/jjm-fix-cephadm-test-py36

cephadm: fix running cephadm tox test suite on python 3.6

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48620 from mgfritch/cephadm-gitignore

cephadm: add .gitignore for tox related files

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #48627 from zdover23/wip-doc-2022-10-26-ceph-volume-lvm-prepare-3

doc/ceph-volume: refine "filestore" section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48625 from zdover23/wip-doc-2022-10-26-ceph-volume-lvm-prepare-2

doc/ceph-volume: refine "bluestore" section

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge PR #43284 into main

* refs/pull/43284/head:
doc: describe bal_rank_mask configuration
qa/cephfs: add bal_rank_mask test cases
mds: add bal_rank_mask option for ceph fs set

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

doc/ceph-volume: refine "filestore" section

This commit refines the "filestore" section in the doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

cephfs-top: Select Filesystem Screen fixes for no FS

* drop the blank FS Menu when there is no FS
* cleanup display_fs_menu() code

Signed-off-by: Jos Collin <jcollin@redhat.com>

doc: Update cephfs-top.png

Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>

cephfs-top: make cephfs-top display scrollable

Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>

doc/ceph-volume: refine "bluestore" section

This commit refines the "bluestore" section in the
doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/governance: add CLT member Vikhyat Umrao

Signed-off-by: Vikhyat Umrao <vikhyat@redhat.com>

cephadm: add .gitignore for tox related files

ignore files created by a run of `tox -e coverage`

Signed-off-by: Michael Fritch <mfritch@suse.com>

qa/standalone/erasure-code: give osdmap 5 seconds to refresh

Fixes: https://tracker.ceph.com/issues/57883
Signed-off-by: Laura Flores <lflores@redhat.com>

Merge pull request #40363 from orozery/rbd-clone-encryption

librbd: add encryption format support for clones (part 1/2)

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

cephadm: fix running test suite on python3.6

While a new version of pyfakefs is available, version 5 is not available
for python 3.6. In order to run the test suite on centos 8 we will
continue to work with pyfakefs version 4.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: fix base class behavior on python3.6

This fixes the cephadm test files when running tox/pytest on python3.6
(centos/rhel 8).
Long story short, combining classmethod and property on py3.6 behaves
differently from py3.7 and up. Since the classmethod is actually
unnecessary for the base class to behave as it does, we drop that
decorator.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #48547 from SUSE/wip-fix-57893

make-dist: don't set Release tag in ceph.spec for SUSE distros

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #48610 from zdover23/wip-doc-2022-10-25-cephadm-ssh-capitalization

doc/cephadm: s/ssh/SSH/ in doc/cephadm (complete)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: s/ssh/SSH/ in doc/cephadm (complete)

This PR alters "ssh" to "SSH" in the text (that is, not in
commands) every location in the doc/cephadm/ directory where
"ssh" should be "SSH".

Signed-off-by: Zac Dover <zac.dover@gmail.com>

make-dist: don't set Release tag in ceph.spec for SUSE distros

SUSE's Open Build Service overwrites the Release tag with checkin
and build counters, so we can't use it to record the number of
commits since the last tag, and the last commit hash.  This commit
appends that extra information to the Version tag instead for
SUSE builds.

Fixes: https://tracker.ceph.com/issues/57893
Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #46188 from Zhiwei-Dai/wip-rgw-crypto-stack-on-compress

rgw: support full object encryption stack on compression

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48588 from tchaikov/wip-57834

qa/tasks/vstart_runner: do not fail if stop.sh fails

Reviewed-by: Tim Serong <tserong@suse.com>

Merge pull request #48345 from Matan-B/wip-matanb-c-load-obc

crimson/osd: Generalize loading obc for head/clone

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>

Merge pull request #48605 from zdover23/wip-doc-2022-10-24-cephadm-front-matter-improvement

doc/cephadm: improve front matter

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: improve front matter

- I fixed a sentence that was missing a verb.
- I linked to the Ceph-specific Rook instructions.
- I removed the word "GitHub", because after adding the
  Rook instructions it made the sentence false.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48576 from cyx1231st/wip-crimson-msgr-cleanup-2

crimson/net: fixes and cleanups

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48600 from zdover23/wip-doc-2022-10-24-cephadm-host-management-colon-cleaning

doc/cephadm: clean colons in host-management.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48599 from zdover23/wip-doc-2022-10-24-cephadm-troubleshooting-ssh-capitalization

doc/cephadm: s/ssh/SSH/ in troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: clean colons in host-management.rst

Two lines in host-management.rst ended with both colons and
full stops (periods), causing a kind of punctuational turf
war. This commit removes the full stops.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/cephadm: s/ssh/SSH/ in troubleshooting.rst

Two places in the troubleshooting.rst file had "ssh" in
the text when it should have been "SSH".

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48593 from zdover23/wip-doc-2022-10-23-cephadm-front-matter

doc/cephadm: update install.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/cephadm: update install.rst

This commit addresses https://github.com/ceph/ceph/pull/43250,
which has remained unmerged for thirteen months. The issues
raised in that PR are addressed here.

This commit contributes to the simplification of the procedure
that explains how to install cephadm. More remains to be done
on this page, but the old PR had to be dealt with first.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48584 from tchaikov/crimson-net-formatter

crimson/net: define fmt::formatter for write_state_t

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #48587 from zdover23/wip-doc-2022-10-22-cephadm-host-management-prompts

doc/cephadm: add prompts to host-management.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

qa/tasks/vstart_runner: do not fail if stop.sh fails

stop.sh might fail, but let's keep moving on.

See-also: https://tracker.ceph.com/issues/57834
Signed-off-by: Kefu Chai <tchaikov@gmail.com>

stop.sh: call cephadm rm-cluster only if FSID is not empty

there are chances that there is no cluster running at that moment,
so we could have failure messages like

[errno 2] RADOS object not found (error connecting to the cluster)
usage: cephadm rm-cluster [-h] --fsid FSID [--force] [--keep-logs]
                          [--zap-osds]
cephadm rm-cluster: error: argument --fsid: expected one argument

in that case, better off not failing this bash function, as this
is not a fatal failure.

See-also: https://tracker.ceph.com/issues/57834
Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48555 from phlogistonjohn/jjm-unify-test-alertmanager-config

mgr/cephadm: consolidate test_alertmanager_config_* tests into one

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

doc/cephadm: add prompts to host-management.rst

This PR adds unselectable prompts to host-management.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/net: define fmt::formatter for write_state_t

for better readability

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

rgw: document convention used in ReadOp::read and ReadOp::iterate

Both of these functions defined at the SAL layer take an offset and an
end offset. It's important to note that the end offset is inclusive
since a common, modern convention is for the end offset to be
exclusive.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #48478 from myoungwon/wip-rbm-move-mkfs-cleanup

crimson/os/seastore/rbm: move mkfs to RBMDevice and use device_config_t

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: convert Connection to an interface class

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: convert Messenger to an interface class

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: no futurized SocketMessenger::get_global_seq()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: no futurized Messenger::set_myaddrs()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: add warn log if server got mismatched lossy policy from client

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: set global_seq when get from Messenger

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: move features from Connection to SocketConnection

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: drop the unnecessary connection_features member

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: fix peer_supported_features usages

Also see commit "msg/async/ProtocolV2: store supported features instead
of required"

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #48445 from rzarzynski/wip-crimson-fix-obcload-errs

crimson/osd: send proper reply on obc load failure

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48577 from zdover23/wip-doc-2022-10-21-radosgw-notifications-and-event

doc/radosgw: refine "notifications" and "events"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: refine "notifications" and "events"

This commit refines the English in the "Notifications"
and "Events" sections of the notifications.rst page
(the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/os/seastore/cbj: handle remaing space (from written_to to the end of the journal) is less than the requested size

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/rbm: move test interfaces to the end of the class

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/cbj: rename size-related interfaces with grouping

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

Merge pull request #48477 from rzarzynski/wip-crimson-rollback-delete-head

crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48572 from zdover23/wip-doc-2022-10-21-cephadm-host-management-os-tuning-grammar

doc/cephadm: refine "os tuning" in h. management

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: refine "os tuning" in h. management

This commit refines the English in the "OS Tuning Profiles" section of
the "Host Management" page of the cephadm documentation. This commit is
made separately from but in anticipation of a forthcoming commit that
corrects technical (non-grammatical) errors.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #46089 from myoungwon/wip-dedup-doc

doc/dev: add explanation of how to use deduplication

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

This allows to pass `TestLibRBD.TestIOToSnapshot`:

```
[rzarzynski@o06 build]$ CRIMSON_COMPAT=true RBD_FEATURES=1 bin/ceph_test_librbd --gtest_filter=TestLibRBD.TestIOToSnapshot
seed 3954016
Note: Google Test filter = TestLibRBD.TestIOToSnapshot
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestLibRBD
[ RUN      ] TestLibRBD.TestIOToSnapshot
using new format!
...
opening testimg@orig
read: 80
write to snapshot returned -30
Read-only file system
num snaps is: 2
expected: 2
snap: orig
snap: written
found orig with size 2097152
found written with size 2097152
num snaps is: 1
expected: 1
snap: orig
found orig with size 2097152
num snaps is: 0
expected: 0
[       OK ] TestLibRBD.TestIOToSnapshot (7510 ms)
[----------] 1 test from TestLibRBD (7510 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (8504 ms total)
[  PASSED  ] 1 test.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48246 from liangmingyuanneo/fix-throttle-test

test/rgw: improve integrity of rgw throttle test

Reviewed-by: Casey Bodley <cbodley@redhat.com>

crimson/osd: ClientRequest sends error to client when loading obc fails

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48456 from rhcs-dashboard/cypress-video-enable

mgr/dashboard: enable cypress video on test fails

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #48546 from rhcs-dashboard/update-node

cmake: bump node version to 14

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #48505 from zhscn/fix-uaf

crimson/osd: fix use after free error in FuturizedStoreLogReader::read

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

crimson/net: drop Protocol::proto_type

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: check SERVER_WAIT state won't send

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/net: check CONNECTING/WAIT/STANDBY states are not reentrant

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #48556 from zdover23/wip-doc-2022-10-20-radosgw-notifications-bucket-notifications-rest-api

doc/radosgw: refine "bucket notifications"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>