doc/dev: alphabetize EC glossary

Alphabetize the glossary in
doc/dev/osd_internals/erasure_coding.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 5067f575ad6763e106164aef98f1e172042437b6)

Merge pull request #48675 from zdover23/wip-doc-2022-10-31-backport-48674-to-quincy

quincy: doc/dev: improve EC glossary

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/dev: improve EC glossary

Improve the clarity and syntax of the text in
doc/dev/osd_internals/erasure_coding.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 64f10fc14ba52797ee0c713d0092f2535b6afb3d)

Merge pull request #48670 from zdover23/wip-doc-2022-10-30-backport-48667-to-quincy

quincy: doc/ceph-volume: refine Filestore docs

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #48668 from zdover23/wip-doc-2022-10-30-backport-48665-to-quincy

quincy: doc/ceph-volume: improve prepare.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: refine Filestore docs

Add Cole Mitchell's improvements to the filestore section.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit d5717fe2648451d48f39f30163c6e4af7eaa7a09)

doc/ceph-volume: improve prepare.rst

Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/48651.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 5c5da781cae6e7af16ef31782c99c8bc1490baf1)

Merge pull request #48659 from zdover23/wip-doc-2022-10-28-backport-48658-to-quincy

quincy: doc/radosgw: add prompts to multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: add prompts to multisite.rst

Add unselectable prompts to multisite.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit d85c14bb3085ab70139253b70b6498834d167825)

Merge pull request #48653 from zdover23/wip-doc-2022-10-28-backport-48649-to-quincy

quincy: doc: Change 'ReST' to 'REST' in doc/radosgw/layout.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48651 from zdover23/wip-doc-2022-10-28-backport-48624-to-quincy

quincy: doc/ceph-volume: refine "prepare" top matter

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48655 from zdover23/wip-doc-2022-10-28-backport-47582-to-quincy

quincy: docs: correct add system user to the master zone command

Reviewed-by; Anthony D'Atri <anthony.datri@gmail.com>

docs: correct add system user to the master zone command

Signed-off-by: Salar Nosrati-Ershad <snosratiershad@gmail.com>
(cherry picked from commit e2bc59dfec55f10d4ea49ef6c8d5da21183029e1)

doc: Change 'ReST' to 'REST' in doc/radosgw/layout.rst

In doc/radosgw/layout.rst, 'ReST' is not spelled properly, so we change it to 'REST'.

Signed-off-by: wangyingbin <wangyingbin@inspur.com>
(cherry picked from commit 3acbed815abef1796e699ba98fb4d0b1b5dfbdb4)

doc/ceph-volume: refine "prepare" top matter

This commit refines the top matter in the
doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 233af44cb4d4b0a83a1f32b893febb49540aefc3)

Merge pull request #48645 from zdover23/wip-doc-2022-10-28-backport-48644-to-quincy

quincy: doc/ceph-volume: add A. D'Atri's suggestions

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: add A. D'Atri's suggestions

Add Anthony D'Atri's notes on doc/ceph-volume/lvm/prepare.rst as
expressed in https://github.com/ceph/ceph/pull/48634.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 98b5330b1a170547e7b166da5a489872cfc7e352)

Merge pull request #48636 from zdover23/wip-doc-2022-10-27-backport-48627-to-quincy

quincy: doc/ceph-volume: refine "filestore" section

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #48634 from zdover23/wip-doc-2022-10-27-backport-48625-to-quincy

quincy: doc/ceph-volume: refine "bluestore" section

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: refine "filestore" section

This commit refines the "filestore" section in the doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 447967ea0d9b11314d1797f525ab5a11bdeea59e)

doc/ceph-volume: refine "bluestore" section

This commit refines the "bluestore" section in the
doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 31db0c227d88d0227a935c61ed099d0daf4f02cd)

Merge pull request #48414 from vshankar/tr-57717

quincy: client: fix incorrectly showing the .snap size for stat

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #48611 from zdover23/wip-doc-2022-10-25-backport-48610-to-quincy

quincy: doc/cephadm: s/ssh/SSH/ in doc/cephadm (complete)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/cephadm: s/ssh/SSH/ in doc/cephadm (complete)

This PR alters "ssh" to "SSH" in the text (that is, not in
commands) every location in the doc/cephadm/ directory where
"ssh" should be "SSH".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 5c217c1de57ddcdda19bd83993a26d2f257a03b7)

Merge pull request #48606 from zdover23/wip-doc-2022-10-24-backport-48605-to-quincy

quincy: doc/cephadm: improve front matter

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48603 from zdover23/wip-doc-2022-10-24-backport-48600-to-quincy

quincy: doc/cephadm: clean colons in host-management.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48601 from zdover23/wip-doc-2022-10-24-backport-48599-to-quincy

quincy: doc/cephadm: s/ssh/SSH/ in troubleshooting.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: improve front matter

- I fixed a sentence that was missing a verb.
- I linked to the Ceph-specific Rook instructions.
- I removed the word "GitHub", because after adding the
  Rook instructions it made the sentence false.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 608b1bdd42f1da75b43584fa45586575ccef0290)

doc/cephadm: clean colons in host-management.rst

Two lines in host-management.rst ended with both colons and
full stops (periods), causing a kind of punctuational turf
war. This commit removes the full stops.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 495182b84e86babdba38c184d489f118e8881e2c)

doc/cephadm: s/ssh/SSH/ in troubleshooting.rst

Two places in the troubleshooting.rst file had "ssh" in
the text when it should have been "SSH".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 384e7093c9808b38765d70549d754eafbd47742c)

Merge pull request #48594 from zdover23/wip-doc-2022-10-23-backport-48593-to-quincy

quincy: doc/cephadm: update install.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/cephadm: update install.rst

This commit addresses https://github.com/ceph/ceph/pull/43250,
which has remained unmerged for thirteen months. The issues
raised in that PR are addressed here.

This commit contributes to the simplification of the procedure
that explains how to install cephadm. More remains to be done
on this page, but the old PR had to be dealt with first.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c8f01d3a32b889a0f3b68f619bfed36f6579c28b)

Merge pull request #48268 from vshankar/tr-57193

quincy: fsmap: switch to using iterator based loop

Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge pull request #48589 from zdover23/wip-doc-2022-10-22-backport-48587-to-quincy

quincy: doc/cephadm: add prompts to host-management.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/cephadm: add prompts to host-management.rst

This PR adds unselectable prompts to host-management.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 0ff9e4b9041039160b2d77ce48e29a6fedfaa469)

Merge pull request #48327 from kotreshhr/wip-57719-quincy

quincy: qa: Fix test_subvolume_group_ls_filter_internal_directories

Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge pull request #48321 from kamoltat/wip-ksirivad-backport-quincy-44993

quincy: mon/Elector: Added sanity check when pinging a peer monitor

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #48458 from k0ste/wip-57843-quincy

quincy: rbd: device map/unmap --namespace handling fixes

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #48058 from tserong/wip-57505-quincy

quincy: ceph.spec.in: Use gcc11-c++ on openSUSE Leap 15.x

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #48579 from zdover23/wip-doc-2022-10-21-backport-48577-to-quincy

quincy: doc/radosgw: refine "notifications" and "events"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: refine "notifications" and "events"

This commit refines the English in the "Notifications"
and "Events" sections of the notifications.rst page
(the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit b1e589343df4a113d773c4091705e74cd489a1e7)

Merge pull request #48573 from zdover23/wip-doc-2022-10-21-backport-48572-to-quincy

quincy: doc/cephadm: refine "os tuning" in h. management

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/cephadm: refine "os tuning" in h. management

This commit refines the English in the "OS Tuning Profiles" section of
the "Host Management" page of the cephadm documentation. This commit is
made separately from but in anticipation of a forthcoming commit that
corrects technical (non-grammatical) errors.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 17b50dc1bfeb67132e793f9d8509354a4e29c5b1)

Merge pull request #48570 from zdover23/wip-doc-2022-10-21-quincy-remove-deduplication

quincy: doc/dev: remove deduplication.rst from quincy

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: remove deduplication.rst from quincy

This PR undoes the backporting of https://github.com/ceph/ceph/pull/46089
to the Quincy branch, which backporting was done in
https://github.com/ceph/ceph/pull/48567. Deduplication does not exist
in the quincy branch, so I shouldn't have backported it.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48567 from zdover23/wip-doc-2022-10-21-backport-46089-to-quincy

quincy: doc/dev: add explanation of how to use deduplication

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: add explanation of how to use deduplication

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
(cherry picked from commit 72c695780c8361f81b8135899d9060811873dcb4)

Merge pull request #48560 from zdover23/wip-doc-2022-10-19-backport-48556-to-quincy

quincy: doc/radosgw: refine "bucket notifications"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: refine "bucket notifications"

This commit refines the English in the "Bucket Notifications REST API"
section of the notifications.rst page (the "Bucket Notifications" page).

Co-author: Cole Mitchell <cole.mitchell@gmail.com>

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit a69dd10ddbbf952cc208f35c0ea04d644b582794)

Merge pull request #48519 from ceph/quincy-release

v17.2.5

Merge pull request #48440 from aaSharma14/wip-57841-quincy

 quincy: mgr/dashboard: Unable to change rgw subuser permission

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #48441 from aaSharma14/wip-57835-quincy

quincy: mgr/dashboard: add server side encryption to rgw/s3

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #48535 from zdover23/wip-doc-2022-10-19-backport-48512-to-quincy

quincy: doc/radowsgw: add prompts to notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radowsgw: add prompts to notifications.rst

This PR adds unselectable prompts to doc/radosgw/notifications.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 075ec4cd1435ab5f4c16bbc841aee60419724914)

Merge pull request #48529 from zdover23/wip-doc-2022-10-19-backport-48511-to-quincy

quincy: doc/radosgw: refine "notification reliability"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: refine "notification reliability"

This commit refines the English in the "Notification Reliability"
section of the notifications.rst page (the "Bucket Notifications"
page). I have also added signposting structure.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Yuval Lifshitz <ylifshit@redhat.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 8f7b57f5cec475f8977e61707b287884903c1bb5)

17.2.5

Signed-off-by: Ceph Release Team <ceph-maintainers@ceph.io>

mgr/telemetry: handle daemons with complex ids

Treating daemons as `<daemon_type>.x` caused a crash
in the Telemetry module since the current method does not cover a case
where a daemon id is more complex, i.e. `<daemon_type>.x.y`.

When we parse the daemon type and daemon id, we should
split it into a maximum of two pieces rather than splitting
it by every `.` character. Specifying `1` in the Python
.split() function will limit the split to a maximum of two items.

Fixes: https://tracker.ceph.com/issues/57700
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 97833a6a81fed7f868e1d544816cfbdf254fdb43)

ceph-volume: fix regression in activate

bea9f4b643c introduced a regression that makes the activate process
take a very long time to complete.
`_get_bluestore_info()` which calls `ceph-bluestore-tool` binary via
subprocess is called in an exponential way while this is not needed.

Fixes: https://tracker.ceph.com/issues/57627
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 8d7423c3e75afbe111c91e699ef3cb1c0beee61b)

mgr/rook: fix error when trying to get the list of nfs services

Resolves: https://tracker.ceph.com/issues/55605

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
(cherry picked from commit 1532de124a99ab0e0820850e1c2739689ccb09f0)

Revert "osd/PeeringState: fix missed `recheck_readable` from laggy"

This reverts commit c71ee14cdbcc499d0ccaa84f4714ad5f29821f40.

This commit caused a regression in the rados suite, as evidenced by:

- with the commit:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_15:11:39-rados-quincy-release-distro-default-smithi/

- with the commit reverted:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_17:02:02-rados-wip-lflores-testing-quincy-release-distro-default-smithi/

Fixes: https://tracker.ceph.com/issues/57546
Signed-off-by: Laura Flores <lflores@redhat.com>

Revert "osd/PeeringState: proc_lease_ack break once found from OSD"

This reverts commit 0d07b406dc2f854363f7ae9b970e980400f4f03e.

This commit caused a regression in the rados suite, as evidenced by:

- with the commit:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_15:11:39-rados-quincy-release-distro-default-smithi/

- with the commit reverted:
http://pulpito.front.sepia.ceph.com/lflores-2022-09-14_17:02:02-rados-wip-lflores-testing-quincy-release-distro-default-smithi/

Fixes: https://tracker.ceph.com/issues/57546
Signed-off-by: Laura Flores <lflores@redhat.com>

Merge pull request #48386 from idryomov/wip-57766-quincy

quincy: qa/tasks/rbd_fio: bump default to fio 3.32

Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

Merge pull request #48432 from rhcs-dashboard/wip-57828-quincy

quincy: mgr/dashboard: refactor dashboard cephadm e2e tests

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

PendingReleaseNotes: add "rbd device unmap --namespace" note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2df426bd9743309318cc1022853d0033e9c7c4b9)

qa/workunits/rbd-nbd: also test map/unmap with --namespace option

The entire script is using specs, let's cover non-spec syntax as well.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit edfcf4bd6b2de0de124ec850c75feac3d76a863e)

rbd: Removed device_name argument from wnbd unmap

Right now, rbd-wnbd doesn't actually use disk path
identifiers such as "/dev/*" or "\\.\PhysicalDrive*".

So instead of accepting two arguments that are basically
handled more or less the same, we're dropping the device_name
argument and sticking to the image spec.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit 79127642eb66bd878a1bb6fbf402d695af5bac63)

rbd: Moved get_image_or_snap_spec and parse_options to utils

At the moment, there are multiple copies of "get_image_or_snap_spec".

For this reason, we're moving it to Utils.cc so that all backends may
re-use it, also benefiting from the recent pool related fix.

We are also renaming parse_options to append_options_as_args and
changing its type to void

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit efe8ceb5398e52418ae9ac8c3e227d8bd66a65ff)

rbd: Added namespace optarg for rbd device unmap

When executing rbd device unmap, an explicit namespace optarg wasn't available

Fixes: https://tracker.ceph.com/issues/57765
Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
(cherry picked from commit 51ba25c05c8ec93b26fc0b4fe6f3e5b685093244)

Merge pull request #48474 from idryomov/wip-librbd-cmp-write-quincy

quincy: librbd: compare-and-write fixes and vector C API

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #48502 from zdover23/wip-doc-2022-10-17-backport-48501-to-quincy

quincy: doc/radosgw: refine notifications.rst - top part

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: refine notifications.rst - top part

This commit refines the English in the first part of the
notifications.rst page (the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 840a2fe3e30d099459ccee0c4c7735853dad0bb9)

Merge pull request #48499 from zdover23/wip-doc-2022-10-16-backport-48498-to-quincy

quincy: doc/radosgw: update notifications.rst - grammar

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: update notifications.rst - grammar

This commit rewrites a sentence, as requested by
C. Mitchell here:
https://github.com/ceph/ceph/pull/48493/files#r996003812

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 43c37c6721b373af41fe58235b77a917d1961fc1)

Merge pull request #48494 from zdover23/wip-doc-2022-10-15-backport-48493-to-quincy

quincy: doc/radosgw: improve grammar - notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48228 from ivancich/wip-57430-quincy

quincy: rgw: fix bug where variable referenced after data moved out

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>

doc/radosgw: improve grammar - notifications.rst

This commit makes the changes suggested by C. Mitchell in
https://github.com/ceph/ceph/pull/48486.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 98a4d938e561eb924950535c1a4fe1d6b02849c5)

Merge pull request #48487 from zdover23/wip-doc-2022-10-14-backport-48486-to-quincy

quincy: doc/radosgw: add push_endpoint for rabbitmq

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: add push_endpoint for rabbitmq

This commit directs users of rabbitmq to use "push_endpoint"
(with an underscore) instead of "push-endpoint" (with a hy-
phen). This commit adds a note that contains such a direct-
ive. It does not alter the examples already present in the
text.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit ddf8295438b14ada04d8bb5dfc23402bedc937b8)

Merge pull request #48479 from zdover23/wip-doc-2022-10-13-backport-48463-to-quincy

quincy: doc/dev: add submodule-update link to dev guide

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: add submodule-update link to dev guide

This commit links to the procedure in install/clone-source.rst that
explains how to update submodules.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit e55c3b114be402eae94550c603cf7c028c9b64bf)

PendingReleaseNotes: add rbd_aio_compare_and_writev note

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit bd98a66d03a0d9b0a8d1d6d6c0bd698b5baff60f)

Conflicts:
PendingReleaseNotes [ moved to >=17.2.5 section ]

librbd: add compare-and-write vector C API

Add compare and write vector C API.
Require cmp_iov and write_iov to be the same length.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit 60fd534731487fa15372558f018099df1bca06a3)

test/librbd: various fixups for compare-and-write test cases

- missing EILSEQ asserts in IO and IOWithIOHint
- AioCompletion leak in CompareTooSmall and WriteTooSmall
- skip StripeUnitUnaligned and TooLarge on the PWL cache as it wasn't
  limited by the 512-byte sector limit before and isn't limited by the
  stripe unit limit now

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 093e8237450f561a2267b07231426f86735a2faf)

librbd/cache/pwl: adjust compare-and-write compare substringing

cmp_bl can no longer be shorter than read_bl (i.e. image extent).
This is caught very early at the API level, see commit af96e6dae3f4
("librbd: make C++ cmp&write semantics equal to C API").

However, cmp_bl can still be longer than read_bl and in that case
it should be capped by the image extent length.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 35f3ccb68714f18cc1ff78278fdd5216590cc9bf)

librbd: discard cache state if compare-and-write writes to disk

Otherwise this is obviously broken with rbd_cache_policy = writeback or
rbd_cache_policy = writethrough as the write is done on the OSD, beneath
ObjectCacher.  This went unnoticed because the original (and so far the
only known) compare-and-write user, tcmu-runner rbd driver, disables the
cache altogether.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit ec0fc71cdb579e31ff4e599c43f3918322e70ddf)

PendingReleaseNotes: add rbd compare-and-write notes

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 4ddcb7ff92a51a6fa17887e54fd357bd5dea5f4e)

Conflicts:
PendingReleaseNotes [ moved to >=17.2.5 section ]

librbd: make C++ cmp&write semantics equal to C API

The compare and write C++ API (both sync and async) does not check
compare bufferlist length and executes compare ops of bufferlist length
size, even if (write) "len" is smaller than bufferlist length.
This patch changes this behavior by always issuing compares and
writes of "len" size to match the C API. The bufferlist length
can be greater than "len" for both compare and write but only
"len" bytes are compared and written. If the bufferlist length
is smaller than "len" the call will fail.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit af96e6dae3f4c3e30f91cb26d6579a6b5a726862)

librbd: remove cmp&write sector size restriction

This patch removes the compare and write max sector size len
restriction. We can allow up to stripe unit size accesses if
the access is aligned properly.
To allow larger size compare and write requests in the
journal we split the buffers like we do for writes now.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit d80cff0dd665d660cd545c5a66d265b6bf732c73)

librbd: new cmp&write C API tests

Test correct mismatch offset is returned.
Test no data is written when compare fails.
Test correct data is written when compare succeeds.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
(cherry picked from commit 3eb7ac6aeb3d11911bcf1c393ddee8913414bef7)

Merge pull request #48464 from zdover23/wip-doc-2022-10-15-backport-48460-to-quincy

quincy: doc/install: improve updating submodules procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/install: improve updating submodules procedure

This commit beefs up the "Updating Submodules" procedure,
which (prior to this commit) was quite brief.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 9382a90342f96cabab4b7caf816d9381f77e7f46)

Merge pull request #48219 from s0nea/wip-57661-quincy

quincy: mgr/dashboard: add option to resolve ip addr

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #48340 from rhcs-dashboard/fix-fedora-url-quincy

quincy: mgr/dashboard: Fix broken Fedora image URL

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: zmc <NOT@FOUND>

Merge pull request #48447 from zdover23/wip-doc-2022-10-12-backport-48446-to-quincy

quincy: doc/glossary: add "ceph monitor" entry

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/glossary: add "ceph monitor" entry

This commit adds information to the "ceph monitor" entry in
glossary.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 8f4ad5dc9d171c805f061b937ad1110b53255fa6)

Merge pull request #48433 from rhcs-dashboard/wip-57831-quincy

quincy: mgr/dashboard: fix weird data in osd details

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #48430 from zdover23/wip-doc-2022-10-11-backport-48429-to-quincy

quincy: doc/security: improve grammar in CVE-2022-0670.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #48438 from rhcs-dashboard/wip-57838-quincy

quincy: mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: auto-coloring-badges-component

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 29f510a522b2694903d095ac0ec45ee23c474121)