]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agorgw: add 'inline_data' zone placement info option 48711/head
Cory Snyder [Wed, 2 Nov 2022 20:06:23 +0000 (20:06 +0000)]
rgw: add 'inline_data' zone placement info option

Adds a new RGW zone placement info option to control whether
an object's first data chunk is placed in the head object.
This allows admins to make a tradeoff between optimizing for
PUT/GET performance vs. DELETE performance for some cluster
configurations.

Fixes: https://tracker.ceph.com/issues/57965
Signed-off-by: Cory Snyder <csnyder@iland.com>
2 years agoMerge pull request #49325 from liu-chunmei/crimson-reactor_utilization
Yingxin [Mon, 12 Dec 2022 07:43:12 +0000 (15:43 +0800)]
Merge pull request #49325 from liu-chunmei/crimson-reactor_utilization

crimson/osd: dump each shard seastar metrics

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #49383 from zdover23/wip-doc-2022-12-12-rados-user-management...
colemitchell [Mon, 12 Dec 2022 04:32:46 +0000 (23:32 -0500)]
Merge pull request #49383 from zdover23/wip-doc-2022-12-12-rados-user-management-prompts

doc/rados: add prompts to user-management.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rados: add prompts to user-management.rst 49383/head
Zac Dover [Mon, 12 Dec 2022 04:22:40 +0000 (14:22 +1000)]
doc/rados: add prompts to user-management.rst

Add unselectable prompts to doc/rados/operations/user-management.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48545 from ronen-fr/wip-rf-slow-replica
Ronen Friedman [Sun, 11 Dec 2022 17:05:34 +0000 (19:05 +0200)]
Merge pull request #48545 from ronen-fr/wip-rf-slow-replica

osd/scrub: report replicas slow to respond to scrub requests

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoosd/scrub: modifying some tests to ignore late replicas 48545/head
Ronen Friedman [Thu, 8 Dec 2022 17:58:19 +0000 (19:58 +0200)]
osd/scrub: modifying some tests to ignore late replicas

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoosd/scrub: earlier response to interval changes
Ronen Friedman [Mon, 24 Oct 2022 13:35:52 +0000 (16:35 +0300)]
osd/scrub: earlier response to interval changes

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoosd/scrub: minor logging changes
Ronen Friedman [Mon, 24 Oct 2022 13:33:23 +0000 (16:33 +0300)]
osd/scrub: minor logging changes

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoosd/scrub: report replicas slow to repond to scrub requests
Ronen Friedman [Mon, 24 Jan 2022 13:19:01 +0000 (13:19 +0000)]
osd/scrub: report replicas slow to repond to scrub requests

Implemented timeouts:

1: Slow-Secondary Warning:

Once at least half of the replicas have accepted the reservation, we
start reporting any secondary that takes too long (more than <conf>
milliseconds after the previous response received) to respond to the reservation
request.
(Why? because we have encountered real-life situations where a specific
OSD was systematically very slow to respond (e.g. 5 seconds in one case) to
the reservation requests, slowing the scrub process to a crawl).

2: Reservation Process Timeout:

We now limit the total time the primary waits for the replicas to
respond to the reservation request. If we do not get all the responses
(either Grant or Reject) within <conf> milliseconds, we give up and release all the
reservations we have acquired so far.
(Why? because we have encountered instances where a reservation request
was lost - either due to a bug or due to a network issue.)

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #49376 from zdover23/wip-doc-2022-12-11-install-clone-source-fix...
colemitchell [Sat, 10 Dec 2022 21:31:53 +0000 (16:31 -0500)]
Merge pull request #49376 from zdover23/wip-doc-2022-12-11-install-clone-source-fix-git-command

doc/install: update clone-source.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/install: update clone-source.rst 49376/head
Zac Dover [Sat, 10 Dec 2022 20:25:13 +0000 (06:25 +1000)]
doc/install: update clone-source.rst

Beef up clone-source.rst. Repair semantics. Add internal references. Fix
a broken "git submodule foreach git clean -fdx" command.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49375 from adk3798/partial-revert-49359
Kefu Chai [Sat, 10 Dec 2022 15:57:01 +0000 (23:57 +0800)]
Merge pull request #49375 from adk3798/partial-revert-49359

pybind/mgr: partial reversion of #49359

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49368 from zdover23/wip-doc-2022-12-10-rados-upmap-prompts
colemitchell [Sat, 10 Dec 2022 04:42:48 +0000 (23:42 -0500)]
Merge pull request #49368 from zdover23/wip-doc-2022-12-10-rados-upmap-prompts

doc/rados: add prompts to upmap.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49367 from zdover23/wip-doc-2022-12-10-rados-stretch-mode-prompts
colemitchell [Sat, 10 Dec 2022 04:42:12 +0000 (23:42 -0500)]
Merge pull request #49367 from zdover23/wip-doc-2022-12-10-rados-stretch-mode-prompts

doc/rados: add prompts to stretch-mode.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rados: add prompts to upmap.rst 49368/head
Zac Dover [Sat, 10 Dec 2022 04:34:46 +0000 (14:34 +1000)]
doc/rados: add prompts to upmap.rst

Add unselectable prompts to doc/rados/operations/upmap.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to stretch-mode.rst 49367/head
Zac Dover [Sat, 10 Dec 2022 04:15:45 +0000 (14:15 +1000)]
doc/rados: add prompts to stretch-mode.rst

Add unselectable prompts to doc/rados/operations/stretch-mode.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49364 from zdover23/wip-doc-2022-12-10-rbd-rados-rbd-retrieving...
colemitchell [Sat, 10 Dec 2022 03:31:57 +0000 (22:31 -0500)]
Merge pull request #49364 from zdover23/wip-doc-2022-12-10-rbd-rados-rbd-retrieving-image-information-typo

doc/rbd: remove typo and ill-formed command

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rbd: remove typo and ill-formed command 49364/head
Zac Dover [Sat, 10 Dec 2022 03:20:17 +0000 (13:20 +1000)]
doc/rbd: remove typo and ill-formed command

Ingest Ilya Dryomov's comments here https://github.com/ceph/ceph/pull/49340/files#r1044365857

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agopybind/mgr: partial reversion of #49359 49375/head
Adam King [Fri, 9 Dec 2022 19:20:47 +0000 (14:20 -0500)]
pybind/mgr: partial reversion of #49359

When creating #49359 I was testing on an outdated
branch and didn't realize part of what I was fixing
had already been fixed in #49321. Basically ended up
changing what a variable "mypy_args" is set to but that
variable is no longer being used. It has no actual effect
but we should remove the extraneous code.

Signed-off-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #49359 from adk3798/mypy-args
Adam King [Fri, 9 Dec 2022 18:19:10 +0000 (13:19 -0500)]
Merge pull request #49359 from adk3798/mypy-args

 mgr/pybind: fix mypy and autopep8 arg parsing

Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #48626 from qiuxinyidian/rgw-coroutine
Casey Bodley [Fri, 9 Dec 2022 17:56:28 +0000 (12:56 -0500)]
Merge pull request #48626 from qiuxinyidian/rgw-coroutine

rgw: modify multisite coroutine stack block

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #48559 from baergj/fix-listbuckets-truncation-main
Casey Bodley [Fri, 9 Dec 2022 17:55:21 +0000 (12:55 -0500)]
Merge pull request #48559 from baergj/fix-listbuckets-truncation-main

rgw: Fix truncated ListBuckets response.

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agoMerge pull request #48554 from giubacc/rgw_dns_name_multivalue
Casey Bodley [Fri, 9 Dec 2022 17:54:13 +0000 (12:54 -0500)]
Merge pull request #48554 from giubacc/rgw_dns_name_multivalue

rgw: add multivalue support to rgw_dns_name config option

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48390 from cbodley/wip-57784
Casey Bodley [Fri, 9 Dec 2022 17:52:32 +0000 (12:52 -0500)]
Merge pull request #48390 from cbodley/wip-57784

rgw: beast frontend checks for local_endpoint() errors

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #45818 from cbodley/wip-system-rapidjson
Casey Bodley [Fri, 9 Dec 2022 17:52:07 +0000 (12:52 -0500)]
Merge pull request #45818 from cbodley/wip-system-rapidjson

cmake: use rapidjson headers from s3select's submodule

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49336 from dang/wip-dang-zipper-driver
Daniel Gryniewicz [Fri, 9 Dec 2022 17:41:13 +0000 (12:41 -0500)]
Merge pull request #49336 from dang/wip-dang-zipper-driver

Store -> Driver rename + header cleanup

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agopybind/mgr: fix tox autopep8 args 49359/head
Adam King [Fri, 9 Dec 2022 16:25:01 +0000 (11:25 -0500)]
pybind/mgr: fix tox autopep8 args

Similar to mypy, we now need a backslash to signal
a newline doesn't mean to start a new command

Signed-off-by: Adam King <adking@redhat.com>
2 years agomgr/pybind: fix mypy arg parsing
Adam King [Fri, 9 Dec 2022 16:10:36 +0000 (11:10 -0500)]
mgr/pybind: fix mypy arg parsing

On the new tox version it is treating each line as a new command
so it will do something like "mypy --config-file=../../mypy.ini"
as one command and then "-m balancer" as a totally separate command.
The first one immediately fails as it doesn't include any modules
to test. Adding backslashes to the ends of the lines gets it to
handle the lines as one long command

Signed-off-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #48691 from zhscn/wip-reserve
Yingxin [Fri, 9 Dec 2022 10:01:52 +0000 (18:01 +0800)]
Merge pull request #48691 from zhscn/wip-reserve

crimson/os/seastore: correct the behavior of reserving space

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agoMerge pull request #47842 from trociny/wip-rbd-rest-api-metadata
Pere Diaz Bou [Fri, 9 Dec 2022 08:34:06 +0000 (09:34 +0100)]
Merge pull request #47842 from trociny/wip-rbd-rest-api-metadata

mgr/dashboard: allow to get/update RBD image metadata via REST API

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #49342 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-removin...
colemitchell [Fri, 9 Dec 2022 06:45:28 +0000 (01:45 -0500)]
Merge pull request #49342 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-removing-a-block-device-semantics

doc/rbd: refine "Removing a Block Device Image"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rbd: refine "Removing a Block Device Image" 49342/head
Zac Dover [Fri, 9 Dec 2022 01:16:27 +0000 (11:16 +1000)]
doc/rbd: refine "Removing a Block Device Image"

Refine and add unselectable prompts to "Removing a Block Device Image"
in doc/rbd/rados-rbd-cmds.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49341 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-resizin...
colemitchell [Fri, 9 Dec 2022 06:17:17 +0000 (01:17 -0500)]
Merge pull request #49341 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-resizing-a-block-device-image-semantics

doc/rbd: refine "Resizing a Block Device Image"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49343 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-restori...
colemitchell [Fri, 9 Dec 2022 06:16:43 +0000 (01:16 -0500)]
Merge pull request #49343 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-restoring-a-block-device-image-semantics

doc/rbd: refine "Restoring a Block Device Image"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rbd: refine "Restoring a Block Device Image" 49343/head
Zac Dover [Fri, 9 Dec 2022 01:31:07 +0000 (11:31 +1000)]
doc/rbd: refine "Restoring a Block Device Image"

Refine and add unselectable prompts to "Restoring a Block Device Image"
in doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rbd: refine "Resizing a Block Device Image" 49341/head
Zac Dover [Fri, 9 Dec 2022 01:02:31 +0000 (11:02 +1000)]
doc/rbd: refine "Resizing a Block Device Image"

Refine and add unselectable prompts to "Resizing a Block Device Image"
in doc/rbd/rados/rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49338 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-creatin...
colemitchell [Fri, 9 Dec 2022 04:50:23 +0000 (23:50 -0500)]
Merge pull request #49338 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-creating-a-block-device-image-semantics

doc/rbd: refine "Creating a Block Device Image"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49340 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-retriev...
colemitchell [Fri, 9 Dec 2022 04:50:07 +0000 (23:50 -0500)]
Merge pull request #49340 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-retrieving-image-information-semantics

doc/rbd: refine "Retrieving Image Information"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49339 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-listing...
colemitchell [Fri, 9 Dec 2022 02:50:05 +0000 (21:50 -0500)]
Merge pull request #49339 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-listing-block-device-images-semantics

doc/rbd: refine "Listing Block Device Images"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rbd: refine "Retrieving Image Information" 49340/head
Zac Dover [Fri, 9 Dec 2022 00:25:55 +0000 (10:25 +1000)]
doc/rbd: refine "Retrieving Image Information"

Refine the text and prompts in "Retrieving Image Information" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49321 from tchaikov/wip-qa-install-with-utf-8
Kefu Chai [Fri, 9 Dec 2022 00:31:05 +0000 (08:31 +0800)]
Merge pull request #49321 from tchaikov/wip-qa-install-with-utf-8

qa: set locale to C.UTF-8 in tox.ini

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
2 years agocrimson/osd: dump each shard seastar metrics 49325/head
chunmei-liu [Thu, 8 Dec 2022 07:48:33 +0000 (23:48 -0800)]
crimson/osd: dump each shard seastar metrics

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agodoc/rbd: refine "Listing Block Device Images" 49339/head
Zac Dover [Fri, 9 Dec 2022 00:21:47 +0000 (10:21 +1000)]
doc/rbd: refine "Listing Block Device Images"

Refine the text and prompts in "Listing Block Device Images" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rbd: refine "Creating a Block Device Image" 49338/head
Zac Dover [Thu, 8 Dec 2022 23:53:14 +0000 (09:53 +1000)]
doc/rbd: refine "Creating a Block Device Image"

Refine the English and prompts in "Creating a Block Device Image" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agorgw: define a hierarchy of basic type headers 49336/head
Matt Benjamin [Sat, 19 Sep 2020 00:59:31 +0000 (20:59 -0400)]
rgw: define a hierarchy of basic type headers

Defines a hierarchy of "simple" data types ensured to be
safe to include in any context above the zipper line, and
also from CLS.

The following headers are currently defined to contain basic
types only:

 rewrite src/rgw/rgw_basic_types.h (70%) // includes the whole hierarchy
 create mode 100644 src/rgw/rgw_acl_types.h
 create mode 100644 src/rgw/rgw_bucket_types.h
 create mode 100644 src/rgw/rgw_obj_types.h
 create mode 100644 src/rgw/rgw_placement_types.h
 create mode 100644 src/rgw/rgw_pool_types.h
 create mode 100644 src/rgw/rgw_quota_types.h
 create mode 100644 src/rgw/rgw_user_types.h
 create mode 100644 src/rgw/rgw_zone_types.h

This commit consolidates the following original commits:

* rgw: move RGWUploadPartInfo to rgw_basic_types.{h,cc}
* rgw: move rgw_obj_key to rgw_basic_types.{h,cc}
* rgw: move rgw_placement_rule to rgw_basic_types.{h,cc}
* rgw: move rgw_obj to rgw_basic_types.{h,cc}
* rgw: include rgw_compression_types.h in rgw_basic_types.{h,cc}
* rgw: move rgw_raw_obj to rgw_basic_types.{h,cc}
* rgw: rgw_multi.h: remove unused RGWMPObj forward decl

and the following cleanups from review:

* rgw: remove stray comments
* rgw: move rgw_obj_manifest.h inclusion to top of rgw_basic_types.h
* rgw: nit: indentation
* rgw: remove this line
* rgw: move rgw_bucket_shard to rgw_bucket_types.h, cleanup
* rgw: fix rgw_quota.h

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2 years agorgw: setup for inclusion of rgw_basic_types in rgw cls
Matt Benjamin [Sat, 19 Sep 2020 00:17:46 +0000 (20:17 -0400)]
rgw: setup for inclusion of rgw_basic_types in rgw cls

In downstream 4.1 version this change moved rgw_pool, rgw_bucket,
and some related types--but these have already moved on more
recent branches.

Include rgw_basic_types.h only from cls_rgw_types.h (review).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoRGW - Zipper - move rgw/store to rgw/driver
Daniel Gryniewicz [Fri, 2 Dec 2022 16:34:44 +0000 (11:34 -0500)]
RGW - Zipper - move rgw/store to rgw/driver

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoRGW - Zipper - Rename rgw::sal::Store to rgw::sal::Driver
Daniel Gryniewicz [Tue, 29 Nov 2022 17:31:01 +0000 (12:31 -0500)]
RGW - Zipper - Rename rgw::sal::Store to rgw::sal::Driver

All along, we've had an overload of the term "store".  It was the base
class of the entrypoint, and it was the lowest layer in a stack.  This
renames the base class to Driver.  So, the primary elements of zipper
that to work are now Drivers, and they come in two different flavors:
Filters live in the middle of the stack, and do not need to implement
every API, but pass through instead.  And Stores live a the bottom of
the stack, and must implement the entire API.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2 years agopybind/mgr: do not test with py37 49321/head
Kefu Chai [Thu, 8 Dec 2022 16:49:37 +0000 (00:49 +0800)]
pybind/mgr: do not test with py37

as we always test with ubuntu jammy, which does not provide python3.7:

py37: skipped because could not find python interpreter with spec(s): py37

so there is no point testing with python3.7.

also, in tox v4, it is not able to handle "key = value" anymore, where
value has newlines in it. so we need to find a better way passing
command line options to the test command.

this change partially reverts 2dd86c9e3eca6e14a04a821edf3a654f31da7a21

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocmake: temporarily disable py3 test
Kefu Chai [Thu, 8 Dec 2022 16:32:26 +0000 (00:32 +0800)]
cmake: temporarily disable py3 test

py3 tries to import all python modules to ensure that they are
python3 compatible. but the installation fails on jenkins test node:

  Resolved https://github.com/ceph/teuthology.git to commit 4da97cf64e542f347ec47b7bdbe5eca99759f9b7
  Installing build dependencies: started
  error: subprocess-exited-with-error

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48375 from lbausch/mgr/balancer-fix_end_weekday_being_exclusive
Yuri Weinstein [Thu, 8 Dec 2022 16:49:17 +0000 (08:49 -0800)]
Merge pull request #48375 from lbausch/mgr/balancer-fix_end_weekday_being_exclusive

mgr/balancer: Fix `end_weekday` being exclusive

Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #48318 from gregsfortytwo/wip-17170
Yuri Weinstein [Thu, 8 Dec 2022 16:48:23 +0000 (08:48 -0800)]
Merge pull request #48318 from gregsfortytwo/wip-17170

osd: mds: suggest clock skew when failing to obtain rotating service keys

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoqa: add pytest to deps of py3 env
Kefu Chai [Thu, 8 Dec 2022 14:34:38 +0000 (22:34 +0800)]
qa: add pytest to deps of py3 env

otherwise it is mising when running test, and we'd have following
failure:

py3: exit 2 (0.00 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/qa> pytest --assert=plain test_import.py

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoqa: set locale to C.UTF-8 in tox.ini
Kefu Chai [Thu, 8 Dec 2022 06:42:42 +0000 (14:42 +0800)]
qa: set locale to C.UTF-8 in tox.ini

as ansible is using UTF-8 encoded characters in the file names, so,
to avoid failures like:

  File "/home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/py3/lib/python3.10/site-packages/pip/_internal/utils/unpacking.py", line 217, in untar_file
    with open(path, "wb") as destfp:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256)

we have to set a locale which is able to handle UTF-8.

see also https://github.com/ceph/teuthology/pull/1671

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49236 from yuvalif/wip-yuval-missing-init
Casey Bodley [Thu, 8 Dec 2022 14:24:22 +0000 (09:24 -0500)]
Merge pull request #49236 from yuvalif/wip-yuval-missing-init

rgw/notification: initialize member in reservation ctor

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #49290 from inspur-wyq/wip-rgw-svc-doc
Casey Bodley [Thu, 8 Dec 2022 14:04:25 +0000 (09:04 -0500)]
Merge pull request #49290 from inspur-wyq/wip-rgw-svc-doc

src/rgw/services/svc_finisher.cc: fix typos

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49322 from tchaikov/wip-allowlist_externals
Kefu Chai [Thu, 8 Dec 2022 13:33:38 +0000 (21:33 +0800)]
Merge pull request #49322 from tchaikov/wip-allowlist_externals

*: s/whitelist_externals/allowlist_externals/

Reviewed-by: Adam King <adking@redhat.com>
2 years agopybind/mgr: drop cython from requires 49322/head
Kefu Chai [Thu, 8 Dec 2022 10:25:20 +0000 (18:25 +0800)]
pybind/mgr: drop cython from requires

cython is not required for running tox commands.

this should address the test failure like:

ROOT: will run in automatically provisioned tox, host /home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-virtualenv/bin/python3.10 is missing [requires (has)]: cython

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocephadm: drop cython from requires
Kefu Chai [Thu, 8 Dec 2022 10:23:32 +0000 (18:23 +0800)]
cephadm: drop cython from requires

cython is not required for launching the tox environment.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years ago*: s/whitelist_externals/allowlist_externals/
Kefu Chai [Thu, 8 Dec 2022 06:53:33 +0000 (14:53 +0800)]
*: s/whitelist_externals/allowlist_externals/

as allowlist_externals was introduced in
tox v4.0. see
https://github.com/tox-dev/tox/commit/5e33fda1a40ffb4973de3d607a572891eb3cb2d2 , but
this option was backported to 3.18 as an alias of whitelist_externals, so we don't need
to specify the minversion to 4.0 in this change.

as we started using tox 4.0 and up (v4.0.2 in specific). tox complains
and fails like:

alerts-lint: failed with promtool is not allowed, use allowlist_externals to allow it
  alerts-lint: FAIL code 1 (9.25 seconds)

see https://tox.wiki/en/latest/faq.html#tox-4-removed-tox-ini-keys
and https://tox.wiki/en/latest/config.html#allowlist_externals

it'd be nice to use a more inclusive language also. so, in this change,
s/whitelist_externals/allowlist_externals/ in all tox.ini in this
project.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49306 from zdover23/wip-doc-2022-12-08-rbd-rados-rbd-cmds-create...
zdover23 [Thu, 8 Dec 2022 05:21:24 +0000 (15:21 +1000)]
Merge pull request #49306 from zdover23/wip-doc-2022-12-08-rbd-rados-rbd-cmds-create-a-block-device-user-semantics

doc/rbd: refine "Create a Block Device User"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49288 from BryceCao/wip-update-doc-ubuntu-deps-install
Anthony D'Atri [Thu, 8 Dec 2022 04:24:42 +0000 (23:24 -0500)]
Merge pull request #49288 from BryceCao/wip-update-doc-ubuntu-deps-install

doc/start: update "apt install" command in documenting-ceph.rst

2 years agodoc/start: update "apt install" command in documenting-ceph.rst 49288/head
cao.leilc [Wed, 7 Dec 2022 03:16:36 +0000 (11:16 +0800)]
doc/start: update "apt install" command in documenting-ceph.rst

Signed-off-by: caolei <cao.leilc@inspur.com>
2 years agodoc/rbd: refine "Create a Block Device User" 49306/head
Zac Dover [Wed, 7 Dec 2022 14:43:31 +0000 (00:43 +1000)]
doc/rbd: refine "Create a Block Device User"

Refine "Create a Block Device User", after suggestions made by Ilya
Dryomov in https://github.com/ceph/ceph/pull/49301#pullrequestreview-1208285685

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48943 from yaarith/fix-telemetry-ident
Laura Flores [Wed, 7 Dec 2022 22:40:03 +0000 (16:40 -0600)]
Merge pull request #48943 from yaarith/fix-telemetry-ident

qa/workunits: identify ceph test clusters

2 years agoMerge pull request #49121 from tchaikov/wip-cmake-cares
Casey Bodley [Wed, 7 Dec 2022 20:07:27 +0000 (15:07 -0500)]
Merge pull request #49121 from tchaikov/wip-cmake-cares

cmake: add c-ares::cares as a global visible library

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48679 from cfsnyder/wip-rgw-multi-obj-del-perf
Casey Bodley [Wed, 7 Dec 2022 19:09:10 +0000 (14:09 -0500)]
Merge pull request #48679 from cfsnyder/wip-rgw-multi-obj-del-perf

rgw: concurrency for multi object deletes

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48265 from pdvian/wip-fix-mmgrupdate
Yuri Weinstein [Wed, 7 Dec 2022 18:52:58 +0000 (10:52 -0800)]
Merge pull request #48265 from pdvian/wip-fix-mmgrupdate

mon: Fix condition to check for ceph version mismatch

Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #48138 from sseshasa/wip-fix-osd-bench
Yuri Weinstein [Wed, 7 Dec 2022 18:52:32 +0000 (10:52 -0800)]
Merge pull request #48138 from sseshasa/wip-fix-osd-bench

osd: Randomize osd bench buffer data before submitting to objectstore

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #48136 from shreyanshjain7174/fix_versions
Yuri Weinstein [Wed, 7 Dec 2022 18:49:37 +0000 (10:49 -0800)]
Merge pull request #48136 from shreyanshjain7174/fix_versions

 mon: remove empty list entries from ceph versions

Reviewed-by: Prashant D <pdhange@redhat.com>
2 years agoMerge pull request #49282 from zdover23/wip-doc-2022-12-06-rbd-rados-rbd-cmds-create...
zdover23 [Wed, 7 Dec 2022 16:51:20 +0000 (02:51 +1000)]
Merge pull request #49282 from zdover23/wip-doc-2022-12-06-rbd-rados-rbd-cmds-create-a-block-device-pool-semantics

doc/rbd: refine "Create a Block Device Pool"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #49293 from BryceCao/wip-fix-rgw.yaml.in-spelling-mistake
Casey Bodley [Wed, 7 Dec 2022 16:30:26 +0000 (11:30 -0500)]
Merge pull request #49293 from BryceCao/wip-fix-rgw.yaml.in-spelling-mistake

src/common/options/rgw.yaml.in: fix spelling mistake

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #47708 from rkachach/fix_issue_57160
Adam King [Wed, 7 Dec 2022 15:43:44 +0000 (10:43 -0500)]
Merge pull request #47708 from rkachach/fix_issue_57160

mgr/rgw: adding support for rgw multisite

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 years agoMerge pull request #48074 from adk3798/client-removal-fixing
Adam King [Wed, 7 Dec 2022 15:37:31 +0000 (10:37 -0500)]
Merge pull request #48074 from adk3798/client-removal-fixing

mgr/cephadm: write client files after applying services

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agoMerge pull request #48213 from adk3798/migration-too-high
Adam King [Wed, 7 Dec 2022 15:33:43 +0000 (10:33 -0500)]
Merge pull request #48213 from adk3798/migration-too-high

mgr/cephadm: don't say migration in progress if migration current > migration last

Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agoMerge pull request #48304 from rhcs-dashboard/iscsi-default-user-pwd
Adam King [Wed, 7 Dec 2022 15:32:07 +0000 (10:32 -0500)]
Merge pull request #48304 from rhcs-dashboard/iscsi-default-user-pwd

mgr/cephadm: iscsi username and password defaults to admin

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #49127 from Matan-B/wip-matanb-c-seq_mode_t
Kefu Chai [Wed, 7 Dec 2022 15:30:44 +0000 (23:30 +0800)]
Merge pull request #49127 from Matan-B/wip-matanb-c-seq_mode_t

crimson/osd/osd_operations/client_request: Remove seq_mode_t

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #48306 from alimaredia/wip-ceph-adm-force-asok-removal
Adam King [Wed, 7 Dec 2022 15:27:25 +0000 (10:27 -0500)]
Merge pull request #48306 from alimaredia/wip-ceph-adm-force-asok-removal

cephadm: force .asok file removal after daemon stoppage

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #48389 from adk3798/staggered-start-update
Adam King [Wed, 7 Dec 2022 15:25:51 +0000 (10:25 -0500)]
Merge pull request #48389 from adk3798/staggered-start-update

qa/cephadm: update staggered upgrade test to use --image when redeploying mgr

Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agoMerge pull request #48391 from adk3798/iscsi-ports
Adam King [Wed, 7 Dec 2022 15:22:42 +0000 (10:22 -0500)]
Merge pull request #48391 from adk3798/iscsi-ports

mgr/cephadm: specify ports for iscsi

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #48489 from rkachach/fix_issue_57816
Adam King [Wed, 7 Dec 2022 15:20:56 +0000 (10:20 -0500)]
Merge pull request #48489 from rkachach/fix_issue_57816

mgr/cephadm: making grafana protocol configurable

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #48507 from rkachach/fix_issue_57876
Adam King [Wed, 7 Dec 2022 15:19:20 +0000 (10:19 -0500)]
Merge pull request #48507 from rkachach/fix_issue_57876

mgr/prometheus: fix module crash when trying to collect OSDs metrics

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #48517 from adk3798/active-mgr-redeploy
Adam King [Wed, 7 Dec 2022 15:16:41 +0000 (10:16 -0500)]
Merge pull request #48517 from adk3798/active-mgr-redeploy

mgr/cephadm: save host cache data after scheduling daemon action

Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agodoc/rbd: refine "Create a Block Device Pool" 49282/head
Zac Dover [Tue, 6 Dec 2022 13:14:49 +0000 (23:14 +1000)]
doc/rbd: refine "Create a Block Device Pool"

Refine the "Create a Block Device Pool" section of
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49283 from zdover23/wip-doc-2022-12-06-rbd-rados-rbd-cmds-create...
zdover23 [Wed, 7 Dec 2022 11:29:10 +0000 (21:29 +1000)]
Merge pull request #49283 from zdover23/wip-doc-2022-12-06-rbd-rados-rbd-cmds-create-a-block-device-user-semantics

doc/rbd: refine "Create a Block Device User"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agocrimson/os/seastore: update assertion about reservation 48691/head
Zhang Song [Tue, 6 Dec 2022 07:38:36 +0000 (15:38 +0800)]
crimson/os/seastore: update assertion about reservation

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore: allow transactions conflict on backref extents
Zhang Song [Tue, 6 Dec 2022 07:37:35 +0000 (15:37 +0800)]
crimson/os/seastore: allow transactions conflict on backref extents

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore/EPM: parallelise trim_alloc and trim_dirty
Zhang Song [Tue, 6 Dec 2022 07:36:48 +0000 (15:36 +0800)]
crimson/os/seastore/EPM: parallelise trim_alloc and trim_dirty

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore: introduce try_reserve
Zhang Song [Tue, 6 Dec 2022 07:36:00 +0000 (15:36 +0800)]
crimson/os/seastore: introduce try_reserve

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore: reserve space before writing delayed extents
Zhang Song [Tue, 6 Dec 2022 07:34:07 +0000 (15:34 +0800)]
crimson/os/seastore: reserve space before writing delayed extents

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore/EPM: divide delayed_alloc_or_ool_write into two steps
Zhang Song [Tue, 6 Dec 2022 06:51:19 +0000 (14:51 +0800)]
crimson/os/seastore/EPM: divide delayed_alloc_or_ool_write into two steps

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore: simplify update_mappings
Zhang Song [Tue, 6 Dec 2022 06:48:42 +0000 (14:48 +0800)]
crimson/os/seastore: simplify update_mappings

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore: add prior_poffset field in CachedExtent
Zhang Song [Tue, 6 Dec 2022 06:48:02 +0000 (14:48 +0800)]
crimson/os/seastore: add prior_poffset field in CachedExtent

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agosrc/common/options/rgw.yaml.in: fix spelling mistake 49293/head
cao.leilc [Wed, 7 Dec 2022 06:11:56 +0000 (14:11 +0800)]
src/common/options/rgw.yaml.in: fix spelling mistake

Signed-off-by: caolei <cao.leilc@inspur.com>
2 years agoMerge pull request #49155 from joscollin/wip-cephfs-top-doc-update-filters
Venky Shankar [Wed, 7 Dec 2022 04:35:10 +0000 (10:05 +0530)]
Merge pull request #49155 from joscollin/wip-cephfs-top-doc-update-filters

doc: updated doc for Filters

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoMerge pull request #49257 from ktdreyer/doc-createfs-syntax
Venky Shankar [Wed, 7 Dec 2022 04:29:50 +0000 (09:59 +0530)]
Merge pull request #49257 from ktdreyer/doc-createfs-syntax

doc/cephfs: monospace "ceph fs set-default" command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rbd: refine "Create a Block Device User" 49283/head
Zac Dover [Tue, 6 Dec 2022 14:20:24 +0000 (00:20 +1000)]
doc/rbd: refine "Create a Block Device User"

Refine "Create a Block Device User" in doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agosrc/rgw/services/svc_finisher.cc: fix typos 49290/head
wangyunqing [Wed, 7 Dec 2022 03:48:47 +0000 (11:48 +0800)]
src/rgw/services/svc_finisher.cc: fix typos

Signed-off-by: wangyunqing <wangyunqing@inspur.com>
2 years agodoc/cephfs: monospace "ceph fs set-default" command 49257/head
Ken Dreyer [Mon, 5 Dec 2022 17:31:42 +0000 (12:31 -0500)]
doc/cephfs: monospace "ceph fs set-default" command

Fix the rst syntax here to make this command match everything else.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
2 years agoMerge pull request #48296 from Matan-B/wip-matanb-no-history-cleanup
Yuri Weinstein [Tue, 6 Dec 2022 19:37:47 +0000 (11:37 -0800)]
Merge pull request #48296 from Matan-B/wip-matanb-no-history-cleanup

osd/OSD.cc: handle_fast_pg_create cleanup

Reviewed-by: Samuel Just <sjust@redhat.com>