]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Jos Collin [Tue, 8 Nov 2022 14:30:55 +0000 (20:00 +0530)]
Revert "doc: update cephfs-top.png"
This reverts commit
2233b68fe0efa3666f90296fd5df249a3f56bbe5 .
Signed-off-by: Jos Collin <jcollin@redhat.com>
Jos Collin [Tue, 8 Nov 2022 14:30:30 +0000 (20:00 +0530)]
Revert "cephfs-top: add version in header"
This reverts commit
7d2deda2b212a4b5c1b81737321fb4ac2ef10347 .
Signed-off-by: Jos Collin <jcollin@redhat.com>
Jos Collin [Sat, 5 Nov 2022 02:29:28 +0000 (07:59 +0530)]
Merge pull request #48666 from joscollin/wip-cephfs-top-version
cephfs-top: add version in header
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Laura Flores [Sat, 5 Nov 2022 01:00:30 +0000 (20:00 -0500)]
Merge pull request #48291 from ljflores/wip-upgrade-telemetry
Jos Collin [Fri, 4 Nov 2022 04:41:19 +0000 (10:11 +0530)]
doc: update cephfs-top.png
Signed-off-by: Jos Collin <jcollin@redhat.com>
Jos Collin [Thu, 27 Oct 2022 06:42:41 +0000 (12:12 +0530)]
cephfs-top: add version in header
Signed-off-by: Jos Collin <jcollin@redhat.com>
zdover23 [Fri, 4 Nov 2022 17:25:54 +0000 (03:25 +1000)]
Merge pull request #48739 from zdover23/wip-doc-2022-11-05-dev-guide-lone-sentence
doc/dev: improve lone sentence
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Fri, 4 Nov 2022 17:11:04 +0000 (03:11 +1000)]
doc/dev: improve lone sentence
Improve a lone sentence to make it less ambiguous, and at the same
time permit the testing of a script.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
zdover23 [Fri, 4 Nov 2022 16:55:32 +0000 (02:55 +1000)]
Merge pull request #48736 from zdover23/wip-doc-2022-11-05-cephadm-host-management-removing-hosts
doc/cephadm: improve lone sentence
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Fri, 4 Nov 2022 16:38:13 +0000 (02:38 +1000)]
doc/cephadm: improve lone sentence
Improve a lone sentence, both to make the cephadm documentation better
and to test a script that is under development.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Fri, 4 Nov 2022 06:31:49 +0000 (14:31 +0800)]
Merge pull request #48716 from tchaikov/crimson-cpuset
crimson/os/alienstore: parse crimson_alien_thread_cpu_cores in cpuset(7)'s list format
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Jos Collin [Fri, 4 Nov 2022 03:24:10 +0000 (08:54 +0530)]
Merge pull request #48111 from neesingh-rh/feature_55121
cephfs-top: addition of sort feature and limit option
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
zdover23 [Thu, 3 Nov 2022 14:33:02 +0000 (00:33 +1000)]
Merge pull request #48722 from zdover23/wip-doc-2022-11-04-cephadm-index-list-alphabetizing
doc/cephadm: alphabetize external tools list
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
zdover23 [Thu, 3 Nov 2022 14:27:57 +0000 (00:27 +1000)]
Merge pull request #48721 from zdover23/wip-doc-2022-11-04-cephadm-host-management-listing-hosts
doc/cephadm: arrange "listing hosts" section
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 3 Nov 2022 14:16:34 +0000 (00:16 +1000)]
doc/cephadm: alphabetize external tools list
Alphabetize "Ansible", "Rook", and "Salt", so that
the items in the list match the items in the sentence
that precedes the list.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Zac Dover [Thu, 3 Nov 2022 14:12:25 +0000 (00:12 +1000)]
doc/cephadm: arrange "listing hosts" section
Collect the material at the top of this page into a
"Listing Hosts" section and clean the English so that
it is clearer.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Neeraj Pratap Singh [Thu, 15 Sep 2022 18:06:35 +0000 (23:36 +0530)]
doc: addition of sort and limit features in doc
Fixes: https://tracker.ceph.com/issues/55121
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
Neeraj Pratap Singh [Tue, 26 Jul 2022 19:35:37 +0000 (01:05 +0530)]
cephfs-top: addition of sort and limit feature
This commit intends to add:
- sort-by field value feature to cephfs-top.
- feature to limit number of clients displayed
Fixes: https://tracker.ceph.com/issues/55121
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
Ilya Dryomov [Thu, 3 Nov 2022 10:57:41 +0000 (11:57 +0100)]
Merge pull request #48661 from thesamesam/gcc-13
common: Fix build with GCC 13 (missing <cstdint> include)
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Kefu Chai [Thu, 3 Nov 2022 06:27:11 +0000 (14:27 +0800)]
crimson/os/alienstore: use boost::counting_iterator for setting cpuset
less repeatings this way.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Thu, 3 Nov 2022 06:04:30 +0000 (14:04 +0800)]
crimson/os/alienstore: parse crimson_alien_thread_cpu_cores as a cpuset(7)
the "List format" listed in cpuset(7) allows us to specify a range of
CPU cores in a comma-separated list. and the upper bound of the range
is optional. before this change, the upper bound is not optional.
before this change, the upper bound of the range is not optional. and
the upper bound is not inclusive. so we don't support the list format
of cpuset(7). Take cores "1,2,3,5,7,8" for example, we need to set the
option to "1-4,5-6,7-9" to represent this cpuset.
after this change, the upper bound is optional, so we can properly
support the list format defined by cpuset(7). and the upper bound is
inclusive. so we can use "1-3,5,7-8", which is compatible with
notation defined by cpuset(7).
in this change, the cpuset option is parsed using a seastar helper,
which is implemented using a regex. so we don't need to manually parse
it. as Seastar's parser returns an `std::optional<std::set<unsigned>>`.
if the string does not match with the regex of comma-separated list,
the returned cpuset does not have a value. this design is more explicit.
so in this change, instead of using `std::vector<uint64_t>`,
`std::optional<cpuset>` is used.
Signed-off-by: Jianxin Li <jianxin1.li@intel.com>
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Thu, 3 Nov 2022 05:38:31 +0000 (15:38 +1000)]
Merge pull request #48712 from zdover23/wip-doc-2022-11-03-cephadm-compatibility-grammar
doc/cephadm: fix grammar in compatibility.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Thu, 3 Nov 2022 05:13:49 +0000 (15:13 +1000)]
doc/cephadm: fix grammar in compatibility.rst
Fix grammar in doc/cephadm/compatibility.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
zdover23 [Wed, 2 Nov 2022 05:15:02 +0000 (15:15 +1000)]
Merge pull request #48699 from zdover23/wip-doc-2022-11-02-dev-osd-internals-ec-glossary-fixes
doc/dev: refine erasure_coding.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 2 Nov 2022 03:45:48 +0000 (13:45 +1000)]
doc/dev: refine erasure_coding.rst
Improve the readability and clarity of
erasure_coding.rst.
Co-author: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Anthony D'Atri [Tue, 1 Nov 2022 13:55:19 +0000 (09:55 -0400)]
Merge pull request #48687 from StevenWash/bugfix/fix_command_error_blank
doc/radosgw: fix command error blank
stevenhua [Tue, 1 Nov 2022 01:53:02 +0000 (09:53 +0800)]
doc/radosgw: fix command error blank
zdover23 [Tue, 1 Nov 2022 00:57:30 +0000 (10:57 +1000)]
Merge pull request #48684 from zdover23/wip-doc-2022-11-01-dev-osd-internals-ec-glossary-alphabetize
doc/dev: alphabetize EC glossary
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Tue, 1 Nov 2022 00:47:52 +0000 (10:47 +1000)]
doc/dev: alphabetize EC glossary
Alphabetize the glossary in
doc/dev/osd_internals/erasure_coding.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ilya Dryomov [Mon, 31 Oct 2022 18:33:30 +0000 (19:33 +0100)]
Merge pull request #48673 from idryomov/wip-49947
doc: note architecture availability for PMEM mode of PWL cache
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Matan [Mon, 31 Oct 2022 12:57:08 +0000 (14:57 +0200)]
Merge pull request #48548 from dparmar18/update_debug_script
script/ceph-debug-docker.sh: change default branch to main
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
zdover23 [Mon, 31 Oct 2022 03:43:46 +0000 (13:43 +1000)]
Merge pull request #48674 from zdover23/doc-2022-10-31-dev-osd-internals-ec-glossary
doc/dev: improve EC glossary
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Mon, 31 Oct 2022 03:17:45 +0000 (13:17 +1000)]
doc/dev: improve EC glossary
Improve the clarity and syntax of the text in
doc/dev/osd_internals/erasure_coding.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ilya Dryomov [Sun, 30 Oct 2022 17:06:57 +0000 (18:06 +0100)]
doc: note architecture availability for PMEM mode of PWL cache
Fixes: https://tracker.ceph.com/issues/49947
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
zdover23 [Sun, 30 Oct 2022 06:07:38 +0000 (16:07 +1000)]
Merge pull request #48667 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-colemitchell-notes
doc/ceph-volume: refine Filestore docs
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sun, 30 Oct 2022 05:27:24 +0000 (15:27 +1000)]
doc/ceph-volume: refine Filestore docs
Add Cole Mitchell's improvements to the filestore section.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
zdover23 [Sun, 30 Oct 2022 00:49:31 +0000 (10:49 +1000)]
Merge pull request #48665 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-datri-notes
doc/ceph-volume: improve prepare.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sat, 29 Oct 2022 22:46:26 +0000 (08:46 +1000)]
doc/ceph-volume: improve prepare.rst
Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/48651.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Jos Collin [Sat, 29 Oct 2022 02:09:55 +0000 (07:39 +0530)]
Merge pull request #48090 from joscollin/wip-F55197-cephfs-top-scroll
cephfs-top: make cephfs-top display scrollable
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Laura Flores [Fri, 28 Oct 2022 20:02:07 +0000 (15:02 -0500)]
Merge pull request #48662 from ceph/wip-update-stale-bot
.github/workflows: update `days-before-pr-close`
Laura Flores [Fri, 28 Oct 2022 18:24:33 +0000 (13:24 -0500)]
.github/workflows: update `days-before-pr-close`
Currently, the stale bot closes PRs 90 days after they are marked stale since it counts "marking a PR stale" as activity.
We really want the PRs to close after a total of 90 days, or 30 days after they are marked stale. Changing `days-before-prs-close` to 30 will fix this.
Signed-off-by: Laura Flores <lflores@redhat.com>
Sam James [Fri, 28 Oct 2022 15:47:38 +0000 (16:47 +0100)]
common: fix build with GCC 13 (missing <cstdint> include)
Needed for uint8_t. Only worked by chance before (see
https://www.gnu.org/software/gcc/gcc-13/porting_to.html).
```
FAILED: src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DBOOST_ASIO_DISABLE_THREAD_KEYWORD_EXTENSION -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D__CEPH__ -D__STDC_FORMAT_MACROS -D__linux__ -I/var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5_build/src/include -I/var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src -isystem /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5_build/include -isystem /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/xxHash -isystem /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/rapidjson/include -O2 -march=native -pipe -fPIC -U_FORTIFY_SOURCE -Wall -fno-strict-aliasing -fsigned-char -Wtype-limits -Wignored-qualifiers -Wpointer-arith -Werror=format-security -Winit-self -Wno-unknown-pragmas -Wnon-virtual-dtor -Wno-ignored-qualifiers -ftemplate-depth-1024 -Wpessimizing-move -Wredundant-move -Wstrict-null-sentinel -Woverloaded-virtual -fno-new-ttp-matching -fstack-protector-strong -fdiagnostics-color=auto -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-free -std=c++17 -MD -MT src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o -MF src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o.d -o src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o -c /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/FSMapUser.cc
In file included from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/log/SubsystemMap.h:12,
from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/common/config.h:23,
from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/mdstypes.h:13,
from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/FSMapUser.h:21,
from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/FSMapUser.cc:1:
/var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/common/subsys_types.h:56:23: error: ‘uint8_t’ in namespace ‘std’ does not name a type; did you mean ‘wint_t’?
```
Bug: https://bugs.gentoo.org/878531
Signed-off-by: Sam James <sam@gentoo.org>
zdover23 [Fri, 28 Oct 2022 13:54:31 +0000 (23:54 +1000)]
Merge pull request #48658 from zdover23/wip-doc-2022-10-28-radosgw-multisite-prompts
doc/radosgw: add prompts to multisite.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 28 Oct 2022 13:37:16 +0000 (23:37 +1000)]
doc/radosgw: add prompts to multisite.rst
Add unselectable prompts to multisite.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
zdover23 [Fri, 28 Oct 2022 11:14:03 +0000 (21:14 +1000)]
Merge pull request #47582 from snosratiershad/docs/correct-add-system-user-to-the-master-zone-command
docs: correct add system user to the master zone command
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Jos Collin [Mon, 19 Sep 2022 12:35:43 +0000 (18:05 +0530)]
cephfs-top: Select Filesystem Screen fixes for no FS
* drop the blank FS Menu when there is no FS
* cleanup display_fs_menu() code
Signed-off-by: Jos Collin <jcollin@redhat.com>
Jos Collin [Wed, 19 Oct 2022 11:07:53 +0000 (16:37 +0530)]
doc: Update cephfs-top.png
Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>
Jos Collin [Thu, 8 Sep 2022 09:51:24 +0000 (15:21 +0530)]
cephfs-top: make cephfs-top display scrollable
Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>
Ilya Dryomov [Tue, 25 Oct 2022 16:16:33 +0000 (18:16 +0200)]
Merge pull request #40363 from orozery/rbd-clone-encryption
librbd: add encryption format support for clones (part 1/2)
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
dparmar18 [Wed, 19 Oct 2022 09:52:44 +0000 (15:22 +0530)]
script/ceph-debug-docker.sh: change default branch to main
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
Ronen Friedman [Wed, 19 Oct 2022 05:13:25 +0000 (08:13 +0300)]
Merge pull request #48347 from ronen-fr/wip-rf-acting
osd/scrub: use the actual active set when requesting replicas to scrub
Reviewed-by: Samuel Just <sjust@redhat.com>
Nizamudeen A [Wed, 19 Oct 2022 05:06:14 +0000 (10:36 +0530)]
Merge pull request #48510 from ceph/update-mailmap
mailmap: add Pedro Gonzalez Gomez
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Wed, 19 Oct 2022 05:03:52 +0000 (10:33 +0530)]
Merge pull request #48528 from ceph/fix-gh_pr_triage_node_version-main
.github/pr-triage: update node.js to v16
Reviewed-by: Nizamudeen A <nia@redhat.com>
Samuel Just [Tue, 18 Oct 2022 22:45:28 +0000 (15:45 -0700)]
Merge pull request #48515 from athanatos/sjust/wip-crimson-suites
qa/suites/crimson-rados: move seastore to crimson-rados-experimental, remove cache/dedup workloads
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
zdover23 [Tue, 18 Oct 2022 17:14:46 +0000 (03:14 +1000)]
Merge pull request #48533 from zdover23/wip-doc-2022-10-19-radosgw-notification-topic-management-and-notification-performance
doc/radosgw: refine top. man. and not. perf. stats
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 18 Oct 2022 16:55:23 +0000 (02:55 +1000)]
doc/radosgw: refine top. man. and not. perf. stats
This commit refines the English in the "Topic Management via CLI" and
"Notification Performance Statistics" sections of the notifications.rst
file.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Yuval Lifshitz [Tue, 18 Oct 2022 16:07:42 +0000 (19:07 +0300)]
Merge pull request #48444 from yuvalif/wip-yuval-fix-57850
rgw/amqp: store CA location string in connection object
Samuel Just [Mon, 10 Oct 2022 23:33:38 +0000 (16:33 -0700)]
qa/suites/crimson-rados: remove cache and dedup related tests
It's an accident that some of these pass -- the tests provide some
coverage for inconsistencies that can arise, but don't really validate
that the objects actually get moved between tiers.
It's going to be some time before we implement cache or dedup in
crimson, and we'll probably want to disable the related commands for
pools that can map to crimson osds to prevent accidents.
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 10 Oct 2022 23:30:06 +0000 (16:30 -0700)]
qa/suites: move seastore to crimson-rados-experimental suite
Let's use crimson-rados-experimental for tests that don't yet
pass reliably. We can move these to crimson-rados as they
become reliable.
Signed-off-by: Samuel Just <sjust@redhat.com>
zdover23 [Tue, 18 Oct 2022 14:56:50 +0000 (00:56 +1000)]
Merge pull request #48511 from zdover23/wip-doc-2022-10-18-radosgw-notification-reliability
doc/radosgw: refine "notification reliability"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 17 Oct 2022 14:09:34 +0000 (00:09 +1000)]
doc/radosgw: refine "notification reliability"
This commit refines the English in the "Notification Reliability"
section of the notifications.rst page (the "Bucket Notifications"
page). I have also added signposting structure.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Yuval Lifshitz <ylifshit@redhat.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ernesto Puerta [Tue, 18 Oct 2022 12:50:39 +0000 (14:50 +0200)]
.github/pr-triage: update node.js to v16
[Warning](https://github.com/ceph/ceph/actions/runs/
3273201887 ):
```
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: actions/labeler, iyu/actions-milestone
```
Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
Kefu Chai [Tue, 18 Oct 2022 12:36:20 +0000 (20:36 +0800)]
Merge pull request #48484 from cyx1231st/wip-crimson-msgr-cleanup
crimson/net: simplify msgr interfaces with AuthClient/Server
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Ernesto Puerta [Tue, 18 Oct 2022 12:13:10 +0000 (14:13 +0200)]
Merge pull request #48514 from ceph/wip-dashboard_gh_project-main
Reviewed-by: Nizamudeen A <nia@redhat.com>
Venky Shankar [Tue, 18 Oct 2022 09:05:59 +0000 (14:35 +0530)]
Merge pull request #48485 from vshankar/wip-upgrade-x-o-q
qa: fs:upgrade featureful_client test upgrades to quincy
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Avan [Tue, 18 Oct 2022 09:00:15 +0000 (14:30 +0530)]
Merge pull request #48398 from rhcs-dashboard/fix-get-rbd-stats
mgr/prometheus: avoid duplicates and deleted entries for rbd_stats_pools
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Tue, 18 Oct 2022 08:41:01 +0000 (10:41 +0200)]
Merge pull request #48471 from SUSE/wip-fix-57860
ceph.spec.in: disable system_pmdk on s390x for SUSE distros
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ernesto Puerta [Mon, 17 Oct 2022 15:50:41 +0000 (17:50 +0200)]
.github/pr-triage: switch from old to new project
The old (classic) Dashboard project (https://github.com/ceph/ceph/projects/6) has been migrated to a new-style one (https://github.com/orgs/ceph/projects/2/views/1).
This also requires updating the GH Action that automatically assigned `dashboard`-labeled PRs to the Dashboard project.
Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
zdover23 [Mon, 17 Oct 2022 15:49:32 +0000 (01:49 +1000)]
Merge pull request #48512 from zdover23/wip-doc-2022-10-18-radosgw-notifications-prompts
doc/radowsgw: add prompts to notifications.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Pedro Gonzalez Gomez [Mon, 17 Oct 2022 13:59:36 +0000 (15:59 +0200)]
mailmap: add Pedro Gonzalez Gomez
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Zac Dover [Mon, 17 Oct 2022 13:46:39 +0000 (23:46 +1000)]
doc/radowsgw: add prompts to notifications.rst
This PR adds unselectable prompts to doc/radosgw/notifications.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Venky Shankar [Mon, 17 Oct 2022 11:56:46 +0000 (17:26 +0530)]
Merge pull request #48241 from ajarr/fix-57210
src/mds: increment directory inode's change attr by one
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Kefu Chai [Mon, 17 Oct 2022 03:44:14 +0000 (11:44 +0800)]
Merge pull request #48425 from phlogistonjohn/jjm-shell-fixups
build: minor build script cleanups
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Sun, 16 Oct 2022 18:14:38 +0000 (04:14 +1000)]
Merge pull request #48501 from zdover23/wip-doc-2022-10-17-radosgw-notifications
doc/radosgw: refine notifications.rst - top part
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sun, 16 Oct 2022 17:54:25 +0000 (03:54 +1000)]
doc/radosgw: refine notifications.rst - top part
This commit refines the English in the first part of the
notifications.rst page (the "Bucket Notifications" page).
Signed-off-by: Zac Dover <zac.dover@gmail.com>
John Mulligan [Mon, 10 Oct 2022 14:21:02 +0000 (10:21 -0400)]
install-deps: switch to C.UTF-8 locale
The en_US.UTF-8 locale is not always going to present on all systems.
Specifically, setting en_US.UTF-8 causes numerous warnings when running
this script on a CentOS Stream 8 container. Rather than install
additional packages to suppress the warning, use the C.UTF-8 locale.
Additionally, try to update the comment explaining the line to something
based on the commit history rather than the confusing term "vulnerable".
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Mon, 10 Oct 2022 14:18:00 +0000 (10:18 -0400)]
script/run-make: convert a tab to spaces
There was a single line using a hard tab to indent, convert the tab
and reformat the spacing of the line near it.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Mon, 10 Oct 2022 14:16:44 +0000 (10:16 -0400)]
install-deps: for consistency, reformat tabs to spaces
The majority of the install-deps.sh file was already using spaces to
indent, convert the remaining hard tabs to 8 spaces.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Mon, 10 Oct 2022 14:01:21 +0000 (10:01 -0400)]
install-deps: remove emacs modeline from script
The majority of the lines in this shell script uses spaces to indent,
but I *think* this modeline tells emacs to indent with tabs. In a very
near future change I'm going to make all indents use spaces. So we first
remove the emacs modeline that tells it to use the opposite.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Venky Shankar [Sun, 16 Oct 2022 14:46:17 +0000 (20:16 +0530)]
Merge pull request #48086 from vshankar/wip-57084
client: use parent directory POSIX ACLs for snapshot dir
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Liu-Chunmei [Sun, 16 Oct 2022 06:19:08 +0000 (23:19 -0700)]
Merge pull request #48497 from liu-chunmei/fix-variable-usage-after-move
crimson/osd: not use a moved variable
Reviewed-by: Samuel Just <sjust@redhat.com>
zdover23 [Sun, 16 Oct 2022 03:41:41 +0000 (13:41 +1000)]
Merge pull request #48498 from zdover23/wip-doc-2022-10-16-radosgw-notifications-wording
doc/radosgw: update notifications.rst - grammar
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sun, 16 Oct 2022 03:09:35 +0000 (13:09 +1000)]
doc/radosgw: update notifications.rst - grammar
This commit rewrites a sentence, as requested by
C. Mitchell here:
https://github.com/ceph/ceph/pull/48493/files#r996003812
Signed-off-by: Zac Dover <zac.dover@gmail.com>
chunmei-liu [Sun, 16 Oct 2022 00:52:36 +0000 (17:52 -0700)]
crimson/osd: not use a moved variable
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Ramana Raja [Wed, 21 Sep 2022 20:31:05 +0000 (16:31 -0400)]
cephfs: add additional logging to track change_attr of inodes
Signed-off-by: Ramana Raja <rraja@redhat.com>
Ramana Raja [Thu, 22 Sep 2022 15:41:50 +0000 (11:41 -0400)]
src/mds: increment directory inode's change attr by one
... whenever the mtime or ctime of the directory inode is modified.
In CephFS subvolume clones exported using NFS-Ganesha, newly created
files using `touch` were not being listed. It was identified that the
create request sent to the Ceph MDS via NFS-Ganesha's libcephfs client
modified the mtime and ctime of the parent directory, but did not modify
the change_attr of the parent directory. Since the NFS client
didn't see a modification of the change attribute in the reply, it
didn't invalidate its readdir cache. The subsequent directory `ls` was
satisfied from the NFS client's stale readdir cache.
Whenever parent directory inode's mtime was modified in
MDCache::predirty_journal_parents(), the parent inode's change_attr
was set to its dirstat->change_attr. The parent inode's
dirstat->change_attr doesn't track changes to parent's *ctime only*
changes such as setattr, setvxattr, etc. on the parent
directory. See commit
0d441dcd6af553d11d6be6df56d577c5659904a0 for more
details. This caused the directory inode's change_attr to not be updated
when an operation to change only its ctime was followed by an operation
to change its mtime and ctime.
Fix this by making changes to MDCache::predirty_journal_parents() and
CInode::finish_scatter_gather_update() to increment the directory
inode's change_attr by one instead of setting it to its
dirstat->change_attr.
Fixes: https://tracker.ceph.com/issues/57210
Signed-off-by: Ramana Raja <rraja@redhat.com>
Ramana Raja [Thu, 22 Sep 2022 19:55:52 +0000 (15:55 -0400)]
test/libcephfs: enhance directory's change_attr testing
Alternate operations that only change directory's ctime
(setattr/setxattr/removexattr on directory) with those that change
directory's mtime and ctime (create/rename/remove a file within
directory). Check that directory's change_attr is updated everytime
ctime changes.
Signed-off-by: Ramana Raja <rraja@redhat.com>
Adam King [Fri, 14 Oct 2022 20:10:57 +0000 (16:10 -0400)]
Merge pull request #48227 from phlogistonjohn/jjm-cephadm-test-nfsg
cephadm: add test coverage for NFSGanesha, HAproxy, & Keepalived classes
Reviewed-by: Adam King <adking@redhat.com>
zdover23 [Fri, 14 Oct 2022 18:02:21 +0000 (04:02 +1000)]
Merge pull request #48493 from zdover23/wip-doc-2022-10-15-radosgw-notifications-cleanup
doc/radosgw: improve grammar - notifications.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 14 Oct 2022 17:48:44 +0000 (03:48 +1000)]
doc/radosgw: improve grammar - notifications.rst
This commit makes the changes suggested by C. Mitchell in
https://github.com/ceph/ceph/pull/48486.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Fri, 14 Oct 2022 12:06:52 +0000 (20:06 +0800)]
Merge pull request #48422 from aravind-wdc/refactor
crimson/zns: refactor zone operations
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Fri, 14 Oct 2022 06:49:49 +0000 (16:49 +1000)]
Merge pull request #48486 from zdover23/wip-doc-2022-10-14-radosgw-push_endpoint
doc/radosgw: add push_endpoint for rabbitmq
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Aravind Ramesh [Mon, 10 Oct 2022 07:22:59 +0000 (07:22 +0000)]
crimson/zns: refactor zone operation
Moved all zone operations into one routine.
Signed-off-by: Aravind Ramesh <Aravind.Ramesh@wdc.com>
Zac Dover [Fri, 14 Oct 2022 06:17:12 +0000 (16:17 +1000)]
doc/radosgw: add push_endpoint for rabbitmq
This commit directs users of rabbitmq to use "push_endpoint"
(with an underscore) instead of "push-endpoint" (with a hy-
phen). This commit adds a note that contains such a direct-
ive. It does not alter the examples already present in the
text.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Venky Shankar [Thu, 13 Oct 2022 05:22:22 +0000 (01:22 -0400)]
qa: fs:upgrade featureful_client test upgrades to quincy
Reef cycle will not allow upgrades from octopus. However, the featureful
client tests still needs to be testes, therefore, upgrade to quincy (from
octopus) rather to the current cycle (reef).
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Samuel Just [Thu, 13 Oct 2022 20:56:07 +0000 (13:56 -0700)]
Merge pull request #48475 from rzarzynski/wip-crimson-resolve_oid-clone_snaps-fix-search
crimson/osd: resolve_oid() looks in clone_snaps by requested snap ID
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Thu, 13 Oct 2022 20:01:25 +0000 (13:01 -0700)]
Merge pull request #48405 from athanatos/sjust/wip-57759
crimson: tmap support, list_snaps support, fixes for zero and cmpext
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Avan Thakkar [Fri, 7 Oct 2022 20:10:57 +0000 (01:40 +0530)]
mgr/prometheus: avoid duplicates and deleted entries for rbd_stats_pool
Fixes: https://tracker.ceph.com/issues/57797
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Avoid duplicate entries (pool[/namespace]) for rbd_stats_pools config and also avoid deleted pools.
Radoslaw Zarzynski [Thu, 13 Oct 2022 11:22:32 +0000 (11:22 +0000)]
crimson/osd: resolve_oid() looks in clone_snaps by requested snap ID
Before the patch the method was looking for `lower_bound(oid.snap)`
from `SnapSet::clones` which leads to reading from head instead of
returning the `ENOENT` expected in `TestLibRBD.TestIOToSnapshot`.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yingxin Cheng [Thu, 13 Oct 2022 09:51:52 +0000 (17:51 +0800)]
crimson/net: hide peer_global_id from Connection class
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>