]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agomgr/prometheus: expose daemon health metrics 48843/head
Pere Diaz Bou [Fri, 11 Nov 2022 09:43:01 +0000 (10:43 +0100)]
mgr/prometheus: expose daemon health metrics

Until now daemon health metrics were stored without being used. One of
the most helpful metrics there is SLOW_OPS with respect to OSDs and MONs
which this commit tries to expose to bring fine grained metrics to find
troublesome OSDs instead of having a lone healthcheck of slow ops in the
whole cluster.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #48137 from nSedrickm/color-contrast-accessibility-update
Nizamudeen A [Tue, 8 Nov 2022 04:51:03 +0000 (10:21 +0530)]
Merge pull request #48137 from nSedrickm/color-contrast-accessibility-update

mgr/dashboard: improve level AA color contrast accessibility for dashboard pages and components

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48776 from zdover23/wip-doc-2022-11-08-rados-config-storage-devic...
zdover23 [Tue, 8 Nov 2022 03:05:56 +0000 (13:05 +1000)]
Merge pull request #48776 from zdover23/wip-doc-2022-11-08-rados-config-storage-devices-backend-correction

doc/rados: s/backend/back end/

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #48775 from zdover23/wip-doc-2022-11-08-glossary-OSD-link
zdover23 [Tue, 8 Nov 2022 02:58:08 +0000 (12:58 +1000)]
Merge pull request #48775 from zdover23/wip-doc-2022-11-08-glossary-OSD-link

doc/glossary: link to OSD material

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #48774 from zdover23/wip-doc-2022-11-08-glossary-BlueStore
zdover23 [Tue, 8 Nov 2022 02:55:33 +0000 (12:55 +1000)]
Merge pull request #48774 from zdover23/wip-doc-2022-11-08-glossary-BlueStore

doc/glossary: add "BlueStore"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rados: s/backend/back end/ 48776/head
Zac Dover [Tue, 8 Nov 2022 02:35:57 +0000 (12:35 +1000)]
doc/rados: s/backend/back end/

s/backend/back end/ in storage-devices.rst.
(IBM Style Guide, 305).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/glossary: link to OSD material 48775/head
Zac Dover [Tue, 8 Nov 2022 02:33:18 +0000 (12:33 +1000)]
doc/glossary: link to OSD material

Link to the OSD material in RADOS Configuration
"Storage Devices".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/glossary: add "BlueStore" 48774/head
Zac Dover [Tue, 8 Nov 2022 02:25:35 +0000 (12:25 +1000)]
doc/glossary: add "BlueStore"

Define "BlueStore" in the glossary and link to the BlueStore
section in the RADOS Configuration "Storage Devices" chapter.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48768 from zdover23/wip-doc-2022-11-07-glossary-ceph-osd
zdover23 [Mon, 7 Nov 2022 23:32:58 +0000 (09:32 +1000)]
Merge pull request #48768 from zdover23/wip-doc-2022-11-07-glossary-ceph-osd

doc/glossary: define "Ceph OSD"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/glossary: define "Ceph OSD" 48768/head
Zac Dover [Mon, 7 Nov 2022 22:58:35 +0000 (08:58 +1000)]
doc/glossary: define "Ceph OSD"

Define "Ceph OSD", using Sage's own description.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48022 from rhcs-dashboard/paginate-services
Pere Diaz Bou [Mon, 7 Nov 2022 17:12:06 +0000 (18:12 +0100)]
Merge pull request #48022 from rhcs-dashboard/paginate-services

mgr/dashboard: paginate services

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48763 from zdover23/wip-doc-2022-11-07-glossary-ceph-manager
zdover23 [Mon, 7 Nov 2022 14:19:43 +0000 (00:19 +1000)]
Merge pull request #48763 from zdover23/wip-doc-2022-11-07-glossary-ceph-manager

doc/glossary.rst: define "Ceph Manager"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary.rst: define "Ceph Manager" 48763/head
Zac Dover [Mon, 7 Nov 2022 13:55:53 +0000 (23:55 +1000)]
doc/glossary.rst: define "Ceph Manager"

Add a definition for Ceph Manager (ceph-mgr).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48616 from rhcs-dashboard/mirror-promote-demote-bug
Nizamudeen A [Mon, 7 Nov 2022 06:24:44 +0000 (11:54 +0530)]
Merge pull request #48616 from rhcs-dashboard/mirror-promote-demote-bug

mgr/dashboard: bug fixes for rbd mirroring edit and promotion/demotion

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #48538 from Syphdias/add-bonding-alert
Nizamudeen A [Mon, 7 Nov 2022 06:17:43 +0000 (11:47 +0530)]
Merge pull request #48538 from Syphdias/add-bonding-alert

ceph-mixin: Add Prometheus Alert for Degraded Bond

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2 years agoMerge pull request #48693 from ljx023/seastore-device-size-detect
Yingxin [Mon, 7 Nov 2022 01:55:08 +0000 (09:55 +0800)]
Merge pull request #48693 from ljx023/seastore-device-size-detect

crimson/os/seastore/segment_manager/block: get block device size

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2 years agoMerge pull request #48757 from zdover23/wip-doc-2022-11-07-glossary-OSD
zdover23 [Sun, 6 Nov 2022 18:29:47 +0000 (04:29 +1000)]
Merge pull request #48757 from zdover23/wip-doc-2022-11-07-glossary-OSD

doc/glossary: define "OSD"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/glossary: define "OSD" 48757/head
Zac Dover [Sun, 6 Nov 2022 17:45:24 +0000 (03:45 +1000)]
doc/glossary: define "OSD"

Define "OSD" as "Object Storage Device", distinct from
"object storage daemon".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agomgr/dashboard: improve level AA color contrast accessibility for dashboard pages... 48137/head
nsedrickm [Fri, 16 Sep 2022 12:33:28 +0000 (13:33 +0100)]
mgr/dashboard: improve level AA color contrast accessibility for dashboard pages and components
Use more accessible colors for dashboard components, text and table columns

Fixes: https://tracker.ceph.com/issues/56023
Signed-off-by: nsedrickm <nsedrick101@gmail.com>
2 years agoMerge pull request #48753 from zdover23/wip-doc-2022-11-06-glossary-remove-front...
zdover23 [Sun, 6 Nov 2022 08:29:51 +0000 (18:29 +1000)]
Merge pull request #48753 from zdover23/wip-doc-2022-11-06-glossary-remove-front-matter

doc/glossary.rst: remove old front matter

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary.rst: remove old front matter 48753/head
Zac Dover [Sun, 6 Nov 2022 07:41:20 +0000 (17:41 +1000)]
doc/glossary.rst: remove old front matter

Remove two paragraphs from May 2013 that no longer apply.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48750 from zdover23/wip-doc-2022-11-06-glossary-various
zdover23 [Sat, 5 Nov 2022 17:12:07 +0000 (03:12 +1000)]
Merge pull request #48750 from zdover23/wip-doc-2022-11-06-glossary-various

doc/glossary: improve wording

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary: improve wording 48750/head
Zac Dover [Sat, 5 Nov 2022 16:59:23 +0000 (02:59 +1000)]
doc/glossary: improve wording

Remove "e.g." and "etc." and improve the wording of a definition.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48747 from zdover23/wip-doc-2022-11-05-glossary-dashboard
zdover23 [Sat, 5 Nov 2022 16:49:39 +0000 (02:49 +1000)]
Merge pull request #48747 from zdover23/wip-doc-2022-11-05-glossary-dashboard

doc/glossary.rst: add "Ceph Dashboard" term

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/glossary.rst: add "Ceph Dashboard" term 48747/head
Zac Dover [Sat, 5 Nov 2022 16:22:25 +0000 (02:22 +1000)]
doc/glossary.rst: add "Ceph Dashboard" term

Add a definition for "Ceph Dashboard".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48744 from zdover23/wip-doc-2022-11-05-glossary-rbd
zdover23 [Sat, 5 Nov 2022 05:59:22 +0000 (15:59 +1000)]
Merge pull request #48744 from zdover23/wip-doc-2022-11-05-glossary-rbd

doc/glosary.rst: add "Ceph Block Device" term

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/glosary.rst: add "Ceph Block Device" term 48744/head
Zac Dover [Sat, 5 Nov 2022 05:34:20 +0000 (15:34 +1000)]
doc/glosary.rst: add "Ceph Block Device" term

Add a definition for "Ceph Block Device".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48666 from joscollin/wip-cephfs-top-version
Jos Collin [Sat, 5 Nov 2022 02:29:28 +0000 (07:59 +0530)]
Merge pull request #48666 from joscollin/wip-cephfs-top-version

cephfs-top: add version in header

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoMerge pull request #48291 from ljflores/wip-upgrade-telemetry
Laura Flores [Sat, 5 Nov 2022 01:00:30 +0000 (20:00 -0500)]
Merge pull request #48291 from ljflores/wip-upgrade-telemetry

2 years agodoc: update cephfs-top.png 48666/head
Jos Collin [Fri, 4 Nov 2022 04:41:19 +0000 (10:11 +0530)]
doc: update cephfs-top.png

Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agocephfs-top: add version in header
Jos Collin [Thu, 27 Oct 2022 06:42:41 +0000 (12:12 +0530)]
cephfs-top: add version in header

Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #48739 from zdover23/wip-doc-2022-11-05-dev-guide-lone-sentence
zdover23 [Fri, 4 Nov 2022 17:25:54 +0000 (03:25 +1000)]
Merge pull request #48739 from zdover23/wip-doc-2022-11-05-dev-guide-lone-sentence

doc/dev: improve lone sentence

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/dev: improve lone sentence 48739/head
Zac Dover [Fri, 4 Nov 2022 17:11:04 +0000 (03:11 +1000)]
doc/dev: improve lone sentence

Improve a lone sentence to make it less ambiguous, and at the same
time permit the testing of a script.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48736 from zdover23/wip-doc-2022-11-05-cephadm-host-management...
zdover23 [Fri, 4 Nov 2022 16:55:32 +0000 (02:55 +1000)]
Merge pull request #48736 from zdover23/wip-doc-2022-11-05-cephadm-host-management-removing-hosts

doc/cephadm: improve lone sentence

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/cephadm: improve lone sentence 48736/head
Zac Dover [Fri, 4 Nov 2022 16:38:13 +0000 (02:38 +1000)]
doc/cephadm: improve lone sentence

Improve a lone sentence, both to make the cephadm documentation better
and to test a script that is under development.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48716 from tchaikov/crimson-cpuset
Kefu Chai [Fri, 4 Nov 2022 06:31:49 +0000 (14:31 +0800)]
Merge pull request #48716 from tchaikov/crimson-cpuset

crimson/os/alienstore: parse crimson_alien_thread_cpu_cores in cpuset(7)'s list format

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #48111 from neesingh-rh/feature_55121
Jos Collin [Fri, 4 Nov 2022 03:24:10 +0000 (08:54 +0530)]
Merge pull request #48111 from neesingh-rh/feature_55121

cephfs-top: addition of sort feature and limit option

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #48722 from zdover23/wip-doc-2022-11-04-cephadm-index-list-alphabe...
zdover23 [Thu, 3 Nov 2022 14:33:02 +0000 (00:33 +1000)]
Merge pull request #48722 from zdover23/wip-doc-2022-11-04-cephadm-index-list-alphabetizing

doc/cephadm: alphabetize external tools list

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #48721 from zdover23/wip-doc-2022-11-04-cephadm-host-management...
zdover23 [Thu, 3 Nov 2022 14:27:57 +0000 (00:27 +1000)]
Merge pull request #48721 from zdover23/wip-doc-2022-11-04-cephadm-host-management-listing-hosts

doc/cephadm: arrange "listing hosts" section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephadm: alphabetize external tools list 48722/head
Zac Dover [Thu, 3 Nov 2022 14:16:34 +0000 (00:16 +1000)]
doc/cephadm: alphabetize external tools list

Alphabetize "Ansible", "Rook", and "Salt", so that
the items in the list match the items in the sentence
that precedes the list.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/cephadm: arrange "listing hosts" section 48721/head
Zac Dover [Thu, 3 Nov 2022 14:12:25 +0000 (00:12 +1000)]
doc/cephadm: arrange "listing hosts" section

Collect the material at the top of this page into a
"Listing Hosts" section and clean the English so that
it is clearer.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc: addition of sort and limit features in doc 48111/head
Neeraj Pratap Singh [Thu, 15 Sep 2022 18:06:35 +0000 (23:36 +0530)]
doc: addition of sort and limit features in doc

Fixes: https://tracker.ceph.com/issues/55121
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agocephfs-top: addition of sort and limit feature
Neeraj Pratap Singh [Tue, 26 Jul 2022 19:35:37 +0000 (01:05 +0530)]
cephfs-top: addition of sort and limit feature

This commit intends to add:
- sort-by field value feature to cephfs-top.
- feature to limit number of clients displayed

Fixes: https://tracker.ceph.com/issues/55121
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoMerge pull request #48661 from thesamesam/gcc-13
Ilya Dryomov [Thu, 3 Nov 2022 10:57:41 +0000 (11:57 +0100)]
Merge pull request #48661 from thesamesam/gcc-13

common: Fix build with GCC 13 (missing <cstdint> include)

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agomgr/dashboard: bug fixes for rbd mirroring edit and promotion/demotion 48616/head
Pedro Gonzalez Gomez [Tue, 25 Oct 2022 13:43:42 +0000 (15:43 +0200)]
mgr/dashboard: bug fixes for rbd mirroring edit and promotion/demotion

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agocrimson/os/alienstore: use boost::counting_iterator for setting cpuset 48716/head
Kefu Chai [Thu, 3 Nov 2022 06:27:11 +0000 (14:27 +0800)]
crimson/os/alienstore: use boost::counting_iterator for setting cpuset

less repeatings this way.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/os/alienstore: parse crimson_alien_thread_cpu_cores as a cpuset(7)
Kefu Chai [Thu, 3 Nov 2022 06:04:30 +0000 (14:04 +0800)]
crimson/os/alienstore: parse crimson_alien_thread_cpu_cores as a cpuset(7)

the "List format" listed in cpuset(7) allows us to specify a range of
CPU cores in a comma-separated list. and the upper bound of the range
is optional. before this change, the upper bound is not optional.

before this change, the upper bound of the range is not optional. and
the upper bound is not inclusive. so we don't support the list format
of cpuset(7). Take cores "1,2,3,5,7,8" for example, we need to set the
option to "1-4,5-6,7-9" to represent this cpuset.
after this change, the upper bound is optional, so we can properly
support the list format defined by cpuset(7). and the upper bound is
inclusive. so we can use "1-3,5,7-8", which is compatible with
notation defined by cpuset(7).

in this change, the cpuset option is parsed using a seastar helper,
which is implemented using a regex. so we don't need to manually parse
it. as Seastar's parser returns an `std::optional<std::set<unsigned>>`.
if the string does not match with the regex of comma-separated list,
the returned cpuset does not have a value. this design is more explicit.
so in this change, instead of using `std::vector<uint64_t>`,
`std::optional<cpuset>` is used.

Signed-off-by: Jianxin Li <jianxin1.li@intel.com>
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48712 from zdover23/wip-doc-2022-11-03-cephadm-compatibility...
zdover23 [Thu, 3 Nov 2022 05:38:31 +0000 (15:38 +1000)]
Merge pull request #48712 from zdover23/wip-doc-2022-11-03-cephadm-compatibility-grammar

doc/cephadm: fix grammar in compatibility.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/cephadm: fix grammar in compatibility.rst 48712/head
Zac Dover [Thu, 3 Nov 2022 05:13:49 +0000 (15:13 +1000)]
doc/cephadm: fix grammar in compatibility.rst

Fix grammar in doc/cephadm/compatibility.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoceph-mixin: Add Prometheus Alert for Degraded Bond 48538/head
Christian Kugler [Sun, 16 Oct 2022 17:21:01 +0000 (19:21 +0200)]
ceph-mixin: Add Prometheus Alert for Degraded Bond

Currently there is no alert for a network interface card to be misconfigured or
failed which is part of a network bond.

This could lead to redundancies and performance being degraded unnoticed.

To solve this, I use node exporter metrics to look at the number of total peers
of the bond and the ones that are active. If the numbers differ, something is up
and should be looked at.

Fixes: https://tracker.ceph.com/issues/57962
Signed-off-by: Christian Kugler <syphdias+git@gmail.com>
2 years agocrimson/os/seastore/segment_manager/block: get block device size 48693/head
Jianxin Li [Mon, 31 Oct 2022 08:03:01 +0000 (08:03 +0000)]
crimson/os/seastore/segment_manager/block: get block device size

Previously the file_stat(::stat) can not get correct size for block devices.
Now call the file.size(using ::lseek) to replace it.

Signed-off-by: Jianxin Li <jianxin1.li@intel.com>
2 years agoMerge pull request #48699 from zdover23/wip-doc-2022-11-02-dev-osd-internals-ec-gloss...
zdover23 [Wed, 2 Nov 2022 05:15:02 +0000 (15:15 +1000)]
Merge pull request #48699 from zdover23/wip-doc-2022-11-02-dev-osd-internals-ec-glossary-fixes

doc/dev: refine erasure_coding.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/dev: refine erasure_coding.rst 48699/head
Zac Dover [Wed, 2 Nov 2022 03:45:48 +0000 (13:45 +1000)]
doc/dev: refine erasure_coding.rst

Improve the readability and clarity of
erasure_coding.rst.

Co-author: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48687 from StevenWash/bugfix/fix_command_error_blank
Anthony D'Atri [Tue, 1 Nov 2022 13:55:19 +0000 (09:55 -0400)]
Merge pull request #48687 from StevenWash/bugfix/fix_command_error_blank

doc/radosgw: fix command error blank

2 years agodoc/radosgw: fix command error blank 48687/head
stevenhua [Tue, 1 Nov 2022 01:53:02 +0000 (09:53 +0800)]
doc/radosgw: fix command error blank

2 years agoMerge pull request #48684 from zdover23/wip-doc-2022-11-01-dev-osd-internals-ec-gloss...
zdover23 [Tue, 1 Nov 2022 00:57:30 +0000 (10:57 +1000)]
Merge pull request #48684 from zdover23/wip-doc-2022-11-01-dev-osd-internals-ec-glossary-alphabetize

doc/dev: alphabetize EC glossary

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/dev: alphabetize EC glossary 48684/head
Zac Dover [Tue, 1 Nov 2022 00:47:52 +0000 (10:47 +1000)]
doc/dev: alphabetize EC glossary

Alphabetize the glossary in
doc/dev/osd_internals/erasure_coding.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48673 from idryomov/wip-49947
Ilya Dryomov [Mon, 31 Oct 2022 18:33:30 +0000 (19:33 +0100)]
Merge pull request #48673 from idryomov/wip-49947

doc: note architecture availability for PMEM mode of PWL cache

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #48548 from dparmar18/update_debug_script
Matan [Mon, 31 Oct 2022 12:57:08 +0000 (14:57 +0200)]
Merge pull request #48548 from dparmar18/update_debug_script

script/ceph-debug-docker.sh: change default branch to main

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #48674 from zdover23/doc-2022-10-31-dev-osd-internals-ec-glossary
zdover23 [Mon, 31 Oct 2022 03:43:46 +0000 (13:43 +1000)]
Merge pull request #48674 from zdover23/doc-2022-10-31-dev-osd-internals-ec-glossary

doc/dev: improve EC glossary

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/dev: improve EC glossary 48674/head
Zac Dover [Mon, 31 Oct 2022 03:17:45 +0000 (13:17 +1000)]
doc/dev: improve EC glossary

Improve the clarity and syntax of the text in
doc/dev/osd_internals/erasure_coding.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc: note architecture availability for PMEM mode of PWL cache 48673/head
Ilya Dryomov [Sun, 30 Oct 2022 17:06:57 +0000 (18:06 +0100)]
doc: note architecture availability for PMEM mode of PWL cache

Fixes: https://tracker.ceph.com/issues/49947
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #48667 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare...
zdover23 [Sun, 30 Oct 2022 06:07:38 +0000 (16:07 +1000)]
Merge pull request #48667 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-colemitchell-notes

doc/ceph-volume: refine Filestore docs

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/ceph-volume: refine Filestore docs 48667/head
Zac Dover [Sun, 30 Oct 2022 05:27:24 +0000 (15:27 +1000)]
doc/ceph-volume: refine Filestore docs

Add Cole Mitchell's improvements to the filestore section.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48665 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare...
zdover23 [Sun, 30 Oct 2022 00:49:31 +0000 (10:49 +1000)]
Merge pull request #48665 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-datri-notes

doc/ceph-volume: improve prepare.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/ceph-volume: improve prepare.rst 48665/head
Zac Dover [Sat, 29 Oct 2022 22:46:26 +0000 (08:46 +1000)]
doc/ceph-volume: improve prepare.rst

Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/48651.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48090 from joscollin/wip-F55197-cephfs-top-scroll
Jos Collin [Sat, 29 Oct 2022 02:09:55 +0000 (07:39 +0530)]
Merge pull request #48090 from joscollin/wip-F55197-cephfs-top-scroll

cephfs-top: make cephfs-top display scrollable

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoMerge pull request #48662 from ceph/wip-update-stale-bot
Laura Flores [Fri, 28 Oct 2022 20:02:07 +0000 (15:02 -0500)]
Merge pull request #48662 from ceph/wip-update-stale-bot

.github/workflows: update `days-before-pr-close`

2 years ago.github/workflows: update `days-before-pr-close` 48662/head
Laura Flores [Fri, 28 Oct 2022 18:24:33 +0000 (13:24 -0500)]
.github/workflows: update `days-before-pr-close`

Currently, the stale bot closes PRs 90 days after they are marked stale since it counts "marking a PR stale" as activity.

We really want the PRs to close after a total of 90 days, or 30 days after they are marked stale. Changing `days-before-prs-close` to 30 will fix this.

Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agocommon: fix build with GCC 13 (missing <cstdint> include) 48661/head
Sam James [Fri, 28 Oct 2022 15:47:38 +0000 (16:47 +0100)]
common: fix build with GCC 13 (missing <cstdint> include)

Needed for uint8_t. Only worked by chance before (see
https://www.gnu.org/software/gcc/gcc-13/porting_to.html).

```
FAILED: src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DBOOST_ASIO_DISABLE_THREAD_KEYWORD_EXTENSION -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D__CEPH__ -D__STDC_FORMAT_MACROS -D__linux__ -I/var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5_build/src/include -I/var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src -isystem /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5_build/include -isystem /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/xxHash -isystem /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/rapidjson/include  -O2 -march=native -pipe -fPIC   -U_FORTIFY_SOURCE -Wall -fno-strict-aliasing -fsigned-char -Wtype-limits -Wignored-qualifiers -Wpointer-arith -Werror=format-security -Winit-self -Wno-unknown-pragmas -Wnon-virtual-dtor -Wno-ignored-qualifiers -ftemplate-depth-1024 -Wpessimizing-move -Wredundant-move -Wstrict-null-sentinel -Woverloaded-virtual -fno-new-ttp-matching -fstack-protector-strong -fdiagnostics-color=auto -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-free -std=c++17 -MD -MT src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o -MF src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o.d -o src/CMakeFiles/common-objs.dir/mds/FSMapUser.cc.o -c /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/FSMapUser.cc
In file included from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/log/SubsystemMap.h:12,
                 from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/common/config.h:23,
                 from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/mdstypes.h:13,
                 from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/FSMapUser.h:21,
                 from /var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/mds/FSMapUser.cc:1:
/var/tmp/portage/sys-cluster/ceph-17.2.5/work/ceph-17.2.5/src/common/subsys_types.h:56:23: error: ‘uint8_t’ in namespace ‘std’ does not name a type; did you mean ‘wint_t’?
```

Bug: https://bugs.gentoo.org/878531
Signed-off-by: Sam James <sam@gentoo.org>
2 years agoMerge pull request #48658 from zdover23/wip-doc-2022-10-28-radosgw-multisite-prompts
zdover23 [Fri, 28 Oct 2022 13:54:31 +0000 (23:54 +1000)]
Merge pull request #48658 from zdover23/wip-doc-2022-10-28-radosgw-multisite-prompts

doc/radosgw: add prompts to multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/radosgw: add prompts to multisite.rst 48658/head
Zac Dover [Fri, 28 Oct 2022 13:37:16 +0000 (23:37 +1000)]
doc/radosgw: add prompts to multisite.rst

Add unselectable prompts to multisite.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #47582 from snosratiershad/docs/correct-add-system-user-to-the...
zdover23 [Fri, 28 Oct 2022 11:14:03 +0000 (21:14 +1000)]
Merge pull request #47582 from snosratiershad/docs/correct-add-system-user-to-the-master-zone-command

docs: correct add system user to the master zone command

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2 years agocephfs-top: Select Filesystem Screen fixes for no FS 48090/head
Jos Collin [Mon, 19 Sep 2022 12:35:43 +0000 (18:05 +0530)]
cephfs-top: Select Filesystem Screen fixes for no FS

* drop the blank FS Menu when there is no FS
* cleanup display_fs_menu() code

Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agodoc: Update cephfs-top.png
Jos Collin [Wed, 19 Oct 2022 11:07:53 +0000 (16:37 +0530)]
doc: Update cephfs-top.png

Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agocephfs-top: make cephfs-top display scrollable
Jos Collin [Thu, 8 Sep 2022 09:51:24 +0000 (15:21 +0530)]
cephfs-top: make cephfs-top display scrollable

Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #40363 from orozery/rbd-clone-encryption
Ilya Dryomov [Tue, 25 Oct 2022 16:16:33 +0000 (18:16 +0200)]
Merge pull request #40363 from orozery/rbd-clone-encryption

librbd: add encryption format support for clones (part 1/2)

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #48587 from zdover23/wip-doc-2022-10-22-cephadm-host-management...
zdover23 [Fri, 21 Oct 2022 18:04:56 +0000 (04:04 +1000)]
Merge pull request #48587 from zdover23/wip-doc-2022-10-22-cephadm-host-management-prompts

doc/cephadm: add prompts to host-management.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #48555 from phlogistonjohn/jjm-unify-test-alertmanager-config
Adam King [Fri, 21 Oct 2022 16:55:27 +0000 (12:55 -0400)]
Merge pull request #48555 from phlogistonjohn/jjm-unify-test-alertmanager-config

mgr/cephadm: consolidate test_alertmanager_config_* tests into one

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agodoc/cephadm: add prompts to host-management.rst 48587/head
Zac Dover [Fri, 21 Oct 2022 16:42:33 +0000 (02:42 +1000)]
doc/cephadm: add prompts to host-management.rst

This PR adds unselectable prompts to host-management.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48478 from myoungwon/wip-rbm-move-mkfs-cleanup
Yingxin [Fri, 21 Oct 2022 10:01:15 +0000 (18:01 +0800)]
Merge pull request #48478 from myoungwon/wip-rbm-move-mkfs-cleanup

crimson/os/seastore/rbm: move mkfs to RBMDevice and use device_config_t

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #48445 from rzarzynski/wip-crimson-fix-obcload-errs
Radoslaw Zarzynski [Fri, 21 Oct 2022 07:35:56 +0000 (09:35 +0200)]
Merge pull request #48445 from rzarzynski/wip-crimson-fix-obcload-errs

crimson/osd: send proper reply on obc load failure

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48577 from zdover23/wip-doc-2022-10-21-radosgw-notifications...
zdover23 [Fri, 21 Oct 2022 03:47:56 +0000 (13:47 +1000)]
Merge pull request #48577 from zdover23/wip-doc-2022-10-21-radosgw-notifications-and-event

doc/radosgw: refine "notifications" and "events"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/radosgw: refine "notifications" and "events" 48577/head
Zac Dover [Fri, 21 Oct 2022 03:07:16 +0000 (13:07 +1000)]
doc/radosgw: refine "notifications" and "events"

This commit refines the English in the "Notifications"
and "Events" sections of the notifications.rst page
(the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocrimson/os/seastore/cbj: handle remaing space (from written_to to the end of the... 48478/head
myoungwon oh [Fri, 21 Oct 2022 01:56:58 +0000 (10:56 +0900)]
crimson/os/seastore/cbj: handle remaing space (from written_to to the end of the journal) is less than the requested size

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/rbm: move test interfaces to the end of the class
myoungwon oh [Thu, 20 Oct 2022 05:21:49 +0000 (14:21 +0900)]
crimson/os/seastore/rbm: move test interfaces to the end of the class

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agocrimson/os/seastore/cbj: rename size-related interfaces with grouping
myoungwon oh [Thu, 20 Oct 2022 05:16:51 +0000 (14:16 +0900)]
crimson/os/seastore/cbj: rename size-related interfaces with grouping

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 years agoMerge pull request #48477 from rzarzynski/wip-crimson-rollback-delete-head
Samuel Just [Fri, 21 Oct 2022 01:27:55 +0000 (18:27 -0700)]
Merge pull request #48477 from rzarzynski/wip-crimson-rollback-delete-head

crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48572 from zdover23/wip-doc-2022-10-21-cephadm-host-management...
zdover23 [Thu, 20 Oct 2022 19:22:53 +0000 (05:22 +1000)]
Merge pull request #48572 from zdover23/wip-doc-2022-10-21-cephadm-host-management-os-tuning-grammar

doc/cephadm: refine "os tuning" in h. management

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephadm: refine "os tuning" in h. management 48572/head
Zac Dover [Thu, 20 Oct 2022 18:43:24 +0000 (04:43 +1000)]
doc/cephadm: refine "os tuning" in h. management

This commit refines the English in the "OS Tuning Profiles" section of
the "Host Management" page of the cephadm documentation. This commit is
made separately from but in anticipation of a forthcoming commit that
corrects technical (non-grammatical) errors.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #46089 from myoungwon/wip-dedup-doc
zdover23 [Thu, 20 Oct 2022 15:54:56 +0000 (01:54 +1000)]
Merge pull request #46089 from myoungwon/wip-dedup-doc

doc/dev: add explanation of how to use deduplication

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK 48477/head
Radoslaw Zarzynski [Thu, 13 Oct 2022 11:54:35 +0000 (11:54 +0000)]
crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

This allows to pass `TestLibRBD.TestIOToSnapshot`:

```
[rzarzynski@o06 build]$ CRIMSON_COMPAT=true RBD_FEATURES=1 bin/ceph_test_librbd --gtest_filter=TestLibRBD.TestIOToSnapshot
seed 3954016
Note: Google Test filter = TestLibRBD.TestIOToSnapshot
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestLibRBD
[ RUN      ] TestLibRBD.TestIOToSnapshot
using new format!
...
opening testimg@orig
read: 80
write to snapshot returned -30
Read-only file system
num snaps is: 2
expected: 2
snap: orig
snap: written
found orig with size 2097152
found written with size 2097152
num snaps is: 1
expected: 1
snap: orig
found orig with size 2097152
num snaps is: 0
expected: 0
[       OK ] TestLibRBD.TestIOToSnapshot (7510 ms)
[----------] 1 test from TestLibRBD (7510 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (8504 ms total)
[  PASSED  ] 1 test.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #48246 from liangmingyuanneo/fix-throttle-test
Casey Bodley [Thu, 20 Oct 2022 13:42:35 +0000 (09:42 -0400)]
Merge pull request #48246 from liangmingyuanneo/fix-throttle-test

test/rgw: improve integrity of rgw throttle test

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agocrimson/osd: ClientRequest sends error to client when loading obc fails 48445/head
Radoslaw Zarzynski [Tue, 11 Oct 2022 13:38:30 +0000 (13:38 +0000)]
crimson/osd: ClientRequest sends error to client when loading obc fails

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #48456 from rhcs-dashboard/cypress-video-enable
Nizamudeen A [Thu, 20 Oct 2022 06:07:52 +0000 (11:37 +0530)]
Merge pull request #48456 from rhcs-dashboard/cypress-video-enable

mgr/dashboard: enable cypress video on test fails

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #48546 from rhcs-dashboard/update-node
Nizamudeen A [Thu, 20 Oct 2022 06:07:07 +0000 (11:37 +0530)]
Merge pull request #48546 from rhcs-dashboard/update-node

cmake: bump node version to 14

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 years agoMerge pull request #48505 from zhscn/fix-uaf
Kefu Chai [Thu, 20 Oct 2022 03:20:51 +0000 (11:20 +0800)]
Merge pull request #48505 from zhscn/fix-uaf

crimson/osd: fix use after free error in FuturizedStoreLogReader::read

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48556 from zdover23/wip-doc-2022-10-20-radosgw-notifications...
zdover23 [Wed, 19 Oct 2022 21:51:36 +0000 (07:51 +1000)]
Merge pull request #48556 from zdover23/wip-doc-2022-10-20-radosgw-notifications-bucket-notifications-rest-api

doc/radosgw: refine "bucket notifications"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/radosgw: refine "bucket notifications" 48556/head
Zac Dover [Wed, 19 Oct 2022 18:35:14 +0000 (04:35 +1000)]
doc/radosgw: refine "bucket notifications"

This commit refines the English in the "Bucket Notifications REST API"
section of the notifications.rst page (the "Bucket Notifications" page).

Co-author: Cole Mitchell <cole.mitchell@gmail.com>

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #47848 from galsalomon66/s3select_next_version
Casey Bodley [Wed, 19 Oct 2022 19:44:27 +0000 (15:44 -0400)]
Merge pull request #47848 from galsalomon66/s3select_next_version

moving to next version of s3select.

Reviewed-by: Casey Bodley <cbodley@redhat.com>