]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Adam King [Sun, 22 Jan 2023 16:52:10 +0000 (11:52 -0500)]
mgr/cephadm: fix error_ok not being passed in unit tests
Signed-off-by: Adam King <adking@redhat.com>
Mykola Golub [Sun, 20 Nov 2022 13:11:11 +0000 (13:11 +0000)]
mgr/cephadm: try to avoid pull when getting container image info
Fixes: https://tracker.ceph.com/issues/58051
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
Mykola Golub [Sat, 26 Nov 2022 08:39:54 +0000 (08:39 +0000)]
mgr/cephadm: allow _run_cephadm_json to be silent on error
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
Lucian Petrut [Fri, 17 Feb 2023 10:11:15 +0000 (12:11 +0200)]
Merge pull request #49961 from stefan-chivu/test_rbd_wnbd_latency
qa: Added latency to results table in test_rbd_wnbd.py
Casey Bodley [Thu, 16 Feb 2023 17:22:41 +0000 (12:22 -0500)]
Merge pull request #49709 from yima77/rgw_fix_mp_upload_obj_leak_due_to_reupload
rgw: fix multipart upload object leaks due to re-upload
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Lucian Petrut [Tue, 7 Feb 2023 13:13:54 +0000 (15:13 +0200)]
quincy: qa: update test_rbd_wnbd.py to report latency in seconds
At the moment, the latency results are reported in nanoseconds.
In order to improve readability, we'll convert it to seconds.
While at it, we'll fix the fio duration report, which we're
wrongfully dividing by 1000 twice.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Stefan Chivu [Wed, 1 Feb 2023 15:38:52 +0000 (15:38 +0000)]
qa: Added latency to results table in test_rbd_wnbd.py
Added data regarding completion latency (ns) to the fio results
table, such as min, max, mean, stddev, etc.
Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
Nizamudeen A [Thu, 16 Feb 2023 10:51:12 +0000 (16:21 +0530)]
Merge pull request #50109 from rhcs-dashboard/landing-page-v3
mgr/dashboard: Landing page v3
Reviewed-by: bryanmontalvan <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Thu, 16 Feb 2023 06:50:51 +0000 (12:20 +0530)]
Merge pull request #50114 from rhcs-dashboard/cephadm-prom-401-error
mgr/dashboard: ignore the rules 400 error in dashboard kcli e2e
Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Yingxin [Thu, 16 Feb 2023 02:30:56 +0000 (10:30 +0800)]
Merge pull request #50111 from rzarzynski/wip-crimson-osd-ftbfs-fmtptr
crimson/osd: fix FTBFS due to smart-ptr-to-bool conversion in fmt::ptr
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Anthony D'Atri [Thu, 16 Feb 2023 01:55:25 +0000 (20:55 -0500)]
Merge pull request #50138 from zdover23/wip-doc-2023-02-16-radosgw-realms-refinement
doc/rgw: refine "Realms" section
Zac Dover [Wed, 15 Feb 2023 23:56:53 +0000 (09:56 +1000)]
doc/rgw: refine "Realms" section
Make various syntactical and semantic improvements to "Realms" section.
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Wed, 15 Feb 2023 23:37:13 +0000 (09:37 +1000)]
Merge pull request #50119 from zdover23/wip-doc-2023-02-15-multisite-zonegroup-spelling-correction
doc/rgw: s/[Zz]one [Gg]roup/zonegroup/g
Guillaume Abrioux [Wed, 15 Feb 2023 19:09:30 +0000 (20:09 +0100)]
Merge pull request #50017 from guits/fix-simple-scan-dir
ceph-volume: do not raise RuntimeError in util.lsblk
Adam King [Wed, 15 Feb 2023 16:04:38 +0000 (11:04 -0500)]
Merge pull request #50062 from phlogistonjohn/jjm-more-cephadm-tests
cephadm: a few more utility function tests
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Adam King [Wed, 15 Feb 2023 14:17:40 +0000 (09:17 -0500)]
Merge pull request #50084 from adk3798/cephadm-autopep8-error
cephadm: fix autopep8 arg parsing on newer tox versions
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Venky Shankar [Wed, 15 Feb 2023 13:28:29 +0000 (18:58 +0530)]
Merge PR #48053 into main
* refs/pull/48053/head:
test/libcephfs: fix rebasing issues
libcephfs: replace errno.h errors with CEPHFS_E*
messages: avoid converting ceph errors on Windows
client: use CEPHFS_E*
test/libcephfs: use CEPHFS_E* errors
libcephfs: switch to CEPHFS_E* errors
test/libcephfs: disable flaky timestamp assertion on Windows
client: use _setattrx when changing timestamps
client: set nsec to 0 when converting stat struct on Windows
test/libcephfs: skip dirent inode check on Windows
client: avoid trimming inodes on Windows
test/libcephfs: address windows issues
test/libcephfs: include compat.h
test/libcephfs: enable the tests on Windows
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Pedro Gonzalez Gomez [Tue, 11 Oct 2022 17:43:34 +0000 (19:43 +0200)]
mgr/dashboard: dashboard-v3: cluster-utilization card
mgr/dashboard: some improvements
mgr/dashboard: updated promqls and improved tooltips
mgr/dashboard: some fixes and improvements
mgr/dashboard: added square box plugin and improved/fixed code
mgr/dashboard: added maxValue option for graphs and added tooltips to text
mgr/dashboard: removed unnecessary variables
mgr/dashboard: fix openapi
tracker: https://tracker.ceph.com/issues/57863
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
bryanmontalvan [Wed, 10 Aug 2022 18:22:02 +0000 (14:22 -0400)]
mgr/dashboard: dashboard-v3: inventory card
This commit starts the inventory-card which is one of the cards which
will be located in the landing-page revamp
tracker: https://tracker.ceph.com/issues/58065
Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
bryanmontalvan [Wed, 3 Aug 2022 01:39:05 +0000 (21:39 -0400)]
mgr/dashboard: dashboard-v3: status card
This commit is the bare-bones work of the status card. The only logic
written in this commit is the Cluster health status icon.
tracker: https://tracker.ceph.com/issues/58728
Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
mgr/dashboard: introduce active alerts to status cards
Signed-off-by: Nizamudeen A <nia@redhat.com>
Pedro Gonzalez Gomez [Mon, 1 Aug 2022 20:17:29 +0000 (22:17 +0200)]
xmgr/dashboard: dashboard-v3: capacity card
tracker: https://tracker.ceph.com/issues/57862
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: fix openapi tox error
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: capacity-card set interval and display bytes used
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: Landing Page v3
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Pedro Gonzalez Gomez [Mon, 25 Jul 2022 19:50:47 +0000 (21:50 +0200)]
mgr/dashboard: dashboard-v3: details card
mgr/dashboard: added interface, changed html table to list, using mgrModuleService now
tracker: https://tracker.ceph.com/issues/58731
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
bryanmontalvan [Thu, 7 Jul 2022 16:36:15 +0000 (12:36 -0400)]
mgr/dashboard: dashboard-v3: landing-page revamp
This commit add the following
- A new dashboard component, which will exist in parallel with in the
current landing-page
- Created a route for this dashboard `/dashboard_3`
- Created a bare-bones bootstrap grid with mock-up card components
Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: changes to first layout
CHANGES:
- Renamed dashboardcomponents
- Removed unnecesary styling
- Added unit tests
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Moved router.url logic inside html template
This commit removes the `this.router.url` logic which was located in the
`workbench-layout.component.ts` file and moved it into the HTML template
section.
Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
mgr/dashboard: syntax changes from bootstrap 4 to 5
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: small fixes and improvements over all cards and layout
- all cards placed evenly with the same height
- increased font size on details card and adjusted margin
- changed capacity card legend to: "Used"
- adjusted cluster utilization card margins and increased graphs height
- improved status card toggle
- changed orchestror to orchestrator
- switched IPS/OPS graph colors
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: added recovery throghput graph, improve promqls, fix inventory's card lines
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Ronen Friedman [Wed, 15 Feb 2023 10:06:58 +0000 (12:06 +0200)]
Merge pull request #44749 from ronen-fr/wip-rf-large-chunk
osd/scrub: use separate chunk size configuration for shallow scrubs
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
Anthony D'Atri [Wed, 15 Feb 2023 09:56:35 +0000 (04:56 -0500)]
Merge pull request #50120 from zdover23/wip-doc-2023-02-15-glossary-realm
doc/glossary: add "realm" to glossary
Zac Dover [Wed, 15 Feb 2023 07:51:41 +0000 (17:51 +1000)]
doc/glossary: add "realm" to glossary
Add the term "Realm" to the glossary, and link to the section in the RGW
documentation that provides more information about realms.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Nizamudeen A [Tue, 14 Feb 2023 15:34:26 +0000 (21:04 +0530)]
mgr/dashboard: ignore the rules 400 error in dashboard kcli e2e
Fixes: https://tracker.ceph.com/issues/58722
Signed-off-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Wed, 15 Feb 2023 06:38:01 +0000 (12:08 +0530)]
Merge pull request #50057 from rhcs-dashboard/nfs-exports-return-fix
mgr/dashboard: adapt nfs export code to the new changes in nfs module
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Zac Dover [Wed, 15 Feb 2023 05:05:43 +0000 (15:05 +1000)]
doc/rgw: s/[Zz]one [Gg]roup/zonegroup/g
Change all instances of "Zone Group" and "Zone group" and "zone group"
to "Zonegroup" or "zonegroup".
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Wed, 15 Feb 2023 04:39:36 +0000 (14:39 +1000)]
Merge pull request #50108 from zdover23/wip-doc-2023-02-13-multisite-multisite-config-reference
doc/rgw: refine "Multi-site Config Ref" (1 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Samuel Just [Wed, 15 Feb 2023 03:57:02 +0000 (19:57 -0800)]
Merge pull request #50019 from rzarzynski/wip-crimson-fix-zeroed-startevent
crimson/osd: fix zeroed starting timestamp of tracked ops
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Yingxin [Wed, 15 Feb 2023 01:13:06 +0000 (09:13 +0800)]
Merge pull request #49420 from cyx1231st/wip-seastar-msgr-multi-core
crimson/net: refactors to encapsulate ProtocolV2 message read and write paths and event dispatching
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Zac Dover [Tue, 14 Feb 2023 11:53:02 +0000 (21:53 +1000)]
doc/rgw: refine "Multi-site Config Ref" (1 of x)
Refine the syntax (and in some cases, the semantics) of the English in
"Multi-site Configuration Reference" in doc/radosgw/multisite.rst. This
is a long section, so more PRs are likely.
https://tracker.ceph.com/issues/58632
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Laura Flores [Tue, 14 Feb 2023 21:39:09 +0000 (15:39 -0600)]
Merge pull request #47555 from JoshSalomon/wip-prim-balance-score
mon, osd: Adding read (aka workload, primary) balance score
John Mulligan [Thu, 9 Feb 2023 21:37:36 +0000 (16:37 -0500)]
cephadm/tests: add test coverage of get_distro function
Signed-off-by: John Mulligan <jmulligan@redhat.com>
John Mulligan [Thu, 9 Feb 2023 21:17:29 +0000 (16:17 -0500)]
cephadm/tests: add test coverage of check_time_sync function
This is also effectively full coverage of `check_units` as well
as check_time_sync is the only consumer.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Anthony D'Atri [Tue, 14 Feb 2023 14:39:12 +0000 (09:39 -0500)]
Merge pull request #50104 from cityofships/fix_docs_lvm_activate
doc/ceph-volume: fix cephadm references
Radoslaw Zarzynski [Tue, 14 Feb 2023 14:37:30 +0000 (14:37 +0000)]
crimson/osd: fix FTBFS due to smart-ptr-to-bool conversion in fmt::ptr
```
../src/fmt/include/fmt/format.h: In instantiation of ‘const void* fmt::v9::ptr(T) [with T = seastar::shared_ptr<crimson::net::SocketConnection>]’:
../src/crimson/net/ProtocolV2.cc:1109:72: required from here
../src/fmt/include/fmt/format.h:3809:37: error: static assertion failed
3809 | static_assert(std::is_pointer<T>::value, "");
| ^~~~~
../src/fmt/include/fmt/format.h:3809:37: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Casey Bodley [Tue, 14 Feb 2023 14:11:42 +0000 (09:11 -0500)]
Merge pull request #50102 from cbodley/wip-github-examples-rgw
examples: move rgw examples under subdirectory
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
kalebskeithley [Tue, 14 Feb 2023 12:56:26 +0000 (07:56 -0500)]
Merge pull request #50099 from kalebskeithley/rgw_token.gcc13
rgw: rgw_token.cc error: reference to 'formatter' is ambiguous
Nizamudeen A [Tue, 14 Feb 2023 12:44:42 +0000 (18:14 +0530)]
Merge pull request #49801 from rhcs-dashboard/service-instances-flickering
mgr/dashboard: move service_instances logic to backend
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Casey Bodley [Mon, 13 Feb 2023 22:18:49 +0000 (17:18 -0500)]
doc/rgw: update links to examples/rgw
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Nizamudeen A [Tue, 14 Feb 2023 12:33:28 +0000 (18:03 +0530)]
Merge pull request #49834 from rhcs-dashboard/rgw-list-roles
mgr/dashboard: rgw role listing
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Thu, 9 Feb 2023 15:59:41 +0000 (21:29 +0530)]
mgr/dashboard: adapt nfs export code to the new changes in nfs module
when you create/edit an nfs export from dashboard it leaves this traceback and error
```
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard ERROR taskexec] Error while calling Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
Traceback (most recent call last):
File "/usr/share/ceph/mgr/dashboard/tools.py", line 550, in _run
val = self.task.fn(*self.task.fn_args, **self.task.fn_kwargs) # type: ignore
File "/usr/share/ceph/mgr/dashboard/controllers/nfs.py", line 148, in create
ret, _, err = export_mgr.apply_export(cluster_id, json.dumps(raw_ex))
TypeError: 'AppliedExportResults' object is not iterable
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO taskmgr] finished Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO request] [::ffff:192.168.100.1:43896] [POST] [500] [0.767s] [admin] [172.0B] /api/nfs-ganesha/export
```
This started after https://github.com/ceph/ceph/pull/46209, so dashboard code needs to be adapted
Fixes: https://tracker.ceph.com/issues/58681
Signed-off-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Fri, 20 Jan 2023 10:28:12 +0000 (15:58 +0530)]
mgr/dashboard: move service_instances logic to backend
Fixes: https://tracker.ceph.com/issues/58504
Signed-off-by: Nizamudeen A <nia@redhat.com>
Josh Salomon [Mon, 18 Apr 2022 08:37:13 +0000 (11:37 +0300)]
osd, mon: add read balance score to command `ceph osd pool ls detail`
for replicated pools.
osd: Added workload balance score to the command
ceph osd pool ls detail
(different flavors for console output and json/xml output)
mon: Added command 'osd rm-primary-temp'
(developers only) rm was not working
vstart: Added osd debug messages into mon log with -d flag
For commands that execute methonds in OSD module
Signed-off-by: Josh Salomon <jsalomon@redhat.com>
Nizamudeen A [Tue, 14 Feb 2023 10:24:54 +0000 (15:54 +0530)]
Merge pull request #50051 from rhcs-dashboard/rbd-mirroring-status-fix
mgr/dashboard: fix rbd mirroring daemon health status
Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Pere Diaz Bou [Mon, 23 Jan 2023 11:34:12 +0000 (12:34 +0100)]
mgr/dashboard: rgw role listing
Listing is performed using the radosgw-admin command api we have with
the mgr for now until the S3 api is fixed: https://tracker.ceph.com/issues/58547.
This commit fixes and issue with regards to the _crud.py controller
where redefining `CRUDClassMetadata` caused the users table and the
roles table to share columns. We fixed this by creating
CRUDClassMetadata dynamically for each endpoint.
The issue described above is linked to an issue with NamedTuple were
default nested lists are not a great move because it can cause
unexpected issues when 2 or more classes are created. Moreover,
NamedTuples are read-only making initialization even harder without
factory methods as with dataclasses. Therefore, let's move to the good
old __init__ :).
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Fixes: https://tracker.ceph.com/issues/58699
Piotr Parczewski [Tue, 14 Feb 2023 08:12:30 +0000 (09:12 +0100)]
doc/ceph-volume: fix cephadm references
Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
Samuel Just [Tue, 14 Feb 2023 07:00:05 +0000 (23:00 -0800)]
Merge pull request #49729 from rzarzynski/wip-crimson-obcregistry-per-pg
crimson/osd: make the ObjectContextRegistry per-PG
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Samuel Just [Tue, 14 Feb 2023 06:58:55 +0000 (22:58 -0800)]
Merge pull request #49020 from xxhdx1985126/wip-pg-remove
crimson/osd: implement pg removal
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Ronen Friedman [Mon, 24 Jan 2022 08:43:41 +0000 (08:43 +0000)]
osd/scrub: create a separate chunk size conf for shallow scrubs
Using the existing common default chunk size for scrubs that are
not deep scrubs is wasteful: a high ratio of inter-OSD messages
per chunk, while the actual OSD work per chunk is minimal.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Venky Shankar [Tue, 14 Feb 2023 04:41:34 +0000 (10:11 +0530)]
Merge pull request #50058 from rishabh-d-dave/vstart-client-debug
vstart.sh: set logging for client and MDS when -d is passed
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Casey Bodley [Mon, 13 Feb 2023 22:17:18 +0000 (17:17 -0500)]
examples: move rgw examples under subdirectory
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ilya Dryomov [Mon, 13 Feb 2023 22:05:43 +0000 (23:05 +0100)]
Merge pull request #50076 from idryomov/wip-codeowners-doc-writers-fix
CODEOWNERS: don't override doc-writers by core and rbd for some files
Reviewed-by: Neha Ojha <nojha@redhat.com>
Samuel Just [Mon, 13 Feb 2023 20:44:51 +0000 (12:44 -0800)]
Merge pull request #50070 from xxhdx1985126/wip-sync-peering-backfill
crimson/osd/pg: synchronize processing of peering events and backfill
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Samuel Just [Mon, 13 Feb 2023 20:44:05 +0000 (12:44 -0800)]
Merge pull request #49344 from xxhdx1985126/wip-obc-watchers-checkonload
crimson/osd/object_context_loader: check on old watchers when loading obcs
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 13 Feb 2023 20:43:32 +0000 (12:43 -0800)]
Merge pull request #49955 from xxhdx1985126/wip-pg-stats-read
crimson/osd/ops_executor: apply delta stats for pure read ops
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 13 Feb 2023 20:42:45 +0000 (12:42 -0800)]
Merge pull request #50018 from Matan-B/wip-matanb-c-pg-pipeline
crimson/osd/osd_operations: Remove replicated_request_pg_pipeline
Reviewed-by: Samuel Just <sjust@redhat.com>
Ilya Dryomov [Sat, 11 Feb 2023 09:43:50 +0000 (10:43 +0100)]
CODEOWNERS: don't override doc-writers by core and rbd for some files
This happens because core and rbd ownership is defined after
doc-writers: a later match takes precedence.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Kaleb S. KEITHLEY [Mon, 13 Feb 2023 16:15:59 +0000 (11:15 -0500)]
rgw: rgw_token.cc error: reference to 'formatter' is ambiguous
compiling main branch on Fedora 38 and 39/rawhide with gcc-c++-13.0.1
fails with the error:
/builddir/build/BUILD/
ceph-18.0.0-2148-g9754cafc /src/rgw/rgw_token.cc:
In function 'int main(int, char**)':
/builddir/build/BUILD/
ceph-18.0.0-2148-g9754cafc /src/rgw/rgw_token.cc:125:3:
error: reference to 'formatter' is ambiguous
125 | formatter = new JSONFormatter(true /* pretty */);
| ^~~~~~~~~
Similar error for src/test/test_rgw_token.cc
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Casey Bodley [Mon, 13 Feb 2023 15:53:42 +0000 (10:53 -0500)]
Merge pull request #50073 from cbodley/wip-codeowners-rgw
github: add rgw team to CODEOWNERS
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Adam King [Mon, 13 Feb 2023 15:09:07 +0000 (10:09 -0500)]
Merge pull request #49555 from fmount/drive_group_crush
Add per OSD crush_device_class definition
Reviewed-by: Adam King <adking@redhat.com>
zdover23 [Mon, 13 Feb 2023 12:46:05 +0000 (22:46 +1000)]
Merge pull request #50086 from zdover23/wip-doc-2023-02-13-multisite-migrating-single-site-to-multi-site
doc/rgw: "Migrating Single Site to Multi-Site"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 13 Feb 2023 05:35:32 +0000 (15:35 +1000)]
doc/rgw: "Migrating Single Site to Multi-Site"
Refine "Migrating Single-site System to Multi-site" in
doc/radosgw/multisite.rst.
https://tracker.ceph.com/issues/58632
Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthonh D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ilya Dryomov [Mon, 13 Feb 2023 11:54:26 +0000 (12:54 +0100)]
Merge pull request #50071 from idryomov/wip-58688
qa/suites/rbd: fix sporadic "rx-only direction" test failures
Reviewed-by: Ramana Raja <rraja@redhat.com>
Yingxin Cheng [Mon, 13 Feb 2023 06:42:13 +0000 (14:42 +0800)]
crimson/net: fix the corner case when the replacing connection doesn't have socket
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 13 Feb 2023 05:37:25 +0000 (13:37 +0800)]
test/crimson: improve messenger test coverage
* add blockings at custom_bp_t::SOCKET_CONNECTING
* adjust peer_wins to true
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 13 Feb 2023 03:35:35 +0000 (11:35 +0800)]
test/crimson: enable blocking with custom_bp_t::SOCKET_CONNECTING in messenger test
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 13 Feb 2023 03:28:19 +0000 (11:28 +0800)]
test/crimson: cleanup messenger test addresses
Consolidate the name/port/nonce of the addresses used in the messenger
unit tests.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Adam King [Mon, 13 Feb 2023 03:18:25 +0000 (22:18 -0500)]
cephadm: fix autopep8 arg parsing on newer tox versions
This was failing for me on new tox versions with
fix: commands[1]> autopep8 --max-line-length 100
incorrect number of argumentsfix: exit 99 (0.06 seconds) /home/adking/ceph/src/cephadm> autopep8 --max-line-length 100 pid=309039
fix: FAIL ✖ in 0.08 seconds
As it was considering our list of args for autopep8 to each be
one separate command. Fixed by just adding slashes to the ends
of the lines (as has already been done in the tox.ini in src/pybind/mgr
for some of the tests there)
Signed-off-by: Adam King <adking@redhat.com>
Casey Bodley [Sun, 12 Feb 2023 16:00:59 +0000 (11:00 -0500)]
github: add /examples to CODEOWNERS
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Anthony D'Atri [Sun, 12 Feb 2023 04:54:45 +0000 (23:54 -0500)]
Merge pull request #50077 from zdover23/wip-doc-2023-02-12-multisite-failover
doc/rgw: refine "Failover and Disaster Recovery"
Zac Dover [Sat, 11 Feb 2023 22:04:34 +0000 (08:04 +1000)]
doc/rgw: refine "Failover and Disaster Recovery"
English grammar and syntax pass for "Failover and Disaster Recovery" in
doc/radosgw/multisite.rst.
https://tracker.ceph.com/issues/58632
Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Fri, 10 Feb 2023 23:51:51 +0000 (09:51 +1000)]
Merge pull request #50066 from zdover23/wip-doc-2023-02-10-multisite-configuring-secondary-zones
doc/rgw: refine "Configuring Secondary Zones"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Casey Bodley [Fri, 10 Feb 2023 18:15:13 +0000 (13:15 -0500)]
github: add rgw team to CODEOWNERS
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ilya Dryomov [Fri, 10 Feb 2023 12:56:57 +0000 (13:56 +0100)]
qa/suites/rbd: fix sporadic "rx-only direction" test failures
The existing
xmlstarlet sel -t -v '//mirror/peers/peer[1]/uuid')" = ""
test is bogus since a tx-only peer gets added after the remote
rbd-mirror daemon pings the local cluster. It happened to pass most
of the time because xmlstarlet filter just failed on an empty peers
array, producing the wrongly expected empty string by accident.
Fixes: https://tracker.ceph.com/issues/58688
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Fri, 10 Feb 2023 14:23:19 +0000 (15:23 +0100)]
Merge pull request #49763 from Svelar/vstart4
vstart: check mgr status after starting mgr
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Xuehan Xu [Fri, 10 Feb 2023 07:36:07 +0000 (15:36 +0800)]
crimson/osd/pg: synchronize processing of peering events and backfill
events
All peering events and backfill events for the same pg has to be
processed sequentially, so use a single pipeline phase to synchronize
them.
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
zdover23 [Fri, 10 Feb 2023 05:29:08 +0000 (15:29 +1000)]
Merge pull request #50063 from zdover23/wip-doc-2023-02-10-cephfs-quota-extended-cephfs-attributes-and-getfattr
doc/cephfs: add note about CephFS extended attributes and getfattr
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 10 Feb 2023 02:40:01 +0000 (12:40 +1000)]
doc/rgw: refine "Configuring Secondary Zones"
English grammar and syntax pass (and some pragmatics, too, where I had
enough understanding to be helpful that way) for "Configuring Secondary
Zones" in doc/radosgw/multisite.rst.
https://tracker.ceph.com/issues/58632
Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Rongqi Sun [Tue, 7 Feb 2023 02:59:18 +0000 (10:59 +0800)]
vstart: check mgr status after starting mgr.
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
Zac Dover [Thu, 9 Feb 2023 22:59:00 +0000 (08:59 +1000)]
doc/cephfs: add note about CephFS extended attributes and getfattr
Supersedes https://github.com/ceph/ceph/pull/50060
Add a note on the fact that CephFS extended attributes are not printed
by "getfattr /some/cephfs/dir/ -d -m -" even when the CephFS directory
has some extended attributes set on it.
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/6ENI42ZMHTTP2OONBRD7FDP7LQBC4P2E/
Primary Author: Rishabh Dave <ridave@redhat.com>
Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Radoslaw Zarzynski [Thu, 12 Jan 2023 17:16:15 +0000 (17:16 +0000)]
crimson/osd: make the ObjectContextRegistry per-PG
This patch moves the OBC registry from ShardServices (which
is basicaly a gateway to a bunch of PGs) into PG itself.
Dividing OBCs by PG (they truly belong to) minimizes the space
to search when e.g. checking whether a client is blocked or
not. Therefore, this commit is enabler of more performant
PR #47637.
The changeset draws the assumption that OBC registry and all
its users live on the same CPU core. It looks valid to me.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Rishabh Dave [Thu, 9 Feb 2023 16:53:14 +0000 (22:23 +0530)]
vstart.sh: set logging for client and MDS when -d is passed
Set debug log messages for client and MDS to 20 when option "--debug" is
passed to vstart.sh
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Yuri Weinstein [Thu, 9 Feb 2023 15:29:36 +0000 (07:29 -0800)]
Merge pull request #49132 from aclamk/wip-aclamk-bs-excl-lock
blk/kernel: Add O_EXCL for block devices
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Nizamudeen A [Thu, 9 Feb 2023 11:26:44 +0000 (16:56 +0530)]
mgr/dashboard: fix rbd mirroring daemon health status
Fixes: https://tracker.ceph.com/issues/58679
Signed-off-by: Nizamudeen A <nia@redhat.com>
Matan [Thu, 9 Feb 2023 10:30:52 +0000 (12:30 +0200)]
Merge pull request #50023 from rosinL/fix-vstart
vstart: correct condition for checking crimson
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Guillaume Abrioux [Tue, 7 Feb 2023 09:51:36 +0000 (10:51 +0100)]
ceph-volume: do not raise RuntimeError in util.lsblk
Otherwise it makes `simple scan` calls fail.
```
File "/usr/lib/python3.6/site-packages/ceph_volume/util/disk.py", line 246, in lsblk
raise RuntimeError(f"{device} not found is lsblk report")
RuntimeError: /var/lib/ceph/osd/ceph-0/ not found is lsblk report
```
Fixes: https://tracker.ceph.com/issues/58655
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Yingxin [Thu, 9 Feb 2023 08:34:26 +0000 (16:34 +0800)]
Merge pull request #49744 from xxhdx1985126/wip-fix-seastar-mem-leak
seastar: fix mem leak caused by no maximum memory limit for cpu core
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yuri Weinstein [Thu, 9 Feb 2023 01:15:08 +0000 (17:15 -0800)]
Merge pull request #48703 from sseshasa/wip-fix-mclk-builtin-profile-mods
osd: Restore defaults of mClock built-in profiles upon modification
Reviewed-by: Neha Ojha <nojha@redhat.com>
Laura Flores [Wed, 8 Feb 2023 23:37:13 +0000 (17:37 -0600)]
Merge pull request #48591 from rzarzynski/wip-osd-snaptrimmer-waitscrub-fix-name
osd: fix name of WaitScrub state of SnapTrimmer
Laura Flores [Wed, 8 Feb 2023 23:36:34 +0000 (17:36 -0600)]
Merge pull request #47702 from ifed01/wip-ifed-more-pin-fix
os/bluestore: fix onode ref counting.
Adam King [Wed, 8 Feb 2023 18:45:09 +0000 (13:45 -0500)]
Merge pull request #49888 from phlogistonjohn/jjm-more-utils-coverage
cephadm: more test coverage for various utils functions
Reviewed-by: Adam King <adking@redhat.com>
zdover23 [Wed, 8 Feb 2023 14:53:10 +0000 (00:53 +1000)]
Merge pull request #50030 from zdover23/wip-doc-2023-02-09-multisite-to-config-2ndary-zones
doc/rgw: refine multisite to "config 2ndary zones"
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 8 Feb 2023 14:32:44 +0000 (00:32 +1000)]
doc/rgw: refine multisite to "config 2ndary zones"
Refine the English in doc/radosgw/multisite.rst up to (but not
including) "Configure Secondary Zones".
https://tracker.ceph.com/issues/58632
Signed-off-by: Zac Dover <zac.dover@proton.me>
Venky Shankar [Wed, 8 Feb 2023 13:23:45 +0000 (18:53 +0530)]
Merge pull request #50027 from joscollin/wip-drop-aitalic
cephfs-top: drop curses.A_ITALIC
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Nizamudeen A [Wed, 8 Feb 2023 13:07:38 +0000 (18:37 +0530)]
Merge pull request #50021 from rhcs-dashboard/rename-endpoints
mgr/rgw: rename endpoints to zone_endpoints to match rgw spec
Reviewed-by: rkachach <NOT@FOUND>
Aashish Sharma [Wed, 8 Feb 2023 13:04:30 +0000 (18:34 +0530)]
Merge pull request #48783 from rhcs-dashboard/fix-grafana-stat-panel
mgr/dashboard: Replace vonage-status-panel with native grafana stat panel
Reviewed-by: Nizamudeen A <nia@redhat.com>
Jos Collin [Wed, 8 Feb 2023 09:27:31 +0000 (14:57 +0530)]
cephfs-top: drop curses.A_ITALIC
Fixes: https://tracker.ceph.com/issues/58663
Signed-off-by: Jos Collin <jcollin@redhat.com>