]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc/rados: add prompts to cache-tiering.rst 49118/head
Zac Dover [Tue, 29 Nov 2022 12:28:36 +0000 (22:28 +1000)]
doc/rados: add prompts to cache-tiering.rst

Add unselectable prompts to doc/rados/operations/cache-tiering.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49107 from zdover23/wip-doc-2022-11-29-rados-balancer-prompts
zdover23 [Tue, 29 Nov 2022 07:43:48 +0000 (17:43 +1000)]
Merge pull request #49107 from zdover23/wip-doc-2022-11-29-rados-balancer-prompts

doc/rados: add prompts to balancer.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: add prompts to balancer.rst 49107/head
Zac Dover [Tue, 29 Nov 2022 05:41:11 +0000 (15:41 +1000)]
doc/rados: add prompts to balancer.rst

Add unselectable prompts to doc/rados/operations/balancer.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49015 from batrick/meta-doc
Venky Shankar [Tue, 29 Nov 2022 04:07:04 +0000 (09:37 +0530)]
Merge pull request #49015 from batrick/meta-doc

doc/cephfs: correct names for fs/meta

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #48490 from aclamk/wip-aclamk-fix-deferred
Yuri Weinstein [Mon, 28 Nov 2022 18:38:12 +0000 (10:38 -0800)]
Merge pull request #48490 from aclamk/wip-aclamk-fix-deferred

[bluestore] Improve deferred write decision

Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2 years agoMerge pull request #49053 from tchaikov/wip-crimson-fmt-v9
Samuel Just [Mon, 28 Nov 2022 16:43:12 +0000 (08:43 -0800)]
Merge pull request #49053 from tchaikov/wip-crimson-fmt-v9

crimson: various fmt related changes and fixes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #47221 from markhpc/wip-faster-rocksdb
Mark Nelson [Mon, 28 Nov 2022 16:32:16 +0000 (10:32 -0600)]
Merge pull request #47221 from markhpc/wip-faster-rocksdb

[WIP] kv/RocksDBStore: Improved RocksDB Settings and Tombstone behavior

2 years agoMerge pull request #48875 from yuvalif/wip-yuval-fix-58014
Yuval Lifshitz [Mon, 28 Nov 2022 16:01:32 +0000 (18:01 +0200)]
Merge pull request #48875 from yuvalif/wip-yuval-fix-58014

rgw/notifications: sending metadata in COPY and CompleteMultipartUpload

2 years agoMerge pull request #49082 from zdover23/wip-doc-2022-11-28-rbd-isci-monitoring-prompts
Ilya Dryomov [Mon, 28 Nov 2022 09:29:00 +0000 (10:29 +0100)]
Merge pull request #49082 from zdover23/wip-doc-2022-11-28-rbd-isci-monitoring-prompts

doc/rbd: add prompts to iscsi-monitoring.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #48598 from yuvalif/wip-yuval-fix-57899
Yuval Lifshitz [Mon, 28 Nov 2022 06:01:06 +0000 (08:01 +0200)]
Merge pull request #48598 from yuvalif/wip-yuval-fix-57899

rgw/admin/notifications: support admin operations on topics with tenants

2 years agoMerge pull request #49079 from zdover23/wip-doc-2022-11-28-glossary-ceph-system-remove
zdover23 [Mon, 28 Nov 2022 00:16:58 +0000 (10:16 +1000)]
Merge pull request #49079 from zdover23/wip-doc-2022-11-28-glossary-ceph-system-remove

doc/glossary: s/Ceph System/Ceph Cluster/

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rbd: add prompts to iscsi-monitoring.rst 49082/head
Zac Dover [Mon, 28 Nov 2022 00:11:04 +0000 (10:11 +1000)]
doc/rbd: add prompts to iscsi-monitoring.rst

Add unselectable prompts to doc/rbd/iscsi-monitoring.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/glossary: s/Ceph System/Ceph Cluster/ 49079/head
Zac Dover [Sun, 27 Nov 2022 23:45:25 +0000 (09:45 +1000)]
doc/glossary: s/Ceph System/Ceph Cluster/

Remove "Ceph System" and replace it with "Ceph Cluster".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49074 from zdover23/wip-doc-2022-11-27-dev-guide-basic-workflow...
zdover23 [Sun, 27 Nov 2022 23:35:17 +0000 (09:35 +1000)]
Merge pull request #49074 from zdover23/wip-doc-2022-11-27-dev-guide-basic-workflow-local-working-copy

doc/dev: improve Basic Workflow wording

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/dev: improve Basic Workflow wording 49074/head
Zac Dover [Sun, 27 Nov 2022 08:20:51 +0000 (18:20 +1000)]
doc/dev: improve Basic Workflow wording

Make several semantic and syntactic improvements to basic-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48680 from pkalever/snap-id
Ilya Dryomov [Sun, 27 Nov 2022 13:10:31 +0000 (14:10 +0100)]
Merge pull request #48680 from pkalever/snap-id

rbd: add --snap-id option to "rbd device map" to allow mapping arbitrary snapshots

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #49066 from zdover23/wip-doc-2022-11-26-glossary-ceph-system-remove
zdover23 [Sun, 27 Nov 2022 04:06:18 +0000 (14:06 +1000)]
Merge pull request #49066 from zdover23/wip-doc-2022-11-26-glossary-ceph-system-remove

doc/glossary: remove "Ceph System"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49065 from zdover23/wip-doc-2022-11-26-rados-ops-add-or-rm-osds...
zdover23 [Sat, 26 Nov 2022 22:00:28 +0000 (08:00 +1000)]
Merge pull request #49065 from zdover23/wip-doc-2022-11-26-rados-ops-add-or-rm-osds-prompts

doc/rados: add prompts to add-or-remove-osds

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49045 from zdover23/wip-doc-2022-11-25-rbd-iscsi-initiator
zdover23 [Sat, 26 Nov 2022 20:59:55 +0000 (06:59 +1000)]
Merge pull request #49045 from zdover23/wip-doc-2022-11-25-rbd-iscsi-initiator

doc/rbd: update iSCSI gateway info

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agodoc/rbd: update iSCSI gateway info 49045/head
Zac Dover [Thu, 24 Nov 2022 18:08:13 +0000 (04:08 +1000)]
doc/rbd: update iSCSI gateway info

Update iSCSI gateway info in the RBD documentation.

https://tracker.ceph.com/issues/58080

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/glossary: remove "Ceph System" 49066/head
Zac Dover [Sat, 26 Nov 2022 13:16:18 +0000 (23:16 +1000)]
doc/glossary: remove "Ceph System"

"Ceph System" appears only in definitions where "Ceph Cluster" should
be, so I'm removing the headword. A future commit will scrub the
glossary of the phrase "Ceph System".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoqa/workunits/rbd-nbd: clear DEV after detach tests 48680/head
Ilya Dryomov [Sat, 26 Nov 2022 12:27:33 +0000 (13:27 +0100)]
qa/workunits/rbd-nbd: clear DEV after detach tests

Otherwise we attempt to unmap it in cleanup(), needlessly.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agodoc/rados: add prompts to add-or-remove-osds 49065/head
Zac Dover [Sat, 26 Nov 2022 07:44:22 +0000 (17:44 +1000)]
doc/rados: add prompts to add-or-remove-osds

Add unselectable prompts to add-or-rm-osds.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49062 from zdover23/wip-doc-2022-11-26-glossary-ceph-manager
zdover23 [Sat, 26 Nov 2022 00:16:42 +0000 (10:16 +1000)]
Merge pull request #49062 from zdover23/wip-doc-2022-11-26-glossary-ceph-manager

doc/glossary: link to "Ceph Manager"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/glossary: link to "Ceph Manager" 49062/head
Zac Dover [Sat, 26 Nov 2022 00:06:34 +0000 (10:06 +1000)]
doc/glossary: link to "Ceph Manager"

Add link to "Ceph Manager" material.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48761 from soumyakoduri/wip-skoduri-cloudtier-fixes
Soumya Koduri [Fri, 25 Nov 2022 15:13:19 +0000 (20:43 +0530)]
Merge pull request #48761 from soumyakoduri/wip-skoduri-cloudtier-fixes

rgw/cloud-transition: Fix issues with MCG endpoint

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agocrimson/osd: correct the fmt::formatter<WatchTimeoutRequest> 49053/head
Kefu Chai [Fri, 25 Nov 2022 09:07:29 +0000 (17:07 +0800)]
crimson/osd: correct the fmt::formatter<WatchTimeoutRequest>

it was introduced by c9569f8eb027b9e08c8eeb59ecb37378ef66e5c0

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson: print exceptions using e.what()
Kefu Chai [Fri, 25 Nov 2022 09:04:48 +0000 (17:04 +0800)]
crimson: print exceptions using e.what()

see also e6223872c58e492d3570335fd7f05bb52641837c

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/os: specialize fmt::formatter<> for StagedIterator
Kefu Chai [Fri, 25 Nov 2022 09:00:11 +0000 (17:00 +0800)]
crimson/os: specialize fmt::formatter<> for StagedIterator

StagedIterator is a nested class of stage_t, which is in turn a template
class. it would be impossible to partial specialize fmt::formatter<> for
a nested class of a template class. to workaround this, we specialize
fmt::formatter<> for a type which has `do_format_to()` method, and
define this method for StagedIterator.

since seastar::logger is the only user of the operator<<() operator,
the original operator<<() operator is replaced with this new helper
method.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49036 from idryomov/wip-52932
Ilya Dryomov [Fri, 25 Nov 2022 10:48:42 +0000 (11:48 +0100)]
Merge pull request #49036 from idryomov/wip-52932

mgr/rbd_support: avoid wedging the task queue if pool is removed

Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agoMerge pull request #49042 from idryomov/wip-rbd-support-flake8
Ilya Dryomov [Fri, 25 Nov 2022 10:47:38 +0000 (11:47 +0100)]
Merge pull request #49042 from idryomov/wip-rbd-support-flake8

mgr/rbd_support: clean up and enable flake8

Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agocrimson/os: include fmt/os.h for printing std::error_code
Kefu Chai [Fri, 25 Nov 2022 08:58:17 +0000 (16:58 +0800)]
crimson/os: include fmt/os.h for printing std::error_code

this is required by {fmt} v9 and up.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson: specialize fmt::formatter<> for formatting using {fmt}
Kefu Chai [Fri, 25 Nov 2022 08:57:19 +0000 (16:57 +0800)]
crimson: specialize fmt::formatter<> for formatting using {fmt}

so the specialized types can be formatted using {fmt} v9.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49046 from zdover23/wip-doc-2022-11-25-rados-ops-erasure-code...
zdover23 [Fri, 25 Nov 2022 07:12:05 +0000 (17:12 +1000)]
Merge pull request #49046 from zdover23/wip-doc-2022-11-25-rados-ops-erasure-code-profiles

doc/rados: cleanup "erasure code profiles"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: cleanup "erasure code profiles" 49046/head
Zac Dover [Thu, 24 Nov 2022 18:41:12 +0000 (04:41 +1000)]
doc/rados: cleanup "erasure code profiles"

Improve the grammar of "Erasure Code Profiles".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48927 from neesingh-rh/fix_58028
Venky Shankar [Thu, 24 Nov 2022 17:25:17 +0000 (22:55 +0530)]
Merge pull request #48927 from neesingh-rh/fix_58028

cephfs-top: Fix unresposive sorting in some cases

Reviewed-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #48542 from CongMinYin/fix-inconsistent-pwl-status
Ilya Dryomov [Thu, 24 Nov 2022 15:12:36 +0000 (16:12 +0100)]
Merge pull request #48542 from CongMinYin/fix-inconsistent-pwl-status

librbd/cache/pwl: fix clean vs bytes_dirty cache state inconsistency

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agocephfs-top: Fix unresposive sorting in some cases 48927/head
Neeraj Pratap Singh [Tue, 22 Nov 2022 06:36:48 +0000 (12:06 +0530)]
cephfs-top: Fix unresposive sorting in some cases

Sorting is not working properly in case of change
in the number of clients or after removing and
creating the same filesystem again.

Fixes: https://tracker.ceph.com/issues/58028
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoMerge pull request #49026 from neesingh-rh/fix_58031
Venky Shankar [Thu, 24 Nov 2022 13:36:17 +0000 (19:06 +0530)]
Merge pull request #49026 from neesingh-rh/fix_58031

cephfs-top: sorting excepts when the filesystems are removed and created

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2 years agomgr/rbd_support: clean up and enable flake8 49042/head
Ilya Dryomov [Thu, 24 Nov 2022 12:37:44 +0000 (13:37 +0100)]
mgr/rbd_support: clean up and enable flake8

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #49029 from Matan-B/wip-matanb-EIO-flag
Kefu Chai [Thu, 24 Nov 2022 12:34:47 +0000 (20:34 +0800)]
Merge pull request #49029 from Matan-B/wip-matanb-EIO-flag

crimson/osd: Support Pool EIO flag

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48932 from aisakaki/wip-crimson-loop
Kefu Chai [Thu, 24 Nov 2022 09:12:51 +0000 (17:12 +0800)]
Merge pull request #48932 from aisakaki/wip-crimson-loop

crimson/common: re-implement do_for_each

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49040 from tchaikov/wip-cephadm-flake8
Kefu Chai [Thu, 24 Nov 2022 08:29:26 +0000 (16:29 +0800)]
Merge pull request #49040 from tchaikov/wip-cephadm-flake8

cephadm: pin flake8 to 5.0.4

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agopybind/mgr: use annotation style without comment 49040/head
Kefu Chai [Thu, 24 Nov 2022 06:01:13 +0000 (14:01 +0800)]
pybind/mgr: use annotation style without comment

* use annotation style without comment
* add noqa to import statement to prevent flake8 from complaining
  those which import typing modules

to silence the warnings like:

```
flake8 run-test: commands[0] | flake8 --config=tox.ini alerts balancer cephadm cli_api crash devicehealth diskprediction_local hello iostat localpool nfs orchestrator prometheus selftest
cephadm/schedule.py:5:1: F401 'typing.Callable' imported but unused
cephadm/schedule.py:8:1: F401 'ceph.deployment.service_spec.ServiceSpec' imported but unused
cephadm/tests/fixtures.py:17:1: F401 'orchestrator.OrchResult' imported but unused
orchestrator/module.py:4:1: F401 'typing.Set' imported but unused
orchestrator/module.py:17:1: F401 'ceph.deployment.inventory.Device' imported but unused
prometheus/module.py:17:1: F401 'typing.DefaultDict' imported but unused
6     F401 'typing.Callable' imported but unused
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/flake8/bin/flake8 --config=tox.ini alerts
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoqa/tasks/cephfs: annotate variable without comment
Kefu Chai [Thu, 24 Nov 2022 05:46:27 +0000 (13:46 +0800)]
qa/tasks/cephfs: annotate variable without comment

to silence the warning like
```
flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_full.py:6:5: F401 'typing.Optional' imported but unused
```

since we've migrated to python3.6 and up, there is no need to be
compatible with Python 2 anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocephadm: pin flake8 to 5.0.4
Kefu Chai [Thu, 24 Nov 2022 05:18:10 +0000 (13:18 +0800)]
cephadm: pin flake8 to 5.0.4

to workaround https://github.com/zheller/flake8-quotes/issues/110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocephfs-top: sorting excepts when the filesystems are removed and created 49026/head
Neeraj Pratap Singh [Wed, 23 Nov 2022 12:01:33 +0000 (17:31 +0530)]
cephfs-top: sorting excepts when the filesystems are removed and created

Fixes: https://tracker.ceph.com/issues/58031
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoMerge pull request #49022 from cyx1231st/wip-seastar-msgr-fix-yielded-closing
Kefu Chai [Wed, 23 Nov 2022 23:45:45 +0000 (07:45 +0800)]
Merge pull request #49022 from cyx1231st/wip-seastar-msgr-fix-yielded-closing

crimson/net: fix use-after-free during yielded closing

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agomgr/rbd_support: avoid wedging the task queue if pool is removed 49036/head
Ilya Dryomov [Wed, 23 Nov 2022 17:10:03 +0000 (18:10 +0100)]
mgr/rbd_support: avoid wedging the task queue if pool is removed

rados.ObjectNotFound exception handler was referencing ioctx variable
which is assigned only if the pool exists and rados.open_ioctx() call
succeeds.  This lead to a fatal error

  mgr[rbd_support] Failed to locate pool mypool
  mgr[rbd_support] execute_task: [errno 2] error opening pool 'b'mypool''
  mgr[rbd_support] Fatal runtime error: local variable 'ioctx' referenced before assignment

and wedged the task queue.  No other commands were processed until
ceph-mgr daemon restart.

Fixes: https://tracker.ceph.com/issues/52932
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #49037 from zdover23/wip-doc-2022-11-24-container-install-consume...
zdover23 [Wed, 23 Nov 2022 19:52:30 +0000 (05:52 +1000)]
Merge pull request #49037 from zdover23/wip-doc-2022-11-24-container-install-consume-44310

doc/install: update "Official Releases" sources

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/install: update "Official Releases" sources 49037/head
Zac Dover [Wed, 23 Nov 2022 19:26:48 +0000 (05:26 +1000)]
doc/install: update "Official Releases" sources

Remove "Docker Hub" from the list of locations from which Ceph can be
acquired.

This commit represents a second attempt to get
https://github.com/ceph/ceph/pull/49034 past the Jenkins CI tests, and
that PR was itself an attempt to incorporate the change in
https://github.com/ceph/ceph/pull/44310, which could not be merged
because the commit message associated with that PR did not begin with
the string "doc", which meant that the "Signed-off-by" check failed.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agotest/librados/aio_cxx: use fmt formatting 49029/head
Matan Breizman [Wed, 23 Nov 2022 17:18:10 +0000 (17:18 +0000)]
test/librados/aio_cxx: use fmt formatting

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/osd_operations/client_request: Support FLAG_EIO
Matan Breizman [Wed, 23 Nov 2022 13:25:52 +0000 (13:25 +0000)]
crimson/osd/osd_operations/client_request: Support FLAG_EIO

See 5ac9f523ea263eeb747e2543a667a25de67d07b8

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #49025 from zdover23/wip-doc-2022-11-23-glossary-ceph-client
zdover23 [Wed, 23 Nov 2022 15:16:20 +0000 (01:16 +1000)]
Merge pull request #49025 from zdover23/wip-doc-2022-11-23-glossary-ceph-client

doc/glossary: fix "Ceph Client"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49027 from zdover23/wip-doc-2022-11-23-glossary-ceph-object-store
zdover23 [Wed, 23 Nov 2022 15:13:26 +0000 (01:13 +1000)]
Merge pull request #49027 from zdover23/wip-doc-2022-11-23-glossary-ceph-object-store

doc/glossary: add "Ceph Object Store"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #48859 from yanghonggang/yhg-code-cleanup
Kefu Chai [Wed, 23 Nov 2022 14:44:02 +0000 (22:44 +0800)]
Merge pull request #48859 from yanghonggang/yhg-code-cleanup

osd/ECBackend: remove unused variables

Reviewed-by: Omri Zeneva <ozeneva@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #49010 from tchaikov/more-than-future
Kefu Chai [Wed, 23 Nov 2022 14:11:38 +0000 (22:11 +0800)]
Merge pull request #49010 from tchaikov/more-than-future

crimson/common: use concept for type constraints

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #49005 from CHOKYUJIN/main
Anthony D'Atri [Wed, 23 Nov 2022 13:31:58 +0000 (08:31 -0500)]
Merge pull request #49005 from CHOKYUJIN/main

doc/dev: fix a typo in deduplication.rst

2 years agotest/librados/aio_cxx: Simple PoolEIOFlag is added
Matan Breizman [Wed, 23 Nov 2022 13:22:59 +0000 (13:22 +0000)]
test/librados/aio_cxx: Simple PoolEIOFlag is added

Useful for debugging.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agotest/librados/aio_cxx: Fix PoolEIOFlag test
Matan Breizman [Wed, 23 Nov 2022 13:20:01 +0000 (13:20 +0000)]
test/librados/aio_cxx: Fix PoolEIOFlag test

* wait_for_complete is added before getting the return value.

* for loop iteration limit is added to avoid infinite run.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agodoc/glossary: add "Ceph Object Store" 49027/head
Zac Dover [Wed, 23 Nov 2022 13:09:47 +0000 (23:09 +1000)]
doc/glossary: add "Ceph Object Store"

Add a definition for "Ceph Object Store".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocrimson/common: use concept for type constraints 49010/head
Kefu Chai [Tue, 22 Nov 2022 12:22:54 +0000 (20:22 +0800)]
crimson/common: use concept for type constraints

instead of using SFINAE, use concept for specifying the type constraints
for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48896 from yuvalif/wip-yuval-fix-50076
Yuval Lifshitz [Wed, 23 Nov 2022 11:03:20 +0000 (13:03 +0200)]
Merge pull request #48896 from yuvalif/wip-yuval-fix-50076

rgw/kafka: route librdkafka log messages to rgw log

2 years agoMerge pull request #48877 from yuvalif/wip-yuval-fix-58020
Yuval Lifshitz [Wed, 23 Nov 2022 11:02:29 +0000 (13:02 +0200)]
Merge pull request #48877 from yuvalif/wip-yuval-fix-58020

rgw/notifications: send mtime in complete multipart upload event

2 years agoMerge pull request #48758 from yuvalif/wip-yuval-kafka-tests
Yuval Lifshitz [Wed, 23 Nov 2022 11:00:00 +0000 (13:00 +0200)]
Merge pull request #48758 from yuvalif/wip-yuval-kafka-tests

rgw/notification/test: add support for testing kafka security

2 years agodoc/glossary: fix "Ceph Client" 49025/head
Zac Dover [Wed, 23 Nov 2022 08:16:47 +0000 (18:16 +1000)]
doc/glossary: fix "Ceph Client"

Add detail to and clean the syntactics and semantics of "Ceph Client".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/dev: fix a typo in deduplication.rst 49005/head
Kyujin Cho [Tue, 22 Nov 2022 10:49:06 +0000 (10:49 +0000)]
doc/dev: fix a typo in deduplication.rst

Signed-off-by: Kyujin Cho <bori19960@snu.ac.kr>
2 years agocrimson/net: fix use-after-free during yielded closing 49022/head
Yingxin Cheng [Wed, 23 Nov 2022 05:46:47 +0000 (13:46 +0800)]
crimson/net: fix use-after-free during yielded closing

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/common: re-implement do_for_each 48932/head
Xinyu Huang [Fri, 18 Nov 2022 02:43:42 +0000 (02:43 +0000)]
crimson/common: re-implement do_for_each

The current implementation of crimson::do_for_each might meet
stack overflow when future is available but seastar::need_preempt
is true. This new implementation mirror to the seastar::do_for_each
with crimson errorator mechanism will solve this problem.

Fixes: https://tracker.ceph.com/issues/58005.
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
2 years agoMerge pull request #49011 from tchaikov/wip-crimson-fmt-v9
Kefu Chai [Wed, 23 Nov 2022 00:37:43 +0000 (08:37 +0800)]
Merge pull request #49011 from tchaikov/wip-crimson-fmt-v9

crimson: various fmt related changes and fixes.

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #49017 from zdover23/wip-doc-2022-11-23-glossary-cluster-map
zdover23 [Tue, 22 Nov 2022 18:33:11 +0000 (04:33 +1000)]
Merge pull request #49017 from zdover23/wip-doc-2022-11-23-glossary-cluster-map

doc/glossary: s/comprising/consisting of/

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/glossary: s/comprising/consisting of/ 49017/head
Zac Dover [Tue, 22 Nov 2022 18:04:48 +0000 (04:04 +1000)]
doc/glossary: s/comprising/consisting of/

s/comprising/consisting of/ - Make the text easier to read for
non-native or weak readers of English.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/cephfs: correct names for fs/meta 49015/head
Patrick Donnelly [Tue, 22 Nov 2022 17:00:54 +0000 (12:00 -0500)]
doc/cephfs: correct names for fs/meta

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #49001 from tchaikov/wip-fmt-v9
Kefu Chai [Tue, 22 Nov 2022 16:03:16 +0000 (00:03 +0800)]
Merge pull request #49001 from tchaikov/wip-fmt-v9

*: specialize fmt::formatter<> for formatting using {fmt}

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 years agocrimson/os: print exception using e.what() 49011/head
Kefu Chai [Tue, 22 Nov 2022 12:38:02 +0000 (20:38 +0800)]
crimson/os: print exception using e.what()

see also e6223872c58e492d3570335fd7f05bb52641837c

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/os: print pointer using fmt::ptr()
Kefu Chai [Tue, 22 Nov 2022 12:36:30 +0000 (20:36 +0800)]
crimson/os: print pointer using fmt::ptr()

also, partial specialize fmt::format<> for boost::instrusive_ptr<>,
so we can use fmt::ptr() to print boost::intrusive_ptr<>, just like
how we print std::shared_ptr<>.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48984 from Matan-B/wip-matanb-unit-debug-lvl
zdover23 [Tue, 22 Nov 2022 14:11:45 +0000 (00:11 +1000)]
Merge pull request #48984 from Matan-B/wip-matanb-unit-debug-lvl

doc/dev/developer_guide/tests-unit-tests: Add unit test caveat

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2 years agocrimson/os: print the value of optional<>
Kefu Chai [Tue, 22 Nov 2022 12:35:59 +0000 (20:35 +0800)]
crimson/os: print the value of optional<>

if an optional is known to have value, we can just print its value.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson: specialize fmt::formatter<>
Kefu Chai [Tue, 22 Nov 2022 12:35:14 +0000 (20:35 +0800)]
crimson: specialize fmt::formatter<>

so the specialized types can be formatted using {fmt} v9

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years ago*: specialize fmt::formatter<> for formatting using {fmt} 49001/head
Kefu Chai [Tue, 22 Nov 2022 04:26:19 +0000 (12:26 +0800)]
*: specialize fmt::formatter<> for formatting using {fmt}

in {fmt} v9, fmt::formatter<> is not defined automatically for
the types with operator<<, we need to define them explictly. so in this
change, the types printed using `fmt::print()` or `fmt::format()` are
equiped with fmt::formatter<> to appease {fmt} v9.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/os/seastore: add reference to the iterator of segment_map_t
Xinyu Huang [Fri, 18 Nov 2022 02:39:29 +0000 (02:39 +0000)]
crimson/os/seastore: add reference to the iterator of segment_map_t

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
2 years agoMerge pull request #49000 from tchaikov/wip-crimson-fmt-v9
Kefu Chai [Tue, 22 Nov 2022 07:08:04 +0000 (15:08 +0800)]
Merge pull request #49000 from tchaikov/wip-crimson-fmt-v9

crimson: various fmt related changes and fixes.

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/osd: print oid of missing clone 49000/head
Kefu Chai [Tue, 22 Nov 2022 04:20:55 +0000 (12:20 +0800)]
crimson/osd: print oid of missing clone

instead of printing the empty optional<>, print the oid of missing
clone. the oid is more interesting in this context.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson: specialize fmt::formatter<> to print using {fmt}
Kefu Chai [Tue, 22 Nov 2022 04:13:49 +0000 (12:13 +0800)]
crimson: specialize fmt::formatter<> to print using {fmt}

in {fmt} v9, fmt::formatter<> is not defined automatically for
the types with operator<<, we need to define them explictly. so in this
change, the types printed using `fmt::print()` or `fmt::format()` are
equiped with fmt::formatter<> to appease {fmt} v9.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/net: print shared_ptr using fmt::ptr()
Kefu Chai [Tue, 22 Nov 2022 04:06:33 +0000 (12:06 +0800)]
crimson/net: print shared_ptr using fmt::ptr()

in {fmt} v9, only `void*` pointers can be printed directly. when it
comes to typed pointer or smart pointers, we need to print them using
`fmt::ptr()`. in this change, an overload is added so we can print
`seastar::shared_ptr<>` via `fmt::ptr()` as well, just like how we
print `std::shared_ptr<>`.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/osd: add formatter for std::optional<>
Kefu Chai [Tue, 22 Nov 2022 04:03:15 +0000 (12:03 +0800)]
crimson/osd: add formatter for std::optional<>

in `PG::do_update_log_missing()`, `std::optional<eversion_t>` is printed
using {fmt}, but {fmt} does not support formatting `std::optional<>`. so
we need to swing our own formatter. we can promote this formatter to
a more common place if it is proved to be useful otherwhere in the
source tree.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson: print exceptions using exception.what()
Kefu Chai [Tue, 22 Nov 2022 03:56:36 +0000 (11:56 +0800)]
crimson: print exceptions using exception.what()

{fmt} does not support formatting exceptions until
https://github.com/fmtlib/fmt/pull/3062/commits/76adb05a78a026b94c2ecadd20c00ae0c33c5a37
so we need to print them via exception.what().

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/common: print std::exception_ptr after conveting it to exception
Kefu Chai [Tue, 22 Nov 2022 03:41:43 +0000 (11:41 +0800)]
crimson/common: print std::exception_ptr after conveting it to exception

fmt does not support formatting `std::exception_ptr`, so we need to
rethrow it, so we can convert it to a known exception type.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48987 from tchaikov/cmake-cares
Kefu Chai [Tue, 22 Nov 2022 04:37:00 +0000 (12:37 +0800)]
Merge pull request #48987 from tchaikov/cmake-cares

cmake: s/c-ares::c-ares/c-ares::cares/

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48998 from zdover23/wip-doc-2022-11-22-glossary-ceph-storage...
zdover23 [Tue, 22 Nov 2022 04:36:13 +0000 (14:36 +1000)]
Merge pull request #48998 from zdover23/wip-doc-2022-11-22-glossary-ceph-storage-cluster

doc/glossary: define "Ceph Storage Cluster"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agorgw/cloud-transition: Fix issues with MCG endpoint 48761/head
Soumya Koduri [Sat, 5 Nov 2022 16:53:53 +0000 (22:23 +0530)]
rgw/cloud-transition: Fix issues with MCG endpoint

Few s3 endpoints (like Noobaa MCG or AWS) may return BucketAlreadyOwned
or BucketAlreadyExists error if the target path (configured for
cloud transition) already exists. Do not fail transition in those cases.

Also fixed below issues -
* with racing lc threads, when one lc thread is trying to check and create the
target bucket, others may go ahead with the object transition assuming target path
exists.
* initialize few fields to avoid setting wrong content_len during transition

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 years agodoc/glossary: define "Ceph Storage Cluster" 48998/head
Zac Dover [Tue, 22 Nov 2022 04:02:34 +0000 (14:02 +1000)]
doc/glossary: define "Ceph Storage Cluster"

Add "Ceph Storage Cluster" to the glossary.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48773 from myoungwon/wip-fix-out-date-delta
Yingxin [Tue, 22 Nov 2022 01:44:48 +0000 (09:44 +0800)]
Merge pull request #48773 from myoungwon/wip-fix-out-date-delta

crimson/os/seastore: add deallocation map during replay to filter out out-dated delta

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #48837 from badone/wip-ceph-debug-docker-ubuntu-src.list
Brad Hubbard [Mon, 21 Nov 2022 22:42:15 +0000 (08:42 +1000)]
Merge pull request #48837 from badone/wip-ceph-debug-docker-ubuntu-src.list

scripts: Add Ubuntu source repo entry to ceph-debug-docker

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #48989 from zdover23/wip-doc-2022-11-22-glossary-node
zdover23 [Mon, 21 Nov 2022 18:05:10 +0000 (04:05 +1000)]
Merge pull request #48989 from zdover23/wip-doc-2022-11-22-glossary-node

doc/glossary: Define "Ceph Node"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #48990 from zdover23/wip-doc-2022-11-22-glossary-cluster-map-oxfor...
zdover23 [Mon, 21 Nov 2022 18:01:54 +0000 (04:01 +1000)]
Merge pull request #48990 from zdover23/wip-doc-2022-11-22-glossary-cluster-map-oxford-comma

doc/glossary: add oxford comma to "Cluster Map"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agocmake: s/c-ares::c-ares/c-ares::cares/ 48987/head
Kefu Chai [Mon, 21 Nov 2022 16:44:31 +0000 (00:44 +0800)]
cmake: s/c-ares::c-ares/c-ares::cares/

to be aligned with the c-ares upstream, which provides
c-ares-config.cmake in c-ares v1.17 and up. this cmake config file
is also packaged by fedora and CentOS stream in c-ares-devel-1.17.1 and
up.

this change prepares us for bumping up Seastar submodule, which also
has a similar change: https://github.com/scylladb/seastar/commit/aea45c98f255e2013d4b9b399944e9810ee1d972

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agodoc/glossary: add oxford comma to "Cluster Map" 48990/head
Zac Dover [Mon, 21 Nov 2022 16:52:23 +0000 (02:52 +1000)]
doc/glossary: add oxford comma to "Cluster Map"

Add an Oxford comma to a list under the "Cluster Map" headword in the
glossary, so that it doesn't read like "I'd like to thank my parents,
Ayn Rand and God."

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/glossary: Define "Ceph Node" 48989/head
Zac Dover [Mon, 21 Nov 2022 16:49:49 +0000 (02:49 +1000)]
doc/glossary: Define "Ceph Node"

Add a definition of "Ceph Node" to the glossary.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48983 from zdover23/wip-doc-2022-11-21-rados-ops-add-or-rm-mons...
zdover23 [Mon, 21 Nov 2022 14:58:49 +0000 (00:58 +1000)]
Merge pull request #48983 from zdover23/wip-doc-2022-11-21-rados-ops-add-or-rm-mons-prompts-2-of-2

doc/rados: add prompts to add-or-rm-prompts.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>