]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Zac Dover [Thu, 29 Dec 2022 04:42:25 +0000 (14:42 +1000)]
doc/glossary: s/an/each/ where it's needed
s/an/each/ in accordance with the suggestion made by Anthony D'Atri
here: https://github.com/ceph/ceph/pull/49590/files#r1058390357
Signed-off-by: Zac Dover <zac.dover@gmail.com>
zdover23 [Wed, 28 Dec 2022 09:08:45 +0000 (19:08 +1000)]
Merge pull request #49584 from zdover23/wip-doc-2022-12-27-glossary-cleanup
doc/glossary: clean OSD id-related entries
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Ilya Dryomov [Tue, 27 Dec 2022 22:37:59 +0000 (23:37 +0100)]
Merge pull request #49587 from zdover23/wip-doc-2022-12-27-rbd-wuold-typo
doc/rbd: s/wuold/would/ in rados-rbd-cmds.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Adam King [Tue, 27 Dec 2022 16:40:58 +0000 (11:40 -0500)]
Merge pull request #49583 from RanjiniMandyam/RMN-
2151232 -syntax
doc/dev/cephadm: fix host maintenance enter/exit syntax -
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 27 Dec 2022 12:28:49 +0000 (22:28 +1000)]
doc/rbd: s/wuold/would/ in rados-rbd-cmds.rst
s/wuold/would/ in rados-rbd-cmds.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Zac Dover [Tue, 27 Dec 2022 05:28:31 +0000 (15:28 +1000)]
doc/glossary: clean OSD id-related entries
Tidy up the sentences under the headwords "OSD fsid", "OSD id", and "OSD
uuid".
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ranjini Mandyam Narasiodeyar [Tue, 27 Dec 2022 05:08:26 +0000 (10:38 +0530)]
doc/dev/cephadm: fix host maintenance enter/exit syntax -
Signed-off-by: Ranjini Mandyam Narasiodeyar <rmandyam@rmandyam.remote.csb>
Ilya Dryomov [Mon, 26 Dec 2022 13:59:07 +0000 (14:59 +0100)]
Merge pull request #48893 from weixinwei/master
librbd: avoid EUCLEAN error after "rbd rm" is interrupted
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Ilya Dryomov [Mon, 26 Dec 2022 13:56:05 +0000 (14:56 +0100)]
Merge pull request #49261 from ajarr/fix-57726
mgr/rbd_support: remove localized schedule option during module startup
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
zdover23 [Mon, 26 Dec 2022 06:20:57 +0000 (16:20 +1000)]
Merge pull request #49573 from zdover23/wip-doc-2022-12-26-glossary-cleanup
doc/glossary: disambiguate clauses
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Mon, 26 Dec 2022 06:05:32 +0000 (16:05 +1000)]
doc/glossary: disambiguate clauses
Disambiguate various clauses, most of which contain forms of the verb
"to require".
Signed-off-by: Zac Dover <zac.dover@gmail.com>
colemitchell [Sun, 25 Dec 2022 21:21:16 +0000 (16:21 -0500)]
Merge pull request #49569 from zdover23/wip-doc-2022-12-26-start-documenting-ceph-backport-fix
doc/start: update documenting-ceph.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
colemitchell [Sun, 25 Dec 2022 21:19:42 +0000 (16:19 -0500)]
Merge pull request #49567 from zdover23/wip-doc-2022-12-25-glossary-cleanup
doc/glossary: improve glossary entries
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sun, 25 Dec 2022 21:11:30 +0000 (07:11 +1000)]
doc/start: update documenting-ceph.rst
Add an article to documenting-ceph.rst in order to troubleshoot a
backporting problem.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Zac Dover [Sun, 25 Dec 2022 04:02:29 +0000 (14:02 +1000)]
doc/glossary: improve glossary entries
Improve multiple glossary entries.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
colemitchell [Sun, 25 Dec 2022 02:31:29 +0000 (21:31 -0500)]
Merge pull request #49564 from zdover23/wip-doc-2022-12-25-start-documenting-ceph
doc/start: improve documenting-ceph.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sun, 25 Dec 2022 02:08:25 +0000 (12:08 +1000)]
doc/start: improve documenting-ceph.rst
Improve the grammar and the pragmatics of the "TOC and Hyperlinks"
section of start/documenting-ceph.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
colemitchell [Sat, 24 Dec 2022 07:06:22 +0000 (02:06 -0500)]
Merge pull request #49558 from zdover23/wip-doc-2022-12-24-rados-api-librados-intro-prompt-removal
doc/rados: remove prompt from php.ini line
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
colemitchell [Sat, 24 Dec 2022 06:12:47 +0000 (01:12 -0500)]
Merge pull request #49557 from zdover23/wip-doc-2022-12-24-rados-api-python-typo
doc/rados: correct typo in python.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Sat, 24 Dec 2022 06:11:20 +0000 (16:11 +1000)]
doc/rados: remove prompt from php.ini line
Remove an unselectable prompt from the beginning of a line meant to be
included in the "php.ini" file.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Zac Dover [Sat, 24 Dec 2022 05:51:10 +0000 (15:51 +1000)]
doc/rados: correct typo in python.rst
s/you Ceph configuration file/your Ceph configuration file/
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ilya Dryomov [Fri, 23 Dec 2022 20:38:11 +0000 (21:38 +0100)]
Merge pull request #49532 from petrutlucian94/rbd_py_test2
qa: fix test_rbd_wnbd.py, properly retrieving the drive letter
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Lucian Petrut [Thu, 22 Dec 2022 13:26:36 +0000 (15:26 +0200)]
qa: add some retries to test_rbd_wnbd.py
The following operations may fail right after a block device
is attached:
* retrieving the disk number (can return -1)
* opening the disk
* setting the disk online or writable
For this reason, we'll need to add some retries. For convenience,
we're moving the existing retry logic to a separate decorator.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Lucian Petrut [Wed, 21 Dec 2022 13:58:07 +0000 (15:58 +0200)]
qa: fix test_rbd_wnbd.py, properly retrieving the drive letter
Instead of trying to use the first partiton which may be reserved
by Windows, we'll fetch the first non-empty drive letter from
the disk that we've just mounted.
While at it, we're ensuring that the drive letter is actually a
letter and not a null character, which the Powershell command
returns in case of empty drive letters.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Ilya Dryomov [Fri, 23 Dec 2022 09:44:50 +0000 (10:44 +0100)]
Merge pull request #49547 from idryomov/wip-rbd-qemu-xfstests-curl
qa: switch to curl for qemu-xfstests
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
colemitchell [Fri, 23 Dec 2022 00:56:22 +0000 (19:56 -0500)]
Merge pull request #49550 from zdover23/wip-doc-2022-12-23-rados-api-librados-intro-prompts
doc/rados: add prompts to librados-intro.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 23 Dec 2022 00:47:27 +0000 (10:47 +1000)]
doc/rados: add prompts to librados-intro.rst
Add unselectable prompts to doc/rados/api/librados-intro.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Venky Shankar [Thu, 22 Dec 2022 17:53:55 +0000 (23:23 +0530)]
Merge PR #49406 into main
* refs/pull/49406/head:
mds: fix scan_stray_dir not reset next.frag on each run of stray inode
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 22 Dec 2022 16:49:58 +0000 (22:19 +0530)]
Merge PR #49172 into main
* refs/pull/49172/head:
qa/test_nfs: added testcase test_non_existent_cluster
mgr/nfs: handle bad cluster name during info command
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 22 Dec 2022 16:17:45 +0000 (21:47 +0530)]
Merge PR #48907 into main
* refs/pull/48907/head:
test: verify that snapshot items are accounted when deciding to split/merge a directory
mds: account for snapshot items when deciding to split or merge a directory
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Kamoltat Sirivadhna [Thu, 22 Dec 2022 16:06:36 +0000 (11:06 -0500)]
Merge pull request #49259 from kamoltat/wip-ksirivad-fix-58155
mon/Elector.cc Added additional prank >= ranks_size sanity check
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Ilya Dryomov [Thu, 22 Dec 2022 15:32:44 +0000 (16:32 +0100)]
qa: switch to curl for qemu-xfstests
This is a follow-up for commit
631899ffeb84 ("qa: switch back to git
protocol for qemu-xfstests"), needed for the same "ancient execution
environment" reason.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Venky Shankar [Thu, 22 Dec 2022 14:35:55 +0000 (20:05 +0530)]
Merge PR #48281 into main
* refs/pull/48281/head:
mds: md_log_replay thread blocks waiting to be woken up
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 22 Dec 2022 14:33:16 +0000 (20:03 +0530)]
Merge PR #48822 into main
* refs/pull/48822/head:
mds: switch submit_mutex to fair mutex for MDLog
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Venky Shankar [Wed, 16 Nov 2022 10:03:55 +0000 (05:03 -0500)]
test: verify that snapshot items are accounted when deciding to split/merge a directory
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Wed, 16 Nov 2022 10:03:08 +0000 (05:03 -0500)]
mds: account for snapshot items when deciding to split or merge a directory
Its easy to "overload" a directory object with large number of omap entries by
doing the following (one shot or over and over again):
- touch dir/file{0..11000} ; create 11000 files (> mds_bal_split_size)
- mkdir dir/.snap/snap_a
- rm -f dir/file{0..11000}
End result - the directory object would have 11000 omap entries since the MDS
does not fragment directory snapshots. If the number of such entries exceed
`osd_deep_scrub_large_omap_object_key_threshold` (default: 200000), a cluster
health warning is generated:
Large Omap objects found in pool...
CDir::should_merge() does not take into account COW'd inodes and the frags
get merged.
Fixes: http://tracker.ceph.com/issues/55215
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 22 Dec 2022 14:15:08 +0000 (19:45 +0530)]
Merge PR #49098 into main
* refs/pull/49098/head:
client/fuse: add support for 3.12 API of libfuse
client/fuse: set max_idle_threads to the correct value
Reviewed-by: Venky Shankar <vshankar@redhat.com>
dparmar18 [Thu, 1 Dec 2022 10:32:39 +0000 (16:02 +0530)]
qa/test_nfs: added testcase test_non_existent_cluster
Fixes: https://tracker.ceph.com/issues/58138
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
dparmar18 [Thu, 1 Dec 2022 09:57:32 +0000 (15:27 +0530)]
mgr/nfs: handle bad cluster name during info command
It should say the cluster does not exist
Fixes: https://tracker.ceph.com/issues/58138
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
Venky Shankar [Thu, 22 Dec 2022 14:05:27 +0000 (19:35 +0530)]
Merge PR #49423 into main
* refs/pull/49423/head:
qa: remove qa/suites/marginal and restart task
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Ilya Dryomov [Thu, 22 Dec 2022 11:51:11 +0000 (12:51 +0100)]
Merge pull request #49534 from idryomov/wip-rbd-qemu-xfstests-patchup
qa: switch back to git protocol for qemu-xfstests
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Daniel Gryniewicz [Wed, 21 Dec 2022 19:59:16 +0000 (14:59 -0500)]
Merge pull request #48794 from dang/wip-dang-bucket-policy
RGW - Make sure PostObj set bucket on s->object
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Ilya Dryomov [Mon, 19 Dec 2022 17:54:08 +0000 (18:54 +0100)]
qa: switch back to git protocol for qemu-xfstests
As noted in commit
89177d65988c ("qa: switch to https protocol for
repos' server"), git.ceph.com mirror doesn't make git:// available
anymore. However, run_xfstests-obsolete.sh has "obsolete" in its
name for a reason -- due to an ancient execution environment, git://
is the only viable option:
$ git clone https://git.ceph.com/xfstests-dev.git
Cloning into 'xfstests-dev'...
error: gnutls_handshake() failed: A TLS fatal alert has been received. while accessing https://git.ceph.com/xfstests-dev.git/info/refs
fatal: HTTP request failed
Ditch git.ceph.com mirror for now.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Anthony D'Atri [Wed, 21 Dec 2022 16:51:45 +0000 (11:51 -0500)]
Merge pull request #49529 from zdover23/wip-doc-2022-12-21-rados-bluestore-config-ref-prompts
doc/rados: add prompts to bluestore-config-ref.rst
Kefu Chai [Wed, 21 Dec 2022 13:18:04 +0000 (21:18 +0800)]
Merge pull request #49403 from tchaikov/cmake-boost
cmake: pass cflags using compileflags in BuildBoost.cmake
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Lucian Petrut [Wed, 21 Dec 2022 11:09:55 +0000 (13:09 +0200)]
Merge pull request #49305 from petrutlucian94/dokan_subsys
dokan: use the right logging subsystem
Ilya Dryomov [Wed, 21 Dec 2022 10:42:57 +0000 (11:42 +0100)]
Merge pull request #48929 from petrutlucian94/rbd_py_test
qa: fix test_rbd_wnbd.py
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Wed, 21 Dec 2022 07:41:04 +0000 (17:41 +1000)]
doc/rados: add prompts to bluestore-config-ref.rst
Add unselectable prompts to
doc/rados/configuration/bluestore-config-ref.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Anthony D'Atri [Wed, 21 Dec 2022 03:28:49 +0000 (22:28 -0500)]
Merge pull request #49497 from BryceCao/wip-fix-mfa.rst-spelling-mistake
doc/radosgw: fix spelling mistake in mfa.rst
cao.leilc [Mon, 19 Dec 2022 02:52:19 +0000 (10:52 +0800)]
doc/radosgw: fix spelling mistake in mfa.rst
Signed-off-by: caolei <cao.leilc@inspur.com>
Casey Bodley [Tue, 20 Dec 2022 19:32:29 +0000 (14:32 -0500)]
Merge pull request #49402 from BryceCao/wip-fix-usage-trim-cant-be-control-by-remove-all
rgw: fix problem that usage is trimmed when the remove-all parameter …
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 20 Dec 2022 19:32:16 +0000 (14:32 -0500)]
Merge pull request #49390 from cbodley/wip-qa-rgw-inline
qa/rgw: rgw/verify suite randomizes --placement-inline-data
Reviewed-by: Cory Snyder <csnyder@iland.com>
Casey Bodley [Tue, 20 Dec 2022 19:31:54 +0000 (14:31 -0500)]
Merge pull request #49387 from cfsnyder/wip-cfsnyder-58243
rgw: fix dereference of empty std::optional in RGWDeleteMultiObj::execute()
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 20 Dec 2022 19:31:37 +0000 (14:31 -0500)]
Merge pull request #49362 from cbodley/wip-58231
rgw/sal: get_notification() takes optional_yield
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Casey Bodley [Tue, 20 Dec 2022 19:30:59 +0000 (14:30 -0500)]
Merge pull request #49324 from BryceCao/wip-add-num-limit-for-user-policies
rgw : add num limit for IAM user policies
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 20 Dec 2022 19:30:20 +0000 (14:30 -0500)]
Merge pull request #49298 from BryceCao/wip-fix-the-inheriting-class-member-is-passed-to-base-ctor
rgw : fix the inheriting class member is passed to base ctor
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Casey Bodley [Tue, 20 Dec 2022 19:29:58 +0000 (14:29 -0500)]
Merge pull request #49194 from joke-lee/list-delimiter-encode
rgw: list with Delimiter should url encode when encoding-type=url
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 20 Dec 2022 19:29:36 +0000 (14:29 -0500)]
Merge pull request #49426 from BryceCao/wip-fix-ListOpenIDConnectProviders-XML-format
rgw: fix ListOpenIDConnectProviders XML format
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Patrick Donnelly [Tue, 20 Dec 2022 18:19:17 +0000 (13:19 -0500)]
Merge PR #49016 into main
* refs/pull/49016/head:
doc/dev: remove release notes for major release branch
doc: hard-code latest release link
doc: remove rtd main checkout
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Ramana Raja [Wed, 14 Dec 2022 05:09:37 +0000 (00:09 -0500)]
mgr/rbd_support: remove localized schedule option during module startup
The localized schedule option was removed during every load of a
scheduler handler. This occured multiple times during a mgr process's
lifespan. Instead, remove the localized schedule module option when the
rbd_support module starts up.
Fixes: https://tracker.ceph.com/issues/57726
Signed-off-by: Ramana Raja <rraja@redhat.com>
Venky Shankar [Tue, 20 Dec 2022 14:22:58 +0000 (19:52 +0530)]
Merge PR #48743 into main
* refs/pull/48743/head:
mds: do not acquire xlock in xlockdone state
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Pere Diaz Bou [Tue, 20 Dec 2022 11:25:32 +0000 (12:25 +0100)]
Merge pull request #48843 from rhcs-dashboard/expose_slow_ops
mgr/prometheus: expose daemon health metrics
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Pedro Gonzalez Gomez [Tue, 20 Dec 2022 09:49:31 +0000 (10:49 +0100)]
Merge pull request #47276 from rhcs-dashboard/mirror-pool-health
mgr/dashboard: display real health in rbd mirroring pools
Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Pere Diaz Bou [Fri, 11 Nov 2022 09:43:01 +0000 (10:43 +0100)]
mgr/prometheus: expose daemon health metrics
Until now daemon health metrics were stored without being used. One of
the most helpful metrics there is SLOW_OPS with respect to OSDs and MONs
which this commit tries to expose to bring fine grained metrics to find
troublesome OSDs instead of having a lone healthcheck of slow ops in the
whole cluster.
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Yingxin [Tue, 20 Dec 2022 05:27:07 +0000 (13:27 +0800)]
Merge pull request #49496 from cyx1231st/wip-seastore-fix-denc
crimson/os/seastore: fix denc device_spec_t, device_type_t and segment_type_t
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Tue, 20 Dec 2022 04:03:34 +0000 (12:03 +0800)]
Merge pull request #49509 from rhcs-dashboard/fix-prometheus-module-blank-line
mgr/prometheus: Fix make check flake8 blank line missing
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
colemitchell [Tue, 20 Dec 2022 00:41:17 +0000 (19:41 -0500)]
Merge pull request #49514 from zdover23/wip-doc-2022-12-20-glossary-cephx-config-ref-link
doc/glossary: link to CephX Config ref
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
colemitchell [Mon, 19 Dec 2022 18:18:59 +0000 (13:18 -0500)]
Merge pull request #49513 from zdover23/wip-doc-2022-12-20-rados-auth-config-ref-prompts
doc/rados: add prompts to auth-config-ref.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Mon, 19 Dec 2022 18:16:19 +0000 (04:16 +1000)]
doc/glossary: link to CephX Config ref
Link to the CephX Configuration Reference in the "CephX" entry in the
glossary.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Zac Dover [Mon, 19 Dec 2022 18:00:59 +0000 (04:00 +1000)]
doc/rados: add prompts to auth-config-ref.rst
Add unselectable prompts to doc/rados/configuration/auth-config-ref.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
colemitchell [Mon, 19 Dec 2022 17:50:46 +0000 (12:50 -0500)]
Merge pull request #49510 from zdover23/wip-doc-2022-12-20-rados-config-msgr2-prompts
doc/rados: add prompts to msgr2.rst
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Zac Dover [Mon, 19 Dec 2022 17:41:22 +0000 (03:41 +1000)]
doc/rados: add prompts to msgr2.rst
Add unselectable prompts to doc/rados/configuration/msgr2.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Pedro Gonzalez Gomez [Mon, 19 Dec 2022 15:07:31 +0000 (16:07 +0100)]
mgr/prometheus: add blank like previously wrongly deleted that was causing issues on makecheck due to flake8
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Venky Shankar [Mon, 19 Dec 2022 10:47:14 +0000 (16:17 +0530)]
Merge PR #48473 into main
* refs/pull/48473/head:
qa: fix _run_mount_cmd() and _get_mount_cmd() args in vstart_runner
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Kefu Chai [Mon, 19 Dec 2022 10:14:13 +0000 (18:14 +0800)]
Merge pull request #49490 from tchaikov/wip-pybind-mgr-tox-fixes
pybind/mgr: tox and test fixes
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Aashish Sharma [Mon, 19 Dec 2022 08:07:12 +0000 (13:37 +0530)]
Merge pull request #49049 from rhcs-dashboard/add-osd-blocklist-metric
mgr/dashboard: Add metric relative to osd blocklist
Aashish Sharma [Mon, 19 Dec 2022 06:49:58 +0000 (12:19 +0530)]
Merge pull request #49292 from rhcs-dashboard/rbd-mirror-improvements
mgr/dashboard: rbd-mirror improvements
Anthony D'Atri [Mon, 19 Dec 2022 06:46:06 +0000 (01:46 -0500)]
Merge pull request #49203 from ktdreyer/doc-simple-cephfs-create
doc/cephfs: simplify ceph fs volume create command
Yingxin Cheng [Mon, 19 Dec 2022 02:47:46 +0000 (10:47 +0800)]
crimson/os/seastore: fix denc device_spec_t, device_type_t and segment_type_t
* device_spec_t should not include denc and be packed at the same time
* the underlying type of enum:uint8_t should support denc_traits already
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: luo rixin <luorixin@huawei.com>
Kefu Chai [Mon, 19 Dec 2022 00:47:29 +0000 (08:47 +0800)]
Merge pull request #49489 from tchaikov/wip-cmake-with-fmt-version
cmake: set WITH_FMT_VERSION as a STRING option
Reviewed-by: Mark Kogan <mkogan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
colemitchell [Sun, 18 Dec 2022 18:09:54 +0000 (13:09 -0500)]
Merge pull request #49491 from zdover23/wip-doc-2022-12-18-rados-config-ceph-conf-prompts
doc/rados: add prompts to ceph-conf.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sun, 18 Dec 2022 15:29:33 +0000 (01:29 +1000)]
doc/rados: add prompts to ceph-conf.rst
Add unselectable prompts to doc/rados/ceph-conf.rst.
https://tracker.ceph.com/issues/57108
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Sun, 18 Dec 2022 12:18:44 +0000 (20:18 +0800)]
pybind/mgr/tox.ini: add commas in "modules" variable
since tox v4.0.13, it parses the variables differently, so the newlines
in a variable are passed right to the command referencing it. so we now
have failure like:
```
flake8: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> flake8 --config=tox.ini alerts
flake8: commands[1] /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> balancer
flake8: exit 2 (0.00 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> balancer
flake8: FAIL ✖ in 3.33 seconds
```
so we have to add comma as line continuation separator to address
this problem.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 18 Dec 2022 12:16:02 +0000 (20:16 +0800)]
pybind/mgr: s/setup(self)/setup_method(self)/
avoid pytest warnings like:
4: pg_autoscaler/tests/test_cal_final_pg_target.py::TestPgAutoscaler::test_even_pools_one_meta_three_bulk
4: /home/kefu/dev/ceph/src/pybind/mgr/.tox/py3/lib/python3.10/site-packages/_pytest/fixtures.py:900: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
4: pg_autoscaler/tests/test_cal_final_pg_target.py::TestPgAutoscaler::test_even_pools_one_meta_three_bulk is using nose-specific method: `setup(self)`
4: To remove this warning, rename it to `setup_method(self)`
4: See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
4: fixture_result = next(generator)
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 18 Dec 2022 12:15:06 +0000 (20:15 +0800)]
pybind/mgr/prometheus: avoid using distutils
to silence warnings like:
4: prometheus/module.py:35
4: /var/ssd/ceph/src/pybind/mgr/prometheus/module.py:35: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
4: v = StrictVersion(cherrypy.__version__)
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 18 Dec 2022 02:47:42 +0000 (10:47 +0800)]
cmake: set WITH_FMT_VERSION as a STRING option
option() defines a boolean, so its default value cannot be populated
to find_package() as expected. so we need to set it as a cached STRING
variable.
this addresses the regression introduced by
051ec194df16927187cbe4b26dacd06c31fa186a
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 17 Dec 2022 07:08:29 +0000 (15:08 +0800)]
Merge pull request #49430 from tchaikov/wip-fmtlib-v9
cmake, script: run "make check" with fmtlib v9
Reviewed-by: Casey Bodley <cbodley@redhat.com>
zdover23 [Fri, 16 Dec 2022 15:03:22 +0000 (01:03 +1000)]
Merge pull request #49394 from zdover23/wip-doc-2022-12-10-rbd-rbd-snapshot-edit
doc/rbd: refine rbd-snapshot.rst
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Zac Dover [Fri, 9 Dec 2022 17:42:14 +0000 (03:42 +1000)]
doc/rbd: refine rbd-snapshot.rst
Refine the text in rbd-snapshot.rst
https://tracker.ceph.com/issues/57001
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Casey Bodley [Fri, 16 Dec 2022 14:19:12 +0000 (09:19 -0500)]
Merge pull request #49479 from tchaikov/wip-rgw-fmt-v8
rgw: be compatible with fmtlib v8
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Fri, 16 Dec 2022 12:05:43 +0000 (20:05 +0800)]
osd/scrubber: mark fmt::formatter<..>::format() as const
as it should be const, and more importantly, it'd fail the build with
fmtlib v9, as its caller(s) is marked as `const`.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Aashish Sharma [Fri, 16 Dec 2022 11:35:13 +0000 (17:05 +0530)]
Merge pull request #49173 from rhcs-dashboard/fix-encryption-config
mgr/dashboard: fix server side encryption config error
Kefu Chai [Fri, 16 Dec 2022 11:14:53 +0000 (19:14 +0800)]
rgw: be compatible with fmtlib v8
before fmtlib v9, fmtlib provides:
template<typename S, typename ...Args, typename Char = enable_if_t<detail::is_string<S>::value, char_t<S>>>
void fmt::print(std::basic_ostream<Char> &os, const S &format_str, Args&&... args)
but in fmtlib v9 and up, it provides:
template<typename ...T>
void fmt::print(std::ostream &os, format_string<T...> fmt, T&&... args)
so we need to use different function signatures for talking to different
fmtlib versions.
please see
https://fmt.dev/8.1.0/api.html#_CPPv4I0Dp0EN3fmt5printEvRNSt13basic_ostreamI4CharEERK1SDpRR4Args,
and
https://fmt.dev/9.0.0/api#_CPPv4IDpEN3fmt5printEvRNSt7ostreamE13format_stringIDp1TEDpRR1T
fore more details.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Aashish Sharma [Wed, 7 Dec 2022 05:25:24 +0000 (10:55 +0530)]
mgr/dashboard: Rbd Mirroring improvements
1.RBD images in dashboard shows default mirroring as journal
2.snapshot based mirroring schedule Interval got disabled to edit
3.unable to create snapshot of an image using dashboard
4.provide snapshot schedule info in a new column
5.dashboard doesn't allow importing peer bootstrap key to be imported for subsequent pools
Fixes: https://tracker.ceph.com/issues/58297
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
1a37c5e001e0bbc2720e6dfabf6ba04442acabb7 )
Lucian Petrut [Mon, 12 Dec 2022 10:13:41 +0000 (12:13 +0200)]
qa: add fs tests to test_rbd_wnbd.py
The Windows rbd-wnbd python test performs various IO operations
against raw disks.
However, it can be useful to test overlaying filesystems as well.
For this reason, we're adding the following tests:
* RbdFsTest
* RbdFsFioTest
* RbdFsStampFioTest
To simplify the implementation, those tests reuse the existing
ones along with a mixin class (RbdFsTestMixin).
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Lucian Petrut [Wed, 23 Nov 2022 14:50:08 +0000 (16:50 +0200)]
qa: test_rbd_wnbd.py improvements
We'll make the following improvements to the Windows rbd-wnbd
Python test:
* expose fio write validation, defaulting to crc32c
* change the default fio operation to "rw"
* enable the disk and clear the "rw" flag only if required by the
test and if "--skip-enabling-disk" is not set (useful with custom
SAN policies). This operation can take a significant amount of
time under heavy load.
* print fio read and write results separately instead of
aggregating them, useful when running rw tests
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Lucian Petrut [Wed, 23 Nov 2022 10:53:13 +0000 (12:53 +0200)]
doc: document Windows SAN policy
The Windows SAN policy determines which disks will be mounted
automatically. We're going to document this as well as some
Windows limitations.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Kefu Chai [Wed, 14 Dec 2022 14:53:21 +0000 (22:53 +0800)]
script/run-make: build with fmtlib 9.0.0
so we can identify changes which breaks the build with fmtlib v9.0
while running "make check" performed by jenkins.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Wed, 14 Dec 2022 14:48:46 +0000 (22:48 +0800)]
cmake: add an option named WITH_FMT_VERSION
so we can optionally force cmake to use the fmt submodule even if
fmtlib is available in system.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 16 Dec 2022 07:46:59 +0000 (15:46 +0800)]
Merge pull request #49452 from tchaikov/wip-crimson-test-fmt-v9
test/crimson: fixes related to fmtlib v9
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>