]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc/install: link to "cephadm installing ceph" 49780/head
Zac Dover [Thu, 19 Jan 2023 01:50:17 +0000 (11:50 +1000)]
doc/install: link to "cephadm installing ceph"

Link to "Installing Ceph" in the cephadm documentation instead of (as
was the case before this commit) to the cephadm overview page. Anyone
who clicks on the "cephadm" link in the context of the
doc/install/index.rst page is more likely to expect installation
instructions than to expect an explanation of what cephadm is.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49734 from linuxkidd/wip-rgw-gap-orphan-tool-error-checks
J. Eric Ivancich [Wed, 18 Jan 2023 20:30:21 +0000 (15:30 -0500)]
Merge pull request #49734 from linuxkidd/wip-rgw-gap-orphan-tool-error-checks

rgw/rgw-orphan-list: refactor and add more checks to the tool

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agorgw/rgw-orphan-list: refactor / add error checking 49734/head
Michael J. Kidd [Wed, 11 Jan 2023 19:53:50 +0000 (14:53 -0500)]
rgw/rgw-orphan-list: refactor / add error checking

standardize log output
add check that supplied pool[s] exist on the cluster
add return code checks for all commands that can affect output
add check for empty intermediate files
add usage output, including a -h command line option
add command line option to specify temporary directory to use
  ( instead of /tmp )
require command line supplied pools to be encased in double quotes "
  when multiple pools are provided
add warning for indexless buckets
move major segments to separate functions

Signed-off-by: Michael J. Kidd <linuxkidd@gmail.com>
2 years agoMerge pull request #48632 from adamemerson/wip-57562
Casey Bodley [Wed, 18 Jan 2023 15:41:31 +0000 (10:41 -0500)]
Merge pull request #48632 from adamemerson/wip-57562

rgw: Fix race condition on FIFO client on new head creation

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Krunal Chheda <kchheda3@bloomberg.net>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agoMerge pull request #47794 from rhcs-dashboard/auth-add
Pere Diaz Bou [Wed, 18 Jan 2023 09:06:29 +0000 (10:06 +0100)]
Merge pull request #47794 from rhcs-dashboard/auth-add

mgr/dashboard: create authx users

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #49765 from rhcs-dashboard/fix-bucket-encryption-checkbox
Aashish Sharma [Wed, 18 Jan 2023 04:59:31 +0000 (10:29 +0530)]
Merge pull request #49765 from rhcs-dashboard/fix-bucket-encryption-checkbox

mgr/dashboard: fix bucket encryption checkbox

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48729 from ivancich/wip-flight-select-add-flight
J. Eric Ivancich [Tue, 17 Jan 2023 23:22:54 +0000 (18:22 -0500)]
Merge pull request #48729 from ivancich/wip-flight-select-add-flight

rgw: initial commit adding Arrow Flight functionality

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48509 from jliebl-git/jliebl-ldap-fix
J. Eric Ivancich [Tue, 17 Jan 2023 22:57:08 +0000 (17:57 -0500)]
Merge pull request #48509 from jliebl-git/jliebl-ldap-fix

rgw: LDAP fix resource leak with wrong credentials

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #49636 from liangmingyuanneo/wip-read-olh-log
J. Eric Ivancich [Tue, 17 Jan 2023 22:54:54 +0000 (17:54 -0500)]
Merge pull request #49636 from liangmingyuanneo/wip-read-olh-log

rgw: remove guard_reshard in bucket_index_read_olh_log

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49463 from ivancich/wip-log-follow-bi-list
J. Eric Ivancich [Tue, 17 Jan 2023 22:52:49 +0000 (17:52 -0500)]
Merge pull request #49463 from ivancich/wip-log-follow-bi-list

rgw: add logging to radosgw-admin bi list

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 years agoMerge pull request #49648 from ivancich/wip-fix-fp-error
J. Eric Ivancich [Tue, 17 Jan 2023 22:51:38 +0000 (17:51 -0500)]
Merge pull request #49648 from ivancich/wip-fix-fp-error

rgw: fix FP error when calculating enteries per bi shard

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49181 from ljflores/wip-envlibrados-rocksdb-fix
Laura Flores [Tue, 17 Jan 2023 22:32:20 +0000 (16:32 -0600)]
Merge pull request #49181 from ljflores/wip-envlibrados-rocksdb-fix

qa/workunits/rados: skip running envlibrados rocksdb tests on ubuntu

2 years agoqa/workunits/rados: skip running envlibrados rocksdb tests on ubuntu 49181/head
Laura Flores [Thu, 1 Dec 2022 23:57:06 +0000 (17:57 -0600)]
qa/workunits/rados: skip running envlibrados rocksdb tests on ubuntu

This test passes on centos and rhel, but fails on ubuntu from an
invalid pointer. Since the envlibrados rocksdb tests are experimental
and don't have any actual users, we can just run them on rhel and
centos.

At the moment, the actual bug is not fully understood, but it was
decided that fixing it is low priority, and removing the test from
problematic distros is okay for the time being. This commit
is considered a workaround to the actual issue.

Related tracker: https://tracker.ceph.com/issues/57632
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agomgr/dashboard: fix bucket encryption checkbox 49765/head
Aashish Sharma [Tue, 17 Jan 2023 09:56:34 +0000 (15:26 +0530)]
mgr/dashboard: fix bucket encryption checkbox

Fixes: https://tracker.ceph.com/issues/58474
The encryption checkbox in the bucket creation form remains disabled after setting the vault authentication method as agent.

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agomgr/dashboard: create authx users 47794/head
Pere Diaz Bou [Wed, 24 Aug 2022 17:28:38 +0000 (19:28 +0200)]
mgr/dashboard: create authx users

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
Co-authored-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #49533 from mkogan1/wip-fips-openssl3
Casey Bodley [Tue, 17 Jan 2023 13:12:54 +0000 (08:12 -0500)]
Merge pull request #49533 from mkogan1/wip-fips-openssl3

rgw: under fips & openssl 3.x allow md5 iusage in select rgw ops

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #49710 from cyx1231st/wip-seastore-cleanup-overwrite
Yingxin [Tue, 17 Jan 2023 08:29:24 +0000 (16:29 +0800)]
Merge pull request #49710 from cyx1231st/wip-seastore-cleanup-overwrite

crimson/os/seastore/object_data_handler: cleanup the overwrite path

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #49743 from xxhdx1985126/wip-omap-fixes
Yingxin [Tue, 17 Jan 2023 08:28:43 +0000 (16:28 +0800)]
Merge pull request #49743 from xxhdx1985126/wip-omap-fixes

crimson/os/seastore/omap_manager: minor bugs fixes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson/seastore/test_omap_manager: keep test_omap_mappings consistent with... 49743/head
Xuehan Xu [Sat, 14 Jan 2023 03:05:12 +0000 (11:05 +0800)]
test/crimson/seastore/test_omap_manager: keep test_omap_mappings consistent with "rm_key_range" config

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/omap_manager: fix a capture-by-reference related issue
Xuehan Xu [Sat, 14 Jan 2023 01:09:45 +0000 (09:09 +0800)]
crimson/os/seastore/omap_manager: fix a capture-by-reference related issue

Variables that are not guaranteed to be available as long as the continuations
live shouldn't be captured by reference

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #49725 from anthonyeleven/56521
zdover23 [Mon, 16 Jan 2023 03:50:17 +0000 (13:50 +1000)]
Merge pull request #49725 from anthonyeleven/56521

doc/releases: Clarify Quincy CephFS MDS upgrade process

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49747 from zdover23/wip-doc-2023-01-16-luks-versions
Anthony D'Atri [Mon, 16 Jan 2023 03:04:59 +0000 (22:04 -0500)]
Merge pull request #49747 from zdover23/wip-doc-2023-01-16-luks-versions

doc/ceph-volume: update LUKS docs

2 years agocrimson/os/seastore: add FIXME to consider pending extent with absolute paddr 49710/head
Yingxin Cheng [Wed, 11 Jan 2023 02:04:14 +0000 (10:04 +0800)]
crimson/os/seastore: add FIXME to consider pending extent with absolute paddr

During object data overwrite.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/os/seastore/object_data_handler: cleanup the overwrite path
Yingxin Cheng [Wed, 11 Jan 2023 01:56:17 +0000 (09:56 +0800)]
crimson/os/seastore/object_data_handler: cleanup the overwrite path

* implement factory and type for extent_to_write_t.
* refactor overwrite_plan_t with explicit size calculations and
  defined operations.
* cleanup the overwrite path accordingly.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #49716 from zdover23/wip-doc-2023-01-12-rbd-iscsi-initiator-linux...
zdover23 [Mon, 16 Jan 2023 01:32:02 +0000 (11:32 +1000)]
Merge pull request #49716 from zdover23/wip-doc-2023-01-12-rbd-iscsi-initiator-linux-prompts

doc/rbd: refine iscsi-initiator-linux.rbd

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/ceph-volume: update LUKS docs 49747/head
Zac Dover [Sun, 15 Jan 2023 21:46:49 +0000 (07:46 +1000)]
doc/ceph-volume: update LUKS docs

Remove references that claim that Ceph uses only LUKS version 1.

https://tracker.ceph.com/issues/58354

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49745 from zdover23/wip-doc-2023-01-15-start-documenting-ceph...
colemitchell [Sun, 15 Jan 2023 19:54:28 +0000 (14:54 -0500)]
Merge pull request #49745 from zdover23/wip-doc-2023-01-15-start-documenting-ceph-escaping-bold-characters-within-words

doc/start: add RST escape character rules for bold

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rbd: format iscsi-initiator-linux.rbd better 49716/head
Zac Dover [Wed, 11 Jan 2023 16:00:29 +0000 (02:00 +1000)]
doc/rbd: format iscsi-initiator-linux.rbd better

Add prompts and clean up the lists in doc/rbd/iscsi-initiator-linux.rbd.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/start: add RST escape character rules for bold 49745/head
Zac Dover [Sun, 15 Jan 2023 10:45:28 +0000 (20:45 +1000)]
doc/start: add RST escape character rules for bold

Explain how to escape the bold notation (**) within words in RST.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49736 from zdover23/wip-doc-2023-01-14-dev-basic-workflow-git...
colemitchell [Fri, 13 Jan 2023 21:47:52 +0000 (16:47 -0500)]
Merge pull request #49736 from zdover23/wip-doc-2023-01-14-dev-basic-workflow-git-commands

doc/dev: add git branch management commands

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/dev: add git branch management commands 49736/head
Zac Dover [Fri, 13 Jan 2023 20:48:57 +0000 (06:48 +1000)]
doc/dev: add git branch management commands

Add git branch deleting and search commands to the "Basic Workflow" page
of the Developer Guide.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48496 from adk3798/apply-spec-parsing
Adam King [Fri, 13 Jan 2023 19:00:27 +0000 (14:00 -0500)]
Merge pull request #48496 from adk3798/apply-spec-parsing

cephadm: only pull host info from applied spec, don't try to parse yaml

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #49024 from rkachach/fix_issue_58067
Adam King [Fri, 13 Jan 2023 17:29:58 +0000 (12:29 -0500)]
Merge pull request #49024 from rkachach/fix_issue_58067

mgr/cephadm: fixing mgr port shown in ceph orch ps

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge PR #49731 into main
Patrick Donnelly [Fri, 13 Jan 2023 17:28:05 +0000 (12:28 -0500)]
Merge PR #49731 into main

* refs/pull/49731/head:
tools/cephfs: fix traceback from missing envvar

Reviewed-by: Milind Changire <mchangir@redhat.com>
2 years agoMerge pull request #48617 from adk3798/upgrade-status-help
Adam King [Fri, 13 Jan 2023 17:25:54 +0000 (12:25 -0500)]
Merge pull request #48617 from adk3798/upgrade-status-help

mgr/orchestrator: fix upgrade status help message

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #48384 from jmolmo/Rook_PDFetcher
Adam King [Fri, 13 Jan 2023 17:23:10 +0000 (12:23 -0500)]
Merge pull request #48384 from jmolmo/Rook_PDFetcher

mgr/rook: Device inventory

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Travis Nielsen <tnielsen@redhat.com>
2 years agoMerge pull request #48592 from adk3798/offline-upgrade
Adam King [Fri, 13 Jan 2023 17:01:41 +0000 (12:01 -0500)]
Merge pull request #48592 from adk3798/offline-upgrade

mgr/cephadm: improve offline host handling, mostly around upgrade

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #48574 from adk3798/debug-log-spam
Adam King [Fri, 13 Jan 2023 16:59:26 +0000 (11:59 -0500)]
Merge pull request #48574 from adk3798/debug-log-spam

mgr/cephadm: make logging refresh metadata to debug logs configurable

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #47383 from rhcs-dashboard/ceph-exporter-cephadm-changes
Adam King [Fri, 13 Jan 2023 16:54:01 +0000 (11:54 -0500)]
Merge pull request #47383 from rhcs-dashboard/ceph-exporter-cephadm-changes

exporter: cephadm changes

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #49389 from adk3798/git-archive-fix
Adam King [Fri, 13 Jan 2023 15:31:21 +0000 (10:31 -0500)]
Merge pull request #49389 from adk3798/git-archive-fix

qa/tasks/cephadm.py: fix pulling cephadm from git.ceph.com

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #49726 from rhcs-dashboard/cephadm-e2e-fixes
Nizamudeen A [Fri, 13 Jan 2023 15:01:11 +0000 (20:31 +0530)]
Merge pull request #49726 from rhcs-dashboard/cephadm-e2e-fixes

mgr/dashboard: cephadm dashboard e2e fixes

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #49635 from rkachach/fix_issue_58378
Adam King [Fri, 13 Jan 2023 14:47:33 +0000 (09:47 -0500)]
Merge pull request #49635 from rkachach/fix_issue_58378

mgr/mgr_util: fixing some tox issues

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agomgr/dashboard: cephadm dashboard e2e fixes 49726/head
Nizamudeen A [Thu, 12 Jan 2023 05:54:56 +0000 (11:24 +0530)]
mgr/dashboard: cephadm dashboard e2e fixes

Fixes: https://tracker.ceph.com/issues/58406
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #49417 from athanatos/sjust/backburner/wip-smp-option
Samuel Just [Fri, 13 Jan 2023 02:34:48 +0000 (18:34 -0800)]
Merge pull request #49417 from athanatos/sjust/backburner/wip-smp-option

crimson/osd/main: get full config before starting reactor

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agotools/cephfs: fix traceback from missing envvar 49731/head
Patrick Donnelly [Thu, 12 Jan 2023 21:12:52 +0000 (16:12 -0500)]
tools/cephfs: fix traceback from missing envvar

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agorgw: implement initial flight server functionality 48729/head
J. Eric Ivancich [Tue, 28 Jun 2022 19:35:18 +0000 (15:35 -0400)]
rgw: implement initial flight server functionality

Implements the ability for a flight to be created when the object is
retrieved by an S3 get.

Adds FlightServer abilities ListFlights, GetFlightInfo, GetSchema, and
DoGet. Adds an interface for a store for flight information and adds
an in-memory implemtation of it.

This code is functionality is early-stage and lacks some planned
efficiencies.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agodoc/releases: Clarify Quincy CephFS MDS upgrade process 49725/head
Anthony D'Atri [Thu, 12 Jan 2023 05:11:50 +0000 (00:11 -0500)]
doc/releases: Clarify Quincy CephFS MDS upgrade process

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge pull request #49713 from rhcs-dashboard/fix-sse-daemon-name
Aashish Sharma [Thu, 12 Jan 2023 05:00:40 +0000 (10:30 +0530)]
Merge pull request #49713 from rhcs-dashboard/fix-sse-daemon-name

mgr/dashboard: rgw server side encryption daemon name fix

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #49540 from xxhdx1985126/wip-rebuild-missing-set
Yingxin [Thu, 12 Jan 2023 03:50:09 +0000 (11:50 +0800)]
Merge pull request #49540 from xxhdx1985126/wip-rebuild-missing-set

crimson/osd/pg: rebuild missing set when a new interval is created

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #48575 from liu-chunmei/multicore-cyanstore
Liu-Chunmei [Thu, 12 Jan 2023 00:40:33 +0000 (16:40 -0800)]
Merge pull request #48575 from liu-chunmei/multicore-cyanstore

crimson/os: cyanstore support multicore

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49712 from tchaikov/wip-packaging-in-setuptools
Laura Flores [Wed, 11 Jan 2023 23:50:47 +0000 (17:50 -0600)]
Merge pull request #49712 from tchaikov/wip-packaging-in-setuptools

mgr/prometheus: use vendored "packaging" instead

2 years agoMerge pull request #49719 from zdover23/wip-doc-2023-01-12-dev-developer-guide-basic...
colemitchell [Wed, 11 Jan 2023 21:33:02 +0000 (16:33 -0500)]
Merge pull request #49719 from zdover23/wip-doc-2023-01-12-dev-developer-guide-basic-workflow-miscellaneous-reorganization

doc/dev: add push.autoSetupRemote instructions

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/dev: add push.autoSetupRemote instructions 49719/head
Zac Dover [Wed, 11 Jan 2023 20:24:55 +0000 (06:24 +1000)]
doc/dev: add push.autoSetupRemote instructions

Explain how to set up push.autoSetupRemote so that the origin branch is
properly set up when running "get push" without the need for the
"--set-upstream" option.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48756 from Matan-B/wip-matanb-rollback-snap
Matan [Wed, 11 Jan 2023 16:18:43 +0000 (18:18 +0200)]
Merge pull request #48756 from Matan-B/wip-matanb-rollback-snap

crimson/osd: Support snapshot rollbacks

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49568 from Matan-B/wip-matanb-crimson-modified-ranges
Matan [Wed, 11 Jan 2023 16:16:51 +0000 (18:16 +0200)]
Merge pull request #49568 from Matan-B/wip-matanb-crimson-modified-ranges

crimson/osd/*recovery_backend: Rename Push/Pull Info/Op

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
2 years agoMerge pull request #49715 from zdover23/wip-doc-2023-01-12-cephadm-host-management...
Anthony D'Atri [Wed, 11 Jan 2023 15:57:07 +0000 (10:57 -0500)]
Merge pull request #49715 from zdover23/wip-doc-2023-01-12-cephadm-host-management-osd-capitalization

doc/cephadm: s/osd/OSD/ where appropriate

2 years agoMerge PR #49711 into main
Venky Shankar [Wed, 11 Jan 2023 15:31:51 +0000 (21:01 +0530)]
Merge PR #49711 into main

* refs/pull/49711/head:
ceph.spec.in: remove the bcond_without cephfs_java option

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agodoc/cephadm: s/osd/OSD/ where appropriate 49715/head
Zac Dover [Wed, 11 Jan 2023 15:12:24 +0000 (01:12 +1000)]
doc/cephadm: s/osd/OSD/ where appropriate

Capitalize the initialization "OSD" where it occurs in natural language
in cephadm/host-management.rst. This PR answers a request made by
Anthony D'Atri and seconded by Cole Mitchell in https://github.com/ceph/ceph/pull/49699#discussion_r1066171002.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agomgr/prometheus: use vendored "packaging" instead 49712/head
Kefu Chai [Wed, 11 Jan 2023 04:12:17 +0000 (12:12 +0800)]
mgr/prometheus: use vendored "packaging" instead

instead of using the top-level "packaging" module, use the one
vendored by setuptools.

packaging python module provides versioning defined by PEP-440.
but python3-packaging is provided by CentOS8 powertools repo,
which is not enabled by default. and in CentOS9, this package
is provided by AppStream instead of BaseOS.

as prometheus mgr module is included by ceph-mgr-module-core,
it would be desirable if our user can install ceph-mgr-module-core
without enabling powertools or AppStream repo on a CentOS or
its derivative distros.

fortunately, setuptools vendors packaging module. and both
CentOS8 and CentOS9 provide python3-setuptools in their BaseOS
repos.

in this change, instead of using "packging" module, we use the
venderored one, which is in turn embedded in pkg_resources.
this python module is provided by python3-setuptools on CentOS
distros, and python3-pkg-resources on Debian and its derivatives.

the packaging recipes are updated accordingly to reflect the
new runtime dependency.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 years agomgr/dashboard: rgw server side encryption daemon name fix 49713/head
Aashish Sharma [Wed, 11 Jan 2023 10:59:35 +0000 (16:29 +0530)]
mgr/dashboard: rgw server side encryption daemon name fix

The config values for the server side encryption currently are wrongly set to the mon daemon by default. This PR intends to fix this issue

Fixes: https://tracker.ceph.com/issues/58419
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #49686 from xxhdx1985126/wip-crimson-dump-metrics
Yingxin [Wed, 11 Jan 2023 05:44:23 +0000 (13:44 +0800)]
Merge pull request #49686 from xxhdx1985126/wip-crimson-dump-metrics

crimson/admin: correct metrics dumping methods

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/os: make cyanstore not use proxy 48575/head
chunmei-liu [Wed, 11 Jan 2023 00:48:55 +0000 (16:48 -0800)]
crimson/os: make cyanstore not use proxy

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2 years agocrimson/os: make load_pgs() load pg on proper core
chunmei-liu [Wed, 11 Jan 2023 05:39:16 +0000 (21:39 -0800)]
crimson/os: make load_pgs() load pg on proper core

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2 years agocrimson/os: support multicores for cyanstore
chunmei-liu [Thu, 20 Oct 2022 05:42:47 +0000 (22:42 -0700)]
crimson/os: support multicores for cyanstore

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoceph.spec.in: remove the bcond_without cephfs_java option 49711/head
Samuel Just [Wed, 11 Jan 2023 03:19:33 +0000 (19:19 -0800)]
ceph.spec.in: remove the bcond_without cephfs_java option

This effectively disable cephfs_java for rpm builds for now.
The only user appears to be cephfs jni bindings.

Fixes: https://tracker.ceph.com/issues/58382
Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/admin: correct metrics dumping methods 49686/head
Xuehan Xu [Tue, 10 Jan 2023 06:55:57 +0000 (06:55 +0000)]
crimson/admin: correct metrics dumping methods

First level object has no key, so we have to inclose metric objects with
an outer one

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #49699 from zdover23/wip-doc-2023-01-11-cephadm-host-management...
colemitchell [Tue, 10 Jan 2023 19:31:23 +0000 (14:31 -0500)]
Merge pull request #49699 from zdover23/wip-doc-2023-01-11-cephadm-host-management-removing-hosts

doc/cephadm: refine "Removing Hosts"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49703 from zdover23/wip-doc-2023-01-11-rados-operations-move...
colemitchell [Tue, 10 Jan 2023 19:24:11 +0000 (14:24 -0500)]
Merge pull request #49703 from zdover23/wip-doc-2023-01-11-rados-operations-move-colon

doc/rados: move colon

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49700 from zdover23/wip-doc-2023-01-11-css-h3-padding
colemitchell [Tue, 10 Jan 2023 19:20:16 +0000 (14:20 -0500)]
Merge pull request #49700 from zdover23/wip-doc-2023-01-11-css-h3-padding

doc/css: add top-bar padding for h3 html element

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rados: move colon 49703/head
Zac Dover [Tue, 10 Jan 2023 19:08:35 +0000 (05:08 +1000)]
doc/rados: move colon

Move colon in add-or-rm-osds.rst so that the sentence reads properly.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/css: add top-bar padding for h3 html element 49700/head
Zac Dover [Tue, 10 Jan 2023 18:48:32 +0000 (04:48 +1000)]
doc/css: add top-bar padding for h3 html element

Add "scroll-margin-top: 4em;" property to h3 html element.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/cephadm: refine "Removing Hosts" 49699/head
Zac Dover [Tue, 10 Jan 2023 18:29:02 +0000 (04:29 +1000)]
doc/cephadm: refine "Removing Hosts"

An intended edit to remove a redundant indefinite article became a
longer (but still brief) full editorial pass.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49692 from zdover23/wip-doc-2023-01-11-header-fix
zdover23 [Tue, 10 Jan 2023 18:10:22 +0000 (04:10 +1000)]
Merge pull request #49692 from zdover23/wip-doc-2023-01-11-header-fix

doc/css: add "span" padding to custom.css

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49690 from idryomov/wip-58398
Ilya Dryomov [Tue, 10 Jan 2023 17:44:28 +0000 (18:44 +0100)]
Merge pull request #49690 from idryomov/wip-58398

doc/man/ceph-rbdnamer: remove obsolete udev rule

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agodoc/css: add "span" padding to custom.css 49692/head
Zac Dover [Tue, 10 Jan 2023 15:55:55 +0000 (01:55 +1000)]
doc/css: add "span" padding to custom.css

Add "scroll-top-bar: 2em;" for the "span" html element in custom.css so
that the top bar doesn't get in the way of headings bounded by the "span
element".

See also https://github.com/ceph/ceph/pull/49644.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/man/ceph-rbdnamer: remove obsolete udev rule 49690/head
Ilya Dryomov [Tue, 10 Jan 2023 12:40:20 +0000 (13:40 +0100)]
doc/man/ceph-rbdnamer: remove obsolete udev rule

Fixes: https://tracker.ceph.com/issues/58398
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge PR #49630 into main
Venky Shankar [Tue, 10 Jan 2023 11:11:10 +0000 (16:41 +0530)]
Merge PR #49630 into main

* refs/pull/49630/head:
doc: document the relevance of mds_namespace mount option

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agodoc: document the relevance of mds_namespace mount option 49630/head
Jos Collin [Wed, 4 Jan 2023 13:25:36 +0000 (18:55 +0530)]
doc: document the relevance of mds_namespace mount option

Fixes: https://tracker.ceph.com/issues/57673
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #49664 from batrick/first-damage-repair-nosnap
Venky Shankar [Tue, 10 Jan 2023 04:29:51 +0000 (09:59 +0530)]
Merge pull request #49664 from batrick/first-damage-repair-nosnap

tools/cephfs/first-damage: repair specific first=CEPH_NOSNAP damage

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #49677 from zdover23/wip-doc-2023-01-10-rados-replacing-an-osd
zdover23 [Tue, 10 Jan 2023 00:45:39 +0000 (10:45 +1000)]
Merge pull request #49677 from zdover23/wip-doc-2023-01-10-rados-replacing-an-osd

doc/rados: link to cephadm replacing osd section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agocls/fifo: Retry on push to nonexistent part 48632/head
Adam C. Emerson [Wed, 30 Nov 2022 00:41:40 +0000 (19:41 -0500)]
cls/fifo: Retry on push to nonexistent part

A racing client may delete the part we're trying to push to. Use
`assert_exists()` to check, and re-read metadata if we receive
-ENOENT.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agocls/fifo: Fix race condition on `_prepare_new_head`
Adam C. Emerson [Wed, 2 Nov 2022 02:49:12 +0000 (22:49 -0400)]
cls/fifo: Fix race condition on `_prepare_new_head`

First, make `_prepare_new_head` take the new head part number, so two
calls racing from the same push will attempt to create the same head.

Also remove the neorados FIFO since it doesn't have all the bug fixes
in the legacy version and will be rewritten in terms of `async_compose`
anyway.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agocls/fifo: Journal is flat_set, not multimap
Adam C. Emerson [Wed, 30 Nov 2022 22:43:15 +0000 (17:43 -0500)]
cls/fifo: Journal is flat_set, not multimap

We don't really need the overhead and complexity of a multimap.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agodoc/rados: link to cephadm replacing osd section 49677/head
Zac Dover [Mon, 9 Jan 2023 18:09:20 +0000 (04:09 +1000)]
doc/rados: link to cephadm replacing osd section

Direct readers to the "Replacing an OSD" section in the cephadm
documentation, for cases in which the instructions in "Replacing an OSD"
in the RADOS documentation don't work.

https://tracker.ceph.com/issues/58401

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocls/fifo: Move version inc into `apply_update()`
Adam C. Emerson [Wed, 14 Dec 2022 18:12:48 +0000 (13:12 -0500)]
cls/fifo: Move version inc into `apply_update()`

Only increment the version if we make an actual change.

Return whether we have changed something or not so the OSD side can
skip writing if there's no change.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agocls/fifo: Merge duplicate journal entries
Adam C. Emerson [Wed, 30 Nov 2022 21:45:49 +0000 (16:45 -0500)]
cls/fifo: Merge duplicate journal entries

Since we no longer use tags, journal entries are just an operation and
a part number. If an entry being added is already in the journal, skip
it.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agocls/fifo: Use spaceship operator to implement comparisons
Adam C. Emerson [Wed, 30 Nov 2022 21:18:31 +0000 (16:18 -0500)]
cls/fifo: Use spaceship operator to implement comparisons

Except for the version type, where only versions with the same tag are
comparable.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agocls/fifo: Remove all use of part tags
Adam C. Emerson [Wed, 30 Nov 2022 04:21:51 +0000 (23:21 -0500)]
cls/fifo: Remove all use of part tags

Part tags make part creation and setting the head non-idempotent,
leading to issues where racing RGWs may get confused about the correct
tag for a part. (Or worse, potentially have the metadata header hold
different value for a part than the part's header.)

Consistently only requires that all nodes agree on the number.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agocls/fifo: Fix `same_or_later()` comparison
Adam C. Emerson [Fri, 11 Nov 2022 01:00:38 +0000 (20:00 -0500)]
cls/fifo: Fix `same_or_later()` comparison

Fix logic error where disjunction was used instead of conjunction.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #48696 from adk3798/agent-testing-binary
Adam King [Mon, 9 Jan 2023 15:07:59 +0000 (10:07 -0500)]
Merge pull request #48696 from adk3798/agent-testing-binary

cephadm: unit tests for CephadmAgent, MgrListener, AgentGatherer

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #49495 from BryceCao/wip-fix-result-when-users-topics-is-null
Casey Bodley [Mon, 9 Jan 2023 14:45:18 +0000 (09:45 -0500)]
Merge pull request #49495 from BryceCao/wip-fix-result-when-users-topics-is-null

rgw: fix result when user's topics is null

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #49629 from guits/cv-fix-tox-allowlist_externals
Guillaume Abrioux [Mon, 9 Jan 2023 08:59:25 +0000 (09:59 +0100)]
Merge pull request #49629 from guits/cv-fix-tox-allowlist_externals

ceph-volume/tests: add allowlist_externals to tox.ini

2 years agoMerge pull request #49665 from zdover23/wip-doc-2023-01-08-glossary-ceph-object-storage
colemitchell [Sun, 8 Jan 2023 19:33:46 +0000 (14:33 -0500)]
Merge pull request #49665 from zdover23/wip-doc-2023-01-08-glossary-ceph-object-storage

doc/glossary: Clean up "Ceph Object Storage"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary: Clean up "Ceph Object Storage" 49665/head
Zac Dover [Sun, 8 Jan 2023 08:04:43 +0000 (18:04 +1000)]
doc/glossary: Clean up "Ceph Object Storage"

Remove redundant material under the "Ceph Object Storage" headword and
add a "See 'Ceph Object Store'" link. A future PR will provide a couple
of sentences that explain how object storage is what's really supporting
both CephFS and RBD.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agotools/cephfs/first-damage: repair specific first=CEPH_NOSNAP damage 49664/head
Patrick Donnelly [Sat, 7 Jan 2023 20:49:00 +0000 (15:49 -0500)]
tools/cephfs/first-damage: repair specific first=CEPH_NOSNAP damage

first==CEPH_NOSNAP is never valid. Apparently somehow the MDS may set
this in some code path yet to be discovered, even without snapshots.

Note, we probably should not necessarily automate this fix via the MDS
because we do not know if this dentry (visible in HEAD) should also be
visible before NEXT_SNAP.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agotools/cephfs/first-damage.py: load CEPH_CONF
Patrick Donnelly [Sat, 7 Jan 2023 20:48:17 +0000 (15:48 -0500)]
tools/cephfs/first-damage.py: load CEPH_CONF

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #49663 from bradfitz/patch-1
Anthony D'Atri [Sat, 7 Jan 2023 04:44:12 +0000 (23:44 -0500)]
Merge pull request #49663 from bradfitz/patch-1

doc: fix a typo

2 years agodoc: fix a typo 49663/head
Brad Fitzpatrick [Sat, 7 Jan 2023 03:54:45 +0000 (19:54 -0800)]
doc: fix a typo

Signed-off-by: Brad Fitzpatrick <brad@danga.com>
2 years agoMerge pull request #49658 from zdover23/wip-doc-2023-01-15-h2-scroll-margin-top
zdover23 [Fri, 6 Jan 2023 18:02:00 +0000 (04:02 +1000)]
Merge pull request #49658 from zdover23/wip-doc-2023-01-15-h2-scroll-margin-top

doc/css: Add scroll-margin-top to h2 html element

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49653 from zdover23/wip-doc-2023-01-06-crushtool-options
zdover23 [Fri, 6 Jan 2023 17:57:32 +0000 (03:57 +1000)]
Merge pull request #49653 from zdover23/wip-doc-2023-01-06-crushtool-options

doc/man: define --num-rep, --min-rep and --max-rep

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Laura Flores <lflores@redhat.com>