Ilya Dryomov [Thu, 19 Jan 2023 12:21:40 +0000 (13:21 +0100)]
doc/rbd/rbd-exclusive-locks: warn about automatic lock transitions
A lot of people aren't aware of automatic lock transitions and
wrongfully assume that exclusive lock means that the image remains
locked for as long as the client is running. Redo the explanation
and add a warning.
Avan [Thu, 19 Jan 2023 09:34:41 +0000 (15:04 +0530)]
Merge pull request #49759 from rhcs-dashboard/fix-pg-metrics
mgr/prometheus: export zero valued pg state metrics
Reviewed-by: Aashish Sharma <aasharma@redhat.com> Reviewed-by: Adam King <adking@redhat.com> Reviewed-by: Nizamudeen A <nia@redhat.com> Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Zac Dover [Thu, 19 Jan 2023 01:50:17 +0000 (11:50 +1000)]
doc/install: link to "cephadm installing ceph"
Link to "Installing Ceph" in the cephadm documentation instead of (as
was the case before this commit) to the cephadm overview page. Anyone
who clicks on the "cephadm" link in the context of the
doc/install/index.rst page is more likely to expect installation
instructions than to expect an explanation of what cephadm is.
standardize log output
add check that supplied pool[s] exist on the cluster
add return code checks for all commands that can affect output
add check for empty intermediate files
add usage output, including a -h command line option
add command line option to specify temporary directory to use
( instead of /tmp )
require command line supplied pools to be encased in double quotes "
when multiple pools are provided
add warning for indexless buckets
move major segments to separate functions
Signed-off-by: Michael J. Kidd <linuxkidd@gmail.com>
Lucian Petrut [Fri, 6 Jan 2023 12:29:02 +0000 (14:29 +0200)]
qa: add windows run-tests.ps1
We have a few Python rbd-wnbd tests that are invoked explicitly
by the ceph-build scripts [1].
There are a few issues with that:
* it's a separate repo that has to be updated whenever we add new
tests
* new tests that reside in the ceph repo will not be executed by
the PR check
* some tests may be missing in case of older branches
For this reason, we're adding a new script as part of the Ceph
repo that will take care of invoking the Windows rbd-wnbd tests.
The ceph-build script has already been updated accordingly [2].
Laura Flores [Thu, 1 Dec 2022 23:57:06 +0000 (17:57 -0600)]
qa/workunits/rados: skip running envlibrados rocksdb tests on ubuntu
This test passes on centos and rhel, but fails on ubuntu from an
invalid pointer. Since the envlibrados rocksdb tests are experimental
and don't have any actual users, we can just run them on rhel and
centos.
At the moment, the actual bug is not fully understood, but it was
decided that fixing it is low priority, and removing the test from
problematic distros is okay for the time being. This commit
is considered a workaround to the actual issue.
Related tracker: https://tracker.ceph.com/issues/57632 Signed-off-by: Laura Flores <lflores@redhat.com>
Aashish Sharma [Tue, 17 Jan 2023 09:56:34 +0000 (15:26 +0530)]
mgr/dashboard: fix bucket encryption checkbox
Fixes: https://tracker.ceph.com/issues/58474
The encryption checkbox in the bucket creation form remains disabled after setting the vault authentication method as agent.
Avan Thakkar [Mon, 16 Jan 2023 12:41:06 +0000 (18:11 +0530)]
mgr/prometheus: export zero valued pg state metrics
Fixes: https://tracker.ceph.com/issues/58471 Signed-off-by: Avan Thakkar <athakkar@redhat.com>
As per the Prometheus documentation, omitting zero metrics is not a best practice. The metric value for all PG_STATES should be initialized to zero.
Lucian Petrut [Fri, 6 Jan 2023 10:58:00 +0000 (12:58 +0200)]
qa: add test_rbd_wnbd resize test
We're adding a test for the newly introduced live resize feature.
It will simply extend/shrink the image, wait for the new size to
be picked up and then run FIO tests to validate the resized image.
While at it, we're fixing two unrelated linter warnings:
Yingxin Cheng [Wed, 11 Jan 2023 01:56:17 +0000 (09:56 +0800)]
crimson/os/seastore/object_data_handler: cleanup the overwrite path
* implement factory and type for extent_to_write_t.
* refactor overwrite_plan_t with explicit size calculations and
defined operations.
* cleanup the overwrite path accordingly.
Adam King [Fri, 13 Jan 2023 16:54:01 +0000 (11:54 -0500)]
Merge pull request #47383 from rhcs-dashboard/ceph-exporter-cephadm-changes
exporter: cephadm changes
Reviewed-by: Adam King <adking@redhat.com> Reviewed-by: Juan Miguel Olmo MartÃnez <jolmomar@redhat.com> Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Soumya Koduri [Mon, 26 Dec 2022 17:31:40 +0000 (12:31 -0500)]
rgw: Resolve sync stuck in previous gen
In case if any data log entries are missing for the older
generations, the sync server may not mark those shards as done
and can get stuck in that old gen for ever.
To avoid that, whenever a future gen entry is read, write the undone (shard,gen)
entry to error repo so that it can be processed and marked as done
and hence sync can progress eventually.
J. Eric Ivancich [Tue, 28 Jun 2022 19:35:18 +0000 (15:35 -0400)]
rgw: implement initial flight server functionality
Implements the ability for a flight to be created when the object is
retrieved by an S3 get.
Adds FlightServer abilities ListFlights, GetFlightInfo, GetSchema, and
DoGet. Adds an interface for a store for flight information and adds
an in-memory implemtation of it.
This code is functionality is early-stage and lacks some planned
efficiencies.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Zac Dover [Wed, 11 Jan 2023 20:24:55 +0000 (06:24 +1000)]
doc/dev: add push.autoSetupRemote instructions
Explain how to set up push.autoSetupRemote so that the origin branch is
properly set up when running "get push" without the need for the
"--set-upstream" option.
Zac Dover [Wed, 11 Jan 2023 15:12:24 +0000 (01:12 +1000)]
doc/cephadm: s/osd/OSD/ where appropriate
Capitalize the initialization "OSD" where it occurs in natural language
in cephadm/host-management.rst. This PR answers a request made by
Anthony D'Atri and seconded by Cole Mitchell in https://github.com/ceph/ceph/pull/49699#discussion_r1066171002.
Kefu Chai [Wed, 11 Jan 2023 04:12:17 +0000 (12:12 +0800)]
mgr/prometheus: use vendored "packaging" instead
instead of using the top-level "packaging" module, use the one
vendored by setuptools.
packaging python module provides versioning defined by PEP-440.
but python3-packaging is provided by CentOS8 powertools repo,
which is not enabled by default. and in CentOS9, this package
is provided by AppStream instead of BaseOS.
as prometheus mgr module is included by ceph-mgr-module-core,
it would be desirable if our user can install ceph-mgr-module-core
without enabling powertools or AppStream repo on a CentOS or
its derivative distros.
fortunately, setuptools vendors packaging module. and both
CentOS8 and CentOS9 provide python3-setuptools in their BaseOS
repos.
in this change, instead of using "packging" module, we use the
venderored one, which is in turn embedded in pkg_resources.
this python module is provided by python3-setuptools on CentOS
distros, and python3-pkg-resources on Debian and its derivatives.
the packaging recipes are updated accordingly to reflect the
new runtime dependency.