]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agorgw/cloud: Add custom headers for objects transitioned to cloud 50098/head
Soumya Koduri [Mon, 13 Feb 2023 15:00:21 +0000 (20:30 +0530)]
rgw/cloud: Add custom headers for objects transitioned to cloud

Some of the cloud services, (like MCG Noobaa/Azure Namespace store),
may not be able to map and store the objects which contain s3 style
metadata keys.

To help such services determine if the objects being transitioned
are from RGW and whether or not ignore such attrs, added below two
headers for the objects being copied/transitioned from RGW -

1) x-rgw-cloud : true/false
(set to "true" if the object is being transitioned/synced from RGW)

2) x-rgw-cloud-keep-attrs : true/false
- if set to default "true" , the cloud service should store all the
x-amz-meta-* attrs. If cannot be mapped/stored, the operation
should fail
- if set to "false", the destination cloud can ignore such attrs and
just store the object data being sent.

Also fixed a bug in the cloudtier module wherein the user-defined attrs
were not being copied to the cloud endpoint as part of transition

Fixes: https://tracker.ceph.com/issues/57980
Fixes: https://tracker.ceph.com/issues/58796
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 years agoMerge pull request #50077 from zdover23/wip-doc-2023-02-12-multisite-failover
Anthony D'Atri [Sun, 12 Feb 2023 04:54:45 +0000 (23:54 -0500)]
Merge pull request #50077 from zdover23/wip-doc-2023-02-12-multisite-failover

doc/rgw: refine "Failover and Disaster Recovery"

2 years agodoc/rgw: refine "Failover and Disaster Recovery" 50077/head
Zac Dover [Sat, 11 Feb 2023 22:04:34 +0000 (08:04 +1000)]
doc/rgw: refine "Failover and Disaster Recovery"

English grammar and syntax pass for "Failover and Disaster Recovery" in
doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50066 from zdover23/wip-doc-2023-02-10-multisite-configuring...
zdover23 [Fri, 10 Feb 2023 23:51:51 +0000 (09:51 +1000)]
Merge pull request #50066 from zdover23/wip-doc-2023-02-10-multisite-configuring-secondary-zones

doc/rgw: refine "Configuring Secondary Zones"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49763 from Svelar/vstart4
Ilya Dryomov [Fri, 10 Feb 2023 14:23:19 +0000 (15:23 +0100)]
Merge pull request #49763 from Svelar/vstart4

vstart: check mgr status after starting mgr

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50063 from zdover23/wip-doc-2023-02-10-cephfs-quota-extended...
zdover23 [Fri, 10 Feb 2023 05:29:08 +0000 (15:29 +1000)]
Merge pull request #50063 from zdover23/wip-doc-2023-02-10-cephfs-quota-extended-cephfs-attributes-and-getfattr

doc/cephfs: add note about CephFS extended attributes and getfattr

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: refine "Configuring Secondary Zones" 50066/head
Zac Dover [Fri, 10 Feb 2023 02:40:01 +0000 (12:40 +1000)]
doc/rgw: refine "Configuring Secondary Zones"

English grammar and syntax pass (and some pragmatics, too, where I had
enough understanding to be helpful that way) for "Configuring Secondary
Zones" in doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agovstart: check mgr status after starting mgr. 49763/head
Rongqi Sun [Tue, 7 Feb 2023 02:59:18 +0000 (10:59 +0800)]
vstart: check mgr status after starting mgr.

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
2 years agodoc/cephfs: add note about CephFS extended attributes and getfattr 50063/head
Zac Dover [Thu, 9 Feb 2023 22:59:00 +0000 (08:59 +1000)]
doc/cephfs: add note about CephFS extended attributes and getfattr

Supersedes https://github.com/ceph/ceph/pull/50060

Add a note on the fact that CephFS extended attributes are not printed
by "getfattr /some/cephfs/dir/ -d -m -" even when the CephFS directory
has some extended attributes set on it.

https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/6ENI42ZMHTTP2OONBRD7FDP7LQBC4P2E/

Primary Author: Rishabh Dave <ridave@redhat.com>
Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #49132 from aclamk/wip-aclamk-bs-excl-lock
Yuri Weinstein [Thu, 9 Feb 2023 15:29:36 +0000 (07:29 -0800)]
Merge pull request #49132 from aclamk/wip-aclamk-bs-excl-lock

blk/kernel: Add O_EXCL for block devices

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
2 years agoMerge pull request #50023 from rosinL/fix-vstart
Matan [Thu, 9 Feb 2023 10:30:52 +0000 (12:30 +0200)]
Merge pull request #50023 from rosinL/fix-vstart

vstart: correct condition for checking crimson

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #49744 from xxhdx1985126/wip-fix-seastar-mem-leak
Yingxin [Thu, 9 Feb 2023 08:34:26 +0000 (16:34 +0800)]
Merge pull request #49744 from xxhdx1985126/wip-fix-seastar-mem-leak

seastar: fix mem leak caused by no maximum memory limit for cpu core

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #48703 from sseshasa/wip-fix-mclk-builtin-profile-mods
Yuri Weinstein [Thu, 9 Feb 2023 01:15:08 +0000 (17:15 -0800)]
Merge pull request #48703 from sseshasa/wip-fix-mclk-builtin-profile-mods

osd: Restore defaults of mClock built-in profiles upon modification

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #48591 from rzarzynski/wip-osd-snaptrimmer-waitscrub-fix-name
Laura Flores [Wed, 8 Feb 2023 23:37:13 +0000 (17:37 -0600)]
Merge pull request #48591 from rzarzynski/wip-osd-snaptrimmer-waitscrub-fix-name

osd: fix name of WaitScrub state of SnapTrimmer

2 years agoMerge pull request #47702 from ifed01/wip-ifed-more-pin-fix
Laura Flores [Wed, 8 Feb 2023 23:36:34 +0000 (17:36 -0600)]
Merge pull request #47702 from ifed01/wip-ifed-more-pin-fix

os/bluestore: fix onode ref counting.

2 years agoMerge pull request #49888 from phlogistonjohn/jjm-more-utils-coverage
Adam King [Wed, 8 Feb 2023 18:45:09 +0000 (13:45 -0500)]
Merge pull request #49888 from phlogistonjohn/jjm-more-utils-coverage

cephadm: more test coverage for various utils functions

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #50030 from zdover23/wip-doc-2023-02-09-multisite-to-config-2ndary...
zdover23 [Wed, 8 Feb 2023 14:53:10 +0000 (00:53 +1000)]
Merge pull request #50030 from zdover23/wip-doc-2023-02-09-multisite-to-config-2ndary-zones

doc/rgw: refine multisite to "config 2ndary zones"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: refine multisite to "config 2ndary zones" 50030/head
Zac Dover [Wed, 8 Feb 2023 14:32:44 +0000 (00:32 +1000)]
doc/rgw: refine multisite to "config 2ndary zones"

Refine the English in doc/radosgw/multisite.rst up to (but not
including) "Configure Secondary Zones".

https://tracker.ceph.com/issues/58632

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50027 from joscollin/wip-drop-aitalic
Venky Shankar [Wed, 8 Feb 2023 13:23:45 +0000 (18:53 +0530)]
Merge pull request #50027 from joscollin/wip-drop-aitalic

cephfs-top: drop curses.A_ITALIC

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #50021 from rhcs-dashboard/rename-endpoints
Nizamudeen A [Wed, 8 Feb 2023 13:07:38 +0000 (18:37 +0530)]
Merge pull request #50021 from rhcs-dashboard/rename-endpoints

mgr/rgw: rename endpoints to zone_endpoints to match rgw spec

Reviewed-by: rkachach <NOT@FOUND>
2 years agoMerge pull request #48783 from rhcs-dashboard/fix-grafana-stat-panel
Aashish Sharma [Wed, 8 Feb 2023 13:04:30 +0000 (18:34 +0530)]
Merge pull request #48783 from rhcs-dashboard/fix-grafana-stat-panel

mgr/dashboard: Replace vonage-status-panel with native grafana stat panel

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agocephfs-top: drop curses.A_ITALIC 50027/head
Jos Collin [Wed, 8 Feb 2023 09:27:31 +0000 (14:57 +0530)]
cephfs-top: drop curses.A_ITALIC

Fixes: https://tracker.ceph.com/issues/58663
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #49627 from rhcs-dashboard/box-podman-osd
Pere Diaz Bou [Wed, 8 Feb 2023 10:10:51 +0000 (11:10 +0100)]
Merge pull request #49627 from rhcs-dashboard/box-podman-osd

cephadm/box: create osds with podman.

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agovstart: correct condition for checking crimson 50023/head
luo rixin [Wed, 8 Feb 2023 07:49:17 +0000 (15:49 +0800)]
vstart: correct condition for checking crimson

Signed-off-by: luo rixin <luorixin@huawei.com>
2 years agoMerge pull request #50022 from zdover23/wip-doc-2023-02-08-multisite-maintenance
Anthony D'Atri [Wed, 8 Feb 2023 02:11:59 +0000 (21:11 -0500)]
Merge pull request #50022 from zdover23/wip-doc-2023-02-08-multisite-maintenance

doc/radosgw: refine "Maintenance" in multisite.rst

2 years agoMerge pull request #50011 from zmc/deps-broken-repos
Dan Mick [Wed, 8 Feb 2023 00:19:05 +0000 (16:19 -0800)]
Merge pull request #50011 from zmc/deps-broken-repos

install-deps.sh: Fail when downloading apt repos

2 years agodoc/radosgw: refine "Maintenance" in multisite.rst 50022/head
Zac Dover [Wed, 8 Feb 2023 00:10:13 +0000 (10:10 +1000)]
doc/radosgw: refine "Maintenance" in multisite.rst

Refine the text in the "Maintenance" section of
doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agomgr/rgw: rename endpoints to zone_endpoints to match rgw spec 50021/head
Nizamudeen A [Tue, 7 Feb 2023 19:14:37 +0000 (00:44 +0530)]
mgr/rgw: rename endpoints to zone_endpoints to match rgw spec

As per the docs (and the codes), the rgw_spec.endpoint should actually
be rgw_spec.zone_endpoint.

```
rgw_realm: myrealm
rgw_zonegroup: myzonegroup
rgw_zone: myzone
zone_endpoints: http://<rgw_host1>:<rgw_port1>, http://<rgw_host2>:<rgw_port2>
```
Refer: https://docs.ceph.com/en/latest/mgr/rgw/#rgw-realm-operations

Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #49723 from anthonyeleven/anthonyeleven/58123
Anthony D'Atri [Tue, 7 Feb 2023 00:49:13 +0000 (19:49 -0500)]
Merge pull request #49723 from anthonyeleven/anthonyeleven/58123

ceph: Clarify usage message for admin-socket commands

2 years agoinstall-deps.sh: Fail when downloading apt repos 50011/head
Zack Cerza [Mon, 6 Feb 2023 20:45:39 +0000 (13:45 -0700)]
install-deps.sh: Fail when downloading apt repos

More specifically, if we get e.g. a 504 while attempting to download a
.list file, fail the build and log the status code.

Signed-off-by: Zack Cerza <zack@redhat.com>
2 years agoMerge pull request #49994 from zdover23/wip-doc-2023-02-05-rgw-multisite-refine-2
zdover23 [Mon, 6 Feb 2023 19:58:14 +0000 (05:58 +1000)]
Merge pull request #49994 from zdover23/wip-doc-2023-02-05-rgw-multisite-refine-2

doc/rgw: refine ~50-~140 of multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: refine ~50-~140 of multisite.rst 49994/head
Zac Dover [Sun, 5 Feb 2023 10:54:39 +0000 (20:54 +1000)]
doc/rgw: refine ~50-~140 of multisite.rst

Remove pleonasm from approximately line 50 to line 140 of
doc/rgw/multisite.rst.

Follows https://github.com/ceph/ceph/pull/49993.

https://tracker.ceph.com/issues/58632

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49993 from zdover23/wip-doc-2023-02-04-rgw-multisite-top-matter...
zdover23 [Sun, 5 Feb 2023 21:22:37 +0000 (07:22 +1000)]
Merge pull request #49993 from zdover23/wip-doc-2023-02-04-rgw-multisite-top-matter-refine

doc/rgw: refine 1-50 of multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: refine 1-50 of multisite.rst 49993/head
Zac Dover [Sat, 4 Feb 2023 07:53:32 +0000 (17:53 +1000)]
doc/rgw: refine 1-50 of multisite.rst

Refine the English in the first fifty lines of multisite.rst. This is
part of a project whose goal is the creation of a document that will
impart a good aerial view of RGW to a first-time reader in the minimum
number of words.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #49981 from zdover23/wip-doc-2023-02-03-rgw-multisite-zones-refinement
Anthony D'Atri [Fri, 3 Feb 2023 07:44:37 +0000 (02:44 -0500)]
Merge pull request #49981 from zdover23/wip-doc-2023-02-03-rgw-multisite-zones-refinement

doc/rgw: refine "Zones" in multisite.rst

2 years agodoc/rgw: refine "Zones" in multisite.rst 49981/head
Zac Dover [Fri, 3 Feb 2023 07:21:54 +0000 (17:21 +1000)]
doc/rgw: refine "Zones" in multisite.rst

Clean up the English under the section called "Zones". Part of a larger
project aimed at giving the reader more understanding earlier in the
documentation of how buckets and zones and zone groups and endpoints
work.

https://tracker.ceph.com/issues/58632

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49968 from zdover23/wip-doc-2023-02-02-jaegertracing-refinement
zdover23 [Thu, 2 Feb 2023 18:20:48 +0000 (04:20 +1000)]
Merge pull request #49968 from zdover23/wip-doc-2023-02-02-jaegertracing-refinement

doc/jaegertracing: refine index.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49848 from ljflores/wip-tracker-58545
Laura Flores [Thu, 2 Feb 2023 15:36:20 +0000 (09:36 -0600)]
Merge pull request #49848 from ljflores/wip-tracker-58545

qa/workunits: give telemetry opt-in check more time

2 years agodoc/jaegertracing: refine index.rst 49968/head
Zac Dover [Thu, 2 Feb 2023 07:15:44 +0000 (17:15 +1000)]
doc/jaegertracing: refine index.rst

Make English in jaegertracing/index.rst more elegant.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49935 from athanatos/sjust/wip-58486
Samuel Just [Thu, 2 Feb 2023 04:28:49 +0000 (20:28 -0800)]
Merge pull request #49935 from athanatos/sjust/wip-58486

crimson: fix incorrect interval check in PG::submit_transaction

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/net/ProtocalV2: no need to define fmt::ptr() since seastar has done it 49744/head
Xuehan Xu [Mon, 30 Jan 2023 09:55:31 +0000 (17:55 +0800)]
crimson/net/ProtocalV2: no need to define fmt::ptr() since seastar has done it

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoseastar: bump up seastar submodule to fix mem leaks
Xuehan Xu [Sun, 15 Jan 2023 08:39:36 +0000 (08:39 +0000)]
seastar: bump up seastar submodule to fix mem leaks

fix mem leak caused by no maximum memory limit for cpu core

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #49812 from petrutlucian94/poll_hup
Ionut BALUTOIU [Wed, 1 Feb 2023 09:29:11 +0000 (11:29 +0200)]
Merge pull request #49812 from petrutlucian94/poll_hup

msg: fix poll event driver, handling POLLHUP and POLLERR

2 years agoceph: Clarify usage message for admin-socket commands 49723/head
Anthony D'Atri [Thu, 12 Jan 2023 04:55:12 +0000 (23:55 -0500)]
ceph: Clarify usage message for admin-socket commands

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge pull request #48295 from NitzanMordhai/wip-nitzan-osd-start-osdmap-hang-adding...
Yuri Weinstein [Tue, 31 Jan 2023 20:15:56 +0000 (12:15 -0800)]
Merge pull request #48295 from NitzanMordhai/wip-nitzan-osd-start-osdmap-hang-adding-debug-msg

OSD: during test start, not all osds started due to consum map hang

2 years agoMerge pull request #45247 from andriytk/update-ceph-mgw
Daniel Gryniewicz [Tue, 31 Jan 2023 14:40:19 +0000 (09:40 -0500)]
Merge pull request #45247 from andriytk/update-ceph-mgw

rgw: update motr sal

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge PR #49842 into main
Venky Shankar [Tue, 31 Jan 2023 14:15:04 +0000 (19:45 +0530)]
Merge PR #49842 into main

* refs/pull/49842/head:
Revert "cmake: do not link ceph-dencoder against global"

Reviewed-by: Tim Serong <tserong@suse.com>
2 years agoMerge pull request #49946 from cityofships/pkg-docs
zdover23 [Tue, 31 Jan 2023 08:48:50 +0000 (18:48 +1000)]
Merge pull request #49946 from cityofships/pkg-docs

2 years agodoc/cephadm: grammar / syntax in install.rst 49946/head
Piotr Parczewski [Tue, 31 Jan 2023 08:29:27 +0000 (09:29 +0100)]
doc/cephadm: grammar / syntax in install.rst

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
2 years agocrimson/osd/pg: remove incorrect map epoch check in PG::submit_transasction 49935/head
Samuel Just [Mon, 30 Jan 2023 06:20:27 +0000 (22:20 -0800)]
crimson/osd/pg: remove incorrect map epoch check in PG::submit_transasction

It's entirely fine for the map_epoch to change while the op is processed
as long as none of the intervening epochs caused an interval change.  In
general, the correct way to check for an interval change is with
has_reset_since.

We don't need to do this check here at all because IOInterruptCondition
will already have performed it against the captured epoch when the
continuation resumed.

Introduced: 31418020fd58
Fixes: https://tracker.ceph.com/issues/58486
Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoRevert "cmake: do not link ceph-dencoder against global" 49842/head
Venky Shankar [Tue, 24 Jan 2023 06:19:26 +0000 (11:49 +0530)]
Revert "cmake: do not link ceph-dencoder against global"

Reverting since this is causing the following ceph-dencoder exception:

        [src/tcmalloc.cc:332] Attempt to free invalid pointer 0x558f14e3a000

NOTE: I didn't debug this any more further since there is sizable backlog
of PRs that need testing/merging, but reverting the change makes it work.

Fixes: http://tracker.ceph.com/issues/58219
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #49913 from neesingh-rh/wip-51459
zdover23 [Tue, 31 Jan 2023 00:38:33 +0000 (10:38 +1000)]
Merge pull request #49913 from neesingh-rh/wip-51459

doc: add the damage types that scrub can repair

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge PR #49048 into main
Venky Shankar [Mon, 30 Jan 2023 16:31:15 +0000 (22:01 +0530)]
Merge PR #49048 into main

* refs/pull/49048/head:
mds: fix and skip submitting invalid osd request

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 years agodoc: add the damage types that scrub can repair 49913/head
Neeraj Pratap Singh [Mon, 30 Jan 2023 14:36:20 +0000 (20:06 +0530)]
doc: add the damage types that scrub can repair

Fixes: https://tracker.ceph.com/issues/51459
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoRollback submodules changes made by accident 45247/head
Andriy Tkachuk [Sat, 28 Jan 2023 22:29:42 +0000 (22:29 +0000)]
Rollback submodules changes made by accident

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
2 years agoMerge pull request #48541 from lxbsz/wip-qa-upgrade-fix
Rishabh Dave [Mon, 30 Jan 2023 11:55:14 +0000 (17:25 +0530)]
Merge pull request #48541 from lxbsz/wip-qa-upgrade-fix

qa/cephfs: fix confusing config when upgrading mds nodes

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoMerge pull request #48049 from dparmar18/wip-dparmar-qa-mixed-clients-57280
Rishabh Dave [Mon, 30 Jan 2023 11:35:31 +0000 (17:05 +0530)]
Merge pull request #48049 from dparmar18/wip-dparmar-qa-mixed-clients-57280

qa/fs/mixed-clients: specify distros for tests

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #48251 from dparmar18/wip-dparmar-MDS-57359
Rishabh Dave [Mon, 30 Jan 2023 11:14:02 +0000 (16:44 +0530)]
Merge pull request #48251 from dparmar18/wip-dparmar-MDS-57359

mds/Server: do not allow -ve reclaim flags to cause client eviction

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #47753 from mchangir/mon-disable-snap-id-allocation-for-fsmap...
Rishabh Dave [Mon, 30 Jan 2023 11:05:04 +0000 (16:35 +0530)]
Merge pull request #47753 from mchangir/mon-disable-snap-id-allocation-for-fsmap-pools

mon: disable snap id allocation for fsmap pools

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #47114 from lxbsz/wip-56532
Rishabh Dave [Mon, 30 Jan 2023 11:01:48 +0000 (16:31 +0530)]
Merge pull request #47114 from lxbsz/wip-56532

ceph_fuse: retry the test_dentry_handling if fails

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoclient: switch to old method to invalidate dcache if euid != 0 47114/head
Xiubo Li [Thu, 20 Oct 2022 04:16:55 +0000 (12:16 +0800)]
client: switch to old method to invalidate dcache if euid != 0

Force to use the old and slow method to invalidate the dcache
if the euid is non-root, or the remount may fail with return
code 1 or 32.

https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2 years agoceph_fuse: make it to force invalidating dentries when kernel >=3.18
Xiubo Li [Wed, 19 Oct 2022 08:44:04 +0000 (16:44 +0800)]
ceph_fuse: make it to force invalidating dentries when kernel >=3.18

The remount will fail randomly for unknown reasons. And in certain
circumstance we can reprodce this very easy, which will block our
testing. Make it posible to force to old method to invalidate the
dcache when the "client_try_dentry_invalidate" option is enabled
even kernel version >= 3.18.0

Fixes: https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2 years agoceph_fuse: retry the test_dentry_handling if fails
Xiubo Li [Fri, 15 Jul 2022 09:41:43 +0000 (17:41 +0800)]
ceph_fuse: retry the test_dentry_handling if fails

For some unknown reason the remount will fail, we need to retry it
for the test_dentry_handling.

Fixes: https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2 years agoclient: move a client's option to mds-client.yaml
Xiubo Li [Fri, 15 Jul 2022 09:13:37 +0000 (17:13 +0800)]
client: move a client's option to mds-client.yaml

mds_max_retries_on_remount_failure option is used by Client.cc only.

Fixes: https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2 years agocrimson/osd/osd_operations/client_request: clarify get_obc stage message
Samuel Just [Mon, 30 Jan 2023 06:16:25 +0000 (22:16 -0800)]
crimson/osd/osd_operations/client_request: clarify get_obc stage message

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49906 from evershalik/main
Anthony D'Atri [Sun, 29 Jan 2023 18:06:44 +0000 (13:06 -0500)]
Merge pull request #49906 from evershalik/main

Update README.md

2 years agoMerge pull request #49905 from zdover23/wip-doc-2023-01-29-rados-config-osd-config...
Anthony D'Atri [Sun, 29 Jan 2023 16:55:54 +0000 (11:55 -0500)]
Merge pull request #49905 from zdover23/wip-doc-2023-01-29-rados-config-osd-config-ref-osd-op-thread-suicide-timeout

doc/rados: document osd_op_thread_suicide_timeout

2 years agoMerge pull request #49908 from Matan-B/wip-matanb-upgrade-doc
zdover23 [Sun, 29 Jan 2023 10:52:06 +0000 (20:52 +1000)]
Merge pull request #49908 from Matan-B/wip-matanb-upgrade-doc

doc/dev/developer_guide: Add Upgrade Testing Documentation

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/dev/developer_guide/testing_integration_tests: Add Upgrade Testing Documentation 49908/head
Matan Breizman [Sun, 29 Jan 2023 09:53:37 +0000 (09:53 +0000)]
doc/dev/developer_guide/testing_integration_tests: Add Upgrade Testing Documentation

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agodoc/rados: document osd_op_thread_suicide_timeout 49905/head
Zac Dover [Sat, 28 Jan 2023 21:45:35 +0000 (07:45 +1000)]
doc/rados: document osd_op_thread_suicide_timeout

Add default value for osd_op_thread_suicide_timeout configuration value
to the OSD Configuraton Reference.

https://tracker.ceph.com/issues/58590

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoUpdate README.md 49906/head
SHANKAR [Sun, 29 Jan 2023 07:12:01 +0000 (12:42 +0530)]
Update README.md

Signed-off-by: SHANKAR <98207888+evershalik@users.noreply.github.com>
2 years agoMerge branch 'master' into update-ceph-mgw
Andriy Tkachuk [Sat, 28 Jan 2023 22:10:48 +0000 (22:10 +0000)]
Merge branch 'master' into update-ceph-mgw

2 years agocrimson/osd/object_context_loader: add logging for notify_on_change
Samuel Just [Wed, 25 Jan 2023 07:14:44 +0000 (23:14 -0800)]
crimson/osd/object_context_loader: add logging for notify_on_change

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/osd/object_context_loader: convert to log macros
Samuel Just [Wed, 25 Jan 2023 07:14:20 +0000 (23:14 -0800)]
crimson/osd/object_context_loader: convert to log macros

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/osd/object_context_loader: take backend by reference
Samuel Just [Wed, 25 Jan 2023 06:55:19 +0000 (06:55 +0000)]
crimson/osd/object_context_loader: take backend by reference

It's required and we don't check for null.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/osd/pg_backend: remove stopping and peering
Samuel Just [Wed, 25 Jan 2023 05:51:34 +0000 (21:51 -0800)]
crimson/osd/pg_backend: remove stopping and peering

These two state variables duplicate checks that *should* already
be handled by the IOInterruptCondition.  None of the stopping
checks should ever trigger because the caller would be in an
interruptible future context which already performed that check.

Moreover, peering doesn't really work -- it relies on the callback
firing prior the call to on_activate_complete(), and there isn't any
guarantee that will happen.  Storing the epoch from when the
callback was created as we do in IOInterruptCondition
would be required.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/osd/pg_interval_interrupt_condition: use new logging macros
Samuel Just [Wed, 25 Jan 2023 05:33:07 +0000 (21:33 -0800)]
crimson/osd/pg_interval_interrupt_condition: use new logging macros

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/osd/replicated_backend: use new logging macros
Samuel Just [Wed, 25 Jan 2023 05:16:06 +0000 (21:16 -0800)]
crimson/osd/replicated_backend: use new logging macros

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/common: move log macros to log.h from os/seastore/logging.h
Samuel Just [Wed, 25 Jan 2023 04:53:54 +0000 (04:53 +0000)]
crimson/common: move log macros to log.h from os/seastore/logging.h

These have been handy in imposing uniformity on seastore logging,
let's start using them in PG/OSD code.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49891 from bluikko/bluikko-doc-host-management-prompts
Adam King [Fri, 27 Jan 2023 14:02:46 +0000 (09:02 -0500)]
Merge pull request #49891 from bluikko/bluikko-doc-host-management-prompts

doc/cephadm: Fix prompts in host-management.rst

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49897 from bluikko/bluikko-doc-rados-operations-prompt
zdover23 [Fri, 27 Jan 2023 13:58:09 +0000 (23:58 +1000)]
Merge pull request #49897 from bluikko/bluikko-doc-rados-operations-prompt

doc/rados/operations: Fix double prompt

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/cephadm: Fix example commands 49891/head
Ville Ojamo [Fri, 27 Jan 2023 09:07:35 +0000 (16:07 +0700)]
doc/cephadm: Fix example commands

Separate command output block from the command to avoid printing prompt on it.
Also remove double prompt.

Fix indentation of two example commands after prompt.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 years agodoc/rados/operations: Fix double prompt 49897/head
Ville Ojamo [Fri, 27 Jan 2023 10:27:51 +0000 (17:27 +0700)]
doc/rados/operations: Fix double prompt

In monitoring.rst a double prompt was rendered, one non-selectable and one selectable. Remove the selectable prompt.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 years agoMerge pull request #49894 from bluikko/bluikko-doc-rados-operations-control-indentation
zdover23 [Fri, 27 Jan 2023 10:13:25 +0000 (20:13 +1000)]
Merge pull request #49894 from bluikko/bluikko-doc-rados-operations-control-indentation

doc/rados/operations: Fix indentation

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados/operations: Fix indentation 49894/head
Ville Ojamo [Fri, 27 Jan 2023 09:38:25 +0000 (16:38 +0700)]
doc/rados/operations: Fix indentation

Fix invalid indentation that caused indentation to be rendered wrong in control.rst.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 years agoMerge pull request #49890 from bluikko/bluikko-doc-ceph-krb-auth
zdover23 [Fri, 27 Jan 2023 09:29:56 +0000 (19:29 +1000)]
Merge pull request #49890 from bluikko/bluikko-doc-ceph-krb-auth

doc/dev: use underscores in config vars

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/dev: use underscores in config vars 49890/head
Ville Ojamo [Fri, 27 Jan 2023 08:41:04 +0000 (15:41 +0700)]
doc/dev: use underscores in config vars

Use underscores instead of spaces in config vars in ceph_krb_auth.rst.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 years agoMerge pull request #49109 from NitzanMordhai/wip-nitzan-fixing-few-rados/test.sh
Brad Hubbard [Thu, 26 Jan 2023 23:46:53 +0000 (09:46 +1000)]
Merge pull request #49109 from NitzanMordhai/wip-nitzan-fixing-few-rados/test.sh

Wip nitzan fixing few rados/test.sh

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2 years agocephadm/tests: add test coverage of check_unit function 49888/head
John Mulligan [Thu, 26 Jan 2023 21:06:10 +0000 (16:06 -0500)]
cephadm/tests: add test coverage of check_unit function

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #49887 from cbodley/wip-qa-rgw-run-s3tests-tox
Ali Maredia [Thu, 26 Jan 2023 20:37:03 +0000 (15:37 -0500)]
Merge pull request #49887 from cbodley/wip-qa-rgw-run-s3tests-tox

qa/workunits/rgw: run-s3tests.sh uses tox

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 years agocephadm/tests: add test coverage for find_program
John Mulligan [Thu, 26 Jan 2023 20:11:47 +0000 (15:11 -0500)]
cephadm/tests: add test coverage for find_program

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agocephadm/tests: add test coverage for find_executable
John Mulligan [Thu, 26 Jan 2023 20:03:30 +0000 (15:03 -0500)]
cephadm/tests: add test coverage for find_executable

Also sets no coverage pragma on a windows only line. I'm assuming
cephadm isn't going to be run on windows any time soon.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #49799 from phlogistonjohn/jjm-cephadm-utils-tests
Adam King [Thu, 26 Jan 2023 16:57:53 +0000 (11:57 -0500)]
Merge pull request #49799 from phlogistonjohn/jjm-cephadm-utils-tests

cephadm/tests: add test coverage for copy_tree, copy_files, move_files, recursive_chown

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #48597 from ronen-fr/wip-rf-osd-bitfields
Yuri Weinstein [Thu, 26 Jan 2023 15:51:27 +0000 (07:51 -0800)]
Merge pull request #48597 from ronen-fr/wip-rf-osd-bitfields

osd: change two ObjectContext flags from bitfields to full variables

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoqa/workunits/rgw: run-s3tests.sh uses tox 49887/head
Casey Bodley [Thu, 26 Jan 2023 04:23:37 +0000 (23:23 -0500)]
qa/workunits/rgw: run-s3tests.sh uses tox

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49624 from ronen-fr/wip-rf-unique-formatter
Laura Flores [Thu, 26 Jan 2023 00:09:51 +0000 (18:09 -0600)]
Merge pull request #49624 from ronen-fr/wip-rf-unique-formatter

common: extend Formatter API with a unique_ptr-returning static function

2 years agoMerge pull request #49537 from rzarzynski/wip-bug-57546
Laura Flores [Thu, 26 Jan 2023 00:09:25 +0000 (18:09 -0600)]
Merge pull request #49537 from rzarzynski/wip-bug-57546

Revert "osd/PeeringState: proc_lease_ack break once found from OSD"

2 years agoMerge pull request #48854 from ifed01/wip-ifed-small-chunk-bluefs
Yuri Weinstein [Wed, 25 Jan 2023 23:23:38 +0000 (15:23 -0800)]
Merge pull request #48854 from ifed01/wip-ifed-small-chunk-bluefs

os/bluestore: enable 4K allocation unit for BlueFS

2 years agoMerge pull request #49314 from SUSE/wip-tserong-qa-crash-chown
Laura Flores [Wed, 25 Jan 2023 23:23:09 +0000 (17:23 -0600)]
Merge pull request #49314 from SUSE/wip-tserong-qa-crash-chown

qa/workunits/rados/test_crash: chown crash files to ceph user

2 years agoMerge pull request #48799 from DanWritesCode/add-exception-handling
Yuri Weinstein [Wed, 25 Jan 2023 23:22:15 +0000 (15:22 -0800)]
Merge pull request #48799 from DanWritesCode/add-exception-handling

mon: add exception handling to ceph health mute

Reviewed-by: Laura Flores <lflores@redhat.com>