]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc/glossary: add "realm" to glossary 50120/head
Zac Dover [Wed, 15 Feb 2023 07:51:41 +0000 (17:51 +1000)]
doc/glossary: add "realm" to glossary

Add the term "Realm" to the glossary, and link to the section in the RGW
documentation that provides more information about realms.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50057 from rhcs-dashboard/nfs-exports-return-fix
Nizamudeen A [Wed, 15 Feb 2023 06:38:01 +0000 (12:08 +0530)]
Merge pull request #50057 from rhcs-dashboard/nfs-exports-return-fix

mgr/dashboard: adapt nfs export code to the new changes in nfs module

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #50108 from zdover23/wip-doc-2023-02-13-multisite-multisite-config...
zdover23 [Wed, 15 Feb 2023 04:39:36 +0000 (14:39 +1000)]
Merge pull request #50108 from zdover23/wip-doc-2023-02-13-multisite-multisite-config-reference

doc/rgw: refine "Multi-site Config Ref" (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50019 from rzarzynski/wip-crimson-fix-zeroed-startevent
Samuel Just [Wed, 15 Feb 2023 03:57:02 +0000 (19:57 -0800)]
Merge pull request #50019 from rzarzynski/wip-crimson-fix-zeroed-startevent

crimson/osd: fix zeroed starting timestamp of tracked ops

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49420 from cyx1231st/wip-seastar-msgr-multi-core
Yingxin [Wed, 15 Feb 2023 01:13:06 +0000 (09:13 +0800)]
Merge pull request #49420 from cyx1231st/wip-seastar-msgr-multi-core

crimson/net: refactors to encapsulate ProtocolV2 message read and write paths and event dispatching

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agodoc/rgw: refine "Multi-site Config Ref" (1 of x) 50108/head
Zac Dover [Tue, 14 Feb 2023 11:53:02 +0000 (21:53 +1000)]
doc/rgw: refine "Multi-site Config Ref" (1 of x)

Refine the syntax (and in some cases, the semantics) of the English in
"Multi-site Configuration Reference" in doc/radosgw/multisite.rst. This
is a long section, so more PRs are likely.

https://tracker.ceph.com/issues/58632

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #47555 from JoshSalomon/wip-prim-balance-score
Laura Flores [Tue, 14 Feb 2023 21:39:09 +0000 (15:39 -0600)]
Merge pull request #47555 from JoshSalomon/wip-prim-balance-score

mon, osd: Adding read (aka workload, primary) balance score

2 years agoMerge pull request #50104 from cityofships/fix_docs_lvm_activate
Anthony D'Atri [Tue, 14 Feb 2023 14:39:12 +0000 (09:39 -0500)]
Merge pull request #50104 from cityofships/fix_docs_lvm_activate

doc/ceph-volume: fix cephadm references

2 years agoMerge pull request #50102 from cbodley/wip-github-examples-rgw
Casey Bodley [Tue, 14 Feb 2023 14:11:42 +0000 (09:11 -0500)]
Merge pull request #50102 from cbodley/wip-github-examples-rgw

examples: move rgw examples under subdirectory

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #50099 from kalebskeithley/rgw_token.gcc13
kalebskeithley [Tue, 14 Feb 2023 12:56:26 +0000 (07:56 -0500)]
Merge pull request #50099 from kalebskeithley/rgw_token.gcc13

rgw: rgw_token.cc error: reference to 'formatter' is ambiguous

2 years agoMerge pull request #49801 from rhcs-dashboard/service-instances-flickering
Nizamudeen A [Tue, 14 Feb 2023 12:44:42 +0000 (18:14 +0530)]
Merge pull request #49801 from rhcs-dashboard/service-instances-flickering

mgr/dashboard: move service_instances logic to backend

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
2 years agodoc/rgw: update links to examples/rgw 50102/head
Casey Bodley [Mon, 13 Feb 2023 22:18:49 +0000 (17:18 -0500)]
doc/rgw: update links to examples/rgw

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49834 from rhcs-dashboard/rgw-list-roles
Nizamudeen A [Tue, 14 Feb 2023 12:33:28 +0000 (18:03 +0530)]
Merge pull request #49834 from rhcs-dashboard/rgw-list-roles

mgr/dashboard: rgw role listing

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: adapt nfs export code to the new changes in nfs module 50057/head
Nizamudeen A [Thu, 9 Feb 2023 15:59:41 +0000 (21:29 +0530)]
mgr/dashboard: adapt nfs export code to the new changes in nfs module

when you create/edit an nfs export from dashboard it leaves this traceback and error

```
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard ERROR taskexec] Error while calling Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
                                             Traceback (most recent call last):
                                               File "/usr/share/ceph/mgr/dashboard/tools.py", line 550, in _run
                                                 val = self.task.fn(*self.task.fn_args, **self.task.fn_kwargs)  # type: ignore
                                               File "/usr/share/ceph/mgr/dashboard/controllers/nfs.py", line 148, in create
                                                 ret, _, err = export_mgr.apply_export(cluster_id, json.dumps(raw_ex))
                                             TypeError: 'AppliedExportResults' object is not iterable
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO taskmgr] finished Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO request] [::ffff:192.168.100.1:43896] [POST] [500] [0.767s] [admin] [172.0B] /api/nfs-ganesha/export
```
This started after https://github.com/ceph/ceph/pull/46209, so dashboard code needs to be adapted

Fixes: https://tracker.ceph.com/issues/58681
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: move service_instances logic to backend 49801/head
Nizamudeen A [Fri, 20 Jan 2023 10:28:12 +0000 (15:58 +0530)]
mgr/dashboard: move service_instances logic to backend

Fixes: https://tracker.ceph.com/issues/58504
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoosd, mon: add read balance score to command `ceph osd pool ls detail` 47555/head
Josh Salomon [Mon, 18 Apr 2022 08:37:13 +0000 (11:37 +0300)]
osd, mon: add read balance score to command `ceph osd pool ls detail`
for replicated pools.

osd: Added workload balance score to the command
     ceph osd pool ls detail
     (different flavors for console output and json/xml output)
mon: Added command 'osd rm-primary-temp'
(developers only) rm was not working
vstart: Added osd debug messages into mon log with -d flag
        For commands that execute methonds in OSD module

Signed-off-by: Josh Salomon <jsalomon@redhat.com>
2 years agoMerge pull request #50051 from rhcs-dashboard/rbd-mirroring-status-fix
Nizamudeen A [Tue, 14 Feb 2023 10:24:54 +0000 (15:54 +0530)]
Merge pull request #50051 from rhcs-dashboard/rbd-mirroring-status-fix

mgr/dashboard: fix rbd mirroring daemon health status

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agomgr/dashboard: rgw role listing 49834/head
Pere Diaz Bou [Mon, 23 Jan 2023 11:34:12 +0000 (12:34 +0100)]
mgr/dashboard: rgw role listing

Listing is performed using the radosgw-admin command api we have with
the mgr for now until the S3 api is fixed: https://tracker.ceph.com/issues/58547.

This commit fixes and issue with regards to the _crud.py controller
where redefining `CRUDClassMetadata` caused the users table and the
roles table to share columns. We fixed this by creating
CRUDClassMetadata dynamically for each endpoint.

The issue described above is linked to an issue with NamedTuple were
default nested lists are not a great move because it can cause
unexpected issues when 2 or more classes are created. Moreover,
NamedTuples are read-only making initialization even harder without
factory methods as with dataclasses. Therefore, let's move to the good
old __init__ :).

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Fixes: https://tracker.ceph.com/issues/58699
2 years agodoc/ceph-volume: fix cephadm references 50104/head
Piotr Parczewski [Tue, 14 Feb 2023 08:12:30 +0000 (09:12 +0100)]
doc/ceph-volume: fix cephadm references

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
2 years agoMerge pull request #49729 from rzarzynski/wip-crimson-obcregistry-per-pg
Samuel Just [Tue, 14 Feb 2023 07:00:05 +0000 (23:00 -0800)]
Merge pull request #49729 from rzarzynski/wip-crimson-obcregistry-per-pg

crimson/osd: make the ObjectContextRegistry per-PG

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #49020 from xxhdx1985126/wip-pg-remove
Samuel Just [Tue, 14 Feb 2023 06:58:55 +0000 (22:58 -0800)]
Merge pull request #49020 from xxhdx1985126/wip-pg-remove

crimson/osd: implement pg removal

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #50058 from rishabh-d-dave/vstart-client-debug
Venky Shankar [Tue, 14 Feb 2023 04:41:34 +0000 (10:11 +0530)]
Merge pull request #50058 from rishabh-d-dave/vstart-client-debug

vstart.sh: set logging for client and MDS when -d is passed

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoexamples: move rgw examples under subdirectory
Casey Bodley [Mon, 13 Feb 2023 22:17:18 +0000 (17:17 -0500)]
examples: move rgw examples under subdirectory

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #50076 from idryomov/wip-codeowners-doc-writers-fix
Ilya Dryomov [Mon, 13 Feb 2023 22:05:43 +0000 (23:05 +0100)]
Merge pull request #50076 from idryomov/wip-codeowners-doc-writers-fix

CODEOWNERS: don't override doc-writers by core and rbd for some files

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #50070 from xxhdx1985126/wip-sync-peering-backfill
Samuel Just [Mon, 13 Feb 2023 20:44:51 +0000 (12:44 -0800)]
Merge pull request #50070 from xxhdx1985126/wip-sync-peering-backfill

crimson/osd/pg: synchronize processing of peering events and backfill

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #49344 from xxhdx1985126/wip-obc-watchers-checkonload
Samuel Just [Mon, 13 Feb 2023 20:44:05 +0000 (12:44 -0800)]
Merge pull request #49344 from xxhdx1985126/wip-obc-watchers-checkonload

crimson/osd/object_context_loader: check on old watchers when loading obcs

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49955 from xxhdx1985126/wip-pg-stats-read
Samuel Just [Mon, 13 Feb 2023 20:43:32 +0000 (12:43 -0800)]
Merge pull request #49955 from xxhdx1985126/wip-pg-stats-read

crimson/osd/ops_executor: apply delta stats for pure read ops

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #50018 from Matan-B/wip-matanb-c-pg-pipeline
Samuel Just [Mon, 13 Feb 2023 20:42:45 +0000 (12:42 -0800)]
Merge pull request #50018 from Matan-B/wip-matanb-c-pg-pipeline

crimson/osd/osd_operations: Remove replicated_request_pg_pipeline

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoCODEOWNERS: don't override doc-writers by core and rbd for some files 50076/head
Ilya Dryomov [Sat, 11 Feb 2023 09:43:50 +0000 (10:43 +0100)]
CODEOWNERS: don't override doc-writers by core and rbd for some files

This happens because core and rbd ownership is defined after
doc-writers: a later match takes precedence.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agorgw: rgw_token.cc error: reference to 'formatter' is ambiguous 50099/head
Kaleb S. KEITHLEY [Mon, 13 Feb 2023 16:15:59 +0000 (11:15 -0500)]
rgw: rgw_token.cc error: reference to 'formatter' is ambiguous

compiling main branch on Fedora 38 and 39/rawhide with gcc-c++-13.0.1
fails with the error:

/builddir/build/BUILD/ceph-18.0.0-2148-g9754cafc/src/rgw/rgw_token.cc:
In function 'int main(int, char**)':
/builddir/build/BUILD/ceph-18.0.0-2148-g9754cafc/src/rgw/rgw_token.cc:125:3:
error: reference to 'formatter' is ambiguous
  125 | formatter = new JSONFormatter(true /* pretty */);
      |   ^~~~~~~~~

Similar error for src/test/test_rgw_token.cc

Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
2 years agoMerge pull request #50073 from cbodley/wip-codeowners-rgw
Casey Bodley [Mon, 13 Feb 2023 15:53:42 +0000 (10:53 -0500)]
Merge pull request #50073 from cbodley/wip-codeowners-rgw

github: add rgw team to CODEOWNERS

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #49555 from fmount/drive_group_crush
Adam King [Mon, 13 Feb 2023 15:09:07 +0000 (10:09 -0500)]
Merge pull request #49555 from fmount/drive_group_crush

Add per OSD crush_device_class definition

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #50086 from zdover23/wip-doc-2023-02-13-multisite-migrating-single...
zdover23 [Mon, 13 Feb 2023 12:46:05 +0000 (22:46 +1000)]
Merge pull request #50086 from zdover23/wip-doc-2023-02-13-multisite-migrating-single-site-to-multi-site

doc/rgw: "Migrating Single Site to Multi-Site"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: "Migrating Single Site to Multi-Site" 50086/head
Zac Dover [Mon, 13 Feb 2023 05:35:32 +0000 (15:35 +1000)]
doc/rgw: "Migrating Single Site to Multi-Site"

Refine "Migrating Single-site System to Multi-site" in
doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthonh D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50071 from idryomov/wip-58688
Ilya Dryomov [Mon, 13 Feb 2023 11:54:26 +0000 (12:54 +0100)]
Merge pull request #50071 from idryomov/wip-58688

qa/suites/rbd: fix sporadic "rx-only direction" test failures

Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agocrimson/net: fix the corner case when the replacing connection doesn't have socket 49420/head
Yingxin Cheng [Mon, 13 Feb 2023 06:42:13 +0000 (14:42 +0800)]
crimson/net: fix the corner case when the replacing connection doesn't have socket

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson: improve messenger test coverage
Yingxin Cheng [Mon, 13 Feb 2023 05:37:25 +0000 (13:37 +0800)]
test/crimson: improve messenger test coverage

* add blockings at custom_bp_t::SOCKET_CONNECTING
* adjust peer_wins to true

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson: enable blocking with custom_bp_t::SOCKET_CONNECTING in messenger test
Yingxin Cheng [Mon, 13 Feb 2023 03:35:35 +0000 (11:35 +0800)]
test/crimson: enable blocking with custom_bp_t::SOCKET_CONNECTING in messenger test

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson: cleanup messenger test addresses
Yingxin Cheng [Mon, 13 Feb 2023 03:28:19 +0000 (11:28 +0800)]
test/crimson: cleanup messenger test addresses

Consolidate the name/port/nonce of the addresses used in the messenger
unit tests.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agogithub: add /examples to CODEOWNERS 50073/head
Casey Bodley [Sun, 12 Feb 2023 16:00:59 +0000 (11:00 -0500)]
github: add /examples to CODEOWNERS

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #50077 from zdover23/wip-doc-2023-02-12-multisite-failover
Anthony D'Atri [Sun, 12 Feb 2023 04:54:45 +0000 (23:54 -0500)]
Merge pull request #50077 from zdover23/wip-doc-2023-02-12-multisite-failover

doc/rgw: refine "Failover and Disaster Recovery"

2 years agodoc/rgw: refine "Failover and Disaster Recovery" 50077/head
Zac Dover [Sat, 11 Feb 2023 22:04:34 +0000 (08:04 +1000)]
doc/rgw: refine "Failover and Disaster Recovery"

English grammar and syntax pass for "Failover and Disaster Recovery" in
doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50066 from zdover23/wip-doc-2023-02-10-multisite-configuring...
zdover23 [Fri, 10 Feb 2023 23:51:51 +0000 (09:51 +1000)]
Merge pull request #50066 from zdover23/wip-doc-2023-02-10-multisite-configuring-secondary-zones

doc/rgw: refine "Configuring Secondary Zones"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agogithub: add rgw team to CODEOWNERS
Casey Bodley [Fri, 10 Feb 2023 18:15:13 +0000 (13:15 -0500)]
github: add rgw team to CODEOWNERS

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoqa/suites/rbd: fix sporadic "rx-only direction" test failures 50071/head
Ilya Dryomov [Fri, 10 Feb 2023 12:56:57 +0000 (13:56 +0100)]
qa/suites/rbd: fix sporadic "rx-only direction" test failures

The existing

    xmlstarlet sel -t -v  '//mirror/peers/peer[1]/uuid')" = ""

test is bogus since a tx-only peer gets added after the remote
rbd-mirror daemon pings the local cluster.  It happened to pass most
of the time because xmlstarlet filter just failed on an empty peers
array, producing the wrongly expected empty string by accident.

Fixes: https://tracker.ceph.com/issues/58688
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #49763 from Svelar/vstart4
Ilya Dryomov [Fri, 10 Feb 2023 14:23:19 +0000 (15:23 +0100)]
Merge pull request #49763 from Svelar/vstart4

vstart: check mgr status after starting mgr

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agocrimson/osd/pg: synchronize processing of peering events and backfill 50070/head
Xuehan Xu [Fri, 10 Feb 2023 07:36:07 +0000 (15:36 +0800)]
crimson/osd/pg: synchronize processing of peering events and backfill
events

All peering events and backfill events for the same pg has to be
processed sequentially, so use a single pipeline phase to synchronize
them.

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #50063 from zdover23/wip-doc-2023-02-10-cephfs-quota-extended...
zdover23 [Fri, 10 Feb 2023 05:29:08 +0000 (15:29 +1000)]
Merge pull request #50063 from zdover23/wip-doc-2023-02-10-cephfs-quota-extended-cephfs-attributes-and-getfattr

doc/cephfs: add note about CephFS extended attributes and getfattr

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: refine "Configuring Secondary Zones" 50066/head
Zac Dover [Fri, 10 Feb 2023 02:40:01 +0000 (12:40 +1000)]
doc/rgw: refine "Configuring Secondary Zones"

English grammar and syntax pass (and some pragmatics, too, where I had
enough understanding to be helpful that way) for "Configuring Secondary
Zones" in doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agovstart: check mgr status after starting mgr. 49763/head
Rongqi Sun [Tue, 7 Feb 2023 02:59:18 +0000 (10:59 +0800)]
vstart: check mgr status after starting mgr.

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
2 years agodoc/cephfs: add note about CephFS extended attributes and getfattr 50063/head
Zac Dover [Thu, 9 Feb 2023 22:59:00 +0000 (08:59 +1000)]
doc/cephfs: add note about CephFS extended attributes and getfattr

Supersedes https://github.com/ceph/ceph/pull/50060

Add a note on the fact that CephFS extended attributes are not printed
by "getfattr /some/cephfs/dir/ -d -m -" even when the CephFS directory
has some extended attributes set on it.

https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/6ENI42ZMHTTP2OONBRD7FDP7LQBC4P2E/

Primary Author: Rishabh Dave <ridave@redhat.com>
Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agocrimson/osd: make the ObjectContextRegistry per-PG 49729/head
Radoslaw Zarzynski [Thu, 12 Jan 2023 17:16:15 +0000 (17:16 +0000)]
crimson/osd: make the ObjectContextRegistry per-PG

This patch moves the OBC registry from ShardServices (which
is basicaly a gateway to a bunch of PGs) into PG itself.
Dividing OBCs by PG (they truly belong to) minimizes the space
to search when e.g. checking whether a client is blocked or
not. Therefore, this commit is enabler of more performant
PR #47637.

The changeset draws the assumption that OBC registry and all
its users live on the same CPU core. It looks valid to me.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agovstart.sh: set logging for client and MDS when -d is passed 50058/head
Rishabh Dave [Thu, 9 Feb 2023 16:53:14 +0000 (22:23 +0530)]
vstart.sh: set logging for client and MDS when -d is passed

Set debug log messages for client and MDS to 20 when option "--debug" is
passed to vstart.sh

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge pull request #49132 from aclamk/wip-aclamk-bs-excl-lock
Yuri Weinstein [Thu, 9 Feb 2023 15:29:36 +0000 (07:29 -0800)]
Merge pull request #49132 from aclamk/wip-aclamk-bs-excl-lock

blk/kernel: Add O_EXCL for block devices

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
2 years agomgr/dashboard: fix rbd mirroring daemon health status 50051/head
Nizamudeen A [Thu, 9 Feb 2023 11:26:44 +0000 (16:56 +0530)]
mgr/dashboard: fix rbd mirroring daemon health status

Fixes: https://tracker.ceph.com/issues/58679
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50023 from rosinL/fix-vstart
Matan [Thu, 9 Feb 2023 10:30:52 +0000 (12:30 +0200)]
Merge pull request #50023 from rosinL/fix-vstart

vstart: correct condition for checking crimson

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #49744 from xxhdx1985126/wip-fix-seastar-mem-leak
Yingxin [Thu, 9 Feb 2023 08:34:26 +0000 (16:34 +0800)]
Merge pull request #49744 from xxhdx1985126/wip-fix-seastar-mem-leak

seastar: fix mem leak caused by no maximum memory limit for cpu core

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #48703 from sseshasa/wip-fix-mclk-builtin-profile-mods
Yuri Weinstein [Thu, 9 Feb 2023 01:15:08 +0000 (17:15 -0800)]
Merge pull request #48703 from sseshasa/wip-fix-mclk-builtin-profile-mods

osd: Restore defaults of mClock built-in profiles upon modification

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #48591 from rzarzynski/wip-osd-snaptrimmer-waitscrub-fix-name
Laura Flores [Wed, 8 Feb 2023 23:37:13 +0000 (17:37 -0600)]
Merge pull request #48591 from rzarzynski/wip-osd-snaptrimmer-waitscrub-fix-name

osd: fix name of WaitScrub state of SnapTrimmer

2 years agoMerge pull request #47702 from ifed01/wip-ifed-more-pin-fix
Laura Flores [Wed, 8 Feb 2023 23:36:34 +0000 (17:36 -0600)]
Merge pull request #47702 from ifed01/wip-ifed-more-pin-fix

os/bluestore: fix onode ref counting.

2 years agoMerge pull request #49888 from phlogistonjohn/jjm-more-utils-coverage
Adam King [Wed, 8 Feb 2023 18:45:09 +0000 (13:45 -0500)]
Merge pull request #49888 from phlogistonjohn/jjm-more-utils-coverage

cephadm: more test coverage for various utils functions

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #50030 from zdover23/wip-doc-2023-02-09-multisite-to-config-2ndary...
zdover23 [Wed, 8 Feb 2023 14:53:10 +0000 (00:53 +1000)]
Merge pull request #50030 from zdover23/wip-doc-2023-02-09-multisite-to-config-2ndary-zones

doc/rgw: refine multisite to "config 2ndary zones"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: refine multisite to "config 2ndary zones" 50030/head
Zac Dover [Wed, 8 Feb 2023 14:32:44 +0000 (00:32 +1000)]
doc/rgw: refine multisite to "config 2ndary zones"

Refine the English in doc/radosgw/multisite.rst up to (but not
including) "Configure Secondary Zones".

https://tracker.ceph.com/issues/58632

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50027 from joscollin/wip-drop-aitalic
Venky Shankar [Wed, 8 Feb 2023 13:23:45 +0000 (18:53 +0530)]
Merge pull request #50027 from joscollin/wip-drop-aitalic

cephfs-top: drop curses.A_ITALIC

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #50021 from rhcs-dashboard/rename-endpoints
Nizamudeen A [Wed, 8 Feb 2023 13:07:38 +0000 (18:37 +0530)]
Merge pull request #50021 from rhcs-dashboard/rename-endpoints

mgr/rgw: rename endpoints to zone_endpoints to match rgw spec

Reviewed-by: rkachach <NOT@FOUND>
2 years agoMerge pull request #48783 from rhcs-dashboard/fix-grafana-stat-panel
Aashish Sharma [Wed, 8 Feb 2023 13:04:30 +0000 (18:34 +0530)]
Merge pull request #48783 from rhcs-dashboard/fix-grafana-stat-panel

mgr/dashboard: Replace vonage-status-panel with native grafana stat panel

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agocephfs-top: drop curses.A_ITALIC 50027/head
Jos Collin [Wed, 8 Feb 2023 09:27:31 +0000 (14:57 +0530)]
cephfs-top: drop curses.A_ITALIC

Fixes: https://tracker.ceph.com/issues/58663
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #49627 from rhcs-dashboard/box-podman-osd
Pere Diaz Bou [Wed, 8 Feb 2023 10:10:51 +0000 (11:10 +0100)]
Merge pull request #49627 from rhcs-dashboard/box-podman-osd

cephadm/box: create osds with podman.

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agovstart: correct condition for checking crimson 50023/head
luo rixin [Wed, 8 Feb 2023 07:49:17 +0000 (15:49 +0800)]
vstart: correct condition for checking crimson

Signed-off-by: luo rixin <luorixin@huawei.com>
2 years agocrimson/net: fix fmt related compile issue
Yingxin Cheng [Mon, 6 Feb 2023 06:09:42 +0000 (14:09 +0800)]
crimson/net: fix fmt related compile issue

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: drop and replace __func__
Yingxin Cheng [Wed, 14 Dec 2022 08:35:34 +0000 (16:35 +0800)]
crimson/net: drop and replace __func__

__func__ is meaningless in the lambda function with continuations.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: fixes to print exceptions and errors
Yingxin Cheng [Tue, 13 Dec 2022 08:39:05 +0000 (16:39 +0800)]
crimson/net: fixes to print exceptions and errors

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: introduce IOHandler class for message and event dispatching
Yingxin Cheng [Wed, 7 Dec 2022 02:08:18 +0000 (10:08 +0800)]
crimson/net: introduce IOHandler class for message and event dispatching

IOHandler also represents the Connection as ConnectionHandler.

ProtocolV2 and IOHandler will be finally running in different cores, as
ProtocolV2 will need to call IOHandler interfaces asynchronously. And
IOHandler will also notify ProtocolV2 through HandshakeListener
asynchronously.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: cleanups to Protocol and ProtocolV2 interfaces
Yingxin Cheng [Wed, 7 Dec 2022 02:06:31 +0000 (10:06 +0800)]
crimson/net: cleanups to Protocol and ProtocolV2 interfaces

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: cleanup, rename out_state to io_state
Yingxin Cheng [Wed, 7 Dec 2022 01:47:53 +0000 (09:47 +0800)]
crimson/net: cleanup, rename out_state to io_state

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: drop Protocol::print_conn()
Yingxin Cheng [Tue, 6 Dec 2022 01:39:34 +0000 (09:39 +0800)]
crimson/net: drop Protocol::print_conn()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move mark_down() from ProtocolV2 to Protocol
Yingxin Cheng [Tue, 6 Dec 2022 01:15:28 +0000 (09:15 +0800)]
crimson/net: move mark_down() from ProtocolV2 to Protocol

Process mark_down in Protocol rather than in ProtocolV2 to prevent
further event dispatching after mark_down is called by user. Then notify
ProtocolV2 as the IO/socket core and handshake core can be different and
the notification can be asynchronous.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move is_connected() from ProtocolV2 to Protocol
Yingxin Cheng [Mon, 5 Dec 2022 08:30:25 +0000 (16:30 +0800)]
crimson/net: move is_connected() from ProtocolV2 to Protocol

Infer is_connected by connection events instead of the protocol V2
internals. That can save a cross-core operation for connection users
from the connection IO core to the handshake core.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: hide dispatchers from ProtocolV2
Yingxin Cheng [Fri, 2 Dec 2022 09:21:58 +0000 (17:21 +0800)]
crimson/net: hide dispatchers from ProtocolV2

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: unshare conn for ProtocolV2 and Protocol
Yingxin Cheng [Fri, 2 Dec 2022 08:56:13 +0000 (16:56 +0800)]
crimson/net: unshare conn for ProtocolV2 and Protocol

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: make it explict about the FrameAssemberV2 ownership
Yingxin Cheng [Fri, 2 Dec 2022 08:28:36 +0000 (16:28 +0800)]
crimson/net: make it explict about the FrameAssemberV2 ownership

FrameAssemblerV2 is owned by ProtocolV2 during handshake, and owned by
Protocol during messaging.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: change out_state_changed to promise<> as it is not shared
Yingxin Cheng [Fri, 2 Dec 2022 08:21:55 +0000 (16:21 +0800)]
crimson/net: change out_state_changed to promise<> as it is not shared

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move message read path from ProtocolV2 to Protocol
Yingxin Cheng [Thu, 1 Dec 2022 02:36:35 +0000 (10:36 +0800)]
crimson/net: move message read path from ProtocolV2 to Protocol

Also move socket shutdown ownership to Protocol at READY/open.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move message write path from ProtocolV2 to Protocol
Yingxin Cheng [Thu, 1 Dec 2022 02:34:56 +0000 (10:34 +0800)]
crimson/net: move message write path from ProtocolV2 to Protocol

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move dispatch ms_handle_connect() before READY
Yingxin Cheng [Thu, 1 Dec 2022 01:55:34 +0000 (09:55 +0800)]
crimson/net: move dispatch ms_handle_connect() before READY

It would be too late to notify connected after the status becomes READY
and open.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move intercept_frame() from ProtocolV2 down to FrameAssemblerV2
Yingxin Cheng [Thu, 1 Dec 2022 01:47:36 +0000 (09:47 +0800)]
crimson/net: move intercept_frame() from ProtocolV2 down to FrameAssemblerV2

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: refactor socket managements
Yingxin Cheng [Fri, 25 Nov 2022 02:08:52 +0000 (10:08 +0800)]
crimson/net: refactor socket managements

Previously, the socket state is transparent to the protocol and
implicitly handled. Move the responsibilities into protocol for finer
controls to further decouple the IO and handshake.

Also, refactor the fault handling and make the in/out message
dispatching more symmetric.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: fix execution_done wait mechanism
Yingxin Cheng [Fri, 25 Nov 2022 02:05:18 +0000 (10:05 +0800)]
crimson/net: fix execution_done wait mechanism

* prepare the execution_done before the function is invoked, not after.
* execution_done future doesn't need to be shared.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: improve logs
Yingxin Cheng [Fri, 25 Nov 2022 02:03:14 +0000 (10:03 +0800)]
crimson/net: improve logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson/test_messenger: change the logger subsys to test
Yingxin Cheng [Fri, 25 Nov 2022 01:58:39 +0000 (09:58 +0800)]
test/crimson/test_messenger: change the logger subsys to test

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move ms_handle_accept into the replacing gate
Yingxin Cheng [Fri, 25 Nov 2022 01:54:56 +0000 (09:54 +0800)]
crimson/net: move ms_handle_accept into the replacing gate

To prevent others to close the connection before the gate, and causing
abort without proper closing the moving socket.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: add aborts when the state is inconsistent
Yingxin Cheng [Fri, 25 Nov 2022 01:51:50 +0000 (09:51 +0800)]
crimson/net: add aborts when the state is inconsistent

To prevent unexpected event dispatching and state transitions.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move remote reset after waiting
Yingxin Cheng [Fri, 25 Nov 2022 01:31:20 +0000 (09:31 +0800)]
crimson/net: move remote reset after waiting

And only dispatch the remote reset when the connection is still valid.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: introduce and integrate FrameAssemblerV2
Yingxin Cheng [Thu, 17 Nov 2022 09:06:17 +0000 (17:06 +0800)]
crimson/net: introduce and integrate FrameAssemblerV2

FrameAssemblerV2 encapsulates the low-level frame processing for
protocol v2, and manages the socket instance.

FrameAssemblerV2 is supposed to be running on the socket core for
performance reasons, which will be changable.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: split gate for handshake and IO
Yingxin Cheng [Wed, 16 Nov 2022 05:16:07 +0000 (13:16 +0800)]
crimson/net: split gate for handshake and IO

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move close logic from Protocol to ProtocolV2
Yingxin Cheng [Thu, 3 Nov 2022 05:45:47 +0000 (13:45 +0800)]
crimson/net: move close logic from Protocol to ProtocolV2

Protocol class will be removed.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: rename in/out related members and methods
Yingxin Cheng [Thu, 3 Nov 2022 02:48:56 +0000 (10:48 +0800)]
crimson/net: rename in/out related members and methods

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move IO members into Protocol class
Yingxin Cheng [Tue, 1 Nov 2022 08:43:15 +0000 (16:43 +0800)]
crimson/net: move IO members into Protocol class

In order to introduce the cross-core IOHandler class.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: proper group SocketConnection interfaces
Yingxin Cheng [Mon, 31 Oct 2022 09:32:53 +0000 (17:32 +0800)]
crimson/net: proper group SocketConnection interfaces

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: move socket from Protocol to SocketConnection
Yingxin Cheng [Mon, 31 Oct 2022 09:31:23 +0000 (17:31 +0800)]
crimson/net: move socket from Protocol to SocketConnection

Protocol class will be removed.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>