]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agocrimson/os/seastore/async_cleaner: make backref retrieval trans non-weak 50191/head
Xuehan Xu [Thu, 23 Feb 2023 01:56:01 +0000 (01:56 +0000)]
crimson/os/seastore/async_cleaner: make backref retrieval trans non-weak

backref retrieval transactions may conflict with others on RootBlock

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/cache: return the RootBlock it's waiting on in
Xuehan Xu [Thu, 23 Feb 2023 01:30:59 +0000 (01:30 +0000)]
crimson/os/seastore/cache: return the RootBlock it's waiting on in
`Cache::get_root()`

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #50165 from zdover23/wip-doc-2023-02-19-radosgw-multisite-multisit...
zdover23 [Tue, 21 Feb 2023 04:52:21 +0000 (14:52 +1000)]
Merge pull request #50165 from zdover23/wip-doc-2023-02-19-radosgw-multisite-multisite-top-matter-cleanup

doc/rgw: multisite ref. top matter cleanup

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50186 from zdover23/wip-doc-2023-02-21-radosgw-session-tags-rende...
zdover23 [Tue, 21 Feb 2023 04:09:30 +0000 (14:09 +1000)]
Merge pull request #50186 from zdover23/wip-doc-2023-02-21-radosgw-session-tags-render-fix

doc/rgw: session-tags.rst - fix link to keycloak

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge PR #49154 into main
Venky Shankar [Tue, 21 Feb 2023 04:03:18 +0000 (09:33 +0530)]
Merge PR #49154 into main

* refs/pull/49154/head:
qa: add tests for cephfs-top
doc: updates --dump and --dumpfs
cephfs-top: dump values to stdout

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: session-tags.rst - fix link to keycloak 50186/head
Zac Dover [Tue, 21 Feb 2023 03:55:03 +0000 (13:55 +1000)]
doc/rgw: session-tags.rst - fix link to keycloak

Fix a link in the doc/radosgw/session-tags.rst file that was intended to
link to the doc/radosgw/keycloak.rst file.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #43145 from pritha-srivastava/wip-rgw-sts-doc-fixes
zdover23 [Tue, 21 Feb 2023 03:48:28 +0000 (13:48 +1000)]
Merge pull request #43145 from pritha-srivastava/wip-rgw-sts-doc-fixes

rgw/sts: correcting documentation errors.

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49843 from shreyanshjain7174/compression_58410
Yuri Weinstein [Mon, 20 Feb 2023 22:29:38 +0000 (14:29 -0800)]
Merge pull request #49843 from shreyanshjain7174/compression_58410

rados: Set snappy as default value in ms_osd_compression_algorithm

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #49487 from trociny/wip-58269
Yuri Weinstein [Mon, 20 Feb 2023 22:28:49 +0000 (14:28 -0800)]
Merge pull request #49487 from trociny/wip-58269

mgr: don't dump global config holding gil

Reviewed-by: Tim Serong <tserong@suse.com>
2 years agoMerge pull request #49379 from zhsgao/osd_deep_scrub_stride
Yuri Weinstein [Mon, 20 Feb 2023 22:27:31 +0000 (14:27 -0800)]
Merge pull request #49379 from zhsgao/osd_deep_scrub_stride

osd/scrub: add a variable to store osd_deep_scrub_stride

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #49199 from ifed01/wip-ifed-fix-require-osd-release
Yuri Weinstein [Mon, 20 Feb 2023 22:26:39 +0000 (14:26 -0800)]
Merge pull request #49199 from ifed01/wip-ifed-fix-require-osd-release

mon: avoid exception when setting require-osd-release more than 2

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #45414 from ifed01/wip-ifed-log-before-assert-in-avl
Yuri Weinstein [Mon, 20 Feb 2023 22:26:11 +0000 (14:26 -0800)]
Merge pull request #45414 from ifed01/wip-ifed-log-before-assert-in-avl

os/bluestore: log before assert in AvlAllocator

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #49335 from yuvalif/wip-yuval-fix-58167
Yuval Lifshitz [Mon, 20 Feb 2023 20:29:51 +0000 (22:29 +0200)]
Merge pull request #49335 from yuvalif/wip-yuval-fix-58167

prevent anonymous topic operations

Reviewed-By: pritha-srivastava, cbodley
2 years agoMerge pull request #48709 from yanghonggang/yhg-jaeger-port
Yuval Lifshitz [Mon, 20 Feb 2023 20:27:06 +0000 (22:27 +0200)]
Merge pull request #48709 from yanghonggang/yhg-jaeger-port

common: add a config option for jaeger agent port

Reviewed-By: tchaikov, zenomri, yuvalif
2 years agoMerge pull request #49910 from myoungwon/fix-58587
Laura Flores [Mon, 20 Feb 2023 20:24:03 +0000 (14:24 -0600)]
Merge pull request #49910 from myoungwon/fix-58587

qa/workunits/rados/test_dedup_tool.sh: reset dedup tier during tests

2 years agoMerge pull request #49950 from cbodley/wip-qa-ragweed-tox
Casey Bodley [Mon, 20 Feb 2023 14:29:50 +0000 (09:29 -0500)]
Merge pull request #49950 from cbodley/wip-qa-ragweed-tox

qa/rgw: run ragweed tests with tox

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 years agoMerge pull request #49962 from robbat2/main-post_object_upload_size_rgw_chunk_size_bug
Casey Bodley [Mon, 20 Feb 2023 14:28:41 +0000 (09:28 -0500)]
Merge pull request #49962 from robbat2/main-post_object_upload_size_rgw_chunk_size_bug

rgw: Fix Browser POST content-length-range min value

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #50166 from zdover23/wip-doc-2023-02-19-radosgw-multisite-zonegrou...
zdover23 [Mon, 20 Feb 2023 08:21:16 +0000 (18:21 +1000)]
Merge pull request #50166 from zdover23/wip-doc-2023-02-19-radosgw-multisite-zonegroup-setup-cleanup

doc/rgw: refine "Setting a Zonegroup"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rgw: refine "Setting a Zonegroup" 50166/head
Zac Dover [Sun, 19 Feb 2023 13:50:43 +0000 (23:50 +1000)]
doc/rgw: refine "Setting a Zonegroup"

Streamline the "Setting a Zonegroup" section by separating out the
necessary prerequisite reading from the procedure itself.

I also corrected a typo in the word "following" in an unrelated section.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50164 from zdover23/wip-doc-2023-02-19-radosgw-multisite-execute...
zdover23 [Mon, 20 Feb 2023 00:55:32 +0000 (10:55 +1000)]
Merge pull request #50164 from zdover23/wip-doc-2023-02-19-radosgw-multisite-execute-removal

doc/radosgw: s/execute/run/ in multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50160 from cbodley/wip-qa-rgw-notification-example
Casey Bodley [Sun, 19 Feb 2023 13:41:52 +0000 (08:41 -0500)]
Merge pull request #50160 from cbodley/wip-qa-rgw-notification-example

qa/rgw: update boto3 example path in notification_tests.py

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agodoc/rgw: multisite ref. top matter cleanup 50165/head
Zac Dover [Sun, 19 Feb 2023 13:20:45 +0000 (23:20 +1000)]
doc/rgw: multisite ref. top matter cleanup

Edit the top matter in "Multi-site Configuration Reference" so that it
is semantically more natural.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/radosgw: s/execute/run/ in multisite.rst 50164/head
Zac Dover [Sun, 19 Feb 2023 06:46:49 +0000 (16:46 +1000)]
doc/radosgw: s/execute/run/ in multisite.rst

Replace "execute" with "run" in fourteen out of fifteen instances in
multisite.rst. "Execute" is plain old too grand in most of these
instances.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #48683 from linuxbox2/wip-rgwlc-faststop
J. Eric Ivancich [Sat, 18 Feb 2023 18:58:02 +0000 (13:58 -0500)]
Merge pull request #48683 from linuxbox2/wip-rgwlc-faststop

rgwlc: prevent lc for one bucket from exceeding time budget

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #49785 from theanalyst/rgw-swift-key
J. Eric Ivancich [Sat, 18 Feb 2023 18:56:14 +0000 (13:56 -0500)]
Merge pull request #49785 from theanalyst/rgw-swift-key

rgw: swift : check for valid key in POST forms

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #49951 from ivancich/wip-clean-up-2023-Jan-23-coverity
J. Eric Ivancich [Sat, 18 Feb 2023 18:54:26 +0000 (13:54 -0500)]
Merge pull request #49951 from ivancich/wip-clean-up-2023-Jan-23-coverity

rgw: clean up January 21, 2023 coverity scan issues

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #50157 from guits/fix-simple-scan-cv
Guillaume Abrioux [Sat, 18 Feb 2023 18:26:25 +0000 (19:26 +0100)]
Merge pull request #50157 from guits/fix-simple-scan-cv

ceph-volume: legacy_encrypted() shouldn't call lsblk() when device is 'tmpfs'

2 years agoqa/rgw: update boto3 example path in notification_tests.py 50160/head
Casey Bodley [Sat, 18 Feb 2023 14:30:36 +0000 (09:30 -0500)]
qa/rgw: update boto3 example path in notification_tests.py

fallout from https://github.com/ceph/ceph/pull/50102

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoceph-volume: legacy_encrypted() shouldn't call lsblk() when device is 'tmpfs' 50157/head
Guillaume Abrioux [Sat, 18 Feb 2023 02:05:51 +0000 (03:05 +0100)]
ceph-volume: legacy_encrypted() shouldn't call lsblk() when device is 'tmpfs'

When the device variable is rebound and become 'tmpfs', lsblk() shouldn't be called.

Fixes: https://tracker.ceph.com/issues/58784
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 years agoMerge pull request #50154 from zdover23/wip-doc-2023-02-18-glossary-period-rgw
Anthony D'Atri [Sat, 18 Feb 2023 00:01:31 +0000 (19:01 -0500)]
Merge pull request #50154 from zdover23/wip-doc-2023-02-18-glossary-period-rgw

doc/glossary: add "Period" to glossary

2 years agodoc/glossary: add "Period" to glossary 50154/head
Zac Dover [Fri, 17 Feb 2023 22:03:06 +0000 (08:03 +1000)]
doc/glossary: add "Period" to glossary

Add definition for "period" to glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50020 from rkachach/fix_issue_58660
Adam King [Fri, 17 Feb 2023 18:10:28 +0000 (13:10 -0500)]
Merge pull request #50020 from rkachach/fix_issue_58660

mgr/rgw: fix module crash because of typing_extensions missing

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #49728 from rkachach/fix_issue_58241
Adam King [Fri, 17 Feb 2023 18:07:21 +0000 (13:07 -0500)]
Merge pull request #49728 from rkachach/fix_issue_58241

cephadm: Adding poststop actions and setting TimeoutStartSec to 200s

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agoMerge pull request #49754 from adk3798/ha-nfs-active-failover
Adam King [Fri, 17 Feb 2023 18:02:08 +0000 (13:02 -0500)]
Merge pull request #49754 from adk3798/ha-nfs-active-failover

mgr/cephadm: fix backends service in haproxy config with multiple nfs of same rank

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #48973 from trociny/wip-58051
Adam King [Fri, 17 Feb 2023 17:47:59 +0000 (12:47 -0500)]
Merge pull request #48973 from trociny/wip-58051

mgr/cephadm: try to avoid pull when getting container image info

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agoMerge pull request #50016 from max-licc/nobjects_begin_crash
J. Eric Ivancich [Fri, 17 Feb 2023 17:40:00 +0000 (12:40 -0500)]
Merge pull request #50016 from max-licc/nobjects_begin_crash

rgw: catches nobjects_begin() exceptions

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #50041 from cbodley/wip-cls-rgw-cancel-deleted
J. Eric Ivancich [Fri, 17 Feb 2023 17:26:47 +0000 (12:26 -0500)]
Merge pull request #50041 from cbodley/wip-cls-rgw-cancel-deleted

cls/rgw: remove index entry after cancelling last racing delete op

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>
2 years agoMerge pull request #50059 from cbodley/wip-rgw-stream-errors
J. Eric Ivancich [Fri, 17 Feb 2023 17:25:41 +0000 (12:25 -0500)]
Merge pull request #50059 from cbodley/wip-rgw-stream-errors

rgw/beast: StreamIO remembers connection errors for graceful shutdown

Reviewed-by: Yixin Jin <yjin77@yahoo.ca>
2 years agoMerge pull request #50131 from yima77/rgw_fix_segfault_due_to_concurrent_socket_use_a...
J. Eric Ivancich [Fri, 17 Feb 2023 17:21:48 +0000 (12:21 -0500)]
Merge pull request #50131 from yima77/rgw_fix_segfault_due_to_concurrent_socket_use_at_timeout

rgw: Fix segfault due to concurrent socket use at timeout

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #50143 from ivancich/wip-flight-getobj-fix
J. Eric Ivancich [Fri, 17 Feb 2023 17:21:19 +0000 (12:21 -0500)]
Merge pull request #50143 from ivancich/wip-flight-getobj-fix

rgw/flight: don't access non-existant flight store during GetObj

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #50096 from nbalacha/syncpercent-fix
Ilya Dryomov [Fri, 17 Feb 2023 17:11:03 +0000 (18:11 +0100)]
Merge pull request #50096 from nbalacha/syncpercent-fix

rbd-mirror: fix syncing_percent calculation logic in get_replay_status()

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #49614 from isodude/wip-librbd-misalign-discard
Ilya Dryomov [Fri, 17 Feb 2023 17:09:39 +0000 (18:09 +0100)]
Merge pull request #49614 from isodude/wip-librbd-misalign-discard

librbd: Fix local rbd mirror journals growing forever

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agomgr/cephadm: fix error_ok not being passed in unit tests 48973/head
Adam King [Sun, 22 Jan 2023 16:52:10 +0000 (11:52 -0500)]
mgr/cephadm: fix error_ok not being passed in unit tests

Signed-off-by: Adam King <adking@redhat.com>
2 years agomgr/cephadm: try to avoid pull when getting container image info
Mykola Golub [Sun, 20 Nov 2022 13:11:11 +0000 (13:11 +0000)]
mgr/cephadm: try to avoid pull when getting container image info

Fixes: https://tracker.ceph.com/issues/58051
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
2 years agomgr/cephadm: allow _run_cephadm_json to be silent on error
Mykola Golub [Sat, 26 Nov 2022 08:39:54 +0000 (08:39 +0000)]
mgr/cephadm: allow _run_cephadm_json to be silent on error

Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
2 years agoMerge pull request #49866 from rkachach/fix_issue_58466
Adam King [Fri, 17 Feb 2023 15:32:06 +0000 (10:32 -0500)]
Merge pull request #49866 from rkachach/fix_issue_58466

cephadm: using short hostname to create the initial mon and mgr

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #49961 from stefan-chivu/test_rbd_wnbd_latency
Lucian Petrut [Fri, 17 Feb 2023 10:11:15 +0000 (12:11 +0200)]
Merge pull request #49961 from stefan-chivu/test_rbd_wnbd_latency

qa: Added latency to results table in test_rbd_wnbd.py

2 years agoqa/rgw: add tox task before ragweed 49950/head
Casey Bodley [Tue, 31 Jan 2023 18:09:36 +0000 (13:09 -0500)]
qa/rgw: add tox task before ragweed

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoqa/ragweed: run ragweed tests with tox
Casey Bodley [Tue, 31 Jan 2023 18:07:34 +0000 (13:07 -0500)]
qa/ragweed: run ragweed tests with tox

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49709 from yima77/rgw_fix_mp_upload_obj_leak_due_to_reupload
Casey Bodley [Thu, 16 Feb 2023 17:22:41 +0000 (12:22 -0500)]
Merge pull request #49709 from yima77/rgw_fix_mp_upload_obj_leak_due_to_reupload

rgw: fix multipart upload object leaks due to re-upload

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agorgw/flight: don't access non-existant flight store during GetObj 50143/head
J. Eric Ivancich [Thu, 16 Feb 2023 15:29:31 +0000 (10:29 -0500)]
rgw/flight: don't access non-existant flight store during GetObj

The front end must be configured via ceph.conf to start up both the
flight_server and the flight_store. RGWGetObj needs to check for the
existence of a flight_store prior to trying to use it.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agoquincy: qa: update test_rbd_wnbd.py to report latency in seconds 49961/head
Lucian Petrut [Tue, 7 Feb 2023 13:13:54 +0000 (15:13 +0200)]
quincy: qa: update test_rbd_wnbd.py to report latency in seconds

At the moment, the latency results are reported in nanoseconds.
In order to improve readability, we'll convert it to seconds.

While at it, we'll fix the fio duration report, which we're
wrongfully dividing by 1000 twice.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoqa: Added latency to results table in test_rbd_wnbd.py
Stefan Chivu [Wed, 1 Feb 2023 15:38:52 +0000 (15:38 +0000)]
qa: Added latency to results table in test_rbd_wnbd.py

Added data regarding completion latency (ns) to the fio results
table, such as min, max, mean, stddev, etc.

Signed-off-by: Stefan Chivu <schivu@cloudbasesolutions.com>
2 years agoqa/workunits/rbd-nbd: work around "rbd feature disable" hang 49614/head
Ilya Dryomov [Thu, 16 Feb 2023 11:53:02 +0000 (12:53 +0100)]
qa/workunits/rbd-nbd: work around "rbd feature disable" hang

"rbd feature disable" appears to reliably hang if the corresponding
remote request is proxied to rbd-nbd (because rbd-nbd happens to own
the exclusive lock after a series of blkdiscard calls) [1].  Work
around it here by enabling journaling before the image is mapped
and disabling it after the image is unmapped.

Also, don't assert on the output of "rbd journal inspect --verbose"
having a certain number of entries.  This is racy: if the script gets
delayed after the last blkdiscard call for some reason, there may be
fewer entries present in the journal or none at all.

[1] https://tracker.ceph.com/issues/58740

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agotest/librbd: add LengthModifiedDiscardJournalAppendEnabled test
Ilya Dryomov [Thu, 16 Feb 2023 11:51:04 +0000 (12:51 +0100)]
test/librbd: add LengthModifiedDiscardJournalAppendEnabled test

Currently nothing triggers the length_modified case in
ImageDiscardRequest::prune_object_extents() in isolation. It's only
triggered in DiscardGranularityJournalAppendEnabled test together with
the prune_required case and a bad refactoring could easily break the
length_modified logic again.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50109 from rhcs-dashboard/landing-page-v3
Nizamudeen A [Thu, 16 Feb 2023 10:51:12 +0000 (16:21 +0530)]
Merge pull request #50109 from rhcs-dashboard/landing-page-v3

mgr/dashboard: Landing page v3

Reviewed-by: bryanmontalvan <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoqa: add tests for cephfs-top 49154/head
Jos Collin [Wed, 1 Feb 2023 12:14:47 +0000 (17:44 +0530)]
qa: add tests for cephfs-top

* Updated the existing tests
* Added new qa tests for --dump and --dumpfs options
* Updated the cluster configuration to 2 mds, 2 clients

Fixes: https://tracker.ceph.com/issues/57014
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agodoc: updates --dump and --dumpfs
Jos Collin [Wed, 30 Nov 2022 09:20:28 +0000 (14:50 +0530)]
doc: updates --dump and --dumpfs

Fixes: https://tracker.ceph.com/issues/57014
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agocephfs-top: dump values to stdout
Jos Collin [Mon, 21 Nov 2022 09:35:01 +0000 (15:05 +0530)]
cephfs-top: dump values to stdout

Fixes: https://tracker.ceph.com/issues/57014
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #50114 from rhcs-dashboard/cephadm-prom-401-error
Nizamudeen A [Thu, 16 Feb 2023 06:50:51 +0000 (12:20 +0530)]
Merge pull request #50114 from rhcs-dashboard/cephadm-prom-401-error

mgr/dashboard: ignore the rules 400 error in dashboard kcli e2e

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agorbd-mirror: fix syncing_percent calculation logic in get_replay_status() 50096/head
N Balachandran [Thu, 16 Feb 2023 04:57:02 +0000 (10:27 +0530)]
rbd-mirror: fix syncing_percent calculation logic in get_replay_status()

When a snapshot sync is resumed and the get_replay_status function
is called before handle_copy_image_progress, the syncing_percent
value may be greater than 100 as the m_local_object_count is still
set to zero. This commit sets the syncing_percent to 0 in such cases.

Fixes: https://tracker.ceph.com/issues/58706
Signed-off-by: N Balachandran <nibalach@redhat.com>
2 years agoMerge pull request #50111 from rzarzynski/wip-crimson-osd-ftbfs-fmtptr
Yingxin [Thu, 16 Feb 2023 02:30:56 +0000 (10:30 +0800)]
Merge pull request #50111 from rzarzynski/wip-crimson-osd-ftbfs-fmtptr

crimson/osd: fix FTBFS due to smart-ptr-to-bool conversion in fmt::ptr

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #50138 from zdover23/wip-doc-2023-02-16-radosgw-realms-refinement
Anthony D'Atri [Thu, 16 Feb 2023 01:55:25 +0000 (20:55 -0500)]
Merge pull request #50138 from zdover23/wip-doc-2023-02-16-radosgw-realms-refinement

doc/rgw: refine "Realms" section

2 years agodoc/rgw: refine "Realms" section 50138/head
Zac Dover [Wed, 15 Feb 2023 23:56:53 +0000 (09:56 +1000)]
doc/rgw: refine "Realms" section

Make various syntactical and semantic improvements to "Realms" section.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50119 from zdover23/wip-doc-2023-02-15-multisite-zonegroup-spelli...
zdover23 [Wed, 15 Feb 2023 23:37:13 +0000 (09:37 +1000)]
Merge pull request #50119 from zdover23/wip-doc-2023-02-15-multisite-zonegroup-spelling-correction

doc/rgw: s/[Zz]one [Gg]roup/zonegroup/g

2 years agoMerge pull request #50017 from guits/fix-simple-scan-dir
Guillaume Abrioux [Wed, 15 Feb 2023 19:09:30 +0000 (20:09 +0100)]
Merge pull request #50017 from guits/fix-simple-scan-dir

ceph-volume: do not raise RuntimeError in util.lsblk

2 years agorgw: Fix segfault due to concurrent socket use at timeout 50131/head
Yixin Jin [Wed, 15 Feb 2023 17:08:19 +0000 (17:08 +0000)]
rgw: Fix segfault due to concurrent socket use at timeout

This commit fixes a potential segfault risk when
rgw timeout handler works on the socket in one
thread while it is concurrently used by another.
The details of the fix are:

1. Instead of calling socket close(), which resets
descriptor_data in boost::asio socket and risks
segfault due to concurrent use of the socket,
the timeout handler now calls cancel() to abort
all pending ops followed by shutdown() to disable
the underlying transport. The eventual closure of
the socket will be done in the socket destructor.

2. Expose the actual boost::asio socket via get_socket()
from Connection so that the timeout handler can call
cancel() and shutdown() on it, although the socket data
member is already accessible. It allows future expansion
that wants to hide the socket even though it renders the
existing close() less useful.

Fixes: https://tracker.ceph.com/issues/58670
Signed-off-by: Yixin Jin <yjin77@yahoo.ca>
2 years agoMerge pull request #50062 from phlogistonjohn/jjm-more-cephadm-tests
Adam King [Wed, 15 Feb 2023 16:04:38 +0000 (11:04 -0500)]
Merge pull request #50062 from phlogistonjohn/jjm-more-cephadm-tests

cephadm: a few more utility function tests

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #50084 from adk3798/cephadm-autopep8-error
Adam King [Wed, 15 Feb 2023 14:17:40 +0000 (09:17 -0500)]
Merge pull request #50084 from adk3798/cephadm-autopep8-error

cephadm: fix autopep8 arg parsing on newer tox versions

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge PR #48053 into main
Venky Shankar [Wed, 15 Feb 2023 13:28:29 +0000 (18:58 +0530)]
Merge PR #48053 into main

* refs/pull/48053/head:
test/libcephfs: fix rebasing issues
libcephfs: replace errno.h errors with CEPHFS_E*
messages: avoid converting ceph errors on Windows
client: use CEPHFS_E*
test/libcephfs: use CEPHFS_E* errors
libcephfs: switch to CEPHFS_E* errors
test/libcephfs: disable flaky timestamp assertion on Windows
client: use _setattrx when changing timestamps
client: set nsec to 0 when converting stat struct on Windows
test/libcephfs: skip dirent inode check on Windows
client: avoid trimming inodes on Windows
test/libcephfs: address windows issues
test/libcephfs: include compat.h
test/libcephfs: enable the tests on Windows

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 years agomgr/dashboard: dashboard-v3: cluster-utilization card 50109/head
Pedro Gonzalez Gomez [Tue, 11 Oct 2022 17:43:34 +0000 (19:43 +0200)]
mgr/dashboard: dashboard-v3: cluster-utilization card

mgr/dashboard: some improvements

mgr/dashboard: updated promqls and improved tooltips

mgr/dashboard: some fixes and improvements

mgr/dashboard: added square box plugin and improved/fixed code

mgr/dashboard: added maxValue option for graphs and added tooltips to text

mgr/dashboard: removed unnecessary variables

mgr/dashboard: fix openapi

tracker: https://tracker.ceph.com/issues/57863
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: dashboard-v3: inventory card
bryanmontalvan [Wed, 10 Aug 2022 18:22:02 +0000 (14:22 -0400)]
mgr/dashboard: dashboard-v3: inventory card

This commit starts the inventory-card which is one of the cards which
will be located in the landing-page revamp

tracker: https://tracker.ceph.com/issues/58065
Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: dashboard-v3: status card
bryanmontalvan [Wed, 3 Aug 2022 01:39:05 +0000 (21:39 -0400)]
mgr/dashboard: dashboard-v3: status card

This commit is the bare-bones work of the status card. The only logic
written in this commit is the Cluster health status icon.

tracker: https://tracker.ceph.com/issues/58728
Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
mgr/dashboard: introduce active alerts to status cards

Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoxmgr/dashboard: dashboard-v3: capacity card
Pedro Gonzalez Gomez [Mon, 1 Aug 2022 20:17:29 +0000 (22:17 +0200)]
xmgr/dashboard: dashboard-v3: capacity card

tracker: https://tracker.ceph.com/issues/57862
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: fix openapi tox error

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: capacity-card set interval and display bytes used

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: Landing Page v3

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: dashboard-v3: details card
Pedro Gonzalez Gomez [Mon, 25 Jul 2022 19:50:47 +0000 (21:50 +0200)]
mgr/dashboard: dashboard-v3: details card

mgr/dashboard: added interface, changed html table to list, using mgrModuleService now

tracker: https://tracker.ceph.com/issues/58731
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: dashboard-v3: landing-page revamp
bryanmontalvan [Thu, 7 Jul 2022 16:36:15 +0000 (12:36 -0400)]
mgr/dashboard: dashboard-v3: landing-page revamp

This commit add the following
- A new dashboard component, which will exist in parallel with in the
  current landing-page
- Created a route for this dashboard `/dashboard_3`
- Created a bare-bones bootstrap grid with mock-up card components

Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: changes to first layout

CHANGES:

 - Renamed dashboardcomponents

 - Removed unnecesary styling

 - Added unit tests

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Moved router.url logic inside html template

This commit removes the `this.router.url` logic which was located in the
`workbench-layout.component.ts` file and moved it into the HTML template
section.

Signed-off-by: bryanmontalvan <bmontalv@redhat.com>
mgr/dashboard: syntax changes from bootstrap 4 to 5

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: small fixes and improvements over all cards and layout

- all cards placed evenly with the same height
- increased font size on details card and adjusted margin
- changed capacity card legend to: "Used"
- adjusted cluster utilization card margins and increased graphs height
- improved status card toggle
- changed orchestror to orchestrator
- switched IPS/OPS graph colors

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
mgr/dashboard: added recovery throghput graph, improve promqls, fix inventory's card lines

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #44749 from ronen-fr/wip-rf-large-chunk
Ronen Friedman [Wed, 15 Feb 2023 10:06:58 +0000 (12:06 +0200)]
Merge pull request #44749 from ronen-fr/wip-rf-large-chunk

osd/scrub: use separate chunk size configuration for shallow scrubs

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
2 years agoMerge pull request #50120 from zdover23/wip-doc-2023-02-15-glossary-realm
Anthony D'Atri [Wed, 15 Feb 2023 09:56:35 +0000 (04:56 -0500)]
Merge pull request #50120 from zdover23/wip-doc-2023-02-15-glossary-realm

doc/glossary: add "realm" to glossary

2 years agodoc/glossary: add "realm" to glossary 50120/head
Zac Dover [Wed, 15 Feb 2023 07:51:41 +0000 (17:51 +1000)]
doc/glossary: add "realm" to glossary

Add the term "Realm" to the glossary, and link to the section in the RGW
documentation that provides more information about realms.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agomgr/dashboard: ignore the rules 400 error in dashboard kcli e2e 50114/head
Nizamudeen A [Tue, 14 Feb 2023 15:34:26 +0000 (21:04 +0530)]
mgr/dashboard: ignore the rules 400 error in dashboard kcli e2e

Fixes: https://tracker.ceph.com/issues/58722
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50057 from rhcs-dashboard/nfs-exports-return-fix
Nizamudeen A [Wed, 15 Feb 2023 06:38:01 +0000 (12:08 +0530)]
Merge pull request #50057 from rhcs-dashboard/nfs-exports-return-fix

mgr/dashboard: adapt nfs export code to the new changes in nfs module

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agodoc/rgw: s/[Zz]one [Gg]roup/zonegroup/g 50119/head
Zac Dover [Wed, 15 Feb 2023 05:05:43 +0000 (15:05 +1000)]
doc/rgw: s/[Zz]one [Gg]roup/zonegroup/g

Change all instances of "Zone Group" and "Zone group" and "zone group"
to "Zonegroup" or "zonegroup".

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50108 from zdover23/wip-doc-2023-02-13-multisite-multisite-config...
zdover23 [Wed, 15 Feb 2023 04:39:36 +0000 (14:39 +1000)]
Merge pull request #50108 from zdover23/wip-doc-2023-02-13-multisite-multisite-config-reference

doc/rgw: refine "Multi-site Config Ref" (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50019 from rzarzynski/wip-crimson-fix-zeroed-startevent
Samuel Just [Wed, 15 Feb 2023 03:57:02 +0000 (19:57 -0800)]
Merge pull request #50019 from rzarzynski/wip-crimson-fix-zeroed-startevent

crimson/osd: fix zeroed starting timestamp of tracked ops

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49420 from cyx1231st/wip-seastar-msgr-multi-core
Yingxin [Wed, 15 Feb 2023 01:13:06 +0000 (09:13 +0800)]
Merge pull request #49420 from cyx1231st/wip-seastar-msgr-multi-core

crimson/net: refactors to encapsulate ProtocolV2 message read and write paths and event dispatching

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agodoc/rgw: refine "Multi-site Config Ref" (1 of x) 50108/head
Zac Dover [Tue, 14 Feb 2023 11:53:02 +0000 (21:53 +1000)]
doc/rgw: refine "Multi-site Config Ref" (1 of x)

Refine the syntax (and in some cases, the semantics) of the English in
"Multi-site Configuration Reference" in doc/radosgw/multisite.rst. This
is a long section, so more PRs are likely.

https://tracker.ceph.com/issues/58632

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #47555 from JoshSalomon/wip-prim-balance-score
Laura Flores [Tue, 14 Feb 2023 21:39:09 +0000 (15:39 -0600)]
Merge pull request #47555 from JoshSalomon/wip-prim-balance-score

mon, osd: Adding read (aka workload, primary) balance score

2 years agocephadm/tests: add test coverage of get_distro function 50062/head
John Mulligan [Thu, 9 Feb 2023 21:37:36 +0000 (16:37 -0500)]
cephadm/tests: add test coverage of get_distro function

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agocephadm/tests: add test coverage of check_time_sync function
John Mulligan [Thu, 9 Feb 2023 21:17:29 +0000 (16:17 -0500)]
cephadm/tests: add test coverage of check_time_sync function

This is also effectively full coverage of `check_units` as well
as check_time_sync is the only consumer.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #50104 from cityofships/fix_docs_lvm_activate
Anthony D'Atri [Tue, 14 Feb 2023 14:39:12 +0000 (09:39 -0500)]
Merge pull request #50104 from cityofships/fix_docs_lvm_activate

doc/ceph-volume: fix cephadm references

2 years agocrimson/osd: fix FTBFS due to smart-ptr-to-bool conversion in fmt::ptr 50111/head
Radoslaw Zarzynski [Tue, 14 Feb 2023 14:37:30 +0000 (14:37 +0000)]
crimson/osd: fix FTBFS due to smart-ptr-to-bool conversion in fmt::ptr

```
../src/fmt/include/fmt/format.h: In instantiation of ‘const void* fmt::v9::ptr(T) [with T = seastar::shared_ptr<crimson::net::SocketConnection>]’:
../src/crimson/net/ProtocolV2.cc:1109:72:   required from here
../src/fmt/include/fmt/format.h:3809:37: error: static assertion failed
 3809 |   static_assert(std::is_pointer<T>::value, "");
      |                                     ^~~~~
../src/fmt/include/fmt/format.h:3809:37: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #50102 from cbodley/wip-github-examples-rgw
Casey Bodley [Tue, 14 Feb 2023 14:11:42 +0000 (09:11 -0500)]
Merge pull request #50102 from cbodley/wip-github-examples-rgw

examples: move rgw examples under subdirectory

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #50099 from kalebskeithley/rgw_token.gcc13
kalebskeithley [Tue, 14 Feb 2023 12:56:26 +0000 (07:56 -0500)]
Merge pull request #50099 from kalebskeithley/rgw_token.gcc13

rgw: rgw_token.cc error: reference to 'formatter' is ambiguous

2 years agoMerge pull request #49801 from rhcs-dashboard/service-instances-flickering
Nizamudeen A [Tue, 14 Feb 2023 12:44:42 +0000 (18:14 +0530)]
Merge pull request #49801 from rhcs-dashboard/service-instances-flickering

mgr/dashboard: move service_instances logic to backend

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
2 years agodoc/rgw: update links to examples/rgw 50102/head
Casey Bodley [Mon, 13 Feb 2023 22:18:49 +0000 (17:18 -0500)]
doc/rgw: update links to examples/rgw

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49834 from rhcs-dashboard/rgw-list-roles
Nizamudeen A [Tue, 14 Feb 2023 12:33:28 +0000 (18:03 +0530)]
Merge pull request #49834 from rhcs-dashboard/rgw-list-roles

mgr/dashboard: rgw role listing

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: adapt nfs export code to the new changes in nfs module 50057/head
Nizamudeen A [Thu, 9 Feb 2023 15:59:41 +0000 (21:29 +0530)]
mgr/dashboard: adapt nfs export code to the new changes in nfs module

when you create/edit an nfs export from dashboard it leaves this traceback and error

```
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard ERROR taskexec] Error while calling Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
                                             Traceback (most recent call last):
                                               File "/usr/share/ceph/mgr/dashboard/tools.py", line 550, in _run
                                                 val = self.task.fn(*self.task.fn_args, **self.task.fn_kwargs)  # type: ignore
                                               File "/usr/share/ceph/mgr/dashboard/controllers/nfs.py", line 148, in create
                                                 ret, _, err = export_mgr.apply_export(cluster_id, json.dumps(raw_ex))
                                             TypeError: 'AppliedExportResults' object is not iterable
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO taskmgr] finished Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO request] [::ffff:192.168.100.1:43896] [POST] [500] [0.767s] [admin] [172.0B] /api/nfs-ganesha/export
```
This started after https://github.com/ceph/ceph/pull/46209, so dashboard code needs to be adapted

Fixes: https://tracker.ceph.com/issues/58681
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: move service_instances logic to backend 49801/head
Nizamudeen A [Fri, 20 Jan 2023 10:28:12 +0000 (15:58 +0530)]
mgr/dashboard: move service_instances logic to backend

Fixes: https://tracker.ceph.com/issues/58504
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoosd, mon: add read balance score to command `ceph osd pool ls detail` 47555/head
Josh Salomon [Mon, 18 Apr 2022 08:37:13 +0000 (11:37 +0300)]
osd, mon: add read balance score to command `ceph osd pool ls detail`
for replicated pools.

osd: Added workload balance score to the command
     ceph osd pool ls detail
     (different flavors for console output and json/xml output)
mon: Added command 'osd rm-primary-temp'
(developers only) rm was not working
vstart: Added osd debug messages into mon log with -d flag
        For commands that execute methonds in OSD module

Signed-off-by: Josh Salomon <jsalomon@redhat.com>
2 years agoMerge pull request #50051 from rhcs-dashboard/rbd-mirroring-status-fix
Nizamudeen A [Tue, 14 Feb 2023 10:24:54 +0000 (15:54 +0530)]
Merge pull request #50051 from rhcs-dashboard/rbd-mirroring-status-fix

mgr/dashboard: fix rbd mirroring daemon health status

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>