]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agocrimson/osd/heartbeat: add latest epoch sent concept 50227/head
Matan Breizman [Wed, 29 Mar 2023 16:42:09 +0000 (16:42 +0000)]
crimson/osd/heartbeat: add latest epoch sent concept

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/shard_services: Add logs to load_map_bls
Matan Breizman [Wed, 29 Mar 2023 09:21:12 +0000 (09:21 +0000)]
crimson/osd/shard_services: Add logs to load_map_bls

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/heartbeat: add a rename todo
Matan Breizman [Thu, 27 Apr 2023 16:07:01 +0000 (16:07 +0000)]
crimson/osd/heartbeat: add a rename todo

In continuation to: bfbbc311f1f

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/heartbeat: Rename Peer's created at epoch
Matan Breizman [Wed, 29 Mar 2023 09:19:29 +0000 (09:19 +0000)]
crimson/osd/heartbeat: Rename Peer's created at epoch

As these getter and setter represent the epoch at which the peer was added

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/heartbeat: share osdmap to peers when necessary
Xuehan Xu [Thu, 23 Feb 2023 06:50:56 +0000 (06:50 +0000)]
crimson/osd/heartbeat: share osdmap to peers when necessary

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #51175 from zdover23/wip-doc-2023-04-21-main-page-docs-link
Anthony D'Atri [Sat, 22 Apr 2023 11:24:38 +0000 (13:24 +0200)]
Merge pull request #51175 from zdover23/wip-doc-2023-04-21-main-page-docs-link

doc: add link to "documenting ceph" to index.rst

2 years agodoc: add link to "documenting ceph" to index.rst 51175/head
Zac Dover [Fri, 21 Apr 2023 20:59:04 +0000 (22:59 +0200)]
doc: add link to "documenting ceph" to index.rst

Add a link to the landing page of docs.ceph.com to direct documentation
contributors to documentation-related information.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50324 from pkalever/scrub_incomplete
Ilya Dryomov [Fri, 21 Apr 2023 16:00:55 +0000 (18:00 +0200)]
Merge pull request #50324 from pkalever/scrub_incomplete

librbd: remove previous incomplete primary snapshot after successfully creating a new one

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #48717 from liu-chunmei/multicore-seastore
Samuel Just [Thu, 20 Apr 2023 22:55:11 +0000 (15:55 -0700)]
Merge pull request #48717 from liu-chunmei/multicore-seastore

crimson/os: support multicore seastore

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/os: make ZNS support shard metadata 48717/head
chunmei-liu [Tue, 22 Nov 2022 16:59:56 +0000 (08:59 -0800)]
crimson/os: make ZNS support shard metadata

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2 years agocrimson/os: fix formatter build error
chunmei [Thu, 6 Apr 2023 07:19:40 +0000 (07:19 +0000)]
crimson/os: fix formatter build error

Signed-off-by: chunmei <chunmei.liu@intel.com>
2 years agocrimson/os: fix unittest error for multicore seastore
chunmei [Fri, 17 Mar 2023 05:56:44 +0000 (05:56 +0000)]
crimson/os: fix unittest error for multicore seastore

Signed-off-by: chunmei <chunmei.liu@intel.com>
2 years agocrimson/os: static assign segments to each shard
chunmei [Tue, 4 Apr 2023 07:37:16 +0000 (07:37 +0000)]
crimson/os: static assign segments to each shard

and make device sharded

Signed-off-by: chunmei <chunmei.liu@intel.com>
2 years agocirmson/os: seperate futurizedStore interface
chunmei [Fri, 3 Mar 2023 04:19:21 +0000 (04:19 +0000)]
cirmson/os: seperate futurizedStore interface

into futurizedStore and futurizedShardStore
and modification the other parts in osd and objectstore

Signed-off-by: chunmei <chunmei.liu@intel.com>
2 years agocrimson/seastore: fix heap-used-after-free bug
chunmei [Tue, 18 Apr 2023 09:33:52 +0000 (09:33 +0000)]
crimson/seastore: fix heap-used-after-free bug

Signed-off-by: chunmei <chunmei.liu@intel.com>
2 years agoMerge pull request #51153 from rhcs-dashboard/applitools-fix
Nizamudeen A [Thu, 20 Apr 2023 17:37:48 +0000 (23:07 +0530)]
Merge pull request #51153 from rhcs-dashboard/applitools-fix

mgr/dashboard: ignore Details card in applitools vrt

Reviewed-by: Pegonzal <NOT@FOUND>
2 years agoMerge pull request #51163 from rhcs-dashboard/hide-rbd-force-promote-notification
Nizamudeen A [Thu, 20 Apr 2023 17:35:45 +0000 (23:05 +0530)]
Merge pull request #51163 from rhcs-dashboard/hide-rbd-force-promote-notification

mgr/dashboard: hide notification on force promote

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50835 from cyx1231st/wip-seastar-adjust-conn-ref
Samuel Just [Thu, 20 Apr 2023 16:09:39 +0000 (09:09 -0700)]
Merge pull request #50835 from cyx1231st/wip-seastar-adjust-conn-ref

crimson/net: change ConnectionRef to be a local_shared_foreign_ptr

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agomgr/dashboard: hide notification on force promote 51163/head
Pedro Gonzalez Gomez [Thu, 20 Apr 2023 15:29:57 +0000 (17:29 +0200)]
mgr/dashboard: hide notification on force promote

Fixes: https://tracker.ceph.com/issues/59500
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #51127 from rishabh-d-dave/fs-qa-caps_helper-bug
Rishabh Dave [Thu, 20 Apr 2023 13:57:19 +0000 (19:27 +0530)]
Merge pull request #51127 from rishabh-d-dave/fs-qa-caps_helper-bug

qa/cephfs/caps_helper: fix a bug in methods that generate cap string

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #50882 from rishabh-d-dave/fs-qa-CapTester
Rishabh Dave [Thu, 20 Apr 2023 13:57:02 +0000 (19:27 +0530)]
Merge pull request #50882 from rishabh-d-dave/fs-qa-CapTester

qa/cephfs: improvements in caps_helper

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51159 from idryomov/wip-rbd-man-filestore
Ilya Dryomov [Thu, 20 Apr 2023 10:43:57 +0000 (12:43 +0200)]
Merge pull request #51159 from idryomov/wip-rbd-man-filestore

doc/man/rbd: resurrect filestore alloc_size note

Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2 years agodoc/man/rbd: resurrect filestore alloc_size note 51159/head
Ilya Dryomov [Thu, 20 Apr 2023 10:05:14 +0000 (12:05 +0200)]
doc/man/rbd: resurrect filestore alloc_size note

Mistakenly removed in commit d79f2a81541c ("docs: warning and remove
few docs section for Filestore Update docs after filestore removal.").
The kernel client, however new, will continue to be able to talk to
FileStore OSDs for as long as they exist.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50580 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard...
Nizamudeen A [Thu, 20 Apr 2023 10:07:28 +0000 (15:37 +0530)]
Merge pull request #50580 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-webpack-and-angular-devkit-build-angular-5.76.1

mgr/dashboard: bump webpack and @angular-devkit/build-angular in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: ignore Details card in applitools vrt 51153/head
Nizamudeen A [Thu, 20 Apr 2023 07:35:46 +0000 (13:05 +0530)]
mgr/dashboard: ignore Details card in applitools vrt

because the details card includes the FSID and Ceph Version which can
change on different clusters.

also don't run the 800x600 resolution because for new dashboard it looks
really weird.

Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51140 from zdover23/wip-doc-2023-04-18-rados-operations-2-of-x
zdover23 [Thu, 20 Apr 2023 06:18:04 +0000 (08:18 +0200)]
Merge pull request #51140 from zdover23/wip-doc-2023-04-18-rados-operations-2-of-x

doc/rados: edit user-management (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit user-management (2 of x) 51140/head
Zac Dover [Tue, 18 Apr 2023 20:59:09 +0000 (22:59 +0200)]
doc/rados: edit user-management (2 of x)

Line-edit doc/rados/user-management.rst (2 of x). Some internal
references had to be removed, but these will be repaired when the next
part of this file is updated in a future PR.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51143 from NitzanMordhai/wip-nitzan-filestore-removal-docs-update
zdover23 [Thu, 20 Apr 2023 05:42:58 +0000 (07:42 +0200)]
Merge pull request #51143 from NitzanMordhai/wip-nitzan-filestore-removal-docs-update

docs: warning and remove few docs section for Filestore

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodocs: warning and remove few docs section for Filestore 51143/head
Nitzan Mordechai [Sun, 19 Feb 2023 11:33:51 +0000 (11:33 +0000)]
docs: warning and remove few docs section for Filestore
Update docs after filestore removal.

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
2 years agoMerge pull request #51068 from cbodley/wip-59269
Casey Bodley [Wed, 19 Apr 2023 16:43:53 +0000 (12:43 -0400)]
Merge pull request #51068 from cbodley/wip-59269

cmake/rgw: librgw tests depend on ALLOC_LIBS

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #51031 from cbodley/wip-59423
Casey Bodley [Wed, 19 Apr 2023 15:36:15 +0000 (11:36 -0400)]
Merge pull request #51031 from cbodley/wip-59423

rgw/aio: fix recursion from tracing changes

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #50975 from yuvalif/wip-yuval-fix-59381
Yuval Lifshitz [Wed, 19 Apr 2023 13:30:29 +0000 (16:30 +0300)]
Merge pull request #50975 from yuvalif/wip-yuval-fix-59381

rgw/lua: fix CopyFrom crash

2 years agoMerge pull request #50965 from yuvalif/wip-yuval-fix-59383
Yuval Lifshitz [Wed, 19 Apr 2023 13:29:50 +0000 (16:29 +0300)]
Merge pull request #50965 from yuvalif/wip-yuval-fix-59383

rgw/kafka: failed to reconnect to broker after idle timeout

2 years agolibrbd: always refresh after creating snapshot in CreatePrimaryRequest 50324/head
Ilya Dryomov [Mon, 17 Apr 2023 21:31:37 +0000 (23:31 +0200)]
librbd: always refresh after creating snapshot in CreatePrimaryRequest

Up until now this was conditioned on whether the caller expressed
interest in the ID of the created snapshot and happened to work only
because CreatePrimaryRequest wasn't actually consulting any mirror
snapshot metadata.  This has just changed with unlink_peer() needing to
see an up-to-date complete flag which is set in SetImageStateRequest
following the write out of image state object(s).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50918 from rhcs-dashboard/delete-ceph-authx
Nizamudeen A [Wed, 19 Apr 2023 07:40:57 +0000 (13:10 +0530)]
Merge pull request #50918 from rhcs-dashboard/delete-ceph-authx

mgr/dashboard: delete-ceph-authx

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agolibrbd: remove previous incomplete primary snapshot after successfully creating a...
Prasanna Kumar Kalever [Mon, 6 Mar 2023 09:58:03 +0000 (15:28 +0530)]
librbd: remove previous incomplete primary snapshot after successfully creating a new one

Problem:
-------
At a high level, creating a primary snapshot consists of three steps:

1. actually creating a snapshot in the mirror namespace
2. generating a set of image state objects with additional metadata for
   the snapshot
3. marking the snapshot as complete after the image state objects are
   written out

Depending on the circumstances, a request to create a primary snapshot
can be forwarded to rbd-mirror daemon.  If that happens and rbd-mirror
daemon gets axed for some practical reason after completing steps (1)
and/or (2) but before completing step (3), we are left with a
permanently incomplete primary snapshot because upon retrying that
primary snapshot creation request, librbd notices that such snapshot
already exists.  It does not check whether this "pre-existing" snapshot
is complete.

Solution:
--------
As part of the next mirror snapshot create (say triggered by the
scheduler) the unlink_peer() is called, it checks if there exists any
incomplete snapshot and delete them accordingly.

Fixes: https://tracker.ceph.com/issues/58887
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2 years agoMerge PR #50089 into main
Venky Shankar [Wed, 19 Apr 2023 06:00:54 +0000 (11:30 +0530)]
Merge PR #50089 into main

* refs/pull/50089/head:
doc: add a note for minimum compatible python version and supported distros
tools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephfs-top

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoqa/cephfs/cap_tester: simplify CapTester and its instantiation 50882/head
Rishabh Dave [Tue, 18 Apr 2023 14:55:01 +0000 (20:25 +0530)]
qa/cephfs/cap_tester: simplify CapTester and its instantiation

Class CapTester contains two distinct immiscible group of methods: one
that tests MON caps and other that tests MDS caps. When using CapTester
for the former reason the instantiation neither needs mount object and
the path where files for testing will be created nor it needs to run the
method that creates files for testing rw permissions. When using
this class for latter the case is the exact opposite.

Create 2 separate classes for each of these purpose and class that
inherits both of these classes so that instantiating the class becomes
as simple as it can be.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoqa/cephfs: update method caps_helper.CapTester.run_cap_tests()
Rishabh Dave [Tue, 18 Apr 2023 07:15:03 +0000 (12:45 +0530)]
qa/cephfs: update method caps_helper.CapTester.run_cap_tests()

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoqa/cephfs: move few methods such that they can be reused
Rishabh Dave [Thu, 6 Apr 2023 09:42:14 +0000 (15:12 +0530)]
qa/cephfs: move few methods such that they can be reused

Move get_mon_cap_from_keyring() and get_fsnmes_from_moncap() from class
CapTester to main namespace of caps_helper.py so that they can be
imported freely and reused by tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoqa/cephfs: improve caps_helper.CapTester.run_mon_cap_tests()
Rishabh Dave [Thu, 6 Apr 2023 09:23:17 +0000 (14:53 +0530)]
qa/cephfs: improve caps_helper.CapTester.run_mon_cap_tests()

This method checks if the output of the command "ceph fs ls" for client
ID it receives is same as the output printed for client.admin. Don't do
so, limit the test to only checking if "ceph fs ls --id client.x -k
keyring_file" prints fs name for which client.x has permissions.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoqa/cephfs: improve caps_helper.CapTester
Rishabh Dave [Fri, 31 Mar 2023 19:14:52 +0000 (00:44 +0530)]
qa/cephfs: improve caps_helper.CapTester

Improvement #1:

CapTester.write_test_files() not only creates the test file but also
does the following for every mount object it receives in parameters -

* carefully produces the path for the test file as per parameters
  received
* generates the unique data for each test file on a CephFS mount
* creates a data structure -- list of lists -- that holds all this
  information along with mount object itself for each mount object so
  that tests can be conducted at a later point

Untangle this mess of code by splitting this method into 3 separate
methods -

1. To produce the path for test file (as per user's need).
2. To generate the data that will be written into the test file.
3. To actually create the test file on CephFS.

Improvement #2:

Remove the internal data structure used for testing -- self.test_set --
and use separate class attributes to store all the data required for
testing instead of a tuple. This serves two purpose -

One, it makes it easy to manipulate all this data from helper methods
and during debugging session, especially while using a PDB session.

And two, make it impossible to have multiple mounts/multiple "test sets"
within same CapTester instance for the sake of simplicity. Users can
instead create two instances of CapTester instances if needed.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoqa/cephfs: don't inherit CephFSTestCase in CapTester
Rishabh Dave [Thu, 13 Apr 2023 19:08:33 +0000 (00:38 +0530)]
qa/cephfs: don't inherit CephFSTestCase in CapTester

Inheritting CephFSTestCase in CapTester just for methods assertEqual()
and assertIn() from class unittest.TestCase is odd and heavy-weight.
Don't inherit CephFSTestCase and use simple assert instead.

Reference: https://github.com/ceph/ceph/pull/50882#discussion_r1160611549.

To avoid code duplication, a couple of similar methods have been added
instead.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge pull request #50916 from petrutlucian94/avoid_pip
Ilya Dryomov [Tue, 18 Apr 2023 11:49:41 +0000 (13:49 +0200)]
Merge pull request #50916 from petrutlucian94/avoid_pip

win32_deps_build: avoid pip

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agodoc: add a note for minimum compatible python version and supported distros 50089/head
Jos Collin [Thu, 23 Feb 2023 10:03:59 +0000 (15:33 +0530)]
doc: add a note for minimum compatible python version and supported distros

Fixes: https://tracker.ceph.com/issues/58677
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agotools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephf...
Jos Collin [Wed, 22 Feb 2023 12:24:22 +0000 (17:54 +0530)]
tools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephfs-top

Fixes: https://tracker.ceph.com/issues/58677
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoqa/cephfs/caps_helper: fix a bug in methods that generate cap string 51127/head
Rishabh Dave [Fri, 7 Apr 2023 15:13:46 +0000 (20:43 +0530)]
qa/cephfs/caps_helper: fix a bug in methods that generate cap string

The tuple was not meant to be passed as a whole but its individual
members are to be passed as a list of positional arguments.

Introduced-by: 87025d15858aa88b22afa9702511ccc7120f8b0b
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agowin32_deps_build: avoid pip 50916/head
Lucian Petrut [Thu, 6 Apr 2023 11:05:47 +0000 (11:05 +0000)]
win32_deps_build: avoid pip

We're currently installing cython with pip when using Ubuntu
to cross compile Ceph for Windows. This can fail with recent
Python versions if attempting to use the global env:

  error: externally-managed-environment

  Ã— This environment is externally managed
  â•°â”€> To install Python packages system-wide, try apt install
      python3-xyz, where xyz is the package you are trying to
      install.

Cython isn't really needed by the Windows build so we can go
ahead and drop it. We were hoping to use the Python bindings
on Windows, however Python extensions can't be cross compiled.

We're no longer using pip either, so we're dropping the dependency.
g++ was getting installed as a pip dependency, so we'll have to
include that instead. Note that g++ is used when building the boost
b2 tool.

While at it, we'll also ensure that git is installed.

Fixes: https://tracker.ceph.com/issues/59354
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoMerge pull request #50639 from bitfehler/bitfehler/doc-pg-num
Anthony D'Atri [Mon, 17 Apr 2023 20:58:51 +0000 (22:58 +0200)]
Merge pull request #50639 from bitfehler/bitfehler/doc-pg-num

doc: account for PG autoscaling being the default

2 years agoMerge pull request #51043 from petrutlucian94/fix_jaeger_encoding
Ilya Dryomov [Mon, 17 Apr 2023 16:58:00 +0000 (18:58 +0200)]
Merge pull request #51043 from petrutlucian94/fix_jaeger_encoding

common/tracer: fix decoding when jaeger tracing is disabled

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #49762 from Svelar/vstart2
zdover23 [Mon, 17 Apr 2023 16:42:34 +0000 (18:42 +0200)]
Merge pull request #49762 from Svelar/vstart2

vstart: fix text format

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50820 from rhcs-dashboard/update-landing-page-e2e-tests
Nizamudeen A [Mon, 17 Apr 2023 13:37:44 +0000 (19:07 +0530)]
Merge pull request #50820 from rhcs-dashboard/update-landing-page-e2e-tests

mgr/dashboard: update landing page e2e tests

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51082 from rhcs-dashboard/skip-osds-conditionally-in-e2e
Nizamudeen A [Mon, 17 Apr 2023 13:35:59 +0000 (19:05 +0530)]
Merge pull request #51082 from rhcs-dashboard/skip-osds-conditionally-in-e2e

mgr/dashboard: skip Create OSDs step in Cluster expansion

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51115 from rhcs-dashboard/remove-hyperlink-mgr
Nizamudeen A [Mon, 17 Apr 2023 13:35:16 +0000 (19:05 +0530)]
Merge pull request #51115 from rhcs-dashboard/remove-hyperlink-mgr

mgr/dashboard: remove unncessary hyperlink in landing page

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51114 from colemitchell/wip-doc-2023-04-17-radosgw-s3select-forma...
zdover23 [Mon, 17 Apr 2023 10:07:57 +0000 (12:07 +0200)]
Merge pull request #51114 from colemitchell/wip-doc-2023-04-17-radosgw-s3select-formatting-1

doc/radosgw: format part of s3select

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/radosgw: format part of s3select 51114/head
Cole Mitchell [Mon, 17 Apr 2023 09:34:49 +0000 (05:34 -0400)]
doc/radosgw: format part of s3select

Partially format the 'Basic Workflow' section's introduction and 'Basic Functionalities' subsection in s3select. Nothing else is being fixed.

Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agomgr/dashboard: remove unncessary hyperlink in landing page 51115/head
Nizamudeen A [Mon, 17 Apr 2023 09:38:06 +0000 (15:08 +0530)]
mgr/dashboard: remove unncessary hyperlink in landing page

Fixes: https://tracker.ceph.com/issues/59462
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48869 from rhcs-dashboard/more-grafana-configs
Nizamudeen A [Mon, 17 Apr 2023 07:01:56 +0000 (12:31 +0530)]
Merge pull request #48869 from rhcs-dashboard/more-grafana-configs

mgr/dashboard: expose more grafana configs in service form

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agomgr/dashboard: update landing page e2e tests 50820/head
Pedro Gonzalez Gomez [Fri, 31 Mar 2023 17:51:16 +0000 (19:51 +0200)]
mgr/dashboard: update landing page e2e tests

ignore the region that can vary on different clusters like charts

fixes: https://tracker.ceph.com/issues/59142
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: skip Create OSDs step in Cluster expansion 51082/head
Nizamudeen A [Fri, 14 Apr 2023 19:33:11 +0000 (01:03 +0530)]
mgr/dashboard: skip Create OSDs step in Cluster expansion

Its to ensure OSDs are not deployed on all hosts because that would make
the host draining impossible

Fixes: https://tracker.ceph.com/issues/59457
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge PR #50941 into main
Patrick Donnelly [Sun, 16 Apr 2023 15:34:35 +0000 (11:34 -0400)]
Merge PR #50941 into main

* refs/pull/50941/head:
doc/foundation: Update Foundation members for April 2023

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #51103 from colemitchell/wip-doc-2023-04-16-radosgw-s3select-forma...
zdover23 [Sun, 16 Apr 2023 13:48:32 +0000 (15:48 +0200)]
Merge pull request #51103 from colemitchell/wip-doc-2023-04-16-radosgw-s3select-formatting-1

doc/radosgw: format part of s3select

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/radosgw: format part of s3select 51103/head
Cole Mitchell [Sun, 16 Apr 2023 13:13:56 +0000 (09:13 -0400)]
doc/radosgw: format part of s3select

Format the first section of s3select. Nothing else is being fixed.

Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agoMerge pull request #51099 from zdover23/wip-doc-2023-04-16-dev-cephfs-mirroring-creat...
Anthony D'Atri [Sun, 16 Apr 2023 12:39:53 +0000 (14:39 +0200)]
Merge pull request #51099 from zdover23/wip-doc-2023-04-16-dev-cephfs-mirroring-creating-users-command-formatting

doc/dev: format command in cephfs-mirroring

2 years agodoc/dev: format command in cephfs-mirroring 51099/head
Zac Dover [Sun, 16 Apr 2023 09:11:27 +0000 (11:11 +0200)]
doc/dev: format command in cephfs-mirroring

Correctly format a command in doc/dev/cephfs-mirroring/#creating-users.

Reported by casanlin@init7.net at
https://pad.ceph.com/p/Report_Documentation_Bugs

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51062 from zdover23/wip-doc-2023-04-13-glossary-hybrid-storage
zdover23 [Sun, 16 Apr 2023 06:58:41 +0000 (08:58 +0200)]
Merge pull request #51062 from zdover23/wip-doc-2023-04-13-glossary-hybrid-storage

doc/glossary: add "Hybrid Storage"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary: add "Hybrid Storage" 51062/head
Zac Dover [Thu, 13 Apr 2023 12:01:44 +0000 (14:01 +0200)]
doc/glossary: add "Hybrid Storage"

Add "Hybrid Storage" to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51091 from cityofships/fix_confval
Anthony D'Atri [Sat, 15 Apr 2023 22:03:37 +0000 (00:03 +0200)]
Merge pull request #51091 from cityofships/fix_confval

doc/mgr/prometheus: fix confval reference

2 years agodoc/mgr/prometheus: fix confval reference 51091/head
Piotr Parczewski [Sat, 15 Apr 2023 21:16:35 +0000 (23:16 +0200)]
doc/mgr/prometheus: fix confval reference

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
2 years agoMerge pull request #51086 from zdover23/wip-doc-2023-04-15-rados-ops-ceph-medic-removal
Anthony D'Atri [Sat, 15 Apr 2023 09:01:02 +0000 (05:01 -0400)]
Merge pull request #51086 from zdover23/wip-doc-2023-04-15-rados-ops-ceph-medic-removal

doc/rados/ops: remove ceph-medic from monitoring

2 years agodoc/rados/ops: remove ceph-medic from monitoring 51086/head
Zac Dover [Sat, 15 Apr 2023 07:42:31 +0000 (09:42 +0200)]
doc/rados/ops: remove ceph-medic from monitoring

Remove mention of ceph-medic from doc/rados/operations/monitoring.rst,
because it is no longer supported.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agomgr/dashboard: expose more grafana configs in service form 48869/head
Nizamudeen A [Mon, 14 Nov 2022 02:20:54 +0000 (07:50 +0530)]
mgr/dashboard: expose more grafana configs in service form

Show the grafana_port and initial_admin_password in the form but disable
the password field in the edit option

Fixes: https://tracker.ceph.com/issues/58016
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51074 from rhcs-dashboard/expression-changed-e2e
Nizamudeen A [Fri, 14 Apr 2023 18:27:11 +0000 (23:57 +0530)]
Merge pull request #51074 from rhcs-dashboard/expression-changed-e2e

mgr/dashboard: fix cephadm e2e expression changed error

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #51055 from ceph/wip-yuriw-release-16.2.12-main
Yuri Weinstein [Fri, 14 Apr 2023 16:23:26 +0000 (09:23 -0700)]
Merge pull request #51055 from ceph/wip-yuriw-release-16.2.12-main

doc: 16.2.12 Release Notes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Adam King adking@redhat.com
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge PR #50909 into main
Venky Shankar [Fri, 14 Apr 2023 10:29:12 +0000 (15:59 +0530)]
Merge PR #50909 into main

* refs/pull/50909/head:
qa/workunit: print the detail commands excuted in the scripts

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agomgr/dashboard: delete-ceph-authx 50918/head
Pedro Gonzalez Gomez [Thu, 6 Apr 2023 14:18:41 +0000 (16:18 +0200)]
mgr/dashboard: delete-ceph-authx

Fixes: https://tracker.ceph.com/issues/59365
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #49531 from rhcs-dashboard/fix-rbd-snapshot-creation
Nizamudeen A [Fri, 14 Apr 2023 06:36:05 +0000 (12:06 +0530)]
Merge pull request #49531 from rhcs-dashboard/fix-rbd-snapshot-creation

mgr/dashboard: Fix rbd snapshot creation

Reviewed-by: VasishtaShastry <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2 years agomgr/dashboard: fix cephadm e2e expression changed error 51074/head
Nizamudeen A [Fri, 14 Apr 2023 06:03:16 +0000 (11:33 +0530)]
mgr/dashboard: fix cephadm e2e expression changed error

tried to fix this issue from the daemon component sometime ago several
times but it didn't work. So force ignoring the error

Fixes: https://tracker.ceph.com/issues/59444
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agocrimson/osd: specialize messages to use the external connection 50835/head
Yingxin Cheng [Mon, 3 Apr 2023 08:39:52 +0000 (16:39 +0800)]
crimson/osd: specialize messages to use the external connection

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/net: change ConnectionRef to be a local_shared_foreign_ptr
Yingxin Cheng [Mon, 3 Apr 2023 02:00:11 +0000 (10:00 +0800)]
crimson/net: change ConnectionRef to be a local_shared_foreign_ptr

Make it possible for connections and messages to be dispatched in
arbitrary core without asynchronous foreign copy.

The local_shared_foreign_ptr conn cannot be moved to another core
implicitly, maintain it outside Message independently.

Do asynchronous foreign copy to the new ConnectionRef only in
with_remote_shard_state_and_op().

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/osd: drop unused methods in ClientRequest
Yingxin Cheng [Mon, 3 Apr 2023 01:54:49 +0000 (09:54 +0800)]
crimson/osd: drop unused methods in ClientRequest

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson/test_messenger_thrash: free msgr after its connections
Yingxin Cheng [Mon, 3 Apr 2023 01:51:02 +0000 (09:51 +0800)]
test/crimson/test_messenger_thrash: free msgr after its connections

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agocrimson/common: improve local_shared_foreign_ptr
Yingxin Cheng [Mon, 3 Apr 2023 01:48:38 +0000 (09:48 +0800)]
crimson/common: improve local_shared_foreign_ptr

Make ptr nullable and add necessary operators.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #50939 from pkalever/logging_improve
Ilya Dryomov [Thu, 13 Apr 2023 18:21:27 +0000 (20:21 +0200)]
Merge pull request #50939 from pkalever/logging_improve

librbd: on notify_quiesce() show attempts in a better format

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agocmake/rgw: librgw tests depend on ALLOC_LIBS 51068/head
Casey Bodley [Thu, 13 Apr 2023 16:26:44 +0000 (09:26 -0700)]
cmake/rgw: librgw tests depend on ALLOC_LIBS

somehow this stops tcmalloc from crashing on ubuntu 20.04

Fixes: https://tracker.ceph.com/issues/59269
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agolibrbd: on notify_quiesce() show attempts in a better format 50939/head
Prasanna Kumar Kalever [Fri, 7 Apr 2023 16:00:54 +0000 (21:30 +0530)]
librbd: on notify_quiesce() show attempts in a better format

notify_quiesce() currently shows number of attempts in descending order,
this might be bit confusing to read.

Example: on the very first attempt,
2023-04-04T19:45:56.096+0530 7ff8ba7fc640 10 librbd::ImageWatcher:
  0x7ff898008b30 notify_quiesce: async_request_id=[4151,140705343226832,23] attempts=10

I initially misread the above means 10 attempts where done.

This commit tries to pick the format that is used by
ImageWatcher<I>::handle_payload() and ImageWatcher<I>::notify_async_progress()

Fixes: https://tracker.ceph.com/issues/59379
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2 years agocommon/tracer: fix decoding when jaeger tracing is disabled 51043/head
Lucian Petrut [Wed, 12 Apr 2023 09:39:52 +0000 (09:39 +0000)]
common/tracer: fix decoding when jaeger tracing is disabled

We aren't currently using jaeger tracing on Windows. The issue is
that Windows hosts (or any other host that doesn't use jaeger)
are experiencing message decoding failures after a recent change [1].

This change updates the tracer encoding so that messages from
non-jaeger hosts may be decoded by services that use jaeger.

[1] https://github.com/ceph/ceph/pull/47457

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoMerge pull request #51051 from idryomov/wip-59431
Ilya Dryomov [Thu, 13 Apr 2023 09:54:57 +0000 (11:54 +0200)]
Merge pull request #51051 from idryomov/wip-59431

qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #43546 from ifed01/wip-ifed-snapdiff3-good
Igor Fedotov [Thu, 13 Apr 2023 09:26:58 +0000 (12:26 +0300)]
Merge pull request #43546 from ifed01/wip-ifed-snapdiff3-good

cephfs: implement snapdiff

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agodoc: 16.2.12 Release Notes 51055/head
Yuri Weinstein [Wed, 12 Apr 2023 18:12:23 +0000 (11:12 -0700)]
doc: 16.2.12 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2 years agoMerge pull request #50877 from rhcs-dashboard/add-rbd-mirror-force-promote
Nizamudeen A [Wed, 12 Apr 2023 15:10:40 +0000 (20:40 +0530)]
Merge pull request #50877 from rhcs-dashboard/add-rbd-mirror-force-promote

mgr/dashboard: rbd-mirror force promotion

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50666 from athanatos/sjust/wip-scrub-interval-pr-49959-2
Ronen Friedman [Wed, 12 Apr 2023 14:37:31 +0000 (17:37 +0300)]
Merge pull request #50666 from athanatos/sjust/wip-scrub-interval-pr-49959-2

osd/scrubber: simplify scrub resource handling and interval changes

2 years agoMerge pull request #51008 from guits/cv-tests-fix-rpm-issue-main
Guillaume Abrioux [Wed, 12 Apr 2023 14:23:31 +0000 (16:23 +0200)]
Merge pull request #51008 from guits/cv-tests-fix-rpm-issue-main

ceph-volume/tests: fix an issue with rpm

2 years agoqa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu 51051/head
Ilya Dryomov [Tue, 11 Apr 2023 20:43:58 +0000 (22:43 +0200)]
qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

qemu-utils is usually pre-installed but, due to what appears to be
a Ubuntu packaging bug, it's not upgraded when qemu-block-extra is
installed:

  The following NEW packages will be installed:
    qemu-block-extra
  The following packages will be upgraded:
    qemu-system-common qemu-system-data qemu-system-gui qemu-system-x86

However, the version of the block driver must match exactly the version
of the qemu-img tool, so the above leads to:

  $ qemu-img convert -f qcow2 -O raw /home/ubuntu/cephtest/qemu/base.client.0.0.qcow2 rbd:rbd/client.0.0
  Failed to initialize module: /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
  Note: only modules from the same build can be loaded.
  qemu: module block-block-rbd not found, do you want to install qemu-block-extra package?
  qemu-img: Unknown protocol 'rbd'

Fixes: https://tracker.ceph.com/issues/59431
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50840 from zhscn/segment-nonce-collision
Yingxin [Wed, 12 Apr 2023 06:22:56 +0000 (14:22 +0800)]
Merge pull request #50840 from zhscn/segment-nonce-collision

crimson/os/seatore: avoid segment nonce collision

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agomgr/dashboard: fix rbd mirror snapshot creation 49531/head
Aashish Sharma [Wed, 21 Dec 2022 11:53:37 +0000 (17:23 +0530)]
mgr/dashboard: fix rbd mirror snapshot creation

There are two types of snapshots that can be created on a snapshot based mirroring image - Normal Snapshot(same as journal based snapshot) and Nirror Image Snapshot. Till now Dashboard allowed only Mirror image snapshot, this PR intends to enable both the types

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoqa/standalone/scrub/osd-scrub-dump.sh: drop unnecessary primary lookup 50666/head
Samuel Just [Mon, 20 Mar 2023 21:07:32 +0000 (21:07 +0000)]
qa/standalone/scrub/osd-scrub-dump.sh: drop unnecessary primary lookup

1e44d86b2 swapped this to a pg tell command which doesn't actually
need the primary specified.  Drop the now unnecessary lookup.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/: remove PL::reschedule_scrub, notify scrubber on config/pool change directly
Samuel Just [Wed, 8 Mar 2023 01:21:24 +0000 (17:21 -0800)]
osd/: remove PL::reschedule_scrub, notify scrubber on config/pool change directly

As with on_info_history_change(), we don't need to deal with scrub
scheduling during peering. Once we've gone active, the scrubber itself
would be the origin of any stat changes that could affect scrub
scheduling.  The other possible change vectors would be OSD config
changes or pool config changes.

PG::reschedule_scrub becomes PG::on_scrub_schedule_input_change.  Should
be called in all cases where an input to scrub scheduling changes.

OSD::resched_all_scrubs() calls PG::on_scrub_schedule_input_change
unconditionally
now to deal with changes to osd_scrub_(min|max)_interval.

PG::set_last_[deep_]scrub_stamp now invoke
PG::on_scrub_schedule_input_change directly.

PG::handle_activate_map() now calls PG::on_scrub_schedule_input_change
directly to deal with changes to scrub related pool options.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/: remove PeeringListener::on_info_history_change()
Samuel Just [Tue, 7 Mar 2023 23:09:22 +0000 (15:09 -0800)]
osd/: remove PeeringListener::on_info_history_change()

The only usage of this method was to notify scrub that the pg history
has been updated during split or peering.  That shouldn't be necessary.
Scrub does not schedule itself prior to activation, and we necessarily
must have an authoritative history by that point.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber: associate replica state with state machine states
Samuel Just [Thu, 23 Feb 2023 05:04:17 +0000 (21:04 -0800)]
osd/scrubber: associate replica state with state machine states

Moves responsibility for owning and resetting replica state to state
machine events.

Signed-off-by: Samuel Just <sjust@redhat.com>