doc/rados: edit operations/bs-migration (2 of x)

Disambiguate and improve the English language in
doc/rados/operations/bluestore-migration.rst up to but not including the
section called "Whole Host Replacement".

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ca803a24c64059023733e21d755edb9c6c973ecf)

Merge pull request #50583 from zdover23/wip-doc-2023-03-19-backport-50579-to-pacific

pacific: doc/rados: line edit mon-lookup-dns top matter

doc/rados: line edit mon-lookup-dns top matter

Improve the syntax of the top matter of
doc/rados/operations/mon-lookup-dns.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ed5919964bd914c118f556baf3c517e5e35df277)

Merge pull request #50567 from zdover23/wip-doc-2023-03-17-backport-50563-to-pacific

pacific: doc/rados: line-edit upmap.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

doc/rados: line-edit upmap.rst

Edit all of doc/rados/upmap.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a4a681846499c8d0041a6632e7e31fa83e22ed0e)

Merge pull request #50527 from epuertat/wip-59052-pacific

pacific: mgr/dashboard: force TLS 1.3

Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #47726 from neesingh-rh/wip-57201-pacific

pacific: mgr/snap_schedule: replace .snap with the client configured snap dir name

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49829 from ivancich/wip-58542-pacific

pacific: rgw: fix the problem of duplicate idx when bi list

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49669 from vshankar/wip-58349

pacific: mds: fix scan_stray_dir not reset next.frag on each run of stray inode

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49656 from dparmar18/wip-58254-pacific

pacific: mds/PurgeQueue: don't consider filer_max_purge_ops when _calculate_ops

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49538 from ifed01/wip-ifed-fix-xlock-pac

pacific: mds: do not acquire xlock in xlockdone state

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49458 from mchangir/wip-57761-pacific

pacific: qa: wait for scrub to finish

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49440 from neesingh-rh/wip-58250-pacific

pacific: mds: avoid ~mdsdir's scrubbing and reporting damage health status

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49303 from neesingh-rh/wip-57971-pacific

pacific: cephfs-top: addition of sort feature and limit option

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #50050 from mchangir/wip-58598-pacific

pacific: mon: disable snap id allocation for fsmap pools

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #50029 from joscollin/wip-58668-pacific

pacific: cephfs-top: drop curses.A_ITALIC

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #49966 from vshankar/tr-57728

pacific: pybind/mgr: check for empty metadata mgr_module:get_metadata()

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49956 from dparmar18/wip-58601-pacific

pacific: mds/Server: do not allow -ve reclaim flags to cause client eviction

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #49944 from lxbsz/wip-58603

pacific: ceph_fuse: retry the test_dentry_handling if fails

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #49941 from lxbsz/wip-58608

pacific: mds: fix and skip submitting invalid osd request

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #49671 from vshankar/wip-58346

pacific: mds: md_log_replay thread blocks waiting to be woken up

Reviewed-by: Xiubo Li <xiubli@redhat.com>

mgr/dashboard: force TLS 1.3

Fixes: https://tracker.ceph.com/issues/58942
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit cd8946631b222dfff1727083d75dfe2dd825d1a4)

Merge pull request #50243 from cbodley/wip-58767

pacific: cls/rgw: remove index entry after cancelling last racing delete op

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #50000 from smanjara/wip-57701-pacific

pacific: qa/suites/rgw: fix and update tempest and barbican tests

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49841 from k0ste/wip-58553-pacific

pacific: rgw/beast: fix interaction between keepalive and 100-continue

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49809 from votdev/issue_58470_empty_tags

pacific: rgw: an empty tagset is allowed by S3

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49682 from adamemerson/wip-58403-pacific

rgw: Backport of issue 57562 to Pacific

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #49095 from cfsnyder/wip-55228-pacific

pacific: rgw: adding BUCKET_REWRITE and OBJECT_REWRITE OPS to

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #50352 from ceph/wip-yuri-pacific-reef-pacific

qa/tests: added pacific client upgrade => reef

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #50478 from zdover23/wip-doc-2023-03-11-backport-50470-to-pacific

pacific: doc/index: remove "uniquely" from landing page

doc/index: remove "uniquely" from landing page

Change "Ceph uniquely delivers[...]" to "Ceph delivers[...]"

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6e5be7ad66aa76cb798c52c87e34f8fe079cda5c)

Merge pull request #50454 from zdover23/wip-doc-2023-03-09-backport-50439-to-pacific

pacific: doc/rados/operations: Improve wording, capitalization, formatting

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rados/operations: Improve wording, capitalization, formatting

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 5f2060c0829992b31a0d17e23d7b1d2fb2280ac0)

client: switch to old method to invalidate dcache if euid != 0

Force to use the old and slow method to invalidate the dcache
if the euid is non-root, or the remount may fail with return
code 1 or 32.

https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit b9b25a54414b60f5da841f3d16b2e267b670ec5b)

ceph_fuse: make it to force invalidating dentries when kernel >=3.18

The remount will fail randomly for unknown reasons. And in certain
circumstance we can reprodce this very easy, which will block our
testing. Make it posible to force to old method to invalidate the
dcache when the "client_try_dentry_invalidate" option is enabled
even kernel version >= 3.18.0

Fixes: https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit f9c78fe72f3d7c02e927f71e0fbd841605c42708)

ceph_fuse: retry the test_dentry_handling if fails

For some unknown reason the remount will fail, we need to retry it
for the test_dentry_handling.

Fixes: https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit f6a9bd6a69362527502eba4906e2605f3474007f)

client: rename mds_max_retries_on_remount_failure to client_

mds_max_retries_on_remount_failure option is used by Client.cc only.

Fixed: https://tracker.ceph.com/issues/56532
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit b9edab80f048fee09b82cdd4ec58fa37bd937ded)
Conflicts:
- The options are still old style in pacific

Merge pull request #50389 from zdover23/wip-doc-2023-03-06-backport-50386-to-pacific

pacific: doc/rgw - fix grammar in table in s3.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #50122 from rhcs-dashboard/wip-57513-pacific

pacific: mgr/dashboard: osd form preselect db/wal device filters

Reviewed-by: Pegonzal <NOT@FOUND>

Merge pull request #50436 from zdover23/wip-doc-2023-03-08-backport-49823-to-pacific

pacific: doc/install: refine index.rst

doc/install: refine index.rst

Refine English sentences in doc/install/index.rst. Remove adverbial
phrases of time that refer to Nautilus-era features as "new", since that
was four years ago.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit e7669539aceffc0f6f5d61bd140f1c7936d21cf9)

Merge pull request #50433 from zdover23/wip-doc-2023-03-08-backport-50430-to-pacific

pacific: doc/install: update index.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/install: update index.rst

Update index.rst by making minor grammar improvements. This file was
long overdue for a backport to Reef, Quincy, and Pacific, so this commit
was a good way to pass a human eyeball over the text before making those
backports.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 82d748ff590cfd31fefddc094b10622d090b054f)

Merge pull request #50158 from idryomov/wip-57396-pacific

pacific: librbd: Fix local rbd mirror journals growing forever

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #50265 from idryomov/wip-58755-pacific

pacific: rbd-mirror: add information about the last snapshot sync to image status

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #50181 from nbalacha/wip-58764-pacific

pacific: rbd-mirror: fix syncing_percent calculation logic in get_replay_status()

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #50129 from idryomov/wip-58060-pacific

pacific: librbd: avoid EUCLEAN error after "rbd rm" is interrupted

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #50112 from idryomov/wip-58688-pacific

pacific: qa/suites/rbd: fix sporadic "rx-only direction" test failures

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #49650 from ajarr/wip-58361-pacific

pacific: mgr/rbd_support: remove localized schedule option during module startup

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #49413 from idryomov/wip-50461-pacific

pacific: librbd/crypto: fix bad return checks from libcryptsetup

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #50401 from zdover23/wip-doc-2023-03-07-backport-50398-to-pacific

pacific: doc/dev: add full stop to sentence in basic-wo

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: add full stop to sentence in basic-wo

Add a full stop to a sentence in basic-workflow.rst. I looked at this
document and noticed that it wasn't there, and it was just bugging me.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 262b115b7554b7931cc174500eb12ac7a5d67513)

Merge pull request #50396 from zdover23/wip-doc-2023-03-06-backport-50382-to-pacific

pacific: doc/rgw: fix caption

doc/rgw: fix caption

Rewrite the third paragraph of the caption to the figure depicting how a
zonegroup works.

Follows https://github.com/ceph/ceph/pull/50316.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8fa521466023635436305c1af31501bbbe20e857)

doc/rgw - fix grammar in table in s3.rst

Put an "only" in the correct place. Also, this is a very small change
that will allow me to see if Jenkins is working (it probably isn't).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1beab1e8abf59088be628cca972c59202526637d)

Merge pull request #50379 from zdover23/wip-doc-2023-03-04-backport-50375-to-pacific

pacific: doc/rgw: refine keycloak.rst

doc/rgw: refine keycloak.rst

Full line-edit of doc/radosgw/keycloak.rst. Corrected syntax, grammar,
RST, and broken links.

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5706ff1e451e6c7b3c3d40d492985377161b0133)

Merge pull request #50368 from zdover23/wip-doc-2023-03-03-backport-50364-to-pacific

pacific: doc/cephadm: Redd up compatibility.rst

doc/cephadm: Redd up compatibility.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit d608dec43b84c9a06990458219dda769829e05f8)

Merge pull request #50363 from zdover23/wip-doc-2023-03-03-backport-50354-to-pacific

pacific: doc/rgw: clean zone-sync.svg

doc/rgw: clean zone-sync.svg

Refine zone-sync.svg (fix kerning and use fonts that render properly).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 064fdc9d9b4ad3393bfb5069d2f97dc622aaf12d)

rgw/beast: StreamIO remembers connection errors for graceful shutdown

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 525899d4608203ea4236a816a78cf871cadceea6)

rgw: Fix segfault due to concurrent socket use at timeout

This commit fixes a potential segfault risk when
rgw timeout handler works on the socket in one
thread while it is concurrently used by another.
The details of the fix are:

1. Instead of calling socket close(), which resets
descriptor_data in boost::asio socket and risks
segfault due to concurrent use of the socket,
the timeout handler now calls cancel() to abort
all pending ops followed by shutdown() to disable
the underlying transport. The eventual closure of
the socket will be done in the socket destructor.

2. Expose the actual boost::asio socket via get_socket()
from Connection so that the timeout handler can call
cancel() and shutdown() on it, although the socket data
member is already accessible. It allows future expansion
that wants to hide the socket even though it renders the
existing close() less useful.

Fixes: https://tracker.ceph.com/issues/58670
Signed-off-by: Yixin Jin <yjin77@yahoo.ca>
(cherry picked from commit 6d5988cbdab48705414e311217c61d3c798085d8)

rgw/beast: fix interaction between keepalive and 100-continue

if we reject a request with a "Expect: 100-continue" header before
sending a "100 Continue" response, the keepalive logic should not try to
read/discard request body before parsing the next request headers

Fixes: https://tracker.ceph.com/issues/58286
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 4358cf2a6a60d780791322f17cb216addd8ddae6)

rgw/beast: ClientIO remembers whether it sent '100 Continue'

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 99228e17543d2cfed903b801919ef3e5f4847ba7)

Merge pull request #50357 from zdover23/wip-doc-2023-03-03-backport-50351-to-pacific

pacific: doc/radosgw: format admonitions

doc/radosgw: format admonitions

Break up the text of two similar admonitions into three paragraphs (in
each of the two instances). This makes the content of the admonition
much easier to read at a glance.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4db68f5711f48b190f0135a3a7a6df8dfcf5abfa)

qa/tests: added pacific client upgrade => reef

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #50337 from zdover23/wip-doc-2023-03-02-backport-50335-to-pacific

pacific: doc/cephadm: update cephadm compatability and stability page

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: update cephadm compatability and stability page

This page is very out of date. This commit probably doesn't
cover everything there is to say about stability and compatability
in cephadm, but it at least gets it noticeably closer to reality

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 383f46aa79e7a6f5571405a352ad023983560625)

Merge pull request #50332 from zdover23/wip-doc-2023-03-02-backport-50316-to-pacific

pacific: doc/rgw: improve diagram caption

doc/rgw: improve diagram caption

Improve the syntax and semantics of the caption of the diagram
"Replication of Object Data Between Zones" in doc/radosgw/multisite.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e8aa50e240141949e2cf91c3b216808f4e055887)

Merge pull request #50298 from zdover23/wip-doc-2023-02-28-backport-50295-to-pacific

doc/radosgw: s/zone group/zonegroup/g et alia

doc/radosgw: s/zone group/zonegroup/g et alia

s/zone group/zonegroup/ where simple greps failed to find instances of
"zone group" that were spread across two lines; break a paragraph into
two paragraphs so that each paragraph has a thematic idea of its own.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d1f2e9f3a6837f2b19acaabfb3261849d547d5f8)

Merge pull request #50294 from zdover23/wip-doc-2023-02-28-backport-50276-to-pacific

pacific: doc/rgw: caption a diagram

doc/rgw: caption a diagram

Add an explanation of a diagram that shows how object data is replicated
between zones within a zonegroup.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ce2bd7cb2603c479c17ac18b9277b903a02bb06a)

Merge pull request #50288 from zdover23/wip-doc-2023-02-28-backport-50274-to-pacific

pacific: doc/rgw: remove "tertiary", link to procedure

Merge pull request #50278 from zdover23/wip-doc-2023-02-27-backport-50264-to-pacific

pacific: doc/radosgw: multisite - edit "functional changes"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rgw: remove "tertiary", link to procedure

Remove the term "tertiary zone" and replace it with "second secondary
zone" (because there is no such thing as a tertiary zone). Link to the
procedure for creating a secondary zone in a place where such a link is
helpful to the reader.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8e273199d09a670578b0c1076bc18dbd113d42dd)

Merge pull request #50272 from zdover23/wip-doc-2023-02-27-backport-50267-to-pacific

pacific: doc/glossary: Add "zone" to glossary.rst

doc/radosgw: multisite - edit "functional changes"

Improve the wording of the section "Functional Changes from Infernalis"
in doc/radosgw/multisite.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 35edcc17c96010328e8ee85648a3b74887aef7b9)

doc/glossary: Add "zone" to glossary.rst

Add "Zone" to the glossary.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 495eb97fd7fa3d53d27ad8d7df993df80b708ca1)

rbd-mirror: add information about the last snapshot sync to image status

this commit adds fields for time taken to sync and bytes in the last
snapshot to the mirror image status command.

Fixes: https://tracker.ceph.com/issues/58755
Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
(cherry picked from commit 9b9f18a65d2430ddcf32cbf85566b0223be91758)

Merge pull request #50263 from zdover23/wip-doc-2023-02-27-backport-50260-to-pacific

pacific: doc/glossary: add "client" to glossary

doc/glossary: add "client" to glossary

Add a definition of "client" to doc/glossary.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2dc6f56f26c55f89f3445ff97a88a704622b55c0)

Merge pull request #50259 from zdover23/wip-doc-2023-02-26-backport-50257-to-pacific

pacific: doc/glossary: add "application" to the glossary

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/glossary: add "application" to the glossary

Add an admittedly-stub definition of "application" to the glossary.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 235d2e8b67b1700a55819a14eb26f00de86ba554)

Merge pull request #50255 from zdover23/wip-doc-2023-02-24-backport-50250-to-pacific

pacific: doc/cephadm/host-management: add service spec link

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #50253 from zdover23/wip-doc-2023-02-24-backport-50179-to-pacific

pacific: doc/cephfs: describe conf opt "client quota df" in quota doc

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/cephfs: describe conf opt "client quota df" in quota doc

The ceph config file option (from the client section) "client quota df"
is mentioned in "CephFS Client Capabilities" document but not in the
"CephFS Quota" document. Adding information about this option to this
document too would make it easier for CephFS users to discover,
understand and use this option.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit cd3f9575afb33bdb0a311a3f27801879a3254824)

doc/cephadm/host-management: add service spec link

The old "(below)" text is not accurate, the service spec definition is
not in the same file at this point in time. This commit adds a ref link
to the actual service specification section.

Signed-off-by: thomas <me@thomasanderson.cloud>
(cherry picked from commit bb5837f049d9eb46f8d5c63c4dfec09fd94424f3)

Merge pull request #50248 from zdover23/wip-doc-2023-02-24-backport-50246-to-pacific

pacific: doc/glossary: add AWS/OpenStack bucket info

doc/glossary: add AWS/OpenStack bucket info

Add links to AWS's documentation of buckets, in accordance with Casey
Bodley's suggestions here:
https://github.com/ceph/ceph/pull/50221#discussion_r1115900879

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d16ed970e9ac76d6320f0ae26fa3ddd745dbd429)

test/cls/rgw: test that index entry is removed after racing deletes

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 5ddde6eb3d6a9e387b904fa4986bfb8e2ccbef7a)

cls/rgw: remove index entry after cancelling last racing delete op

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 08efcc2536c34935a516bf850a9f909c0a3b3f52)

Conflicts:
src/cls/rgw/cls_rgw.cc CLS_LOG_BITX() -> CLS_LOG()

rgw/rados: index transactions pass remove_objs to cancel() too

whenever an index transaction uses remove_objs for complete(), it also
needs to pass them for cancel() to avoid leaking index entries

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b848ccae96169ff697ab0eed5edf6e3e8f898eb7)

Conflicts:
src/rgw/rgw_rados.h 'using namespace std' not backported

cls/rgw: index cancelation still cleans up remove_objs

when multipart uploads complete their final bucket index transaction,
they pass the list of part objects in 'remove_objs' for bulk removal -
the part objects, along with their bucket stats, get replaced by the
head object

but if CompleteMultipart races with another upload, the head object
write will fail with ECANCELED and the bucket index transaction gets
canceled with CLS_RGW_OP_CANCEL. these canceled uploads still need to
clean up their 'remove_objs', but cancelation was returning too early.
as a result, these bucket index entries get orphaned and leave the
bucket stats inconsistent

this commit reworks rgw_bucket_complete_op() so that CLS_RGW_OP_CANCEL
is handled the same way as OP_ADD and OP_DEL, so always runs the loop to
clean up 'remove_objs'

Fixes: https://tracker.ceph.com/issues/53199
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8b27472bbd8a22372cd14c0c5603ee41056a3343)

cls/rgw: add complete_remove_obj() helper for remove_objs

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit f3325fc76fef97001f31142ce51c140e549c43bb)

cls/rgw: helpers take const input params

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit d7ec0b281c80eeb319fbe8437400c807e3758b6e)

Merge pull request #50225 from zdover23/wip-doc-2023-02-23-backport-50221-to-pacific

pacific: doc/glossary: add "Bucket"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>