]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc/cephfs: Improve fs-volumes.rst 50832/head
Anthony D'Atri [Fri, 31 Mar 2023 13:37:52 +0000 (09:37 -0400)]
doc/cephfs: Improve fs-volumes.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit c8e1f3ac3db513004fbfbb0049757ddc2bca291a)

2 years agoMerge PR #50923 into pacific
Patrick Donnelly [Thu, 6 Apr 2023 17:51:50 +0000 (13:51 -0400)]
Merge PR #50923 into pacific

* refs/pull/50923/head:
qa: load file system info if not created

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #50860 into pacific
Patrick Donnelly [Thu, 6 Apr 2023 17:50:07 +0000 (13:50 -0400)]
Merge PR #50860 into pacific

* refs/pull/50860/head:
qa: simplify and use correct recovery procedure
doc: update alternate meta pool recovery
tools/cephfs/DataScan: add debugging for directory injection

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #50784 into pacific
Patrick Donnelly [Thu, 6 Apr 2023 17:49:08 +0000 (13:49 -0400)]
Merge PR #50784 into pacific

* refs/pull/50784/head:
tools/cephfs: include lost+found in scan_links

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #50781 into pacific
Patrick Donnelly [Thu, 6 Apr 2023 17:48:10 +0000 (13:48 -0400)]
Merge PR #50781 into pacific

* refs/pull/50781/head:
mds: add config to decide whether to mark dentry bad
qa: add missing scan_links step for data scan recovery
qa/tasks/cephfs: test damage to dentry's first is caught
qa/tasks/cephfs: use rank_asok and allow specifying rank
qa/tasks: allow specifying timeout command prefix to ceph
mds: provide test configs for creating first corruption
mds: catch damage to dentry's first field
mds: add debugging for pre_cow_old_inode
mds: cleanup code
mds: check for some dentry damage in scrub
mds: remove unused method
mds: note damaged dentry with first gt last
mds: cluster log scrub failure for dirfrag
mds: mark dirfrag good if repaired
mds: only dump past_parent_snap if non-empty

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #50775 into pacific
Patrick Donnelly [Thu, 6 Apr 2023 17:47:19 +0000 (13:47 -0400)]
Merge PR #50775 into pacific

* refs/pull/50775/head:
qa: ignore expected scrub error

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #50760 into pacific
Patrick Donnelly [Thu, 6 Apr 2023 17:46:18 +0000 (13:46 -0400)]
Merge PR #50760 into pacific

* refs/pull/50760/head:
qa: lengthen health warning wait

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #50757 into pacific
Patrick Donnelly [Thu, 6 Apr 2023 17:41:27 +0000 (13:41 -0400)]
Merge PR #50757 into pacific

* refs/pull/50757/head:
qa: ignore MDS_TRIM warnings when osd thrashing

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #50913 from zdover23/wip-doc-2023-04-06-backport-50825-to-pacific
Anthony D'Atri [Thu, 6 Apr 2023 16:06:01 +0000 (12:06 -0400)]
Merge pull request #50913 from zdover23/wip-doc-2023-04-06-backport-50825-to-pacific

pacific: doc/rados/ops: edit health-checks.rst (2 of x)

2 years agoqa: load file system info if not created 50923/head
Patrick Donnelly [Wed, 5 Apr 2023 19:25:38 +0000 (15:25 -0400)]
qa: load file system info if not created

Mounts may create a Filesystem object which does not create the file
system. This causes self.id to be Null when we try to wait for daemons
to be up. Load it just in time!

Fixes: https://tracker.ceph.com/issues/59332
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 69565dbbf124e29f30dae989eae41eada161a4b4)

2 years agoMerge pull request #50123 from rhcs-dashboard/wip-57433-pacific
Nizamudeen A [Thu, 6 Apr 2023 06:20:15 +0000 (11:50 +0530)]
Merge pull request #50123 from rhcs-dashboard/wip-57433-pacific

pacific: mgr/dashboard: fix "can't read .ssh/known_hosts: No such file or directory

Reviewed-by: Pegonzal <NOT@FOUND>
2 years agodoc/rados/ops: edit health-checks.rst (2 of x) 50913/head
Zac Dover [Sat, 1 Apr 2023 20:05:41 +0000 (06:05 +1000)]
doc/rados/ops: edit health-checks.rst (2 of x)

Edit docs/rados/operations/health-checks.rst (2 of x). PR#50674, the PR
that immediately precedes this PR in the series of PRs that line-edit
health-checks.rst, wrongly identified this series as having five
sections. This has been rectified by using the "2 of x" formulation.

Follows https://github.com/ceph/ceph/pull/50674

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0565f59698e9d00adf5a4667ac6e84e97d31b554)

2 years agoMerge pull request #50036 from batrick/i52247
Yuri Weinstein [Wed, 5 Apr 2023 21:27:11 +0000 (14:27 -0700)]
Merge pull request #50036 from batrick/i52247

pacific: libcephsqlite: CheckReservedLock the result will always be zero

Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #50092 from petrutlucian94/wip-58703-pacific
Yuri Weinstein [Wed, 5 Apr 2023 21:24:23 +0000 (14:24 -0700)]
Merge pull request #50092 from petrutlucian94/wip-58703-pacific

pacific: os/memstore: Fix memory leak

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #50072 from ifed01/wip-ifed-more-pin-fix-pac
Yuri Weinstein [Wed, 5 Apr 2023 21:23:11 +0000 (14:23 -0700)]
Merge pull request #50072 from ifed01/wip-ifed-more-pin-fix-pac

pacific: os/bluestore: fix onode ref counting

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #49937 from NitzanMordhai/wip-58613-pacific
Yuri Weinstein [Wed, 5 Apr 2023 21:21:35 +0000 (14:21 -0700)]
Merge pull request #49937 from NitzanMordhai/wip-58613-pacific

pacific: Wip nitzan pglog ec getattr error

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #49830 from tserong/wip-58533-pacific
Yuri Weinstein [Wed, 5 Apr 2023 21:20:33 +0000 (14:20 -0700)]
Merge pull request #49830 from tserong/wip-58533-pacific

pacific: ceph.spec.in: Replace %usrmerged macro with regular version check

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #50870 from rhcs-dashboard/wip-59321-pacific
Nizamudeen A [Wed, 5 Apr 2023 14:42:09 +0000 (20:12 +0530)]
Merge pull request #50870 from rhcs-dashboard/wip-59321-pacific

pacific: mgr/dashboard: fix displaying mirror image progress

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #47725 from rhcs-dashboard/wip-57217-pacific
Nizamudeen A [Wed, 5 Apr 2023 14:38:35 +0000 (20:08 +0530)]
Merge pull request #47725 from rhcs-dashboard/wip-57217-pacific

pacific: mgr/dashboard: Hide maintenance option on expand cluster

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #50866 from zdover23/wip-doc-2023-04-05-backport-50855-to-pacific
Anthony D'Atri [Wed, 5 Apr 2023 13:25:52 +0000 (09:25 -0400)]
Merge pull request #50866 from zdover23/wip-doc-2023-04-05-backport-50855-to-pacific

pacific: doc/rados/ops: edit monitoring-osd-pg.rst (1 of x)

2 years agomgr/dashboard: fix displaying mirror image progress 50870/head
Pere Diaz Bou [Mon, 3 Apr 2023 15:22:35 +0000 (17:22 +0200)]
mgr/dashboard: fix displaying mirror image progress

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
(cherry picked from commit 80960387fbb6d49c3681f4c9e249c441a891462a)

2 years agodoc/rados/ops: edit monitoring-osd-pg.rst (1 of x) 50866/head
Zac Dover [Tue, 4 Apr 2023 03:29:15 +0000 (13:29 +1000)]
doc/rados/ops: edit monitoring-osd-pg.rst (1 of x)

Line-edit doc/rados/operations/monitoring-osd-pg.rst (1 of x).

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bd213c244e8a387c98358ac41f4802e102e89c63)

2 years agoMerge pull request #50289 from idryomov/wip-58833-pacific
Yuri Weinstein [Tue, 4 Apr 2023 15:04:16 +0000 (08:04 -0700)]
Merge pull request #50289 from idryomov/wip-58833-pacific

pacific: librbd: call apply_changes() after setting librados_thread_count

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoqa: simplify and use correct recovery procedure 50860/head
Patrick Donnelly [Tue, 20 Sep 2022 14:57:01 +0000 (10:57 -0400)]
qa: simplify and use correct recovery procedure

Notably, this recovery procedure was missing scan_links.

Also, the test was oddly trying to recover the real file system in
addition to the recovery file system. I've removed that unnecessary
recovery.

Fixes: https://tracker.ceph.com/issues/57598
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 8512bbc01525b77583a87dfc2149fb1dec072978)

Conflicts:
qa/tasks/cephfs/filesystem.py: trivial

2 years agodoc: update alternate meta pool recovery
Patrick Donnelly [Tue, 20 Sep 2022 14:32:26 +0000 (10:32 -0400)]
doc: update alternate meta pool recovery

Streamline, clarify, and use modern commands (notably: --recover).

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit da19a128ee4a68299d4899de91701944720f53ae)

2 years agotools/cephfs/DataScan: add debugging for directory injection
Patrick Donnelly [Mon, 19 Sep 2022 17:31:40 +0000 (13:31 -0400)]
tools/cephfs/DataScan: add debugging for directory injection

Continuation of 16fc2c392b0a4de13dbe4dfcc7dad01d8e58ce40.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 94d2e24b5cb2bbbfb2d55f6cc538d448091e3d4e)

2 years agoMerge pull request #50854 from zdover23/wip-doc-2023-04-04-backport-50851-to-pacific
Anthony D'Atri [Mon, 3 Apr 2023 22:20:58 +0000 (18:20 -0400)]
Merge pull request #50854 from zdover23/wip-doc-2023-04-04-backport-50851-to-pacific

pacific: doc/rados/ops: add ceph-medic documentation

2 years agodoc/rados/ops: add ceph-medic documentation 50854/head
Zac Dover [Mon, 3 Apr 2023 20:57:27 +0000 (06:57 +1000)]
doc/rados/ops: add ceph-medic documentation

Add a link to the ceph-medic documentation to
doc/rados/operations/monitoring.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b2a409da26b508e5a51e3becbce16b7ecaffcc1d)

2 years agoMerge pull request #50824 from zdover23/wip-doc-2023-04-01-backport-50670-to-pacific
colemitchell [Fri, 31 Mar 2023 21:29:50 +0000 (17:29 -0400)]
Merge pull request #50824 from zdover23/wip-doc-2023-04-01-backport-50670-to-pacific

pacific: doc/rados: edit ops/monitoring.rst (1 of 3)

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/rados: edit ops/monitoring.rst (1 of 3) 50824/head
Zac Dover [Sat, 25 Mar 2023 18:51:50 +0000 (04:51 +1000)]
doc/rados: edit ops/monitoring.rst (1 of 3)

Line-edit the first third of doc/rados/operations/monitoring.rst.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bc5f404a7876f887d0c7a2dedee5391f66ab0505)

2 years agoMerge pull request #50801 from zdover23/wip-doc-2023-03-31-backport-45354-to-pacific
Anthony D'Atri [Fri, 31 Mar 2023 13:58:23 +0000 (09:58 -0400)]
Merge pull request #50801 from zdover23/wip-doc-2023-03-31-backport-45354-to-pacific

pacific: doc/msgr2: update dual stack status

2 years agoMerge pull request #50804 from zdover23/wip-doc-2023-03-31-backport-50554-to-pacific
Anthony D'Atri [Fri, 31 Mar 2023 13:54:08 +0000 (09:54 -0400)]
Merge pull request #50804 from zdover23/wip-doc-2023-03-31-backport-50554-to-pacific

pacific: doc/rados: line-edit pg-repair.rst

2 years agoMerge pull request #50798 from zdover23/wip-doc-2023-03-31-backport-50674-to-pacific
zdover23 [Fri, 31 Mar 2023 07:15:00 +0000 (17:15 +1000)]
Merge pull request #50798 from zdover23/wip-doc-2023-03-31-backport-50674-to-pacific

pacific: doc/rados/ops: edit health-checks.rst (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: line-edit pg-repair.rst 50804/head
Zac Dover [Thu, 16 Mar 2023 02:27:44 +0000 (12:27 +1000)]
doc/rados: line-edit pg-repair.rst

Line edit pg-repair.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b7c19dac2dfdcbc50515e83d952fb25070496c1c)

2 years agodoc/msgr2: update dual stack status 50801/head
Dan van der Ster [Fri, 11 Mar 2022 14:15:20 +0000 (15:15 +0100)]
doc/msgr2: update dual stack status

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit c7eaeb4dff1fca967046bcd9b53548eabd18012e)

2 years agodoc/rados/ops: edit health-checks.rst (1 of x) 50798/head
Zac Dover [Sat, 25 Mar 2023 20:02:19 +0000 (06:02 +1000)]
doc/rados/ops: edit health-checks.rst (1 of x)

Edit docs/rados/operations/health-checks.rst (1 of x).

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cb1e20f879edb82ae619693a4f1f5e88fd0593dd)
(cherry picked from commit bfeadab4cacfea984b24be32f74aae29d750c148)

2 years agoMerge pull request #50771 from zdover23/wip-doc-2023-03-30-backport-50742-to-pacific
Anthony D'Atri [Thu, 30 Mar 2023 23:58:50 +0000 (19:58 -0400)]
Merge pull request #50771 from zdover23/wip-doc-2023-03-30-backport-50742-to-pacific

pacific: doc/start: update "notify us" section

2 years agodoc/start: update "notify us" section 50771/head
Zac Dover [Wed, 29 Mar 2023 13:47:38 +0000 (23:47 +1000)]
doc/start: update "notify us" section

Rewrite the "Notify Us" section in doc/start/documenting-ceph.rst so
that it is written in English sentences.

(cherry picked from commit 613ece24777c4b222054fe9a6d82ba51949c45ea)
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoqa: lengthen health warning wait 50760/head
Patrick Donnelly [Thu, 21 Oct 2021 01:43:54 +0000 (21:43 -0400)]
qa: lengthen health warning wait

It's just a little too short!

Fixes: https://tracker.ceph.com/issues/52995
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit c8810e46e8f28ed204ef2d39f552f96f4a6cfe39)

Conflicts:
qa/tasks/cephfs/test_failover.py

2 years agomds: add config to decide whether to mark dentry bad 50781/head
Patrick Donnelly [Wed, 29 Mar 2023 13:05:25 +0000 (09:05 -0400)]
mds: add config to decide whether to mark dentry bad

So admin can restore access to files if necessary.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 7ffa065a03316b67b6b6d48692b4b181f93ddbda)

2 years agoqa: add missing scan_links step for data scan recovery
Patrick Donnelly [Fri, 24 Mar 2023 21:54:35 +0000 (17:54 -0400)]
qa: add missing scan_links step for data scan recovery

Without, the first field remains corrupt (HEAD).

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 1b4d9077af826d1931b91938fd49e7113e8d3840)

Conflicts:
qa/tasks/cephfs/test_data_scan.py

2 years agoqa/tasks/cephfs: test damage to dentry's first is caught
Patrick Donnelly [Wed, 18 Jan 2023 02:22:10 +0000 (21:22 -0500)]
qa/tasks/cephfs: test damage to dentry's first is caught

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 293b90fe63665666ca2de8b65c38f987a4d0b2a6)

2 years agoqa/tasks/cephfs: use rank_asok and allow specifying rank
Patrick Donnelly [Fri, 20 Jan 2023 23:20:15 +0000 (18:20 -0500)]
qa/tasks/cephfs: use rank_asok and allow specifying rank

This will use the more efficient:

    ceph tell mds.<fsname>:<rank> ...

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 3ba17390e92c21a3eba7337a2da0df79f6bf49ca)

2 years agoqa/tasks: allow specifying timeout command prefix to ceph
Patrick Donnelly [Wed, 18 Jan 2023 02:21:08 +0000 (21:21 -0500)]
qa/tasks: allow specifying timeout command prefix to ceph

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit dbf1a402c9626bcb2d1b3363f871c569860a0921)

Conflicts:
qa/tasks/ceph_manager.py

2 years agoMerge pull request #50789 from zdover23/wip-doc-2023-03-30-backport-50764-to-pacific
zdover23 [Thu, 30 Mar 2023 07:15:29 +0000 (17:15 +1000)]
Merge pull request #50789 from zdover23/wip-doc-2023-03-30-backport-50764-to-pacific

pacific: doc/start: format procedure in documenting-ceph

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/start: format procedure in documenting-ceph 50789/head
Zac Dover [Thu, 30 Mar 2023 00:54:52 +0000 (10:54 +1000)]
doc/start: format procedure in documenting-ceph

Organize three steps in a procedure into one step with three sub-steps.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6f3cd78f6116f3e19a8f6c5e0ebda816067a334e)

2 years agotools/cephfs: include lost+found in scan_links 50784/head
Patrick Donnelly [Mon, 27 Mar 2023 18:47:29 +0000 (14:47 -0400)]
tools/cephfs: include lost+found in scan_links

Otherwise, any injected dentries have incorrect first snapids.

Fixes: https://tracker.ceph.com/issues/59183
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit d8b6d451847cda2b3b06ed630a14306cd20bf9b8)

2 years agomds: provide test configs for creating first corruption
Patrick Donnelly [Wed, 18 Jan 2023 02:30:04 +0000 (21:30 -0500)]
mds: provide test configs for creating first corruption

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit fe258dc54bbeee5913289cad08634b5ff1d737ba)

Conflicts:
src/mds/MDSRank.cc
src/mds/MDSRank.h
src/mds/Server.cc

2 years agomds: catch damage to dentry's first field
Patrick Donnelly [Wed, 18 Jan 2023 02:29:39 +0000 (21:29 -0500)]
mds: catch damage to dentry's first field

When possible. Abort the MDS before it can be written to the
journal/directory.

This is part of a series to address corruption first observed in [1].
How the corruption is introduced is yet unknown.

[1] https://tracker.ceph.com/issues/38452#note-10

Fixes: http://tracker.ceph.com/issues/58482
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 03407528f95fe60e5af4062c3caa3688b8b31530)

Conflicts:
src/common/options/mds.yaml.in
src/mds/CDir.cc

2 years agomds: add debugging for pre_cow_old_inode
Patrick Donnelly [Wed, 15 Mar 2023 18:06:11 +0000 (14:06 -0400)]
mds: add debugging for pre_cow_old_inode

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit c9d36056c7d515ad879d589938f888f9f2787973)

2 years agomds: cleanup code
Patrick Donnelly [Tue, 10 Jan 2023 20:35:04 +0000 (15:35 -0500)]
mds: cleanup code

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 17d826551cd9466b4c5457e668d581baa9252c91)

2 years agomds: check for some dentry damage in scrub
Patrick Donnelly [Wed, 10 Aug 2022 17:21:26 +0000 (13:21 -0400)]
mds: check for some dentry damage in scrub

Fixes: https://tracker.ceph.com/issues/57091
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 14712f96294ad0915951af151e4919ebf6c40cbb)

2 years agomds: remove unused method
Patrick Donnelly [Wed, 31 Aug 2022 01:02:32 +0000 (21:02 -0400)]
mds: remove unused method

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 104ae798c68c95faf904adb498aae35063fe04a0)

2 years agomds: note damaged dentry with first gt last
Patrick Donnelly [Wed, 24 Aug 2022 17:12:21 +0000 (13:12 -0400)]
mds: note damaged dentry with first gt last

Only when loaded in cache.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 956eff7e02498511b597aadb85c686b78c44ea8a)

2 years agomds: cluster log scrub failure for dirfrag
Patrick Donnelly [Wed, 24 Aug 2022 17:11:10 +0000 (13:11 -0400)]
mds: cluster log scrub failure for dirfrag

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 40f483ed457a24cfdab343875ab98ca1240850a6)

2 years agomds: mark dirfrag good if repaired
Patrick Donnelly [Tue, 20 Sep 2022 20:15:27 +0000 (16:15 -0400)]
mds: mark dirfrag good if repaired

Otherwise, we get wrong scrub errors after repair.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 7d6199a226f7e54b9580cbf05d97114068377b4d)

2 years agomds: only dump past_parent_snap if non-empty
Patrick Donnelly [Wed, 24 Aug 2022 17:09:55 +0000 (13:09 -0400)]
mds: only dump past_parent_snap if non-empty

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit b1a169b4f319c92ed0e57f68e224572fb509619c)

2 years agoqa: ignore expected scrub error 50775/head
Patrick Donnelly [Mon, 26 Sep 2022 17:27:57 +0000 (13:27 -0400)]
qa: ignore expected scrub error

The test_orphan_scan test deliberately removes a dentry which will cause
rstat damage. Ignore it.

Fixes: https://tracker.ceph.com/issues/57657
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit e930a8b22108917f195ce5e106b1c70cabef9c91)

2 years agoMerge pull request #50763 from zdover23/wip-doc-2023-03-30-backport-50744-to-pacific
Anthony D'Atri [Wed, 29 Mar 2023 22:32:14 +0000 (18:32 -0400)]
Merge pull request #50763 from zdover23/wip-doc-2023-03-30-backport-50744-to-pacific

pacific: doc/rados: add link to ops/health-checks.rst

2 years agodoc/rados: add link to ops/health-checks.rst 50763/head
Zac Dover [Wed, 29 Mar 2023 14:25:23 +0000 (00:25 +1000)]
doc/rados: add link to ops/health-checks.rst

Add an internal navigation link to
doc/rados/operations/health-checks.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f2f968f65bd1f1a6975fd340c66703cea335dcf6)
(cherry picked from commit 1ddc2b410258449e5d89a415a0494da2b8a79060)

2 years agoqa: ignore MDS_TRIM warnings when osd thrashing 50757/head
Patrick Donnelly [Tue, 27 Sep 2022 02:20:57 +0000 (22:20 -0400)]
qa: ignore MDS_TRIM warnings when osd thrashing

Fixes: https://tracker.ceph.com/issues/57677
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit efe41d2a9d8c521683e1dcddaebce9b12544933f)

2 years agoMerge pull request #50753 from zdover23/wip-doc-2023-03-30-backport-50750-to-pacific
Anthony D'Atri [Wed, 29 Mar 2023 19:32:52 +0000 (15:32 -0400)]
Merge pull request #50753 from zdover23/wip-doc-2023-03-30-backport-50750-to-pacific

pacific: doc/rados/operations: Fix typo in erasure-code.rst

2 years agodoc/rados/operations: Fix typo in erasure-code.rst 50753/head
SAINITHIN.ARTHAM [Wed, 29 Mar 2023 18:16:32 +0000 (23:46 +0530)]
doc/rados/operations: Fix typo in erasure-code.rst

Signed-off-by: Sainithin Artham <sai.artham.19cse@bmu.edu.in>
(cherry picked from commit 3269fea2a209928137e55db16328c581988c048a)

2 years agoMerge pull request #50741 from zdover23/wip-doc-2023-03-29-backport-50723-to-pacific
Anthony D'Atri [Wed, 29 Mar 2023 14:16:48 +0000 (10:16 -0400)]
Merge pull request #50741 from zdover23/wip-doc-2023-03-29-backport-50723-to-pacific

pacific: doc/start: documenting-ceph - add squash procedure

2 years agodoc/start: documenting-ceph - add squash procedure 50741/head
Zac Dover [Tue, 28 Mar 2023 09:29:40 +0000 (19:29 +1000)]
doc/start: documenting-ceph - add squash procedure

Add a procedure to doc/start/documenting-ceph.rst that explains how to
perform an interactive rebase to squash commits.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 71ee225d7b8bf54bd190a8b1f2422c6837601f16)

2 years agoMerge pull request #49923 from adk3798/wip-58539-pacific
Adam King [Tue, 28 Mar 2023 19:44:41 +0000 (15:44 -0400)]
Merge pull request #49923 from adk3798/wip-58539-pacific

pacific: mgr/cephadm: increase ingress timeout values

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #49925 from adk3798/wip-58541-pacific
Adam King [Tue, 28 Mar 2023 19:39:18 +0000 (15:39 -0400)]
Merge pull request #49925 from adk3798/wip-58541-pacific

pacific: mgr/cephadm: support for extra entrypoint args

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #50709 from zdover23/wip-doc-2023-03-28-backport-49514-to-pacific
Anthony D'Atri [Tue, 28 Mar 2023 12:29:28 +0000 (08:29 -0400)]
Merge pull request #50709 from zdover23/wip-doc-2023-03-28-backport-49514-to-pacific

pacific: doc/glossary: link to CephX Config ref

2 years agoMerge pull request #49632 from lxbsz/wip-58343
Xiubo Li [Tue, 28 Mar 2023 08:46:28 +0000 (16:46 +0800)]
Merge pull request #49632 from lxbsz/wip-58343

pacific: mds: switch submit_mutex to fair mutex for MDLog

2 years agodoc/glossary: link to CephX Config ref 50709/head
Zac Dover [Mon, 19 Dec 2022 18:16:19 +0000 (04:16 +1000)]
doc/glossary: link to CephX Config ref

Link to the CephX Configuration Reference in the "CephX" entry in the
glossary.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 36a8f27e969d7103975ebfe312a4be6ae9f281f5)

2 years agoMerge pull request #50703 from zdover23/wip-doc-2023-03-28-backport-50697-to-pacific
Anthony D'Atri [Tue, 28 Mar 2023 02:45:25 +0000 (22:45 -0400)]
Merge pull request #50703 from zdover23/wip-doc-2023-03-28-backport-50697-to-pacific

pacific: doc/glossary: add "Scrubbing"

2 years agodoc/glossary: add "Scrubbing" 50703/head
Zac Dover [Mon, 27 Mar 2023 20:48:32 +0000 (06:48 +1000)]
doc/glossary: add "Scrubbing"

Add "Scrubbing" to the glossary.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4a66819da48cee430ca74830e1a6f63685b6b240)

2 years agomgr/cephadm: increate ingress timeout values 49923/head
Frank Ederveen [Fri, 23 Dec 2022 14:44:38 +0000 (14:44 +0000)]
mgr/cephadm: increate ingress timeout values

This commit increases the 'timeout client' and 'timeout server' from 1s
to 30s. S3cmd multi-part uploads were failing with the shorter timeout.

Fixes: https://tracker.ceph.com/issues/58183
Signed-off-by: Frank Ederveen <frank.ederveen@gmail.com>
(cherry picked from commit 07701912cfe5b4e72d0f63ce0a8782c3f8c3da7e)

Conflicts:
src/pybind/mgr/cephadm/tests/test_services.py

2 years agomgr/cephadm: fix extra container/entrypoint args with spaces 49925/head
Adam King [Mon, 9 Jan 2023 19:50:12 +0000 (14:50 -0500)]
mgr/cephadm: fix extra container/entrypoint args with spaces

Fixes: https://tracker.ceph.com/issues/57338
Prior, doing extra container args like

- "--cpus"
- "2"

would work fine as the two args would be passed separately and
eventually placed in the final podman/docker run command
with a space between them. However, trying to do something like

- "--cpus 2"

instead would fail, as it would be translated to

--extra-container-args=--cpus 2

causing "2" to be considered its own arg, which cephadm
wouldn't know how to handle. Another way this can cause problems
is listed in the linked tracker. Either way, leaving the spaces
in the args was causing problems, and the simplest way to handle
it seems to be to just split on the original arg on the spaces
into multiple args

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit a161381ba816609b5041d2072e7e6cec39eaa753)

2 years agodoc/cephadm: docs for extra entrypoint args
Adam King [Tue, 8 Nov 2022 19:25:13 +0000 (14:25 -0500)]
doc/cephadm: docs for extra entrypoint args

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 8ee799e9cc0800fbedc8d9343aa3207bc9fd429e)

Conflicts:
doc/cephadm/services/index.rst

2 years agomgr/cephadm: support for extra entrypoint args
Adam King [Tue, 8 Nov 2022 19:09:05 +0000 (14:09 -0500)]
mgr/cephadm: support for extra entrypoint args

Args specified in the service spec to be added as
args for the entrypoint when we deploy the daemon

Fixes: https://tracker.ceph.com/issues/57944
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit db8e4462c968e1d29b0688efafad3442abb8779c)

Conflicts:
src/cephadm/cephadm
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/services/cephadmservice.py
src/pybind/mgr/cephadm/tests/test_cephadm.py
src/pybind/mgr/cephadm/tests/test_services.py

2 years agopython-common: add extra_entrypoint_args to service specs
Adam King [Mon, 7 Nov 2022 21:15:09 +0000 (16:15 -0500)]
python-common: add extra_entrypoint_args to service specs

To allow users to set extra args to be passed to
the entrypoint in the podman/docker run command
built by cephadm

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 98f6a9379e2dccbaf599923644b7aaa7200ded1f)

Conflicts:
src/python-common/ceph/deployment/drive_group.py
src/python-common/ceph/deployment/service_spec.py

2 years agoMerge pull request #49931 from adk3798/wip-58199-pacific
Adam King [Mon, 27 Mar 2023 15:37:47 +0000 (11:37 -0400)]
Merge pull request #49931 from adk3798/wip-58199-pacific

pacific: mgr/prometheus: fix module crash when trying to collect OSDs metrics

Reviewed-by: Teoman ONAY <tonay@ibm.com>
2 years agoMerge pull request #50007 from adk3798/57060-pacific-backport
Adam King [Mon, 27 Mar 2023 15:34:46 +0000 (11:34 -0400)]
Merge pull request #50007 from adk3798/57060-pacific-backport

pacific: mgr/cephadm: Fix how we check if a host belongs to public network

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #50371 from guits/wip-58909-pacific
Adam King [Mon, 27 Mar 2023 15:31:04 +0000 (11:31 -0400)]
Merge pull request #50371 from guits/wip-58909-pacific

pacific: drive_group: fix limit filter in drive_selection.selector

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #50511 from adk3798/wip-58775-pacific
Adam King [Mon, 27 Mar 2023 15:23:59 +0000 (11:23 -0400)]
Merge pull request #50511 from adk3798/wip-58775-pacific

pacific: mgr/cephadm: fix backends service in haproxy config with multiple nfs of same rank

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #50512 from adk3798/wip-58882-pacific
Adam King [Mon, 27 Mar 2023 15:17:27 +0000 (11:17 -0400)]
Merge pull request #50512 from adk3798/wip-58882-pacific

pacific: cephadm: set pids-limit unlimited for all ceph daemons

Reviewed-by: Teoman ONAY <tonay@ibm.com>
2 years agoMerge pull request #50513 from adk3798/wip-58773-pacific
Adam King [Mon, 27 Mar 2023 15:14:23 +0000 (11:14 -0400)]
Merge pull request #50513 from adk3798/wip-58773-pacific

pacific: mgr/cephadm: try to avoid pull when getting container image info

Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agoMerge pull request #49867 from vshankar/tr-58573
Yuri Weinstein [Mon, 27 Mar 2023 14:54:39 +0000 (07:54 -0700)]
Merge pull request #49867 from vshankar/tr-58573

pacific: mds: account for snapshot items when deciding to split or merge a directory

Reviewed-by: Xiubo Li <xiubli@redhat.com>
2 years agoMerge pull request #50514 from adk3798/wip-58777-pacific
Adam King [Mon, 27 Mar 2023 14:29:59 +0000 (10:29 -0400)]
Merge pull request #50514 from adk3798/wip-58777-pacific

pacific: cephadm: Adding poststop actions and setting TimeoutStartSec to 200s

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #50515 from adk3798/wip-58988-pacific
Adam King [Mon, 27 Mar 2023 14:27:48 +0000 (10:27 -0400)]
Merge pull request #50515 from adk3798/wip-58988-pacific

pacific: mgr/cephadm: don't add mgr into iscsi trusted_ip_list if it's already there

Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agoMerge pull request #50516 from adk3798/wip-58990-pacific
Adam King [Mon, 27 Mar 2023 14:24:57 +0000 (10:24 -0400)]
Merge pull request #50516 from adk3798/wip-58990-pacific

pacific: mgr/cephadm: be aware of host's shortname and FQDN

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #50679 from zdover23/wip-doc-2023-03-27-backport-50675-to-pacific
Anthony D'Atri [Sun, 26 Mar 2023 19:32:47 +0000 (15:32 -0400)]
Merge pull request #50679 from zdover23/wip-doc-2023-03-27-backport-50675-to-pacific

pacific: doc/rados: clean up ops/bluestore-migration.rst

2 years agodoc/rados: clean up ops/bluestore-migration.rst 50679/head
Zac Dover [Sun, 26 Mar 2023 15:03:58 +0000 (01:03 +1000)]
doc/rados: clean up ops/bluestore-migration.rst

Clean up internal links, fix the numbering of a procedure, and implement
Anthony D'Atri's suggestions in
https://github.com/ceph/ceph/pull/50487 and
https://github.com/ceph/ceph/pull/50488.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b28be76d0f9a5d78943fe3c583a234d0b50356f1)

2 years agoMerge pull request #50673 from zdover23/wip-doc-2023-03-26-backport-50654-to-pacific
colemitchell [Sat, 25 Mar 2023 19:56:06 +0000 (15:56 -0400)]
Merge pull request #50673 from zdover23/wip-doc-2023-03-26-backport-50654-to-pacific

pacific: doc/glossary: add "User"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/glossary: add "User" 50673/head
Zac Dover [Fri, 24 Mar 2023 10:56:51 +0000 (20:56 +1000)]
doc/glossary: add "User"

Add "User" to glossary.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fd6bfaf3fe6337511dd7ab344c2936f22a5d43bf)

2 years agoMerge pull request #50663 from zdover23/wip-doc-2023-03-25-backport-50660-to-pacific
Anthony D'Atri [Fri, 24 Mar 2023 18:51:14 +0000 (14:51 -0400)]
Merge pull request #50663 from zdover23/wip-doc-2023-03-25-backport-50660-to-pacific

pacific: doc/operations: fix prompt in bluestore-migration

2 years agodoc/operations: fix prompt in bluestore-migration 50663/head
Zac Dover [Fri, 24 Mar 2023 17:47:10 +0000 (03:47 +1000)]
doc/operations: fix prompt in bluestore-migration

Fix a single prompt in bluestore-migration.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5e54641aec134188c8001e212ea66c1a15d5945c)

2 years agoMerge pull request #50642 from zdover23/wip-doc-2023-03-23-backport-50634-to-pacific
Anthony D'Atri [Thu, 23 Mar 2023 13:20:20 +0000 (09:20 -0400)]
Merge pull request #50642 from zdover23/wip-doc-2023-03-23-backport-50634-to-pacific

pacific: doc/rados: edit user-management.rst (1 of x)

2 years agodoc/rados: edit user-management.rst (1 of x) 50642/head
Zac Dover [Thu, 23 Mar 2023 02:21:06 +0000 (12:21 +1000)]
doc/rados: edit user-management.rst (1 of x)

Edit doc/rados/operations/user-management.rst. (1 of x)

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 3f90958909815a287279eccb22193ba5d67cfc1d)

2 years agoMerge pull request #50620 from zdover23/wip-doc-2023-03-22-backport-50606-to-pacific
Anthony D'Atri [Wed, 22 Mar 2023 03:33:08 +0000 (23:33 -0400)]
Merge pull request #50620 from zdover23/wip-doc-2023-03-22-backport-50606-to-pacific

pacific: doc/rados: line-edit erasure-code.rst

2 years agodoc/rados: line-edit erasure-code.rst 50620/head
Zac Dover [Tue, 21 Mar 2023 12:27:15 +0000 (22:27 +1000)]
doc/rados: line-edit erasure-code.rst

Line-edit doc/rados/operations/erasure-code.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2ff9965e02756636f8d33fd96b7c909f2fca7414)

2 years agoMerge pull request #50591 from zdover23/wip-doc-2023-03-20-backport-50488-to-pacific
Anthony D'Atri [Mon, 20 Mar 2023 04:48:36 +0000 (00:48 -0400)]
Merge pull request #50591 from zdover23/wip-doc-2023-03-20-backport-50488-to-pacific

pacific: doc/rados: edit operations/bs-migration (2 of x)

2 years agoMerge pull request #50588 from zdover23/wip-doc-2023-03-20-backport-50487-to-pacific
Anthony D'Atri [Mon, 20 Mar 2023 04:46:35 +0000 (00:46 -0400)]
Merge pull request #50588 from zdover23/wip-doc-2023-03-20-backport-50487-to-pacific

pacific: doc/rados: edit operations/bs-migration (1 of x)

2 years agodoc/rados: edit operations/bs-migration (2 of x) 50591/head
Zac Dover [Sun, 12 Mar 2023 01:17:03 +0000 (11:17 +1000)]
doc/rados: edit operations/bs-migration (2 of x)

Disambiguate and improve the English language in
doc/rados/operations/bluestore-migration.rst up to but not including the
section called "Whole Host Replacement".

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ca803a24c64059023733e21d755edb9c6c973ecf)