]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc/dev: format command in cephfs-mirroring 51107/head
Zac Dover [Sun, 16 Apr 2023 09:11:27 +0000 (11:11 +0200)]
doc/dev: format command in cephfs-mirroring

Correctly format a command in doc/dev/cephfs-mirroring/#creating-users.

Reported by casanlin@init7.net at
https://pad.ceph.com/p/Report_Documentation_Bugs

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 408219bfca6b1e698229967e76d22d10028b7c20)

2 years agoMerge pull request #51104 from zdover23/wip-doc-2023-04-16-backport-51103-to-reef
colemitchell [Sun, 16 Apr 2023 14:43:15 +0000 (10:43 -0400)]
Merge pull request #51104 from zdover23/wip-doc-2023-04-16-backport-51103-to-reef

reef: doc/radosgw: format part of s3select

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/radosgw: format part of s3select 51104/head
Cole Mitchell [Sun, 16 Apr 2023 13:13:56 +0000 (09:13 -0400)]
doc/radosgw: format part of s3select

Format the first section of s3select. Nothing else is being fixed.

Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
(cherry picked from commit a6a84471a7af154e7ccc93f51df2fc9744dc606c)

2 years agoMerge pull request #51087 from zdover23/wip-doc-2023-04-15-backport-51086-to-reef
Anthony D'Atri [Sat, 15 Apr 2023 09:46:55 +0000 (11:46 +0200)]
Merge pull request #51087 from zdover23/wip-doc-2023-04-15-backport-51086-to-reef

reef: doc/rados/ops: remove ceph-medic from monitoring

2 years agodoc/rados/ops: remove ceph-medic from monitoring 51087/head
Zac Dover [Sat, 15 Apr 2023 07:42:31 +0000 (09:42 +0200)]
doc/rados/ops: remove ceph-medic from monitoring

Remove mention of ceph-medic from doc/rados/operations/monitoring.rst,
because it is no longer supported.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 42cd28a2a639e68a44838ae4e7f875cb6bd5d97b)

2 years agoMerge pull request #51010 from rhcs-dashboard/wip-59420-reef
Nizamudeen A [Fri, 14 Apr 2023 08:24:57 +0000 (13:54 +0530)]
Merge pull request #51010 from rhcs-dashboard/wip-59420-reef

reef: mgr/dashboard: fix eviction of all FS clients

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51063 from zdover23/wip-doc-2023-04-13-backport-50713-to-reef
Anthony D'Atri [Thu, 13 Apr 2023 12:32:26 +0000 (08:32 -0400)]
Merge pull request #51063 from zdover23/wip-doc-2023-04-13-backport-50713-to-reef

reef: doc/glossary: improve "CephX" entry

2 years agodoc/glossary: improve "CephX" entry 51063/head
Zac Dover [Tue, 28 Mar 2023 08:42:11 +0000 (18:42 +1000)]
doc/glossary: improve "CephX" entry

Improve the glossary entry for "CephX".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 02e3a5cb763987eeaee2dd1a7543d2762aaad7fe)

2 years agoMerge pull request #50919 from idryomov/wip-rbd-reef-backports-1
Ilya Dryomov [Thu, 13 Apr 2023 12:03:55 +0000 (14:03 +0200)]
Merge pull request #50919 from idryomov/wip-rbd-reef-backports-1

reef: RBD backports (batch 1)

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #51058 from rhcs-dashboard/wip-59436-reef
Nizamudeen A [Thu, 13 Apr 2023 10:10:20 +0000 (15:40 +0530)]
Merge pull request #51058 from rhcs-dashboard/wip-59436-reef

reef: mgr/dashboard: rbd-mirror force promotion

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoqa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu 50919/head
Ilya Dryomov [Tue, 11 Apr 2023 20:43:58 +0000 (22:43 +0200)]
qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

qemu-utils is usually pre-installed but, due to what appears to be
a Ubuntu packaging bug, it's not upgraded when qemu-block-extra is
installed:

  The following NEW packages will be installed:
    qemu-block-extra
  The following packages will be upgraded:
    qemu-system-common qemu-system-data qemu-system-gui qemu-system-x86

However, the version of the block driver must match exactly the version
of the qemu-img tool, so the above leads to:

  $ qemu-img convert -f qcow2 -O raw /home/ubuntu/cephtest/qemu/base.client.0.0.qcow2 rbd:rbd/client.0.0
  Failed to initialize module: /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
  Note: only modules from the same build can be loaded.
  qemu: module block-block-rbd not found, do you want to install qemu-block-extra package?
  qemu-img: Unknown protocol 'rbd'

Fixes: https://tracker.ceph.com/issues/59431
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit c529fdd63a5aae2c598078df05fe9bbef40042dc)

2 years agomgr/dashboard: rbd-mirror force promotion 51058/head
Pedro Gonzalez Gomez [Wed, 5 Apr 2023 15:42:52 +0000 (17:42 +0200)]
mgr/dashboard: rbd-mirror force promotion

resolves: https://tracker.ceph.com/issues/59327
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 9696b6a04830297c23c4cccd6e7c225f183ba0b2)

2 years agoMerge pull request #51035 from zdover23/wip-doc-2023-04-12-backport-50993-to-reef
zdover23 [Wed, 12 Apr 2023 09:41:54 +0000 (19:41 +1000)]
Merge pull request #51035 from zdover23/wip-doc-2023-04-12-backport-50993-to-reef

reef: doc/rados/operations: edit monitoring.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50994 from guits/cv-bkp-50473-reef
Guillaume Abrioux [Wed, 12 Apr 2023 07:58:53 +0000 (09:58 +0200)]
Merge pull request #50994 from guits/cv-bkp-50473-reef

ceph-volume: update the OS before deploying Ceph (reef)

2 years agodoc/rados/operations: edit monitoring.rst 51035/head
Zac Dover [Tue, 11 Apr 2023 04:15:47 +0000 (14:15 +1000)]
doc/rados/operations: edit monitoring.rst

Line-edit the final third of doc/rados/operations/monitoring.rst.

Follows https://github.com/ceph/ceph/pull/50834.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b9ccad80608953fc0af779e8cad93971d47649b6)

2 years agoMerge pull request #51006 from rhcs-dashboard/wip-59402-reef
Nizamudeen A [Tue, 11 Apr 2023 16:11:42 +0000 (21:41 +0530)]
Merge pull request #51006 from rhcs-dashboard/wip-59402-reef

reef: mgr/dashboard: fix create osd default selected as recommended not working

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 years agomgr/dashboard: fix eviction of all FS clients 51010/head
Pere Diaz Bou [Wed, 5 Apr 2023 16:54:45 +0000 (18:54 +0200)]
mgr/dashboard: fix eviction of all FS clients

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
(cherry picked from commit 780f49325aefd0b2c537462c6bb498232621ee8a)

2 years agoceph-volume/tests: fix an issue with rpm 50994/head
Guillaume Abrioux [Tue, 11 Apr 2023 11:29:15 +0000 (13:29 +0200)]
ceph-volume/tests: fix an issue with rpm

Typical error seen in the CI:

```
error: /var/cache/dnf/baseos-00fe51d07def85f0/packages/kernel-core-4.18.0-483.el8.x86_64.rpm: signature hdr data: BAD, no. of bytes(459772) out of range
```

Upgrading `rpm` fixes this issue.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 05aa334b96ed8a8c8497047bc26da64ee3a3d1fa)

2 years agomgr/dashboard: fix create osds step failing on the default option 51006/head
Nizamudeen A [Thu, 6 Apr 2023 06:37:20 +0000 (12:07 +0530)]
mgr/dashboard: fix create osds step failing on the default option

the backend was reporting with a keyError which doesn't find the
`encrypted` key.

Fixes: https://tracker.ceph.com/issues/59319
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit ca8b107cf2198ecf189b513ff75b9d5a9d9782b9)

2 years agomgr/dashboard: add option to skip the create OSDs step
Nizamudeen A [Wed, 5 Apr 2023 06:37:11 +0000 (12:07 +0530)]
mgr/dashboard: add option to skip the create OSDs step

Fixes: https://tracker.ceph.com/issues/59319
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit caa0c456b1d0c33f6abb847b3c9259501d587004)

2 years agoceph-volume: add bluefs_buffered_io: false in functional tests
Guillaume Abrioux [Fri, 10 Mar 2023 15:44:16 +0000 (16:44 +0100)]
ceph-volume: add bluefs_buffered_io: false in functional tests

This is a workaround to make dmcrypt scenarios pass the CI.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 491e88ede56b51bc425ba5e38adf6eb74ad5196e)

2 years agoceph-volume: update the OS before deploying Ceph
Guillaume Abrioux [Fri, 10 Mar 2023 15:01:19 +0000 (16:01 +0100)]
ceph-volume: update the OS before deploying Ceph

ceph-volume tests are failing, OSDs never get up and running.
For some reason, updating the OS early in the testing workflow
addresses that issue in the CI.

-- to be continued ... --

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 663c914c59873f433a5512aca0ebc4b4a7ef1fd3)

2 years agoMerge pull request #50955 from zdover23/wip-doc-2023-04-09-backport-50827-to-reef
colemitchell [Tue, 11 Apr 2023 01:04:56 +0000 (21:04 -0400)]
Merge pull request #50955 from zdover23/wip-doc-2023-04-09-backport-50827-to-reef

reef: doc/rados/ops: edit health-checks.rst (4 of x)

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agoMerge pull request #50966 from zdover23/wip-doc-2023-04-10-backport-50828-to-reef
Anthony D'Atri [Mon, 10 Apr 2023 11:48:40 +0000 (07:48 -0400)]
Merge pull request #50966 from zdover23/wip-doc-2023-04-10-backport-50828-to-reef

reef: doc/rados/ops: edit health checks.rst (5 of x)

2 years agoMerge pull request #50969 from zdover23/wip-doc-2023-04-10-backport-50829-to-reef
Anthony D'Atri [Mon, 10 Apr 2023 11:46:50 +0000 (07:46 -0400)]
Merge pull request #50969 from zdover23/wip-doc-2023-04-10-backport-50829-to-reef

reef: doc/rados/ops: edit health-checks.rst (6 of x)

2 years agodoc/rados/ops: edit health-checks.rst (6 of x) 50969/head
Zac Dover [Sat, 1 Apr 2023 20:39:32 +0000 (06:39 +1000)]
doc/rados/ops: edit health-checks.rst (6 of x)

Edit docs/rados/operations/health-checks.rst (6 of x).

Follows https://github.com/ceph/ceph/pull/50828.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c59bc152ea746a8bfc5795dbeb68b2ef6e511b1f)

2 years agodoc/rados/ops: edit health checks.rst (5 of x) 50966/head
Zac Dover [Sat, 1 Apr 2023 20:33:45 +0000 (06:33 +1000)]
doc/rados/ops: edit health checks.rst (5 of x)

Edit docs/rados/operations/health-checks.rst (5 of x).

Follows https://github.com/ceph/ceph/pull/50827

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cb8ec5b5ab8f5fb25c8f2c6404447dabe4ebd1ad)

2 years agoMerge pull request #50959 from zdover23/wip-doc-2023-04-09-backport-50958-to-reef
Anthony D'Atri [Sun, 9 Apr 2023 19:08:46 +0000 (15:08 -0400)]
Merge pull request #50959 from zdover23/wip-doc-2023-04-09-backport-50958-to-reef

reef: doc/rados/ops: add hyphen to mon-osd-pg.rst

2 years agodoc/rados/ops: add hyphen to mon-osd-pg.rst 50959/head
Zac Dover [Sun, 9 Apr 2023 02:42:11 +0000 (12:42 +1000)]
doc/rados/ops: add hyphen to mon-osd-pg.rst

Remove confusing parentheses and add a clearer (as compared to the
parentheses) hyphen (actually an em-dash, or at least it is intended
to be an em-dash) to doc/rados/operations/monitoring-osd-pg.rst

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0c965c18d0e6ab1461b5fad42d481f25e4207940)

2 years agoMerge pull request #50952 from zdover23/wip-doc-2023-04-09-backport-50826-to-reef
zdover23 [Sun, 9 Apr 2023 05:03:40 +0000 (15:03 +1000)]
Merge pull request #50952 from zdover23/wip-doc-2023-04-09-backport-50826-to-reef

reef: doc/rados/ops: edit health-checks.rst (3 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50949 from zdover23/wip-doc-2023-04-09-backport-50907-to-reef
zdover23 [Sun, 9 Apr 2023 05:03:09 +0000 (15:03 +1000)]
Merge pull request #50949 from zdover23/wip-doc-2023-04-09-backport-50907-to-reef

reef: doc/rados/config: edit auth-config-ref

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados/ops: edit health-checks.rst (4 of x) 50955/head
Zac Dover [Sat, 1 Apr 2023 20:25:42 +0000 (06:25 +1000)]
doc/rados/ops: edit health-checks.rst (4 of x)

Edit docs/rados/operations/health-checks.rst (4 of x).

Follows https://github.com/ceph/ceph/pull/50826.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 31df75356f2e49e0da6e0f4a6ec498e3609bd39e)

2 years agodoc/rados/ops: edit health-checks.rst (3 of x) 50952/head
Zac Dover [Sat, 1 Apr 2023 20:17:06 +0000 (06:17 +1000)]
doc/rados/ops: edit health-checks.rst (3 of x)

Edit docs/rados/operations/health-checks.rst (3 of x).

Follows https://github.com/ceph/ceph/pull/50825

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e02ddb24e583b5bedd4056ba0871a9427b581bfe)

2 years agodoc/rados/config: edit auth-config-ref 50949/head
Zac Dover [Thu, 6 Apr 2023 00:21:01 +0000 (10:21 +1000)]
doc/rados/config: edit auth-config-ref

Line edit doc/rados/config/auth-config-ref.rst.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 3d0acf9372a35ef48be47efe68192ec389c17ccb)

2 years agoMerge pull request #50945 from zdover23/wip-doc-2023-04-08-backport-50863-to-reef
zdover23 [Sat, 8 Apr 2023 04:53:55 +0000 (14:53 +1000)]
Merge pull request #50945 from zdover23/wip-doc-2023-04-08-backport-50863-to-reef

reef: doc/rados/ops: edit monitoring-osd-pg.rst (2 of x)

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agoMerge pull request #50942 from zdover23/wip-doc-2023-04-08-backport-50795-to-reef
zdover23 [Sat, 8 Apr 2023 04:13:30 +0000 (14:13 +1000)]
Merge pull request #50942 from zdover23/wip-doc-2023-04-08-backport-50795-to-reef

reef: doc/rados: line-edit common.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados/ops: edit monitoring-osd-pg.rst (2 of x) 50945/head
Zac Dover [Wed, 5 Apr 2023 03:32:43 +0000 (13:32 +1000)]
doc/rados/ops: edit monitoring-osd-pg.rst (2 of x)

Line-edit monitoring-osd-pg.rst (2 of x).

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 270e2fd730dad19d970d73ea19c6872defa9fce4)

2 years agodoc/rados: line-edit common.rst 50942/head
Zac Dover [Thu, 30 Mar 2023 22:54:05 +0000 (08:54 +1000)]
doc/rados: line-edit common.rst

Edit syntax and semantics in doc/configuration/common.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6c9f226742e951de6c40627271ba6d6cabba4535)

2 years agoMerge pull request #50933 from zdover23/wip-doc-2023-04-07-backport-50928-to-reef
Anthony D'Atri [Fri, 7 Apr 2023 11:25:37 +0000 (07:25 -0400)]
Merge pull request #50933 from zdover23/wip-doc-2023-04-07-backport-50928-to-reef

reef: doc/rados/ops: line-edit operating.rst

2 years agodoc/rados/ops: line-edit operating.rst 50933/head
Zac Dover [Fri, 7 Apr 2023 00:46:50 +0000 (10:46 +1000)]
doc/rados/ops: line-edit operating.rst

Line-edit doc/rados/operations/operating.rst.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bb8fc0068369369fd213062590738e38c9f4dc63)

2 years agoMerge pull request #50848 from zdover23/wip-doc-2023-04-04-backport-50834-to-reef
zdover23 [Fri, 7 Apr 2023 02:10:11 +0000 (12:10 +1000)]
Merge pull request #50848 from zdover23/wip-doc-2023-04-04-backport-50834-to-reef

reef: doc/rados: edit ops/monitoring.rst (2 of 3)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit ops/monitoring.rst (2 of 3) 50848/head
Zac Dover [Sun, 2 Apr 2023 22:03:29 +0000 (08:03 +1000)]
doc/rados: edit ops/monitoring.rst (2 of 3)

Line-edit the second third of doc/rados/operations/monitoring.rst.

Follows https://github.com/ceph/ceph/pull/50670.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 41684ebd33b5c9fe707f5a33b27c55ed29cd5ede)

2 years agoMerge pull request #50911 from zdover23/wip-doc-2023-04-06-backport-50825-to-reef
Anthony D'Atri [Thu, 6 Apr 2023 16:05:17 +0000 (12:05 -0400)]
Merge pull request #50911 from zdover23/wip-doc-2023-04-06-backport-50825-to-reef

reef: doc/rados/ops: edit health-checks.rst (2 of x)

2 years agolibrbd: avoid generating ESHUTDOWN in ManagedLock
Ilya Dryomov [Tue, 28 Mar 2023 18:03:05 +0000 (20:03 +0200)]
librbd: avoid generating ESHUTDOWN in ManagedLock

EBLOCKLISTED has a very special meaning but happens to be an alias for
ESHUTDOWN.  If the client gets blocklisted, we always want to propagate
EBLOCKLISTED error code since it's generated by the OSD.

For ManagedLock use case of indicating that an operation on the lock
raced with lock shut down, meaning that a higher level request can just
be restarted, ERESTART should do.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 76856d90e0e0d73276c06a724091197301f982e9)

2 years agolibrbd: fix recursive locking on owner_lock in ImageDispatch
Ilya Dryomov [Tue, 28 Mar 2023 17:52:42 +0000 (19:52 +0200)]
librbd: fix recursive locking on owner_lock in ImageDispatch

needs_exclusive_lock() calls acquire_lock() with owner_lock held.
If lock acquisiton races with lock shut down, ManagedLock completes
ImageDispatch context directly and dispatch is retried immediately on
the same thread (due to DISPATCH_RESULT_RESTART).  This results in
recursion into needs_exclusive_lock() and, barring locking issues, can
lead to unbounded stack growth if lock shut down takes its time.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1d943f8c47b3510e47d40701e9acd213706754e5)

2 years agotest/librados_test_stub: drop watches only after actually blocklisting
Ilya Dryomov [Tue, 4 Apr 2023 15:21:16 +0000 (17:21 +0200)]
test/librados_test_stub: drop watches only after actually blocklisting

Eliminate a race where a client is able to submit an operation after
WatchCtx2::handle_error() is invoked on its watch due to blocklisting.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit a14498eff645e9e154e4d1a3cc436453b8401d89)

2 years agotest/librados_test_stub: raise a watch error on blocklisting
Ilya Dryomov [Thu, 30 Mar 2023 16:22:24 +0000 (18:22 +0200)]
test/librados_test_stub: raise a watch error on blocklisting

Simulate getting MWatchNotify CEPH_WATCH_EVENT_DISCONNECT message after
the client is blocklisted.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0dfe87d3b6ed52cee6f6660b42af42a8dd7708bb)

2 years agolibrbd: Propagate EBLOCKLIST in send_acquire_lock
Christopher Hoffman [Tue, 21 Mar 2023 16:15:04 +0000 (16:15 +0000)]
librbd: Propagate EBLOCKLIST in send_acquire_lock

During send_acquire_lock, there's a case where
there's no watcher handle present and lock request is delayed.
If the client is blocklisted, the delayed request will not
continue and the call that requested lock will never complete.

The lock process will now propagate -EBLOCKLIST, to callback
instead of indefinitely delaying.

Fixes: https://tracker.ceph.com/issues/59115
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
(cherry picked from commit 6a0aeadc31ab1942c42c6e466183148f1d3752be)

2 years agoPendingReleaseNotes: add a note for rbd-mirror daemon perf counters
Ilya Dryomov [Thu, 6 Apr 2023 10:32:11 +0000 (12:32 +0200)]
PendingReleaseNotes: add a note for rbd-mirror daemon perf counters

This was missed in commit 1a1477b9fd7f ("rbd-mirror: add and rename
perf counters for journal and snapshot mirroring").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit e89f5815134fbeea4fa4894082c71a4ebd249794)

2 years agolibrbd: clear Image::list_watchers() list before populating it
Ilya Dryomov [Thu, 30 Mar 2023 11:58:20 +0000 (13:58 +0200)]
librbd: clear Image::list_watchers() list before populating it

The "append to the passed list" behavior is confusing and not what the
corresponding C API (rbd_watchers_list) or other similar C++ APIs (e.g.
list_lockers) do.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit e11097bc4cf82b997ad1e8e21a8cd9400767f40d)

2 years agolibrbd: fix wrong attribute for rbd_quiesce_complete api
Dongsheng Yang [Wed, 15 Mar 2023 06:54:39 +0000 (06:54 +0000)]
librbd: fix wrong attribute for rbd_quiesce_complete api

When we use rbd_quiesce_complete api, we got an error:
/usr/bin/ld: undefined reference to `rbd_quiesce_complete'

Then we found the problem is the symbol of rbd_quiesce_complete
in librbd.so is LOCAL. After some investigation, we found
the attribute of rbd_quiesce_complete api is CEPH_RADOS_API
rather than expected CEPH_RBD_API.

Fixes: https://tracker.ceph.com/issues/59208
Signed-off-by: Dongsheng Yang <dongsheng.yang.linux@gmail.com>
(cherry picked from commit 51a2b707a3074e000b310fc20901d5038b15ea0c)

2 years agorbd: improve log msgs when failing to enable mirroring on image
Prasanna Kumar Kalever [Thu, 2 Mar 2023 10:29:19 +0000 (15:59 +0530)]
rbd: improve log msgs when failing to enable mirroring on image

Attempting to enable mirroring on an an image within a namespace bails
out without any useful msg.

$ rbd mirror image enable mi_pool/ns_0/big snapshot
2021-11-17T08:33:21.321+0000 7f4b36f9c2c0 -1 librbd::api::Mirror:
  image_enable: cannot enable mirroring in the current pool mirroring mode

Fixes: https://tracker.ceph.com/issues/58895
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
(cherry picked from commit 828a0dea2d40ba0c1aa0a9d4b211f0fabc854350)

2 years agodoc/rados/ops: edit health-checks.rst (2 of x) 50911/head
Zac Dover [Sat, 1 Apr 2023 20:05:41 +0000 (06:05 +1000)]
doc/rados/ops: edit health-checks.rst (2 of x)

Edit docs/rados/operations/health-checks.rst (2 of x). PR#50674, the PR
that immediately precedes this PR in the series of PRs that line-edit
health-checks.rst, wrongly identified this series as having five
sections. This has been rectified by using the "2 of x" formulation.

Follows https://github.com/ceph/ceph/pull/50674

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0565f59698e9d00adf5a4667ac6e84e97d31b554)

2 years agoMerge pull request #50869 from rhcs-dashboard/wip-59323-reef
Nizamudeen A [Wed, 5 Apr 2023 17:41:26 +0000 (23:11 +0530)]
Merge pull request #50869 from rhcs-dashboard/wip-59323-reef

reef: mgr/dashboard: fix displaying mirror image progress

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50864 from zdover23/wip-doc-2023-04-05-backport-50855-to-reef
Anthony D'Atri [Wed, 5 Apr 2023 13:25:12 +0000 (09:25 -0400)]
Merge pull request #50864 from zdover23/wip-doc-2023-04-05-backport-50855-to-reef

reef: doc/rados/ops: edit monitoring-osd-pg.rst (1 of x)

2 years agomgr/dashboard: fix displaying mirror image progress 50869/head
Pere Diaz Bou [Mon, 3 Apr 2023 15:22:35 +0000 (17:22 +0200)]
mgr/dashboard: fix displaying mirror image progress

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
(cherry picked from commit 80960387fbb6d49c3681f4c9e249c441a891462a)

2 years agodoc/rados/ops: edit monitoring-osd-pg.rst (1 of x) 50864/head
Zac Dover [Tue, 4 Apr 2023 03:29:15 +0000 (13:29 +1000)]
doc/rados/ops: edit monitoring-osd-pg.rst (1 of x)

Line-edit doc/rados/operations/monitoring-osd-pg.rst (1 of x).

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bd213c244e8a387c98358ac41f4802e102e89c63)

2 years agoMerge pull request #50852 from zdover23/wip-doc-2023-04-04-backport-50851-to-reef
Anthony D'Atri [Mon, 3 Apr 2023 22:22:03 +0000 (18:22 -0400)]
Merge pull request #50852 from zdover23/wip-doc-2023-04-04-backport-50851-to-reef

reef: doc/rados/ops: add ceph-medic documentation

2 years agodoc/rados/ops: add ceph-medic documentation 50852/head
Zac Dover [Mon, 3 Apr 2023 20:57:27 +0000 (06:57 +1000)]
doc/rados/ops: add ceph-medic documentation

Add a link to the ceph-medic documentation to
doc/rados/operations/monitoring.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b2a409da26b508e5a51e3becbce16b7ecaffcc1d)

2 years agoMerge pull request #50758 from ceph/wip-yuriw-fix-upgrades-reef
Yuri Weinstein [Mon, 3 Apr 2023 18:30:33 +0000 (11:30 -0700)]
Merge pull request #50758 from ceph/wip-yuriw-fix-upgrades-reef

qa/upgrade: consistently use the tip of the branch as the start version

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoqa/upgrade: consistently use the tip of the branch as the start version 50758/head
Yuri Weinstein [Wed, 29 Mar 2023 21:18:00 +0000 (14:18 -0700)]
qa/upgrade: consistently use the tip of the branch as the start version

Also corrected line to use `image: quay.ceph.io/ceph-ci/ceph:*`
In order to make sure that latest versions of ceph is used as initial install

Fixes: https://tracker.ceph.com/issues/58914
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2 years agoMerge pull request #50830 from zdover23/wip-doc-2023-04-02-backport-50818-to-reef
Anthony D'Atri [Sun, 2 Apr 2023 12:59:19 +0000 (08:59 -0400)]
Merge pull request #50830 from zdover23/wip-doc-2023-04-02-backport-50818-to-reef

reef: doc/cephfs: Improve fs-volumes.rst

2 years agodoc/cephfs: Improve fs-volumes.rst 50830/head
Anthony D'Atri [Fri, 31 Mar 2023 13:37:52 +0000 (09:37 -0400)]
doc/cephfs: Improve fs-volumes.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit c8e1f3ac3db513004fbfbb0049757ddc2bca291a)

2 years agoMerge pull request #50481 from ljflores/wip-tracker-58050-reef
Yuri Weinstein [Fri, 31 Mar 2023 22:43:02 +0000 (15:43 -0700)]
Merge pull request #50481 from ljflores/wip-tracker-58050-reef

reef: mgr/telemetry: make sure histograms are formatted in `all` commands

Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
2 years agoMerge pull request #50475 from rzarzynski/wip-aclamk-harmonize-bluefs-log-reef
Yuri Weinstein [Fri, 31 Mar 2023 22:41:46 +0000 (15:41 -0700)]
Merge pull request #50475 from rzarzynski/wip-aclamk-harmonize-bluefs-log-reef

reef: os/bluestore: BlueFS: harmonize log read and writes modes

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #50822 from zdover23/wip-doc-2023-04-01-backport-50670-to-reef
Anthony D'Atri [Fri, 31 Mar 2023 20:04:37 +0000 (16:04 -0400)]
Merge pull request #50822 from zdover23/wip-doc-2023-04-01-backport-50670-to-reef

reef: doc/rados: edit ops/monitoring.rst (1 of 3)

2 years agodoc/rados: edit ops/monitoring.rst (1 of 3) 50822/head
Zac Dover [Sat, 25 Mar 2023 18:51:50 +0000 (04:51 +1000)]
doc/rados: edit ops/monitoring.rst (1 of 3)

Line-edit the first third of doc/rados/operations/monitoring.rst.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bc5f404a7876f887d0c7a2dedee5391f66ab0505)

2 years agoMerge pull request #50799 from zdover23/wip-doc-2023-03-31-backport-45354-to-reef
Anthony D'Atri [Fri, 31 Mar 2023 13:57:47 +0000 (09:57 -0400)]
Merge pull request #50799 from zdover23/wip-doc-2023-03-31-backport-45354-to-reef

reef: doc/msgr2: update dual stack status

2 years agoMerge pull request #50802 from zdover23/wip-doc-2023-03-31-backport-50554-to-reef
Anthony D'Atri [Fri, 31 Mar 2023 13:53:49 +0000 (09:53 -0400)]
Merge pull request #50802 from zdover23/wip-doc-2023-03-31-backport-50554-to-reef

reef: doc/rados: line-edit pg-repair.rst

2 years agodoc/rados: line-edit pg-repair.rst 50802/head
Zac Dover [Thu, 16 Mar 2023 02:27:44 +0000 (12:27 +1000)]
doc/rados: line-edit pg-repair.rst

Line edit pg-repair.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b7c19dac2dfdcbc50515e83d952fb25070496c1c)

2 years agodoc/msgr2: update dual stack status 50799/head
Dan van der Ster [Fri, 11 Mar 2022 14:15:20 +0000 (15:15 +0100)]
doc/msgr2: update dual stack status

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit c7eaeb4dff1fca967046bcd9b53548eabd18012e)

2 years agoMerge pull request #50796 from zdover23/wip-doc-2023-03-31-backport-50674-to-reef
Anthony D'Atri [Thu, 30 Mar 2023 23:56:30 +0000 (19:56 -0400)]
Merge pull request #50796 from zdover23/wip-doc-2023-03-31-backport-50674-to-reef

reef: doc/rados/ops: edit health-checks.rst (1 of x)

2 years agodoc/rados/ops: edit health-checks.rst (1 of x) 50796/head
Zac Dover [Sat, 25 Mar 2023 20:02:19 +0000 (06:02 +1000)]
doc/rados/ops: edit health-checks.rst (1 of x)

Edit docs/rados/operations/health-checks.rst (1 of x).

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cb1e20f879edb82ae619693a4f1f5e88fd0593dd)

2 years agoMerge pull request #50769 from zdover23/wip-doc-2023-03-30-backport-50742-to-reef
zdover23 [Thu, 30 Mar 2023 07:16:12 +0000 (17:16 +1000)]
Merge pull request #50769 from zdover23/wip-doc-2023-03-30-backport-50742-to-reef

reef: doc/start: update "notify us" section

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #50787 from zdover23/wip-doc-2023-03-30-backport-50764-to-reef
zdover23 [Thu, 30 Mar 2023 07:15:11 +0000 (17:15 +1000)]
Merge pull request #50787 from zdover23/wip-doc-2023-03-30-backport-50764-to-reef

reef: doc/start: format procedure in documenting-ceph

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50609 from rhcs-dashboard/wip-59094-reef
Nizamudeen A [Thu, 30 Mar 2023 06:43:43 +0000 (12:13 +0530)]
Merge pull request #50609 from rhcs-dashboard/wip-59094-reef

reef: mgr/dashboard: add button toggle to switch between landing pages

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agodoc/start: format procedure in documenting-ceph 50787/head
Zac Dover [Thu, 30 Mar 2023 00:54:52 +0000 (10:54 +1000)]
doc/start: format procedure in documenting-ceph

Organize three steps in a procedure into one step with three sub-steps.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6f3cd78f6116f3e19a8f6c5e0ebda816067a334e)

2 years agoMerge pull request #50604 from neesingh-rh/wip-59912-reef
Venky Shankar [Thu, 30 Mar 2023 02:45:14 +0000 (08:15 +0530)]
Merge pull request #50604 from neesingh-rh/wip-59912-reef

reef: cephfs-top: Handle METRIC_TYPE_NONE fields for sorting

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agodoc/start: update "notify us" section 50769/head
Zac Dover [Wed, 29 Mar 2023 13:47:38 +0000 (23:47 +1000)]
doc/start: update "notify us" section

Rewrite the "Notify Us" section in doc/start/documenting-ceph.rst so
that it is written in English sentences.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 613ece24777c4b222054fe9a6d82ba51949c45ea)

2 years agoMerge pull request #50761 from zdover23/wip-doc-2023-03-30-backport-50744-to-reef
Anthony D'Atri [Wed, 29 Mar 2023 22:31:32 +0000 (18:31 -0400)]
Merge pull request #50761 from zdover23/wip-doc-2023-03-30-backport-50744-to-reef

reef: doc/rados: add link to ops/health-checks.rst

2 years agodoc/rados: add link to ops/health-checks.rst 50761/head
Zac Dover [Wed, 29 Mar 2023 14:25:23 +0000 (00:25 +1000)]
doc/rados: add link to ops/health-checks.rst

Add an internal navigation link to
doc/rados/operations/health-checks.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f2f968f65bd1f1a6975fd340c66703cea335dcf6)
(cherry picked from commit 1ddc2b410258449e5d89a415a0494da2b8a79060)

2 years agoMerge pull request #50751 from zdover23/wip-doc-2023-03-30-backport-50750-to-reef
Anthony D'Atri [Wed, 29 Mar 2023 19:33:23 +0000 (15:33 -0400)]
Merge pull request #50751 from zdover23/wip-doc-2023-03-30-backport-50750-to-reef

reef: doc/rados/operations: Fix typo in erasure-code.rst

2 years agodoc/rados/operations: Fix typo in erasure-code.rst 50751/head
SAINITHIN.ARTHAM [Wed, 29 Mar 2023 18:16:32 +0000 (23:46 +0530)]
doc/rados/operations: Fix typo in erasure-code.rst

Signed-off-by: Sainithin Artham <sai.artham.19cse@bmu.edu.in>
(cherry picked from commit 3269fea2a209928137e55db16328c581988c048a)

2 years agoMerge pull request #50739 from zdover23/wip-doc-2023-03-29-backport-50723-to-reef
Anthony D'Atri [Wed, 29 Mar 2023 14:16:26 +0000 (10:16 -0400)]
Merge pull request #50739 from zdover23/wip-doc-2023-03-29-backport-50723-to-reef

reef: doc/start: documenting-ceph - add squash procedure

2 years agodoc/start: documenting-ceph - add squash procedure 50739/head
Zac Dover [Tue, 28 Mar 2023 09:29:40 +0000 (19:29 +1000)]
doc/start: documenting-ceph - add squash procedure

Add a procedure to doc/start/documenting-ceph.rst that explains how to
perform an interactive rebase to squash commits.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 71ee225d7b8bf54bd190a8b1f2422c6837601f16)

2 years agoMerge pull request #50701 from zdover23/wip-doc-2023-03-28-backport-50697-to-reef 50710/head
Anthony D'Atri [Tue, 28 Mar 2023 02:45:03 +0000 (22:45 -0400)]
Merge pull request #50701 from zdover23/wip-doc-2023-03-28-backport-50697-to-reef

reef: doc/glossary: add "Scrubbing"

2 years agodoc/glossary: add "Scrubbing" 50701/head
Zac Dover [Mon, 27 Mar 2023 20:48:32 +0000 (06:48 +1000)]
doc/glossary: add "Scrubbing"

Add "Scrubbing" to the glossary.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4a66819da48cee430ca74830e1a6f63685b6b240)

2 years agoMerge pull request #50484 from cbodley/wip-58932-reef
Yuri Weinstein [Mon, 27 Mar 2023 19:51:00 +0000 (12:51 -0700)]
Merge pull request #50484 from cbodley/wip-58932-reef

reef: rgw/admin: 'bucket stats' displays non-empty time

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #50688 from weirdwiz/wip-59175-reef
Ilya Dryomov [Mon, 27 Mar 2023 16:41:54 +0000 (18:41 +0200)]
Merge pull request #50688 from weirdwiz/wip-59175-reef

reef: rbd-mirror: switch to labeled perf counters

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agorbd-mirror: add and rename perf counters for journal and snapshot mirroring 50688/head
Divyansh Kamboj [Fri, 17 Mar 2023 09:19:14 +0000 (14:49 +0530)]
rbd-mirror: add and rename perf counters for journal and snapshot mirroring

This commit renames the existing snapshot and journal based performance
counters in the rbd-mirror daemon to better reflect their purpose.
Additionally, new perf counters have been added to provide more detailed
information about the synchronization of snapshots between the source
and destination clusters.

This commit also switches to use labels instead of having the image spec
in the name of the counter.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
(cherry picked from commit 1a1477b9fd7f3fcf7eb66c8a768476bea1322d1d)

2 years agoMerge pull request #50677 from zdover23/wip-doc-2023-03-27-backport-50675-to-reef
Anthony D'Atri [Sun, 26 Mar 2023 19:33:04 +0000 (15:33 -0400)]
Merge pull request #50677 from zdover23/wip-doc-2023-03-27-backport-50675-to-reef

reef: doc/rados: clean up ops/bluestore-migration.rst

2 years agodoc/rados: clean up ops/bluestore-migration.rst 50677/head
Zac Dover [Sun, 26 Mar 2023 15:03:58 +0000 (01:03 +1000)]
doc/rados: clean up ops/bluestore-migration.rst

Clean up internal links, fix the numbering of a procedure, and implement
Anthony D'Atri's suggestions in
https://github.com/ceph/ceph/pull/50487 and
https://github.com/ceph/ceph/pull/50488.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b28be76d0f9a5d78943fe3c583a234d0b50356f1)

2 years agoMerge pull request #50656 from petrutlucian94/wip-59161-reef
Ilya Dryomov [Sun, 26 Mar 2023 19:00:26 +0000 (21:00 +0200)]
Merge pull request #50656 from petrutlucian94/wip-59161-reef

reef: rbd-wnbd: optionally handle wnbd adapter restart events

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50671 from zdover23/wip-doc-2023-03-26-backport-50654-to-reef
colemitchell [Sat, 25 Mar 2023 19:56:08 +0000 (15:56 -0400)]
Merge pull request #50671 from zdover23/wip-doc-2023-03-26-backport-50654-to-reef

reef: doc/glossary: add "User"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/glossary: add "User" 50671/head
Zac Dover [Fri, 24 Mar 2023 10:56:51 +0000 (20:56 +1000)]
doc/glossary: add "User"

Add "User" to glossary.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fd6bfaf3fe6337511dd7ab344c2936f22a5d43bf)

2 years agoMerge pull request #50661 from zdover23/wip-doc-2023-03-25-backport-50660-to-reef
Anthony D'Atri [Fri, 24 Mar 2023 18:52:38 +0000 (14:52 -0400)]
Merge pull request #50661 from zdover23/wip-doc-2023-03-25-backport-50660-to-reef

reef: doc/operations: fix prompt in bluestore-migration

2 years agodoc/operations: fix prompt in bluestore-migration 50661/head
Zac Dover [Fri, 24 Mar 2023 17:47:10 +0000 (03:47 +1000)]
doc/operations: fix prompt in bluestore-migration

Fix a single prompt in bluestore-migration.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5e54641aec134188c8001e212ea66c1a15d5945c)

2 years agoMerge pull request #50629 from mkogan1/wip-59126-reef
Yuri Weinstein [Fri, 24 Mar 2023 16:40:43 +0000 (09:40 -0700)]
Merge pull request #50629 from mkogan1/wip-59126-reef

reef: rgw : fix python script using s3cmd with error code 403

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #50603 from mkogan1/wip-59004-reef
Yuri Weinstein [Fri, 24 Mar 2023 16:40:13 +0000 (09:40 -0700)]
Merge pull request #50603 from mkogan1/wip-59004-reef

reef: qa: d3n: fix test failure when "inline_data": false

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #50577 from cbodley/wip-qa-reef-ubuntu22
Yuri Weinstein [Fri, 24 Mar 2023 16:39:40 +0000 (09:39 -0700)]
Merge pull request #50577 from cbodley/wip-qa-reef-ubuntu22

reef: qa/distros: add ubuntu 22 as supported distro

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>