]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agomgr/dashboard: ignore Details card in applitools vrt 51153/head
Nizamudeen A [Thu, 20 Apr 2023 07:35:46 +0000 (13:05 +0530)]
mgr/dashboard: ignore Details card in applitools vrt

because the details card includes the FSID and Ceph Version which can
change on different clusters.

also don't run the 800x600 resolution because for new dashboard it looks
really weird.

Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51140 from zdover23/wip-doc-2023-04-18-rados-operations-2-of-x
zdover23 [Thu, 20 Apr 2023 06:18:04 +0000 (08:18 +0200)]
Merge pull request #51140 from zdover23/wip-doc-2023-04-18-rados-operations-2-of-x

doc/rados: edit user-management (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit user-management (2 of x) 51140/head
Zac Dover [Tue, 18 Apr 2023 20:59:09 +0000 (22:59 +0200)]
doc/rados: edit user-management (2 of x)

Line-edit doc/rados/user-management.rst (2 of x). Some internal
references had to be removed, but these will be repaired when the next
part of this file is updated in a future PR.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51143 from NitzanMordhai/wip-nitzan-filestore-removal-docs-update
zdover23 [Thu, 20 Apr 2023 05:42:58 +0000 (07:42 +0200)]
Merge pull request #51143 from NitzanMordhai/wip-nitzan-filestore-removal-docs-update

docs: warning and remove few docs section for Filestore

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodocs: warning and remove few docs section for Filestore 51143/head
Nitzan Mordechai [Sun, 19 Feb 2023 11:33:51 +0000 (11:33 +0000)]
docs: warning and remove few docs section for Filestore
Update docs after filestore removal.

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
2 years agoMerge pull request #51068 from cbodley/wip-59269
Casey Bodley [Wed, 19 Apr 2023 16:43:53 +0000 (12:43 -0400)]
Merge pull request #51068 from cbodley/wip-59269

cmake/rgw: librgw tests depend on ALLOC_LIBS

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #51031 from cbodley/wip-59423
Casey Bodley [Wed, 19 Apr 2023 15:36:15 +0000 (11:36 -0400)]
Merge pull request #51031 from cbodley/wip-59423

rgw/aio: fix recursion from tracing changes

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #50975 from yuvalif/wip-yuval-fix-59381
Yuval Lifshitz [Wed, 19 Apr 2023 13:30:29 +0000 (16:30 +0300)]
Merge pull request #50975 from yuvalif/wip-yuval-fix-59381

rgw/lua: fix CopyFrom crash

2 years agoMerge pull request #50965 from yuvalif/wip-yuval-fix-59383
Yuval Lifshitz [Wed, 19 Apr 2023 13:29:50 +0000 (16:29 +0300)]
Merge pull request #50965 from yuvalif/wip-yuval-fix-59383

rgw/kafka: failed to reconnect to broker after idle timeout

2 years agoMerge pull request #50918 from rhcs-dashboard/delete-ceph-authx
Nizamudeen A [Wed, 19 Apr 2023 07:40:57 +0000 (13:10 +0530)]
Merge pull request #50918 from rhcs-dashboard/delete-ceph-authx

mgr/dashboard: delete-ceph-authx

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge PR #50089 into main
Venky Shankar [Wed, 19 Apr 2023 06:00:54 +0000 (11:30 +0530)]
Merge PR #50089 into main

* refs/pull/50089/head:
doc: add a note for minimum compatible python version and supported distros
tools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephfs-top

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoMerge pull request #50916 from petrutlucian94/avoid_pip
Ilya Dryomov [Tue, 18 Apr 2023 11:49:41 +0000 (13:49 +0200)]
Merge pull request #50916 from petrutlucian94/avoid_pip

win32_deps_build: avoid pip

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agodoc: add a note for minimum compatible python version and supported distros 50089/head
Jos Collin [Thu, 23 Feb 2023 10:03:59 +0000 (15:33 +0530)]
doc: add a note for minimum compatible python version and supported distros

Fixes: https://tracker.ceph.com/issues/58677
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agotools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephf...
Jos Collin [Wed, 22 Feb 2023 12:24:22 +0000 (17:54 +0530)]
tools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephfs-top

Fixes: https://tracker.ceph.com/issues/58677
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agowin32_deps_build: avoid pip 50916/head
Lucian Petrut [Thu, 6 Apr 2023 11:05:47 +0000 (11:05 +0000)]
win32_deps_build: avoid pip

We're currently installing cython with pip when using Ubuntu
to cross compile Ceph for Windows. This can fail with recent
Python versions if attempting to use the global env:

  error: externally-managed-environment

  × This environment is externally managed
  ╰─> To install Python packages system-wide, try apt install
      python3-xyz, where xyz is the package you are trying to
      install.

Cython isn't really needed by the Windows build so we can go
ahead and drop it. We were hoping to use the Python bindings
on Windows, however Python extensions can't be cross compiled.

We're no longer using pip either, so we're dropping the dependency.
g++ was getting installed as a pip dependency, so we'll have to
include that instead. Note that g++ is used when building the boost
b2 tool.

While at it, we'll also ensure that git is installed.

Fixes: https://tracker.ceph.com/issues/59354
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoMerge pull request #50639 from bitfehler/bitfehler/doc-pg-num
Anthony D'Atri [Mon, 17 Apr 2023 20:58:51 +0000 (22:58 +0200)]
Merge pull request #50639 from bitfehler/bitfehler/doc-pg-num

doc: account for PG autoscaling being the default

2 years agoMerge pull request #51043 from petrutlucian94/fix_jaeger_encoding
Ilya Dryomov [Mon, 17 Apr 2023 16:58:00 +0000 (18:58 +0200)]
Merge pull request #51043 from petrutlucian94/fix_jaeger_encoding

common/tracer: fix decoding when jaeger tracing is disabled

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #49762 from Svelar/vstart2
zdover23 [Mon, 17 Apr 2023 16:42:34 +0000 (18:42 +0200)]
Merge pull request #49762 from Svelar/vstart2

vstart: fix text format

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50820 from rhcs-dashboard/update-landing-page-e2e-tests
Nizamudeen A [Mon, 17 Apr 2023 13:37:44 +0000 (19:07 +0530)]
Merge pull request #50820 from rhcs-dashboard/update-landing-page-e2e-tests

mgr/dashboard: update landing page e2e tests

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51082 from rhcs-dashboard/skip-osds-conditionally-in-e2e
Nizamudeen A [Mon, 17 Apr 2023 13:35:59 +0000 (19:05 +0530)]
Merge pull request #51082 from rhcs-dashboard/skip-osds-conditionally-in-e2e

mgr/dashboard: skip Create OSDs step in Cluster expansion

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51115 from rhcs-dashboard/remove-hyperlink-mgr
Nizamudeen A [Mon, 17 Apr 2023 13:35:16 +0000 (19:05 +0530)]
Merge pull request #51115 from rhcs-dashboard/remove-hyperlink-mgr

mgr/dashboard: remove unncessary hyperlink in landing page

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51114 from colemitchell/wip-doc-2023-04-17-radosgw-s3select-forma...
zdover23 [Mon, 17 Apr 2023 10:07:57 +0000 (12:07 +0200)]
Merge pull request #51114 from colemitchell/wip-doc-2023-04-17-radosgw-s3select-formatting-1

doc/radosgw: format part of s3select

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/radosgw: format part of s3select 51114/head
Cole Mitchell [Mon, 17 Apr 2023 09:34:49 +0000 (05:34 -0400)]
doc/radosgw: format part of s3select

Partially format the 'Basic Workflow' section's introduction and 'Basic Functionalities' subsection in s3select. Nothing else is being fixed.

Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agomgr/dashboard: remove unncessary hyperlink in landing page 51115/head
Nizamudeen A [Mon, 17 Apr 2023 09:38:06 +0000 (15:08 +0530)]
mgr/dashboard: remove unncessary hyperlink in landing page

Fixes: https://tracker.ceph.com/issues/59462
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #48869 from rhcs-dashboard/more-grafana-configs
Nizamudeen A [Mon, 17 Apr 2023 07:01:56 +0000 (12:31 +0530)]
Merge pull request #48869 from rhcs-dashboard/more-grafana-configs

mgr/dashboard: expose more grafana configs in service form

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agomgr/dashboard: update landing page e2e tests 50820/head
Pedro Gonzalez Gomez [Fri, 31 Mar 2023 17:51:16 +0000 (19:51 +0200)]
mgr/dashboard: update landing page e2e tests

ignore the region that can vary on different clusters like charts

fixes: https://tracker.ceph.com/issues/59142
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: skip Create OSDs step in Cluster expansion 51082/head
Nizamudeen A [Fri, 14 Apr 2023 19:33:11 +0000 (01:03 +0530)]
mgr/dashboard: skip Create OSDs step in Cluster expansion

Its to ensure OSDs are not deployed on all hosts because that would make
the host draining impossible

Fixes: https://tracker.ceph.com/issues/59457
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge PR #50941 into main
Patrick Donnelly [Sun, 16 Apr 2023 15:34:35 +0000 (11:34 -0400)]
Merge PR #50941 into main

* refs/pull/50941/head:
doc/foundation: Update Foundation members for April 2023

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #51103 from colemitchell/wip-doc-2023-04-16-radosgw-s3select-forma...
zdover23 [Sun, 16 Apr 2023 13:48:32 +0000 (15:48 +0200)]
Merge pull request #51103 from colemitchell/wip-doc-2023-04-16-radosgw-s3select-formatting-1

doc/radosgw: format part of s3select

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/radosgw: format part of s3select 51103/head
Cole Mitchell [Sun, 16 Apr 2023 13:13:56 +0000 (09:13 -0400)]
doc/radosgw: format part of s3select

Format the first section of s3select. Nothing else is being fixed.

Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agoMerge pull request #51099 from zdover23/wip-doc-2023-04-16-dev-cephfs-mirroring-creat...
Anthony D'Atri [Sun, 16 Apr 2023 12:39:53 +0000 (14:39 +0200)]
Merge pull request #51099 from zdover23/wip-doc-2023-04-16-dev-cephfs-mirroring-creating-users-command-formatting

doc/dev: format command in cephfs-mirroring

2 years agodoc/dev: format command in cephfs-mirroring 51099/head
Zac Dover [Sun, 16 Apr 2023 09:11:27 +0000 (11:11 +0200)]
doc/dev: format command in cephfs-mirroring

Correctly format a command in doc/dev/cephfs-mirroring/#creating-users.

Reported by casanlin@init7.net at
https://pad.ceph.com/p/Report_Documentation_Bugs

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51062 from zdover23/wip-doc-2023-04-13-glossary-hybrid-storage
zdover23 [Sun, 16 Apr 2023 06:58:41 +0000 (08:58 +0200)]
Merge pull request #51062 from zdover23/wip-doc-2023-04-13-glossary-hybrid-storage

doc/glossary: add "Hybrid Storage"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary: add "Hybrid Storage" 51062/head
Zac Dover [Thu, 13 Apr 2023 12:01:44 +0000 (14:01 +0200)]
doc/glossary: add "Hybrid Storage"

Add "Hybrid Storage" to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51091 from cityofships/fix_confval
Anthony D'Atri [Sat, 15 Apr 2023 22:03:37 +0000 (00:03 +0200)]
Merge pull request #51091 from cityofships/fix_confval

doc/mgr/prometheus: fix confval reference

2 years agodoc/mgr/prometheus: fix confval reference 51091/head
Piotr Parczewski [Sat, 15 Apr 2023 21:16:35 +0000 (23:16 +0200)]
doc/mgr/prometheus: fix confval reference

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
2 years agoMerge pull request #51086 from zdover23/wip-doc-2023-04-15-rados-ops-ceph-medic-removal
Anthony D'Atri [Sat, 15 Apr 2023 09:01:02 +0000 (05:01 -0400)]
Merge pull request #51086 from zdover23/wip-doc-2023-04-15-rados-ops-ceph-medic-removal

doc/rados/ops: remove ceph-medic from monitoring

2 years agodoc/rados/ops: remove ceph-medic from monitoring 51086/head
Zac Dover [Sat, 15 Apr 2023 07:42:31 +0000 (09:42 +0200)]
doc/rados/ops: remove ceph-medic from monitoring

Remove mention of ceph-medic from doc/rados/operations/monitoring.rst,
because it is no longer supported.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agomgr/dashboard: expose more grafana configs in service form 48869/head
Nizamudeen A [Mon, 14 Nov 2022 02:20:54 +0000 (07:50 +0530)]
mgr/dashboard: expose more grafana configs in service form

Show the grafana_port and initial_admin_password in the form but disable
the password field in the edit option

Fixes: https://tracker.ceph.com/issues/58016
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51074 from rhcs-dashboard/expression-changed-e2e
Nizamudeen A [Fri, 14 Apr 2023 18:27:11 +0000 (23:57 +0530)]
Merge pull request #51074 from rhcs-dashboard/expression-changed-e2e

mgr/dashboard: fix cephadm e2e expression changed error

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #51055 from ceph/wip-yuriw-release-16.2.12-main
Yuri Weinstein [Fri, 14 Apr 2023 16:23:26 +0000 (09:23 -0700)]
Merge pull request #51055 from ceph/wip-yuriw-release-16.2.12-main

doc: 16.2.12 Release Notes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Adam King adking@redhat.com
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge PR #50909 into main
Venky Shankar [Fri, 14 Apr 2023 10:29:12 +0000 (15:59 +0530)]
Merge PR #50909 into main

* refs/pull/50909/head:
qa/workunit: print the detail commands excuted in the scripts

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agomgr/dashboard: delete-ceph-authx 50918/head
Pedro Gonzalez Gomez [Thu, 6 Apr 2023 14:18:41 +0000 (16:18 +0200)]
mgr/dashboard: delete-ceph-authx

Fixes: https://tracker.ceph.com/issues/59365
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #49531 from rhcs-dashboard/fix-rbd-snapshot-creation
Nizamudeen A [Fri, 14 Apr 2023 06:36:05 +0000 (12:06 +0530)]
Merge pull request #49531 from rhcs-dashboard/fix-rbd-snapshot-creation

mgr/dashboard: Fix rbd snapshot creation

Reviewed-by: VasishtaShastry <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2 years agomgr/dashboard: fix cephadm e2e expression changed error 51074/head
Nizamudeen A [Fri, 14 Apr 2023 06:03:16 +0000 (11:33 +0530)]
mgr/dashboard: fix cephadm e2e expression changed error

tried to fix this issue from the daemon component sometime ago several
times but it didn't work. So force ignoring the error

Fixes: https://tracker.ceph.com/issues/59444
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50939 from pkalever/logging_improve
Ilya Dryomov [Thu, 13 Apr 2023 18:21:27 +0000 (20:21 +0200)]
Merge pull request #50939 from pkalever/logging_improve

librbd: on notify_quiesce() show attempts in a better format

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agocmake/rgw: librgw tests depend on ALLOC_LIBS 51068/head
Casey Bodley [Thu, 13 Apr 2023 16:26:44 +0000 (09:26 -0700)]
cmake/rgw: librgw tests depend on ALLOC_LIBS

somehow this stops tcmalloc from crashing on ubuntu 20.04

Fixes: https://tracker.ceph.com/issues/59269
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agolibrbd: on notify_quiesce() show attempts in a better format 50939/head
Prasanna Kumar Kalever [Fri, 7 Apr 2023 16:00:54 +0000 (21:30 +0530)]
librbd: on notify_quiesce() show attempts in a better format

notify_quiesce() currently shows number of attempts in descending order,
this might be bit confusing to read.

Example: on the very first attempt,
2023-04-04T19:45:56.096+0530 7ff8ba7fc640 10 librbd::ImageWatcher:
  0x7ff898008b30 notify_quiesce: async_request_id=[4151,140705343226832,23] attempts=10

I initially misread the above means 10 attempts where done.

This commit tries to pick the format that is used by
ImageWatcher<I>::handle_payload() and ImageWatcher<I>::notify_async_progress()

Fixes: https://tracker.ceph.com/issues/59379
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2 years agocommon/tracer: fix decoding when jaeger tracing is disabled 51043/head
Lucian Petrut [Wed, 12 Apr 2023 09:39:52 +0000 (09:39 +0000)]
common/tracer: fix decoding when jaeger tracing is disabled

We aren't currently using jaeger tracing on Windows. The issue is
that Windows hosts (or any other host that doesn't use jaeger)
are experiencing message decoding failures after a recent change [1].

This change updates the tracer encoding so that messages from
non-jaeger hosts may be decoded by services that use jaeger.

[1] https://github.com/ceph/ceph/pull/47457

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoMerge pull request #51051 from idryomov/wip-59431
Ilya Dryomov [Thu, 13 Apr 2023 09:54:57 +0000 (11:54 +0200)]
Merge pull request #51051 from idryomov/wip-59431

qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #43546 from ifed01/wip-ifed-snapdiff3-good
Igor Fedotov [Thu, 13 Apr 2023 09:26:58 +0000 (12:26 +0300)]
Merge pull request #43546 from ifed01/wip-ifed-snapdiff3-good

cephfs: implement snapdiff

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agodoc: 16.2.12 Release Notes 51055/head
Yuri Weinstein [Wed, 12 Apr 2023 18:12:23 +0000 (11:12 -0700)]
doc: 16.2.12 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2 years agoMerge pull request #50877 from rhcs-dashboard/add-rbd-mirror-force-promote
Nizamudeen A [Wed, 12 Apr 2023 15:10:40 +0000 (20:40 +0530)]
Merge pull request #50877 from rhcs-dashboard/add-rbd-mirror-force-promote

mgr/dashboard: rbd-mirror force promotion

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50666 from athanatos/sjust/wip-scrub-interval-pr-49959-2
Ronen Friedman [Wed, 12 Apr 2023 14:37:31 +0000 (17:37 +0300)]
Merge pull request #50666 from athanatos/sjust/wip-scrub-interval-pr-49959-2

osd/scrubber: simplify scrub resource handling and interval changes

2 years agoMerge pull request #51008 from guits/cv-tests-fix-rpm-issue-main
Guillaume Abrioux [Wed, 12 Apr 2023 14:23:31 +0000 (16:23 +0200)]
Merge pull request #51008 from guits/cv-tests-fix-rpm-issue-main

ceph-volume/tests: fix an issue with rpm

2 years agoqa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu 51051/head
Ilya Dryomov [Tue, 11 Apr 2023 20:43:58 +0000 (22:43 +0200)]
qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

qemu-utils is usually pre-installed but, due to what appears to be
a Ubuntu packaging bug, it's not upgraded when qemu-block-extra is
installed:

  The following NEW packages will be installed:
    qemu-block-extra
  The following packages will be upgraded:
    qemu-system-common qemu-system-data qemu-system-gui qemu-system-x86

However, the version of the block driver must match exactly the version
of the qemu-img tool, so the above leads to:

  $ qemu-img convert -f qcow2 -O raw /home/ubuntu/cephtest/qemu/base.client.0.0.qcow2 rbd:rbd/client.0.0
  Failed to initialize module: /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
  Note: only modules from the same build can be loaded.
  qemu: module block-block-rbd not found, do you want to install qemu-block-extra package?
  qemu-img: Unknown protocol 'rbd'

Fixes: https://tracker.ceph.com/issues/59431
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50840 from zhscn/segment-nonce-collision
Yingxin [Wed, 12 Apr 2023 06:22:56 +0000 (14:22 +0800)]
Merge pull request #50840 from zhscn/segment-nonce-collision

crimson/os/seatore: avoid segment nonce collision

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agomgr/dashboard: fix rbd mirror snapshot creation 49531/head
Aashish Sharma [Wed, 21 Dec 2022 11:53:37 +0000 (17:23 +0530)]
mgr/dashboard: fix rbd mirror snapshot creation

There are two types of snapshots that can be created on a snapshot based mirroring image - Normal Snapshot(same as journal based snapshot) and Nirror Image Snapshot. Till now Dashboard allowed only Mirror image snapshot, this PR intends to enable both the types

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoqa/standalone/scrub/osd-scrub-dump.sh: drop unnecessary primary lookup 50666/head
Samuel Just [Mon, 20 Mar 2023 21:07:32 +0000 (21:07 +0000)]
qa/standalone/scrub/osd-scrub-dump.sh: drop unnecessary primary lookup

1e44d86b2 swapped this to a pg tell command which doesn't actually
need the primary specified.  Drop the now unnecessary lookup.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/: remove PL::reschedule_scrub, notify scrubber on config/pool change directly
Samuel Just [Wed, 8 Mar 2023 01:21:24 +0000 (17:21 -0800)]
osd/: remove PL::reschedule_scrub, notify scrubber on config/pool change directly

As with on_info_history_change(), we don't need to deal with scrub
scheduling during peering. Once we've gone active, the scrubber itself
would be the origin of any stat changes that could affect scrub
scheduling.  The other possible change vectors would be OSD config
changes or pool config changes.

PG::reschedule_scrub becomes PG::on_scrub_schedule_input_change.  Should
be called in all cases where an input to scrub scheduling changes.

OSD::resched_all_scrubs() calls PG::on_scrub_schedule_input_change
unconditionally
now to deal with changes to osd_scrub_(min|max)_interval.

PG::set_last_[deep_]scrub_stamp now invoke
PG::on_scrub_schedule_input_change directly.

PG::handle_activate_map() now calls PG::on_scrub_schedule_input_change
directly to deal with changes to scrub related pool options.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/: remove PeeringListener::on_info_history_change()
Samuel Just [Tue, 7 Mar 2023 23:09:22 +0000 (15:09 -0800)]
osd/: remove PeeringListener::on_info_history_change()

The only usage of this method was to notify scrub that the pg history
has been updated during split or peering.  That shouldn't be necessary.
Scrub does not schedule itself prior to activation, and we necessarily
must have an authoritative history by that point.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber: associate replica state with state machine states
Samuel Just [Thu, 23 Feb 2023 05:04:17 +0000 (21:04 -0800)]
osd/scrubber: associate replica state with state machine states

Moves responsibility for owning and resetting replica state to state
machine events.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrub: split on_pg_activate from on_new_interval
Ronen Friedman [Wed, 1 Feb 2023 07:22:00 +0000 (09:22 +0200)]
osd/scrub: split on_pg_activate from on_new_interval

Separate and clarify handling of interval termination, pg activation,
and configuration change.

A primary PG now registers with its OSD for scrubbing only on
activation: on_pg_activate() called from PG::on_activate().

When the interval ends, the scrubber is notified via on_interval_change,
which is responsible for cleaning up any active or replica state
associated with scrub.

Configuration changes are still handled by update_scrub_job().

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber/scrub_machine*: s/ActiveReplica/ReplicaBuildingMap/g
Samuel Just [Fri, 10 Feb 2023 05:10:30 +0000 (21:10 -0800)]
osd/scrubber/scrub_machine*: s/ActiveReplica/ReplicaBuildingMap/g

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoscrubber/pg_scrubber: regularize message interval checks
Samuel Just [Thu, 9 Feb 2023 20:46:00 +0000 (12:46 -0800)]
scrubber/pg_scrubber: regularize message interval checks

OpRequestRef::sent_epoch can be used to uniformly check incoming
messages against the current interval.  Every caller should do it first
thing before any other processing.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber: make PgScrubber::check_interval const
Samuel Just [Thu, 9 Feb 2023 20:45:25 +0000 (12:45 -0800)]
osd/scrubber: make PgScrubber::check_interval const

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber: rename advance_token to reset_replica_state
Samuel Just [Wed, 8 Feb 2023 07:00:09 +0000 (07:00 +0000)]
osd/scrubber: rename advance_token to reset_replica_state

Also removes misleading comment -- because primaries may
freely reset scrub, there may well be valid scrub state.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber: move m_remote_osd_resource.reset() into advance_token()
Samuel Just [Wed, 8 Feb 2023 06:57:03 +0000 (06:57 +0000)]
osd/scrubber: move m_remote_osd_resource.reset() into advance_token()

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber: simplify existing reservation case in handle_scrub_reserve_request
Samuel Just [Wed, 8 Feb 2023 06:44:36 +0000 (22:44 -0800)]
osd/scrubber: simplify existing reservation case in handle_scrub_reserve_request

First, the is_stale() case should be impossible.  This patch leaves an
error message rather than an assert.

Second, this patch removes the special handling for receiving a reservation
when m_remote_osd_resource is already populated.  The next patch will exploit
the fact that all calls to m_remote_osd_resource.reset() and advance_token()
occur together.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrubber: remove unused PgScrubber::send_full_reset
Samuel Just [Wed, 8 Feb 2023 04:51:31 +0000 (20:51 -0800)]
osd/scrubber: remove unused PgScrubber::send_full_reset

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/scrub: remove PgScrubber::unregister_from_osd()
Ronen Friedman [Thu, 2 Feb 2023 15:06:46 +0000 (17:06 +0200)]
osd/scrub: remove PgScrubber::unregister_from_osd()

and inline its functionality into its sole caller
(PgScrubber::rm_from_osd_scrubbing())

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoosd/: misc scrub related formatting fixes -- no functional changes
Ronen Friedman [Thu, 2 Feb 2023 20:51:05 +0000 (22:51 +0200)]
osd/: misc scrub related formatting fixes -- no functional changes

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #50993 from zdover23/wip-doc-2023-04-11-rados-operations-monitorin...
zdover23 [Wed, 12 Apr 2023 00:04:47 +0000 (10:04 +1000)]
Merge pull request #50993 from zdover23/wip-doc-2023-04-11-rados-operations-monitoring-3-of-3

doc/rados/operations: edit monitoring.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50245 from baergj/bluefs-perf-stats-write-count
Yuri Weinstein [Tue, 11 Apr 2023 16:09:51 +0000 (09:09 -0700)]
Merge pull request #50245 from baergj/bluefs-perf-stats-write-count

os/bluestore: Add bluefs write op count metrics.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2 years agodoc/rados/operations: edit monitoring.rst 50993/head
Zac Dover [Tue, 11 Apr 2023 04:15:47 +0000 (14:15 +1000)]
doc/rados/operations: edit monitoring.rst

Line-edit the final third of doc/rados/operations/monitoring.rst.

Follows https://github.com/ceph/ceph/pull/50834.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agorgw/aio: fix recursion from tracing changes 51031/head
Casey Bodley [Tue, 11 Apr 2023 14:49:09 +0000 (10:49 -0400)]
rgw/aio: fix recursion from tracing changes

Fixes: https://tracker.ceph.com/issues/59423
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agomgr/dashboard: rbd-mirror force promotion 50877/head
Pedro Gonzalez Gomez [Wed, 5 Apr 2023 15:42:52 +0000 (17:42 +0200)]
mgr/dashboard: rbd-mirror force promotion

resolves: https://tracker.ceph.com/issues/59327
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoceph-volume/tests: fix an issue with rpm 51008/head
Guillaume Abrioux [Tue, 11 Apr 2023 11:29:15 +0000 (13:29 +0200)]
ceph-volume/tests: fix an issue with rpm

Typical error seen in the CI:

```
error: /var/cache/dnf/baseos-00fe51d07def85f0/packages/kernel-core-4.18.0-483.el8.x86_64.rpm: signature hdr data: BAD, no. of bytes(459772) out of range
```

Upgrading `rpm` fixes this issue.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 years agoMerge pull request #50885 from rhcs-dashboard/evict-fs
Nizamudeen A [Tue, 11 Apr 2023 10:56:28 +0000 (16:26 +0530)]
Merge pull request #50885 from rhcs-dashboard/evict-fs

mgr/dashboard: fix eviction of all FS clients

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50646 from rishabh-d-dave/doc-fs-subcmds
Rishabh Dave [Tue, 11 Apr 2023 10:10:33 +0000 (15:40 +0530)]
Merge pull request #50646 from rishabh-d-dave/doc-fs-subcmds

doc/cephfs: add missing "ceph fs" commands to man page

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #50628 from jianwei1216/support_bluestore_db_wal_physical_disk upstream/main
Igor Fedotov [Tue, 11 Apr 2023 09:26:53 +0000 (12:26 +0300)]
Merge pull request #50628 from jianwei1216/support_bluestore_db_wal_physical_disk

vstart: support bluestore db/wal physical disk

2 years agocrimson/os/seastore: check the type of segment head and segment tail during mount 50840/head
Zhang Song [Tue, 4 Apr 2023 01:34:06 +0000 (09:34 +0800)]
crimson/os/seastore: check the type of segment head and segment tail during mount

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agocrimson/os/seastore: avoid segment nonce collision
Zhang Song [Mon, 3 Apr 2023 11:29:27 +0000 (19:29 +0800)]
crimson/os/seastore: avoid segment nonce collision

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agoMerge pull request #50867 from rhcs-dashboard/skip-osds-expand-cluster
Nizamudeen A [Tue, 11 Apr 2023 05:20:04 +0000 (10:50 +0530)]
Merge pull request #50867 from rhcs-dashboard/skip-osds-expand-cluster

mgr/dashboard: fix create osd default selected as recommended not working

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge PR #50716 into main
Venky Shankar [Tue, 11 Apr 2023 02:34:01 +0000 (08:04 +0530)]
Merge PR #50716 into main

* refs/pull/50716/head:
doc: updating the doc with chamges related to delay option in cephfs-top
cephfs-top: fixing the -d [--delay] option in cephfs-top

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #50839 from zhscn/io-order
Yingxin [Tue, 11 Apr 2023 02:17:25 +0000 (10:17 +0800)]
Merge pull request #50839 from zhscn/io-order

crimson/os/seastore: ensure transaction commit order

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/libcephfs: add cases for last dir testing. 43546/head
Igor Fedotov [Mon, 23 Jan 2023 10:59:41 +0000 (13:59 +0300)]
test/libcephfs: add cases for last dir testing.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
2 years agoMerge pull request #50185 from ethanwu-syno/bluefs_tracker_56210
Yuri Weinstein [Mon, 10 Apr 2023 18:54:59 +0000 (11:54 -0700)]
Merge pull request #50185 from ethanwu-syno/bluefs_tracker_56210

os/bluestore/bluefs: fix dir_link might add link that already exists in compact log

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #50699 from yaarith/telemetry-leaderboard-doc
yaarith [Mon, 10 Apr 2023 17:55:36 +0000 (13:55 -0400)]
Merge pull request #50699 from yaarith/telemetry-leaderboard-doc

mgr/telemetry: add leaderboard description and documentation

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50721 from ceph/wip-yuriw-release-17.2.6-main
Laura Flores [Mon, 10 Apr 2023 16:00:18 +0000 (11:00 -0500)]
Merge pull request #50721 from ceph/wip-yuriw-release-17.2.6-main

doc: 17.2.6 Release Notes

2 years agodoc: 17.2.6 Release Notes 50721/head
Yuri Weinstein [Tue, 28 Mar 2023 16:46:56 +0000 (09:46 -0700)]
doc: 17.2.6 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agorgw/lua: fix CopyFrom crash 50975/head
Yuval Lifshitz [Mon, 10 Apr 2023 14:27:05 +0000 (14:27 +0000)]
rgw/lua: fix CopyFrom crash

Fixes: https://tracker.ceph.com/issues/59381
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoinclude,win: move uid_t/gid_t declarations to win32/fs_compat.h
Igor Fedotov [Mon, 3 Apr 2023 12:50:40 +0000 (15:50 +0300)]
include,win: move uid_t/gid_t declarations to win32/fs_compat.h

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Signed-off-by: Lucian Petrut <petrutlucian94@gmail.com>
2 years agopybind/cephfs: add snapdiff api binding
Igor Fedotov [Sun, 11 Sep 2022 22:04:17 +0000 (01:04 +0300)]
pybind/cephfs: add snapdiff api binding

Signed-off-by: Igor Fedotov <ifedotov@croit.io>
2 years agotest/libcephfs: add readdir_snapdiff
Igor Fedotov [Tue, 10 Aug 2021 19:12:26 +0000 (22:12 +0300)]
test/libcephfs: add readdir_snapdiff

Signed-off-by: Denis Barahtanov <denis.barahtanov@croit.io>
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
2 years agocephfs: imlplement readdir_snapdiff API
Igor Fedotov [Thu, 24 Jun 2021 11:27:53 +0000 (14:27 +0300)]
cephfs: imlplement readdir_snapdiff API

Signed-off-by: Denis Barahtanov <denis.barahtanov@croit.io>
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
2 years agoMerge pull request #50829 from zdover23/wip-doc-2023-04-02-rados-operations-health...
zdover23 [Mon, 10 Apr 2023 11:29:43 +0000 (21:29 +1000)]
Merge pull request #50829 from zdover23/wip-doc-2023-04-02-rados-operations-health-checks-6-of-x

doc/rados/ops: edit health-checks.rst (6 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados/ops: edit health-checks.rst (6 of x) 50829/head
Zac Dover [Sat, 1 Apr 2023 20:39:32 +0000 (06:39 +1000)]
doc/rados/ops: edit health-checks.rst (6 of x)

Edit docs/rados/operations/health-checks.rst (6 of x).

Follows https://github.com/ceph/ceph/pull/50828.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50828 from zdover23/wip-doc-2023-04-02-rados-operations-health...
zdover23 [Mon, 10 Apr 2023 10:40:43 +0000 (20:40 +1000)]
Merge pull request #50828 from zdover23/wip-doc-2023-04-02-rados-operations-health-checks-5-of-x

doc/rados/ops: edit health checks.rst (5 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados/ops: edit health checks.rst (5 of x) 50828/head
Zac Dover [Sat, 1 Apr 2023 20:33:45 +0000 (06:33 +1000)]
doc/rados/ops: edit health checks.rst (5 of x)

Edit docs/rados/operations/health-checks.rst (5 of x).

Follows https://github.com/ceph/ceph/pull/50827

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>