]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agocrimson/osd/objclass: Compilation warning 51333/head
Matan Breizman [Wed, 3 May 2023 09:39:14 +0000 (09:39 +0000)]
crimson/osd/objclass: Compilation warning

```
In copy constructor ‘ceph::buffer::v15_2_0::list::list(const ceph::buffer::v15_2_0::list&)’,
    inlined from ‘OSDOp::OSDOp(const OSDOp&)’ at ../src/osd/osd_types.h:4081:8,
    inlined from ‘int cls_cxx_snap_revert(cls_method_context_t, snapid_t)’ at ../src/crimson/osd/objclass.cc:279:37:
../src/include/buffer.h:945:20: warning: ‘op.OSDOp::indata.ceph::buffer::v15_2_0::list::_len’ is used uninitialized [-Wuninitialized]
  945 |         _len(other._len),
      |              ~~~~~~^~~~
../src/crimson/osd/objclass.cc: In function ‘int cls_cxx_snap_revert(cls_method_context_t, snapid_t)’:
../src/crimson/osd/objclass.cc:279:9: note: ‘op’ declared here
  279 |   OSDOp op{op = CEPH_OSD_OP_ROLLBACK};
      |
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #51331 from Matan-B/wip-matanb-revert-51043
Ilya Dryomov [Wed, 3 May 2023 10:28:17 +0000 (12:28 +0200)]
Merge pull request #51331 from Matan-B/wip-matanb-revert-51043

Revert "common/tracer: fix decoding when jaeger tracing is disabled"

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoRevert "common/tracer: fix decoding when jaeger tracing is disabled" 51331/head
Matan Breizman [Wed, 3 May 2023 08:04:11 +0000 (08:04 +0000)]
Revert "common/tracer: fix decoding when jaeger tracing is disabled"

This reverts commit 3701ffa6733b001d4278a0b68395c5efe2382f25.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #51255 from rhcs-dashboard/one-way-mirror-fix
Nizamudeen A [Wed, 3 May 2023 05:49:57 +0000 (11:19 +0530)]
Merge pull request #51255 from rhcs-dashboard/one-way-mirror-fix

mgr/dashboard: fix the rbd mirroring configure check

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51161 from cbodley/wip-59495
Casey Bodley [Tue, 2 May 2023 20:57:22 +0000 (16:57 -0400)]
Merge pull request #51161 from cbodley/wip-59495

rgw/sts: AssumeRole no longer writes to user metadata

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
2 years agoMerge pull request #51052 from cbodley/wip-59433
Casey Bodley [Tue, 2 May 2023 20:56:53 +0000 (16:56 -0400)]
Merge pull request #51052 from cbodley/wip-59433

rgw/s3: dump Message field in Error response even if empty

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #50925 from cbodley/wip-58725
Casey Bodley [Tue, 2 May 2023 20:56:17 +0000 (16:56 -0400)]
Merge pull request #50925 from cbodley/wip-58725

rgw/rados: check_quota() uses real bucket owner

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agoMerge pull request #50924 from cbodley/wip-58594
Casey Bodley [Tue, 2 May 2023 20:55:27 +0000 (16:55 -0400)]
Merge pull request #50924 from cbodley/wip-58594

rgw: add crypt attrs for iam policy to PostObj and Init/CompleteMultipart

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #49965 from pritha-srivastava/wip-rgw-sts-upload-part
Casey Bodley [Tue, 2 May 2023 20:54:59 +0000 (16:54 -0400)]
Merge pull request #49965 from pritha-srivastava/wip-rgw-sts-upload-part

rgw/sts: changing identity to boost::none, when role policy

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agoMerge pull request #51048 from yaarith/pending-release-notes-leaderboard
yaarith [Tue, 2 May 2023 17:57:48 +0000 (13:57 -0400)]
Merge pull request #51048 from yaarith/pending-release-notes-leaderboard

PendingReleaseNotes: add a note about telemetry leaderboard

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #51264 from idryomov/wip-rbd-gtest-skip
Ilya Dryomov [Tue, 2 May 2023 11:15:39 +0000 (13:15 +0200)]
Merge pull request #51264 from idryomov/wip-rbd-gtest-skip

test/librbd: use GTEST_SKIP macro to skip tests

Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agoMerge pull request #51295 from jzhu116-bloomberg/wip-59577
Yuval Lifshitz [Tue, 2 May 2023 09:35:22 +0000 (12:35 +0300)]
Merge pull request #51295 from jzhu116-bloomberg/wip-59577

rgw/notification: pass in bytes_transferred to populate object_size in sync notification

2 years agoMerge pull request #50457 from Matan-B/wip-matanb-c-new-rbd-api
Matan [Tue, 2 May 2023 09:21:35 +0000 (12:21 +0300)]
Merge pull request #50457 from Matan-B/wip-matanb-c-new-rbd-api

qa/suites/crimson-rados/rbd: Add new rbd image format api tests

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #50227 from xxhdx1985126/wip-share-map-over-heartbeat
Matan [Tue, 2 May 2023 09:19:33 +0000 (12:19 +0300)]
Merge pull request #50227 from xxhdx1985126/wip-share-map-over-heartbeat

crimson/osd/heartbeat: share osdmap to peers when necessary

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51202 from xxhdx1985126/wip-crimson-clone-head-version
Radoslaw Zarzynski [Tue, 2 May 2023 09:15:39 +0000 (11:15 +0200)]
Merge pull request #51202 from xxhdx1985126/wip-crimson-clone-head-version

crimson/osd/pg: make clone object's version consistent with pglog

Reviewed-by: Sam Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #51180 from xxhdx1985126/wip-59511
Radoslaw Zarzynski [Tue, 2 May 2023 09:03:59 +0000 (11:03 +0200)]
Merge pull request #51180 from xxhdx1985126/wip-59511

crimson/osd/snaptrim_event: get SnapSetContext from head obc

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Sam Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #47637 from rzarzynski/wip-crimson-blocklist
Radoslaw Zarzynski [Tue, 2 May 2023 09:01:46 +0000 (11:01 +0200)]
Merge pull request #47637 from rzarzynski/wip-crimson-blocklist

crimson/osd: bring support for client blocklisting

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Sam Just <sjust@redhat.com>
2 years agoMerge PR #51158 into main
Venky Shankar [Tue, 2 May 2023 06:47:28 +0000 (12:17 +0530)]
Merge PR #51158 into main

* refs/pull/51158/head:
cephfs-top: fix help text for delay

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #51005 into main
Venky Shankar [Tue, 2 May 2023 05:58:41 +0000 (11:28 +0530)]
Merge PR #51005 into main

* refs/pull/51005/head:
qa: fix test_nfs_export_creation_at_symlink
qa: update test cases to check for ENOTDIR instead of EINVAL
qa: fix test_nfs_export_with_invalid_path
mgr/nfs: handle exceptions for cephfs_path_is_dir()
mgr/nfs/utils: changes to helper func to check cephfs path

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51133 from zdover23/wip-doc-2023-04-18-mgr-prometheus-prompts...
zdover23 [Tue, 2 May 2023 02:55:53 +0000 (12:55 +1000)]
Merge pull request #51133 from zdover23/wip-doc-2023-04-18-mgr-prometheus-prompts-update

doc/mgr: update prompts in prometheus.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agoMerge pull request #51299 from zdover23/wip-doc-2023-05-02-radosgw-notifications...
zdover23 [Mon, 1 May 2023 21:31:38 +0000 (07:31 +1000)]
Merge pull request #51299 from zdover23/wip-doc-2023-05-02-radosgw-notifications-rabbitmq-push-endpoint-directive-removal

doc/radosgw: rabbitmq - push-endpoint edit

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #50698 from linuxkidd/wip-rgw-restore-bucket-index-update
J. Eric Ivancich [Mon, 1 May 2023 21:14:39 +0000 (17:14 -0400)]
Merge pull request #50698 from linuxkidd/wip-rgw-restore-bucket-index-update

rgw: add use of cached `rados ls` output to rgw-restore-bucket-index script

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2 years agoMerge pull request #51270 from ljflores/wip-telemetry-selftest
yaarith [Mon, 1 May 2023 21:08:08 +0000 (17:08 -0400)]
Merge pull request #51270 from ljflores/wip-telemetry-selftest

mgr/telemetry: compile all channels and collections in selftest

Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>
2 years agoMerge pull request #51296 from zdover23/wip-doc-2023-05-01-rados-operations-stretch...
zdover23 [Mon, 1 May 2023 20:11:04 +0000 (06:11 +1000)]
Merge pull request #51296 from zdover23/wip-doc-2023-05-01-rados-operations-stretch-mode-top-matter

doc/rados: edit stretch-mode.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #51298 from ljflores/wip-urllib3-version
Laura Flores [Mon, 1 May 2023 19:30:17 +0000 (14:30 -0500)]
Merge pull request #51298 from ljflores/wip-urllib3-version

mgr: add urllib3==1.26.15 to mgr/requirements.txt

2 years agodoc/rados: edit stretch-mode.rst 51296/head
Zac Dover [Mon, 1 May 2023 02:29:07 +0000 (12:29 +1000)]
doc/rados: edit stretch-mode.rst

Refine and supplement the introductory and explanatory text at the top
of the /doc/rados/operations/stretch-mode.rst file.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/radosgw: rabbitmq - push-endpoint edit 51299/head
Zac Dover [Mon, 1 May 2023 17:14:01 +0000 (03:14 +1000)]
doc/radosgw: rabbitmq - push-endpoint edit

Remove a note that directed users to change "push-endpoint" (with a
hyphen) to "push_endpoint" (with an underscore) when using rabbitmq.

Re: https://github.com/ceph/ceph/pull/48486#issuecomment-1529925389

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agorgw/notification: read object size from the rados obj when populate sync notification 51295/head
Jane Zhu [Mon, 1 May 2023 02:20:16 +0000 (22:20 -0400)]
rgw/notification: read object size from the rados obj when populate sync notification

Signed-off-by: Juan Zhu <jzhu4@dev-10-34-20-139.pw1.bcc.bloomberg.com>
2 years agomgr: add urllib3==1.26.15 to mgr/requirements.txt 51298/head
Laura Flores [Mon, 1 May 2023 16:28:54 +0000 (16:28 +0000)]
mgr: add urllib3==1.26.15 to mgr/requirements.txt

We do not depend on any particular version of
urllib3, but as a workaround to the incompatibility
of urllib3 constraints between kubernetes and
requests, we need to pin it temporarily to
the version both are happy with.

Fixes: https://tracker.ceph.com/issues/59591
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #51284 from zdover23/wip-doc-2023-04-29-cephfs-nfs
Anthony D'Atri [Mon, 1 May 2023 12:39:42 +0000 (08:39 -0400)]
Merge pull request #51284 from zdover23/wip-doc-2023-04-29-cephfs-nfs

doc/cephfs: improve sentence in nfs.rst

2 years agoMerge pull request #51138 from AliMasarweh/wip-alimasa-pubsub-hide-autogen-topics
Ali Masarwa [Mon, 1 May 2023 11:12:40 +0000 (14:12 +0300)]
Merge pull request #51138 from AliMasarweh/wip-alimasa-pubsub-hide-autogen-topics

RGW: bucket notification - hide auto generated topics when listing topics

2 years agotest/cls_rbd/test_cls_rbd: Skip mirror_image_status (Crimson) 50457/head
Matan Breizman [Tue, 25 Apr 2023 10:14:06 +0000 (10:14 +0000)]
test/cls_rbd/test_cls_rbd: Skip mirror_image_status (Crimson)

This commit is part of an initial attempt to establish a Crimson testing baseline.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoqa/suites/crimson-rados/rbd: Add new rbd image format api tests
Matan Breizman [Thu, 9 Mar 2023 11:15:18 +0000 (11:15 +0000)]
qa/suites/crimson-rados/rbd: Add new rbd image format api tests

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agotest/librbd: Skip unsupported Crimson tests
Matan Breizman [Thu, 9 Mar 2023 10:59:18 +0000 (10:59 +0000)]
test/librbd: Skip unsupported Crimson tests

This commit is part of an initial attempt to establish a Crimson testing baseline.

test_librbd notes:

* Skip ListChildrenTiered (Crimson):
  Cache tiering is not supported.

test_internal notes:

* Skip SnapshotCopyup (Crimson):
  Clone overlap calculation is WIP: https://tracker.ceph.com/issues/58263

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #51293 from yuvalif/wip-yuval-revert-47457
Gregory Farnum [Sun, 30 Apr 2023 17:33:52 +0000 (10:33 -0700)]
Merge pull request #51293 from yuvalif/wip-yuval-revert-47457

revert PRs #47457 and #51031

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2 years agoRevert "tracer/osd/librados/build/rgw: rgw and osd end2end tracing using opentelemetry" 51293/head
Yuval Lifshitz [Sun, 30 Apr 2023 13:31:19 +0000 (13:31 +0000)]
Revert "tracer/osd/librados/build/rgw: rgw and osd end2end tracing using opentelemetry"

This reverts commit 5d4c5e65be94a346e62b9f8ac63241779c4c7a6a.

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoRevert "rgw/aio: fix recursion from tracing changes"
Yuval Lifshitz [Sun, 30 Apr 2023 13:29:55 +0000 (13:29 +0000)]
Revert "rgw/aio: fix recursion from tracing changes"

This reverts commit 9f160e4f1aa385f39f1cd55eb42f278c94dfd85c.

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #51285 from zdover23/wip-doc-2023-04-29-rados-operations-stretch...
zdover23 [Sat, 29 Apr 2023 19:45:39 +0000 (05:45 +1000)]
Merge pull request #51285 from zdover23/wip-doc-2023-04-29-rados-operations-stretch-mode-stretch-mode

doc/rados: edit stretch-mode procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit stretch-mode procedure 51285/head
Zac Dover [Sat, 29 Apr 2023 00:14:02 +0000 (10:14 +1000)]
doc/rados: edit stretch-mode procedure

Edit the "stretch mode" section in doc/rados/operations/stretch-mode.rst
so that the procedure is formatted as a procedure and the sentences
correctly have heads.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51276 from pcuzner/fix-prom-docs
zdover23 [Sat, 29 Apr 2023 01:18:37 +0000 (11:18 +1000)]
Merge pull request #51276 from pcuzner/fix-prom-docs

docs: Update the cephadm docs for Prometheus endpoint info

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/cephfs: improve sentence in nfs.rst 51284/head
Zac Dover [Fri, 28 Apr 2023 19:21:09 +0000 (05:21 +1000)]
doc/cephfs: improve sentence in nfs.rst

Corect a sentence that should have been corrected in
https://github.com/ceph/ceph/pull/51204.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agocephfs-top: fix help text for delay 51158/head
Jos Collin [Thu, 20 Apr 2023 09:39:01 +0000 (15:09 +0530)]
cephfs-top: fix help text for delay

Updates:

`
  -d {1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25}, --delay {1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25}
                        Refresh interval in seconds (default: 1)
`

to

`
  -d DELAY, --delay DELAY
                        Refresh interval in seconds (default: 1, range: 1 - 25)
`

Fixes: https://tracker.ceph.com/issues/59553
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #51069 from rhcs-dashboard/exporter-prom
Juan Miguel Olmo [Fri, 28 Apr 2023 06:21:53 +0000 (08:21 +0200)]
Merge pull request #51069 from rhcs-dashboard/exporter-prom

exporter: promethize counter names

2 years agodocs: Update the Prometheus endpoint info 51276/head
Paul Cuzner [Fri, 28 Apr 2023 05:21:39 +0000 (17:21 +1200)]
docs: Update the Prometheus endpoint info

This patch just tidies up some of the links and adds
an example showing how the http_sd_configs option
may be used.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2 years agoMerge pull request #51271 from zdover23/wip-doc-2023-04-28-rados-configuration-mon...
zdover23 [Thu, 27 Apr 2023 22:55:45 +0000 (08:55 +1000)]
Merge pull request #51271 from zdover23/wip-doc-2023-04-28-rados-configuration-mon-config-ref-background

doc/rados: m-config-ref: edit "background"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: m-config-ref: edit "background" 51271/head
Zac Dover [Thu, 27 Apr 2023 22:35:17 +0000 (08:35 +1000)]
doc/rados: m-config-ref: edit "background"

Edit the "Background" section of doc/rados/monitor/config-ref.rst

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/mgr: update prompts in prometheus.rst 51133/head
Zac Dover [Tue, 18 Apr 2023 14:28:50 +0000 (16:28 +0200)]
doc/mgr: update prompts in prometheus.rst

Update prompts in prometheus.rst so that they're unselectable.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agomgr/telemetry: compile all channels and collections in selftest 51270/head
Laura Flores [Thu, 27 Apr 2023 18:22:47 +0000 (18:22 +0000)]
mgr/telemetry: compile all channels and collections in selftest

The selftest currently compiles only channels and collections that
are on by default. This change tests the compilation of all channels
and collections.

Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agocrimson/osd/heartbeat: add latest epoch sent concept 50227/head
Matan Breizman [Wed, 29 Mar 2023 16:42:09 +0000 (16:42 +0000)]
crimson/osd/heartbeat: add latest epoch sent concept

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/shard_services: Add logs to load_map_bls
Matan Breizman [Wed, 29 Mar 2023 09:21:12 +0000 (09:21 +0000)]
crimson/osd/shard_services: Add logs to load_map_bls

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/heartbeat: add a rename todo
Matan Breizman [Thu, 27 Apr 2023 16:07:01 +0000 (16:07 +0000)]
crimson/osd/heartbeat: add a rename todo

In continuation to: bfbbc311f1f

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/heartbeat: Rename Peer's created at epoch
Matan Breizman [Wed, 29 Mar 2023 09:19:29 +0000 (09:19 +0000)]
crimson/osd/heartbeat: Rename Peer's created at epoch

As these getter and setter represent the epoch at which the peer was added

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/heartbeat: share osdmap to peers when necessary
Xuehan Xu [Thu, 23 Feb 2023 06:50:56 +0000 (06:50 +0000)]
crimson/osd/heartbeat: share osdmap to peers when necessary

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd: drop the OSDMap caching from PG 47637/head
Radoslaw Zarzynski [Mon, 29 Aug 2022 10:52:05 +0000 (10:52 +0000)]
crimson/osd: drop the OSDMap caching from PG

`PG` directly aggregates both `OSDMap` and `PeeringState` which
maintains its own `OSDMap` instance. This duplication leads to
issues as the `PG::osdmap` never gets updated.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agocrimson/osd: implement watcher blocklisting
Radoslaw Zarzynski [Tue, 16 Aug 2022 14:34:23 +0000 (14:34 +0000)]
crimson/osd: implement watcher blocklisting

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agocrimson/osd: check for blocklisted clients
Radoslaw Zarzynski [Tue, 16 Aug 2022 12:23:58 +0000 (12:23 +0000)]
crimson/osd: check for blocklisted clients

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agotest/librbd: use GTEST_SKIP macro to skip tests 51264/head
Ilya Dryomov [Thu, 27 Apr 2023 13:43:05 +0000 (15:43 +0200)]
test/librbd: use GTEST_SKIP macro to skip tests

The use of SUCCEED macro predates the introduction of GTEST_SKIP macro
to GTest 1.10.  Having skipped tests reported as passed is misleading!

Before:

[ RUN      ] TestMockOperationSnapshotRemoveRequest.FlattenedCloneRemovesChild
SKIPPING
[       OK ] TestMockOperationSnapshotRemoveRequest.FlattenedCloneRemovesChild (9 ms)
...
[ RUN      ] TestMockOperationSnapshotRemoveRequest.RemoveChildError
SKIPPING
[       OK ] TestMockOperationSnapshotRemoveRequest.RemoveChildError (112 ms)
...
[  PASSED  ] 16 tests.

After:

[ RUN      ] TestMockOperationSnapshotRemoveRequest.FlattenedCloneRemovesChild
../src/test/librbd/operation/test_mock_SnapshotRemoveRequest.cc:381: Skipped
Skipping due to unmet REQUIRE
[  SKIPPED ] TestMockOperationSnapshotRemoveRequest.FlattenedCloneRemovesChild (9 ms)
...
[ RUN      ] TestMockOperationSnapshotRemoveRequest.RemoveChildError
../src/test/librbd/operation/test_mock_SnapshotRemoveRequest.cc:727: Skipped
Skipping due to enabled deep-flatten
[  SKIPPED ] TestMockOperationSnapshotRemoveRequest.RemoveChildError (111 ms)
...
[  PASSED  ] 14 tests.
[  SKIPPED ] 2 tests, listed below:
[  SKIPPED ] TestMockOperationSnapshotRemoveRequest.FlattenedCloneRemovesChild
[  SKIPPED ] TestMockOperationSnapshotRemoveRequest.RemoveChildError

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agomgr/dashboard: fix the rbd mirroring configure check 51255/head
Nizamudeen A [Thu, 27 Apr 2023 11:24:24 +0000 (16:54 +0530)]
mgr/dashboard: fix the rbd mirroring configure check

In one-way mirroring, the condition we are checking now for configuring
the mirroring will fail because only one cluster needs to have the
mirror daemon present. Thus even if mirroring is successfuly happening
the page won't load. For now relaxing the rule until we find a better
api call to check for the status

Fixes: https://tracker.ceph.com/issues/59573
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50530 from Matan-B/wip-matanb-crimson-only-new-rbd-v2
Matan [Thu, 27 Apr 2023 09:53:38 +0000 (12:53 +0300)]
Merge pull request #50530 from Matan-B/wip-matanb-crimson-only-new-rbd-v2

crimson/osd: Handle rollback to head obejct

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #50584 from Matan-B/wip-matanb-crimson-only-add-thrash
Matan [Thu, 27 Apr 2023 09:43:00 +0000 (12:43 +0300)]
Merge pull request #50584 from Matan-B/wip-matanb-crimson-only-add-thrash

qa/suites/crimson-rados/thrash: Enable supported tests and ops

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51198 from Matan-B/wip-matanb-snap-trimmer-loop
Matan [Thu, 27 Apr 2023 09:40:07 +0000 (12:40 +0300)]
Merge pull request #51198 from Matan-B/wip-matanb-snap-trimmer-loop

crimson/osd/snaptrim_event: Handle missing clone obc case

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
2 years agoMerge pull request #51189 from rhcs-dashboard/fix-cephpgimbalance-alert
Nizamudeen A [Thu, 27 Apr 2023 05:35:19 +0000 (11:05 +0530)]
Merge pull request #51189 from rhcs-dashboard/fix-cephpgimbalance-alert

mgr/dashboard: fix CephPGImbalance alert

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agocrimson/osd/snaptrim_event: avoid leaking txn ops for updating head obcs 51180/head
Xuehan Xu [Thu, 27 Apr 2023 03:32:04 +0000 (03:32 +0000)]
crimson/osd/snaptrim_event: avoid leaking txn ops for updating head obcs
when removing clones

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/osd/snaptrim_event: encode head oi with no oid
Xuehan Xu [Thu, 27 Apr 2023 03:31:20 +0000 (03:31 +0000)]
crimson/osd/snaptrim_event: encode head oi with no oid

This is required by PGBackend::load_metadata

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/osd/snaptrim_event: don't clear head obc's snaps
Xuehan Xu [Thu, 27 Apr 2023 03:29:58 +0000 (03:29 +0000)]
crimson/osd/snaptrim_event: don't clear head obc's snaps

There may be valid snaps for a head object, although some snap is
being removed

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #51154 from zdover23/wip-doc-2023-04-20-rados-operations-3-of-x
zdover23 [Thu, 27 Apr 2023 00:11:24 +0000 (10:11 +1000)]
Merge pull request #51154 from zdover23/wip-doc-2023-04-20-rados-operations-3-of-x

doc/rados/ops: edit user-management.rst (3 of x)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #51204 from zdover23/wip-doc-2023-04-25-cephfs-nfs-ganesha-permissions
zdover23 [Wed, 26 Apr 2023 22:08:07 +0000 (08:08 +1000)]
Merge pull request #51204 from zdover23/wip-doc-2023-04-25-cephfs-nfs-ganesha-permissions

doc/cephfs: explain cephfs data and metadata set

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephfs: explain cephfs data and metadata set 51204/head
Zac Dover [Tue, 25 Apr 2023 07:46:53 +0000 (17:46 +1000)]
doc/cephfs: explain cephfs data and metadata set

Explain how to set application metadata for the CephFS data pool and the
CephFS metadata pool.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51228 from jsoref/spelling-rbd
Ilya Dryomov [Wed, 26 Apr 2023 21:07:47 +0000 (23:07 +0200)]
Merge pull request #51228 from jsoref/spelling-rbd

rbd: fix spelling errors

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51030 from batrick/i59425
Rishabh Dave [Wed, 26 Apr 2023 14:14:39 +0000 (19:44 +0530)]
Merge pull request #51030 from batrick/i59425

qa: check each fs for health

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agorbd: fix spelling errors 51228/head
Josh Soref [Thu, 23 Jun 2022 01:24:32 +0000 (21:24 -0400)]
rbd: fix spelling errors

* acquire
* are
* asynchronous
* attempt
* bootstrap
* concurrent
* consume
* couldn't
* cumulative
* disable
* disabling
* disaster
* disconnected
* endianness
* entries
* exclusive
* filesystem
* flag
* generic
* github
* image
* information
* initiating
* latency
* limitations
* metadata
* modify
* namespace
* noautoconsole
* ourselves
* prefetch
* propagate
* protection
* recorder
* recover
* release
* replicated
* reserved
* selection
* sentinel
* several
* snapshot
* source
* specifying
* suppress
* synchronize
* the
* transfer
* triggering
* unknown
* validation
* version
* visible
* write log entries

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2 years agoMerge pull request #50927 from rhcs-dashboard/export-authx
Nizamudeen A [Wed, 26 Apr 2023 13:06:23 +0000 (18:36 +0530)]
Merge pull request #50927 from rhcs-dashboard/export-authx

mgr/dashboard: import/export ceph authx users

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoqa: fix test_nfs_export_creation_at_symlink 51005/head
Dhairya Parmar [Wed, 26 Apr 2023 07:51:28 +0000 (13:21 +0530)]
qa: fix test_nfs_export_creation_at_symlink

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoqa: update test cases to check for ENOTDIR instead of EINVAL
Dhairya Parmar [Wed, 12 Apr 2023 07:57:53 +0000 (13:27 +0530)]
qa: update test cases to check for ENOTDIR instead of EINVAL

- test_nfs_export_creation_at_filepath:
ENOTDIR is raised instead of EINVAL which is better
aligned with the nature of the failure

- test_nfs_export_creation_at_symlink:
ENOTDIR is raised instead of ENOENT since the code
can now check if the path is symlink but won't follow
it.

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2 years agoqa: fix test_nfs_export_with_invalid_path
Dhairya Parmar [Tue, 11 Apr 2023 12:14:41 +0000 (17:44 +0530)]
qa: fix test_nfs_export_with_invalid_path

It actually didn't test the invalid path but still ended with
ENOENT(which is expected in case path is invalid) as the test
didn't create a fs, and it failed saying "FS nfs-cephfs not found"
which too raises ENOENT and thus it always passed.

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2 years agomgr/nfs: handle exceptions for cephfs_path_is_dir()
Dhairya Parmar [Tue, 11 Apr 2023 10:09:00 +0000 (15:39 +0530)]
mgr/nfs: handle exceptions for cephfs_path_is_dir()
in create_cephfs_export()

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2 years agomgr/nfs/utils: changes to helper func to check cephfs path
Dhairya Parmar [Tue, 11 Apr 2023 10:06:52 +0000 (15:36 +0530)]
mgr/nfs/utils: changes to helper func to check cephfs path

- Renamed to cephfs_path_is_dir

- Removed exception handling to prevent redundant log statements like:
   "No such file or directory error in stat: b'/mnt/testdir_symlink': No such file or directory [Errno 2]"

  Exceptions handled inside caller eliminates this redundancy

- Set modifier flag AT_SYMLINK_NOFOLLOW

- Removed string "{path} is not a dir" when raising NotADirectoryError
  Rationale: will be handled in export.py

- change mock to cephfs_path_is_dir

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2 years agomgr/dashboard: import/export authx users 50927/head
Pere Diaz Bou [Thu, 6 Apr 2023 14:24:03 +0000 (16:24 +0200)]
mgr/dashboard: import/export authx users

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Fixes: https://tracker.ceph.com/issues/59486
2 years agoMerge PR #51223 into main
Venky Shankar [Wed, 26 Apr 2023 04:28:15 +0000 (09:58 +0530)]
Merge PR #51223 into main

* refs/pull/51223/head:
Revert "tools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephfs-top"

Reviewed-by: Jos Collin <jcollin@redhat.com>
2 years agoRevert "tools/cephfs/top/CMakeList.txt: check the minimum compatible python version... 51223/head
Venky Shankar [Wed, 26 Apr 2023 01:29:26 +0000 (06:59 +0530)]
Revert "tools/cephfs/top/CMakeList.txt: check the minimum compatible python version for cephfs-top"

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51193 from zdover23/wip-doc-2023-04-24-start-intro-first-para... 51095/head
Anthony D'Atri [Tue, 25 Apr 2023 23:17:50 +0000 (19:17 -0400)]
Merge pull request #51193 from zdover23/wip-doc-2023-04-24-start-intro-first-para-rewrite

doc/start: rewrite intro paragraph

2 years agodoc/start: rewrite intro paragraph 51193/head
Zac Dover [Mon, 24 Apr 2023 11:02:16 +0000 (13:02 +0200)]
doc/start: rewrite intro paragraph

Rewrite the first paragraph in doc/start/intro.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #50722 from adk3798/asyncio-cephadm-timeout
Adam King [Tue, 25 Apr 2023 17:08:07 +0000 (13:08 -0400)]
Merge pull request #50722 from adk3798/asyncio-cephadm-timeout

mgr/cephadm: asyncio based universal timeout for ssh/cephadm commands

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #49103 from adk3798/mon-crush-location
Adam King [Tue, 25 Apr 2023 15:25:29 +0000 (11:25 -0400)]
Merge pull request #49103 from adk3798/mon-crush-location

mgr/cephadm: allow setting mon crush locations through mon service spec

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #51120 from mgfritch/cephadm-haproxy-offline-host
Adam King [Tue, 25 Apr 2023 15:21:28 +0000 (11:21 -0400)]
Merge pull request #51120 from mgfritch/cephadm-haproxy-offline-host

cephadm: reschedule haproxy from an offline host

Reviewed-by: Adam King <adking@redhat.com>
2 years agomgr/cephadm: asyncio based universal timeout for ssh/cephadm commands 50722/head
Adam King [Mon, 20 Mar 2023 19:31:12 +0000 (15:31 -0400)]
mgr/cephadm: asyncio based universal timeout for ssh/cephadm commands

Since we already have make use of asyncio for our ssh commands,
we can use asyncio's timeout on waiting for concurrent futures to complete
as a way to have universal timeouts on our cephadm commands.
This change also creates a contextmanager that will catch any asyncio.TimeoutError.
Using the contextmanager along with calls to the wait_async function
will catch any timeout exception raised and convert it into an appropriate
OrchetratorError including information about what and where for the timeout
if it was provided (host where run, what command). This allows us to guarantee a
background ssh command eventually returns and inform users of any
timeouts by raising a health warning or logging the error instead
of sitting idle indefinitely

Fixes: https://tracker.ceph.com/issues/54024
Signed-off-by: Adam King <adking@redhat.com>
2 years agomgr/cephadm: pass --timeout to cephadm binary commands
Adam King [Thu, 16 Mar 2023 18:20:48 +0000 (14:20 -0400)]
mgr/cephadm: pass --timeout to cephadm binary commands

Signed-off-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #50719 from guits/update-dockerfile-keepalived
Adam King [Tue, 25 Apr 2023 14:04:36 +0000 (10:04 -0400)]
Merge pull request #50719 from guits/update-dockerfile-keepalived

contrib: update keepalived Dockerfile

Reviewed-by: Adam King <adking@redhat.com>
2 years agoqa/suites/crimson-rados/thrash: Enable supported thrashers 50584/head
Matan Breizman [Sun, 19 Mar 2023 11:56:03 +0000 (11:56 +0000)]
qa/suites/crimson-rados/thrash: Enable supported thrashers

Balanced/Localized reads are now supported.
snap_remove and rollback are supported as well.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoqa/suites/crimson-rados/thrash: Add snap_remove/create weights
Matan Breizman [Sun, 19 Mar 2023 11:53:38 +0000 (11:53 +0000)]
qa/suites/crimson-rados/thrash: Add snap_remove/create weights

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/pg: PG::on_active_actmap() clear PG_STATE_SNAPTRIM_ERROR 51198/head
Matan Breizman [Mon, 24 Apr 2023 12:56:18 +0000 (12:56 +0000)]
crimson/osd/pg: PG::on_active_actmap() clear PG_STATE_SNAPTRIM_ERROR

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/pg: PG::on_active_actmap() fix SnapTrimEvent stop condition
Matan Breizman [Mon, 24 Apr 2023 12:55:45 +0000 (12:55 +0000)]
crimson/osd/pg: PG::on_active_actmap() fix SnapTrimEvent stop condition

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/osd_operations/snaptrim_event: Handle missing clone obc
Matan Breizman [Mon, 24 Apr 2023 12:55:08 +0000 (12:55 +0000)]
crimson/osd/osd_operations/snaptrim_event: Handle missing clone obc

The case where resolve_oid is not able to return the clone oid (in order
to load the clone obc) should result in an SNAPTRIM_ERROR and stop the loop
iteration. Without taking this case into account an infinite loop of snap
trim events will be created.
The ENOENT error is delegated upwards to be handled by PG::on_active_actmap().

Fixes: https://tracker.ceph.com/issues/59231
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/pg: make clone object's version consistent with pglog 51202/head
Xuehan Xu [Tue, 25 Apr 2023 06:21:07 +0000 (06:21 +0000)]
crimson/osd/pg: make clone object's version consistent with pglog

Right now, the head object's version is 1 less than clone object's
version in the pg log; while it's exactly the other way around when
it comes to the versions recorded in the object info of head/clone
objects

Fixes: https://tracker.ceph.com/issues/59536
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #49980 from myoungwon/wip-generalize-recordsubmitter
Yingxin [Tue, 25 Apr 2023 01:48:35 +0000 (09:48 +0800)]
Merge pull request #49980 from myoungwon/wip-generalize-recordsubmitter

crimson/os/seastore/journal: generalize recordsubmitter

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoexporter: promethize counter names 51069/head
Pere Diaz Bou [Thu, 13 Apr 2023 16:55:04 +0000 (18:55 +0200)]
exporter: promethize counter names

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
Fixes: https://tracker.ceph.com/issues/59475
2 years agocrimson/osd/osd_operations/snaptrim_event: Add log lines and formatting
Matan Breizman [Mon, 24 Apr 2023 12:53:40 +0000 (12:53 +0000)]
crimson/osd/osd_operations/snaptrim_event: Add log lines and formatting

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd: get SnapSetContext from head obc
Xuehan Xu [Sun, 23 Apr 2023 03:59:17 +0000 (03:59 +0000)]
crimson/osd: get SnapSetContext from head obc

clone obc doesn't have snapset context

Fixes: https://tracker.ceph.com/issues/59511
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #51067 from guits/fix-backward-compatible-issue-cv
Guillaume Abrioux [Mon, 24 Apr 2023 08:36:42 +0000 (10:36 +0200)]
Merge pull request #51067 from guits/fix-backward-compatible-issue-cv

ceph-volume: fix batch refactor issue

2 years agoMerge pull request #50838 from guits/osd-replacement-improvements
Guillaume Abrioux [Mon, 24 Apr 2023 08:35:51 +0000 (10:35 +0200)]
Merge pull request #50838 from guits/osd-replacement-improvements

orchestrator: add `--no-destroy` arg to `ceph orch osd rm`