doc/rados: edit stretch-mode.rst

Edit "Stretch Mode Limitations" (renamed "Limitations of Stretch Mode"
in this commit) in doc/rados/operations/stretch-mode.rst.

Co-authored-by: Greg Farnum <gfarnum@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 410e2a181c3247d13a1b20d80c4bcbbc1a5f84da)

Merge pull request #50978 from batrick/i59295

reef: MgrMonitor: batch commit OSDMap and MgrMap mutations

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #50963 from ajarr/wip-58999-reef

reef: mgr: store names of modules that register RADOS clients in the MgrMap

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #51061 from mkogan1/wip-50842-reef

reef: rgw : fix python script using s3cmd with error code 403 ubuntu 20.04

Reviewed-by: Casey Bodley <cbodley@redhat.com>

rgw : fix python script using s3cmd with error code 403 ubuntu 20.04

Fixes: https://tracker.ceph.com/issues/54104
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit 5846a9c2677067516f98d502980dab1681cddb69)

Merge pull request #51334 from ljflores/wip-59600-reef

reef: mgr: add urllib3==1.26.15 to mgr/requirements.txt

mgr: add urllib3==1.26.15 to mgr/requirements.txt

We do not depend on any particular version of
urllib3, but as a workaround to the incompatibility
of urllib3 constraints between kubernetes and
requests, we need to pin it temporarily to
the version both are happy with.

Fixes: https://tracker.ceph.com/issues/59591
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 80d460005e44649191aa862fa78bd278644b5237)

Merge pull request #51309 from zdover23/wip-doc-2023-05-02-backport-51133-to-reef

reef: doc/mgr: update prompts in prometheus.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

Merge pull request #50631 from trociny/wip-59130-reef

reef: mgr/cephadm: don't add mgr into iscsi trusted_ip_list if it's already there

Reviewed-by: Adam King <adking@redhat.com>

doc/mgr: update prompts in prometheus.rst

Update prompts in prometheus.rst so that they're unselectable.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5a90d64b343f158d43397c70c267deb4e7ef0e00)

Merge pull request #51305 from zdover23/wip-doc-2023-05-02-backport-51299-to-reef

reef: doc/radosgw: rabbitmq - push-endpoint edit

doc/radosgw: rabbitmq - push-endpoint edit

Remove a note that directed users to change "push-endpoint" (with a
hyphen) to "push_endpoint" (with an underscore) when using rabbitmq.

Re: https://github.com/ceph/ceph/pull/48486#issuecomment-1529925389

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e4b35de2abf00d514c76f77645c587c562bab05d)

Merge pull request #51302 from zdover23/wip-doc-2023-05-02-backport-51296-to-reef

reef: doc/rados: edit stretch-mode.rst

doc/rados: edit stretch-mode.rst

Refine and supplement the introductory and explanatory text at the top
of the /doc/rados/operations/stretch-mode.rst file.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b642900abc57302e62a5064dba510c3cc5743ac0)

Merge pull request #51289 from zdover23/wip-doc-2023-04-30-backport-51285-to-reef

reef: doc/rados: edit stretch-mode procedure

doc/rados: edit stretch-mode procedure

Edit the "stretch mode" section in doc/rados/operations/stretch-mode.rst
so that the procedure is formatted as a procedure and the sentences
correctly have heads.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a19ff7a5ea9bbd24365648a90abfa1b720c5b231)

Merge pull request #51286 from zdover23/wip-doc-2023-04-29-backport-51276-to-reef

reef: docs: Update the Prometheus endpoint info

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

docs: Update the Prometheus endpoint info

This patch just tidies up some of the links and adds
an example showing how the http_sd_configs option
may be used.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit 690d34ab08f22cd988828aa2097531627000907e)

Merge pull request #51272 from zdover23/wip-doc-2023-04-28-backport-51271-to-reef

reef: doc/rados: m-config-ref: edit "background"

doc/rados: m-config-ref: edit "background"

Edit the "Background" section of doc/rados/monitor/config-ref.rst

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9223863fc83095def59b416bf70f9a828a701ccc)

Merge pull request #51148 from zdover23/wip-doc-2023-04-20-backport-51143-to-reef

reef: docs: warning and remove few docs section for Filestore

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/man/rbd: resurrect filestore alloc_size note

Mistakenly removed in commit d79f2a81541c ("docs: warning and remove
few docs section for Filestore Update docs after filestore removal.").
The kernel client, however new, will continue to be able to talk to
FileStore OSDs for as long as they exist.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit d3558c49bf0456a199cf55f73c5832f408462ec5)

Merge pull request #51239 from zdover23/wip-doc-2023-04-27-backport-51154-to-reef

reef: doc/rados/ops: edit user-management.rst (3 of x)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/rados/ops: edit user-management.rst (3 of x)

Line-edit doc/rados/user-management.rst (3 of x).

https://tracker.ceph.com/issues/58485

Follows https://github.com/ceph/ceph/pull/51140.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 97b751ed8f8917f9d4d9cbca03f224e6518836ef)

Merge pull request #51155 from zdover23/wip-doc-2023-04-20-backport-51140-to-reef

reef: doc/rados: edit user-management (2 of x)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #51235 from zdover23/wip-doc-2023-04-27-backport-51204-to-reef

reef: doc/cephfs: explain cephfs data and metadata set

doc/cephfs: explain cephfs data and metadata set

Explain how to set application metadata for the CephFS data pool and the
CephFS metadata pool.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9152f9700420f9735533f276559af87dff97bd75)

Merge pull request #51012 from cbodley/wip-59358

reef: rgw/keystone: use secret key from EC2 for sigv4 streaming mode

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #51220 from zdover23/wip-doc-2023-04-26-backport-51193-to-reef

reef: doc/start: rewrite intro paragraph

doc/start: rewrite intro paragraph

Rewrite the first paragraph in doc/start/intro.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bea01d5f1469030253a3403dbb9e2c9fa97806ac)

Merge pull request #51022 from cbodley/wip-59151

reef: rgw: install rgw scripts with common files rather than radosgw files

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51019 from cbodley/wip-59273

reef: rgw/admin: 'data sync status' formats binary error repo entries

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51024 from cbodley/wip-59133

reef: rgw/s3: DeleteObjects response uses correct delete_marker flag

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51015 from cbodley/wip-59292

reef: qa/rgw: add rgw/upgrade suite

Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #51014 from cbodley/wip-59280

reef: rgw: set init_check_compat when bucket sync status doesn't exist

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51020 from cbodley/wip-59275

reef: rgw/sts: Fixes get_cert_url improper url path concatenation

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51145 from cbodley/wip-59493

reef: cmake/rgw: librgw tests depend on ALLOC_LIBS

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51013 from cbodley/wip-59278

reef: rgw: fix CopyObj crash after admin override

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51017 from cbodley/wip-59360

reef: rgw: fix rgw cache invalidation after unregister_watch() error

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51018 from cbodley/wip-59377

reef: rgw/civetweb: handle old clients with transfer-encoding: chunked.

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51021 from cbodley/wip-59356

reef: rgw/sse-s3: fix bucket encryption of multipart upload

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51023 from cbodley/wip-59232

reef: rgw/notifications: support bucket notification with bucket policy

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #51025 from cbodley/wip-59145

reef: rgw: Do not duplicate query-string in ops-log

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51026 from cbodley/wip-59028

reef: rgw: use unique_ptr for flat_map emplace in BucketTrimWatcher

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #51027 from cbodley/wip-59013

reef: rgw/notifications: fetch object state to get size, in rgw_lc.cc

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #51028 from cbodley/wip-59220

reef: qa/rgw: unpin centos for verify suite

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #50880 from guits/wip-59310-reef

reef: ceph-volume: fix issue with fast device allocs when there are multiple PVs per VG

Merge pull request #51181 from zdover23/wip-doc-2023-04-23-backport-51177-to-reef

reef: doc/start: edit first 150 lines of documenting-ceph

Merge pull request #51184 from zdover23/wip-doc-2023-04-23-backport-51178-to-reef

reef: doc/glossary: add "Placement Groups" definition

doc/glossary: add "Placement Groups" definition

Add a definition of "Placement Groups" to the Glossary.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9f37ea651f9ee2c51e0705b9b58ed356f1bc56e6)

doc/start: edit first 50 lines of documenting-ceph

Edit the first 150 lines of doc/start/documenting-ceph.rst. This is part
of an initiative to harvest the fruits of Cephalocon 2023, at which
documentation proved to be in demand to a surprising degree.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dd37f94aa4f1de947b1eaf5d82cc529925f5823e)

mgr: take a lock within PyModuleRegistry's mutators and accessor

... that modify and access the data member 'clients' respectively.

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit a586dcc57ab35a269f0c271756951d49f422662d)

mgr: store names of modules that register RADOS clients in the MgrMap

The MgrMap stores a list of RADOS clients' addresses registered by the
mgr modules. During failover of ceph-mgr, the list is used to blocklist
clients belonging to the failed ceph-mgr.

Store the names of the mgr modules that registered the RADOS clients
along with the clients' addresses in the MgrMap. During debugging, this
allows easy identification of the mgr module that registered a
particular RADOS client by just dumping the MgrMap (`ceph mgr dump`).

Following is the MgrMap output with a module's client name displayed
along with its client addrvec,
$ ceph mgr dump | jq '.active_clients[0]'
{
  "name": "devicehealth",
  "addrvec": [
    {
      "type": "v2",
      "addr": "10.0.0.148:0",
      "nonce": 612376578
    }
  ]
}

Fixes: https://tracker.ceph.com/issues/58691
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit b545fb9f5660dca3af4dea195ea4555f09b3a6e8)

Merge pull request #51151 from rhcs-dashboard/wip-59468-reef

reef: mgr/dashboard: skip Create OSDs step in Cluster expansion

Reviewed-by: Pegonzal <NOT@FOUND>

doc/rados: edit user-management (2 of x)

Line-edit doc/rados/user-management.rst (2 of x). Some internal
references had to be removed, but these will be repaired when the next
part of this file is updated in a future PR.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e3575bb72f307a27d49fedf3692ca661e3d613a5)

mgr/dashboard: skip Create OSDs step in Cluster expansion

Its to ensure OSDs are not deployed on all hosts because that would make
the host draining impossible

Fixes: https://tracker.ceph.com/issues/59457
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 0f6d23a7aa024495a79cdedc80f7a00902115b6b)

docs: warning and remove few docs section for Filestore
Update docs after filestore removal.

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit d79f2a81541cfa9e905aef00ad517278c2692c9c)

cmake/rgw: librgw tests depend on ALLOC_LIBS

somehow this stops tcmalloc from crashing on ubuntu 20.04

Fixes: https://tracker.ceph.com/issues/59269
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit d5f97e6543906d5be898b24a1c10269ace309c76)

Merge pull request #51125 from zdover23/wip-doc-2023-04-17-backport-50639-to-reef

reef: doc: account for PG autoscaling being the default

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #51121 from rhcs-dashboard/wip-59465-reef

reef: mgr/dashboard: remove unncessary hyperlink in landing page

Reviewed-by: Pegonzal <NOT@FOUND>

Merge pull request #51123 from zdover23/wip-doc-2023-04-17-backport-49762-to-reef

reef: vstart: fix text format

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc: account for PG autoscaling being the default

The current documentation tries really hard to convince people to set
both `osd_pool_default_pg_num` and `osd_pool_default_pgp_num` in their
configs, but at least the latter has undesirable side effects on any
Ceph version that has PG autoscaling enabled by default (at least quincy
and beyond).

Assume a cluster with defaults of `64` for `pg_num` and `pgp_num`.
Starting `radosgw` will fail as it tries to create various pools without
providing values for `pg_num` or `pgp_num`. This triggers the following
in `OSDMonitor::prepare_new_pool()`:

- `pg_num` is set to `1`, because autoscaling is enabled
- `pgp_num` is set to `osd pool default pgp_num`, which we set to `64`
- This is an invalid setup, so the pool creation fails

Likewise, `ceph osd pool create mypool` (without providing values for
`pg_num` or `pgp_num`) does not work.

Following this rationale:

- Not providing a default value for `pgp_num` will always do the right
  thing, unless you use advanced features, in which case you can be
  expected to set both values on pool creation
- Setting `osd_pool_default_pgp_num` in your config breaks pool creation
  for various cases

This commit:

- Removes `osd_pool_default_pgp_num` from all example configs
- Adds mentions of the autoscaling and how it interacts with the default
  values in various places

For each file that was touched, the following maintenance was also
performed:

- Change interternal spaces to underscores for config values
- Remove mentions of filestore or any of its settings
- Fix minor inconsistencies, like indentation etc.

There is also a ticket which I think is very relevant and fixed by this,
though it only captures part of the broader issue addressed here:

Fixes: https://tracker.ceph.com/issues/47176
Signed-off-by: Conrad Hoffmann <ch@bitfehler.net>
(cherry picked from commit 402d2eacbc67f7a6d47d8f90d9ed757fc20931a6)

vstart: fix text format

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
(cherry picked from commit 57dc8ce51602543d42a2f82cb829eda1c231b434)

mgr/dashboard: remove unncessary hyperlink in landing page

Fixes: https://tracker.ceph.com/issues/59462
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 7e7da955445ecf37bc43fc296298bd91d0d8a140)

Merge pull request #51080 from rhcs-dashboard/wip-59452-reef

reef: mgr/dashboard: fix cephadm e2e expression changed error

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #51116 from zdover23/wip-doc-2023-04-17-backport-51114-to-reef

reef: doc/radosgw: format part of s3select

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

doc/radosgw: format part of s3select

Partially format the 'Basic Workflow' section's introduction and 'Basic Functionalities' subsection in s3select. Nothing else is being fixed.

Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
(cherry picked from commit 13cf134c0610509da52aa68e11e26f0740002bde)

Merge pull request #51110 from zdover23/wip-doc-2023-04-16-backport-50941-to-reef

reef: doc/foundation: Update Foundation members for April 2023

Merge pull request #51107 from zdover23/wip-doc-2023-04-16-backport-51099-to-reef

reef: doc/dev: format command in cephfs-mirroring

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

Merge pull request #51096 from zdover23/wip-doc-2023-04-16-backport-51062-to-reef

reef: doc/glossary: add "Hybrid Storage"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

Merge pull request #51092 from zdover23/wip-doc-2023-04-16-backport-51091-to-reef

reef: doc/mgr/prometheus: fix confval reference

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

doc/foundation: Update Foundation members for April 2023

Signed-off-by: Mike Perez <thingee@gmail.com>
(cherry picked from commit 759f26a99f7a1b52954e12e080304b867af81418)

doc/dev: format command in cephfs-mirroring

Correctly format a command in doc/dev/cephfs-mirroring/#creating-users.

Reported by casanlin@init7.net at
https://pad.ceph.com/p/Report_Documentation_Bugs

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 408219bfca6b1e698229967e76d22d10028b7c20)

Merge pull request #51104 from zdover23/wip-doc-2023-04-16-backport-51103-to-reef

reef: doc/radosgw: format part of s3select

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

doc/radosgw: format part of s3select

Format the first section of s3select. Nothing else is being fixed.

Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
(cherry picked from commit a6a84471a7af154e7ccc93f51df2fc9744dc606c)

doc/glossary: add "Hybrid Storage"

Add "Hybrid Storage" to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dc8148d0727b307fb3baa30baf9dfee9bf8a247e)

doc/mgr/prometheus: fix confval reference

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
(cherry picked from commit b9b75dafe248e07b21f2958023697397094cc537)

Merge pull request #51087 from zdover23/wip-doc-2023-04-15-backport-51086-to-reef

reef: doc/rados/ops: remove ceph-medic from monitoring

doc/rados/ops: remove ceph-medic from monitoring

Remove mention of ceph-medic from doc/rados/operations/monitoring.rst,
because it is no longer supported.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 42cd28a2a639e68a44838ae4e7f875cb6bd5d97b)

mgr/dashboard: fix cephadm e2e expression changed error

tried to fix this issue from the daemon component sometime ago several
times but it didn't work. So force ignoring the error

Fixes: https://tracker.ceph.com/issues/59444
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit f7e29e5ab85fabcf2524656bb456a2955fa8608d)

Merge pull request #51010 from rhcs-dashboard/wip-59420-reef

reef: mgr/dashboard: fix eviction of all FS clients

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #51063 from zdover23/wip-doc-2023-04-13-backport-50713-to-reef

reef: doc/glossary: improve "CephX" entry

doc/glossary: improve "CephX" entry

Improve the glossary entry for "CephX".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 02e3a5cb763987eeaee2dd1a7543d2762aaad7fe)

Merge pull request #50919 from idryomov/wip-rbd-reef-backports-1

reef: RBD backports (batch 1)

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #51058 from rhcs-dashboard/wip-59436-reef

reef: mgr/dashboard: rbd-mirror force promotion

Reviewed-by: Nizamudeen A <nia@redhat.com>

qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

qemu-utils is usually pre-installed but, due to what appears to be
a Ubuntu packaging bug, it's not upgraded when qemu-block-extra is
installed:

  The following NEW packages will be installed:
    qemu-block-extra
  The following packages will be upgraded:
    qemu-system-common qemu-system-data qemu-system-gui qemu-system-x86

However, the version of the block driver must match exactly the version
of the qemu-img tool, so the above leads to:

  $ qemu-img convert -f qcow2 -O raw /home/ubuntu/cephtest/qemu/base.client.0.0.qcow2 rbd:rbd/client.0.0
  Failed to initialize module: /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
  Note: only modules from the same build can be loaded.
  qemu: module block-block-rbd not found, do you want to install qemu-block-extra package?
  qemu-img: Unknown protocol 'rbd'

Fixes: https://tracker.ceph.com/issues/59431
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit c529fdd63a5aae2c598078df05fe9bbef40042dc)

mgr/dashboard: rbd-mirror force promotion

resolves: https://tracker.ceph.com/issues/59327
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 9696b6a04830297c23c4cccd6e7c225f183ba0b2)

Merge pull request #51035 from zdover23/wip-doc-2023-04-12-backport-50993-to-reef

reef: doc/rados/operations: edit monitoring.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #50994 from guits/cv-bkp-50473-reef

ceph-volume: update the OS before deploying Ceph (reef)

doc/rados/operations: edit monitoring.rst

Line-edit the final third of doc/rados/operations/monitoring.rst.

Follows https://github.com/ceph/ceph/pull/50834.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b9ccad80608953fc0af779e8cad93971d47649b6)

Merge pull request #51006 from rhcs-dashboard/wip-59402-reef

reef: mgr/dashboard: fix create osd default selected as recommended not working

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>

qa/rgw: unpin centos for verify suite

use a random supported distro instead of centos

Fixes: https://tracker.ceph.com/issues/54102
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 4bc1f376b901f809748b751d45899e512738c934)

rgwlc/notifications: also fix etag

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 7c58b2a9f3cb3f31398065d862e264bb248760bf)

rgw/notifications: fetch object state to get size, in rgw_lc.cc

Failure to call get_obj_state() leaves object size and other members
uninitialized, and appears to result in in lc delete notifications
with 0 for object size.

Fixes: https://tracker.ceph.com/issues/58287
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit b20a66767f782c06258fb0a5551ee45d6dccb91c)

rgw: use unique_ptr for flat_map emplace in BucketTrimWatcher

When emplacing objects into the trim notify handler of
BucketTrimWatcher, use a unique_ptr for the handler so that it is
destroyed if the emplace fails.

Though the destructor is already called, this behaviour cannot be relied
upon. std::map does not exhibit the same behaviour, and would have
leaked memory had it been used instead.

Fixes: https://tracker.ceph.com/issues/57938
Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
(cherry picked from commit 43ef4753eb338781529a7dc8360eab13d56fce85)

Do not duplicate query-string in ops-log

Fixes: https://tracker.ceph.com/issues/59059
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 3f2313f0e67c444407139c80dff596c5d5b5903e)

rgw/s3: DeleteObjects response uses correct delete_marker flag

use delete_marker from the DeleteOp result, not from the sal::Object

Fixes: https://tracker.ceph.com/issues/59048
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 7288cbe28035867540b68dfcbc4894e1fb50ea2e)

rgw/notifications: support bucket notification with bucket policy

following policy should be used to allow any user to get, put and delete
bucket notification on a bucket called "my-bucket":
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Sid": "Statement",
      "Effect": "Allow",
      "Principal": "*",
      "Action": ["s3:GetBucketNotification", "s3:PutBucketNotification"],
      "Resource": "arn:aws:s3:::my-bucket"
    }
  ]
}

note that notification deletion uses the "PUT" permission.

Fixes: https://tracker.ceph.com/issues/59136
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit e100d392a0ed4a22d8544d25299df2366e727d4c)

rgw: add unordered listing to reindex to force stats update

By including an unordered listing in the script, we will complete
placing objects in the bucket index and allow stats to be updated
rather than waiting for this to happen organically at a user's
request. Unordered is preferred as it can run more efficiently.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 71b2c2a6dd288e2bb8ec73cff3e909a0f12f2b5c)

rgw: install rgw scripts with common files rather than radosgw files

Update ceph.spec.in and debian install files so
rgw-restore-bucket-index, rgw-orphan-list, rgw-gap-list,
rgw-gap-list-comparator are installed with common files.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 637d461bf12b68d2c04f326139367dcfda0664ce)