]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agomgr/dashboard: fix spacing of embedded grafana buttons 51555/head
Pedro Gonzalez Gomez [Thu, 18 May 2023 10:10:11 +0000 (12:10 +0200)]
mgr/dashboard: fix spacing of embedded grafana buttons

Fixes: https://tracker.ceph.com/issues/61220
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #51531 from rhcs-dashboard/rename-service-details-to-daemons
Aashish Sharma [Thu, 18 May 2023 08:43:19 +0000 (14:13 +0530)]
Merge pull request #51531 from rhcs-dashboard/rename-service-details-to-daemons

mgr/dashboard: rename Service>Details to Service>Daemons

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51449 from amathuria/wip-rbd-suite-change-mclock-profile
Ilya Dryomov [Thu, 18 May 2023 07:28:00 +0000 (09:28 +0200)]
Merge pull request #51449 from amathuria/wip-rbd-suite-change-mclock-profile

qa/tasks: Changing default mClock profile to high_recovery_ops

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge PR #49691 into main
Venky Shankar [Thu, 18 May 2023 07:19:33 +0000 (12:49 +0530)]
Merge PR #49691 into main

* refs/pull/49691/head:
qa: add test for opening a file via a hard link that is not in the same mds as the inode
mds: rdlock_path_xlock_dentry supports returning auth target inode

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoqa/tasks: Change default mClock profile to high_recovery_ops 51449/head
Aishwarya Mathuria [Thu, 11 May 2023 17:20:15 +0000 (22:50 +0530)]
qa/tasks: Change default mClock profile to high_recovery_ops

With the new mClock default profile, tests were failing with "Exiting scrub checking -- not all pgs scrubbed" due to slower scrubs.
Changing the default profile to high_recovery_ops for testing purposes will fix this issue.

Fixes: https://tracker.ceph.com/issues/61228
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 years agoMerge pull request #46985 from fengyueqiao/fix-the-comment-of-RecoveryState-hierarchical
Samuel Just [Wed, 17 May 2023 23:34:02 +0000 (16:34 -0700)]
Merge pull request #46985 from fengyueqiao/fix-the-comment-of-RecoveryState-hierarchical

osd: fix the comment of RecoveryState hierarchical structure

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51534 from zdover23/wip-doc-2023-05-17-cephfs-mirroring-cleanup
zdover23 [Wed, 17 May 2023 21:20:28 +0000 (07:20 +1000)]
Merge pull request #51534 from zdover23/wip-doc-2023-05-17-cephfs-mirroring-cleanup

doc/cephfs: line-edit "Mirroring Module"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #51444 from jianwei1216/handle_osd_map_use_deep_copy
Yuri Weinstein [Wed, 17 May 2023 20:09:00 +0000 (13:09 -0700)]
Merge pull request #51444 from jianwei1216/handle_osd_map_use_deep_copy

osd/OSDMap: improve efficiency for OSD::handle_osd_map

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #50531 from YiteGu/op-delayed-detail
Yuri Weinstein [Wed, 17 May 2023 20:08:33 +0000 (13:08 -0700)]
Merge pull request #50531 from YiteGu/op-delayed-detail

osd/OpRequest: Add detail description for delayed op in osd log file

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agomgr/dashboard: rename Service>Details to Service>Daemons 51531/head
Pere Diaz Bou [Wed, 17 May 2023 11:19:10 +0000 (13:19 +0200)]
mgr/dashboard: rename Service>Details to Service>Daemons

Daemons and services are not interchangeable in cephadm terms. As stated
in the docs: `A daemon is a systemd unit that is running and part of a
service.` https://docs.ceph.com/en/latest/cephadm/services/#daemon-status

Fixes: https://tracker.ceph.com/issues/61214
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2 years agodoc/cephfs: line-edit "Mirroring Module" 51534/head
Zac Dover [Wed, 17 May 2023 12:25:38 +0000 (22:25 +1000)]
doc/cephfs: line-edit "Mirroring Module"

Line-edit the "Mirroring Module" section of
doc/cephfs/cephfs-mirroring.rst. Add prompts and formatting where such
things contribute to the realization of adequate sentences.

This commit is a follow-up to https://github.com/ceph/ceph/pull/51505.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51513 from cbodley/wip-59490
Casey Bodley [Wed, 17 May 2023 13:04:35 +0000 (09:04 -0400)]
Merge pull request #51513 from cbodley/wip-59490

rgw: use string_view to parse Accept header

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #51279 from pkalever/cleanup-logs
Ilya Dryomov [Wed, 17 May 2023 08:46:47 +0000 (10:46 +0200)]
Merge pull request #51279 from pkalever/cleanup-logs

librbd: clean up a few log messages

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge PR #50594 into main
Venky Shankar [Wed, 17 May 2023 06:17:15 +0000 (11:47 +0530)]
Merge PR #50594 into main

* refs/pull/50594/head:
mds: remove inappropriate initialization of num_imported

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51505 from vshankar/wip-cephfs-mirror-add-explanation
zdover23 [Wed, 17 May 2023 04:51:30 +0000 (14:51 +1000)]
Merge pull request #51505 from vshankar/wip-cephfs-mirror-add-explanation

doc: explain cephfs mirroring `peer_add` step in detail

Reviewed-by: Zac Dover <zac.dover.proton.me>
2 years agoMerge pull request #51297 from Matan-B/wip-matanb-locker-request-str
Ilya Dryomov [Tue, 16 May 2023 18:34:38 +0000 (20:34 +0200)]
Merge pull request #51297 from Matan-B/wip-matanb-locker-request-str

librbd/managed_lock/GetLockerRequest: Fix no valid lockers case

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51454 from ajarr/wip-59713
Ilya Dryomov [Tue, 16 May 2023 18:28:33 +0000 (20:28 +0200)]
Merge pull request #51454 from ajarr/wip-59713

rbd_support: recover from "double blocklisting"

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: cleanup few log lines 51279/head
Prasanna Kumar Kalever [Fri, 28 Apr 2023 08:46:35 +0000 (14:16 +0530)]
librbd: cleanup few log lines

Currently:
2023-04-28T12:20:17.135+0530 7f1a7ccd2640 20 librbd::ExclusiveLock: 0x7f1a4c000b60 block_requestsr=0
[...]
2023-04-28T12:20:17.135+0530 7f1a7ccd2640 20 librbd::ManagedLock: 0x7f1a4c000b78 is_lock_owner: =1
[...]
2023-04-18T21:18:50.695+0530 7f0a1ffff640 20 librbd::ImageWatcher: 0x7f0a10007840 remote async request finished: [4305,140018014309120,1] = -110

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2 years agorgw: use string_view to parse Accept header 51513/head
Casey Bodley [Tue, 16 May 2023 12:24:29 +0000 (08:24 -0400)]
rgw: use string_view to parse Accept header

avoid copying the header into a separate buffer to do comparisons

Fixes: https://tracker.ceph.com/issues/59490
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoosd/OSDMap: improve efficiency for OSD::handle_osd_map 51444/head
zhangjianwei [Thu, 11 May 2023 13:34:13 +0000 (13:34 +0000)]
osd/OSDMap: improve efficiency for OSD::handle_osd_map

- improve OSDMap::decode performance by page-aligning bufferlist
  - align osdmap buffer memory pages in OSDService::_get_map_bl()
  - align osdmap bluffer memory pages in OSDService::get_inc_map_bl
- use OSDMap::deepish_copy_from in OSD::handle_osd_map instead of OSDMap::decode

co-author: yanghonggang <yanghonggang_yewu@cmss.chinamobile.com>
Signed-off-by: zhangjianwei <zhangjianwei2_yewu@cmss.chinamobile.com>
2 years agodoc: explain cephfs mirroring `peer_add` step in detail 51505/head
Venky Shankar [Tue, 16 May 2023 05:25:34 +0000 (10:55 +0530)]
doc: explain cephfs mirroring `peer_add` step in detail

@zdover23 reached out regarding missing explanation for `peer_add`
step in cephfs mirroring documentation. Add some explanation and
and example to make the step clear.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51492 from zdover23/wip-doc-2023-05-16-start-os-recommendations
zdover23 [Tue, 16 May 2023 05:10:18 +0000 (15:10 +1000)]
Merge pull request #51492 from zdover23/wip-doc-2023-05-16-start-os-recommendations

doc/start: KRBD feature flag support note

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #51385 from rhcs-dashboard/fix-cephPgImbalance-regression
Nizamudeen A [Tue, 16 May 2023 04:47:34 +0000 (10:17 +0530)]
Merge pull request #51385 from rhcs-dashboard/fix-cephPgImbalance-regression

mgr/dashboard: fix regression caused by cephPgImabalance alert

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50537 from mrstarke/main
Casey Bodley [Mon, 15 May 2023 21:09:28 +0000 (17:09 -0400)]
Merge pull request #50537 from mrstarke/main

rgw/swift: check position of first slash in slo manifest files

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 years agoMerge pull request #49767 from cbodley/wip-rgw-replicated-from
Casey Bodley [Mon, 15 May 2023 21:08:54 +0000 (17:08 -0400)]
Merge pull request #49767 from cbodley/wip-rgw-replicated-from

rgw: fetch_remote_obj() adds x-rgw-replicated-from headers

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agorbd_support: recover from "double blocklisting" 51454/head
Ramana Raja [Wed, 10 May 2023 18:37:44 +0000 (14:37 -0400)]
rbd_support: recover from "double blocklisting"

Recover from being blocklisted while recovering from blocklisting.
When the rbd_support  module is being set up to recover from client
blocklisting, the module's new rados client connection can also get
blocklisted. Currently, this will cause the recovery to fail and
the module will remain inoperable. Instead, retry module recovery
when the new client gets blocklisted during the module setup in the
recovery thread.

Fixes: https://tracker.ceph.com/issues/59713
Signed-off-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #50536 from smanjara/wip-rgw-return-enoent
Shilpa Jagannath [Mon, 15 May 2023 19:36:24 +0000 (15:36 -0400)]
Merge pull request #50536 from smanjara/wip-rgw-return-enoent

rgw/multisite: don't retry in error repo if bucket instance does not exist

2 years agoMerge pull request #51085 from smanjara/wip-fix-num-shards-0
Shilpa Jagannath [Mon, 15 May 2023 19:16:30 +0000 (15:16 -0400)]
Merge pull request #51085 from smanjara/wip-fix-num-shards-0

rgw/multisite: handle shard_id correctly in data sync when bucket num_shards is 0

2 years agodoc/start: KRBD feature flag support note 51492/head
Zac Dover [Mon, 15 May 2023 17:04:43 +0000 (03:04 +1000)]
doc/start: KRBD feature flag support note

Add KRBD feature flag support note to doc/start/os-recommendations.rst.

This change was suggested by Anthony D'Atri in https://github.com/ceph/ceph/pull/51485.

Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge PR #47752 into main
Venky Shankar [Mon, 15 May 2023 16:50:50 +0000 (22:20 +0530)]
Merge PR #47752 into main

* refs/pull/47752/head:
test/libcephfs: add test case for revoking caps
mds: remove the cap directly when releasing the cap
mds: add the revoking caps back to _revokes list
mds: move confirm_receipt() to Capability.cc

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51485 from idryomov/wip-os-recommendations-drop-4.14
zdover23 [Mon, 15 May 2023 16:21:47 +0000 (02:21 +1000)]
Merge pull request #51485 from idryomov/wip-os-recommendations-drop-4.14

doc/start/os-recommendations: drop 4.14 kernel and reword guidance

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51453 from yuvalif/wip-yuval-fix-59733
Yuval Lifshitz [Mon, 15 May 2023 15:56:57 +0000 (18:56 +0300)]
Merge pull request #51453 from yuvalif/wip-yuval-fix-59733

rgw/lua: add lib64 to the package search path

2 years agoMerge pull request #45958 from ofriedma/wip-ofriedma-sync-fairness-bidding
Casey Bodley [Mon, 15 May 2023 15:24:11 +0000 (11:24 -0400)]
Merge pull request #45958 from ofriedma/wip-ofriedma-sync-fairness-bidding

rgw: sync fairness bidding

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agodoc/start/os-recommendations: drop 4.14 kernel and reword guidance 51485/head
Ilya Dryomov [Fri, 12 May 2023 11:55:32 +0000 (13:55 +0200)]
doc/start/os-recommendations: drop 4.14 kernel and reword guidance

The 4.14 LTS kernel has less than a year left in terms of maintenance,
drop it.

Also, the current wording with an explicit list of kernels tends to go
stale: it's missing the latest 6.1 LTS kernel.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51415 from yuvalif/wip-yuval-fix-59698
Yuval Lifshitz [Mon, 15 May 2023 14:02:48 +0000 (17:02 +0300)]
Merge pull request #51415 from yuvalif/wip-yuval-fix-59698

rgw/lua: add more info on package install errors

2 years agoMerge pull request #50471 from galsalomon66/json_s3tests_and_more
Casey Bodley [Mon, 15 May 2023 13:50:37 +0000 (09:50 -0400)]
Merge pull request #50471 from galsalomon66/json_s3tests_and_more

Trino/RGW alignments  & adding JSON queries to s3tests

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #51343 from guits/tracker_59640
Guillaume Abrioux [Mon, 15 May 2023 11:02:57 +0000 (13:02 +0200)]
Merge pull request #51343 from guits/tracker_59640

ceph-volume: fix a bug in `get_lvm_fast_allocs()` (batch)

2 years agoMerge pull request #51410 from ceph/revert-50392-seastore-cephadm
Guillaume Abrioux [Mon, 15 May 2023 11:02:20 +0000 (13:02 +0200)]
Merge pull request #51410 from ceph/revert-50392-seastore-cephadm

Revert "ceph-volume: assign seastore as object store backend when deplying crimson-osd using LVM with cephadm"

2 years agoMerge pull request #51473 from zdover23/wip-doc-2023-05-15-rados-operations-devices
zdover23 [Mon, 15 May 2023 10:18:30 +0000 (20:18 +1000)]
Merge pull request #51473 from zdover23/wip-doc-2023-05-15-rados-operations-devices

doc/rados: edit devices.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com
2 years agomds: remove inappropriate initialization of num_imported 50594/head
Yongseok Oh [Mon, 20 Mar 2023 10:24:25 +0000 (19:24 +0900)]
mds: remove inappropriate initialization of num_imported

The variable num_imported is being passed by reference. Additionally,
the decode_import_dir() function is invoked from handle_export_dir(),
where num_imported is initialized and passed by reference.
Therefore, there is no need to initialize it again within
the decode_import_dir() function.

fixes: https://tracker.ceph.com/issues/59107

Signed-off-by: Yongseok Oh <yongseok.oh@linecorp.com>
2 years agodoc/rados: edit devices.rst 51473/head
Zac Dover [Mon, 15 May 2023 01:01:19 +0000 (11:01 +1000)]
doc/rados: edit devices.rst

Line-edit doc/rados/operations/devices.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge PR #51386 into main
Venky Shankar [Mon, 15 May 2023 06:56:46 +0000 (12:26 +0530)]
Merge PR #51386 into main

* refs/pull/51386/head:
qa: ignore cluster warning when fs flag refuse_client_session is set

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #50806 from rhcs-dashboard/dashboard-multisite-migrate
Aashish Sharma [Mon, 15 May 2023 06:38:12 +0000 (12:08 +0530)]
Merge pull request #50806 from rhcs-dashboard/dashboard-multisite-migrate

Dashboard multisite migrate

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: Migrate from single site to multi-site 50806/head
Aashish Sharma [Thu, 20 Apr 2023 05:22:41 +0000 (10:52 +0530)]
mgr/dashboard: Migrate from single site to multi-site

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51463 from zdover23/wip-doc-2023-05-13-fs-volumes-1-of-x
zdover23 [Sat, 13 May 2023 02:41:36 +0000 (12:41 +1000)]
Merge pull request #51463 from zdover23/wip-doc-2023-05-13-fs-volumes-1-of-x

doc/cephfs: edit fs-volumes.rst (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephfs: edit fs-volumes.rst (1 of x) 51463/head
Zac Dover [Fri, 12 May 2023 15:49:14 +0000 (01:49 +1000)]
doc/cephfs: edit fs-volumes.rst (1 of x)

Edit the syntax of the English language in the file
doc/cephfs/fs-volumes.rst up to (but not including) the section called
"FS Subvolumes".

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51458 from zdover23/wip-doc-2023-05-12-cephfs-fs-volumes-prompt...
zdover23 [Fri, 12 May 2023 12:42:23 +0000 (22:42 +1000)]
Merge pull request #51458 from zdover23/wip-doc-2023-05-12-cephfs-fs-volumes-prompt-rectification

doc/cephfs: rectify prompts in fs-volumes.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephfs: rectify prompts in fs-volumes.rst 51458/head
Zac Dover [Fri, 12 May 2023 10:35:25 +0000 (20:35 +1000)]
doc/cephfs: rectify prompts in fs-volumes.rst

Make sure all prompts are unselectable. This PR is meant to be
backported to Reef, Quincy, and Pacific, to get all of the prompts into
a fit state so that a line-edit can be performed on the Englsh language
in this file.

Follows https://github.com/ceph/ceph/pull/51427.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agorgw/lua: add lib64 to the package search path 51453/head
Yuval Lifshitz [Thu, 11 May 2023 18:59:32 +0000 (21:59 +0300)]
rgw/lua: add lib64 to the package search path

Fixes: https://tracker.ceph.com/issues/59733
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
2 years agoMerge pull request #51448 from Matan-B/wip-matanb-crimson-only-mclock-boot
Samuel Just [Thu, 11 May 2023 18:35:20 +0000 (11:35 -0700)]
Merge pull request #51448 from Matan-B/wip-matanb-crimson-only-mclock-boot

crimson/osd/scheduler/mclock_scheduler: Fix OSD unable to start

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51388 from Matan-B/wip-matanb-c-enable-rbd-tests
Matan [Thu, 11 May 2023 14:28:55 +0000 (16:28 +0200)]
Merge pull request #51388 from Matan-B/wip-matanb-c-enable-rbd-tests

qa/suites/crimson: Enhance rbd api testing

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
2 years agocrimson/osd/scheduler/mclock_scheduler: Fix OSD unable to start 51448/head
Matan Breizman [Thu, 11 May 2023 14:18:46 +0000 (14:18 +0000)]
crimson/osd/scheduler/mclock_scheduler: Fix OSD unable to start

https://github.com/ceph/ceph/pull/49975 Introduced changes to
mclock conf value types which caused the osd to stall while booting.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoRevert "ceph-volume: assign seastore as object store backend when deplying crimson... 51410/head
Guillaume Abrioux [Tue, 9 May 2023 16:49:10 +0000 (18:49 +0200)]
Revert "ceph-volume: assign seastore as object store backend when deplying crimson-osd using LVM with cephadm"

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 years agoMerge PR #51251 into main
Venky Shankar [Thu, 11 May 2023 05:51:14 +0000 (11:21 +0530)]
Merge PR #51251 into main

* refs/pull/51251/head:
PendingReleaseNotes: add a note about deleting files from lost+found directory
qa: add checks that validate removal of entries from lost+found dir
mds: allow unlink operation under lost+found directory

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge PR #51201 into main
Venky Shankar [Thu, 11 May 2023 05:49:13 +0000 (11:19 +0530)]
Merge PR #51201 into main

* refs/pull/51201/head:
qa: run scrub post file system recovery

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2 years agoMerge PR #51188 into main
Venky Shankar [Thu, 11 May 2023 03:55:50 +0000 (09:25 +0530)]
Merge PR #51188 into main

* refs/pull/51188/head:
client: use deep-copy when setting permission during make_request

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
2 years agoMerge pull request #51423 from bigjust/replace-go-example-mods
Ken Dreyer [Wed, 10 May 2023 17:18:22 +0000 (13:18 -0400)]
Merge pull request #51423 from bigjust/replace-go-example-mods

examples: replace example go modules with instructions to run

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
2 years agoMerge pull request #51427 from zdover23/wip-doc-2023-05-10-cephfs-fs-volumes-prompt-fix
zdover23 [Wed, 10 May 2023 15:30:44 +0000 (01:30 +1000)]
Merge pull request #51427 from zdover23/wip-doc-2023-05-10-cephfs-fs-volumes-prompt-fix

doc/cephfs: fix prompts in fs-volumes.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agorgw/multisite: use intrusive_ptr instead of raw ptr for notify_stack 45958/head
Shilpa Jagannath [Tue, 11 Apr 2023 15:13:25 +0000 (11:13 -0400)]
rgw/multisite: use intrusive_ptr instead of raw ptr for notify_stack

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agorgw/multisite: - add a lost_bid variable to handle is_highest_bidder() control flow
Shilpa Jagannath [Tue, 14 Mar 2023 02:14:24 +0000 (22:14 -0400)]
rgw/multisite: - add a lost_bid variable to handle is_highest_bidder() control flow
- check for is_highest_bidder() before even attempting to take the lock
- don't block on RGWMetaSyncShardNotifyCR()
- other minor fixes

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agorgw/multisite: clean up
Shilpa Jagannath [Wed, 8 Mar 2023 21:05:10 +0000 (16:05 -0500)]
rgw/multisite: clean up

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agorgw/multisite: periodically check if we still have the highest bid.
Shilpa Jagannath [Mon, 6 Mar 2023 17:43:49 +0000 (12:43 -0500)]
rgw/multisite: periodically check if we still have the highest bid.
If we are outbid, exit after updating sync status.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agorgw/multisite: add a timer coroutine to call notify_cr() at intervals
Shilpa Jagannath [Thu, 2 Mar 2023 04:17:23 +0000 (23:17 -0500)]
rgw/multisite: add a timer coroutine to call notify_cr() at intervals

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agorgw: multisite metadata sync fairness
Or Friedmann [Wed, 16 Feb 2022 17:00:33 +0000 (17:00 +0000)]
rgw: multisite metadata sync fairness

    multisite metadata sync fairness

    The approach of this commit is to allow multiple RGWs to participate in the multisite metadata sync.
    Before this commit only single RGW has caught the all the sync locks.
    This feature is using bidding algorithm.
    For each lock, RGW is randomizing a number from 0 to shard count and for each shard is picking randomally one number and giving it as the bid_amount.
    each one of those vectors each RGW handles are being sent using watch notify (based on RADOS watch notify).
    Each time the RGW tries to lock it will compare its bid for the lock and the bids of other rgws, if the current RGW has the highest bid it will try to acquire the lock.

    Important configs:

    rgw_sync_work_period - For how long the RGW will sync until it will send unlock (very important in the beggining, because in the beginning only single RGW holds the locks)
    rgw_sync_lease_period - not new to this commit but affecting it, For how many seconds the RGW will request from the RADOS to keep the lock, mainly important in case of failure, so automatically the RGW will lose a lock if it's down

Fixes: https://tracker.ceph.com/issues/41230
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Signed-off-by: Or Friedmann <ofriedma@ibm.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agorgw/sync: add a BidManager to metadata sync
Casey Bodley [Mon, 5 Dec 2022 22:40:10 +0000 (17:40 -0500)]
rgw/sync: add a BidManager to metadata sync

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agorgw: add BidManager for sync fairness via watch/notify
Casey Bodley [Mon, 5 Dec 2022 21:43:44 +0000 (16:43 -0500)]
rgw: add BidManager for sync fairness via watch/notify

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agodoc/cephfs: fix prompts in fs-volumes.rst 51427/head
Zac Dover [Wed, 10 May 2023 14:52:50 +0000 (00:52 +1000)]
doc/cephfs: fix prompts in fs-volumes.rst

Fixed a regression introduced in
e5355e3d66e1438d51de6b57eae79fab47cd0184 that broke the unselectable
prompts in the RST.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51345 from cbodley/wip-59639
Casey Bodley [Wed, 10 May 2023 12:56:37 +0000 (08:56 -0400)]
Merge pull request #51345 from cbodley/wip-59639

rgw/dbstore: allow NULL RealmIDs in sqlite schema

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoexamples: replace example go modules with instructions to run 51423/head
Justin Caratzas [Tue, 18 Apr 2023 16:35:37 +0000 (12:35 -0400)]
examples: replace example go modules with instructions to run

Signed-off-by: Justin Caratzas <jcaratza@ibm.com>
2 years agoMerge pull request #50627 from AliMasarweh/wip-ali-masa-multipart-populate-etag
Ali Masarwa [Wed, 10 May 2023 12:10:12 +0000 (15:10 +0300)]
Merge pull request #50627 from AliMasarweh/wip-ali-masa-multipart-populate-etag

RGW: Solving the issue of not populating etag in Multipart upload result
Reviewed-by: Daniel Gryniewicz <dang1@ibm.com>
2 years agorolling back 50471/head
galsalomon66 [Wed, 10 May 2023 09:56:46 +0000 (12:56 +0300)]
rolling back

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
2 years agoMerge pull request #49742 from ajarr/fix-56724
Ilya Dryomov [Wed, 10 May 2023 09:55:42 +0000 (11:55 +0200)]
Merge pull request #49742 from ajarr/fix-56724

mgr/rbd_support: recover from rados client blocklisting

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51166 from chrisphoffman/wip-rbd-59393
Ilya Dryomov [Wed, 10 May 2023 09:53:16 +0000 (11:53 +0200)]
Merge pull request #51166 from chrisphoffman/wip-rbd-59393

librbd: localize snap_remove op for mirror snapshots

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge PR #43184 into main
Venky Shankar [Wed, 10 May 2023 08:34:58 +0000 (14:04 +0530)]
Merge PR #43184 into main

* refs/pull/43184/head:
qa: fix journal flush failure issue due to the MDS daemon crashes
qa: add test support for the alloc ino failing
mds: do not take the ino which has been used

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoqa: run scrub post file system recovery 51201/head
Venky Shankar [Mon, 24 Apr 2023 04:54:55 +0000 (00:54 -0400)]
qa: run scrub post file system recovery

Running file system scrub is recommended post running filesystem
data and metadata recovery. Running scrub isn't covered in tests.

Fixes: http://tracker.ceph.com/issues/59527
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51167 from liu-chunmei/teuthology-multicore
Liu-Chunmei [Tue, 9 May 2023 23:04:47 +0000 (16:04 -0700)]
Merge pull request #51167 from liu-chunmei/teuthology-multicore

crimson/qa: make crimson run multicore in teuthology test

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51301 from ceph/wip-yuriw-release-16.2.13-main
Laura Flores [Tue, 9 May 2023 22:04:38 +0000 (17:04 -0500)]
Merge pull request #51301 from ceph/wip-yuriw-release-16.2.13-main

doc: 16.2.13 Release Notes

2 years agodoc: 16.2.13 Release Notes 51301/head
Yuri Weinstein [Mon, 1 May 2023 20:09:47 +0000 (13:09 -0700)]
doc: 16.2.13 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #50411 from xxhdx1985126/wip-58928
Samuel Just [Tue, 9 May 2023 18:55:41 +0000 (11:55 -0700)]
Merge pull request #50411 from xxhdx1985126/wip-58928

crimson/osd: start operations asynchrously

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agorgw/lua: add more info on package install errors 51415/head
Yuval Lifshitz [Tue, 9 May 2023 18:10:37 +0000 (21:10 +0300)]
rgw/lua: add more info on package install errors

Fixes: https://tracker.ceph.com/issues/59698
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
2 years agoMerge pull request #51403 from zdover23/wip-doc-2023-05-09-start-get-involved-planet...
zdover23 [Tue, 9 May 2023 14:50:01 +0000 (00:50 +1000)]
Merge pull request #51403 from zdover23/wip-doc-2023-05-09-start-get-involved-planet-ceph

doc/start: fix "Planet Ceph" link

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoadding s3test albin/json-op-serial
galsalomon66 [Fri, 10 Mar 2023 12:27:05 +0000 (14:27 +0200)]
adding s3test albin/json-op-serial
modify json chunk processing function to handle offset/length as csv-processing
a fix valgrind :: Conditional jump or move depends on uninitialised value
upon using Trino the Trino-server issue multiple requests per single query,upon completion of all requests
the results are merged (by Trino).  these request splits the input into equal parts; the RGW side should be aligned with Trino expectations(for result).
fixing the main routine for shaping the chunk (range-scan) for Trino processing
upon removing the payload-TAG, it need to change the response element index
handling more use cases for "shaping" the processed chunk by s3select per Trino request
re-shape the processed chunk only upon Trino sent the request
bug-fix: the chunk offset was not handle correctly
bug-fix: progress-message calcualation
modifying the range-request boundaries only upon Trino request.

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
2 years agocrimson/qa: enable multicore for crimson in teuthology test 51167/head
chunmei [Thu, 20 Apr 2023 22:09:34 +0000 (22:09 +0000)]
crimson/qa: enable multicore for crimson in teuthology test

Signed-off-by: chunmei <chunmei.liu@intel.com>
2 years agoMerge pull request #47749 from xxhdx1985126/wip-intra-fixedkvbtree-pointers-2
Yingxin [Tue, 9 May 2023 08:37:41 +0000 (16:37 +0800)]
Merge pull request #47749 from xxhdx1985126/wip-intra-fixedkvbtree-pointers-2

crimson/os/seastore/btree: link fixedkvbtree's nodes and logical extents with forward and backward pointers, and drop the pin_set

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51308 from jzhu116-bloomberg/wip-59592
Yuval Lifshitz [Tue, 9 May 2023 07:34:36 +0000 (10:34 +0300)]
Merge pull request #51308 from jzhu116-bloomberg/wip-59592

rgw/notification: remove non x-amz-meta-* attributes from bucket notifications

2 years agocrimson/tools/store_nbd: read logical extents via 47749/head
Xuehan Xu [Mon, 8 May 2023 08:15:55 +0000 (08:15 +0000)]
crimson/tools/store_nbd: read logical extents via
TransactionManager::read_pin()

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/cache: add comment about backref_extent_entry_t
Xuehan Xu [Thu, 23 Mar 2023 09:59:12 +0000 (09:59 +0000)]
crimson/os/seastore/cache: add comment about backref_extent_entry_t

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agotest/crimson/seastore: complement lba test with logical extents
Xuehan Xu [Sat, 11 Mar 2023 03:46:14 +0000 (03:46 +0000)]
test/crimson/seastore: complement lba test with logical extents

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agotest/crimson/seastore: check intra-fixedkv-btree parent->child trackers during unittests
Xuehan Xu [Mon, 29 Aug 2022 08:12:00 +0000 (16:12 +0800)]
test/crimson/seastore: check intra-fixedkv-btree parent->child trackers during unittests

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/btree: drop btree_pin_set_t
Xuehan Xu [Mon, 27 Mar 2023 02:20:59 +0000 (02:20 +0000)]
crimson/os/seastore/btree: drop btree_pin_set_t

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/transaction_manager: follow leaf<->logical extent pointers to...
Xuehan Xu [Sat, 6 May 2023 09:26:18 +0000 (17:26 +0800)]
crimson/os/seastore/transaction_manager: follow leaf<->logical extent pointers to read extent

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/lba_manager: link lba leaf nodes with logical extents by pointers
Xuehan Xu [Tue, 25 Oct 2022 06:03:43 +0000 (14:03 +0800)]
crimson/os/seastore/lba_manager: link lba leaf nodes with logical extents by pointers

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/btree: "templatize" btree leaf node to distinguish leaf nodes...
Xuehan Xu [Thu, 27 Oct 2022 07:21:32 +0000 (15:21 +0800)]
crimson/os/seastore/btree: "templatize" btree leaf node to distinguish leaf nodes with(out) children

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/btree: link fixed-kv-btree and root_block with pointers
Xuehan Xu [Thu, 20 Oct 2022 09:41:25 +0000 (17:41 +0800)]
crimson/os/seastore/btree: link fixed-kv-btree and root_block with pointers

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore: more debug logs
Xuehan Xu [Thu, 20 Oct 2022 05:35:08 +0000 (13:35 +0800)]
crimson/os/seastore: more debug logs

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/backref_manager: retrieve live backref extents throught the backr...
Xuehan Xu [Wed, 17 Aug 2022 10:07:42 +0000 (18:07 +0800)]
crimson/os/seastore/backref_manager: retrieve live backref extents throught the backref tree

After involving intra-fixed-kv-btree parent-child pointers, we need to keep the
invariant that it's only when extents are not in transactions' read_set that
we can directly query cache with inspecting the transaction

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/btree: avoid searching transactions' read_set when retrieving...
Xuehan Xu [Thu, 13 Oct 2022 06:27:34 +0000 (14:27 +0800)]
crimson/os/seastore/btree: avoid searching transactions' read_set when retrieving btree nodes

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/btree: search fixed-kv-btree by parent<->child pointers
Xuehan Xu [Thu, 13 Oct 2022 03:50:17 +0000 (11:50 +0800)]
crimson/os/seastore/btree: search fixed-kv-btree by parent<->child pointers

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/cache: invalidate out-dated extent when initiating Cache
Xuehan Xu [Thu, 13 Oct 2022 02:57:09 +0000 (10:57 +0800)]
crimson/os/seastore/cache: invalidate out-dated extent when initiating Cache

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agocrimson/os/seastore/cached_extent: improve the representation of "has_been_invalidated"
Xuehan Xu [Wed, 12 Oct 2022 06:37:39 +0000 (14:37 +0800)]
crimson/os/seastore/cached_extent: improve the representation of "has_been_invalidated"

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>