]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc/rados: line-edit devices.rst 51576/head
Zac Dover [Thu, 18 May 2023 14:13:41 +0000 (00:13 +1000)]
doc/rados: line-edit devices.rst

Edit doc/rados/operations/devices.rst.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8d589b43d76a4e291c96c3750d068dba18eb9309)

2 years agoMerge pull request #51489 from zdover23/wip-doc-2023-05-16-backport-51485-to-reef
zdover23 [Thu, 18 May 2023 14:50:11 +0000 (00:50 +1000)]
Merge pull request #51489 from zdover23/wip-doc-2023-05-16-backport-51485-to-reef

reef: doc/start/os-recommendations: drop 4.14 kernel and reword guidance

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #51483 from cbodley/wip-59609-reef
Yuri Weinstein [Thu, 18 May 2023 14:26:41 +0000 (07:26 -0700)]
Merge pull request #51483 from cbodley/wip-59609-reef

reef: rgw: add crypt attrs for iam policy to PostObj and Init/CompleteMultipart

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #51482 from cbodley/wip-59614-reef
Yuri Weinstein [Thu, 18 May 2023 14:26:07 +0000 (07:26 -0700)]
Merge pull request #51482 from cbodley/wip-59614-reef

reef: rgw/s3: dump Message field in Error response even if empty

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #51481 from cbodley/wip-59611-reef
Yuri Weinstein [Thu, 18 May 2023 14:25:09 +0000 (07:25 -0700)]
Merge pull request #51481 from cbodley/wip-59611-reef

reef: rgw/sts: AssumeRole no longer writes to user metadata

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #51542 from zdover23/wip-doc-2023-05-18-backport-51534-to-reef
Anthony D'Atri [Wed, 17 May 2023 22:43:32 +0000 (18:43 -0400)]
Merge pull request #51542 from zdover23/wip-doc-2023-05-18-backport-51534-to-reef

reef: doc/cephfs: line-edit "Mirroring Module"

2 years agodoc/cephfs: line-edit "Mirroring Module" 51542/head
Zac Dover [Wed, 17 May 2023 12:25:38 +0000 (22:25 +1000)]
doc/cephfs: line-edit "Mirroring Module"

Line-edit the "Mirroring Module" section of
doc/cephfs/cephfs-mirroring.rst. Add prompts and formatting where such
things contribute to the realization of adequate sentences.

This commit is a follow-up to https://github.com/ceph/ceph/pull/51505.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dd8855d9a934bcdd6a026f1308ba7410b1e143e3)

2 years agoMerge pull request #51042 from kotreshhr/wip-59415-reef
Yuri Weinstein [Wed, 17 May 2023 15:33:39 +0000 (08:33 -0700)]
Merge pull request #51042 from kotreshhr/wip-59415-reef

reef: mgr: Add one finisher thread per module

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51520 from zdover23/wip-doc-2023-05-17-backport-51505-to-reef
Anthony D'Atri [Wed, 17 May 2023 12:56:13 +0000 (08:56 -0400)]
Merge pull request #51520 from zdover23/wip-doc-2023-05-17-backport-51505-to-reef

reef: doc: explain cephfs mirroring `peer_add` step in detail

2 years agodoc: explain cephfs mirroring `peer_add` step in detail 51520/head
Venky Shankar [Tue, 16 May 2023 05:25:34 +0000 (10:55 +0530)]
doc: explain cephfs mirroring `peer_add` step in detail

@zdover23 reached out regarding missing explanation for `peer_add`
step in cephfs mirroring documentation. Add some explanation and
and example to make the step clear.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 6a6e887ff1f7f7d76db7f30f8410783b2f8153b0)

2 years agoMerge pull request #51502 from zdover23/wip-doc-2023-05-16-backport-51492-to-reef
Anthony D'Atri [Wed, 17 May 2023 00:49:40 +0000 (20:49 -0400)]
Merge pull request #51502 from zdover23/wip-doc-2023-05-16-backport-51492-to-reef

reef: doc/start: KRBD feature flag support note

2 years agoMerge pull request #50808 from dparmar18/wip-59251-reef
Yuri Weinstein [Tue, 16 May 2023 19:10:22 +0000 (12:10 -0700)]
Merge pull request #50808 from dparmar18/wip-59251-reef

reef: mgr/nfs: disallow non-existent paths when creating export

Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #50782 from batrick/i59227
Yuri Weinstein [Tue, 16 May 2023 19:09:25 +0000 (12:09 -0700)]
Merge pull request #50782 from batrick/i59227

reef: cephfs-data-scan: does not scan_links for lost+found

Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #51047 from mchangir/wip-59430-reef
Yuri Weinstein [Tue, 16 May 2023 18:36:17 +0000 (11:36 -0700)]
Merge pull request #51047 from mchangir/wip-59430-reef

reef: qa: avoid explicit set to client mountpoint as "/"

Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #51003 from joscollin/wip-59406-reef
Yuri Weinstein [Tue, 16 May 2023 18:35:30 +0000 (11:35 -0700)]
Merge pull request #51003 from joscollin/wip-59406-reef

reef: cephfs-top: navigate to home screen when no fs

Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #50998 from neesingh-rh/wip-59397-reef
Yuri Weinstein [Tue, 16 May 2023 18:33:11 +0000 (11:33 -0700)]
Merge pull request #50998 from neesingh-rh/wip-59397-reef

reef: cephfs-top: fixing the -d [--delay] option in cephfs-top

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #50524 from trociny/wip-59020-reef
Yuri Weinstein [Tue, 16 May 2023 18:31:29 +0000 (11:31 -0700)]
Merge pull request #50524 from trociny/wip-59020-reef

reef: tools/cephfs-data-scan: support for multi-datapool

Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #51364 from rhcs-dashboard/reef-ceph-authx-backports
Nizamudeen A [Tue, 16 May 2023 07:19:36 +0000 (12:49 +0530)]
Merge pull request #51364 from rhcs-dashboard/reef-ceph-authx-backports

reef: mgr/dashboard: crud component, ceph authx and create rgw role features

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agodoc/start: KRBD feature flag support note 51502/head
Zac Dover [Mon, 15 May 2023 17:04:43 +0000 (03:04 +1000)]
doc/start: KRBD feature flag support note

Add KRBD feature flag support note to doc/start/os-recommendations.rst.

This change was suggested by Anthony D'Atri in https://github.com/ceph/ceph/pull/51485.

Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2a619dba2d22749e6facaf8dd0d370e16a1672c4)

2 years agoMerge pull request #51477 from zdover23/wip-doc-2023-05-15-backport-51473-to-reef
Anthony D'Atri [Mon, 15 May 2023 16:51:31 +0000 (12:51 -0400)]
Merge pull request #51477 from zdover23/wip-doc-2023-05-15-backport-51473-to-reef

reef: doc/rados: edit devices.rst

2 years agodoc/start/os-recommendations: drop 4.14 kernel and reword guidance 51489/head
Ilya Dryomov [Fri, 12 May 2023 11:55:32 +0000 (13:55 +0200)]
doc/start/os-recommendations: drop 4.14 kernel and reword guidance

The 4.14 LTS kernel has less than a year left in terms of maintenance,
drop it.

Also, the current wording with an explicit list of kernels tends to go
stale: it's missing the latest 6.1 LTS kernel.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b697f96f3872f178f024e85799445386204a96e1)

2 years agorgw/op: Init/CompleteMultipart add crypt attrs for iam policy 51483/head
Casey Bodley [Thu, 6 Apr 2023 15:29:55 +0000 (11:29 -0400)]
rgw/op: Init/CompleteMultipart add crypt attrs for iam policy

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 4cc6e05a7a550b277c22ac43f2088fe7a0423716)

2 years agorgw/op: RGWPostObj adds crypt attrs for iam policy
Casey Bodley [Thu, 6 Apr 2023 15:28:25 +0000 (11:28 -0400)]
rgw/op: RGWPostObj adds crypt attrs for iam policy

Fixes: https://tracker.ceph.com/issues/58594
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit c224bae02218b574f360cb718feb8f2a50f7ac7e)

2 years agorgw/op: factor out rgw_iam_add_crypt_attrs()
Casey Bodley [Thu, 6 Apr 2023 14:53:52 +0000 (10:53 -0400)]
rgw/op: factor out rgw_iam_add_crypt_attrs()

make the iam environment variables for server-side encryption available
to other ops

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 3b517a2679c62529950cd66136f9fb971ae612cc)

2 years agorgw/s3: dump Message field in Error response even if empty 51482/head
Casey Bodley [Wed, 12 Apr 2023 15:18:15 +0000 (11:18 -0400)]
rgw/s3: dump Message field in Error response even if empty

some clients like veeam fail to decode the response if Message is missing

Fixes: https://tracker.ceph.com/issues/59433
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 6de9e376b61fc11be9033a03d027dd0fa7f200ad)

2 years agorgw: remove RGWUserInfo::assumed_role_arn 51481/head
Casey Bodley [Thu, 20 Apr 2023 13:32:08 +0000 (09:32 -0400)]
rgw: remove RGWUserInfo::assumed_role_arn

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit af5f9cabb90e574c6fab33f1c9273cc868c6da22)

2 years agorgw/dbstore: stop storing RGWUserInfo::assumed_role_arn
Casey Bodley [Thu, 20 Apr 2023 13:31:52 +0000 (09:31 -0400)]
rgw/dbstore: stop storing RGWUserInfo::assumed_role_arn

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 9da31205051db56edade69b1cec3a05e162b7a9b)

2 years agorgw/sts: AssumeRole no longer writes to user metadata
Casey Bodley [Thu, 20 Apr 2023 13:25:49 +0000 (09:25 -0400)]
rgw/sts: AssumeRole no longer writes to user metadata

`storeARN()` was storing the role's ARN in `RGWUserInfo::assumed_role_arn`,
but that field was unused

Fixes: https://tracker.ceph.com/issues/59495
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 2f60200bf69b0814ce7d1ae7d217d5c37f99f80e)

2 years agodoc/rados: edit devices.rst 51477/head
Zac Dover [Mon, 15 May 2023 01:01:19 +0000 (11:01 +1000)]
doc/rados: edit devices.rst

Line-edit doc/rados/operations/devices.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8321b457a25a4394439f908c500091ce30e0736a)

2 years agoMerge pull request #51469 from zdover23/wip-doc-2023-05-14-backport-51175-to-reef
Anthony D'Atri [Sun, 14 May 2023 11:06:58 +0000 (07:06 -0400)]
Merge pull request #51469 from zdover23/wip-doc-2023-05-14-backport-51175-to-reef

reef: doc: add link to "documenting ceph" to index.rst

2 years agodoc: add link to "documenting ceph" to index.rst 51469/head
Zac Dover [Fri, 21 Apr 2023 20:59:04 +0000 (22:59 +0200)]
doc: add link to "documenting ceph" to index.rst

Add a link to the landing page of docs.ceph.com to direct documentation
contributors to documentation-related information.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 155a382cb2e8b80dca260ca7abdc3cc89c805edb)

2 years agoMerge pull request #51465 from zdover23/wip-doc-2023-05-13-backport-51463-to-reef
Anthony D'Atri [Sat, 13 May 2023 11:40:13 +0000 (07:40 -0400)]
Merge pull request #51465 from zdover23/wip-doc-2023-05-13-backport-51463-to-reef

reef: doc/cephfs: edit fs-volumes.rst (1 of x)

2 years agodoc/cephfs: edit fs-volumes.rst (1 of x) 51465/head
Zac Dover [Fri, 12 May 2023 15:49:14 +0000 (01:49 +1000)]
doc/cephfs: edit fs-volumes.rst (1 of x)

Edit the syntax of the English language in the file
doc/cephfs/fs-volumes.rst up to (but not including) the section called
"FS Subvolumes".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a1184070a1a3d2f6c1462c62f88fe70df5626c36)

2 years agoMerge pull request #51461 from zdover23/wip-doc-2023-05-12-backport-51458-to-reef
zdover23 [Fri, 12 May 2023 13:28:48 +0000 (23:28 +1000)]
Merge pull request #51461 from zdover23/wip-doc-2023-05-12-backport-51458-to-reef

reef: doc/cephfs: rectify prompts in fs-volumes.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/cephfs: rectify prompts in fs-volumes.rst 51461/head
Zac Dover [Fri, 12 May 2023 10:35:25 +0000 (20:35 +1000)]
doc/cephfs: rectify prompts in fs-volumes.rst

Make sure all prompts are unselectable. This PR is meant to be
backported to Reef, Quincy, and Pacific, to get all of the prompts into
a fit state so that a line-edit can be performed on the Englsh language
in this file.

Follows https://github.com/ceph/ceph/pull/51427.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1f88f10fe6d2069d3d474fe490e69a809afb1f56)

2 years agoMerge pull request #51434 from zdover23/wip-doc-2023-05-11-backport-51427-to-reef
zdover23 [Fri, 12 May 2023 10:31:35 +0000 (20:31 +1000)]
Merge pull request #51434 from zdover23/wip-doc-2023-05-11-backport-51427-to-reef

reef: doc/cephfs: fix prompts in fs-volumes.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephfs: fix prompts in fs-volumes.rst 51434/head
Zac Dover [Wed, 10 May 2023 14:52:50 +0000 (00:52 +1000)]
doc/cephfs: fix prompts in fs-volumes.rst

Fixed a regression introduced in
e5355e3d66e1438d51de6b57eae79fab47cd0184 that broke the unselectable
prompts in the RST.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e019948783adf41207d70e8cd2540d335e07b80b)

2 years agoMerge pull request #51419 from zdover23/wip-doc-2023-05-10-backport-51403-to-reef
Anthony D'Atri [Wed, 10 May 2023 12:23:50 +0000 (08:23 -0400)]
Merge pull request #51419 from zdover23/wip-doc-2023-05-10-backport-51403-to-reef

reef: doc/start: fix "Planet Ceph" link

2 years agodoc/start: fix "Planet Ceph" link 51419/head
Zac Dover [Tue, 9 May 2023 03:39:10 +0000 (13:39 +1000)]
doc/start: fix "Planet Ceph" link

Fix a link to Planet Ceph on the doc/start/get-involved.rst page.

Reported 2023 Apr 21, here:
https://pad.ceph.com/p/Report_Documentation_Bugs

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 67ebc206648144e533b627b9c22f29695764b26b)

2 years agoMerge pull request #51016 from cbodley/wip-59351
Casey Bodley [Tue, 9 May 2023 14:30:26 +0000 (10:30 -0400)]
Merge pull request #51016 from cbodley/wip-59351

reef: fmt: remove FMT_HEADER_ONLY defines

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51397 from zdover23/wip-doc-2023-05-09-backport-51394-to-reef
Anthony D'Atri [Tue, 9 May 2023 08:47:51 +0000 (04:47 -0400)]
Merge pull request #51397 from zdover23/wip-doc-2023-05-09-backport-51394-to-reef

reef: doc/dev/encoding.txt: update per std::optional

2 years agoMerge pull request #51400 from zdover23/wip-doc-2023-05-09-backport-51392-to-reef
Anthony D'Atri [Tue, 9 May 2023 08:38:17 +0000 (04:38 -0400)]
Merge pull request #51400 from zdover23/wip-doc-2023-05-09-backport-51392-to-reef

reef: doc: update multisite doc

2 years agodoc: update multisite doc 51400/head
parth-gr [Mon, 8 May 2023 13:53:29 +0000 (19:23 +0530)]
doc: update multisite doc

cmd for getting zone group was spelled incorrectly
Updated to rdosgw-admin

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit edab93b2f15b19f05a86aab499ba11b56135aaf3)

2 years agodoc/dev/encoding.txt: update per std::optional 51397/head
Radoslaw Zarzynski [Mon, 8 May 2023 14:41:22 +0000 (14:41 +0000)]
doc/dev/encoding.txt: update per std::optional

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 622829cebcca8ae4ec6f0463a4d74c909998a92d)

2 years agoMerge pull request #51263 from sseshasa/wip-reef-fix-mclk-rec-backfill-cost
Radoslaw Zarzynski [Mon, 8 May 2023 18:23:32 +0000 (20:23 +0200)]
Merge pull request #51263 from sseshasa/wip-reef-fix-mclk-rec-backfill-cost

reef: osd: mClock recovery/backfill cost fixes

Reviewed-by: Sam Just <sjust@redhat.com>
2 years agoMerge pull request #51389 from zdover23/wip-doc-2023-05-08-backport-51387-to-reef
zdover23 [Mon, 8 May 2023 13:37:03 +0000 (23:37 +1000)]
Merge pull request #51389 from zdover23/wip-doc-2023-05-08-backport-51387-to-reef

reef: doc/rados: stretch-mode.rst (other commands)

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/rados: stretch-mode.rst (other commands) 51389/head
Zac Dover [Mon, 8 May 2023 11:08:49 +0000 (21:08 +1000)]
doc/rados: stretch-mode.rst (other commands)

Edit the "Other Commands" section of
doc/rados/operations/stretch-mode.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fde33f1a5b8dbd03c096140887e04038a82f3076)

2 years agoMerge pull request #51371 from zdover23/wip-doc-2023-05-06-backport-51359-to-reef
zdover23 [Mon, 8 May 2023 12:41:55 +0000 (22:41 +1000)]
Merge pull request #51371 from zdover23/wip-doc-2023-05-06-backport-51359-to-reef

reef: doc/cephfs: repairing inaccessible FSes

Reviewed-by: Svelar <sunrongqi@huawei.com>
2 years agoMerge pull request #51377 from zdover23/wip-doc-2023-05-07-backport-51322-to-reef
Anthony D'Atri [Sun, 7 May 2023 10:37:21 +0000 (06:37 -0400)]
Merge pull request #51377 from zdover23/wip-doc-2023-05-07-backport-51322-to-reef

reef: doc/rados: stretch-mode: stretch cluster issues

2 years agodoc/rados: stretch-mode: stretch cluster issues 51377/head
Zac Dover [Wed, 3 May 2023 05:16:07 +0000 (15:16 +1000)]
doc/rados: stretch-mode: stretch cluster issues

Edit "Stretch Cluster Issues", which might better be called "Netsplits"
or "Recognizing Netsplits".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6c1baffb85556120672b45cce89b93a20e7b09a2)

2 years agodoc/cephfs: repairing inaccessible FSes 51371/head
Zac Dover [Fri, 5 May 2023 06:35:28 +0000 (16:35 +1000)]
doc/cephfs: repairing inaccessible FSes

Add a procedure to doc/cephfs/troubleshooting.rst that explains how to
restore access to FileSystems that became inaccessible after
post-Nautilus upgrades. The procedure included here was written by Harry
G Coin, and merely lightly edited by me. I include him here as a
"co-author", but it should be noted that he did the heavy lifting on
this.

See the email thread here for more context:
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/HS5FD3QFR77NAKJ43M2T5ZC25UYXFLNW/

Co-authored-by: Harry G Coin <hgcoin@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51253 from rhcs-dashboard/fix-pg-imbalancy-reef
Nizamudeen A [Fri, 5 May 2023 15:19:21 +0000 (20:49 +0530)]
Merge pull request #51253 from rhcs-dashboard/fix-pg-imbalancy-reef

reef: mgr/dashboard: fix CephPGImbalance alert

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agomgr/dashboard: Edit ceph authx users 51364/head
Pedro Gonzalez Gomez [Mon, 20 Feb 2023 13:37:00 +0000 (14:37 +0100)]
mgr/dashboard: Edit ceph authx users

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 8177a748bd831568417df5c687109fbbbd9b981d)

2 years agomgr/dashboard: import/export authx users
Pere Diaz Bou [Thu, 6 Apr 2023 14:24:03 +0000 (16:24 +0200)]
mgr/dashboard: import/export authx users

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Fixes: https://tracker.ceph.com/issues/59486
(cherry picked from commit 62d762f6965c5b8585d223c06cb23071a856cfcb)

2 years agomgr/dashboard: delete-ceph-authx
Pedro Gonzalez Gomez [Thu, 6 Apr 2023 14:18:41 +0000 (16:18 +0200)]
mgr/dashboard: delete-ceph-authx

Fixes: https://tracker.ceph.com/issues/59365
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 6b5a00fb8e8b9a72d9308a069763dd86e9ecd153)

2 years agomgr/dashboard: rgw role creation form
Pere Diaz Bou [Thu, 2 Mar 2023 12:17:25 +0000 (13:17 +0100)]
mgr/dashboard: rgw role creation form

Fixes: https://tracker.ceph.com/issues/59187
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit bd0eb20c673d54b9be3440decc0f3a1449153385)

2 years agomgr/dashboard: replace ajsf with formly
Pere Diaz Bou [Mon, 6 Mar 2023 19:32:24 +0000 (20:32 +0100)]
mgr/dashboard: replace ajsf with formly

ajsf json schema library for angular doesn't seem to be actively
maintained. Instead, fromly is a well maintained replacement with extra
stuff like validators builtin, support for json schemas, custom
components, etc...

Textareas weren't supported on ajsf, therefore, it made sense to move to
this dep instead.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 2c43dd0c16e3cc3b3eada03ed11958a689cc4bcd)

2 years agoMerge pull request #51111 from rhcs-dashboard/wip-59458-reef
Nizamudeen A [Fri, 5 May 2023 05:25:36 +0000 (10:55 +0530)]
Merge pull request #51111 from rhcs-dashboard/wip-59458-reef

reef: mgr/dashboard: expose more grafana configs in service form

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51349 from zdover23/wip-doc-2023-05-05-backport-51348-to-reef
Anthony D'Atri [Fri, 5 May 2023 03:10:51 +0000 (23:10 -0400)]
Merge pull request #51349 from zdover23/wip-doc-2023-05-05-backport-51348-to-reef

reef: doc: Use `ceph osd crush tree` command to display weight set weights

2 years agodoc: Use `ceph osd crush tree` command to display weight set weights 51349/head
James Lakin [Thu, 4 May 2023 17:02:36 +0000 (18:02 +0100)]
doc: Use `ceph osd crush tree` command to display weight set weights

The previous `ceph osd tree` doesn't show pool-defined weight-sets as the above documentation suggests.

Signed-off-by: James Lakin <james@jameslakin.co.uk>
(cherry picked from commit 15c3d72a43a37798de823b26f1429f7776f67aaa)

2 years agoMerge pull request #51165 from rhcs-dashboard/wip-59503-reef
Nizamudeen A [Thu, 4 May 2023 15:36:31 +0000 (21:06 +0530)]
Merge pull request #51165 from rhcs-dashboard/wip-59503-reef

reef: mgr/dashboard: hide notification on force promote

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #50881 from adk3798/reef-backport-49969-50100-50270-50101-50244...
Adam King [Thu, 4 May 2023 14:04:54 +0000 (10:04 -0400)]
Merge pull request #50881 from adk3798/reef-backport-49969-50100-50270-50101-50244-50133-50133-50413-50318-50082-

reef: mgr/cephadm: Reef Batch Backport

Reviewed-by: Teoman ONAY <tonay@ibm.com>
2 years agoMerge pull request #51337 from zdover23/wip-doc-2023-05-04-backport-51292-to-reef
Anthony D'Atri [Thu, 4 May 2023 02:18:43 +0000 (22:18 -0400)]
Merge pull request #51337 from zdover23/wip-doc-2023-05-04-backport-51292-to-reef

reef: doc/rados: edit stretch-mode.rst

2 years agodoc/rados: edit stretch-mode.rst 51337/head
Zac Dover [Sun, 30 Apr 2023 02:09:51 +0000 (12:09 +1000)]
doc/rados: edit stretch-mode.rst

Edit "Stretch Mode Limitations" (renamed "Limitations of Stretch Mode"
in this commit) in doc/rados/operations/stretch-mode.rst.

Co-authored-by: Greg Farnum <gfarnum@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 410e2a181c3247d13a1b20d80c4bcbbc1a5f84da)

2 years agoMerge pull request #50978 from batrick/i59295
Yuri Weinstein [Wed, 3 May 2023 22:12:22 +0000 (15:12 -0700)]
Merge pull request #50978 from batrick/i59295

reef: MgrMonitor: batch commit OSDMap and MgrMap mutations

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #50963 from ajarr/wip-58999-reef
Yuri Weinstein [Wed, 3 May 2023 22:11:06 +0000 (15:11 -0700)]
Merge pull request #50963 from ajarr/wip-58999-reef

reef: mgr: store names of modules that register RADOS clients in the MgrMap

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #51061 from mkogan1/wip-50842-reef
Casey Bodley [Wed, 3 May 2023 21:36:23 +0000 (17:36 -0400)]
Merge pull request #51061 from mkogan1/wip-50842-reef

reef: rgw : fix python script using s3cmd with error code 403 ubuntu 20.04

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agorgw : fix python script using s3cmd with error code 403 ubuntu 20.04 51061/head
Mark Kogan [Sun, 2 Apr 2023 13:23:25 +0000 (16:23 +0300)]
rgw : fix python script using s3cmd with error code 403 ubuntu 20.04

Fixes: https://tracker.ceph.com/issues/54104
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit 5846a9c2677067516f98d502980dab1681cddb69)

2 years agoMerge pull request #51334 from ljflores/wip-59600-reef
Laura Flores [Wed, 3 May 2023 18:38:21 +0000 (13:38 -0500)]
Merge pull request #51334 from ljflores/wip-59600-reef

reef: mgr: add urllib3==1.26.15 to mgr/requirements.txt

2 years agomgr: add urllib3==1.26.15 to mgr/requirements.txt 51334/head
Laura Flores [Mon, 1 May 2023 16:28:54 +0000 (16:28 +0000)]
mgr: add urllib3==1.26.15 to mgr/requirements.txt

We do not depend on any particular version of
urllib3, but as a workaround to the incompatibility
of urllib3 constraints between kubernetes and
requests, we need to pin it temporarily to
the version both are happy with.

Fixes: https://tracker.ceph.com/issues/59591
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 80d460005e44649191aa862fa78bd278644b5237)

2 years agocephfs-top: fix help text for delay 50998/head
Jos Collin [Thu, 20 Apr 2023 09:39:01 +0000 (15:09 +0530)]
cephfs-top: fix help text for delay

Updates:

`
  -d {1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25}, --delay {1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25}
                        Refresh interval in seconds (default: 1)
`

to

`
  -d DELAY, --delay DELAY
                        Refresh interval in seconds (default: 1, range: 1 - 25)
`

Fixes: https://tracker.ceph.com/issues/59553
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 10a74b9f09b8e1402e421503d5ff23a44416bf15)

2 years agoMerge pull request #51309 from zdover23/wip-doc-2023-05-02-backport-51133-to-reef
zdover23 [Tue, 2 May 2023 22:25:04 +0000 (08:25 +1000)]
Merge pull request #51309 from zdover23/wip-doc-2023-05-02-backport-51133-to-reef

reef: doc/mgr: update prompts in prometheus.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agoMerge pull request #50631 from trociny/wip-59130-reef
Adam King [Tue, 2 May 2023 21:48:25 +0000 (17:48 -0400)]
Merge pull request #50631 from trociny/wip-59130-reef

reef: mgr/cephadm: don't add mgr into iscsi trusted_ip_list if it's already there

Reviewed-by: Adam King <adking@redhat.com>
2 years agoqa: fix test_nfs_export_creation_at_symlink 50808/head
Dhairya Parmar [Wed, 26 Apr 2023 07:51:28 +0000 (13:21 +0530)]
qa: fix test_nfs_export_creation_at_symlink

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 7a6ab31)

2 years agoqa: update test cases to check for ENOTDIR instead of EINVAL
Dhairya Parmar [Wed, 12 Apr 2023 07:57:53 +0000 (13:27 +0530)]
qa: update test cases to check for ENOTDIR instead of EINVAL

- test_nfs_export_creation_at_filepath:
ENOTDIR is raised instead of EINVAL which is better
aligned with the nature of the failure

- test_nfs_export_creation_at_symlink:
ENOTDIR is raised instead of ENOENT since the code
can now check if the path is symlink but won't follow
it.

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 0c89625)

2 years agoqa: fix test_nfs_export_with_invalid_path
Dhairya Parmar [Tue, 11 Apr 2023 12:14:41 +0000 (17:44 +0530)]
qa: fix test_nfs_export_with_invalid_path

It actually didn't test the invalid path but still ended with
ENOENT(which is expected in case path is invalid) as the test
didn't create a fs, and it failed saying "FS nfs-cephfs not found"
which too raises ENOENT and thus it always passed.

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 5cc0857)

2 years agomgr/nfs: handle exceptions for cephfs_path_is_dir()
Dhairya Parmar [Tue, 11 Apr 2023 10:09:00 +0000 (15:39 +0530)]
mgr/nfs: handle exceptions for cephfs_path_is_dir()
in create_cephfs_export()

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit d759fe4103174d412cc1ba317390383b299a7d35)

2 years agomgr/nfs/utils: changes to helper func to check cephfs path
Dhairya Parmar [Tue, 11 Apr 2023 10:06:52 +0000 (15:36 +0530)]
mgr/nfs/utils: changes to helper func to check cephfs path

- Renamed to cephfs_path_is_dir

- Removed exception handling to prevent redundant log statements like:
   "No such file or directory error in stat: b'/mnt/testdir_symlink': No such file or directory [Errno 2]"

  Exceptions handled inside caller eliminates this redundancy

- Set modifier flag AT_SYMLINK_NOFOLLOW

- Removed string "{path} is not a dir" when raising NotADirectoryError
  Rationale: will be handled in export.py

- change mock to cephfs_path_is_dir

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit f3d7370)

2 years agodoc/mgr: update prompts in prometheus.rst 51309/head
Zac Dover [Tue, 18 Apr 2023 14:28:50 +0000 (16:28 +0200)]
doc/mgr: update prompts in prometheus.rst

Update prompts in prometheus.rst so that they're unselectable.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5a90d64b343f158d43397c70c267deb4e7ef0e00)

2 years agoMerge pull request #51305 from zdover23/wip-doc-2023-05-02-backport-51299-to-reef
Anthony D'Atri [Mon, 1 May 2023 23:25:48 +0000 (19:25 -0400)]
Merge pull request #51305 from zdover23/wip-doc-2023-05-02-backport-51299-to-reef

reef: doc/radosgw: rabbitmq - push-endpoint edit

2 years agodoc/radosgw: rabbitmq - push-endpoint edit 51305/head
Zac Dover [Mon, 1 May 2023 17:14:01 +0000 (03:14 +1000)]
doc/radosgw: rabbitmq - push-endpoint edit

Remove a note that directed users to change "push-endpoint" (with a
hyphen) to "push_endpoint" (with an underscore) when using rabbitmq.

Re: https://github.com/ceph/ceph/pull/48486#issuecomment-1529925389

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e4b35de2abf00d514c76f77645c587c562bab05d)

2 years agoMerge pull request #51302 from zdover23/wip-doc-2023-05-02-backport-51296-to-reef
Anthony D'Atri [Mon, 1 May 2023 20:35:51 +0000 (16:35 -0400)]
Merge pull request #51302 from zdover23/wip-doc-2023-05-02-backport-51296-to-reef

reef: doc/rados: edit stretch-mode.rst

2 years agodoc/rados: edit stretch-mode.rst 51302/head
Zac Dover [Mon, 1 May 2023 02:29:07 +0000 (12:29 +1000)]
doc/rados: edit stretch-mode.rst

Refine and supplement the introductory and explanatory text at the top
of the /doc/rados/operations/stretch-mode.rst file.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b642900abc57302e62a5064dba510c3cc5743ac0)

2 years agoqa/: Override mClock profile to 'high_recovery_ops' for qa tests 51263/head
Sridhar Seshasayee [Sat, 29 Apr 2023 04:48:11 +0000 (10:18 +0530)]
qa/: Override mClock profile to 'high_recovery_ops' for qa tests

The qa tests are not client I/O centric and mostly focus on triggering
recovery/backfills and monitor them for completion within a finite amount
of time. The same holds true for scrub operations.

Therefore, an mClock profile that optimizes background operations is a
better fit for qa related tests. The osd_mclock_profile is therefore
globally overriden to 'high_recovery_ops' profile for the Rados suite as
it fits the requirement.

Also, many standalone tests expect recovery and scrub operations to
complete within a finite time. To ensure this, the osd_mclock_profile
options is set to 'high_recovery_ops' as part of the run_osd() function
in ceph-helpers.sh.

A subset of standalone tests explicitly used 'high_recovery_ops' profile.
Since the profile is now set as part of run_osd(), the earlier overrides
are redundant and therefore removed from the tests.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agodoc/: Modify mClock configuration documentation to reflect profile changes
Sridhar Seshasayee [Tue, 11 Apr 2023 17:57:05 +0000 (23:27 +0530)]
doc/: Modify mClock configuration documentation to reflect profile changes

Modify the relevant documentation to reflect:

- change in the default mClock profile to 'balanced'
- new allocations for ops across mClock profiles
- change in the osd_max_backfills limit
- miscellaneous changes related to warnings.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agocommon/options/osd.yaml.in: Change mclock max sequential bandwidth for SSDs
Sridhar Seshasayee [Tue, 11 Apr 2023 16:47:53 +0000 (22:17 +0530)]
common/options/osd.yaml.in: Change mclock max sequential bandwidth for SSDs

The osd_mclock_max_sequential_bandwidth_ssd is changed to 1200 MiB/s as
a reasonable middle ground considering the broad range of SSD capabilities.
This allows the mClock's cost model to extract the SSDs capability
depending on the cost of the IO being performed.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agoosd/: Retain the default osd_max_backfills limit to 1 for mClock
Sridhar Seshasayee [Tue, 11 Apr 2023 16:30:11 +0000 (22:00 +0530)]
osd/: Retain the default osd_max_backfills limit to 1 for mClock

The earlier limit of 3 was still aggressive enough to have an impact on
the client and other competing operations. Retain the current default
for mClock. This can be modified if necessary after setting the
osd_mclock_override_recovery_settings option.

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agocommon/options/osd.yaml.in: change mclock profile default to balanced
Samuel Just [Tue, 11 Apr 2023 15:15:38 +0000 (08:15 -0700)]
common/options/osd.yaml.in: change mclock profile default to balanced

Let's use the middle profile as the default.
Modify the standalone tests accordingly.

Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agoMerge pull request #51289 from zdover23/wip-doc-2023-04-30-backport-51285-to-reef
Anthony D'Atri [Sat, 29 Apr 2023 20:00:57 +0000 (16:00 -0400)]
Merge pull request #51289 from zdover23/wip-doc-2023-04-30-backport-51285-to-reef

reef: doc/rados: edit stretch-mode procedure

2 years agodoc/rados: edit stretch-mode procedure 51289/head
Zac Dover [Sat, 29 Apr 2023 00:14:02 +0000 (10:14 +1000)]
doc/rados: edit stretch-mode procedure

Edit the "stretch mode" section in doc/rados/operations/stretch-mode.rst
so that the procedure is formatted as a procedure and the sentences
correctly have heads.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a19ff7a5ea9bbd24365648a90abfa1b720c5b231)

2 years agoMerge pull request #51286 from zdover23/wip-doc-2023-04-29-backport-51276-to-reef
zdover23 [Sat, 29 Apr 2023 17:32:04 +0000 (03:32 +1000)]
Merge pull request #51286 from zdover23/wip-doc-2023-04-29-backport-51276-to-reef

reef: docs: Update the Prometheus endpoint info

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodocs: Update the Prometheus endpoint info 51286/head
Paul Cuzner [Fri, 28 Apr 2023 05:21:39 +0000 (17:21 +1200)]
docs: Update the Prometheus endpoint info

This patch just tidies up some of the links and adds
an example showing how the http_sd_configs option
may be used.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit 690d34ab08f22cd988828aa2097531627000907e)

2 years agoMerge pull request #51272 from zdover23/wip-doc-2023-04-28-backport-51271-to-reef
Anthony D'Atri [Fri, 28 Apr 2023 00:53:50 +0000 (20:53 -0400)]
Merge pull request #51272 from zdover23/wip-doc-2023-04-28-backport-51271-to-reef

reef: doc/rados: m-config-ref: edit "background"

2 years agodoc/rados: m-config-ref: edit "background" 51272/head
Zac Dover [Thu, 27 Apr 2023 22:35:17 +0000 (08:35 +1000)]
doc/rados: m-config-ref: edit "background"

Edit the "Background" section of doc/rados/monitor/config-ref.rst

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9223863fc83095def59b416bf70f9a828a701ccc)

2 years agoMerge pull request #51148 from zdover23/wip-doc-2023-04-20-backport-51143-to-reef
zdover23 [Thu, 27 Apr 2023 20:41:03 +0000 (06:41 +1000)]
Merge pull request #51148 from zdover23/wip-doc-2023-04-20-backport-51143-to-reef

reef: docs: warning and remove few docs section for Filestore

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agodoc/man/rbd: resurrect filestore alloc_size note 51148/head
Ilya Dryomov [Thu, 20 Apr 2023 10:05:14 +0000 (12:05 +0200)]
doc/man/rbd: resurrect filestore alloc_size note

Mistakenly removed in commit d79f2a81541c ("docs: warning and remove
few docs section for Filestore Update docs after filestore removal.").
The kernel client, however new, will continue to be able to talk to
FileStore OSDs for as long as they exist.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit d3558c49bf0456a199cf55f73c5832f408462ec5)

2 years agoosd/scheduler/mClockScheduler: avoid limits for recovery
Samuel Just [Tue, 11 Apr 2023 15:10:04 +0000 (08:10 -0700)]
osd/scheduler/mClockScheduler: avoid limits for recovery

Now that recovery operations are split between background_recovery and
background_best_effort, rebalance qos params to avoid penalizing
background_recovery while idle.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/: add counters for ops delayed due to degraded|unreadable target
Samuel Just [Mon, 10 Apr 2023 21:18:49 +0000 (14:18 -0700)]
osd/: add counters for ops delayed due to degraded|unreadable target

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/: add counters for queue latency for PGRecovery[Context]
Samuel Just [Thu, 6 Apr 2023 21:15:02 +0000 (14:15 -0700)]
osd/: add counters for queue latency for PGRecovery[Context]

Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoosd/: add per-op latency averages for each recovery related message
Samuel Just [Thu, 6 Apr 2023 20:50:48 +0000 (20:50 +0000)]
osd/: add per-op latency averages for each recovery related message

Signed-off-by: Samuel Just <sjust@redhat.com>